Bug#717195: linux-kbuild-3.10: modpost wrapper crashes due to bad getline call

2013-07-17 Thread Aaron M. Ucko
Ben Hutchings  writes:

> Surprisingly, an amd64 build worked, so I didn't notice this.

No problem; I quite understand, as my own debugging inconveniently
encountered crashes *only* under module-assistant. :-/ I wound up
contriving to use a wrapper script that arranged to run the modpost
binary under Valgrind to help track the problem down.

-- 
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?a...@monk.mit.edu


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/udlsizc1w41@dr-wily.mit.edu



Bug#717195: linux-kbuild-3.10: modpost wrapper crashes due to bad getline call

2013-07-17 Thread Ben Hutchings
On Wed, 2013-07-17 at 15:54 -0400, Aaron M. Ucko wrote:
> Package: linux-kbuild-3.10
> Version: 3.10-1
> Severity: important
> 
> debian/build/scripts/mod/modpost passes getline pointers to
> uninitialized name and name_len variables, leading to crashes under
> some circumstances.  According to getline's manpage, initializing name
> to NULL should let the call reliably succeed, albeit with a memory
> leak (which you can probably ignore in this case).  Could you please
> look into it?

Sorry about that.  I had assumed that Chris's change to the modpost
wrapper was sufficient to make it work for 3.10, but then after
uploading linux I found that it wasn't.  So I was in a bit of a hurry to
get that done and upload linux-tools.  Surprisingly, an amd64 build
worked, so I didn't notice this.

Ben.

-- 
Ben Hutchings
Humans are not rational beings; they are rationalising beings.


signature.asc
Description: This is a digitally signed message part


Bug#717195: linux-kbuild-3.10: modpost wrapper crashes due to bad getline call

2013-07-17 Thread Aaron M. Ucko
Package: linux-kbuild-3.10
Version: 3.10-1
Severity: important

debian/build/scripts/mod/modpost passes getline pointers to
uninitialized name and name_len variables, leading to crashes under
some circumstances.  According to getline's manpage, initializing name
to NULL should let the call reliably succeed, albeit with a memory
leak (which you can probably ignore in this case).  Could you please
look into it?

Thanks!


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/20130717195450.30689.50316.report...@ghostwheel.internal.ucko.debian.net