Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-27 Thread John Paul Adrian Glaubitz 
On 04/21/2016 01:07 PM, John Paul Adrian Glaubitz wrote:
> On 04/21/2016 12:59 PM, Ben Hutchings wrote:
>> As you should know, our general policy is to wait for patches to be
>> applied by the subsystem maintainer.  Let us know when they are.
> 
> Ok, I wasn't aware of that. I will let you know once that has happened!

That has happened now:

>
http://git.kernel.org/cgit/linux/kernel/git/davem/sparc.git/commit/?id=5bde2c9be701c4583f0a9243bd46590ec401bfba
>
http://git.kernel.org/cgit/linux/kernel/git/davem/sparc.git/commit/?id=36128d204b81c099b5779771127a5546eac549c9

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



signature.asc
Description: OpenPGP digital signature

Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-21 Thread John Paul Adrian Glaubitz 
On 04/21/2016 12:59 PM, Ben Hutchings wrote:
> As you should know, our general policy is to wait for patches to be
> applied by the subsystem maintainer.  Let us know when they are.

Ok, I wasn't aware of that. I will let you know once that has happened!

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



signature.asc
Description: OpenPGP digital signature

Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-21 Thread Ben Hutchings 
On Thu, 2016-04-21 at 11:42 +0200, John Paul Adrian Glaubitz wrote:
> Control: retitle -1 linux: Please add autoloading support for vio
> 
> On 04/14/2016 11:19 AM, John Paul Adrian Glaubitz wrote:
> > 
> > On 04/14/2016 10:56 AM, John Paul Adrian Glaubitz wrote:
> > > 
> > > Hold on a second, I had a copy-and-paste error, the patch needs
> > > a slight update since __ATTR_RO(modalias) is misssing in
> > > vio_dev_attrs.
> > Attaching a cleaned up patch.
> Ping.
> 
> Can we get this patch merged or is there anything that needs further
> review or discussion? FWIW, the patch set has been acked upstream [1,2],
> but it has not been merged yet.
[...]

As you should know, our general policy is to wait for patches to be
applied by the subsystem maintainer.  Let us know when they are.

Ben.

-- 
Ben Hutchings
The program is absolutely right; therefore, the computer must be wrong.

signature.asc
Description: This is a digitally signed message part

Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-21 Thread John Paul Adrian Glaubitz 
Control: retitle -1 linux: Please add autoloading support for vio

On 04/14/2016 11:19 AM, John Paul Adrian Glaubitz wrote:
> On 04/14/2016 10:56 AM, John Paul Adrian Glaubitz wrote:
>> Hold on a second, I had a copy-and-paste error, the patch needs
>> a slight update since __ATTR_RO(modalias) is misssing in
>> vio_dev_attrs.
> 
> Attaching a cleaned up patch.

Ping.

Can we get this patch merged or is there anything that needs further
review or discussion? FWIW, the patch set has been acked upstream [1,2],
but it has not been merged yet.

It would be great to have this patch merged into the Debian kernel as
it fixes the issues people have when installing Debian in an LDOM.

Adrian

> [1] http://patchwork.ozlabs.org/patch/610563/
> [2] http://patchwork.ozlabs.org/patch/610562/

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



signature.asc
Description: OpenPGP digital signature

Processed: Re: Bug#815977 closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-21 Thread Debian Bug Tracking System 
Processing control commands:

> retitle -1 linux: Please add autoloading support for vio
Bug #815977 [src:linux] vio devices on SPARC do not have modaliases
Changed Bug title to 'linux: Please add autoloading support for vio' from 'vio 
devices on SPARC do not have modaliases'.

-- 
815977: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815977
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-14 Thread John Paul Adrian Glaubitz 
On 04/14/2016 10:56 AM, John Paul Adrian Glaubitz wrote:
> Hold on a second, I had a copy-and-paste error, the patch needs
> a slight update since __ATTR_RO(modalias) is misssing in
> vio_dev_attrs.

Attaching a cleaned up patch.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
From: John Paul Adrian Glaubitz 
Date: Thu, 14 Apr 2016 11:14:00 +0200
Subject: sparc: Enable autoloading for vio drivers.
Bug-Debian: https://bugs.debian.org/815977

The vio driver on sparc has been missing both modalias_show as
well as a hotplug event handler which are both required to
enable automatic loading for the vio modules. With this patch,
both sunvnet and sunvdc are loaded automatically which is
necessary when installing Debian in a sparc LDOM.

Signed-off-by: John Paul Adrian Glaubitz 

diff --git a/arch/sparc/kernel/vio.c b/arch/sparc/kernel/vio.c
index cb5789c..73b33b1 100644
--- a/arch/sparc/kernel/vio.c
+++ b/arch/sparc/kernel/vio.c
@@ -45,6 +45,14 @@ static const struct vio_device_id *vio_match_device(
 	return NULL;
 }
 
+static int vio_hotplug(struct device *dev, struct kobj_uevent_env *env)
+{
+	const struct vio_dev *vio_dev = to_vio_dev(dev);
+
+	add_uevent_var(env, "MODALIAS=vio:T%sS%s", vio_dev->type, vio_dev->compat);
+	return 0;
+}
+
 static int vio_bus_match(struct device *dev, struct device_driver *drv)
 {
 	struct vio_dev *vio_dev = to_vio_dev(dev);
@@ -105,15 +113,25 @@ static ssize_t type_show(struct device *dev,
 	return sprintf(buf, "%s\n", vdev->type);
 }
 
+static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,
+ char *buf)
+{
+	const struct vio_dev *vdev = to_vio_dev(dev);
+
+	return sprintf(buf, "vio:T%sS%s\n", vdev->type, vdev->compat);
+}
+
 static struct device_attribute vio_dev_attrs[] = {
 	__ATTR_RO(devspec),
 	__ATTR_RO(type),
+	__ATTR_RO(modalias),
 	__ATTR_NULL
 };
 
 static struct bus_type vio_bus_type = {
 	.name		= "vio",
 	.dev_attrs	= vio_dev_attrs,
+	.uevent = vio_hotplug,
 	.match		= vio_bus_match,
 	.probe		= vio_device_probe,
 	.remove		= vio_device_remove,


signature.asc
Description: OpenPGP digital signature

Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-14 Thread John Paul Adrian Glaubitz 
On 04/13/2016 05:27 PM, John Paul Adrian Glaubitz wrote:
> Ok, tested it and it didn't work unfortunately. The modules are
> not loaded automatically and it seems the reason is that the
> modaliases are not generated:

Hold on a second, I had a copy-and-paste error, the patch needs
a slight update since __ATTR_RO(modalias) is misssing in
vio_dev_attrs.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



signature.asc
Description: OpenPGP digital signature

Processed: Re: Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-13 Thread Debian Bug Tracking System 
Processing control commands:

> tags -1 patch
Bug #815977 [src:linux] vio devices on SPARC do not have modaliases
Added tag(s) patch.

-- 
815977: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815977
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-13 Thread John Paul Adrian Glaubitz 
Control: tags -1 patch

Hi Ben!

On 04/13/2016 05:40 PM, Ben Hutchings wrote:
> Try deleting the 'if (!cp)' block.

That wasn't enough. I invested some more time and now have a patch
that does the trick. Module aliases are created correctly and
module autoloading is working as expected. This has been tested
with Debian unstable and kernel 4.5.1 on a SPARC-T5 in a Linux
LDOM.

Attaching my patch. I also sent it as two single patches upstream.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
diff --git a/arch/sparc/kernel/vio.c b/arch/sparc/kernel/vio.c
index cb5789c..59f4b7c 100644
--- a/arch/sparc/kernel/vio.c
+++ b/arch/sparc/kernel/vio.c
@@ -45,6 +45,13 @@ static const struct vio_device_id *vio_match_device(
 	return NULL;
 }
 
+static int vio_hotplug(struct device *dev, struct kobj_uevent_env *env)
+{
+	const struct vio_dev *vio_dev = to_vio_dev(dev);
+	add_uevent_var(env, "MODALIAS=vio:T%sS%s", vio_dev->type, vio_dev->compat);
+	 return 0;
+}
+
 static int vio_bus_match(struct device *dev, struct device_driver *drv)
 {
 	struct vio_dev *vio_dev = to_vio_dev(dev);
@@ -105,6 +112,13 @@ static ssize_t type_show(struct device *dev,
 	return sprintf(buf, "%s\n", vdev->type);
 }
 
+static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,
+ char *buf)
+{
+	const struct vio_dev *vdev = to_vio_dev(dev);
+	return sprintf(buf, "vio:T%sS%s\n", vdev->type, vdev->compat);
+}
+
 static struct device_attribute vio_dev_attrs[] = {
 	__ATTR_RO(devspec),
 	__ATTR_RO(type),
@@ -114,6 +128,7 @@ static struct device_attribute vio_dev_attrs[] = {
 static struct bus_type vio_bus_type = {
 	.name		= "vio",
 	.dev_attrs	= vio_dev_attrs,
+	.uevent = vio_hotplug,
 	.match		= vio_bus_match,
 	.probe		= vio_device_probe,
 	.remove		= vio_device_remove,


signature.asc
Description: OpenPGP digital signature

Processed: Re: Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-13 Thread Debian Bug Tracking System 
Processing control commands:

> reopen -1
Bug #815977 {Done: Ben Hutchings } [src:linux] 
kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i
Bug reopened
Ignoring request to alter fixed versions of bug #815977 to the same values 
previously set
> retitle -1 vio devices on SPARC do not have modaliases
Bug #815977 [src:linux] kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and 
sunvdc for d-i
Changed Bug title to 'vio devices on SPARC do not have modaliases' from 
'kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i'.

-- 
815977: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815977
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-13 Thread Ben Hutchings 
Control: reopen -1
Control: retitle -1 vio devices on SPARC do not have modaliases

On Wed, 2016-04-13 at 17:27 +0200, John Paul Adrian Glaubitz wrote:
> On 04/13/2016 02:03 PM, John Paul Adrian Glaubitz wrote:
> > 
> > On 04/11/2016 01:32 AM, Ben Hutchings wrote:
> > > 
> > > The attached patch might fix that, though the correct fix would
> > > presumably be to merge the two implementations.
> > Thanks a lot for the explanation and the patch. I will test the
> > patch and then we can maybe decide if we include it as a work
> > around.
> Ok, tested it and it didn't work unfortunately. The modules are
> not loaded automatically and it seems the reason is that the
> modaliases are not generated:
> 
> root@deb4g:~# cat /sys/devices/channel-devices/vdc-port-0-0/modalias
> 
> root@deb4g:~#
> 
> Will do further debugging.

Try deleting the 'if (!cp)' block.

Ben.

-- 
Ben Hutchings
It is easier to change the specification to fit the program than vice versa.


signature.asc
Description: This is a digitally signed message part

Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-13 Thread John Paul Adrian Glaubitz 
On 04/13/2016 02:03 PM, John Paul Adrian Glaubitz wrote:
> On 04/11/2016 01:32 AM, Ben Hutchings wrote:
>> The attached patch might fix that, though the correct fix would
>> presumably be to merge the two implementations.
> 
> Thanks a lot for the explanation and the patch. I will test the
> patch and then we can maybe decide if we include it as a work
> around.

Ok, tested it and it didn't work unfortunately. The modules are
not loaded automatically and it seems the reason is that the
modaliases are not generated:

root@deb4g:~# cat /sys/devices/channel-devices/vdc-port-0-0/modalias

root@deb4g:~#

Will do further debugging.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



signature.asc
Description: OpenPGP digital signature

Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-13 Thread John Paul Adrian Glaubitz 
On 04/11/2016 01:32 AM, Ben Hutchings wrote:
> The attached patch might fix that, though the correct fix would
> presumably be to merge the two implementations.

Thanks a lot for the explanation and the patch. I will test the
patch and then we can maybe decide if we include it as a work
around.

I have also notified upstream and Dave Miller is now looking
at a proper fix.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



signature.asc
Description: OpenPGP digital signature

Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-10 Thread Ben Hutchings 
On Mon, 2016-04-11 at 00:02 +0200, John Paul Adrian Glaubitz wrote:
> On 04/10/2016 10:17 PM, Ben Hutchings wrote:
> > 
> > Like everything else in the installer initramfs, they are installed
> > from a udeb.  See build/pkg-lists/*/sparc64.cfg
> Yeah, I remember that now. Indeed, scsi-core-modules was missing.
> However, nic-modules was already there.
> 
> I rebuilt d-i now making sure both are present and created a new
> set of images. When booting on a SPARC-T5, the modules are just
> not loaded automatically.
[...]
> So, the question now is why those modules aren't loaded automatically
> when boot the debian-installer initrd and kernel.

That turns out to be quite simple:

- These are drivers for the vio bus, and the module aliases generated
  from their device ID tables have the form "vio:TS".
- The vio bus can exist on PowerPC and SPARC, and they have two
  separate (but similar) implementations.
- The PowerPC implementation generates module aliases for vio devices
  but the SPARC implementation does not.

So autoloading currently only works on PowerPC.

The attached patch might fix that, though the correct fix would
presumably be to merge the two implementations.

Ben.

-- 
Ben Hutchings
Humans are not rational beings; they are rationalising beings.From: Ben Hutchings 
Date: Mon, 11 Apr 2016 00:30:34 +0100
Subject: sparc: vio: Add modalias attribute to support auto-loading drivers
Bug-Debian: https://bugs.debian.org/815977

Add a modalias attribute for vio devices, matching the syntax
supported by file2alias and the PowerPC vio implementation.

Signed-off-by: Ben Hutchings 
---
--- a/arch/sparc/kernel/vio.c
+++ b/arch/sparc/kernel/vio.c
@@ -105,9 +105,31 @@ static ssize_t type_show(struct device *dev,
 	return sprintf(buf, "%s\n", vdev->type);
 }
 
+static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,
+			 char *buf)
+{
+	const struct vio_dev *vdev = to_vio_dev(dev);
+	struct device_node *dn;
+	const char *cp;
+
+	dn = dev->of_node;
+	if (!dn) {
+		strcpy(buf, "\n");
+		return strlen(buf);
+	}
+	cp = of_get_property(dn, "compatible", NULL);
+	if (!cp) {
+		strcpy(buf, "\n");
+		return strlen(buf);
+	}
+
+	return sprintf(buf, "vio:T%sS%s\n", vdev->type, cp);
+}
+
 static struct device_attribute vio_dev_attrs[] = {
 	__ATTR_RO(devspec),
 	__ATTR_RO(type),
+	__ATTR_RO(modalias),
 	__ATTR_NULL
 };
 


signature.asc
Description: This is a digitally signed message part

Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-10 Thread John Paul Adrian Glaubitz 
On 04/10/2016 10:17 PM, Ben Hutchings wrote:
> Like everything else in the installer initramfs, they are installed
> from a udeb.  See build/pkg-lists/*/sparc64.cfg

Yeah, I remember that now. Indeed, scsi-core-modules was missing.
However, nic-modules was already there.

I rebuilt d-i now making sure both are present and created a new
set of images. When booting on a SPARC-T5, the modules are just
not loaded automatically.

Dropping out of d-i into a shell and just loading the modules with
"modprobe sunvdc" and "modprobe sunvnet" works:

[3549345.279904] sunvdc.c:v1.2 (November 24, 2014)
[3549345.281060] sunvdc: Virtual Hard disk vdiska
[3549345.281064] sunvdc: vdiska: 20971520 sectors (10240 MB) protocol 1.1
[3549345.281610]  vdiska: vdiska1 vdiska2 vdiska3
[3549345.284722] sunvdc: Virtual CDROM vdiskb
[3549345.284727] sunvdc: vdiskb: 338864 sectors (165 MB) protocol 1.1
[3549345.285054]  vdiskb: vdiskb1 vdiskb2 vdiskb3 vdiskb4 vdiskb5
vdiskb6 vdiskb7
[3549361.270957] sunvnet.c:v1.0 (June 25, 2007)
[3549361.273663] vnet_port vnet-port-0-0 eth0: Sun LDOM vnet
00:14:4f:f8:57:82
[3549361.273720] sunvnet: eth0: PORT ( remote-mac XX:XX:XX:XX:XX:XX
switch-port )
[3549361.273930] sunvnet: eth0: PORT ( remote-mac XX:XX:XX:XX:XX:XX )
[3549361.273995] sunvnet: eth0: PORT ( remote-mac XX:XX:XX:XX:XX:XX )
[3549361.274055] sunvnet: eth0: PORT ( remote-mac XX:XX:XX:XX:XX:XX )
[3549361.274115] sunvnet: eth0: PORT ( remote-mac XX:XX:XX:XX:XX:XX )
[3549361.274175] sunvnet: eth0: PORT ( remote-mac XX:XX:XX:XX:XX:XX )

So, the question now is why those modules aren't loaded automatically
when boot the debian-installer initrd and kernel.

Adrian

PS: I replaced the actual MAC addresses above with "XX".

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



signature.asc
Description: OpenPGP digital signature

Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-10 Thread Ben Hutchings 
On Sun, 2016-04-10 at 21:03 +0200, John Paul Adrian Glaubitz wrote:
> On 04/10/2016 08:50 PM, Ben Hutchings wrote:
> > 
> > initramfs-tools has nothing to do with the installer initramfs.
> Hmm, ok. Then I'll need to keep digging in debian-installer. So far,
> I haven't found the obvious place yet which is responsible for adding
> modules to the initrd in the debian-installer image.

Like everything else in the installer initramfs, they are installed
from a udeb.  See build/pkg-lists/*/sparc64.cfg

Ben.

-- 
Ben Hutchings
I'm always amazed by the number of people who take up solipsism because
they heard someone else explain it. - E*Borg on alt.fan.pratchett


signature.asc
Description: This is a digitally signed message part

Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-10 Thread John Paul Adrian Glaubitz 
On 04/10/2016 08:50 PM, Ben Hutchings wrote:
> initramfs-tools has nothing to do with the installer initramfs.

Hmm, ok. Then I'll need to keep digging in debian-installer. So far,
I haven't found the obvious place yet which is responsible for adding
modules to the initrd in the debian-installer image.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



signature.asc
Description: OpenPGP digital signature

Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-10 Thread Ben Hutchings 
On Sun, 2016-04-10 at 20:39 +0200, John Paul Adrian Glaubitz wrote:
> Hi Ben!
> 
> On Sun, Mar 20, 2016 at 01:54:05AM +, Debian Bug Tracking System
> wrote:
> > 
> > $ git grep -E 'sunvdc|sunvnet' debian/installer/
> > debian/installer/sparc64/modules/sparc64/nic-modules:sunvnet ?
> > debian/installer/sparc64/modules/sparc64/scsi-core-modules:sunvdc ?
> > $ dpkg-deb -c /tmp/nic-modules-4.4.0-1-sparc64-di_4.4.6-
> > 1_sparc64.udeb | grep sunvnet
> > -rw-r--r-- root/root 43488 2016-03-17 23:05
> > ./lib/modules/4.4.0-1-
> > sparc64/kernel/drivers/net/ethernet/sun/sunvnet.ko
> > $ dpkg-deb -c /tmp/scsi-core-modules-4.4.0-1-sparc64-di_4.4.6-
> > 1_sparc64.udeb | grep sunvdc
> > -rw-r--r-- root/root 28680 2016-03-17 23:04
> > ./lib/modules/4.4.0-1-sparc64/kernel/drivers/block/sunvdc.ko
> > 
> > All looks good to me.  Sounds like you're not including the right
> > packages in your installer image.
> The packages are there, otherwise it wouldn't be possible to load the
> modules manually right after booting the installer.
> 
> There must be an issue with the module loading mechanism. Grepping
> through sources.debian.net, it looks like the modules are actually
> loaded by initramfs-tools when /sys/bus/vio is present during boot.
[...]

initramfs-tools has nothing to do with the installer initramfs.

Ben.

-- 
Ben Hutchings
I'm always amazed by the number of people who take up solipsism because
they heard someone else explain it. - E*Borg on alt.fan.pratchett


signature.asc
Description: This is a digitally signed message part

Bug#815977: closed by Ben Hutchings <b...@decadent.org.uk> (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-10 Thread John Paul Adrian Glaubitz 
Hi Ben!

On Sun, Mar 20, 2016 at 01:54:05AM +, Debian Bug Tracking System wrote:
> $ git grep -E 'sunvdc|sunvnet' debian/installer/
> debian/installer/sparc64/modules/sparc64/nic-modules:sunvnet ?
> debian/installer/sparc64/modules/sparc64/scsi-core-modules:sunvdc ?
> $ dpkg-deb -c /tmp/nic-modules-4.4.0-1-sparc64-di_4.4.6-1_sparc64.udeb | grep 
> sunvnet
> -rw-r--r-- root/root 43488 2016-03-17 23:05 
> ./lib/modules/4.4.0-1-sparc64/kernel/drivers/net/ethernet/sun/sunvnet.ko
> $ dpkg-deb -c /tmp/scsi-core-modules-4.4.0-1-sparc64-di_4.4.6-1_sparc64.udeb 
> | grep sunvdc
> -rw-r--r-- root/root 28680 2016-03-17 23:04 
> ./lib/modules/4.4.0-1-sparc64/kernel/drivers/block/sunvdc.ko
> 
> All looks good to me.  Sounds like you're not including the right
> packages in your installer image.

The packages are there, otherwise it wouldn't be possible to load the
modules manually right after booting the installer.

There must be an issue with the module loading mechanism. Grepping
through sources.debian.net, it looks like the modules are actually
loaded by initramfs-tools when /sys/bus/vio is present during boot.

Thus, we first need to verify whether this is actually true. Maybe
there was a change in the kernel that changed the behavior of the
sysfs entry so that the check in the initramfs script fails.

Cheers,
Adrian

> [1] 
> http://sources.debian.net/src/initramfs-tools/0.123/hook-functions/?hl=478#L478

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i

2016-02-26 Thread John Paul Adrian Glaubitz 
Source: linux
Version: 4.4.2-3
Severity: normal
User: debian-sp...@lists.debian.org
Usertags: sparc64

Hi!

Several sparc64 users recently reported that the sunvnet and sunvdc modules
have been missing while installing with debian-installer and they had to
load these manually [1].

As it turns out, these module have been missing in the past in the d-i
kernel package on sparc [2], thus I guess the fix should be the same.

If this is not directly a kernel issue but an issue with the installation
images I am creating, please let me know. But since I couldn't anything
in d-i which allows me to define a list of modules to be loaded, I assume
it's something to be changed in the kernel package.

Thanks,
Adrian

> [1] https://lists.debian.org/debian-sparc/2016/02/msg00054.html
> [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=504702

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913