Bug#837588: vmlinux in linux-image packages is unstripped
Hi Ben, On 30.09.2016 23:20, Ben Hutchings wrote: > On Tue, 2016-09-27 at 23:09 +0200, Helge Deller wrote: >> On 27.09.2016 21:07, Ben Hutchings wrote: >>> On Tue, 2016-09-27 at 14:48 +0200, Helge Deller wrote: On 23.09.2016 05:39, Ben Hutchings wrote: > > I pushed a fix to the sid branch which I've tested on a powerpc > porterbox. The addition of dh_strip --no-automatic-dbgsym broke the 64bit parisc/hppa kernel build: >>> >>> That's strange, because it's not really an addition (we've always run >>> dh_strip). >>> >>> [...] > > Can you try adding -X$(IMAGE_FILE)? Yes, this seems to work: - dh_strip --no-automatic-dbgsym + dh_strip --no-automatic-dbgsym -X$(IMAGE_FILE) I had to restart my test-kernel-build because of another error, but from the logs the build didn't failed now because of this dh_strip line any longer. I'll have final convidence tomorrow. So, please add "-X$(IMAGE_FILE)" for now. > I have no idea how to access any hppa porterbox myself. If you need access once, just let me know. Maybe, if we have more machines up again, I will try to make one accessible as porterbox. Helge
Bug#837588: vmlinux in linux-image packages is unstripped
On Tue, 2016-09-27 at 23:09 +0200, Helge Deller wrote: > Hi Ben, > > On 27.09.2016 21:07, Ben Hutchings wrote: > > > > On Tue, 2016-09-27 at 14:48 +0200, Helge Deller wrote: > > > > > > On 23.09.2016 05:39, Ben Hutchings wrote: > > > > > > > > > > > > I pushed a fix to the sid branch which I've tested on a powerpc > > > > porterbox. > > > > > > The addition of > > > dh_strip --no-automatic-dbgsym > > > > > > broke the 64bit parisc/hppa kernel build: > > > > That's strange, because it's not really an addition (we've always run > > dh_strip). > > > > [...] > > > > > > I'm currently testing this patch (not sure if this is a good patch > > > though): > > > - dh_strip --no-automatic-dbgsym > > > + $(CROSS_COMPILE)strip --remove-section=.comment --remove-section=.note > > > '$(DIR)/$(IMAGE_FILE)' > > > > This is not correct because we do want to strip the userland tools that > > get included in powerpc builds. We could add -Xvmlinux to the dh_strip > > command to make sure it doesn't touch the kernel. > > Since the error is: > strip:debian/linux-image-4.7.0-1-parisc64-smp/boot/vmlinux-4.7.0-1-parisc64-smp: > File format not recognized > I think you would need something like -X$(IMAGE_FILE) That should also work, but the -X option gives a substring to match, not a wildcard or full filename. > > > > vmlinux is being stripped using $(CROSS_COMPILE)objcopy, but I wonder > > whether we should be using hppa64-linux-gnu-objcopy instead for the 64- > > bit kernel? > > I think $(CROSS_COMPILE)objcopy expands to hppa64-linux-gnu-objcopy when > packaging > the 64bit kernel. At least my patch worked which seems to indicate that. Oh yes, I never noticed before that rules.gen defines OVERRIDE_HOST_TYPE in this case. > Anyhow, I'm fine with any patch you agree on and which fixes the problem. Can you try adding -X$(IMAGE_FILE)? I have no idea how to access any hppa porterbox myself. Ben. -- Ben Hutchings If the facts do not conform to your theory, they must be disposed of. signature.asc Description: This is a digitally signed message part
Bug#837588: vmlinux in linux-image packages is unstripped
Hi Ben, On 27.09.2016 21:07, Ben Hutchings wrote: > On Tue, 2016-09-27 at 14:48 +0200, Helge Deller wrote: >> On 23.09.2016 05:39, Ben Hutchings wrote: >>> >>> I pushed a fix to the sid branch which I've tested on a powerpc >>> porterbox. >> >> The addition of >> dh_strip --no-automatic-dbgsym >> >> broke the 64bit parisc/hppa kernel build: > > That's strange, because it's not really an addition (we've always run > dh_strip). > > [...] >> I'm currently testing this patch (not sure if this is a good patch though): >> - dh_strip --no-automatic-dbgsym >> + $(CROSS_COMPILE)strip --remove-section=.comment --remove-section=.note >> '$(DIR)/$(IMAGE_FILE)' > > This is not correct because we do want to strip the userland tools that > get included in powerpc builds. We could add -Xvmlinux to the dh_strip > command to make sure it doesn't touch the kernel. Since the error is: strip:debian/linux-image-4.7.0-1-parisc64-smp/boot/vmlinux-4.7.0-1-parisc64-smp: File format not recognized I think you would need something like -X$(IMAGE_FILE) > vmlinux is being stripped using $(CROSS_COMPILE)objcopy, but I wonder > whether we should be using hppa64-linux-gnu-objcopy instead for the 64- > bit kernel? I think $(CROSS_COMPILE)objcopy expands to hppa64-linux-gnu-objcopy when packaging the 64bit kernel. At least my patch worked which seems to indicate that. Anyhow, I'm fine with any patch you agree on and which fixes the problem. Helge signature.asc Description: OpenPGP digital signature
Bug#837588: vmlinux in linux-image packages is unstripped
On Tue, 2016-09-27 at 14:48 +0200, Helge Deller wrote: > Hi Ben, > > On 23.09.2016 05:39, Ben Hutchings wrote: > > > > I pushed a fix to the sid branch which I've tested on a powerpc > > porterbox. > > The addition of > dh_strip --no-automatic-dbgsym > > broke the 64bit parisc/hppa kernel build: That's strange, because it's not really an addition (we've always run dh_strip). [...] > I'm currently testing this patch (not sure if this is a good patch though): > - dh_strip --no-automatic-dbgsym > + $(CROSS_COMPILE)strip --remove-section=.comment --remove-section=.note > '$(DIR)/$(IMAGE_FILE)' This is not correct because we do want to strip the userland tools that get included in powerpc builds. We could add -Xvmlinux to the dh_strip command to make sure it doesn't touch the kernel. vmlinux is being stripped using $(CROSS_COMPILE)objcopy, but I wonder whether we should be using hppa64-linux-gnu-objcopy instead for the 64- bit kernel? Ben. -- Ben Hutchings If the facts do not conform to your theory, they must be disposed of. signature.asc Description: This is a digitally signed message part
Bug#837588: vmlinux in linux-image packages is unstripped
Hi Ben, On 23.09.2016 05:39, Ben Hutchings wrote: > I pushed a fix to the sid branch which I've tested on a powerpc > porterbox. The addition of dh_strip --no-automatic-dbgsym broke the 64bit parisc/hppa kernel build: dh_strip --no-automatic-dbgsym strip:debian/linux-image-4.7.0-1-parisc64-smp/boot/vmlinux-4.7.0-1-parisc64-smp: File format not recognized dh_strip: strip --remove-section=.comment --remove-section=.note debian/linux-image-4.7.0-1-parisc64-smp/boot/vmlinux-4.7.0-1-parisc64-smp returned exit code 1 debian/rules.real:381: recipe for target 'install-image_hppa_none_parisc64-smp' failed I'm currently testing this patch (not sure if this is a good patch though): - dh_strip --no-automatic-dbgsym + $(CROSS_COMPILE)strip --remove-section=.comment --remove-section=.note '$(DIR)/$(IMAGE_FILE)' Helge
Bug#837588: vmlinux in linux-image packages is unstripped
I pushed a fix to the sid branch which I've tested on a powerpc porterbox. Ben. -- Ben Hutchings A free society is one where it is safe to be unpopular. - Adlai Stevenson signature.asc Description: This is a digitally signed message part
