Processed: Re: Bug#926539: rootskel: steal-ctty no longer works on at least sparc64
Processing control commands:
> reopen -1
Bug #926539 {Done: John Paul Adrian Glaubitz }
[src:linux,rootskel] rootskel: steal-ctty no longer works on at least sparc64
Bug reopened
Ignoring request to alter fixed versions of bug #926539 to the same values
previously set
--
926539: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=926539
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
Bug#926539: rootskel: steal-ctty no longer works on at least sparc64
Control: reopen -1 On 3/28/20 6:16 PM, John Paul Adrian Glaubitz wrote: > On 3/28/20 5:39 PM, Ivo De Decker wrote: >> This bug wasn't fixed in time for buster. Is it still present in bullseye? If >> so, it might be good to try to fix it this time. > > I fixed the bug upstream [1], so we can safely close the issue here. Ah, I just realized this bug also affected s390x. Sorry, I will reopen it. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Bug#926539: rootskel: steal-ctty no longer works on at least sparc64
Hi,
On Wed, Jun 26, 2019 at 10:18:37PM +0100, James Clarke wrote:
> (Don't know if this is a blocker for the release, but it should at
> least be reviewed before we release IMO, hence the severity)
>
> On Sun, Apr 07, 2019 at 12:53:35AM +0100, Ben Hutchings wrote:
> > On Sat, 2019-04-06 at 21:33 +0200, John Paul Adrian Glaubitz wrote:
> > > On 4/6/19 6:46 PM, John Paul Adrian Glaubitz wrote:
> > > > My suspicion is that the support multiple consoles in parallel [2]
> > > > introduced
> > > > this particular regression. I haven't done any debugging yet though as
> > > > I'm
> > > > not sure where to start, I haven't touched the rootskel package before
> > > > and
> > > > therefore would be interested in any pointers how to debug this.
> > >
> > > The problem seems to be the fact that the sparc64 kernel uses different
> > > names
> > > for /proc/console and the actual console name:
> > >
> > > root@landau:~# cat /proc/consoles
> > > ttyHV0 -W- (EC p )4:64
> > > tty0 -WU (E )4:1
> > > root@landau:~# readlink /sys/dev/char/4:64
> > > ../../devices/root/f0299a70/f029b788/tty/ttyS0
> >
> > The inconsistent name seems like a kernel bug...
> >
> > > root@landau:~#
> > >
> > > And this is what used to make it work [1]:
> > >
> > > *) # >= 2.6.38
> > > console_major_minor="$(get-real-console-linux)"
> > > console_raw="$(readlink "/sys/dev/char/${console_major_minor}")"
> > > console="${console_raw##*/}"
> > > ;;
> >
> > So maybe rootskel should use that again, but applied to each console's
> > char device number.
> >
> > (Though directly using the symlinks under /dev/char seems cleaner than
> > poking in sysfs.)
>
> Just got a report in #debian-cd of a user running into this issue on
> s390x with Hercules; a subset of the messages sent in conversation are
> below:
>
> [20:12:18]steal-ctty: No such file or directory
> [20:12:29]will go hunt this down once i find time
> [20:12:52](DI buster RC2 / s390x)
> [21:52:40]gruetzkopf: cat /proc/consoles ?
> [21:54:00]should give something like:
> [21:54:00]ttyS0-W- (EC p )4:64
> [21:54:22]rootskel will prefer a console which has the C flag
> [21:55:17]now let's see how to get there
> [21:55:57](note: running in hercules, not real hw or qemu
> where i'd have virtio console)
> [22:01:39]cat /proc/consoles
> [22:01:40]ttyS0-W- (EC p )4:64
> [22:02:05]and ls -l /dev/ttyS0?
> [22:03:06]ls: /dev/ttyS0: No such file or directory
> [22:03:06]oh, fun!
> [22:04:36]and ls -l /sys/dev/char/4:64 ?
> [22:06:06]ls -l /sys/dev/char/4:64
> [22:06:06]lrwxrwxrwx1 root root 0 Jun
> 26 21:05 /sys/dev/char/4:64 -> .
> [22:06:06]./../devices/virtual/tty/sclp_line0
> [22:06:28]ok, so, it's not /dev/ttyS0, it's /dev/sclp_line0?
> [22:06:32](does that exist?)
> [22:06:48]we had an issue like this on sparc64 (#926539)
> [22:07:38]i just found that
> [22:07:53]does that device node exist for you?
> [22:08:13]crw--w1 root root4, 64 Jun
> 26 20:58 /dev/sclp_line0
> [22:08:43](and so does /dev/ttysclp0)
>
> This is the "fault" of drivers/s390/char/sclp_tty.c. I don't know what
> the best fix is; we could also patch the kernel to ensure this shows up
> as /dev/sclp_line0 in /proc/consoles like sparc64 now does for sunhv,
> but I worry now that this might be a game of whack-a-mole and there are
> other character device drivers out there that also suffer from this.
> Perhaps therefore we need to go back to looking up the device name from
> the device number as has been suggested already...
This bug wasn't fixed in time for buster. Is it still present in bullseye? If
so, it might be good to try to fix it this time.
Cheers,
Ivo
Bug#926539: rootskel: steal-ctty no longer works on at least sparc64
Control: reopen -1
Control: reassign -1 src:linux,rootskel
Control: severity -1 serious
(Don't know if this is a blocker for the release, but it should at
least be reviewed before we release IMO, hence the severity)
On Sun, Apr 07, 2019 at 12:53:35AM +0100, Ben Hutchings wrote:
> On Sat, 2019-04-06 at 21:33 +0200, John Paul Adrian Glaubitz wrote:
> > On 4/6/19 6:46 PM, John Paul Adrian Glaubitz wrote:
> > > My suspicion is that the support multiple consoles in parallel [2]
> > > introduced
> > > this particular regression. I haven't done any debugging yet though as I'm
> > > not sure where to start, I haven't touched the rootskel package before and
> > > therefore would be interested in any pointers how to debug this.
> >
> > The problem seems to be the fact that the sparc64 kernel uses different
> > names
> > for /proc/console and the actual console name:
> >
> > root@landau:~# cat /proc/consoles
> > ttyHV0 -W- (EC p )4:64
> > tty0 -WU (E )4:1
> > root@landau:~# readlink /sys/dev/char/4:64
> > ../../devices/root/f0299a70/f029b788/tty/ttyS0
>
> The inconsistent name seems like a kernel bug...
>
> > root@landau:~#
> >
> > And this is what used to make it work [1]:
> >
> > *) # >= 2.6.38
> > console_major_minor="$(get-real-console-linux)"
> > console_raw="$(readlink "/sys/dev/char/${console_major_minor}")"
> > console="${console_raw##*/}"
> > ;;
>
> So maybe rootskel should use that again, but applied to each console's
> char device number.
>
> (Though directly using the symlinks under /dev/char seems cleaner than
> poking in sysfs.)
Just got a report in #debian-cd of a user running into this issue on
s390x with Hercules; a subset of the messages sent in conversation are
below:
[20:12:18] steal-ctty: No such file or directory
[20:12:29] will go hunt this down once i find time
[20:12:52] (DI buster RC2 / s390x)
[21:52:40] gruetzkopf: cat /proc/consoles ?
[21:54:00] should give something like:
[21:54:00] ttyS0-W- (EC p )4:64
[21:54:22] rootskel will prefer a console which has the C flag
[21:55:17] now let's see how to get there
[21:55:57] (note: running in hercules, not real hw or qemu
where i'd have virtio console)
[22:01:39] cat /proc/consoles
[22:01:40] ttyS0-W- (EC p )4:64
[22:02:05] and ls -l /dev/ttyS0?
[22:03:06] ls: /dev/ttyS0: No such file or directory
[22:03:06] oh, fun!
[22:04:36] and ls -l /sys/dev/char/4:64 ?
[22:06:06] ls -l /sys/dev/char/4:64
[22:06:06] lrwxrwxrwx1 root root 0 Jun
26 21:05 /sys/dev/char/4:64 -> .
[22:06:06] ./../devices/virtual/tty/sclp_line0
[22:06:28] ok, so, it's not /dev/ttyS0, it's /dev/sclp_line0?
[22:06:32] (does that exist?)
[22:06:48] we had an issue like this on sparc64 (#926539)
[22:07:38] i just found that
[22:07:53] does that device node exist for you?
[22:08:13] crw--w1 root root4, 64 Jun
26 20:58 /dev/sclp_line0
[22:08:43] (and so does /dev/ttysclp0)
This is the "fault" of drivers/s390/char/sclp_tty.c. I don't know what
the best fix is; we could also patch the kernel to ensure this shows up
as /dev/sclp_line0 in /proc/consoles like sparc64 now does for sunhv,
but I worry now that this might be a game of whack-a-mole and there are
other character device drivers out there that also suffer from this.
Perhaps therefore we need to go back to looking up the device name from
the device number as has been suggested already...
James
Processed: Re: Bug#926539: rootskel: steal-ctty no longer works on at least sparc64
Processing control commands:
> reopen -1
Bug #926539 {Done: Ben Hutchings } [src:linux] rootskel:
steal-ctty no longer works on at least sparc64
'reopen' may be inappropriate when a bug has been closed with a version;
all fixed versions will be cleared, and you may need to re-add them.
Bug reopened
No longer marked as fixed in versions linux/4.19.37-5.
> reassign -1 src:linux,rootskel
Bug #926539 [src:linux] rootskel: steal-ctty no longer works on at least sparc64
Bug reassigned from package 'src:linux' to 'src:linux,rootskel'.
Ignoring request to alter found versions of bug #926539 to the same values
previously set
Ignoring request to alter fixed versions of bug #926539 to the same values
previously set
> severity -1 serious
Bug #926539 [src:linux,rootskel] rootskel: steal-ctty no longer works on at
least sparc64
Severity set to 'serious' from 'important'
--
926539: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=926539
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
Bug#926539: rootskel: steal-ctty no longer works on at least sparc64
Hi! On 6/14/19 7:55 AM, John Paul Adrian Glaubitz wrote: > My patch has been merged upstream now and is planned for -stable [1]. It's now part of the 4.19 [1] and 5.1 [2] stable queues, so I guess we just have to wait a little now. @Ben: Can you make sure this bug gets closed with the next stable upload? Thanks! Adrian > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/commit/?id=cc95841f3511b943ad72133e67a105008839ead2 > [2] > https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/commit/?id=176eeebcbf771062473c8f751fa2adb4a8baebb6 -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Processed: Re: Bug#926539: rootskel: steal-ctty no longer works on at least sparc64
Processing control commands: > reassign -1 src:linux Bug #926539 [src:rootskel] rootskel: steal-ctty no longer works on at least sparc64 Bug reassigned from package 'src:rootskel' to 'src:linux'. No longer marked as found in versions rootskel/1.128. Ignoring request to alter fixed versions of bug #926539 to the same values previously set > tags -1 patch Bug #926539 [src:linux] rootskel: steal-ctty no longer works on at least sparc64 Added tag(s) patch. -- 926539: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=926539 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
