Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1)
On Tue, Feb 16, 2021 at 11:46:26PM +0100, maximilian attems wrote: > > Actually I think the problem is this commit: > > https://salsa.debian.org/kernel-team/firmware-nonfree/-/commit/9c597cb850e77c2bff39378503849a92ff522353 > > this commit is just fine, the debian package just needs to have the > corresponding symlinks to the newer version. FYI I've now tested reverting that commit and the symlinks are back: Here's the sid vs sid+revert binary package content (files) diff: --- fbr-sid-files.txt 2021-02-17 09:39:13.679336856 +0100 +++ fbr-sid-rev9c597cb850e7-files.txt 2021-02-17 10:00:12.730055901 +0100 @@ -63,4 +63,13 @@ ./usr/share/doc/firmware-brcm80211/copyright ./usr/share/metainfo/ ./usr/share/metainfo/firmware-brcm80211.metainfo.xml +./lib/firmware/brcm/brcmfmac43340-sdio.bin +./lib/firmware/brcm/brcmfmac43362-sdio.bin +./lib/firmware/brcm/brcmfmac4339-sdio.bin +./lib/firmware/brcm/brcmfmac43430-sdio.bin +./lib/firmware/brcm/brcmfmac43455-sdio.bin +./lib/firmware/brcm/brcmfmac4354-sdio.bin +./lib/firmware/brcm/brcmfmac4356-pcie.bin ./lib/firmware/brcm/brcmfmac4356-sdio.bin +./lib/firmware/brcm/brcmfmac43570-pcie.bin +./lib/firmware/brcm/brcmfmac4373-sdio.bin And yes, they are all symlinks... eg from the patched/rebuilt package: $ dpkg -c patched/firmware-brcm80211_20210208-1_all.deb | grep brcmfmac43340-sdio lrwxrwxrwx root/root 0 2021-02-17 09:58 ./lib/firmware/brcm/brcmfmac43340-sdio.bin -> ../cypress/cyfmac43340-sdio.bin Note also that this is definitely not a general problem with symlinks as even the existing package in sid has atleast one symlink in it still: $ dpkg -c sid/firmware-brcm80211_20210208-1_all.deb | grep -- '->' lrwxrwxrwx root/root 0 2021-02-09 11:15 ./lib/firmware/brcm/brcmfmac4356-sdio.bin -> ../cypress/cyfmac4356-sdio.bin The problem is simply that the symlinks are being installed into debian/build/install/ but then they are not moved over to the debian/firmware-brcm80211 directory to be included in the binary package. It might be helpful to improve the packaging logic so files are /moved/ from debian/build/install/ into the respective binary package directory and then fail the build if debian/build/install/ still contains anything (ie. similar to --fail-missing in generic dh packages). Regards, Andreas Henriksson
Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1)
On Tue, Feb 16, 2021 at 10:35:53PM +0100, Andreas Henriksson wrote: > Control: notfound -1 20201218-3 > Control: found -1 20210208-1 > > On Tue, Feb 16, 2021 at 08:20:47AM +0100, maximilian attems wrote: > [...] > > right it was replaced by newer cypress version and there should be > > a symlink of that guy from the older name: > > > > Link: brcm/brcmfmac43340-sdio.bin -> ../cypress/cyfmac43340-sdio.bin > > > > Could you please test latest 2021 upstream package with this symlink? > > It seems the bug report was filed against the (working) testing version > when (as said in subject) the problem is really in the 2021 unstable > version. Adjusted bug metadata accordingly. (I've confirmed by checking > the content of both versions myself.) > > It seems the reason that brcm/brcmfmac43340-sdio.bin symlink is missing > is this: > > The symlink first gets installed in debian/build/install ... then ... the rest on my analysis was completly wrong. Actually I think the problem is this commit: https://salsa.debian.org/kernel-team/firmware-nonfree/-/commit/9c597cb850e77c2bff39378503849a92ff522353 Regards, Andreas Henriksson
Processed: Re: Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1)
Processing control commands: > notfound -1 20201218-3 Bug #982757 [firmware-brcm80211] firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1) No longer marked as found in versions firmware-nonfree/20201218-3. > found -1 20210208-1 Bug #982757 [firmware-brcm80211] firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1) Marked as found in versions firmware-nonfree/20210208-1. -- 982757: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982757 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1)
Control: notfound -1 20201218-3 Control: found -1 20210208-1 On Tue, Feb 16, 2021 at 08:20:47AM +0100, maximilian attems wrote: [...] > right it was replaced by newer cypress version and there should be > a symlink of that guy from the older name: > > Link: brcm/brcmfmac43340-sdio.bin -> ../cypress/cyfmac43340-sdio.bin > > Could you please test latest 2021 upstream package with this symlink? It seems the bug report was filed against the (working) testing version when (as said in subject) the problem is really in the 2021 unstable version. Adjusted bug metadata accordingly. (I've confirmed by checking the content of both versions myself.) It seems the reason that brcm/brcmfmac43340-sdio.bin symlink is missing is this: The symlink first gets installed in debian/build/install ... then debian/rules.gen (generated by debian/bin/gencontrol.py) does *not* install it into debian/firmware-brcm80211 . The reason seems to be that the filename is not listed in debian/firmware-brcm80211.metainfo.xml (The cypress filename the symlink points to is however listed and that gets installed as expected.) HTH Regards, Andreas Henriksson
Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1)
severity 982757 critical stop > Version: 20201218-3 > Severity: normal thank you for the report, oh boy this one is opens a can of trouble. It seems I was blissfully unaware that the Debian packaging did not take into account the symlinks of upstream linux-firmware WHENCE file. So this means we are missing a *lot* - all the symlinks!?!? > after latest update wifi stopped working and I saw that > brcm/brcmfmac43340-sdio.bin was missing, right it was replaced by newer cypress version and there should be a symlink of that guy from the older name: Link: brcm/brcmfmac43340-sdio.bin -> ../cypress/cyfmac43340-sdio.bin Could you please test latest 2021 upstream package with this symlink? kind regards, -- maks signature.asc Description: PGP signature
Processed: Re: Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1)
Processing commands for cont...@bugs.debian.org: > severity 982757 critical Bug #982757 [firmware-brcm80211] firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1) Severity set to 'critical' from 'normal' > stop Stopping processing here. Please contact me if you need assistance. -- 982757: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982757 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1)
Package: firmware-brcm80211 Version: 20201218-3 Severity: normal Dear Maintainer, after latest update wifi stopped working and I saw that brcm/brcmfmac43340-sdio.bin was missing, so I downgraded to the version from testing and it works again. please include again! Thank You! --Jan Hetges -- System Information: Debian Release: bullseye/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: i386 (i686) Kernel: Linux 5.10.0-3-686 (SMP w/4 CPU threads) Kernel taint flags: TAINT_WARN Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled firmware-brcm80211 depends on no packages. firmware-brcm80211 recommends no packages. Versions of packages firmware-brcm80211 suggests: ii initramfs-tools 0.139 -- no debconf information
