Re: Hopefully straight forward patch by a newbie. Any comments?

[Thiemo Seufer]

[EMAIL PROTECTED] wrote:
   I am clueless with kernel programming. Still, I have came up with the
 following - hopefully straight forward - patch. Any comments?

The patch looks good to me, please send it to the upstream driver
maintainer.

I figure you want to have a look a http://www.kernelnewbies.org/ , it
is a very good starting point for working on the Linux kernel.


Thiemo


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Hopefully straight forward patch by a newbie. Any comments?

[shaulka]

  I am clueless with kernel programming. Still, I have came up with the
following - hopefully straight forward - patch. Any comments?

--- ne.c2006-08-29 14:55:59.0 +0300
+++ linux-source-2.6.17/drivers/net/ne.c2006-08-29 16:02:24.0 
+0300
@@ -829,7 +829,7 @@
 is at boot) and so the probe will get confused by any other 8390 cards.
 ISA device autoprobes on a running machine are not recommended anyway. */

-int init_module(void)
+static int __init init_ne_module(void)
 {
int this_dev, found = 0;

@@ -867,7 +867,7 @@
release_region(dev-base_addr, NE_IO_EXTENT);
 }

-void cleanup_module(void)
+static void __exit cleanup_ne_module(void)
 {
int this_dev;

@@ -880,4 +880,8 @@
}
}
 }
+
+module_init(init_ne_module);
+module_exit(cleanup_ne_module);
+
 #endif /* MODULE */

--- smc-ultra.c 2006-08-29 15:03:33.0 +0300
+++ linux-source-2.6.17/drivers/net/smc-ultra.c 2006-08-29 16:08:08.0 
+0300
@@ -553,8 +553,7 @@

 /* This is set up so that only a single autoprobe takes place per call.
 ISA device autoprobes on a running machine are not recommended. */
-int
-init_module(void)
+static int __init init_smcUltra_module(void)
 {
struct net_device *dev;
int this_dev, found = 0;
@@ -594,8 +593,7 @@
iounmap(ei_status.mem);
 }

-void
-cleanup_module(void)
+static void __exit cleanup_smcUltra_module(void)
 {
int this_dev;

@@ -608,4 +606,8 @@
}
}
 }
+
+module_init(init_smcUltra_module);
+module_exit(cleanup_smcUltra_module);
+
 #endif /* MODULE */







-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Re: Hopefully straight forward patch by a newbie. Any comments?

[dann frazier]

On Tue, Aug 29, 2006 at 07:06:23PM +0200, [EMAIL PROTECTED] wrote:
   I am clueless with kernel programming. Still, I have came up with the
 following - hopefully straight forward - patch. Any comments?

Yeah, what's it for?

Your best bet is to send this patch with a description and a
Signed-off-by line to the maintainer of the ne driver. Once its
accepted, let us know  give us an idea of why you think Debian should
include it.

-- 
dann frazier


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]