Re: Bug#1032140: [External] Re: Bug#1032140: Lenovo Z16 Install issue

[Cyril Brulebois]

Just a quick follow-up…

Cyril Brulebois  (2023-03-01):
> David Ober  (2023-03-01):
> > Test worked as you expected the network card driver looks to be
> > enabled but cannot load firmware.
> 
> Thanks for this confirmation, I'll file the MR against linux later on.
> 
> > I can test if you want or you can wait until the next formal build
> 
> You'll find a local bookworm build including the patched nic-wireless
> in the same directory: https://people.debian.org/~kibi/bug-1032140/
> 
> (Since it's ~650MB, it will get removed in a week or two.)

This bug was addressed in a previous src:linux upload, but follow-ups to
get all the bits in place in the installer context include:
 - https://salsa.debian.org/kernel-team/linux/-/merge_requests/667
 - 
https://salsa.debian.org/installer-team/hw-detect/-/commit/d913f525a58d6f9191c6e59f80efe037ae15d036

Things should go smoother with the next Debian Installer release.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Re: Bug#1032140: [External] Re: Bug#1032140: Lenovo Z16 Install issue

[Cyril Brulebois]

David Ober  (2023-03-02):
> Syslog attached

Thanks, looks like some things need to be addressed in various places…

Mar  2 02:32:13 check-missing-firmware: looking at dmesg for the first time
Mar  2 02:32:13 check-missing-firmware: saving timestamp for a later use: [ 
  26.337353]
Mar  2 02:32:13 check-missing-firmware: looking for firmware file 
ath11k/WCN6855/hw2.1/amss.bin requested by mhi
Mar  2 02:32:13 check-missing-firmware: looking for firmware file 
ath11k/WCN6855/hw2.1/amss.bin requested by mhi
Mar  2 02:32:13 check-missing-firmware: missing firmware files 
(ath11k/WCN6855/hw2.1/amss.bin ath11k/WCN6855/hw2.1/amss.bin) for mhi

#1: missing deduplication, already fixed in git.

Mar  2 02:32:13 check-missing-firmware: mainloop iteration #1
Mar  2 02:32:13 check-missing-firmware: lookup with 
/cdrom/firmware/Contents-firmware

#2: firmware files → firmware packages lookup doesn't seem to have found
anything. I only checked quickly initially, seeing amss.bin shipped
in firmware-atheros, then making sure it landed on the ISO I've
pointed you to… except it's not the right version. Your module wants
hw2.1/ while firmware-atheros (at least in testing) only ships some
hw2.0/ version for it. That's on me: symlinks are present in the
firmware package, but not in the Contents-firmware index… since my
local build didn't catch up with latest debian-cd code (I knew I
would need to adjust some config, so I didn't rebase, but then I
missed a bugfix)…
.
Definitely my fault, sorry about that, but that wouldn't have worked
anyway because of the next one…

Mar  2 02:32:13 check-missing-firmware: removing and loading kernel module 
mhi
Mar  2 02:32:13 check-missing-firmware: modprobe: FATAL: Module mhi is in 
use.

#3: we're trying to reload the mhi module here, which is likely a
situation that's similar to the usb one I encountered and adjusted
in a previous hw-detect upload. I suspect we should do something
similar here, “resolving” `mhi mhi0` into `ath11k_pci`. See:

https://salsa.debian.org/installer-team/hw-detect/-/commit/ab087adedd738d8b6bfb7e785c591a1aa982b7f2

Based on … we
should have something like /sys/bus/mhi/devices/mhi0/driver that's a
symlink to some other place that contains `ath11k_pci`. If that's indeed
the case, we can implement an mhi lookup that's similar to the usb one.

If the path mentioned above doesn't exist or isn't a symlink to some
ath11k_pci location, please look around with things like these:

ls -l /sys/bus/mhi/devices/
ls -l /sys/bus/mhi/devices/mhi0
etc.


Thanks again, your help is much appreciated.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Re: Bug#1032140: [External] Re: Bug#1032140: Lenovo Z16 Install issue

[Cyril Brulebois]

David Ober  (2023-03-02):
> Not the result I was expecting, here is the dmesg logs where it still failed 
> to load the firmware
> 
> [   26.626868] ath11k_pci :04:00.0: BAR 0: assigned [mem 
> 0xb000-0xb01f 64bit]
> [   26.627223] ath11k_pci :04:00.0: MSI vectors: 32
> [   26.627228] ath11k_pci :04:00.0: wcn6855 hw2.1
> [   26.630080] NET: Registered PF_QIPCRTR protocol family
> [   26.785089] mhi mhi0: Requested to power ON
> [   26.785102] mhi mhi0: Power on setup success
> [   26.785400] mhi mhi0: firmware: failed to load 
> ath11k/WCN6855/hw2.1/amss.bin (-2)
> [   26.785407] firmware_class: See https://wiki.debian.org/Firmware for 
> information about missing firmware
> [   26.785422] mhi mhi0: firmware: failed to load 
> ath11k/WCN6855/hw2.1/amss.bin (-2)
> [   26.785425] mhi mhi0: Direct firmware load for 
> ath11k/WCN6855/hw2.1/amss.bin failed with error -2
> [   26.785430] mhi mhi0: Error loading firmware: -2
> [   26.785589] ath11k_pci :04:00.0: failed to power up mhi: -110
> [   26.785596] ath11k_pci :04:00.0: failed to start mhi: -110
> [   26.785600] ath11k_pci :04:00.0: failed to power up :-110
> [   26.820002] ath11k_pci :04:00.0: failed to create soc core: -110
> [   26.820018] ath11k_pci :04:00.0: failed to init core: -110
> [   27.036908] ath11k_pci: probe of :04:00.0 failed with error -110

Can you please attach the whole /var/log/syslog (compressed to make sure
it goes through BTS & ML)?

It's expected to have those lines show up once, then one component
should notice, do the firmware dance, and reload modules, after which
things should be all fine.

Having the whole syslog will help spot what's missing in that picture.


Thanks,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Processed: Re: Bug#1032140: [External] Re: Bug#1032140: Lenovo Z16 Install issue

[Debian Bug Tracking System]

Processing control commands:

> reassign -1 src:linux 6.1.12-1
Bug #1032140 [installation-reports] Lenovo Z16 Install issue
Bug reassigned from package 'installation-reports' to 'src:linux'.
Ignoring request to alter found versions of bug #1032140 to the same values 
previously set
Ignoring request to alter fixed versions of bug #1032140 to the same values 
previously set
Bug #1032140 [src:linux] Lenovo Z16 Install issue
Marked as found in versions linux/6.1.12-1.
> forwarded -1 https://salsa.debian.org/kernel-team/linux/-/merge_requests/667
Bug #1032140 [src:linux] Lenovo Z16 Install issue
Set Bug forwarded-to-address to 
'https://salsa.debian.org/kernel-team/linux/-/merge_requests/667'.
> tag -1 patch
Bug #1032140 [src:linux] Lenovo Z16 Install issue
Added tag(s) patch.

-- 
1032140: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1032140
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Re: Bug#1032140: [External] Re: Bug#1032140: Lenovo Z16 Install issue

[Cyril Brulebois]

Control: reassign -1 src:linux 6.1.12-1
Control: forwarded -1 
https://salsa.debian.org/kernel-team/linux/-/merge_requests/667
Control: tag -1 patch

Cyril Brulebois  (2023-03-01):
> Thanks for this confirmation, I'll file the MR against linux later on.

Doing so now.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Re: Bug#1032140: [External] Re: Bug#1032140: Lenovo Z16 Install issue

[Cyril Brulebois]

David Ober  (2023-03-01):
> Test worked as you expected the network card driver looks to be
> enabled but cannot load firmware.

Thanks for this confirmation, I'll file the MR against linux later on.

> I can test if you want or you can wait until the next formal build

You'll find a local bookworm build including the patched nic-wireless
in the same directory: https://people.debian.org/~kibi/bug-1032140/

(Since it's ~650MB, it will get removed in a week or two.)


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

RE: Bug#1032140: [External] Re: Bug#1032140: Lenovo Z16 Install issue

[David Ober]

Test worked as you expected the network card driver looks to be enabled but 
cannot load firmware.  I can test if you want or you can wait until the next 
formal build

David

-Original Message-
From: Cyril Brulebois  
Sent: Tuesday, February 28, 2023 4:41 PM
To: David Ober ; 1032...@bugs.debian.org
Cc: Steve McIntyre ; debian-kernel@lists.debian.org
Subject: Re: Bug#1032140: [External] Re: Bug#1032140: Lenovo Z16 Install issue

David Ober  (2023-02-28):
> Happy to test it

Great!

Here's a minimal netboot-gtk mini.iso, to test just the loading aspect:
  https://people.debian.org/~kibi/bug-1032140/

It adds qrtr-mhi (and its dependency qrtr), and both can be loaded just fine in 
QEMU (manually).

This should help ath11k_pci work better (probing shouldn't fail, at least), and 
the next step is probably getting an error about missing firmware. That's 
expected with this small build, but once we make sure ath11k_pci loads and 
probes fine, I'm happy to build a full netinst if you want to go through the 
whole installation process. Otherwise, we can stash the change in linux.git and 
that should get included in the next Debian Installer release.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)<https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

Re: Bug#1032140: [External] Re: Bug#1032140: Lenovo Z16 Install issue

[Cyril Brulebois]

David Ober  (2023-02-28):
> Happy to test it 

Great!

Here's a minimal netboot-gtk mini.iso, to test just the loading aspect:
  https://people.debian.org/~kibi/bug-1032140/

It adds qrtr-mhi (and its dependency qrtr), and both can be loaded just
fine in QEMU (manually).

This should help ath11k_pci work better (probing shouldn't fail, at
least), and the next step is probably getting an error about missing
firmware. That's expected with this small build, but once we make sure
ath11k_pci loads and probes fine, I'm happy to build a full netinst if
you want to go through the whole installation process. Otherwise, we can
stash the change in linux.git and that should get included in the next
Debian Installer release.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature