Re: s390: Implement IRQ functions if !PCI

2013-06-10 Thread Martin Schwidefsky
On Sun, 09 Jun 2013 17:03:04 -0700 (PDT)
David Miller da...@davemloft.net wrote:

 From: Ben Hutchings b...@decadent.org.uk
 Date: Sun, 09 Jun 2013 21:07:31 +0100
 
  All architectures must implement IRQ functions.  Since various
  dependencies on !S390 were removed, there are various drivers that can
  be selected but will fail to link.  Provide a dummy implementation of
  these functions for the !PCI case.
  
  Compile-tested only.
 
 Acked-by: David S. Miller da...@davemloft.net

Yeah, this is probably the least painful method to do it. Applied.

-- 
blue skies,
   Martin.

Reality continues to ruin my life. - Calvin.


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130610160438.237ce20b@mschwide



s390: Implement IRQ functions if !PCI

2013-06-09 Thread Ben Hutchings
All architectures must implement IRQ functions.  Since various
dependencies on !S390 were removed, there are various drivers that can
be selected but will fail to link.  Provide a dummy implementation of
these functions for the !PCI case.

Compile-tested only.

Signed-off-by: Ben Hutchings b...@decadent.org.uk
Cc: sta...@vger.kernel.org # 3.9
---
--- a/arch/s390/kernel/irq.c
+++ b/arch/s390/kernel/irq.c
@@ -313,3 +313,67 @@ void measurement_alert_subclass_unregist
spin_unlock(ma_subclass_lock);
 }
 EXPORT_SYMBOL(measurement_alert_subclass_unregister);
+
+void synchronize_irq(unsigned int irq)
+{
+   /*
+* Not needed, the handler is protected by a lock and IRQs that occur
+* after the handler is deleted are just NOPs.
+*/
+}
+EXPORT_SYMBOL_GPL(synchronize_irq);
+
+#ifndef CONFIG_PCI
+
+/* Only PCI devices have dynamically-defined IRQ handlers */
+
+int request_irq(unsigned int irq, irq_handler_t handler,
+   unsigned long irqflags, const char *devname, void *dev_id)
+{
+   return -EINVAL;
+}
+EXPORT_SYMBOL_GPL(request_irq);
+
+void free_irq(unsigned int irq, void *dev_id)
+{
+   WARN_ON(1);
+}
+EXPORT_SYMBOL_GPL(free_irq);
+
+void enable_irq(unsigned int irq)
+{
+   WARN_ON(1);
+}
+EXPORT_SYMBOL_GPL(enable_irq);
+
+void disable_irq(unsigned int irq)
+{
+   WARN_ON(1);
+}
+EXPORT_SYMBOL_GPL(disable_irq);
+
+#endif /* !CONFIG_PCI */
+
+void disable_irq_nosync(unsigned int irq)
+{
+   disable_irq(irq);
+}
+EXPORT_SYMBOL_GPL(disable_irq_nosync);
+
+unsigned long probe_irq_on(void)
+{
+   return 0;
+}
+EXPORT_SYMBOL_GPL(probe_irq_on);
+
+int probe_irq_off(unsigned long val)
+{
+   return 0;
+}
+EXPORT_SYMBOL_GPL(probe_irq_off);
+
+unsigned int probe_irq_mask(unsigned long val)
+{
+   return val;
+}
+EXPORT_SYMBOL_GPL(probe_irq_mask);
--- a/arch/s390/pci/pci.c
+++ b/arch/s390/pci/pci.c
@@ -306,15 +306,6 @@ static int zpci_cfg_store(struct zpci_de
return rc;
 }
 
-void synchronize_irq(unsigned int irq)
-{
-   /*
-* Not needed, the handler is protected by a lock and IRQs that occur
-* after the handler is deleted are just NOPs.
-*/
-}
-EXPORT_SYMBOL_GPL(synchronize_irq);
-
 void enable_irq(unsigned int irq)
 {
struct msi_desc *msi = irq_get_msi_desc(irq);
@@ -331,30 +322,6 @@ void disable_irq(unsigned int irq)
 }
 EXPORT_SYMBOL_GPL(disable_irq);
 
-void disable_irq_nosync(unsigned int irq)
-{
-   disable_irq(irq);
-}
-EXPORT_SYMBOL_GPL(disable_irq_nosync);
-
-unsigned long probe_irq_on(void)
-{
-   return 0;
-}
-EXPORT_SYMBOL_GPL(probe_irq_on);
-
-int probe_irq_off(unsigned long val)
-{
-   return 0;
-}
-EXPORT_SYMBOL_GPL(probe_irq_off);
-
-unsigned int probe_irq_mask(unsigned long val)
-{
-   return val;
-}
-EXPORT_SYMBOL_GPL(probe_irq_mask);
-
 void pcibios_fixup_bus(struct pci_bus *bus)
 {
 }



signature.asc
Description: This is a digitally signed message part


Re: s390: Implement IRQ functions if !PCI

2013-06-09 Thread David Miller
From: Ben Hutchings b...@decadent.org.uk
Date: Sun, 09 Jun 2013 21:07:31 +0100

 All architectures must implement IRQ functions.  Since various
 dependencies on !S390 were removed, there are various drivers that can
 be selected but will fail to link.  Provide a dummy implementation of
 these functions for the !PCI case.
 
 Compile-tested only.

Acked-by: David S. Miller da...@davemloft.net


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/20130609.170304.610055126891418919.da...@davemloft.net