Bug#504257: lintian: check for exit() or _exit() calls in shared libraries

[Paul Wise]

On Sun, 2008-11-02 at 21:21 -0800, Russ Allbery wrote:

> I have some packages that would trigger this because the library uses
> generic error handling routines that include functions that can call
> exit() or _exit() but which are never called in practice.  Ideally, that
> dead code would be stripped out of the shared library, but in practice,
> this can be more painful to do than is worth it.

Hmm, ok. 

> This sort of check suffers from the problem that there often isn't
> anything the Debian maintainer can really do about it.  It's not the sort
> of thing that warrants making modifications that upstream won't take,
> usually (although it can in some situations).

Mainly it would be to make the Debian maintainer aware of it so they can
contact upstream about it and ask them to fix the situation. In many
cases this would mean an ABI change so upstream will likely be unwilling
to make the change.

> I'm not opposed to adding it, but I think we should probably start with it
> marked as experimental, and I'd expect a lot of false positives.

Agreed, definitely an info-level complaint if it gets added.

-- 
bye,
pabs

http://wiki.debian.org/PaulWise


signature.asc
Description: This is a digitally signed message part

Bug#504264: lintian: warn on empty files passed to dh_installdocs or in .deb

[Paul Wise]

On Sun, 2008-11-02 at 21:22 -0800, Russ Allbery wrote:

> lintian already warns about empty files in the package in general, which
> would seem to cover this.  Do you have a specific example that we can look
> at where this didn't work?

Ah. I was reviewing an RFS, but only ran lintian on the source package:

http://mentors.debian.net/debian/pool/main/p/plotmm/plotmm_0.1.2-1.dsc
http://lists.debian.org/debian-mentors/2008/11/msg00014.html

-- 
bye,
pabs

http://wiki.debian.org/PaulWise


signature.asc
Description: This is a digitally signed message part

Bug#504257: lintian: check for exit() or _exit() calls in shared libraries

[Russ Allbery]

Paul Wise <[EMAIL PROTECTED]> writes:

> Package: lintian
> Version: 2.0.0
> Severity: wishlist
>
> rpmlint added checks for exit() or _exit() calls in shared libraries:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=450011
> http://rpmlint.zarb.org/cgi-bin/trac.cgi/changeset/1448
>
> I think this would be a useful addition to lintian.

I have some packages that would trigger this because the library uses
generic error handling routines that include functions that can call
exit() or _exit() but which are never called in practice.  Ideally, that
dead code would be stripped out of the shared library, but in practice,
this can be more painful to do than is worth it.

This sort of check suffers from the problem that there often isn't
anything the Debian maintainer can really do about it.  It's not the sort
of thing that warrants making modifications that upstream won't take,
usually (although it can in some situations).

I'm not opposed to adding it, but I think we should probably start with it
marked as experimental, and I'd expect a lot of false positives.

-- 
Russ Allbery ([EMAIL PROTECTED])   



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Bug#504264: lintian: warn on empty files passed to dh_installdocs or in .deb

[Russ Allbery]

Paul Wise <[EMAIL PROTECTED]> writes:

> Package: lintian
> Version: 2.0.0
> Severity: wishlist
>
> Please warn about empty or whitespace-only files being listed in
> debian/*docs when dh_installdocs is being used, or on the command-line
> to the dh_installdocs command in debian/rules. Shipping useless files
> in .debs should be discouraged. Please also warn on empty files
> in /usr/share/doc.

lintian already warns about empty files in the package in general, which
would seem to cover this.  Do you have a specific example that we can look
at where this didn't work?

-- 
Russ Allbery ([EMAIL PROTECTED])   



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Processed: setting package to lintian, tagging 503695

[Debian Bug Tracking System]

Processing commands for [EMAIL PROTECTED]:

> #lintian (2.1.0) unstable; urgency=low
> #
> #  * checks/patch-systems:
> #+ [ADB] Don't include dpatch comment lines containing no content
> #  when determining whether the patch includes a description.
> #  (Closes: #503695)
> #
> package lintian
Ignoring bugs not assigned to: lintian

> tags 503695 + pending
Bug#503695: lintian: Add support for checking empty DP: ""
There were no tags set.
Tags added: pending

>
End of message, stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Bug#504302: lintian: Rename --show-overrides to a --display-* option

[Adam D. Barratt]

On Sun, 2008-11-02 at 18:43 +0200, jaalto wrote:
> For canonical option names like these:
> 
>--display-info
>--display-experimental
>...
> 
> it would be expected to find similarly named:
> 
>--display-overrides

Renaming an option that's existed for nearly eight years is never a good
idea. I'm not personally convinced it's worth adding a synonym for the
existing option purely for aesthetic reasons; at least, I've never heard
of anyone getting confused by the current name.

Regards,

Adam



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Bug#504302: lintian: Rename --show-overrides to a --display-* option

[jaalto]

Package: lintian
Version: 2.0.0
Severity: wishlist


For canonical option names like these:

   --display-info
   --display-experimental
   ...

it would be expected to find similarly named:

   --display-overrides

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.26-1-openvz-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils2.18.1~cvs20080103-7 The GNU assembler, linker and bina
ii  diffstat1.45-2   produces graph of changes introduc
ii  dpkg-dev1.14.22  Debian package development tools
ii  file4.26-1   Determines file type using "magic"
ii  gettext 0.17-4   GNU Internationalization utilities
ii  intltool-debian 0.35.0+20060710.1Help i18n of RFC822 compliant conf
ii  libparse-debianchan 1.1.1-2  parse Debian changelogs and output
ii  libtimedate-perl1.1600-9 Time and date functions for Perl
ii  liburi-perl 1.35.dfsg.1-1Manipulates and accesses URI strin
ii  man-db  2.5.2-3  on-line manual pager
ii  perl [libdigest-sha 5.10.0-15Larry Wall's Practical Extraction 

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch (no description available)
pn  libtext-template-perl  (no description available)
ii  man-db2.5.2-3on-line manual pager

-- no debconf information



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Bug#504264: lintian: warn on empty files passed to dh_installdocs or in .deb

[Paul Wise]

Package: lintian
Version: 2.0.0
Severity: wishlist

Please warn about empty or whitespace-only files being listed in
debian/*docs when dh_installdocs is being used, or on the command-line
to the dh_installdocs command in debian/rules. Shipping useless files
in .debs should be discouraged. Please also warn on empty files
in /usr/share/doc.

-- 
bye,
pabs

http://wiki.debian.org/PaulWise


signature.asc
Description: This is a digitally signed message part

Bug#504257: lintian: check for exit() or _exit() calls in shared libraries

[Paul Wise]

Package: lintian
Version: 2.0.0
Severity: wishlist

rpmlint added checks for exit() or _exit() calls in shared libraries:

https://bugzilla.redhat.com/show_bug.cgi?id=450011
http://rpmlint.zarb.org/cgi-bin/trac.cgi/changeset/1448

I think this would be a useful addition to lintian.

-- 
bye,
pabs

http://wiki.debian.org/PaulWise


signature.asc
Description: This is a digitally signed message part