[SCM] Debian package checker branch, master, updated. 2.4.3-18-g570b098
The following commit has been merged in the master branch:
commit 570b0985ed5159bae6917a4d9121455cff039931
Author: Niels Thykier
Date: Wed Dec 22 09:15:25 2010 +0100
Fixed some style issues in d/changelog.
diff --git a/debian/changelog b/debian/changelog
index d9e4ddc..788d98f 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -9,7 +9,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
embedded-zlib check since it's in the kernel. (Closes: #593397)
+ [RG] Add swipl to the list of known interpreters. (Closes: #591316)
* checks/debian-source-dir:
-+ [NT] Added missing import of "Util" perl module. Thanks to David
++ [NT] Added missing import of "Util" perl module. Thanks to David
Bremner for the patch.
* checks/fields{,.desc}:
+ [NT] Added check for packages build depending on openjdk-X-doc or
@@ -17,7 +17,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
(Closes: #593837)
* checks/files:
+ [NT] Fixed false-positive extra-license-file for license.ui files.
- Thanks to Jeremy Sanders for the report. (Closes: #595941)
+ Thanks to Jeremy Sanders for the report. (Closes: #595941)
* checks/menu-format.desc:
+ [CW] Fix several typos.
* checks/menus.desc:
@@ -42,7 +42,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
+ [RA] Remove versions from dependencies when those versions are
satisifed by stable (lenny).
+ [NT] Bump debhelper build dependency to 7.0.50~, since some tests
- depend on using dh7 with override targets. (Closes: #607730)
+ depend on using dh7 with override targets. (Closes: #607730)
+ [NT] Added Niels Thykier to uploaders.
* debian/copyright:
+ [NT] Added Niels Thykier to maintainers.
@@ -52,14 +52,8 @@ lintian (2.4.4) UNRELEASED; urgency=low
* debian/compat:
+ [NT] Bump debhelper comat to 7.
- * t/tests/files-extra-license:
-+ [NT] Added new test.
- * t/tests/fields-java:
-+ [NT] Added test for new tag.
- * t/tests/rules-not-makefile:
-+ [NT] Added new test.
- * t/tests/scripts-missing-dep:
-+ [NT] Added new test. (Closes: #607731)
+ * t/tests/{rules-not-makefile,scripts-missing-dep}:
++ [NT] Added new tests. (Closes: #607731)
-- Raphael Geissert Thu, 29 Jul 2010 21:09:55 -0400
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvjsl-0005ws...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-19-g92b41fe
The following commit has been merged in the master branch:
commit 92b41fec86c4e25225d9e5a0d224d276f8666276
Author: Niels Thykier
Date: Fri Dec 3 22:41:43 2010 +0100
Add check for depending on specific system javadoc instead default-jdk-doc.
* Summary of tag changes:
+ Added:
- depends-on-specific-java-doc-package
* checks/fields{,.desc}:
+ [NT] Added check for packages (build) depending on openjdk-X-doc or
classpath-doc instead of the default-jdk-doc metapackage.
(Closes: #593837)
diff --git a/checks/fields b/checks/fields
index 5161ae2..e503a52 100644
--- a/checks/fields
+++ b/checks/fields
@@ -638,6 +638,13 @@ if (($type eq "binary") || ($type eq 'udeb')) {
if ($field eq 'recommends'
&& $pkg =~ m/^lib/ && $pkg !~
m/-(dev|docs?|tools|bin)$/
&& $part_d_orig =~ m/-docs?$/);
+
+ # default-jdk-doc must depend on openjdk-X-doc
(or classpath-doc) to be
+ # useful; other packages should depend on
default-jdk-doc if they
+ # want the Java Core API.
+ tag "depends-on-specific-java-doc-package",
"$field"
+ if(&$is_dep_field($field) && $pkg ne
'default-jdk-doc'
+ && ($d_pkg eq 'classpath-doc' || $d_pkg
=~ m/openjdk-\d+-doc/o));
}
for my $pkg (@seen_obsolete_packages) {
diff --git a/checks/fields.desc b/checks/fields.desc
index 2a77b7e..cf91829 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -1000,3 +1000,10 @@ Info: The given package declares a build dependency on
either openjdk-
X-doc or classpath-doc instead of using default-jdk-doc. default-jdk-doc
provides a symlink to the API via /usr/share/default-jdk-doc/api.
+Tag: depends-on-specific-java-doc-package
+Severity: normal
+Certainty: certain
+Info: The package should use default-jdk-doc instead of classpath-doc
+ or openjdk-X-doc to ease transitions when the providing doc package
+ is replaced (e.g. openjdk-6-doc being replaced by openjdk-7-doc).
+
diff --git a/debian/changelog b/debian/changelog
index 788d98f..4eec353 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,6 +3,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
* Summary of tag changes:
+ Added:
- build-depends-on-specific-java-doc-package
+ - depends-on-specific-java-doc-package
* checks/binaries:
+ [RA] Exclude kfreebsd-kernel-di-{amd64,i386} from the
@@ -12,7 +13,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
+ [NT] Added missing import of "Util" perl module. Thanks to David
Bremner for the patch.
* checks/fields{,.desc}:
-+ [NT] Added check for packages build depending on openjdk-X-doc or
++ [NT] Added check for packages (build) depending on openjdk-X-doc or
classpath-doc instead of the default-jdk-doc metapackage.
(Closes: #593837)
* checks/files:
diff --git a/t/tests/fields-java/debian/debian/control.in
b/t/tests/fields-java/debian/debian/control.in
index 8dbc64a..d03c194 100644
--- a/t/tests/fields-java/debian/debian/control.in
+++ b/t/tests/fields-java/debian/debian/control.in
@@ -5,9 +5,13 @@ Maintainer: {$author}
Standards-Version: {$standards_version}
Build-Depends: debhelper (>= 7.0.50~), openjdk-6-doc
-Package: lib{$srcpkg}-java
+Package: lib{$srcpkg}-java-doc
Architecture: {$architecture}
+Section: doc
Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Recommends: openjdk-6-doc
+# Negative testing as well, this should not be triggered.
+Replaces: openjdk-6-doc
Description: {$description}
This is a test package designed to exercise some feature or tag of
Lintian. It is part of the Lintian test suite and may do very odd
diff --git a/t/tests/fields-java/desc b/t/tests/fields-java/desc
index 12e1005..52b570a 100644
--- a/t/tests/fields-java/desc
+++ b/t/tests/fields-java/desc
@@ -4,3 +4,4 @@ Version: 1.0
Description: General tests for java package (build) dependencies
Test-For:
build-depends-on-specific-java-doc-package
+ depends-on-specific-java-doc-package
diff --git a/t/tests/fields-java/tags b/t/tests/fields-java/tags
index 4f3321f..19f1802 100644
--- a/t/tests/fields-java/tags
+++ b/t/tests/fields-java/tags
@@ -1 +1,2 @@
W: fields-java source: build-depends-on-specific-java-doc-package openjdk-6-doc
+W: libfields-java-java-doc: depends-on-specific-java-doc-package recommends
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvkpf-00048f...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-20-g5b36419
The following commit has been merged in the master branch:
commit 5b36419d5040f8af89bf92440974c658d3fe69c0
Author: Niels Thykier
Date: Wed Dec 22 09:59:42 2010 +0100
Create a sorted file index for checks to use instead of sorting it
themselves (Closes: #605844)
* checks/*:
+ [NT] Use the new pre-sorted file index when iterating over files.
* lib/Lintian/Collect/Binary.pm:
+ [NT] Create a sorted file index to avoid sorting it in the checks.
(Closes: #605844)
diff --git a/checks/changelog-file b/checks/changelog-file
index 8147095..40f4b0f 100644
--- a/checks/changelog-file
+++ b/checks/changelog-file
@@ -79,7 +79,7 @@ for my $file (sort keys %{$info->file_info}) {
}
# Read package contents Capitalization errors are dealt with later.
-foreach (sort keys %{$info->index}) {
+foreach (@{$info->sorted_index}) {
next unless length $_;
# skip packages which have a /usr/share/doc/$pkg -> foo symlink
if (m,usr/share/doc/$ppkg$, and defined $info->index->{$_}->{link}) {
diff --git a/checks/copyright-file b/checks/copyright-file
index 336d0f4..267ed43 100644
--- a/checks/copyright-file
+++ b/checks/copyright-file
@@ -45,7 +45,7 @@ my $found = 0;
my $linked = 0;
# Read package contents...
-foreach (sort keys %{$info->index}) {
+foreach (@{$info->sorted_index}) {
my $index_info = $info->index->{$_};
if (m,usr/(share/)?doc/$ppkg/copyright(\.\S+)?$,) {
my $ext = $2;
diff --git a/checks/etcfiles b/checks/etcfiles
index bc61715..9a734b1 100644
--- a/checks/etcfiles
+++ b/checks/etcfiles
@@ -45,7 +45,7 @@ if (open(IN, '<', $conffiles)) {
}
# Read package contents...
-foreach my $file (sort keys %{$info->index}) {
+foreach my $file (@{$info->sorted_index}) {
my $index_info = $info->index->{$file};
next unless $file =~ m,^etc, and $index_info->{type}=~ m/^[-h]/;
diff --git a/checks/fields b/checks/fields
index e503a52..af5fae5 100644
--- a/checks/fields
+++ b/checks/fields
@@ -503,7 +503,7 @@ if (defined $info->field('installer-menu-item')) {
my $metapackage = 0;
if ($type eq 'binary') {
$metapackage = 1;
- for my $file (keys %{$info->index}) {
+ for my $file (@{$info->sorted_index}) {
next if $info->index->{$file}->{type} =~ /^d/;
next if $file =~ m%^usr/share/doc/%;
next if $file =~ m%^usr/share/lintian/overrides/%;
diff --git a/checks/files b/checks/files
index bdbd585..07b7fea 100644
--- a/checks/files
+++ b/checks/files
@@ -199,7 +199,7 @@ if ($description) {
}
}
if ($is_empty) {
-for my $file (sort keys %{$info->index}) {
+for my $file (@{$info->sorted_index}) {
# Ignore directories
unless ($file =~ m,/$,) {
# Skip if $file is an empty string
@@ -226,7 +226,7 @@ if ($is_empty) {
}
# Read package contents...
-foreach my $file (sort keys %{$info->index}) {
+foreach my $file (@{$info->sorted_index}) {
next if $file eq "";
my $index_info = $info->index->{$file};
my $owner = $index_info->{owner} . '/' . $index_info->{group};
@@ -1204,7 +1204,7 @@ if ($pkg_section !~ m,games$, and $games > 0 and $other
== 0) {
# so just ignore them.
#
# python-support needs a directory for each package even it might be empty
-foreach my $dir (sort keys %{$info->index}) {
+foreach my $dir (@{$info->sorted_index}) {
next if $dir eq "" or $info->index->{$dir}->{type} ne 'd';
next if ($dir =~ m{^var/} or $dir =~ m{^etc/});
next if $pkg eq 'base-files';
diff --git a/checks/infofiles b/checks/infofiles
index 2c5b994..872a74b 100644
--- a/checks/infofiles
+++ b/checks/infofiles
@@ -40,7 +40,7 @@ my %missing_section;
my $has_info_file;
# Read package contents...
-foreach my $file (sort keys %{$info->index}) {
+foreach my $file (@{$info->sorted_index}) {
my $index_info = $info->index->{$file};
my $file_info = $info->file_info->{$file};
my $link = $index_info->{link} || '';
diff --git a/checks/manpages b/checks/manpages
index 0035bda..17912d2 100644
--- a/checks/manpages
+++ b/checks/manpages
@@ -40,7 +40,7 @@ my %link;
my %manpage;
# Read package contents...
-foreach my $file (sort keys %{$info->index}) {
+foreach my $file (@{$info->sorted_index}) {
my $index_info = $info->index->{$file};
my $file_info = $info->file_info->{$file};
my $link = $index_info->{link} || '';
diff --git a/checks/menu-format b/checks/menu-format
index bbb4bc8..4e85dae 100644
--- a/checks/menu-format
+++ b/checks/menu-format
@@ -396,7 +396,7 @@ closedir MENUDIR;
# Find the desktop files in the package for verification.
my @desktop_files;
-foreach my $file (sort keys %{$info->index}) {
+foreach my $file (@{$info->sorted_index}) {
my $index_info = $info->index->{$file};
my $operm = $index_info->{operm};
diff --git a/checks/scripts b/checks/scripts
index 54aa37b..1acd2b0 100644
--- a/checks/scripts
+++ b/checks/scripts
@@ -312,7 +312,7 @@ my $pkg = shift;
[SCM] Debian package checker branch, master, updated. 2.4.3-21-g6d868dc
The following commit has been merged in the master branch: commit 6d868dcf683f3bda40c3ac76afb84c5c7e7629e8 Author: David Bremner Date: Mon Dec 20 22:59:33 2010 -0400 debian/rules: Add support for skipping the test suite per policy 4.9.1 + [NT] Add support for skipping the test suite per policy 4.9.1. Many thanks to David Bremner for the patch. Signed-off-by: Niels Thykier diff --git a/debian/changelog b/debian/changelog index df45810..877755a 100755 --- a/debian/changelog +++ b/debian/changelog @@ -52,6 +52,8 @@ lintian (2.4.4) UNRELEASED; urgency=low * debian/rules: + [RA] Run the test suite during the package build. + [NT] Replace dh_clean -k with dh_prep. ++ [NT] Add support for skipping the test suite per policy 4.9.1. + Many thanks to David Bremner for the patch. * debian/compat: + [NT] Bump debhelper comat to 7. diff --git a/debian/rules b/debian/rules index 81ceab8..a4a9bc8 100755 --- a/debian/rules +++ b/debian/rules @@ -14,6 +14,12 @@ perlprovides := data/fields/perl-provides onlyrun = tag = +ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) + testtarget = runtests +else + testtarget = +endif + runtests: $(neededfiles) $(allchecks) $(allcollect) $(tagfiles) $(testfiles) @echo running tests rm -rf debian/tests @@ -37,7 +43,7 @@ refresh-perl-provides: perl private/refresh-perl-provides > $(perlprovides) build: build-stamp -build-stamp: $(neededfiles) $(docsource) runtests +build-stamp: $(neededfiles) $(docsource) $(testtarget) @echo running build dh_testdir cd doc && LANG=C debiandoc2html lintian.sgml -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pvklj-0005ic...@alioth.debian.org
Re: [PATCH] debian/rules: Add support for skipping the test suite per policy 4.9.1
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2010-12-21 03:59, brem...@debian.org wrote: > From: David Bremner > > Rational: the lintian test suite is somewhat heavyweight, and > sometimes broken in git. This makes it hard for people to test new > lintian checks. > --- > debian/rules |8 +++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/debian/rules b/debian/rules > index 77861c5..497ca49 100755 > --- a/debian/rules > +++ b/debian/rules > [...] Hi Applied and pushed[1], thanks for the patch. ~Niels [1] http://git.debian.org/?p=lintian/lintian.git;a=commit;h=6d868dcf683f3bda40c3ac76afb84c5c7e7629e8 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNEcENAAoJEAVLu599gGRCOfsQAKNG5sWopfhhrI1i6cgDpuC+ PEA0OT7O4E3KC4Apftq2zbTD5ziABtKMk4q1SGMdW08rZClXzwGbUB2rRB45oRgg kuqd/qQl7MpfX1k5oBXjwJk8ePWNlofD+HD4nm1cJAGlT/wP/2GnS2XRDtJJa2pz AFQzZ/znz30FE2MjwrEEz+3GxFUS3HKgQ2nnCDsQSpzEHkLya22kdnQz1BTHW12N 4LuAISgWWxHR6VF+ANVrWsBNIullVoCeHVrrOdKt5gFgA4uI3dPNluZwPKOzI9Dm eWtWEyEMq8IjpeUMDhOxHc6VuO0YrO/W/7ooWaCMaAcP76G1V/HR15Hu9tWuf5z5 3Aj12GMPsbk7/RkXex7/Fk3fpmqvMVtxCcFtX5cSxVf20msSvpDwsiY1neLkTDXf h/37XVIGgTdiIvDhzAnyHetFNw5mwgiM3QlbKvoyjywLayjCWlQkoaeLHYVO7XkU ZvcoSSe6LtvwFBtHB9Cem8Cmv309a3bkh0BGd5nUzH0SxVWVzh6igvupwo/9OjnH XcvhZPOyWyexYJm9UBAbFRtEAIsScfpkzf1dCOSmAThHTsTqS+F6IY+hj+7DFm9A A3dw2Z3L89H1VkxNBIgotn/IkKdhVbN/hhKUhhj611kA0WnBDwX+sToPmiMcTtw/ gV1LaRRpFm/x9IYxddfZ =1nnz -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4d11c10d.8090...@thykier.net
Bug#528001: Appears to have been fixed in 2.3.4
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 tags 528001 - patch thanks Hi It appears that all the patches here have been applied. I have not closed it because I assumed it was still open since there is no check for (e.g.) d/source/include-binaries. ~Niels -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNEcOdAAoJEAVLu599gGRC7YEP/R4BKHg5ynGgRAX463i52Pcg 4J8lawJH+LalxCD3N5LXF8oWM5+k+pbGX4+iLtJL6MSUukyF6j3JW5e6ShTPXz+A z08g4jdDf3Di5cnxvqU0jpqdy8UPOnqbNJ37OuP2ZjkrNZalkQ9fsueXDSenUrDT 2iIWCalyS4iOm1F+cQ7RL1i0cd1VkGDdAOFTZumLjJWL+QZffnMOcMQTxbtyWzKa 0lKqhdENNOX5ML07oQc2AyR7sk2WWku/toh/8p3kJ8va0XhxZdndofD/HDYYFbZ2 at/oyjw/ZINs1u30/AzBbi+T68m/eceY/8nU0bcS2ZSrb1wfQCK+w1M8Yr5T+y6i jV3b4LFWvWtvNE9Oh97oPp2mVI3ZLCogHrBRAWVZrpthK2qWYdCmbnyDmVJ5Xwft 13JCl0H1kU0RUxSQi5nwR7nSvn2MglAD4AgS7B34mjv4eXUzzB70kCf3KE7mTmN7 k64btzi1rOVD4rTY2DtKl0lD7qVmgSLaEswYnLV+jw7AHP84cyC/exLGAF/4/hV/ BDqEPHExhoqWv/St2BUlWVmxVZvUp5X7M7vpCU8th/gH2fD/6c5nUGKz77/01iFD 7ZUX/ZxXkC7xovvtDT3ZR8Ocx5brwnuaRuhknUOpBJ0PwlJ8aOyZNDr+Ua/PkDlN BYJPK4YHRP+vHDjNuzNJ =1uKi -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4d11c39d.7040...@thykier.net
Processed: Appears to have been fixed in 2.3.4
Processing commands for cont...@bugs.debian.org: > tags 528001 - patch Bug #528001 [lintian] [new check] syntax-check new source control files Removed tag(s) patch. > thanks Stopping processing here. Please contact me if you need assistance. -- 528001: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=528001 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.129300993425445.transcr...@bugs.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-23-g95bb4b1
The following commit has been merged in the master branch:
commit 6cf684cac7e1e4ec92260e6bf03358cf9cc1e4ea
Author: Niels Thykier
Date: Wed Dec 22 10:57:16 2010 +0100
Fixed needs-info-missing.t, which was broken by commit 5b36419
diff --git a/t/scripts/needs-info-missing.t b/t/scripts/needs-info-missing.t
index 3999fce..c658487 100755
--- a/t/scripts/needs-info-missing.t
+++ b/t/scripts/needs-info-missing.t
@@ -73,6 +73,8 @@ for my $module (@MODULES) {
}
delete $seen_subs{'new'};
+# Extension of index
+delete $seen_subs{'sorted_index'};
is(scalar(keys(%seen_subs)) + scalar(keys(%seen_needsinfo)), 0,
"$pretty_module has per-method needs-info") or
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvlwt-0006pe...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-23-g95bb4b1
The following commit has been merged in the master branch:
commit 95bb4b1b5ed1c1ee3f3f072ba1353ba28502681c
Author: Niels Thykier
Date: Wed Dec 22 10:58:37 2010 +0100
Fixed the test regressions caused by commit 894daa6. (Closes #606270)
Made nmu-ubuntu-native Test-Against bad-distribution-in-changes-file,
since it may be broken every time we EOL Ubuntu releases.
diff --git a/t/tests/distribution-ubuntu-native/debian/debian/changelog.in
b/t/tests/distribution-ubuntu-native/debian/debian/changelog.in
index 2731d63..ea4d4f6 100644
--- a/t/tests/distribution-ubuntu-native/debian/debian/changelog.in
+++ b/t/tests/distribution-ubuntu-native/debian/debian/changelog.in
@@ -1,4 +1,4 @@
-{$srcpkg} ({$version}) jaunty; urgency=low
+{$srcpkg} ({$version}) lucid; urgency=low
* Lintian Test Suite.
* Test: {$testname}
diff --git a/t/tests/nmu-ubuntu-native/debian/debian/changelog.in
b/t/tests/nmu-ubuntu-native/debian/debian/changelog.in
index 48636ac..d922e3b 100644
--- a/t/tests/nmu-ubuntu-native/debian/debian/changelog.in
+++ b/t/tests/nmu-ubuntu-native/debian/debian/changelog.in
@@ -1,4 +1,4 @@
-{$srcpkg} ({$version}) jaunty; urgency=low
+{$srcpkg} ({$version}) lucid; urgency=low
* Lintian Test Suite.
* Test: {$testname}
diff --git a/t/tests/nmu-ubuntu-native/desc b/t/tests/nmu-ubuntu-native/desc
index 6bc454a..3ab6019 100644
--- a/t/tests/nmu-ubuntu-native/desc
+++ b/t/tests/nmu-ubuntu-native/desc
@@ -3,4 +3,5 @@ Sequence: 6000
Version: 1.0
Description: Test NMU tag suppression for Ubuntu native packages
Test-Against: changelog-should-mention-nmu
+ bad-distribution-in-changes-file
References: Debian Bug #507740
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvlx1-0006sl...@alioth.debian.org
Bug#606270: marked as done (lintian: commit 894daa630bdf (most likely) caused test regressions)
Your message dated Wed, 22 Dec 2010 11:02:00 +0100 with message-id <4d11cc98.60...@thykier.net> and subject line Re: lintian: commit 894daa630bdf (most likely) caused test regressions has caused the Debian Bug report #606270, regarding lintian: commit 894daa630bdf (most likely) caused test regressions to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 606270: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=606270 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems --- Begin Message --- Package: lintian Version: 2.4.4 test output: ... Running test distribution-ubuntu-native 1.0... building... testing... FAILED: --- t/tests/distribution-ubuntu-native/tags 2010-08-03 15:05:07.354069756 +0200 +++ debian/tests/tags.distribution-ubuntu-native2010-12-07 23:21:50.378531654 +0100 @@ -0,0 +1 @@ +E: distribution-ubuntu-native_1.0_i386 changes: bad-distribution-in-changes-file jaunty ... Running test nmu-ubuntu-native 1.0... building... testing... FAILED: --- t/tests/nmu-ubuntu-native/tags 2010-08-03 15:05:07.775100644 +0200 +++ debian/tests/tags.nmu-ubuntu-native 2010-12-07 23:38:15.819550625 +0100 @@ -0,0 +1,3 @@ +E: nmu-ubuntu-native_1.0_i386 changes: bad-distribution-in-changes-file jaunty +W: nmu-ubuntu-native source: changelog-should-mention-nmu +W: nmu-ubuntu-native source: source-nmu-has-incorrect-version-number 1.0 ... I strongly suspect that this commit[1] broke these tests when the commit did not update the tests to reflect current valid Ubuntu code names. ~Niels [1] http://git.debian.org/?p=lintian/lintian.git;a=commit;h=894daa630bdf88e59ff3683857d1d808be2d3c1b --- End Message --- --- Begin Message --- -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Fixed in git[1]. ~Niels [1] http://git.debian.org/?p=lintian/lintian.git;a=commit;h=95bb4b1b5ed1c1ee3f3f072ba1353ba28502681c -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNEcyYAAoJEAVLu599gGRCOikQAKnJIK9hNcf4JiZt/C4gzAKF 4AUBnu69xqbaVvtMRwG1ZKGE+yxF6uHdS+xvCbZZoJbTDXs8CcajIGS9rlSq/XPQ rNB6xBa6HVb1DuUzDf7oXk7G2LH7XClkEfe9qimRp3/N0z/8yeshdXhHvuijv4n1 5OcE/wnWRbBw84JmGiKJP4qmtZJBPy8i8aYsowy4Ixgg9EAwylucK2bIoU1LxZv3 sdvH7GAmU0VquEkeWt5TMyBOPumcpsfEZFiLxsqumywCoHtjkHhNrfD4b2Xp9x2g SsW01X5fVKHTZUrcNxmK1KxIqp03ylgNXuep1BSigQ5YZTg5ENCjrKQpQ31w+HsZ giKNh10tti9QS8KE0iCU5Fsddsm7HLOc0PRTORilQGlaLmfEMGLYzpE2g7CzHk8E p9zQUqfbTmsg0uc9KGT0eDtqf2EprHG1vksINGSLzw2d5OI34ywl+oW3R+LJ6hCH ePIg7Jpjogq38dTHQJooY3GjSVYPF2LF0PVo/afpWQGXeEzDuEOT6n13K09cWGJX a9o6M/8CjDbp/pIZI9Iz+9eB1bLoyEcu0BR5uL7in4/e+dcVFC7UtAt5N1CHYiaG tRyb55NvwRgs9J0IvUG8ew9nGy//Nuj6P2t+OT2MV18dBEjMzYTrQq8g5W3frCSL zVhbJoHVTHyWEV7AEwLL =fm88 -END PGP SIGNATURE- --- End Message ---
lintian test suite
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi I had a look at the test suite and it is only a few hick-ups short of being issue free (at least on a x86). I have attached the failures I saw. I heard that some of the legacy tests are known to fail on non-x86 architectures; but I do not have a non-x86 system, so I could not verify this. If anyone has a bit of time to look at them, I would appreciate it. ~Niels -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNEdqIAAoJEAVLu599gGRCtG8P/joRyiZlvXqce0LfnZkQbC42 Jkf0DGcSReE/xOMtZdNhs4GRfjuO5fY3HGDXvL/5vnWybWRBXv7l5gAwgN9IOMNX SiS0N1JTrqGr+bN8fC1Q6ygkFfdTenXSRm7Bv9gfpoqFkhoPoatyMVxRIQlGBQhh eZlZ1NGbUeuxpJmQkHjXfOM2q2OA/UEwuxxfCzAMIhRczT8nZR7G1T+MaqfT/iKm IV840f9kYZb5sYF1jb/uj8JHesGa72NfwfCMp3k9eYAJc+zZaPrGkp8//BrnWt9/ //fYZDNZRycdywMXt7px7QIedbLS41IFiH3UL1hqZOd5JEsKGddfJ0p72vQP9Vh3 9LR5v4L8dpO9iCaFNZfUrn1eiNKYK/zKYz23wnjm4bkVbqdHRtWu6TFT4sludCxw BsUTFQIRXYlms1jyXg5KriSMSKhSY8vpsx30AF+EKRvkWkrkUtpxPcOYrRVBRfwH Fa3sAFKrevXAQaMVhccgqyhGD8tQIuFOmH5d+HRv3G2DVx8F32neW/mtAQjsFJWR 5yqabyPsSOL1G6PGH2a632CXMFsslNcGHh6GA/Lilohr8O5XkUKRnpTugDZGPHJR R35utKMWuRXi9kiEJUImBZLQAS2NFxyTaVSgZ9LRp56fWFmEFFGh50m4NFk9b3R1 kIFVFyrzGWraTv6DMLF4 =xKId -END PGP SIGNATURE- t/scripts/minimum-version.t ... 51/100 # Failed test '/home/user/debian/lintian/t/runtests' # at /usr/share/perl5/Test/MinimumVersion.pm line 104. # /home/user/debian/lintian/t/runtests requires 5.012 due to syntax # version markers for 5.012: # - _yada_yada_yada t/scripts/minimum-version.t ... 100/100 # Looks like you failed 1 test of 100. t/scripts/minimum-version.t ... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/100 subtests Test Summary Report --- t/scripts/minimum-version.t (Wstat: 256 Tests: 100 Failed: 1) Failed test: 51 Non-zero exit status: 1 Running test package-version-0... building... testing... FAILED: --- t/source/package-version-0/tags 2010-08-03 15:05:06.726070395 +0200 +++ debian/tests/tags.package-version-0 2010-12-22 11:04:02.471068769 +0100 @@ -1 +0,0 @@ -E: package-version-0 source: upstream-version-not-numeric unknown tests.sig Description: Binary data
[SCM] Debian package checker branch, master, updated. 2.4.3-24-gdb0e678
The following commit has been merged in the master branch:
commit db0e6781185c8c0c8ce14883ff28d91f90d52a73
Author: Niels Thykier
Date: Wed Dec 22 12:43:01 2010 +0100
Implemented fields-build-depends; it checks for some build-depends issues
that was previously only present in the legacy suite.
Updated t/COVERAGE.
diff --git a/t/COVERAGE b/t/COVERAGE
index a8ab743..1ebe133 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -1,4 +1,4 @@
-Last generated 2010-08-23
+Last generated 2010-12-22
The following tags are not tested by the test suite:
@@ -163,18 +163,12 @@ po-debconf missing-templates-pot
po-debconf not-using-po-debconf
rules debian-rules-is-symlink
-rules debian-rules-not-a-makefile
scripts csh-considered-harmful
-scripts gawk-script-but-no-gawk-dep
scripts killall-is-dangerous
scripts maintainer-script-needs-depends-on-adduser
scripts maintainer-script-needs-depends-on-update-inetd
-scripts mawk-script-but-no-mawk-dep
scripts mknod-in-maintainer-script
-scripts ruby-script-but-no-ruby-dep
-scripts tclsh-script-but-no-tclsh-dep
-scripts wish-script-but-no-wish-dep
shared-libs dev-pkg-without-shlib-symlink
shared-libs ldconfig-symlink-before-shlib-in-deb
@@ -258,19 +252,13 @@ debhelper uses-dh-python-with-no-pycompat
etcfiles file-in-etc-not-marked-as-conffile
-fields build-conflicts-with-build-dependency
fields build-depends-indep-without-arch-indep
-fields build-depends-on-1-revision
-fields build-depends-on-build-essential
-fields build-depends-on-essential-package-without-using-version
-fields build-depends-on-obsolete-package
fields conflicts-with-dependency
fields dbg-package-missing-depends
fields debian-revision-not-well-formed
fields debian-revision-should-not-be-zero
fields debug-package-should-be-priority-extra
fields depends-exclusively-on-makedev
-fields depends-on-build-essential-package-without-using-version
fields depends-on-essential-package-without-using-version
fields depends-on-obsolete-package
fields depends-on-old-emacs
@@ -304,7 +292,6 @@ files dir-or-file-in-var-www
files embedded-feedparser-library
files embedded-javascript-library
files executable-is-not-world-readable
-files extra-license-file
files file-directly-in-usr-share
files file-directly-in-usr-share-doc
files file-in-unusual-dir
@@ -596,7 +583,6 @@ filenames
dir-or-file-in-var-www
embedded-feedparser-library
embedded-javascript-library
- extra-license-file
file-in-usr-lib-sgml
macos-ds-store-file-in-package
macos-resource-fork-file-in-package
@@ -693,14 +679,8 @@ maintainer-scripts
wrong-debian-qa-group-name
relations
- build-conflicts-with-build-dependency
- build-depends-on-1-revision
- build-depends-on-build-essential
- build-depends-on-essential-package-without-using-version
- build-depends-on-obsolete-package
conflicts-with-dependency
depends-exclusively-on-makedev
- depends-on-build-essential-package-without-using-version
depends-on-essential-package-without-using-version
depends-on-obsolete-package
depends-on-old-emacs
diff --git a/t/tests/cruft-updated-libtool/debian/debian/control.in
b/t/tests/fields-build-depends/debian/debian/control.in
similarity index 74%
copy from t/tests/cruft-updated-libtool/debian/debian/control.in
copy to t/tests/fields-build-depends/debian/debian/control.in
index 82de9d0..650d4f1 100644
--- a/t/tests/cruft-updated-libtool/debian/debian/control.in
+++ b/t/tests/fields-build-depends/debian/debian/control.in
@@ -1,9 +1,11 @@
Source: {$srcpkg}
Priority: extra
-Section: {$section}
+Section: devel
Maintainer: {$author}
Standards-Version: {$standards_version}
-Build-Depends: debhelper (>= 7), libtool
+Build-Depends: debhelper (>= 7.0.50~), bd-conflict, revision-1 (>= 1.0-1),
+ bash, make, x-dev, build-essential
+Build-Conflicts: bd-conflict
Package: {$srcpkg}
Architecture: {$architecture}
@@ -13,3 +15,4 @@ Description: {$description}
Lintian. It is part of the Lintian test suite and may do very odd
things. It should not be installed like a regular package. It may
be an empty package.
+
diff --git a/t/tests/fields-build-depends/desc
b/t/tests/fields-build-depends/desc
new file mode 100644
index 000..e1e810f
--- /dev/null
+++ b/t/tests/fields-build-depends/desc
@@ -0,0 +1,12 @@
+Testname: fields-build-depends
+Sequence: 6000
+Version: 1.0
+Description: Check for sane build depends
+Test-For:
+ build-conflicts-with-build-dependency
+ build-depends-on-1-revision
+ build-depends-on-build-essential
+ build-depends-on-essential-package-without-using-version
+ depends-on-build-essential-package-without-using-version
+ build-depends-on-obsolete-package
+
diff --git a/t/tests/fields-build-depends/tags
b/t/tests/fields-build-depends/tags
new file mode 100644
index 000..698f8ef
--- /dev/null
+++ b/t/tests/fields-build-depends/tags
@@ -0,0 +1,6 @@
+E: fields-build-depends source: build-conflicts-with-build-dependency
bd-conflict
+E: fields-build-depends source: build-depen
Re: lintian test suite
On Wed, December 22, 2010 11:01, Niels Thykier wrote: > I had a look at the test suite and it is only a few hick-ups short of > being issue free (at least on a x86). I have attached the failures I saw. Thanks for that. This: t/scripts/minimum-version.t ... 51/100 # Failed test '/home/user/debian/lintian/t/runtests' # at /usr/share/perl5/Test/MinimumVersion.pm line 104. # /home/user/debian/lintian/t/runtests requires 5.012 due to syntax # version markers for 5.012: # - _yada_yada_yada is a false positive caused by libperl-minimumversion-perl 1.26-1; see #607547, which Bremner filed after discovering a similar issue whilst trying to test one of his recent patches. I confirmed at the time that downgrading to 1.25-2 makes the test pass again. > I heard that some of the legacy tests are known to fail on non-x86 > architectures; but I do not have a non-x86 system, so I could not verify > this. That would be libbaz (which I keep confusing with foo++ and referring to as libfoo) which is the only test case we have currently for shlib-with-non-pic-code. Trying to build such an object on amd64 will fail and subsequently make the test fail. There have been a number of discussions regarding how to fix this over the past couple of years (at least one involving beer) but we don't appear to have implemented a solution as yet. Regards, Adam -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/3b5578e29ef1f9d5762f784fe1db4a82.squir...@adsl.funky-badger.org
[SCM] Debian package checker branch, master, updated. 2.4.3-28-g20f9f99
The following commit has been merged in the master branch:
commit 36eaa280e0b90bc7281b68c6d2035e56124ad09f
Author: Niels Thykier
Date: Wed Dec 22 16:07:51 2010 +0100
Extended fields-build-depends test to also check for
ored-build-depends-on-obsolete-package
diff --git a/t/COVERAGE b/t/COVERAGE
index 1ebe133..c7f01f6 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -265,7 +265,6 @@ fields depends-on-old-emacs
fields depends-on-python-minimal
fields malformed-dm-upload-allowed
fields needlessly-depends-on-awk
-fields ored-build-depends-on-obsolete-package
fields ored-depends-on-obsolete-package
fields package-depends-on-multiple-libpng-versions
fields package-depends-on-multiple-libstdc-versions
@@ -685,7 +684,6 @@ relations
depends-on-obsolete-package
depends-on-old-emacs
needlessly-depends-on-awk
- ored-build-depends-on-obsolete-package
ored-depends-on-obsolete-package
package-depends-on-multiple-libpng-versions
package-depends-on-multiple-libstdc-versions
diff --git a/t/tests/fields-build-depends/debian/debian/control.in
b/t/tests/fields-build-depends/debian/debian/control.in
index 650d4f1..c9aad19 100644
--- a/t/tests/fields-build-depends/debian/debian/control.in
+++ b/t/tests/fields-build-depends/debian/debian/control.in
@@ -4,7 +4,7 @@ Section: devel
Maintainer: {$author}
Standards-Version: {$standards_version}
Build-Depends: debhelper (>= 7.0.50~), bd-conflict, revision-1 (>= 1.0-1),
- bash, make, x-dev, build-essential
+ bash, make, x-dev, build-essential, new-package | xlibmesa-gl-dev
Build-Conflicts: bd-conflict
Package: {$srcpkg}
diff --git a/t/tests/fields-build-depends/desc
b/t/tests/fields-build-depends/desc
index e1e810f..e54cef9 100644
--- a/t/tests/fields-build-depends/desc
+++ b/t/tests/fields-build-depends/desc
@@ -9,4 +9,5 @@ Test-For:
build-depends-on-essential-package-without-using-version
depends-on-build-essential-package-without-using-version
build-depends-on-obsolete-package
+ ored-build-depends-on-obsolete-package
diff --git a/t/tests/fields-build-depends/tags
b/t/tests/fields-build-depends/tags
index 698f8ef..83c15cc 100644
--- a/t/tests/fields-build-depends/tags
+++ b/t/tests/fields-build-depends/tags
@@ -3,4 +3,5 @@ E: fields-build-depends source:
build-depends-on-build-essential build-depends
E: fields-build-depends source:
build-depends-on-essential-package-without-using-version build-depends: bash
E: fields-build-depends source: build-depends-on-obsolete-package
build-depends: x-dev
E: fields-build-depends source:
depends-on-build-essential-package-without-using-version make [build-depends:
make]
+I: fields-build-depends source: ored-build-depends-on-obsolete-package
build-depends: xlibmesa-gl-dev
W: fields-build-depends source: build-depends-on-1-revision build-depends:
revision-1 (>= 1.0-1)
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvrcr-0001xx...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-28-g20f9f99
The following commit has been merged in the master branch:
commit e47231ba247a865183aff710e262e2fa38fd7d6c
Author: Niels Thykier
Date: Wed Dec 22 16:32:47 2010 +0100
Move all Build-Depends related issues from fields-depends-general
to fields-build-depends.
diff --git a/t/tests/fields-build-depends/debian/debian/control.in
b/t/tests/fields-build-depends/debian/debian/control.in
index c9aad19..8a18228 100644
--- a/t/tests/fields-build-depends/debian/debian/control.in
+++ b/t/tests/fields-build-depends/debian/debian/control.in
@@ -4,7 +4,10 @@ Section: devel
Maintainer: {$author}
Standards-Version: {$standards_version}
Build-Depends: debhelper (>= 7.0.50~), bd-conflict, revision-1 (>= 1.0-1),
- bash, make, x-dev, build-essential, new-package | xlibmesa-gl-dev
+ bash, make, x-dev, build-essential, new-package | xlibmesa-gl-dev,
+ xorg-dev, java-propose-classpath, python3.1-dev, foo [all],
+ bar [i386 any], baz [source i3!86], baz [i386 !amd64],
+ other-pkg [kfreebsd-any], yet-another [any-powerpc]
Build-Conflicts: bd-conflict
Package: {$srcpkg}
diff --git a/t/tests/fields-build-depends/desc
b/t/tests/fields-build-depends/desc
index e54cef9..fe2f4f8 100644
--- a/t/tests/fields-build-depends/desc
+++ b/t/tests/fields-build-depends/desc
@@ -7,7 +7,12 @@ Test-For:
build-depends-on-1-revision
build-depends-on-build-essential
build-depends-on-essential-package-without-using-version
- depends-on-build-essential-package-without-using-version
+ build-depends-on-metapackage
+ build-depends-on-non-build-package
build-depends-on-obsolete-package
+ build-depends-on-python-dev-with-no-arch-any
+ conflicting-negation-in-source-relation
+ depends-on-build-essential-package-without-using-version
+ invalid-arch-string-in-source-relation
ored-build-depends-on-obsolete-package
-
+References: Debian Bug#540594, Debian Bug#551793
diff --git a/t/tests/fields-build-depends/tags
b/t/tests/fields-build-depends/tags
index 83c15cc..98b1f04 100644
--- a/t/tests/fields-build-depends/tags
+++ b/t/tests/fields-build-depends/tags
@@ -1,7 +1,14 @@
E: fields-build-depends source: build-conflicts-with-build-dependency
bd-conflict
E: fields-build-depends source: build-depends-on-build-essential build-depends
E: fields-build-depends source:
build-depends-on-essential-package-without-using-version build-depends: bash
+E: fields-build-depends source: build-depends-on-metapackage build-depends:
xorg-dev
+E: fields-build-depends source: build-depends-on-non-build-package
build-depends: java-propose-classpath
E: fields-build-depends source: build-depends-on-obsolete-package
build-depends: x-dev
+E: fields-build-depends source: conflicting-negation-in-source-relation
build-depends: baz [i386 !amd64]
E: fields-build-depends source:
depends-on-build-essential-package-without-using-version make [build-depends:
make]
+E: fields-build-depends source: invalid-arch-string-in-source-relation all
[build-depends: foo [all]]
+E: fields-build-depends source: invalid-arch-string-in-source-relation i3!86
[build-depends: baz [source i3!86]]
+E: fields-build-depends source: invalid-arch-string-in-source-relation source
[build-depends: baz [source i3!86]]
I: fields-build-depends source: ored-build-depends-on-obsolete-package
build-depends: xlibmesa-gl-dev
W: fields-build-depends source: build-depends-on-1-revision build-depends:
revision-1 (>= 1.0-1)
+W: fields-build-depends source: build-depends-on-python-dev-with-no-arch-any
diff --git a/t/tests/fields-depends-general/debian/debian/control.in
b/t/tests/fields-depends-general/debian/debian/control.in
index ca24c2d..e914ad8 100644
--- a/t/tests/fields-depends-general/debian/debian/control.in
+++ b/t/tests/fields-depends-general/debian/debian/control.in
@@ -3,9 +3,7 @@ Priority: extra
Section: {$section}
Maintainer: {$author}
Standards-Version: {$standards_version}
-Build-Depends: debhelper (>= 7.0.50~), xorg-dev, java-propose-classpath,
- python3.1-dev, foo [all], bar [i386 any], baz [source i3!86],
- baz [i386 !amd64], other-pkg [kfreebsd-any], yet-another [any-powerpc]
+Build-Depends: debhelper (>= 7.0.50~)
Package: {$srcpkg}
Architecture: {$architecture}
diff --git a/t/tests/fields-depends-general/desc
b/t/tests/fields-depends-general/desc
index b38609b..b2eca24 100644
--- a/t/tests/fields-depends-general/desc
+++ b/t/tests/fields-depends-general/desc
@@ -4,12 +4,7 @@ Version: 1.0
Description: General tests for package dependencies
Test-For:
breaks-without-version
- build-depends-on-metapackage
- build-depends-on-non-build-package
- build-depends-on-python-dev-with-no-arch-any
- conflicting-negation-in-source-relation
conflicts-with-version
depends-on-metapackage
- invalid-arch-string-in-source-relation
lib-recommends-documentation
-References: Debian Bug#540594, Debian Bug#551793
+
diff --git a/t/tests/fields-depends-general/tags
b/t/tests/fields-depends-general/tags
index 62c13a3..5b34d55 100644
--- a/t/tests/fields-depends-general/tags
+++ b/
[SCM] Debian package checker branch, master, updated. 2.4.3-28-g20f9f99
The following commit has been merged in the master branch: commit a15414f0e27f66419a03658d24aa8a061c541660 Author: Niels Thykier Date: Wed Dec 22 16:35:48 2010 +0100 Renamed fields-build-depends test to fields-build-depends-general. diff --git a/t/tests/fields-build-depends/debian/debian/control.in b/t/tests/fields-build-depends-general/debian/debian/control.in similarity index 100% rename from t/tests/fields-build-depends/debian/debian/control.in rename to t/tests/fields-build-depends-general/debian/debian/control.in diff --git a/t/tests/fields-build-depends/desc b/t/tests/fields-build-depends-general/desc similarity index 86% rename from t/tests/fields-build-depends/desc rename to t/tests/fields-build-depends-general/desc index fe2f4f8..1bb26b7 100644 --- a/t/tests/fields-build-depends/desc +++ b/t/tests/fields-build-depends-general/desc @@ -1,7 +1,7 @@ -Testname: fields-build-depends +Testname: fields-build-depends-general Sequence: 6000 Version: 1.0 -Description: Check for sane build depends +Description: General tests for build dependencies Test-For: build-conflicts-with-build-dependency build-depends-on-1-revision diff --git a/t/tests/fields-build-depends-general/tags b/t/tests/fields-build-depends-general/tags new file mode 100644 index 000..d0ff234 --- /dev/null +++ b/t/tests/fields-build-depends-general/tags @@ -0,0 +1,14 @@ +E: fields-build-depends-general source: build-conflicts-with-build-dependency bd-conflict +E: fields-build-depends-general source: build-depends-on-build-essential build-depends +E: fields-build-depends-general source: build-depends-on-essential-package-without-using-version build-depends: bash +E: fields-build-depends-general source: build-depends-on-metapackage build-depends: xorg-dev +E: fields-build-depends-general source: build-depends-on-non-build-package build-depends: java-propose-classpath +E: fields-build-depends-general source: build-depends-on-obsolete-package build-depends: x-dev +E: fields-build-depends-general source: conflicting-negation-in-source-relation build-depends: baz [i386 !amd64] +E: fields-build-depends-general source: depends-on-build-essential-package-without-using-version make [build-depends: make] +E: fields-build-depends-general source: invalid-arch-string-in-source-relation all [build-depends: foo [all]] +E: fields-build-depends-general source: invalid-arch-string-in-source-relation i3!86 [build-depends: baz [source i3!86]] +E: fields-build-depends-general source: invalid-arch-string-in-source-relation source [build-depends: baz [source i3!86]] +I: fields-build-depends-general source: ored-build-depends-on-obsolete-package build-depends: xlibmesa-gl-dev +W: fields-build-depends-general source: build-depends-on-1-revision build-depends: revision-1 (>= 1.0-1) +W: fields-build-depends-general source: build-depends-on-python-dev-with-no-arch-any diff --git a/t/tests/fields-build-depends/tags b/t/tests/fields-build-depends/tags deleted file mode 100644 index 98b1f04..000 --- a/t/tests/fields-build-depends/tags +++ /dev/null @@ -1,14 +0,0 @@ -E: fields-build-depends source: build-conflicts-with-build-dependency bd-conflict -E: fields-build-depends source: build-depends-on-build-essential build-depends -E: fields-build-depends source: build-depends-on-essential-package-without-using-version build-depends: bash -E: fields-build-depends source: build-depends-on-metapackage build-depends: xorg-dev -E: fields-build-depends source: build-depends-on-non-build-package build-depends: java-propose-classpath -E: fields-build-depends source: build-depends-on-obsolete-package build-depends: x-dev -E: fields-build-depends source: conflicting-negation-in-source-relation build-depends: baz [i386 !amd64] -E: fields-build-depends source: depends-on-build-essential-package-without-using-version make [build-depends: make] -E: fields-build-depends source: invalid-arch-string-in-source-relation all [build-depends: foo [all]] -E: fields-build-depends source: invalid-arch-string-in-source-relation i3!86 [build-depends: baz [source i3!86]] -E: fields-build-depends source: invalid-arch-string-in-source-relation source [build-depends: baz [source i3!86]] -I: fields-build-depends source: ored-build-depends-on-obsolete-package build-depends: xlibmesa-gl-dev -W: fields-build-depends source: build-depends-on-1-revision build-depends: revision-1 (>= 1.0-1) -W: fields-build-depends source: build-depends-on-python-dev-with-no-arch-any diff --git a/t/tests/fields-depends-general/desc b/t/tests/fields-depends-general/desc index b2eca24..a39c0d9 100644 --- a/t/tests/fields-depends-general/desc +++ b/t/tests/fields-depends-general/desc @@ -1,7 +1,7 @@ Testname: fields-depends-general Sequence: 6000 Version: 1.0 -Description: General tests for package dependencies +Description: General tests for binary package dependencies Test-For: breaks-without-version conflicts-with-version -- Debian package checker -- To UNSUBSCRIB
[SCM] Debian package checker branch, master, updated. 2.4.3-28-g20f9f99
The following commit has been merged in the master branch:
commit 20f9f993175b670cbc1f4d9e7a69b7593ed169a6
Author: Niels Thykier
Date: Wed Dec 22 17:03:20 2010 +0100
Added some extra binary package relation checks to
fields-depends-general.
diff --git a/t/COVERAGE b/t/COVERAGE
index c7f01f6..c3ba494 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -253,25 +253,19 @@ debhelper uses-dh-python-with-no-pycompat
etcfiles file-in-etc-not-marked-as-conffile
fields build-depends-indep-without-arch-indep
-fields conflicts-with-dependency
fields dbg-package-missing-depends
fields debian-revision-not-well-formed
fields debian-revision-should-not-be-zero
fields debug-package-should-be-priority-extra
fields depends-exclusively-on-makedev
-fields depends-on-essential-package-without-using-version
-fields depends-on-obsolete-package
fields depends-on-old-emacs
fields depends-on-python-minimal
fields malformed-dm-upload-allowed
-fields needlessly-depends-on-awk
-fields ored-depends-on-obsolete-package
fields package-depends-on-multiple-libpng-versions
fields package-depends-on-multiple-libstdc-versions
fields package-depends-on-multiple-tcl-versions
fields package-depends-on-multiple-tk-versions
fields package-depends-on-multiple-tkx-versions
-fields package-relation-with-self
fields redundant-bugs-field
fields redundant-origin-field
fields unknown-section
@@ -678,19 +672,13 @@ maintainer-scripts
wrong-debian-qa-group-name
relations
- conflicts-with-dependency
depends-exclusively-on-makedev
- depends-on-essential-package-without-using-version
- depends-on-obsolete-package
depends-on-old-emacs
- needlessly-depends-on-awk
- ored-depends-on-obsolete-package
package-depends-on-multiple-libpng-versions
package-depends-on-multiple-libstdc-versions
package-depends-on-multiple-tcl-versions
package-depends-on-multiple-tk-versions
package-depends-on-multiple-tkx-versions
- package-relation-with-self
quilt-build-dep-but-no-series-file
redundant-bugs-field
redundant-origin-field
diff --git a/t/tests/fields-depends-general/debian/debian/control.in
b/t/tests/fields-depends-general/debian/debian/control.in
index e914ad8..230d62f 100644
--- a/t/tests/fields-depends-general/debian/debian/control.in
+++ b/t/tests/fields-depends-general/debian/debian/control.in
@@ -7,9 +7,11 @@ Build-Depends: debhelper (>= 7.0.50~)
Package: {$srcpkg}
Architecture: {$architecture}
-Depends: $\{shlibs:Depends\}, $\{misc:Depends\}, xorg
-Breaks: package-without-version
-Conflicts: package-with-version (<< 3.0)
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}, xorg, bash,
+ conflict-dep, gawk | awk, new-package | xbase-clients, {$srcpkg},
+ gaim
+Breaks: package-without-version, {$srcpkg} (<< 0.1)
+Conflicts: package-with-version (<< 3.0), conflict-dep
Description: {$description}
This is a test package designed to exercise some feature or tag of
Lintian. It is part of the Lintian test suite and may do very odd
diff --git a/t/tests/fields-depends-general/desc
b/t/tests/fields-depends-general/desc
index a39c0d9..520d978 100644
--- a/t/tests/fields-depends-general/desc
+++ b/t/tests/fields-depends-general/desc
@@ -4,7 +4,14 @@ Version: 1.0
Description: General tests for binary package dependencies
Test-For:
breaks-without-version
+ conflicts-with-dependency
conflicts-with-version
+ depends-on-essential-package-without-using-version
depends-on-metapackage
+ depends-on-obsolete-package
lib-recommends-documentation
+ needlessly-depends-on-awk
+ ored-depends-on-obsolete-package
+ package-depends-on-itself
+ package-relation-with-self
diff --git a/t/tests/fields-depends-general/tags
b/t/tests/fields-depends-general/tags
index 5b34d55..1a39a46 100644
--- a/t/tests/fields-depends-general/tags
+++ b/t/tests/fields-depends-general/tags
@@ -1,4 +1,11 @@
+E: fields-depends-general: conflicts-with-dependency depends conflict-dep
+E: fields-depends-general: depends-on-essential-package-without-using-version
depends: bash
E: fields-depends-general: depends-on-metapackage depends: xorg
+E: fields-depends-general: depends-on-obsolete-package depends: gaim
+E: fields-depends-general: needlessly-depends-on-awk depends
I: fields-depends-general: conflicts-with-version package-with-version (<< 3.0)
+I: fields-depends-general: ored-depends-on-obsolete-package depends:
xbase-clients
+W: fields-depends-general source: package-depends-on-itself
fields-depends-general depends
W: fields-depends-general: breaks-without-version package-without-version
+W: fields-depends-general: package-relation-with-self breaks:
fields-depends-general (<< 0.1)
W: libfields-depends-general: lib-recommends-documentation recommends:
debconf-doc
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvrcf-00023o...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-29-g3fbea3b
The following commit has been merged in the master branch:
commit 3fbea3b933c3591959165b3e6d61b90b4a0c41a7
Author: Niels Thykier
Date: Thu Dec 9 21:50:02 2010 +0100
Deprecate default-jdk-builddep and correct list of packages providing
dh_nativejava.
* checks/debhelper:
+ [NT] Fix dependency check for dh_nativejava, default-jdk has never
provided dh_nativejava. (Closes: #606506)
* data/fields/obsolete-packages:
+ [NT] Added default-jdk-builddep (replaced by gcj-native-helper).
diff --git a/checks/debhelper b/checks/debhelper
index 56bbc00..32adec2 100644
--- a/checks/debhelper
+++ b/checks/debhelper
@@ -120,10 +120,12 @@ while () {
if ($dh_commands_depends->known($dhcommand)) {
my $dep = $dh_commands_depends->value($dhcommand);
- # Special-case default-jdk-builddep. It appears to be a sort
- # of build-essential for Java applications.
+ # Special-case gcj-native-helper, which is a meta-package to
+ # pull this helper. default-jdk-builddep is obsolete, but
+ # we keep it for backwards compatibility, because it used to
+ # serve this purpose.
if ($dhcommand eq 'dh_nativejava') {
- $dep = "$dep | default-jdk | default-jdk-builddep";
+ $dep = "$dep | gcj-native-helper | default-jdk-builddep";
}
$missingbdeps{$dep} = $dhcommand;
}
diff --git a/data/fields/obsolete-packages b/data/fields/obsolete-packages
index 9726cf0..e4f2a17 100644
--- a/data/fields/obsolete-packages
+++ b/data/fields/obsolete-packages
@@ -56,3 +56,7 @@ xlibmesa-gl
xlibmesa-gl-dev
xlibmesa-glu
xutils
+
+# Last seen in Squeeze
+default-jdk-builddep
+
diff --git a/debian/changelog b/debian/changelog
index 877755a..beea800 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -11,6 +11,9 @@ lintian (2.4.4) UNRELEASED; urgency=low
+ [RA] Exclude kfreebsd-kernel-di-{amd64,i386} from the
embedded-zlib check since it's in the kernel. (Closes: #593397)
+ [RG] Add swipl to the list of known interpreters. (Closes: #591316)
+ * checks/debhelper:
++ [NT] Fix dependency check for dh_nativejava, default-jdk has never
+ provided dh_nativejava. (Closes: #606506)
* checks/debian-source-dir:
+ [NT] Added missing import of "Util" perl module. Thanks to David
Bremner for the patch.
@@ -37,6 +40,8 @@ lintian (2.4.4) UNRELEASED; urgency=low
intrepid and jaunty.
* data/fields/essential:
+ [RG] Add hurd. (Closes: #591323)
+ * data/fields/obsolete-packages:
++ [NT] Added default-jdk-builddep (replaced by gcj-native-helper).
* debian/control:
+ [RA] Add the build dependencies required to run the test suite
diff --git a/t/tests/debhelper-dh-nativejava/debian/debian/control.in
b/t/tests/debhelper-dh-nativejava/debian/debian/control.in
index cff247e..ccc9a46 100644
--- a/t/tests/debhelper-dh-nativejava/debian/debian/control.in
+++ b/t/tests/debhelper-dh-nativejava/debian/debian/control.in
@@ -3,7 +3,7 @@ Priority: extra
Section: {$section}
Maintainer: {$author}
Standards-Version: {$standards_version}
-Build-Depends: debhelper (>= 7), default-jdk-builddep
+Build-Depends: debhelper (>= 7), gcj-native-helper
Package: {$srcpkg}
Architecture: {$architecture}
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvrkf-0002ov...@alioth.debian.org
Processed: limit source to lintian, tagging 606506, tagging 605844
Processing commands for cont...@bugs.debian.org:
> #lintian (2.4.4) UNRELEASED; urgency=low
> #
> # * checks/debhelper:
> #+ [NT] Fix dependency check for dh_nativejava, default-jdk has never
> # provided dh_nativejava. (Closes: #606506)
> # * lib/Lintian/Collect/Binary.pm:
> #+ [NT] Create a sorted file index to avoid sorting it in the checks.
> # (Closes: #605844)
> #
> limit source lintian
Limiting to bugs with field 'source' containing at least one of 'lintian'
Limit currently set to 'source':'lintian'
> tags 606506 + pending
Bug #606506 [lintian] lintian: default-jdk-builddep is deprecated and
dh_nativejava is not provided by default-jdk
Added tag(s) pending.
> tags 605844 + pending
Bug #605844 [lintian] lintian: Consider pre-sorting keys %{$info->index}
Added tag(s) pending.
> thanks
Stopping processing here.
Please contact me if you need assistance.
--
605844: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=605844
606506: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=606506
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/handler.s.c.129303614912511.transcr...@bugs.debian.org
Re: lintian test suite
Adam D. Barratt wrote: >> I heard that some of the legacy tests are known to fail on non-x86 >> architectures; but I do not have a non-x86 system, so I could not verify >> this. > > That would be libbaz (which I keep confusing with foo++ and referring to > as libfoo) which is the only test case we have currently for > shlib-with-non-pic-code. Trying to build such an object on amd64 will > fail and subsequently make the test fail. There have been a number of > discussions regarding how to fix this over the past couple of years (at > least one involving beer) but we don't appear to have implemented a > solution as yet. If it is ported to a new-style test, it can be skipped on non-i386 architectures by adding the Architecture: i386 field to the desc file (see t/tests/runtests-arch-i386.) However, since libbaz has other tests, it might be worth splitting the arch- dependent part from the rest. Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/ietd5g$fa...@dough.gmane.org
[SCM] Debian package checker branch, master, updated. 2.4.3-30-g57a16e8
The following commit has been merged in the master branch:
commit 57a16e8bf68374f53d48d6048220522e09797fd9
Author: Niels Thykier
Date: Wed Dec 22 18:40:35 2010 +0100
Fix needs-info-missing the "right" way.
diff --git a/lib/Lintian/Collect/Binary.pm b/lib/Lintian/Collect/Binary.pm
index bc297fb..8198606 100644
--- a/lib/Lintian/Collect/Binary.pm
+++ b/lib/Lintian/Collect/Binary.pm
@@ -123,6 +123,7 @@ sub index {
}
# Returns sorted file index (eqv to sort keys %{$info->index}), except it is
cached.
+# sub sorted_index Needs-Info <>
sub sorted_index {
my ($self) = @_;
my $index;
diff --git a/t/scripts/needs-info-missing.t b/t/scripts/needs-info-missing.t
index c658487..3999fce 100755
--- a/t/scripts/needs-info-missing.t
+++ b/t/scripts/needs-info-missing.t
@@ -73,8 +73,6 @@ for my $module (@MODULES) {
}
delete $seen_subs{'new'};
-# Extension of index
-delete $seen_subs{'sorted_index'};
is(scalar(keys(%seen_subs)) + scalar(keys(%seen_needsinfo)), 0,
"$pretty_module has per-method needs-info") or
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvsht-da...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-31-g22e2a1e
The following commit has been merged in the master branch:
commit 22e2a1ebe8dac84235665f8a2803b5ced31f30d3
Author: Niels Thykier
Date: Tue Dec 7 23:48:52 2010 +0100
Added check for unneeded build-dep on quilt when building a 3.0 (quilt)
package, including a test case for it.
* Summary of tag changes:
+ Added:
- unneeded-build-dep-on-quilt
* checks/patch-systems{,.desc}
+ [NT] Added check for new unneeded-build-dep-on-quilt.
(Closes: #582767)
diff --git a/checks/patch-systems b/checks/patch-systems
index 9934d46..73337e9 100644
--- a/checks/patch-systems
+++ b/checks/patch-systems
@@ -118,6 +118,9 @@ sub run {
#- quilt
if ($build_deps->implies("quilt") or $quilt_format) {
$uses_patch_system++;
+ if($quilt_format && $build_deps->implies("quilt")){
+ tag "unneeded-build-dep-on-quilt";
+ }
#check for a debian/patches file:
if (! -r "debfiles/patches/series") {
tag "quilt-build-dep-but-no-series-file" unless
$quilt_format;
diff --git a/checks/patch-systems.desc b/checks/patch-systems.desc
index d77749b..f04a9bd 100644
--- a/checks/patch-systems.desc
+++ b/checks/patch-systems.desc
@@ -160,3 +160,11 @@ Info: This package build-depends on a patch system such as
dpatch or
referring to /usr/share/doc/quilt/README.source. Similarly, you
can refer to /usr/share/doc/dpatch/README.source.gz for dpatch.
Ref: policy 4.14
+
+Tag: unneeded-build-dep-on-quilt
+Severity: normal
+Certainty: certain
+Info: This package build-depends on quilt, which is not required since
+ dpkg-source will apply patches at unpack time for 3.0 (quilt) source
+ packages.
+
diff --git a/debian/changelog b/debian/changelog
index beea800..65fd825 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
+ Added:
- build-depends-on-specific-java-doc-package
- depends-on-specific-java-doc-package
+ - unneeded-build-dep-on-quilt
* checks/*:
+ [NT] Use the new pre-sorted file index when iterating over files.
@@ -32,6 +33,9 @@ lintian (2.4.4) UNRELEASED; urgency=low
* checks/nmu:
+ [RG] Completely abort if debian/changelog is a symlink.
(Closes: #582408)
+ * checks/patch-systems{,.desc}
++ [NT] Added check for new unneeded-build-dep-on-quilt.
+ (Closes: #582767)
* checks/standards-version:
+ [RG] Correctly handle cases where debian/changelog is a symlink.
diff --git a/t/tests/debhelper-dh-clean-k-ok/debian/debian/control.in
b/t/tests/patch-systems-quilt-source/debian/debian/control.in
similarity index 91%
copy from t/tests/debhelper-dh-clean-k-ok/debian/debian/control.in
copy to t/tests/patch-systems-quilt-source/debian/debian/control.in
index 4a5a774..07c8950 100644
--- a/t/tests/debhelper-dh-clean-k-ok/debian/debian/control.in
+++ b/t/tests/patch-systems-quilt-source/debian/debian/control.in
@@ -3,7 +3,7 @@ Priority: extra
Section: {$section}
Maintainer: {$author}
Standards-Version: {$standards_version}
-Build-Depends: debhelper (>= 6)
+Build-Depends: debhelper (>= 7.0.50~), quilt
Package: {$srcpkg}
Architecture: {$architecture}
diff --git a/t/tests/basic-quilt/debian/debian/source/format
b/t/tests/patch-systems-quilt-source/debian/debian/source/format
similarity index 100%
copy from t/tests/basic-quilt/debian/debian/source/format
copy to t/tests/patch-systems-quilt-source/debian/debian/source/format
diff --git a/t/tests/patch-systems-quilt-source/desc
b/t/tests/patch-systems-quilt-source/desc
new file mode 100644
index 000..d9f6dd1
--- /dev/null
+++ b/t/tests/patch-systems-quilt-source/desc
@@ -0,0 +1,7 @@
+Testname: patch-systems-quilt-source
+Sequence: 6000
+Type: non-native
+Version: 1.0-1
+Description: Test for quilt patches which do not have accompanying descriptions
+Test-For: unneeded-build-dep-on-quilt
+References: Debian Bug #582767
diff --git a/t/tests/patch-systems-quilt-source/tags
b/t/tests/patch-systems-quilt-source/tags
new file mode 100644
index 000..856b0e2
--- /dev/null
+++ b/t/tests/patch-systems-quilt-source/tags
@@ -0,0 +1 @@
+W: patch-systems-quilt-source source: unneeded-build-dep-on-quilt
diff --git a/t/tests/basic-3.0-native/debian/README
b/t/tests/patch-systems-quilt-source/upstream/README
similarity index 100%
copy from t/tests/basic-3.0-native/debian/README
copy to t/tests/patch-systems-quilt-source/upstream/README
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvtjf-br...@alioth.debian.org
Processed: limit source to lintian, tagging 582767
Processing commands for cont...@bugs.debian.org:
> #lintian (2.4.4) UNRELEASED; urgency=low
> #
> # * checks/patch-systems{,.desc}
> #+ [NT] Added check for new unneeded-build-dep-on-quilt.
> # (Closes: #582767)
> #
> limit source lintian
Limiting to bugs with field 'source' containing at least one of 'lintian'
Limit currently set to 'source':'lintian'
> tags 582767 + pending
Bug #582767 [lintian] lintian: if Package format 3.0 is in use report warning
for quilt in Depebds:
Added tag(s) pending.
> thanks
Stopping processing here.
Please contact me if you need assistance.
--
582767: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=582767
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/handler.s.c.12930421008188.transcr...@bugs.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-32-ga94e7b9
The following commit has been merged in the master branch:
commit a94e7b93c5a7409523b854c8d907ad1809f781ac
Author: Nelson A. de Oliveira
Date: Wed Nov 10 10:45:34 2010 -0200
Add a check for synopsis starting with articles
* Summary of tag changes:
+ Added:
- description-synopsis-starts-with-article
* checks/description{,.desc}:
+ [NT] Add a check for synopsis starting with articles. Thanks to
Nelson A. de Oliveira for the patch. (Closes: #603053)
Signed-off-by: Niels Thykier
diff --git a/checks/description b/checks/description
index 0d75b9d..08cfbd4 100644
--- a/checks/description
+++ b/checks/description
@@ -61,6 +61,9 @@ if ($synopsis =~ m/^\s*$/) {
if ($synopsis =~ m/^\Q$pkg\E\b/i) {
tag "description-starts-with-package-name", "";
}
+if ($synopsis =~ m/^(an?|the)\s/i) {
+ tag "description-synopsis-starts-with-article", "";
+}
if ($synopsis =~ m/(?name and synopsis
+ into this formula:
+ .
+ The package name provides {a,an,the,some} synopsis.
+Ref: devref 6.2.2
+
Tag: description-contains-tabs
Severity: important
Certainty: certain
diff --git a/debian/changelog b/debian/changelog
index 65fd825..1ad605c 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -5,6 +5,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
- build-depends-on-specific-java-doc-package
- depends-on-specific-java-doc-package
- unneeded-build-dep-on-quilt
+ - description-synopsis-starts-with-article
* checks/*:
+ [NT] Use the new pre-sorted file index when iterating over files.
@@ -18,6 +19,9 @@ lintian (2.4.4) UNRELEASED; urgency=low
* checks/debian-source-dir:
+ [NT] Added missing import of "Util" perl module. Thanks to David
Bremner for the patch.
+ * checks/description{,.desc}:
++ [NT] Add a check for synopsis starting with articles. Thanks to
+ Nelson A. de Oliveira for the patch. (Closes: #603053)
* checks/fields{,.desc}:
+ [NT] Added check for packages (build) depending on openjdk-X-doc or
classpath-doc instead of the default-jdk-doc metapackage.
diff --git a/t/tests/description-general/debian/debian/control.in
b/t/tests/description-general/debian/debian/control.in
index cbed638..fff24ba 100644
--- a/t/tests/description-general/debian/debian/control.in
+++ b/t/tests/description-general/debian/debian/control.in
@@ -100,3 +100,15 @@ Description: test package with duplicated words that aren't
Lintian. It is part of the Lintian test suite and may do very odd
things. It should not be installed like a regular package. It may
be an empty package.
+
+Package: {$srcpkg}-syn-article
+Architecture: {$architecture}
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Description: the synopsis starts with an article
+ A good synopsis should start not start with "a", "an" and "the"
+ according to devref 6.2.2.
+ .
+ This is a test package designed to exercise some feature or tag of
+ Lintian. It is part of the Lintian test suite and may do very odd
+ things. It should not be installed like a regular package. It may
+ be an empty package.
diff --git a/t/tests/description-general/desc b/t/tests/description-general/desc
index 153d0d0..ebb8708 100644
--- a/t/tests/description-general/desc
+++ b/t/tests/description-general/desc
@@ -15,6 +15,7 @@ Test-For:
description-synopsis-is-duplicated
description-synopsis-is-empty
description-synopsis-might-not-be-phrased-properly
+ description-synopsis-starts-with-article
description-too-long
extended-description-is-empty
extended-description-line-too-long
diff --git a/t/tests/description-general/tags b/t/tests/description-general/tags
index 5775813..57c67af 100644
--- a/t/tests/description-general/tags
+++ b/t/tests/description-general/tags
@@ -15,6 +15,7 @@ W: description-general-2:
possible-unindented-list-in-extended-description
W: description-general-3: extended-description-line-too-long
W: description-general-4: description-contains-homepage
W: description-general-4: spelling-error-in-description mroe more
+W: description-general-syn-article: description-synopsis-starts-with-article
W: description-general: description-contains-dh-make-perl-template
W: description-general: description-contains-duplicated-word All all all
W: description-general: description-contains-duplicated-word The the
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvv9r-000797...@alioth.debian.org
Processed: limit source to lintian, tagging 603053
Processing commands for cont...@bugs.debian.org:
> #lintian (2.4.4) UNRELEASED; urgency=low
> #
> # * checks/description{,.desc}:
> #+ [NT] Add a check for synopsis starting with articles. Thanks to
> # Nelson A. de Oliveira for the patch. (Closes: #603053)
> #
> limit source lintian
Limiting to bugs with field 'source' containing at least one of 'lintian'
Limit currently set to 'source':'lintian'
> tags 603053 + pending
Bug #603053 [lintian] Add a check for synopsis starting with articles
Added tag(s) pending.
> thanks
Stopping processing here.
Please contact me if you need assistance.
--
603053: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603053
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/handler.s.c.12930491887976.transcr...@bugs.debian.org
