[SCM] Debian package checker branch, master, updated. 2.4.3-79-g7383027
The following commit has been merged in the master branch:
commit 7383027f4280f12a0e651048cd04ed425d8d4636
Author: Niels Thykier
Date: Wed Dec 29 19:38:23 2010 +0100
Fixed a bug in the list of known java packages and extended the
description of the needless-depends-on-jre tag.
diff --git a/checks/fields b/checks/fields
index 0730725..e927ea1 100644
--- a/checks/fields
+++ b/checks/fields
@@ -128,7 +128,7 @@ our @known_java_pkg = map { qr/$_/ }
'java\d*-runtime(?:-headless)?', # java-runtime and javaX-runtime
alternatives (virtual)
'(openjdk-|sun-java)\d+-jre(?:-headless)?', '(openjdk-|sun-java)\d+-jdk',
# openjdk-X and sun-javaX
'gcj-(?:\d+\.\d+-)?jre(?:-headless)?', 'gcj-(?:\d+\.\d+-)?jdk', # gcj
- 'gij', 'java-compat(?:-dev|-headless)?', # deprecated/transitional
packages
+ 'gij', 'java-gcj-compat(?:-dev|-headless)?', # deprecated/transitional
packages
'kaffe', 'cacao', 'jamvm', 'classpath', # deprecated packages (removed in
Squeeze)
);
diff --git a/checks/fields.desc b/checks/fields.desc
index ce6b9b3..77da607 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -1014,7 +1014,11 @@ Info: The package appear to be a Java library and
depending on one
or more JRE/JDK packages. As of 05 Apr 2010, the Java Policy no
longer mandates that Java libraries depend on Java Runtimes.
.
- If there is a valid reason for this dependency, please override
+ If the library package ships executables along with the library,
+ then please consider making this an application package or mvoe the
+ binaries to a (new) application package.
+ .
+ If there is otherwise a valid reason for this dependency, please override
the tag.
Ref: http://packages.qa.debian.org/j/java-common/news/20100405T221415Z.html,
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=227587
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1py0xh-0004yn...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-78-gbdf93c8
The following commit has been merged in the master branch: commit bdf93c8db99fadad852964a456bd817aba9feac9 Author: Niels Thykier Date: Wed Dec 29 19:11:06 2010 +0100 Updated changelog to reflect changes made by commit ad4876b. * data/spelling/corrections: + [NT] Added more corrections. diff --git a/debian/changelog b/debian/changelog index c73136d..38a0922 100755 --- a/debian/changelog +++ b/debian/changelog @@ -65,6 +65,8 @@ lintian (2.4.4) UNRELEASED; urgency=low * data/fields/obsolete-packages: + [NT] Added default-jdk-builddep. See README.gcj-native-transition in java-common for the replacement. + * data/spelling/corrections: ++ [NT] Added more corrections. * debian/control: + [RA] Add the build dependencies required to run the test suite -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1py0xb-000231...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-78-gbdf93c8
The following commit has been merged in the master branch:
commit 0c69de90bb8f37774e9c35a418b76080804d0157
Author: Niels Thykier
Date: Wed Dec 29 19:08:10 2010 +0100
Add check for needless dependency on JRE/JDK for java libraries.
* Summary of tag changes:
+ Added:
- needless-dependency-on-jre
* checks/fields{,.desc}:
+ [NT] Added needless-dependency-on-jre tag.
diff --git a/checks/fields b/checks/fields
index 09d8a6f..0730725 100644
--- a/checks/fields
+++ b/checks/fields
@@ -123,6 +123,15 @@ our %known_tkxs = map { $_ => 1 }
our %known_libpngs = map { $_ => 1 }
( 'libpng12-0', 'libpng2', 'libpng3', );
+our @known_java_pkg = map { qr/$_/ }
+('default-jre(?:-headless)?', 'default-jdk', # default java
+ 'java\d*-runtime(?:-headless)?', # java-runtime and javaX-runtime
alternatives (virtual)
+ '(openjdk-|sun-java)\d+-jre(?:-headless)?', '(openjdk-|sun-java)\d+-jdk',
# openjdk-X and sun-javaX
+ 'gcj-(?:\d+\.\d+-)?jre(?:-headless)?', 'gcj-(?:\d+\.\d+-)?jdk', # gcj
+ 'gij', 'java-compat(?:-dev|-headless)?', # deprecated/transitional
packages
+ 'kaffe', 'cacao', 'jamvm', 'classpath', # deprecated packages (removed in
Squeeze)
+);
+
# Mapping of package names to section names
my @NAME_SECTION_MAPPINGS = (
[ qr/-docs?$/ => 'doc' ],
@@ -518,10 +527,13 @@ if ($type eq 'binary') {
}
if (($type eq "binary") || ($type eq 'udeb')) {
my (%deps, %fields, %parsed);
+ my $javalib = 0;
+ $javalib = 1 if($pkg =~ m/^lib.*-(?:java|gcj)$/o);
for my $field (qw(depends pre-depends recommends suggests conflicts
provides enhances replaces breaks)) {
next unless defined $info->field($field);
#Get data and clean it
my $data = $info->field($field);;
+ my $javadep = 0;
unfold($field, \$data);
$fields{$field} = $data;
@@ -645,6 +657,17 @@ if (($type eq "binary") || ($type eq 'udeb')) {
tag "depends-on-specific-java-doc-package",
"$field"
if(&$is_dep_field($field) && $pkg ne
'default-jdk-doc'
&& ($d_pkg eq 'classpath-doc' || $d_pkg
=~ m/openjdk-\d+-doc/o));
+
+
+ if($javalib && $field eq 'depends'){
+ foreach my $reg (@known_java_pkg){
+ if($d_pkg =~ m/$reg/){
+ $javadep++;
+ last;
+ }
+
+ }
+ }
}
for my $pkg (@seen_obsolete_packages) {
@@ -655,6 +678,11 @@ if (($type eq "binary") || ($type eq 'udeb')) {
tag "ored-depends-on-obsolete-package",
"$field: $pkg";
}
}
+
+ # Only emit the tag if all the alternatives are
JVM/JRE/JDKs
+ # - assume that | openjdk-6-jre-headless
makes sense for now.
+ tag "needless-dependency-on-jre"
+ if (scalar(@alternatives) == $javadep);
}
tag "package-depends-on-multiple-libstdc-versions",
@seen_libstdcs
if (scalar @seen_libstdcs > 1);
diff --git a/checks/fields.desc b/checks/fields.desc
index 672b9d2..ce6b9b3 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -1007,3 +1007,15 @@ Info: The package should use default-jdk-doc instead of
classpath-doc
or openjdk-X-doc to ease transitions when the providing doc package
is replaced (e.g. openjdk-6-doc being replaced by openjdk-7-doc).
+Tag: needless-dependency-on-jre
+Severity: normal
+Certainty: possible
+Info: The package appear to be a Java library and depending on one
+ or more JRE/JDK packages. As of 05 Apr 2010, the Java Policy no
+ longer mandates that Java libraries depend on Java Runtimes.
+ .
+ If there is a valid reason for this dependency, please override
+ the tag.
+Ref: http://packages.qa.debian.org/j/java-common/news/20100405T221415Z.html,
+ http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=227587
+
diff --git a/debian/changelog b/debian/changelog
index 3bfd7b6..c73136d 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,6 +6,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
- depends-on-specific-java-doc-package
- unneeded-build-dep-on-quilt
- description-synopsis-starts-with-article
+ - needless-dependency-on-jre
* checks/*:
+ [NT] Use the new pre-sorted file {index,info} when iterating over files.
@@ -30,6 +31,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
classpath-doc instead of the default-jdk-doc metapackage.
(Closes: #593837)
+ [NT] Fixed spe
[SCM] Debian package checker branch, master, updated. 2.4.3-76-g4b114ab
The following commit has been merged in the master branch: commit 4b114abbb5cce9d7f17ec2d448443e99816b63a0 Author: Niels Thykier Date: Wed Dec 29 17:45:42 2010 +0100 libX-gcj also belong in the java section. diff --git a/checks/fields b/checks/fields index e1f2043..09d8a6f 100644 --- a/checks/fields +++ b/checks/fields @@ -131,7 +131,7 @@ my @NAME_SECTION_MAPPINGS = ( [ qr/^r-cran-/ => 'gnu-r'], [ qr/^lib.*-perl$/ => 'perl' ], [ qr/^lib.*-cil$/ => 'cli-mono' ], -[ qr/^lib.*-java$/ => 'java' ], +[ qr/^lib.*-(?:java|gcj)$/ => 'java' ], [ qr/^(?:lib)php-/ => 'php' ], [ qr/^lib(?:hugs|ghc6)-/ => 'haskell' ], [ qr/^lib.*-ruby(?:1\.\d)?$/ => 'ruby' ], -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pxzbw-0002u8...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-75-gad4876b
The following commit has been merged in the master branch: commit ad4876b3c9c511ffad9bf3354955c38f6828e9d7 Author: Niels Thykier Date: Wed Dec 29 17:27:22 2010 +0100 Added (more) misspellings of developer and development. See #608276 diff --git a/data/spelling/corrections b/data/spelling/corrections index 4b3cb4b..989511d 100644 --- a/data/spelling/corrections +++ b/data/spelling/corrections @@ -188,6 +188,8 @@ desactivate||deactivate detabase||database developement||development developped||developed +developpement||development +developper||developer deveolpment||development devided||divided dictionnary||dictionary -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pxyuj-0006qe...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-74-ga48fb5a
The following commit has been merged in the master branch:
commit a48fb5a20501a2e468401bfd2ea9e1aec085eb06
Author: Niels Thykier
Date: Wed Dec 29 10:28:26 2010 +0100
Added some /usr/share/doc/ -> symlink tests.
diff --git a/t/COVERAGE b/t/COVERAGE
index 2291423..0e8b07b 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -1,4 +1,4 @@
-Last generated 2010-12-28
+Last generated 2010-12-29
The following tags are not tested by the test suite:
@@ -26,8 +26,6 @@ control-files unknown-control-file
copyright-file copyright-does-not-refer-to-common-license-file
copyright-file copyright-should-refer-to-common-license-file-for-lgpl
-copyright-file usr-share-doc-symlink-points-outside-of-usr-share-doc
-copyright-file usr-share-doc-symlink-to-foreign-package
cruft documentation-package-not-architecture-independent
cruft source-contains-prebuilt-windows-binary
diff --git a/t/tests/files-flash-non-free/debian/debian/control.in
b/t/tests/copyright-file-symlink/debian/debian/control.in
similarity index 68%
copy from t/tests/files-flash-non-free/debian/debian/control.in
copy to t/tests/copyright-file-symlink/debian/debian/control.in
index b531357..3997898 100644
--- a/t/tests/files-flash-non-free/debian/debian/control.in
+++ b/t/tests/copyright-file-symlink/debian/debian/control.in
@@ -3,26 +3,26 @@ Priority: extra
Section: {$section}
Maintainer: {$author}
Standards-Version: {$standards_version}
-Build-Depends: debhelper (>= 7)
-Homepage: http://lintian.debian.org/
+Build-Depends: debhelper (>= 7.0.50~)
-Package: {$srcpkg}
+Package: symlink-to-foreign
Architecture: {$architecture}
-Depends: $\{misc:Depends\}
-Description: {$description}
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}, foreign-package
+Description: {$description} (foreign)
This is a test package designed to exercise some feature or tag of
Lintian. It is part of the Lintian test suite and may do very odd
things. It should not be installed like a regular package. It may
be an empty package.
+ .
+ Foreign
-Package: {$srcpkg}-non-free
-Section: non-free/{$section}
+Package: symlink-outside-usd
Architecture: {$architecture}
-Depends: $\{misc:Depends\}
-Description: {$description} (okay)
- non-free in non-free, nice.
- .
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Description: {$description} (usd)
This is a test package designed to exercise some feature or tag of
Lintian. It is part of the Lintian test suite and may do very odd
things. It should not be installed like a regular package. It may
be an empty package.
+ .
+ USD
diff --git a/t/tests/copyright-file-symlink/debian/debian/rules
b/t/tests/copyright-file-symlink/debian/debian/rules
new file mode 100644
index 000..37b7cf6
--- /dev/null
+++ b/t/tests/copyright-file-symlink/debian/debian/rules
@@ -0,0 +1,19 @@
+#!/usr/bin/make -f
+
+USD:=usr/share/doc
+%:
+ dh $@
+
+
+override_dh_md5sums:
+ rm -fr debian/symlink-to-foreign/$(USD)/symlink-to-foreign
+ ln -sf foreign-package \
+ debian/symlink-to-foreign/$(USD)/symlink-to-foreign
+ # Move all of it to usr/lib//
+ mkdir -p debian/symlink-outside-usd/usr/lib/
+ mv debian/symlink-outside-usd/$(USD)/symlink-outside-usd \
+ debian/symlink-outside-usd/usr/lib/symlink-outside-usd/
+ # with symlink of course :)
+ ln -s ../../lib/symlink-outside-usd/copyright \
+ debian/symlink-outside-usd/$(USD)/symlink-outside-usd
+ dh_md5sums
diff --git a/t/tests/copyright-file-symlink/desc
b/t/tests/copyright-file-symlink/desc
new file mode 100644
index 000..3fc7062
--- /dev/null
+++ b/t/tests/copyright-file-symlink/desc
@@ -0,0 +1,7 @@
+Testname: copyright-file-symlink
+Sequence: 6000
+Version: 1.0
+Description: Test for symlinked copyright files
+Test-For:
+ usr-share-doc-symlink-points-outside-of-usr-share-doc
+ usr-share-doc-symlink-to-foreign-package
diff --git a/t/tests/copyright-file-symlink/tags
b/t/tests/copyright-file-symlink/tags
new file mode 100644
index 000..5c6372a
--- /dev/null
+++ b/t/tests/copyright-file-symlink/tags
@@ -0,0 +1,2 @@
+E: symlink-outside-usd: usr-share-doc-symlink-points-outside-of-usr-share-doc
../../lib/symlink-outside-usd/copyright
+E: symlink-to-foreign: usr-share-doc-symlink-to-foreign-package foreign-package
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pxsmk-0004mt...@alioth.debian.org
