[lintian] 02/05: Don't report timestamped-gzip if the file is pregenerated (#762105)
This is an automated email from the git hooks/post-receive script.
nthykier pushed a commit to branch master
in repository lintian.
commit 184e9526017b325919aaaf132fb0a67adfcadc83
Author: Tomasz Buchert tom...@debian.org
Date: Thu May 14 11:32:58 2015 +0200
Don't report timestamped-gzip if the file is pregenerated (#762105)
This is a heuristic proposed in https://bugs.debian.org/762105.
If the gzipped file has a modification time *after* changelog,
then very likely it is unreproducible. On the other hand,
if it is *before*, then it is probably pregenerated in upstream
sources.
Signed-off-by: Niels Thykier ni...@thykier.net
---
checks/files.pm | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/checks/files.pm b/checks/files.pm
index 7ad6e1f..8b937e8 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -277,6 +277,18 @@ sub run {
my $isma_same = $info-field('multi-arch', '') eq 'same';
my $ppkg = quotemeta($pkg);
+# get the last changelog timestamp
+# if for some weird reasons the timestamp does
+# not exist, it will remain 0
+my $changes = $info-changelog;
+my $changelog_timestamp = 0;
+if (defined $changes) {
+my ($entry) = $changes-data;
+if ($entry $entry-Timestamp) {
+$changelog_timestamp = $entry-Timestamp;
+}
+}
+
# find out which files are scripts
my %script = map {$_ = 1} (sort keys %{$info-scripts});
@@ -1433,7 +1445,11 @@ sub run {
if ($isma_same $file !~ m/\Q$arch\E/o) {
tag 'gzip-file-is-not-multi-arch-same-safe', $file;
} else {
-tag 'package-contains-timestamped-gzip', $file;
+# see https://bugs.debian.org/762105
+my $diff = $file-timestamp - $changelog_timestamp;
+if ($diff = 0) {
+tag 'package-contains-timestamped-gzip', $file;
+}
}
}
}
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/e1ythmt-0007wq...@moszumanska.debian.org
[lintian] 03/05: Update files-gzip tests
This is an automated email from the git hooks/post-receive script.
nthykier pushed a commit to branch master
in repository lintian.
commit 548a0cd8e8372e9c9ac3d541babcaf9f2c0cb372
Author: Tomasz Buchert tom...@debian.org
Date: Thu May 14 11:57:44 2015 +0200
Update files-gzip tests
Signed-off-by: Niels Thykier ni...@thykier.net
---
t/tests/files-gzip/debian/debian/rules | 7 +++
t/tests/files-gzip/tags | 2 +-
t/tests/files-gzip/upstream/{good.gz = timestamped-now.gz} | Bin
.../files-gzip/upstream/{good.gz = timestamped-past.gz}| Bin
4 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/t/tests/files-gzip/debian/debian/rules
b/t/tests/files-gzip/debian/debian/rules
index efe8cf2..1d8af89 100755
--- a/t/tests/files-gzip/debian/debian/rules
+++ b/t/tests/files-gzip/debian/debian/rules
@@ -3,6 +3,13 @@ pkg=files-gzip
%:
dh $@
+override_dh_install:
+ dh_install
+ # we set the mtime to the past
+ touch -m -d 2003-06-21 12:12:12 UTC
debian/$(pkg)/etc/timestamped-past.gz
+ # we set the mtime to right now
+ touch -m debian/$(pkg)/etc/timestamped-now.gz
+
override_dh_installdocs:
dh_installdocs
echo Hello world :) debian/$(pkg)/usr/share/doc/$(pkg)/changelog.gz
diff --git a/t/tests/files-gzip/tags b/t/tests/files-gzip/tags
index e003044..74c8c3e 100644
--- a/t/tests/files-gzip/tags
+++ b/t/tests/files-gzip/tags
@@ -1,3 +1,3 @@
-I: files-gzip: package-contains-timestamped-gzip etc/good.gz
+I: files-gzip: package-contains-timestamped-gzip etc/timestamped-now.gz
W: files-gzip: gz-file-not-gzip etc/bad.gz
W: files-gzip: gz-file-not-gzip usr/share/doc/files-gzip/changelog.gz
diff --git a/t/tests/files-gzip/upstream/good.gz
b/t/tests/files-gzip/upstream/timestamped-now.gz
similarity index 100%
copy from t/tests/files-gzip/upstream/good.gz
copy to t/tests/files-gzip/upstream/timestamped-now.gz
diff --git a/t/tests/files-gzip/upstream/good.gz
b/t/tests/files-gzip/upstream/timestamped-past.gz
similarity index 100%
rename from t/tests/files-gzip/upstream/good.gz
rename to t/tests/files-gzip/upstream/timestamped-past.gz
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/e1ythmt-0007we...@moszumanska.debian.org
Re: RfC: Moving not-pkg-perl-team-specific lintian tests from pkg-perl-tools to lintian proper
On Fri, 15 May 2015 21:32:29 +0200, Axel Beckert wrote: I intent to move some lintian tests currently used by the Debian Perl Team an packaged in the pkg-perl lintian profile shipped with pkg-perl-tools into lintian. I think that's a good idea, thanks for your initiative. Some minor thoughts: My main movation is to get the check application-not-library with the following tags into lintian: * libapp-perl-package-name * library-package-name-for-application * application-in-library-section I'm seeing quite a few false positives with those checks; but as long as they stay at the experimental level I have no objections :) For the other checks, I think - the severity might be lowered on some of them (not everything is a horrible error even if we don't want it in the perl group) - the CDBS ones would probably benefit from a review by Jonas (I tried to pick the correct versions from cdbs' changelog but I might have been wrong somewhere) I'd be happy to get at least some comments from Gregor and Damyan if they agree to have the pkg-perl lintian check written by them to be moved into lintian. Sure :) Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of the Free Software Foundation Europe `- NP: Leonard Cohen: So Long, Marianne signature.asc Description: Digital Signature
Processed: limit source to lintian, tagging 762105
Processing commands for cont...@bugs.debian.org: limit source lintian Limiting to bugs with field 'source' containing at least one of 'lintian' Limit currently set to 'source':'lintian' tags 762105 + pending Bug #762105 [lintian] lintian: package-contains-timestamped-gzip incorrectly complains about files from the upstream tarball Added tag(s) pending. thanks Stopping processing here. Please contact me if you need assistance. -- 762105: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762105 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.c.143180464228562.transcr...@bugs.debian.org
Bug#762105: lintian: package-contains-timestamped-gzip incorrectly complains about files from the upstream tarball
On 2015-05-16 01:56, bastien ROUCARIÈS wrote: On Thursday 14 May 2015 13:49:33 Tomasz Buchert wrote: Niels, jakub care to merge ? Bastien [...] Hi, Thanks for writing the patches and the reviewing the change. I have merged the patches with a few minor changes (typo-fixes plus a bit of perltidy etc.) Thanks, ~Niels -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/55579b35.3010...@thykier.net
[lintian] branch master updated (e907388 - 00885bc)
This is an automated email from the git hooks/post-receive script.
nthykier pushed a change to branch master
in repository lintian.
from e907388 c/r-sync-state: Read mirror files as UTF-8 text
new fa73711 Use UTC time add 'timestamp' method to L::Path
new 184e952 Don't report timestamped-gzip if the file is pregenerated
(#762105)
new 548a0cd Update files-gzip tests
new 828e132 Bump ancient S-V date
new 00885bc Add changelog entries for Tomasz Buchert's commits
The 5 revisions listed above as new are entirely new to this
repository and will be described in separate emails. The revisions
listed as adds were already present in the repository and have only
been added to this reference.
Summary of changes:
checks/files.pm | 18 +-
collection/unpacked | 13 ++---
data/standards-version/ancient-date | 2 +-
debian/changelog | 12
lib/Lintian/Path.pm | 17 -
t/tests/files-gzip/debian/debian/rules| 7 +++
t/tests/files-gzip/tags | 2 +-
.../upstream/{good.gz = timestamped-now.gz} | Bin
.../upstream/{good.gz = timestamped-past.gz} | Bin
9 files changed, 64 insertions(+), 7 deletions(-)
copy t/tests/files-gzip/upstream/{good.gz = timestamped-now.gz} (100%)
rename t/tests/files-gzip/upstream/{good.gz = timestamped-past.gz} (100%)
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive:
https://lists.debian.org/20150516193018.28826.38...@moszumanska.debian.org
Re: RfC: Moving not-pkg-perl-team-specific lintian tests from pkg-perl-tools to lintian proper
Quoting Axel Beckert (2015-05-16 19:30:40) gregor herrmann wrote: - the CDBS ones would probably benefit from a review by Jonas (I tried to pick the correct versions from cdbs' changelog but I might have been wrong somewhere) Ok, will either not included before Jonas reviewed it or mark it as experimental. To properly enable security hardening for Perl modules with CDBS, you will need cdbs 0.4.130 or newer. ...which means you should use Debian stable or newer. Period. I disagree that each package need versioned build-dependency: That brings no real benefit, only a) papers over broken build environments and b) makes it harder to backport packages. - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature
[lintian] branch master updated (00885bc - 87c23f4)
This is an automated email from the git hooks/post-receive script. nthykier pushed a change to branch master in repository lintian. from 00885bc Add changelog entries for Tomasz Buchert's commits new 87c23f4 pod-spelling: Add two stopwords for Wheezy The 1 revisions listed above as new are entirely new to this repository and will be described in separate emails. The revisions listed as adds were already present in the repository and have only been added to this reference. Summary of changes: t/scripts/pod-spelling.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20150516204100.6106.79...@moszumanska.debian.org
Re: RfC: Moving not-pkg-perl-team-specific lintian tests from pkg-perl-tools to lintian proper
Hi Gregor, thanks for your insight! gregor herrmann wrote: On Fri, 15 May 2015 21:32:29 +0200, Axel Beckert wrote: My main movation is to get the check application-not-library with the following tags into lintian: * libapp-perl-package-name * library-package-name-for-application * application-in-library-section I'm seeing quite a few false positives with those checks; I assume that you don't include libapp-perl-package-name in that statement. I consider that tag to be quite precise: Certainty: certain With regards to library-package-name-for-application and application-in-library-section, I've set Certainty: possible and currently expect people to add overrides if the check is wrong: In case the program in $PATH is only a helper tool and the package is primarily a library, please add a lintian override for this tag. But yes, those tests will generate false positives and I currently have no idea how to reduce the amount of false positives noticably. but as long as they stay at the experimental level I have no objections :) Of course the idea is that we can remove the experimental flag at some time, hence I'm happy about ideas how to reduce the amount of false positives. For the other checks, I think - the severity might be lowered on some of them (not everything is a horrible error even if we don't want it in the perl group) Thanks for that hint. I think it especially applies to the check if the Perl Module name is present in the package description. - the CDBS ones would probably benefit from a review by Jonas (I tried to pick the correct versions from cdbs' changelog but I might have been wrong somewhere) Ok, will either not included before Jonas reviewed it or mark it as experimental. Regards, Axel -- ,''`. | Axel Beckert a...@debian.org, http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20150516173039.gy24...@sym.noone.org
[lintian] 04/05: Bump ancient S-V date
This is an automated email from the git hooks/post-receive script. nthykier pushed a commit to branch master in repository lintian. commit 828e1320fc09ac5ec88ddbfc84c6e9c77e4e9f36 Author: Niels Thykier ni...@thykier.net Date: Sat May 16 21:13:30 2015 +0200 Bump ancient S-V date Signed-off-by: Niels Thykier ni...@thykier.net --- data/standards-version/ancient-date | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/standards-version/ancient-date b/data/standards-version/ancient-date index a3760f5..fd434ef 100644 --- a/data/standards-version/ancient-date +++ b/data/standards-version/ancient-date @@ -2,4 +2,4 @@ # That date has to be within 22 and 24 months in the past # at release time # Format is ANCIENT Date -ANCIENT 14 April 2013 +ANCIENT 16 June 2013 -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/e1ythmt-0007ws...@moszumanska.debian.org
[lintian] 01/05: Use UTC time add 'timestamp' method to L::Path
This is an automated email from the git hooks/post-receive script.
nthykier pushed a commit to branch master
in repository lintian.
commit fa7371152629910bec5579e88c152263552b7b6d
Author: Tomasz Buchert tom...@debian.org
Date: Thu May 14 11:32:18 2015 +0200
Use UTC time add 'timestamp' method to L::Path
Signed-off-by: Niels Thykier ni...@thykier.net
---
collection/unpacked | 13 ++---
lib/Lintian/Path.pm | 17 -
2 files changed, 26 insertions(+), 4 deletions(-)
diff --git a/collection/unpacked b/collection/unpacked
index fdb9736..928aa04 100755
--- a/collection/unpacked
+++ b/collection/unpacked
@@ -174,7 +174,10 @@ sub extract_and_index_deb {
push(
@jobs,
{
-'_pipeline' = [['tar', '-tvf', '-'], '|', @sort_gzip, ''],
+'_pipeline' = [
+['tar', '--utc', '--full-time', '-tvf', '-'], '|',
+@sort_gzip, ''
+],
'fail' = 'error',
'pipe_in' = FileHandle-new,
'out' = $dir/index.gz,
@@ -184,8 +187,12 @@ sub extract_and_index_deb {
push(
@jobs,
{
-'_pipeline' =
- [['tar', '--numeric-owner', '-tvf', '-'], '|',@sort_gzip, ''],
+'_pipeline' =[
+['tar', '--utc', '--full-time', '--numeric-owner', '-tvf','-'],
+'|',
+@sort_gzip,
+''
+],
'fail' = 'error',
'pipe_in' = FileHandle-new,
'out' = $dir/index-owner-id.gz,
diff --git a/lib/Lintian/Path.pm b/lib/Lintian/Path.pm
index 48de275..a6ed5fd 100644
--- a/lib/Lintian/Path.pm
+++ b/lib/Lintian/Path.pm
@@ -33,6 +33,7 @@ use overload (
'fallback' = 0,
);
+use Date::Parse qw(str2time);
use Carp qw(croak confess);
use Scalar::Util qw(weaken);
@@ -195,7 +196,7 @@ NB: Returns the empty string for the root dir.
Lintian::Path-mk_ro_accessors(
qw(name owner group link type uid gid
- size date operm parent_dir dirname basename
+ size date time operm parent_dir dirname basename
));
=item children
@@ -212,6 +213,20 @@ sub children {
return @{$self-{'_sorted_children'} };
}
+=item timestamp
+
+Returns a Unix timestamp for the given path. This is a number of
+seconds since the start of Unix epoch in UTC.
+
+=cut
+
+sub timestamp {
+my ($self) = @_;
+my $date = $self-{'date'};
+my $time = $self-{'time'};
+return str2time($date $time, 'GMT');
+}
+
=item child(BASENAME)
Returns the child named BASENAME if it is a child of this directory.
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/e1ythmt-0007wf...@moszumanska.debian.org
Jenkins build is back to normal : lintian-tests_wheezy #153
See https://jenkins.debian.net/job/lintian-tests_wheezy/153/changes -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/77900309.8.1431810779783.JavaMail.jenkins@jenkins
