date:20150816

[lintian] 01/01: lintian.desc: Rename renamed-override to renamed-tag

2015-08-16 Thread Niels Thykier

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 8ee14afe4647da3e8c3554a491d2c81633fc1153
Author: Niels Thykier 
Date:   Sun Aug 16 09:28:00 2015 +0200

lintian.desc: Rename renamed-override to renamed-tag

Signed-off-by: Niels Thykier 
---
 checks/lintian.desc  | 6 +++---
 t/tests/overrides-shown/tags | 2 +-
 t/tests/overrides/tags   | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/checks/lintian.desc b/checks/lintian.desc
index 15c93d7..ba83de5 100644
--- a/checks/lintian.desc
+++ b/checks/lintian.desc
@@ -18,11 +18,11 @@ Info: Lintian discovered an unused override entry in its 
database.
  If the override is unused, please remove it from the overrides file.
 
 
-Tag: renamed-override
+Tag: renamed-tag
 Severity: pedantic
 Certainty: certain
-Info: Lintian discovered an renamed override entry in its database.
- Lintian tag are sometime renamed in order to improve description.
+Info: The package has an override for a tag that was renamed.
+ Lintian tag are sometime renamed in order to improve their name.
  .
  Override file is dynamically translated by lintian. Nevertheless
  please replace the old name by the new name.
diff --git a/t/tests/overrides-shown/tags b/t/tests/overrides-shown/tags
index 1ae7b6d..7c7796e 100644
--- a/t/tests/overrides-shown/tags
+++ b/t/tests/overrides-shown/tags
@@ -1,4 +1,4 @@
-P: overrides-shown: renamed-override package-install-apt-sources => 
package-installs-apt-sources at line 18
+P: overrides-shown: renamed-tag package-install-apt-sources => 
package-installs-apt-sources at line 18
 N: renamed tag
 O: overrides-shown: package-installs-apt-sources etc/apt/sources.list.d/
 N: renamed tag
diff --git a/t/tests/overrides/tags b/t/tests/overrides/tags
index 0557d93..0e487e4 100644
--- a/t/tests/overrides/tags
+++ b/t/tests/overrides/tags
@@ -2,4 +2,4 @@ I: overrides: FSSTND-dir-in-manual-page 
usr/share/man/man1/foo.1.gz:12 /usr/info
 I: overrides: FSSTND-dir-in-manual-page usr/share/man/man1/foo.1.gz:13 
/usr/man/
 I: overrides: FSSTND-dir-in-manual-page usr/share/man/man1/foo.1.gz:14 
/usr/adm/
 N: 12 tags overridden (2 errors, 1 warning, 9 info)
-P: overrides: renamed-override package-install-apt-sources => 
package-installs-apt-sources at line 18
+P: overrides: renamed-tag package-install-apt-sources => 
package-installs-apt-sources at line 18

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: c/fields.pm: Use "an" (instead of "a") before "HTTP"

2015-08-16 Thread Niels Thykier

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 21c963f71e79425b094cf9308cd0c4a0df096b1a
Author: Jakub Wilk 
Date:   Sun Aug 16 00:57:02 2015 +0200

c/fields.pm: Use "an" (instead of "a") before "HTTP"

Signed-off-by: Niels Thykier 
---
 checks/fields.desc | 4 ++--
 debian/changelog   | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/checks/fields.desc b/checks/fields.desc
index 35fbc1d..e9b2667 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -1085,7 +1085,7 @@ Info: The VCS-* field contains an uncanonical URI. Please 
update to use
  admins (see reference).
  .
  Note that this check is based on a list of known URIs.  Lintian did not
- send a HTTP request to the URI to test this.  Should the canonical URI
+ send an HTTP request to the URI to test this.  Should the canonical URI
  have changed, please file a bug against Lintian so the check can be
  updated accordingly.
 Ref: https://lists.debian.org/debian-devel-announce/2011/05/msg9.html
@@ -1097,7 +1097,7 @@ Info: The VCS-* field uses an address which no longer 
works.  Please
  update it to use the current canonical URI instead.
  .
  Note that this check is based on a list of known URIs or/and
- patterns.  Lintian did not send a HTTP request to the URI to test
+ patterns.  Lintian did not send an HTTP request to the URI to test
  this.  Should the URI actually work, please file a bug against
  Lintian so the check can be updated accordingly.
 
diff --git a/debian/changelog b/debian/changelog
index 98c5281..070370a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,9 @@ lintian (2.5.37) UNRELEASED; urgency=medium
 
"XXX: generate tag summary"
 
+  * checks/fields.desc:
++ [JW] Use "an" (instead of "a") before "HTTP".
+
   * lib/Lintian/{Tags.pm,Tag/Override.pm}:
 + [BR] Support tag renaming. Warn about renamed
   tags.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (2b1d3c1 -> 8ee14af)

2015-08-16 Thread Niels Thykier

This is an automated email from the git hooks/post-receive script.

nthykier pushed a change to branch master
in repository lintian.

  from  2b1d3c1   Fix changelog and open new version
   new  8ee14af   lintian.desc: Rename renamed-override to renamed-tag

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/lintian.desc  | 6 +++---
 t/tests/overrides-shown/tags | 2 +-
 t/tests/overrides/tags   | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (8ee14af -> 21c963f)

2015-08-16 Thread Niels Thykier

This is an automated email from the git hooks/post-receive script.

nthykier pushed a change to branch master
in repository lintian.

  from  8ee14af   lintian.desc: Rename renamed-override to renamed-tag
   new  21c963f   c/fields.pm: Use "an" (instead of "a") before "HTTP"

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/fields.desc | 4 ++--
 debian/changelog   | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#795667: Suppress hardening-{no-relro,no-fortify-functions}

2015-08-16 Thread Michael Stapelberg

Package: lintian
Version: 2.5.33
Severity: normal
Tags: patch

>From the patch description:

 [PATCH] Suppress hardening-{no-relro,no-fortify-functions} for Go binaries.

 The Go compiler (gc) does not currently support these features, so don’t
 warn about them on _every_ binary which is implemented in Go.

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (990, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.0.0-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils   2.25-10
ii  bzip2  1.0.6-8
ii  diffstat   1.58-1
ii  file   1:5.22+15-2
ii  gettext0.19.4-1
ii  hardening-includes 2.7
ii  intltool-debian0.35.0+20060710.2
ii  libapt-pkg-perl0.1.29+b2
ii  libarchive-zip-perl1.48-1
ii  libclass-accessor-perl 0.34-1
ii  libclone-perl  0.38-1
ii  libdpkg-perl   1.18.1
ii  libemail-valid-perl1.196-1
ii  libfile-basedir-perl   0.07-1
ii  libipc-run-perl0.94-1
ii  liblist-moreutils-perl 0.413-1
ii  libparse-debianchangelog-perl  1.2.0-4
ii  libtext-levenshtein-perl   0.12-1
ii  libtimedate-perl   2.3000-2
ii  liburi-perl1.64-1
ii  man-db 2.7.0.2-5
ii  patchutils 0.3.4-1
ii  perl [libdigest-sha-perl]  5.20.2-6
ii  t1utils1.38-4
ii  xz-utils   5.1.1alpha+20120614-2.1

Versions of packages lintian recommends:
ii  dpkg1.18.1
pn  libperlio-gzip-perl 
ii  perl5.20.2-6
ii  perl-modules [libautodie-perl]  5.20.2-6

Versions of packages lintian suggests:
pn  binutils-multiarch 
ii  dpkg-dev   1.18.1
ii  libhtml-parser-perl3.71-2
ii  libtext-template-perl  1.46-1
pn  libyaml-perl   

-- no debconf information
>From 87e1d19a9cb2dfdfd1b23108bdff89d264102a3c Mon Sep 17 00:00:00 2001
From: Michael Stapelberg 
Date: Sun, 16 Aug 2015 09:52:24 +0200
Subject: [PATCH] Suppress hardening-{no-relro,no-fortify-functions} for Go
 binaries.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The Go compiler (gc) does not currently support these features, so don’t
warn about them on _every_ binary which is implemented in Go.
---
 checks/binaries.pm | 5 +
 1 file changed, 5 insertions(+)

diff --git a/checks/binaries.pm b/checks/binaries.pm
index 1ad6282..3542611 100644
--- a/checks/binaries.pm
+++ b/checks/binaries.pm
@@ -547,6 +547,11 @@ sub run {
 if ($flags) {
 foreach my $t (@{$info->hardening_info->{$fname}}) {
 my $tag = "hardening-$t";
+# Binaries built by the Go compiler do not support all
+# hardening measures.
+next if ($t eq 'no-relro' ||
+ $t eq 'no-fortify-functions') &&
+ $built_with_golang;
 tag $tag, $file if $flags->{$tag};
 }
 }
-- 
2.1.4

Build failed in Jenkins: lintian-tests_sid #624

2015-08-16 Thread jenkins

See 

Changes:

[niels] lintian.desc: Rename renamed-override to renamed-tag

--
[...truncated 2732 lines...]
Get:14 http://ftp.de.debian.org/debian/ sid/main libdbus-1-3 amd64 1.8.20-1 
[170 kB]
Get:15 http://ftp.de.debian.org/debian/ sid/main libavahi-client3 amd64 
0.6.31-5 [54.4 kB]
Get:16 http://ftp.de.debian.org/debian/ sid/main libcups2 amd64 2.0.3-10 [296 
kB]
Get:17 http://ftp.de.debian.org/debian/ sid/main liblcms2-2 amd64 2.6-3+b3 [141 
kB]
Get:18 http://ftp.de.debian.org/debian/ sid/main libjpeg62-turbo amd64 
1:1.4.1-1 [125 kB]
Get:19 http://ftp.de.debian.org/debian/ sid/main libpng12-0 amd64 1.2.50-2+b2 
[172 kB]
Get:20 http://ftp.de.debian.org/debian/ sid/main libfreetype6 amd64 2.5.2-4 
[466 kB]
Get:21 http://ftp.de.debian.org/debian/ sid/main ucf all 3.0030 [69.7 kB]
Get:22 http://ftp.de.debian.org/debian/ sid/main fonts-dejavu-core all 2.35-1 
[1064 kB]
Get:23 http://ftp.de.debian.org/debian/ sid/main fontconfig-config all 
2.11.0-6.3 [273 kB]
Get:24 http://ftp.de.debian.org/debian/ sid/main libfontconfig1 amd64 
2.11.0-6.3 [329 kB]
Get:25 http://ftp.de.debian.org/debian/ sid/main libpcsclite1 amd64 1.8.14-1 
[56.2 kB]
Get:26 http://ftp.de.debian.org/debian/ sid/main libasyncns0 amd64 0.8-5 [12.5 
kB]
Get:27 http://ftp.de.debian.org/debian/ sid/main x11-common all 1:7.7+9 [287 kB]
Get:28 http://ftp.de.debian.org/debian/ sid/main libice6 amd64 2:1.0.9-1+b1 
[58.8 kB]
Get:29 http://ftp.de.debian.org/debian/ sid/main libsm6 amd64 2:1.2.2-1+b1 
[33.6 kB]
Get:30 http://ftp.de.debian.org/debian/ sid/main libogg0 amd64 1.3.2-1 [19.9 kB]
Get:31 http://ftp.de.debian.org/debian/ sid/main libflac8 amd64 1.3.1-4 [218 kB]
Get:32 http://ftp.de.debian.org/debian/ sid/main libvorbis0a amd64 1.3.4-2 
[92.9 kB]
Get:33 http://ftp.de.debian.org/debian/ sid/main libvorbisenc2 amd64 1.3.4-2 
[77.9 kB]
Get:34 http://ftp.de.debian.org/debian/ sid/main libsndfile1 amd64 1.0.25-9.1 
[214 kB]
Get:35 http://ftp.de.debian.org/debian/ sid/main libwrap0 amd64 7.6.q-25 [58.5 
kB]
Get:36 http://ftp.de.debian.org/debian/ sid/main libx11-xcb1 amd64 2:1.6.3-1 
[176 kB]
Get:37 http://ftp.de.debian.org/debian/ sid/main libxi6 amd64 2:1.7.4-1+b2 
[79.7 kB]
Get:38 http://ftp.de.debian.org/debian/ sid/main libxtst6 amd64 2:1.2.2-1+b1 
[27.3 kB]
Get:39 http://ftp.de.debian.org/debian/ sid/main libpulse0 amd64 6.0-5 [262 kB]
Get:40 http://ftp.de.debian.org/debian/ sid/main openjdk-7-jre-headless amd64 
7u79-2.5.6-1 [39.7 MB]
Get:41 http://ftp.de.debian.org/debian/ sid/main default-jre-headless amd64 
2:1.7-52 [9072 B]
Get:42 http://ftp.de.debian.org/debian/ sid/main libasound2-data all 1.0.29-1 
[67.1 kB]
Get:43 http://ftp.de.debian.org/debian/ sid/main libasound2 amd64 1.0.29-1 [377 
kB]
Get:44 http://ftp.de.debian.org/debian/ sid/main libatk1.0-data all 2.16.0-2 
[183 kB]
Get:45 http://ftp.de.debian.org/debian/ sid/main libatk1.0-0 amd64 2.16.0-2 
[92.6 kB]
Get:46 http://ftp.de.debian.org/debian/ sid/main libpixman-1-0 amd64 0.32.6-3 
[507 kB]
Get:47 http://ftp.de.debian.org/debian/ sid/main libxcb-render0 amd64 1.10-3+b1 
[17.5 kB]
Get:48 http://ftp.de.debian.org/debian/ sid/main libxcb-shm0 amd64 1.10-3+b1 
[11.5 kB]
Get:49 http://ftp.de.debian.org/debian/ sid/main libxrender1 amd64 1:0.9.8-1+b1 
[31.4 kB]
Get:50 http://ftp.de.debian.org/debian/ sid/main libcairo2 amd64 1.14.2-2 [753 
kB]
Get:51 http://ftp.de.debian.org/debian/ sid/main libjasper1 amd64 
1.900.1-debian1-2.4 [133 kB]
Get:52 http://ftp.de.debian.org/debian/ sid/main libjbig0 amd64 2.1-3.1 [30.7 
kB]
Get:53 http://ftp.de.debian.org/debian/ sid/main libtiff5 amd64 4.0.3-13 [212 
kB]
Get:54 http://ftp.de.debian.org/debian/ sid/main libgdk-pixbuf2.0-common all 
2.31.5-1 [310 kB]
Get:55 http://ftp.de.debian.org/debian/ sid/main libgdk-pixbuf2.0-0 amd64 
2.31.5-1 [170 kB]
Get:56 http://ftp.de.debian.org/debian/ sid/main libgif4 amd64 4.1.6-11 [39.8 
kB]
Get:57 http://ftp.de.debian.org/debian/ sid/main libgtk2.0-common all 2.24.28-1 
[3140 kB]
Get:58 http://ftp.de.debian.org/debian/ sid/main fontconfig amd64 2.11.0-6.3 
[402 kB]
Get:59 http://ftp.de.debian.org/debian/ sid/main libthai-data all 0.1.22-2 [161 
kB]
Get:60 http://ftp.de.debian.org/debian/ sid/main libdatrie1 amd64 0.2.9-2 [34.6 
kB]
Get:61 http://ftp.de.debian.org/debian/ sid/main libthai0 amd64 0.1.22-2 [47.3 
kB]
Get:62 http://ftp.de.debian.org/debian/ sid/main libpango-1.0-0 amd64 1.36.8-3 
[291 kB]
Get:63 http://ftp.de.debian.org/debian/ sid/main libgraphite2-3 amd64 1.2.4-3 
[57.4 kB]
Get:64 http://ftp.de.debian.org/debian/ sid/main libharfbuzz0b amd64 1.0.1-1 
[524 kB]
Get:65 http://ftp.de.debian.org/debian/ sid/main libpangoft2-1.0-0 amd64 
1.36.8-3 [213 kB]
Get:66 http://ftp.de.debian.org/debian/ sid/main libpangocairo-1.0-0 amd64 
1.36.8-3 [200 kB]
Get:67 http://ftp.de.debian.org/debian/ sid/main libxcomposite1 amd64 1:0.4.4-1 
[17.4 kB]
Get:68 http://ftp.de.debian.org/debian/ sid/main libxfixes3

Build failed in Jenkins: lintian-tests_sid #625

2015-08-16 Thread jenkins

See 

Changes:

[niels] c/fields.pm: Use "an" (instead of "a") before "HTTP"

--
[...truncated 4754 lines...]
Running fields-essential 1.0... building... testing... ok.
Running fields-indep-without-arch-indep 1.0... building... testing... ok.
Running fields-maintainer 1.0... building... testing... ok.
Running fields-maintainer-general 1.0... building... testing... ok.
Running fields-malformed-vcs-fields 1.0... building... testing... ok.
Running fields-malformed-py-version 1.0... building... testing... ok.
Running fields-multi-arch 1.0... building... testing... ok.
Running fields-module-build-perl 1.0... building... testing... ok.
Running fields-multiple-x-deps 1.0... building... testing... ok.
Running fields-maintainer-bounces 1.0... building... testing... ok.
Running fields-depends-wildcard 1.0... building... testing... ok.
Running fields-java 1.0... building... testing... ok.
Running fields-no-homepage 1.0-1... building... testing... ok.
Running fields-no-human-maintainer 1.0... building... testing... ok.
Running fields-not-malformed-vcs-fields 1.0... building... testing... ok.
Running fields-qa-maint-address 1.0... building... testing... ok.
Running fields-no-source-homepage 1.0-1... building... testing... ok.
Running fields-redundant 1.0... building... testing... ok.
Running fields-perl-provides 0.26... building... testing... ok.
Running fields-qa-maint-name 1.0... building... testing... ok.
Running fields-udeb 1.0... building... testing... ok.
Running fields-transitional 1.0... building... testing... ok.
Running fields-uncanonical-vcs-fields 1.0... building... testing... ok.
Running fields-unknown-fields 1.0... building... testing... ok.
Running fields-uploaders 1.0... building... testing... ok.
Running fields-vcs-fields 1.0... building... testing... ok.
Running description-general 1.0... building... testing... ok.
Running fields-version-bad 0-.3... building... testing... ok.
Running fields-version-dot-dfsg 1.0.dfsg1-1... building... testing... ok.
Running fields-version-bad-rc 1.0+rc3-1... building... testing... ok.
Running fields-version-dfsg-native 1.0.dfsg1... building... testing... ok.
Running fields-root-maint-address 1.0... building... testing... ok.
Running files-adobe-font 1.0... building... testing... ok.
Running files-arch-indep-not-marked-all 1.0... building... testing... ok.
Running fields-section-general 1.0... building... testing... ok.
Running files-doxygen-documentation 1.0... building... testing... ok.
Running fields-virtual-packages 1.0... building... testing... ok.
Running files-extra-license 1.0... building... testing... ok.
Running files-embedded 1.0... building... testing... ok.
Running files-empty 1.0... building... testing... ok.
Running fields-version-dsfg 1.0+dsfg1-1... building... testing... ok.
Running filename-length-really-really-really-really-long-package-name 
1.0.and.a.really.long.version.too-1... building... testing... ok.
Running files-foo-violates-expected-naming 1.0... building... testing... ok.
Running files-flash-non-free 1.0... building... testing... ok.
Running files-bad-perm-owner 1.0... building... testing... ok.
Running files-fonts 1.0... building... testing... ok.
Running files-hardlinks 1.0... building... testing... ok.
Running files-ieee-data 1.0... building... testing... ok.
Running files-locales 1.0... building... testing... ok.
Running files-foo-in-bar 1.0... building... testing... ok.
Running files-gzip 1.0-1... building... testing... ok.
Running files-gzip-ma-same 1.0... building... testing... ok.
Running files-privacybreach 1.0... building... testing... ok.
Running files-package-contains-foo 1.0... building... testing... ok.
Running files-python-helpers 1.0... building... testing... ok.
Running files-special-file 1.0... building... testing... ok.
Running files-python-modules 1.0... building... testing... ok.
Running files-games-section 1.0... building... testing... ok.
Running files-general 1.0... building... testing... ok.
Running files-symlinks 1.0... building... testing... ok.
Running files-pkgconfig 1.0... building... testing... ok.
Running files-tar-traps 1.0... building... testing... ok.
Running files-uses-perl4-libs-with-dep 1.0... building... testing... ok.
Running files-override-misplaced 1.0... building... testing... ok.
Running files-uses-perl4-libs-without-dep 1.0... building... testing... ok.
Running files-zero-byte-doc 1.0... building... testing... ok.
Running files-wrong-owner 1.0... building... testing... ok.
Running infofiles-general 1.0... building... testing... ok.
Running group-checks-file-conflict 1.0... building... testing... ok.
Running group-checks-wrong-priorities 1.0... building... testing... ok.
Running files-python-general 1.0... building... testing... ok.
Running init.d-symlink 1.0... building... testing... ok.
Running md5sums-general 1.0... building... testing... ok.
Running menu-format-desktop-general 1.0... building.

Bug#795614: [PATCH] fix false-positive spelling-error-in-binary affecting many Go binaries

2015-08-16 Thread Niels Thykier

On 2015-08-15 21:59, Michael Stapelberg wrote:
> Package: lintian
> Version: 2.5.33
> Severity: normal
> Tags: patch
> 
>>From the patch description:
>  [PATCH] spelling-error-in-binary: ignore ang/and
>  
>  The Go stdlib html/ package contains the string "ang;" (for the ∠
>  entity). Every program which directly or indirectly imports the html/
>  package will hence end up with an unuseful spelling-error-in-binary
>  lintian warning.
> 
> [...]

Hi Michael,

Thanks for the patch.

I was wondering, have you tried something like?

"""
$ git diff
diff --git a/lib/Lintian/Check.pm b/lib/Lintian/Check.pm
index 4b08fae..0b11477 100644
--- a/lib/Lintian/Check.pm
+++ b/lib/Lintian/Check.pm
@@ -301,6 +301,7 @@ sub check_spelling {
 $text =~ s/(\w-)\s*\n\s*/$1/;
 $text =~ tr/\r\n \t/ /s;
 $text =~ s/\s++/ /g;
+$text =~ s/\&[a-zA-Z0-9_-]+\;//g; # Ignore XML entities
 strip($text);

 for my $word (split(' ', $text)) {
"""

AFAICT, it should strip out all XML entities (untested though), which
should be a more generic solution.  Does this work for you?

Thanks,
~Niels

[lintian] 01/01: Suppress hardening-{no-relro, no-fortify-functions} for Go binaries.

2015-08-16 Thread Niels Thykier

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 81863ecc347985856417ef2c871c3d77375916b4
Author: Michael Stapelberg 
Date:   Sun Aug 16 09:52:24 2015 +0200

Suppress hardening-{no-relro,no-fortify-functions} for Go binaries.

The Go compiler (gc) does not currently support these features, so do
not warn about them on _every_ binary which is implemented in Go.

Signed-off-by: Niels Thykier 
---
 checks/binaries.pm | 5 +
 debian/changelog   | 5 +
 2 files changed, 10 insertions(+)

diff --git a/checks/binaries.pm b/checks/binaries.pm
index 94197b6..fe02fee 100644
--- a/checks/binaries.pm
+++ b/checks/binaries.pm
@@ -546,6 +546,11 @@ sub run {
 if ($flags) {
 foreach my $t (@{$info->hardening_info->{$fname}}) {
 my $tag = "hardening-$t";
+# Binaries built by the Go compiler do not support all
+# hardening measures.
+next if ($t eq 'no-relro' ||
+ $t eq 'no-fortify-functions') &&
+ $built_with_golang;
 tag $tag, $file if $flags->{$tag};
 }
 }
diff --git a/debian/changelog b/debian/changelog
index 070370a..2e01731 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,11 @@ lintian (2.5.37) UNRELEASED; urgency=medium
 
"XXX: generate tag summary"
 
+  * checks/binaries.pm:
++ [NT] Apply patch from Michael Stapelberg to ignore
+  "no-relro" and "no-fortify-functions" issues in
+  binaries built by the go compiler, as it does not
+  support these features.  (Closes: #795667)
   * checks/fields.desc:
 + [JW] Use "an" (instead of "a") before "HTTP".
 

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#795614: [PATCH] fix false-positive spelling-error-in-binary affecting many Go binaries

2015-08-16 Thread Michael Stapelberg

On Sun, Aug 16, 2015 at 10:11 AM, Niels Thykier  wrote:
> On 2015-08-15 21:59, Michael Stapelberg wrote:
>> Package: lintian
>> Version: 2.5.33
>> Severity: normal
>> Tags: patch
>>
>>>From the patch description:
>>  [PATCH] spelling-error-in-binary: ignore ang/and
>>
>>  The Go stdlib html/ package contains the string "ang;" (for the ∠
>>  entity). Every program which directly or indirectly imports the html/
>>  package will hence end up with an unuseful spelling-error-in-binary
>>  lintian warning.
>>
>> [...]
>
> Hi Michael,
>
> Thanks for the patch.
>
> I was wondering, have you tried something like?
>
> """
> $ git diff
> diff --git a/lib/Lintian/Check.pm b/lib/Lintian/Check.pm
> index 4b08fae..0b11477 100644
> --- a/lib/Lintian/Check.pm
> +++ b/lib/Lintian/Check.pm
> @@ -301,6 +301,7 @@ sub check_spelling {
>  $text =~ s/(\w-)\s*\n\s*/$1/;
>  $text =~ tr/\r\n \t/ /s;
>  $text =~ s/\s++/ /g;
> +$text =~ s/\&[a-zA-Z0-9_-]+\;//g; # Ignore XML entities
>  strip($text);
>
>  for my $word (split(' ', $text)) {
> """
>
> AFAICT, it should strip out all XML entities (untested though), which
> should be a more generic solution.  Does this work for you?

I think your patch does indeed strip out XML entities, but it doesn’t
quite work for our use-case: note that the string that’s found in the
binary is “ang;”, not “∠”.

-- 
Best regards,
Michael

Processed: limit source to lintian, tagging 795667

2015-08-16 Thread Debian Bug Tracking System

Processing commands for cont...@bugs.debian.org:

> limit source lintian
Limiting to bugs with field 'source' containing at least one of 'lintian'
Limit currently set to 'source':'lintian'

> tags 795667 + pending
Bug #795667 [lintian] Suppress hardening-{no-relro,no-fortify-functions}
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
795667: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=795667
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

[lintian] 01/01: L::Tags: Properly rename a tag

2015-08-16 Thread Niels Thykier

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 547a7a10372fb6d4577d706c7aac3ed0f30dc850
Author: Niels Thykier 
Date:   Sun Aug 16 10:26:48 2015 +0200

L::Tags: Properly rename a tag

Signed-off-by: Niels Thykier 
---
 lib/Lintian/Tags.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Lintian/Tags.pm b/lib/Lintian/Tags.pm
index 65590bd..cb9f610 100644
--- a/lib/Lintian/Tags.pm
+++ b/lib/Lintian/Tags.pm
@@ -626,7 +626,7 @@ sub file_overrides {
 $tag = $tagover->{'tag'};
 
 unless($tag eq $rawtag) {
-tag('renamed-override',"$rawtag => $tag at line $.");
+tag 'renamed-tag',"$rawtag => $tag at line $.";
 }
 
 # treat here ignored overrides

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 02/02: c/binaries.pm: Apply perltidy

2015-08-16 Thread Niels Thykier

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit a1547d038fd1c30dac93d5ae401097244f6d7d6f
Author: Niels Thykier 
Date:   Sun Aug 16 10:30:01 2015 +0200

c/binaries.pm: Apply perltidy

Signed-off-by: Niels Thykier 
---
 checks/binaries.pm | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/checks/binaries.pm b/checks/binaries.pm
index 3542611..57ca2f0 100644
--- a/checks/binaries.pm
+++ b/checks/binaries.pm
@@ -549,9 +549,10 @@ sub run {
 my $tag = "hardening-$t";
 # Binaries built by the Go compiler do not support all
 # hardening measures.
-next if ($t eq 'no-relro' ||
- $t eq 'no-fortify-functions') &&
- $built_with_golang;
+next
+  if ($t eq 'no-relro'
+||$t eq 'no-fortify-functions')
+  &&$built_with_golang;
 tag $tag, $file if $flags->{$tag};
 }
 }

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/02: spelling-error-in-binary: ignore ang/and

2015-08-16 Thread Niels Thykier

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 1e02bb17df87a3079517fcec81be77b2889247dd
Author: Michael Stapelberg 
Date:   Sat Aug 15 21:54:16 2015 +0200

spelling-error-in-binary: ignore ang/and

The Go stdlib html/ package contains the string "ang;" (for the ∠
entity). Every program which directly or indirectly imports the html/
package will hence end up with an unuseful spelling-error-in-binary
lintian warning.

Signed-off-by: Niels Thykier 
---
 checks/binaries.pm | 1 +
 debian/changelog   | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/checks/binaries.pm b/checks/binaries.pm
index fe02fee..3542611 100644
--- a/checks/binaries.pm
+++ b/checks/binaries.pm
@@ -364,6 +364,7 @@ sub run {
 'teH' => 1, # From #711207
 'tEH' => 1, # From #782902
 'tEh' => 1, # From #782902, too
+'ang' => 1, # The Go stdlib html/ package contains "ang;"
 };
 my $tag_emitter
   = spelling_tag_emitter('spelling-error-in-binary', $file);
diff --git a/debian/changelog b/debian/changelog
index 2e01731..9acaca0 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -7,6 +7,9 @@ lintian (2.5.37) UNRELEASED; urgency=medium
   "no-relro" and "no-fortify-functions" issues in
   binaries built by the go compiler, as it does not
   support these features.  (Closes: #795667)
++ [NT] Apply patch from Michael Stapelberg to a
+  common false positive spelling mistake in "go"
+  binaries.  (Closes: #795614)
   * checks/fields.desc:
 + [JW] Use "an" (instead of "a") before "HTTP".
 

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Processed: limit source to lintian, tagging 795614

2015-08-16 Thread Debian Bug Tracking System

Processing commands for cont...@bugs.debian.org:

> limit source lintian
Limiting to bugs with field 'source' containing at least one of 'lintian'
Limit currently set to 'source':'lintian'

> tags 795614 + pending
Bug #795614 [lintian] [PATCH] fix false-positive spelling-error-in-binary 
affecting many Go binaries
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
795614: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=795614
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

[lintian] branch master updated (21c963f -> 81863ec)

2015-08-16 Thread Niels Thykier

This is an automated email from the git hooks/post-receive script.

nthykier pushed a change to branch master
in repository lintian.

  from  21c963f   c/fields.pm: Use "an" (instead of "a") before "HTTP"
   new  81863ec   Suppress hardening-{no-relro,no-fortify-functions} for Go 
binaries.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/binaries.pm | 5 +
 debian/changelog   | 5 +
 2 files changed, 10 insertions(+)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (81863ec -> 547a7a1)

2015-08-16 Thread Niels Thykier

This is an automated email from the git hooks/post-receive script.

nthykier pushed a change to branch master
in repository lintian.

  from  81863ec   Suppress hardening-{no-relro,no-fortify-functions} for Go 
binaries.
   new  547a7a1   L::Tags: Properly rename a tag

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 lib/Lintian/Tags.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (547a7a1 -> a1547d0)

2015-08-16 Thread Niels Thykier

This is an automated email from the git hooks/post-receive script.

nthykier pushed a change to branch master
in repository lintian.

  from  547a7a1   L::Tags: Properly rename a tag
   new  1e02bb1   spelling-error-in-binary: ignore ang/and
   new  a1547d0   c/binaries.pm: Apply perltidy

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/binaries.pm | 8 +---
 debian/changelog   | 3 +++
 2 files changed, 8 insertions(+), 3 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Build failed in Jenkins: lintian-tests_sid #626

2015-08-16 Thread jenkins

See 

Changes:

[niels] Suppress hardening-{no-relro,no-fortify-functions} for Go binaries.

--
[...truncated 4760 lines...]
Running fields-java 1.0... building... testing... ok.
Running fields-duplicate-build 1.0... building... testing... ok.
Running fields-maintainer-bounces 1.0... building... testing... ok.
Running fields-malformed-py-version 1.0... building... testing... ok.
Running fields-maintainer-general 1.0... building... testing... ok.
Running fields-malformed-vcs-fields 1.0... building... testing... ok.
Running fields-module-build-perl 1.0... building... testing... ok.
Running fields-depends-metapackage 1.0... building... testing... ok.
Running fields-multiple-x-deps 1.0... building... testing... ok.
Running fields-no-human-maintainer 1.0... building... testing... ok.
Running fields-no-homepage 1.0-1... building... testing... ok.
Running fields-debug-bad 1.0... building... testing... ok.
Running fields-no-source-homepage 1.0-1... building... testing... ok.
Running fields-qa-maint-address 1.0... building... testing... ok.
Running fields-not-malformed-vcs-fields 1.0... building... testing... ok.
Running fields-qa-maint-name 1.0... building... testing... ok.
Running fields-perl-provides 0.26... building... testing... ok.
Running fields-redundant 1.0... building... testing... ok.
Running fields-maintainer 1.0... building... testing... ok.
Running fields-root-maint-address 1.0... building... testing... ok.
Running fields-transitional 1.0... building... testing... ok.
Running fields-udeb 1.0... building... testing... ok.
Running fields-multi-arch 1.0... building... testing... ok.
Running fields-section-general 1.0... building... testing... ok.
Running fields-uploaders 1.0... building... testing... ok.
Running fields-unknown-fields 1.0... building... testing... ok.
Running fields-vcs-fields 1.0... building... testing... ok.
Running fields-version-dfsg-native 1.0.dfsg1... building... testing... ok.
Running fields-version-bad-rc 1.0+rc3-1... building... testing... ok.
Running fields-version-dot-dfsg 1.0.dfsg1-1... building... testing... ok.
Running fields-version-dsfg 1.0+dsfg1-1... building... testing... ok.
Running description-general 1.0... building... testing... ok.
Running fields-uncanonical-vcs-fields 1.0... building... testing... ok.
Running filename-length-really-really-really-really-long-package-name 
1.0.and.a.really.long.version.too-1... building... testing... ok.
Running files-adobe-font 1.0... building... testing... ok.
Running files-arch-indep-not-marked-all 1.0... building... testing... ok.
Running fields-virtual-packages 1.0... building... testing... ok.
Running files-embedded 1.0... building... testing... ok.
Running files-extra-license 1.0... building... testing... ok.
Running fields-version-bad 0-.3... building... testing... ok.
Running files-empty 1.0... building... testing... ok.
Running files-foo-violates-expected-naming 1.0... building... testing... ok.
Running files-gzip-ma-same 1.0... building... testing... ok.
Running files-fonts 1.0... building... testing... ok.
Running files-flash-non-free 1.0... building... testing... ok.
Running files-hardlinks 1.0... building... testing... ok.
Running files-bad-perm-owner 1.0... building... testing... ok.
Running files-gzip 1.0-1... building... testing... ok.
Running files-ieee-data 1.0... building... testing... ok.
Running files-locales 1.0... building... testing... ok.
Running files-override-misplaced 1.0... building... testing... ok.
Running files-general 1.0... building... testing... ok.
Running files-package-contains-foo 1.0... building... testing... ok.
Running files-python-helpers 1.0... building... testing... ok.
Running files-privacybreach 1.0... building... testing... ok.
Running files-foo-in-bar 1.0... building... testing... ok.
Running files-python-modules 1.0... building... testing... ok.
Running files-special-file 1.0... building... testing... ok.
Running files-games-section 1.0... building... testing... ok.
Running files-symlinks 1.0... building... testing... ok.
Running files-pkgconfig 1.0... building... testing... ok.
Running files-tar-traps 1.0... building... testing... ok.
Running files-uses-perl4-libs-with-dep 1.0... building... testing... ok.
Running files-uses-perl4-libs-without-dep 1.0... building... testing... ok.
Running files-wrong-owner 1.0... building... testing... ok.
Running files-doxygen-documentation 1.0... building... testing... ok.
Running files-zero-byte-doc 1.0... building... testing... ok.
Running huge-usr-share-percent 1.0... building... testing... ok.
Running group-checks-file-conflict 1.0... building... testing... ok.
Running infofiles-general 1.0... building... testing... ok.
Running group-checks-wrong-priorities 1.0... building... testing... ok.
Running files-python-general 1.0... building... testing... ok.
Running init.d-script-registration 1.0... building... testing... ok.
Running init.d-symlink 1

Build failed in Jenkins: lintian-tests_sid #627

2015-08-16 Thread jenkins

See 

Changes:

[niels] L::Tags: Properly rename a tag

[niels] spelling-error-in-binary: ignore ang/and

[niels] c/binaries.pm: Apply perltidy

--
[...truncated 4745 lines...]
Running fields-depends-general 1.0... building... testing... ok.
Running fields-maintainer 1.0... building... testing... ok.
Running fields-maintainer-bounces 1.0... building... testing... ok.
Running fields-indep-without-arch-indep 1.0... building... testing... ok.
Running fields-essential 1.0... building... testing... ok.
Running fields-maintainer-general 1.0... building... testing... ok.
Running fields-malformed-py-version 1.0... building... testing... ok.
Running fields-java 1.0... building... testing... ok.
Running fields-debug-bad 1.0... building... testing... ok.
Running fields-multi-arch 1.0... building... testing... ok.
Running fields-multiple-x-deps 1.0... building... testing... ok.
Running fields-no-homepage 1.0-1... building... testing... ok.
Running fields-module-build-perl 1.0... building... testing... ok.
Running fields-font-not-multiarch-foreign 1.0... building... testing... ok.
Running fields-no-human-maintainer 1.0... building... testing... ok.
Running fields-not-malformed-vcs-fields 1.0... building... testing... ok.
Running fields-malformed-vcs-fields 1.0... building... testing... ok.
Running fields-qa-maint-address 1.0... building... testing... ok.
Running fields-perl-provides 0.26... building... testing... ok.
Running fields-qa-maint-name 1.0... building... testing... ok.
Running fields-transitional 1.0... building... testing... ok.
Running fields-udeb 1.0... building... testing... ok.
Running fields-uploaders 1.0... building... testing... ok.
Running fields-unknown-fields 1.0... building... testing... ok.
Running description-general 1.0... building... testing... ok.
Running fields-vcs-fields 1.0... building... testing... ok.
Running fields-section-general 1.0... building... testing... ok.
Running fields-version-bad-rc 1.0+rc3-1... building... testing... ok.
Running fields-no-source-homepage 1.0-1... building... testing... ok.
Running fields-version-bad 0-.3... building... testing... ok.
Running fields-redundant 1.0... building... testing... ok.
Running fields-version-dfsg-native 1.0.dfsg1... building... testing... ok.
Running fields-version-dot-dfsg 1.0.dfsg1-1... building... testing... ok.
Running fields-root-maint-address 1.0... building... testing... ok.
Running filename-length-really-really-really-really-long-package-name 
1.0.and.a.really.long.version.too-1... building... testing... ok.
Running fields-uncanonical-vcs-fields 1.0... building... testing... ok.
Running files-adobe-font 1.0... building... testing... ok.
Running fields-virtual-packages 1.0... building... testing... ok.
Running files-arch-indep-not-marked-all 1.0... building... testing... ok.
Running fields-version-dsfg 1.0+dsfg1-1... building... testing... ok.
Running files-embedded 1.0... building... testing... ok.
Running files-doxygen-documentation 1.0... building... testing... ok.
Running files-foo-violates-expected-naming 1.0... building... testing... ok.
Running files-extra-license 1.0... building... testing... ok.
Running files-empty 1.0... building... testing... ok.
Running files-hardlinks 1.0... building... testing... ok.
Running files-gzip-ma-same 1.0... building... testing... ok.
Running files-ieee-data 1.0... building... testing... ok.
Running files-gzip 1.0-1... building... testing... ok.
Running files-locales 1.0... building... testing... ok.
Running files-general 1.0... building... testing... ok.
Running files-foo-in-bar 1.0... building... testing... ok.
Running files-bad-perm-owner 1.0... building... testing... ok.
Running files-package-contains-foo 1.0... building... testing... ok.
Running files-privacybreach 1.0... building... testing... ok.
Running files-games-section 1.0... building... testing... ok.
Running files-override-misplaced 1.0... building... testing... ok.
Running files-python-helpers 1.0... building... testing... ok.
Running files-special-file 1.0... building... testing... ok.
Running files-flash-non-free 1.0... building... testing... ok.
Running files-symlinks 1.0... building... testing... ok.
Running files-python-modules 1.0... building... testing... ok.
Running files-fonts 1.0... building... testing... ok.
Running files-uses-perl4-libs-with-dep 1.0... building... testing... ok.
Running files-uses-perl4-libs-without-dep 1.0... building... testing... ok.
Running files-wrong-owner 1.0... building... testing... ok.
Running infofiles-general 1.0... building... testing... ok.
Running huge-usr-share-percent 1.0... building... testing... ok.
Running group-checks-wrong-priorities 1.0... building... testing... ok.
Running group-checks-file-conflict 1.0... building... testing... ok.
Running files-zero-byte-doc 1.0... building... testing... ok.
Running init.d-script-registration 1.0... building... testing... ok.
Running ini

Processed: Re: Bug#795641: lintian: [PATCH] fix common license false positives in new-style copyright files

2015-08-16 Thread Debian Bug Tracking System

Processing control commands:

> tags -1 - moreinfo
Bug #795641 [lintian] lintian: [PATCH] fix common license false positives in 
new-style copyright files
Ignoring request to alter tags of bug #795641 to the same tags previously set

-- 
795641: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=795641
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#795641: lintian: [PATCH] fix common license false positives in new-style copyright files

2015-08-16 Thread Niels Thykier

Control: tags -1 - moreinfo

On 2015-08-16 00:13, Rafael Kitover wrote:
> Package: lintian
> Version: 2.5.35
> Severity: normal
> 
> This patch fixes lack-of-common-license-reference false positives in
> new-style copyright files when a license refers to one of these common
> licenses.
> 
> It includes a test for this against all common licenses.
> 
> All testsuite tests pass.
> 
> The patch is against the debcheckout of lintian.
> 
> [...]
> 

Hi,

Thanks for looking in to this.

I do have some concerns with the implementation, see below interleaved.

> 0001-fix-common-lic.-false-pos.-in-new-style-copyright.patch
> 
> 
>>From 441f44c5be0fe70d9a86b3ee0cec49430b0c2a9d Mon Sep 17 00:00:00 2001
> From: Rafael Kitover 
> Date: Sat, 15 Aug 2015 17:50:34 -0400
> Subject: [PATCH] fix common lic. false pos. in new-style copyright
> 
> Fix false positives for lack of common license references in new-style
> copyright files when a license refers to another license, by trying to
> parse the file and then checking both the names of the licenses and the
> texts.
> 
> Add new test for references to common licenses as well.
> 
> The test suite passes with these changes.
> ---
>  [...]
> 
> diff --git a/checks/copyright-file.pm b/checks/copyright-file.pm
> index c6e35ef..09b664e 100644
> --- a/checks/copyright-file.pm
> +++ b/checks/copyright-file.pm
> [...]
> @@ -373,6 +426,45 @@ sub check_cross_link {
>  return;
>  }
>  
> +# Checks the name and text of every license in the file against given name 
> and
> +# text check coderefs, if the file is in the new format, if the file is in 
> the
> +# old format only runs the text coderef against the whole file.
> +sub check_names_texts {

This is called multiple times.  Each time it opens and parses the
copyright file at least once each.

I would like to see this done smarter and less wastefully.  Please note
that we have some very large copyright files or/and source packages
producing many binaries with a copyright file in each of them.

Have you looked at the performance of this check on some packages?
Lintian has a few built-in options to help you here:

$ lintian --help=extended | grep perf
--perf-debug  turn on performance debugging
--perf-output X   send performance logging to file (...)


> +my ($name_check, $text_check, $file) = @_;
> +
> +local $@;
> +eval {
> +foreach my $paragraph (read_dpkg_control($file)) {
  

(First read of the file.)

> +next
> +  unless (keys %$paragraph == 1)
> +  && ((keys %$paragraph)[0] =~ /^license$/i);
 ^

Please use "exists($paragraph->{'license'})" instead.

> +
> +my ($license_name, $license_text)
> +  = (values %$paragraph)[0] =~ /^([^\r\n]+)\r?\n(.*)\z/s;
> +
> +my $matches = do {
> +local $_ = $license_name || '';
> +$name_check->($_);

$name_check is always a single regex.  Consider passing it as a qr// and
do a normal regex check here instead of calling a separate sub.  This
would also avoid the "local $_", which is somewhat expensive.

> +  }
> +  && do {
> +local $_ = $license_text || '';
> +$text_check->($_);
> +  };

If we could avoid the subroutine + local $_; here too that would be nice
as well.

> +
> +die 'MATCH' if $matches;
> +}
> +};
> +if ($@)
> +{ # match or parse error: copyright not in new format, just check text
> +return 1 if $@ =~ /^MATCH/;
> +
> +local $_ = slurp_entire_file($file);
  
(Second read of the file.)

> +return $text_check->($_);
> +}
> +
> +return; # did not match anything
> +}
> +
>  1;
>  
>  # Local Variables:
> diff --git 
> a/t/tests/copyright-file-non-common-license/debian/debian/control.in 
> b/t/tests/copyright-file-non-common-license/debian/debian/control.in
> new file mode 100644
> index 000..e80822d
> --- /dev/null
> +++ b/t/tests/copyright-file-non-common-license/debian/debian/control.in
> @@ -0,0 +1,94 @@
> +Source: {$source}
> +Priority: extra
> +Section: {$section}
> +Maintainer: {$author}
> +Standards-Version: {$standards_version}
> +Build-Depends: debhelper (>= 9)
> +
> +Package: copyright-mentions-apache
> +Architecture: all
> +Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
> +Description: checks against common license false positive for Apache
> + Tests against common license false positive for Apache.
> + .
> + This is a test package designed to exercise some feature or tag of
> + Lintian.  It is part of the Lintian test suite and may do very odd
> + things.  It should not be installed like a regular package.  It may
> + be an empty package.
> +
> +Package: copyright-mentions-apache2
> +Architecture: all
> +Depends: $\{shlibs:Depends\}, $\

Bug#795641: lintian: [PATCH] fix common license false positives in new-style copyright files

2015-08-16 Thread Bastien ROUCARIÈS

Le dimanche 16 août 2015, 14:20:33 Niels Thykier a écrit :
> Control: tags -1 - moreinfo
> 
> On 2015-08-16 00:13, Rafael Kitover wrote:
> > Package: lintian
> > Version: 2.5.35
> > Severity: normal
> > 
> > This patch fixes lack-of-common-license-reference false positives in
> > new-style copyright files when a license refers to one of these common
> > licenses.
> > 
> > It includes a test for this against all common licenses.
> > 
> > All testsuite tests pass.
> > 
> > The patch is against the debcheckout of lintian.
> > 
> > [...]
> > 
> 
> Hi,
> 
> Thanks for looking in to this.
> 
> I do have some concerns with the implementation, see below interleaved.
> 
> > 0001-fix-common-lic.-false-pos.-in-new-style-copyright.patch
> > 
> > 
> >>From 441f44c5be0fe70d9a86b3ee0cec49430b0c2a9d Mon Sep 17 00:00:00 2001
> > From: Rafael Kitover 
> > Date: Sat, 15 Aug 2015 17:50:34 -0400
> > Subject: [PATCH] fix common lic. false pos. in new-style copyright
> > 
> > Fix false positives for lack of common license references in new-style
> > copyright files when a license refers to another license, by trying to
> > parse the file and then checking both the names of the licenses and the
> > texts.
> > 
> > Add new test for references to common licenses as well.
> > 
> > The test suite passes with these changes.
> > ---
> >  [...]
> > 
> > diff --git a/checks/copyright-file.pm b/checks/copyright-file.pm
> > index c6e35ef..09b664e 100644
> > --- a/checks/copyright-file.pm
> > +++ b/checks/copyright-file.pm
> > [...]
> > @@ -373,6 +426,45 @@ sub check_cross_link {
> >  return;
> >  }
> >  
> > +# Checks the name and text of every license in the file against given name 
> > and
> > +# text check coderefs, if the file is in the new format, if the file is in 
> > the
> > +# old format only runs the text coderef against the whole file.
> > +sub check_names_texts {
> 
> This is called multiple times.  Each time it opens and parses the
> copyright file at least once each.
> 
> I would like to see this done smarter and less wastefully.  Please note
> that we have some very large copyright files or/and source packages
> producing many binaries with a copyright file in each of them.
> 
> Have you looked at the performance of this check on some packages?
> Lintian has a few built-in options to help you here:

I would not try to parse anything except copyright 1.0 format. 
The other format is slowly dying...

> 
> $ lintian --help=extended | grep perf
> --perf-debug  turn on performance debugging
> --perf-output X   send performance logging to file (...)
> 
> 
> > +my ($name_check, $text_check, $file) = @_;
> > +
> > +local $@;
> > +eval {
> > +foreach my $paragraph (read_dpkg_control($file)) {
>   

If you use copyright 1.0 we have parsed the format and we have hash

> (First read of the file.)
> 
> > +next
> > +  unless (keys %$paragraph == 1)
> > +  && ((keys %$paragraph)[0] =~ /^license$/i);
>  ^
> 
> Please use "exists($paragraph->{'license'})" instead.

Yes
> 
> > +
> > +my ($license_name, $license_text)
> > +  = (values %$paragraph)[0] =~ /^([^\r\n]+)\r?\n(.*)\z/s;
> > +
> > +my $matches = do {
> > +local $_ = $license_name || '';
> > +$name_check->($_);
> 
> $name_check is always a single regex.  Consider passing it as a qr// and
> do a normal regex check here instead of calling a separate sub.  This
> would also avoid the "local $_", which is somewhat expensive.
> 
> > +  }
> > +  && do {
> > +local $_ = $license_text || '';
> > +$text_check->($_);
> > +  };
> 
> If we could avoid the subroutine + local $_; here too that would be nice
> as well.
> 
> > +
> > +die 'MATCH' if $matches;
> > +}
> > +};
> > +if ($@)
> > +{ # match or parse error: copyright not in new format, just check text
> > +return 1 if $@ =~ /^MATCH/;
> > +
> > +local $_ = slurp_entire_file($file);
>   
> (Second read of the file.)
> 
> > +return $text_check->($_);
> > +}
> > +
> > +return; # did not match anything
> > +}
> > +
> >  1;
> >  
> >  # Local Variables:
> > diff --git 
> > a/t/tests/copyright-file-non-common-license/debian/debian/control.in 
> > b/t/tests/copyright-file-non-common-license/debian/debian/control.in
> > new file mode 100644
> > index 000..e80822d
> > --- /dev/null
> > +++ b/t/tests/copyright-file-non-common-license/debian/debian/control.in
> > @@ -0,0 +1,94 @@
> > +Source: {$source}
> > +Priority: extra
> > +Section: {$section}
> > +Maintainer: {$author}
> > +Standards-Version: {$standards_version}
> > +Build-Depends: debhelper (>= 9)
> > +
> > +Package: copyright-mentions-apache
> > +Architectu

Bug#795779: perl-module-name-not-mentioned-in-description false positive

2015-08-16 Thread Russ Allbery

Package: lintian
Version: 2.5.36.1
Severity: minor

I see:

X: libnet-duo-perl: perl-module-name-not-mentioned-in-description Net::Duo

However:

Package: libnet-duo-perl
Architecture: all
Depends: ${perl:Depends}, ${misc:Depends}, libjson-perl,
 libperl6-slurp-perl, libsub-install-perl, liburi-perl, libwww-perl
Description: Perl API for Duo multifactor authentication service
 Net::Duo provides an object-oriented Perl interface for the Duo Security
 REST APIs.  It attempts to abstract some of the API details and provide
 an object-oriented view of the returned objects in order to make use of
 the API in Perl code more natural than dealing with JSON data structures
 directly.  Currently, some parts of the Auth and Admin APIs are
 implemented alongside with generic methods to call any of the JSON-based
 APIs.

Maybe some problem recognizing module names at the start of the line?

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.1.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils   2.25.1-1
ii  bzip2  1.0.6-8
ii  diffstat   1.60-1
ii  file   1:5.22+15-2
ii  gettext0.19.5.1-1
ii  hardening-includes 2.7
ii  intltool-debian0.35.0+20060710.2
ii  libapt-pkg-perl0.1.29+b3
ii  libarchive-zip-perl1.49-1
ii  libclass-accessor-perl 0.34-1
ii  libclone-perl  0.38-1
ii  libdpkg-perl   1.18.2
ii  libemail-valid-perl1.196-1
ii  libfile-basedir-perl   0.07-1
ii  libipc-run-perl0.94-1
ii  liblist-moreutils-perl 0.413-1
ii  libparse-debianchangelog-perl  1.2.0-5
ii  libtext-levenshtein-perl   0.12-1
ii  libtimedate-perl   2.3000-2
ii  liburi-perl1.69-1
ii  man-db 2.7.0.2-5
ii  patchutils 0.3.4-1
ii  perl [libdigest-sha-perl]  5.20.2-6
ii  t1utils1.38-4
ii  xz-utils   5.1.1alpha+20120614-2.1

Versions of packages lintian recommends:
ii  dpkg1.18.2
ii  libautodie-perl 2.29-1
pn  libperlio-gzip-perl 
ii  perl5.20.2-6
ii  perl-modules [libautodie-perl]  5.20.2-6

Versions of packages lintian suggests:
pn  binutils-multiarch 
ii  dpkg-dev   1.18.2
ii  libhtml-parser-perl3.71-2
pn  libtext-template-perl  
pn  libyaml-perl   

-- no debconf information

Processed: tagging 795779

2015-08-16 Thread Debian Bug Tracking System

Processing commands for cont...@bugs.debian.org:

> tags 795779 + confirmed
Bug #795779 [lintian] perl-module-name-not-mentioned-in-description false 
positive
Added tag(s) confirmed.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
795779: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=795779
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Processed: owner 795779

2015-08-16 Thread Debian Bug Tracking System

Processing commands for cont...@bugs.debian.org:

> owner 795779 !
Bug #795779 [lintian] perl-module-name-not-mentioned-in-description false 
positive
Owner recorded as Axel Beckert .
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
795779: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=795779
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

[lintian] branch master updated (a1547d0 -> 0b692ca)

2015-08-16 Thread Axel Beckert

This is an automated email from the git hooks/post-receive script.

abe pushed a change to branch master
in repository lintian.

  from  a1547d0   c/binaries.pm: Apply perltidy
   new  0b692ca   Fix f/p in perl-module-name-not-mentioned-in-description 
(Closes: #795779)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/description.pm|  2 +-
 debian/changelog |  3 +++
 t/tests/description-perl/debian/debian/control.in| 12 +++-
 .../debian/{install => libdeb-long-description-perl.install} |  0
 .../debian/libdeb-long-description-proper-perl.install   |  1 +
 .../lib/Deb/Long/{Description.pm => Description/Proper.pm}   |  2 +-
 6 files changed, 17 insertions(+), 3 deletions(-)
 rename t/tests/description-perl/debian/debian/{install => 
libdeb-long-description-perl.install} (100%)
 create mode 100644 
t/tests/description-perl/debian/debian/libdeb-long-description-proper-perl.install
 copy t/tests/description-perl/debian/lib/Deb/Long/{Description.pm => 
Description/Proper.pm} (60%)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: Fix f/p in perl-module-name-not-mentioned-in-description (Closes: #795779)

2015-08-16 Thread Axel Beckert

This is an automated email from the git hooks/post-receive script.

abe pushed a commit to branch master
in repository lintian.

commit 0b692ca4ba7a9612e9fe05af5c3a1e0bf3fbdfb7
Author: Axel Beckert 
Date:   Sun Aug 16 22:06:42 2015 +0200

Fix f/p in perl-module-name-not-mentioned-in-description (Closes: #795779)

index() was called with its parameter order being the wrong way. This
was not present in pkg-perl-tools as using index() replaced the
previously used regular expression matching for performance reasons.

This also adds a test case for such a false positive, i.e. there's now
a package in the test suite which shouldn't trigger the tag.
---
 checks/description.pm|  2 +-
 debian/changelog |  3 +++
 t/tests/description-perl/debian/debian/control.in| 12 +++-
 .../debian/{install => libdeb-long-description-perl.install} |  0
 .../debian/libdeb-long-description-proper-perl.install   |  1 +
 .../debian/lib/Deb/Long/Description/Proper.pm|  5 +
 6 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/checks/description.pm b/checks/description.pm
index 0f2eaec..badf31f 100644
--- a/checks/description.pm
+++ b/checks/description.pm
@@ -268,7 +268,7 @@ sub run {
 }
 
 tag 'perl-module-name-not-mentioned-in-description', $mod
-  if (index($mod_lc, lc($description)) < 0 and $pm_found);
+  if (index(lc($description), $mod_lc) < 0 and $pm_found);
 }
 
 return;
diff --git a/debian/changelog b/debian/changelog
index 9acaca0..daa4f0c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -10,6 +10,9 @@ lintian (2.5.37) UNRELEASED; urgency=medium
 + [NT] Apply patch from Michael Stapelberg to a
   common false positive spelling mistake in "go"
   binaries.  (Closes: #795614)
+  * checks/description.pm:
++ [AB] Fix false positives in
+  perl-module-name-not-mentioned-in-description (Closes: #795779)
   * checks/fields.desc:
 + [JW] Use "an" (instead of "a") before "HTTP".
 
diff --git a/t/tests/description-perl/debian/debian/control.in 
b/t/tests/description-perl/debian/debian/control.in
index cf75af0..de25b04 100644
--- a/t/tests/description-perl/debian/debian/control.in
+++ b/t/tests/description-perl/debian/debian/control.in
@@ -13,4 +13,14 @@ Description: lintian dummy package to test a module name 
related check
  about not mentioning the contained perl module.
  .
  For testing and length-ish purposes, with Long::Description a similar
- name is mentioned though
+ name is mentioned though.
+
+Package: libdeb-long-description-proper-perl
+Architecture: {$architecture}
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Description: lintian dummy package to test a module name related false positive
+ This package is solely meant for testing a lintian check to argue
+ about not mentioning the contained perl module.
+ .
+ This is a package which checks the test for false positives, so it
+ actually mentions Deb::Long::Description::Proper.
diff --git a/t/tests/description-perl/debian/debian/install 
b/t/tests/description-perl/debian/debian/libdeb-long-description-perl.install
similarity index 100%
rename from t/tests/description-perl/debian/debian/install
rename to 
t/tests/description-perl/debian/debian/libdeb-long-description-perl.install
diff --git 
a/t/tests/description-perl/debian/debian/libdeb-long-description-proper-perl.install
 
b/t/tests/description-perl/debian/debian/libdeb-long-description-proper-perl.install
new file mode 100644
index 000..5c2f399
--- /dev/null
+++ 
b/t/tests/description-perl/debian/debian/libdeb-long-description-proper-perl.install
@@ -0,0 +1 @@
+lib/Deb/Long/Description/Proper.pm usr/share/perl5/Deb/Long/Description
diff --git a/t/tests/description-perl/debian/lib/Deb/Long/Description/Proper.pm 
b/t/tests/description-perl/debian/lib/Deb/Long/Description/Proper.pm
new file mode 100644
index 000..67230b9
--- /dev/null
+++ b/t/tests/description-perl/debian/lib/Deb/Long/Description/Proper.pm
@@ -0,0 +1,5 @@
+# Dummy Perl module for lintian testing purposes.
+
+package Deb::Long::Description::Proper;
+
+return 1;

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Processed: tagging 795779

2015-08-16 Thread Debian Bug Tracking System

Processing commands for cont...@bugs.debian.org:

> tags 795779 + pending
Bug #795779 [lintian] perl-module-name-not-mentioned-in-description false 
positive
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
795779: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=795779
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#795779: perl-module-name-not-mentioned-in-description false positive

2015-08-16 Thread Axel Beckert

Hi Russ,

> perl-module-name-not-mentioned-in-description false positive

thanks for the report. This already made the round here at DebConf. At
least gregoa and Guillem notified me IRL, too. :-)

The test was fine in pkg-perl-tools. I tried to optimise it for
lintian proper as preferred by Niels, but mixed up the parameters to
perl's index() function. Hence the tons of false positives.

The test suite didn't have a false positive check, so I didn't notice. 

I just fixed it in git and added such a test for false positives.
(Actually I wrote the test first and made sure it failed. :-)

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Build failed in Jenkins: lintian-tests_sid #628

2015-08-16 Thread jenkins

See 

Changes:

[abe] Fix f/p in perl-module-name-not-mentioned-in-description (Closes:

--
[...truncated 4744 lines...]
Running fields-indep-without-arch-indep 1.0... building... testing... ok.
Running fields-maintainer 1.0... building... testing... ok.
Running fields-build-profiles-general 1.0... building... testing... ok.
Running fields-depends-general 1.0... building... testing... ok.
Running fields-maintainer-bounces 1.0... building... testing... ok.
Running fields-maintainer-general 1.0... building... testing... ok.
Running fields-malformed-py-version 1.0... building... testing... ok.
Running fields-java 1.0... building... testing... ok.
Running fields-malformed-vcs-fields 1.0... building... testing... ok.
Running fields-module-build-perl 1.0... building... testing... ok.
Running fields-multiple-x-deps 1.0... building... testing... ok.
Running fields-no-homepage 1.0-1... building... testing... ok.
Running fields-multi-arch 1.0... building... testing... ok.
Running fields-no-human-maintainer 1.0... building... testing... ok.
Running fields-not-malformed-vcs-fields 1.0... building... testing... ok.
Running fields-no-source-homepage 1.0-1... building... testing... ok.
Running fields-essential 1.0... building... testing... ok.
Running fields-qa-maint-address 1.0... building... testing... ok.
Running fields-qa-maint-name 1.0... building... testing... ok.
Running fields-redundant 1.0... building... testing... ok.
Running fields-perl-provides 0.26... building... testing... ok.
Running fields-root-maint-address 1.0... building... testing... ok.
Running fields-essential-yes-source 1.0... building... testing... ok.
Running fields-transitional 1.0... building... testing... ok.
Running fields-uncanonical-vcs-fields 1.0... building... testing... ok.
Running fields-udeb 1.0... building... testing... ok.
Running fields-unknown-fields 1.0... building... testing... ok.
Running fields-vcs-fields 1.0... building... testing... ok.
Running fields-section-general 1.0... building... testing... ok.
Running fields-uploaders 1.0... building... testing... ok.
Running fields-version-dfsg-native 1.0.dfsg1... building... testing... ok.
Running fields-version-bad 0-.3... building... testing... ok.
Running fields-version-dsfg 1.0+dsfg1-1... building... testing... ok.
Running fields-version-dot-dfsg 1.0.dfsg1-1... building... testing... ok.
Running filename-length-really-really-really-really-long-package-name 
1.0.and.a.really.long.version.too-1... building... testing... ok.
Running fields-version-bad-rc 1.0+rc3-1... building... testing... ok.
Running fields-virtual-packages 1.0... building... testing... ok.
Running files-adobe-font 1.0... building... testing... ok.
Running files-doxygen-documentation 1.0... building... testing... ok.
Running files-embedded 1.0... building... testing... ok.
Running files-extra-license 1.0... building... testing... ok.
Running files-empty 1.0... building... testing... ok.
Running files-arch-indep-not-marked-all 1.0... building... testing... ok.
Running files-foo-violates-expected-naming 1.0... building... testing... ok.
Running description-general 1.0... building... testing... ok.
Running files-flash-non-free 1.0... building... testing... ok.
Running files-gzip-ma-same 1.0... building... testing... ok.
Running files-hardlinks 1.0... building... testing... ok.
Running files-gzip 1.0-1... building... testing... ok.
Running files-fonts 1.0... building... testing... ok.
Running files-ieee-data 1.0... building... testing... ok.
Running files-override-misplaced 1.0... building... testing... ok.
Running files-bad-perm-owner 1.0... building... testing... ok.
Running files-locales 1.0... building... testing... ok.
Running files-general 1.0... building... testing... ok.
Running files-foo-in-bar 1.0... building... testing... ok.
Running files-python-helpers 1.0... building... testing... ok.
Running files-package-contains-foo 1.0... building... testing... ok.
Running files-privacybreach 1.0... building... testing... ok.
Running files-python-modules 1.0... building... testing... ok.
Running files-special-file 1.0... building... testing... ok.
Running files-games-section 1.0... building... testing... ok.
Running files-symlinks 1.0... building... testing... ok.
Running files-uses-perl4-libs-with-dep 1.0... building... testing... ok.
Running files-tar-traps 1.0... building... testing... ok.
Running files-pkgconfig 1.0... building... testing... ok.
Running files-uses-perl4-libs-without-dep 1.0... building... testing... ok.
Running files-wrong-owner 1.0... building... testing... ok.
Running files-zero-byte-doc 1.0... building... testing... ok.
Running group-checks-file-conflict 1.0... building... testing... ok.
Running huge-usr-share-percent 1.0... building... testing... ok.
Running infofiles-general 1.0... building... testing... ok.
Running init.d-script-registration 1.0... building... testing... ok.
Running group-ch

[lintian] branch master updated (0b692ca -> f39fd61)

2015-08-16 Thread Axel Beckert

This is an automated email from the git hooks/post-receive script.

abe pushed a change to branch master
in repository lintian.

  from  0b692ca   Fix f/p in perl-module-name-not-mentioned-in-description 
(Closes: #795779)
   new  f39fd61   Rename application-in-library-section and 
library-package-name-for-application (+ should-not)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/application-not-library.desc  |  4 ++--
 checks/application-not-library.pm|  5 +++--
 data/override/renamed-tags   |  2 ++
 t/tests/application-not-library/desc |  2 +-
 t/tests/application-not-library/tags | 20 ++--
 5 files changed, 18 insertions(+), 15 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: Rename application-in-library-section and library-package-name-for-application (+ should-not)

2015-08-16 Thread Axel Beckert

This is an automated email from the git hooks/post-receive script.

abe pushed a commit to branch master
in repository lintian.

commit f39fd616a40b09bff8d254b0ac7258a8bcc0bb39
Author: Axel Beckert 
Date:   Sun Aug 16 22:43:41 2015 +0200

Rename application-in-library-section and 
library-package-name-for-application (+ should-not)

application-in-library-section   => 
application-should-not-be-in-library-section
library-package-name-for-application => 
application-should-not-have-library-package-name

Signed-off-by: Axel Beckert 
---
 checks/application-not-library.desc  |  4 ++--
 checks/application-not-library.pm|  5 +++--
 data/override/renamed-tags   |  2 ++
 t/tests/application-not-library/desc |  2 +-
 t/tests/application-not-library/tags | 20 ++--
 5 files changed, 18 insertions(+), 15 deletions(-)

diff --git a/checks/application-not-library.desc 
b/checks/application-not-library.desc
index a9c98c9..0b3516f 100644
--- a/checks/application-not-library.desc
+++ b/checks/application-not-library.desc
@@ -17,7 +17,7 @@ Info: This package contains a program in $PATH and is named
  package.
 Ref: http://pkg-perl.alioth.debian.org/policy.html#package_naming_policy
 
-Tag: library-package-name-for-application
+Tag: application-should-not-have-library-package-name
 Severity: normal
 Certainty: wild-guess
 Experimental: yes
@@ -33,7 +33,7 @@ Info: This package contains a program in $PATH but is named 
like a
  primarily a library, please add a lintian override for this tag.
 Ref: http://pkg-perl.alioth.debian.org/policy.html#package_naming_policy
 
-Tag: application-in-library-section
+Tag: application-should-not-be-in-library-section
 Severity: normal
 Certainty: wild-guess
 Experimental: yes
diff --git a/checks/application-not-library.pm 
b/checks/application-not-library.pm
index 7290e64..4223584 100644
--- a/checks/application-not-library.pm
+++ b/checks/application-not-library.pm
@@ -66,14 +66,15 @@ sub run {
 if ($pkg =~ /^libapp(?:.+)-perl$/) {
 tag 'libapp-perl-package-name', @programs;
 } else {
-tag 'library-package-name-for-application', @programs;
+tag 'application-should-not-have-library-package-name', @programs;
 }
 }
 
 # Check for wrong section
 my $section = $info->field('section', '');
 if ($section =~ /perl|python|ruby|(?:^|\/)libs/) { # oldlibs is ok
-tag 'application-in-library-section', "$section", @programs;
+tag 'application-should-not-be-in-library-section',
+  "$section", @programs;
 }
 
 return;
diff --git a/data/override/renamed-tags b/data/override/renamed-tags
index 7dab546..087c769 100644
--- a/data/override/renamed-tags
+++ b/data/override/renamed-tags
@@ -1,5 +1,7 @@
 # list of renamed tag old name => new name. Please alpha sort by old name
+application-in-library-section => application-should-not-be-in-library-section
 dep5-file-paragraph-reference-header-paragraph => 
dep5-file-paragraph-references-header-paragraph
+library-package-name-for-application => 
application-should-not-have-library-package-name
 package-install-apt-preferences => package-installs-apt-preferences
 package-install-apt-sources => package-installs-apt-sources
 package-install-ieee-data => package-installs-ieee-data
diff --git a/t/tests/application-not-library/desc 
b/t/tests/application-not-library/desc
index 265d09b..2d677b4 100644
--- a/t/tests/application-not-library/desc
+++ b/t/tests/application-not-library/desc
@@ -2,4 +2,4 @@ Testname: application-not-library
 Sequence: 6000
 Version: 1.0
 Description: Test cases where packages look like libraries but are applications
-Test-For: libapp-perl-package-name library-package-name-for-application 
application-in-library-section
+Test-For: libapp-perl-package-name 
application-should-not-have-library-package-name 
application-should-not-be-in-library-section
diff --git a/t/tests/application-not-library/tags 
b/t/tests/application-not-library/tags
index c3f3d96..7d4cb1d 100644
--- a/t/tests/application-not-library/tags
+++ b/t/tests/application-not-library/tags
@@ -1,11 +1,11 @@
 E: libapp-something-perl: libapp-perl-package-name 
usr/bin/libapp-something-perl
-X: libapp-something-perl: application-in-library-section perl 
usr/bin/libapp-something-perl
-X: libsomething-else-perl: application-in-library-section perl 
usr/bin/libsomething-else-perl
-X: libsomething-else-perl: library-package-name-for-application 
usr/bin/libsomething-else-perl
-X: python-something: application-in-library-section python 
usr/bin/python-something
-X: python-something: library-package-name-for-application 
usr/bin/python-something
-X: ruby-something: application-in-library-section ruby usr/bin/ruby-something
-X: ruby-something: library-package-name-for-application usr/bin/ruby-something
-X: unspecified-something-pl: application-in-library-section perl 
usr/bin/unspecified-something-pl
-X: unspecified-something-py:

[lintian] 01/01: Add another matching string for libidn

2015-08-16 Thread Raphael Geissert

This is an automated email from the git hooks/post-receive script.

geissert pushed a commit to branch master
in repository lintian.

commit f3e9990147fec541b63b2534c7bec7fc5e2922bf
Author: Raphael Geissert 
Date:   Mon Aug 17 00:06:57 2015 +0200

Add another matching string for libidn

Seen with Simon Josefsson, upstream and maintainer of libidn
---
 data/binaries/embedded-libs | 2 +-
 debian/changelog| 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/data/binaries/embedded-libs b/data/binaries/embedded-libs
index f10d0a1..0f979e2 100644
--- a/data/binaries/embedded-libs
+++ b/data/binaries/embedded-libs
@@ -58,7 +58,7 @@ libavformat ||source=libav||Format detected only with low 
score of %d, misdetect
 libavutil   ||source=libav||AVOption type %d of option %s not implemented yet\n
 libgd ||source-regex=libgd2? ||gd-(?:png|jpeg:) error:
 libgadu ||Gadu-Gadu Client Build
-libidn  ||(?m)^Punycode failed
+libidn  ||(?m)^(?:Punycode failed|ISCSIprep$)
 libidn2-0   ||punycode conversion resulted in overflow
 libjpeg   ||source-regex=libjpeg.* ||(?m)^Caution: quantization tables are too 
coarse for baseline JPEG
 libjsoncpp ||A valid JSON document must be either an array or an object value\.
diff --git a/debian/changelog b/debian/changelog
index daa4f0c..ef38953 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -16,6 +16,9 @@ lintian (2.5.37) UNRELEASED; urgency=medium
   * checks/fields.desc:
 + [JW] Use "an" (instead of "a") before "HTTP".
 
+  * data/binaries/embedded-libs:
++ [RG] Add another matching string for libidn
+
   * lib/Lintian/{Tags.pm,Tag/Override.pm}:
 + [BR] Support tag renaming. Warn about renamed
   tags.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Build failed in Jenkins: lintian-tests_sid #629

2015-08-16 Thread jenkins

See 

Changes:

[abe] Rename application-in-library-section and

--
Started by an SCM change
Building on master in workspace 

Wiping out workspace first.
Cloning the remote Git repository
Cloning repository git://anonscm.debian.org/lintian/lintian.git
 > git init  # timeout=10
Fetching upstream changes from git://anonscm.debian.org/lintian/lintian.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > git://anonscm.debian.org/lintian/lintian.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://anonscm.debian.org/lintian/lintian.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://anonscm.debian.org/lintian/lintian.git # 
 > timeout=10
Fetching upstream changes from git://anonscm.debian.org/lintian/lintian.git
 > git -c core.askpass=true fetch --tags --progress 
 > git://anonscm.debian.org/lintian/lintian.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision f39fd616a40b09bff8d254b0ac7258a8bcc0bb39 (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f f39fd616a40b09bff8d254b0ac7258a8bcc0bb39
 > git rev-list 0b692ca4ba7a9612e9fe05af5c3a1e0bf3fbdfb7 # timeout=10
 > git tag -a -f -m Jenkins Build #629 jenkins-lintian-tests_sid-629 # 
 > timeout=10
[workspace] $ /bin/sh -xe /tmp/hudson7772565321523815960.sh
+ /srv/jenkins/bin/chroot-run.sh sid timeout 6h debian/rules runtests


Sun 16 Aug 21:25:21 UTC 2015 - running job lintian-tests_sid now.

To understand what this job does, clone 
git.debian.org/git/qa/jenkins.debian.net.git
and then have a look at bin/chroot-run.sh

This invocation of the script has been called using "sid timeout 6h 
debian/rules runtests" as arguments.


Sun 16 Aug 21:25:21 UTC 2015 - start running "/srv/jenkins/bin/chroot-run.sh" 
(md5sum fdaebeaec949a431cfab5847bc4f09be) as "/tmp/jenkins-script-Fp4w9PfU".

Bootstraping sid into /chroots/chroot-run-sid.A0nfrbCyG now.
I: Retrieving Release 
I: Retrieving Release.gpg 
I: Checking Release signature
E: Invalid Release signature (key id 8B48AD6246925553)
debootstrap failed, slowing down, sleeping 1800 now...
Sun 16 Aug 22:10:21 UTC 2015 - /srv/jenkins/bin/chroot-run.sh stopped running 
as /tmp/jenkins-script-Fp4w9PfU, which will now be removed.
Build step 'Execute shell' marked build as failure

[lintian] branch master updated (f39fd61 -> f3e9990)

2015-08-16 Thread Raphael Geissert

This is an automated email from the git hooks/post-receive script.

geissert pushed a change to branch master
in repository lintian.

  from  f39fd61   Rename application-in-library-section and 
library-package-name-for-application (+ should-not)
   new  f3e9990   Add another matching string for libidn

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 data/binaries/embedded-libs | 2 +-
 debian/changelog| 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Build failed in Jenkins: lintian-tests_sid #630

2015-08-16 Thread jenkins

See 

Changes:

[geissert] Add another matching string for libidn

--
[...truncated 4744 lines...]
Running fields-essential 1.0... building... testing... ok.
Running fields-indep-without-arch-indep 1.0... building... testing... ok.
Running fields-maintainer 1.0... building... testing... ok.
Running fields-maintainer-general 1.0... building... testing... ok.
Running fields-maintainer-bounces 1.0... building... testing... ok.
Running fields-duplicate-build 1.0... building... testing... ok.
Running fields-java 1.0... building... testing... ok.
Running fields-module-build-perl 1.0... building... testing... ok.
Running fields-dmua 1.0... building... testing... ok.
Running fields-malformed-vcs-fields 1.0... building... testing... ok.
Running fields-multi-arch 1.0... building... testing... ok.
Running fields-multiple-x-deps 1.0... building... testing... ok.
Running fields-no-homepage 1.0-1... building... testing... ok.
Running fields-no-human-maintainer 1.0... building... testing... ok.
Running fields-doc-pkg-wrong-arch 1.0... building... testing... ok.
Running fields-qa-maint-address 1.0... building... testing... ok.
Running fields-no-source-homepage 1.0-1... building... testing... ok.
Running fields-not-malformed-vcs-fields 1.0... building... testing... ok.
Running fields-qa-maint-name 1.0... building... testing... ok.
Running fields-perl-provides 0.26... building... testing... ok.
Running fields-redundant 1.0... building... testing... ok.
Running fields-root-maint-address 1.0... building... testing... ok.
Running fields-udeb 1.0... building... testing... ok.
Running fields-unknown-fields 1.0... building... testing... ok.
Running fields-transitional 1.0... building... testing... ok.
Running fields-uncanonical-vcs-fields 1.0... building... testing... ok.
Running description-general 1.0... building... testing... ok.
Running fields-malformed-py-version 1.0... building... testing... ok.
Running fields-vcs-fields 1.0... building... testing... ok.
Running fields-uploaders 1.0... building... testing... ok.
Running fields-version-dfsg-native 1.0.dfsg1... building... testing... ok.
Running fields-section-general 1.0... building... testing... ok.
Running fields-version-bad 0-.3... building... testing... ok.
Running fields-version-bad-rc 1.0+rc3-1... building... testing... ok.
Running fields-version-dot-dfsg 1.0.dfsg1-1... building... testing... ok.
Running fields-version-dsfg 1.0+dsfg1-1... building... testing... ok.
Running filename-length-really-really-really-really-long-package-name 
1.0.and.a.really.long.version.too-1... building... testing... ok.
Running files-adobe-font 1.0... building... testing... ok.
Running files-embedded 1.0... building... testing... ok.
Running files-doxygen-documentation 1.0... building... testing... ok.
Running files-extra-license 1.0... building... testing... ok.
Running files-empty 1.0... building... testing... ok.
Running files-gzip-ma-same 1.0... building... testing... ok.
Running files-flash-non-free 1.0... building... testing... ok.
Running files-override-misplaced 1.0... building... testing... ok.
Running files-arch-indep-not-marked-all 1.0... building... testing... ok.
Running files-locales 1.0... building... testing... ok.
Running files-fonts 1.0... building... testing... ok.
Running files-foo-in-bar 1.0... building... testing... ok.
Running fields-virtual-packages 1.0... building... testing... ok.
Running files-package-contains-foo 1.0... building... testing... ok.
Running files-general 1.0... building... testing... ok.
Running files-foo-violates-expected-naming 1.0... building... testing... ok.
Running files-bad-perm-owner 1.0... building... testing... ok.
Running files-privacybreach 1.0... building... testing... ok.
Running files-games-section 1.0... building... testing... ok.
Running files-hardlinks 1.0... building... testing... ok.
Running files-python-modules 1.0... building... testing... ok.
Running files-gzip 1.0-1... building... testing... ok.
Running files-pkgconfig 1.0... building... testing... ok.
Running files-special-file 1.0... building... testing... ok.
Running files-python-helpers 1.0... building... testing... ok.
Running files-tar-traps 1.0... building... testing... ok.
Running files-ieee-data 1.0... building... testing... ok.
Running files-uses-perl4-libs-without-dep 1.0... building... testing... ok.
Running files-uses-perl4-libs-with-dep 1.0... building... testing... ok.
Running files-wrong-owner 1.0... building... testing... ok.
Running files-symlinks 1.0... building... testing... ok.
Running files-zero-byte-doc 1.0... building... testing... ok.
Running group-checks-file-conflict 1.0... building... testing... ok.
Running huge-usr-share-percent 1.0... building... testing... ok.
Running group-checks-wrong-priorities 1.0... building... testing... ok.
Running infofiles-general 1.0... building... testing... ok.
Running group-checks-multi-arch 1.0... building... test

[lintian] 01/01: Fix FTBFS in perlcritic runner with Test::Perl::Critic 1.03

2015-08-16 Thread Axel Beckert

This is an automated email from the git hooks/post-receive script.

abe pushed a commit to branch master
in repository lintian.

commit a5baafce0757b846a344c08736d95f7b7da75ac3
Author: Axel Beckert 
Date:   Mon Aug 17 02:06:41 2015 +0200

Fix FTBFS in perlcritic runner with Test::Perl::Critic 1.03
---
 debian/changelog  |  3 +++
 t/scripts/01-critic/runner.pl | 20 +++-
 2 files changed, 6 insertions(+), 17 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index ef38953..47b7c16 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -23,6 +23,9 @@ lintian (2.5.37) UNRELEASED; urgency=medium
 + [BR] Support tag renaming. Warn about renamed
   tags.
 
+  * t/scripts/01-critic/runner.pl:
++ [AB] Fix FTBFS in perlcritic runner with Test::Perl::Critic 1.03
+
  -- Bastien Roucariès   Sat, 15 Aug 2015 
23:49:50 +0200
 
 lintian (2.5.36.1) unstable; urgency=medium
diff --git a/t/scripts/01-critic/runner.pl b/t/scripts/01-critic/runner.pl
index 86f2c26..15f1295 100755
--- a/t/scripts/01-critic/runner.pl
+++ b/t/scripts/01-critic/runner.pl
@@ -42,23 +42,9 @@ exit(0);
 
 sub run_critic {
 my (@args) = @_;
-plan tests => scalar(@args);
-for my $arg (@args) {
-if (-d $arg) {
-
-# all_critic_ok emits its own plan, so run it in a subtest
-# so we can just count it as "one" test.
-subtest "Critic all code in $arg" => sub {
-all_critic_ok($arg);
-};
-}elsif (-f _ ) {
-critic_ok($arg);
-}else {
-print STDERR "N: $arg\n";
-die "$arg does not exists\n" if not -e _;
-die "$arg is of an unsupported file type\n";
-}
-}
+
+all_critic_ok(@args);
+
 # For some reason, perltidy has started to leave behind a
 # "perltidy.LOG" which is rather annoying.  Lets have the tests
 # unconditionally kill those.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (f3e9990 -> a5baafc)

2015-08-16 Thread Axel Beckert

This is an automated email from the git hooks/post-receive script.

abe pushed a change to branch master
in repository lintian.

  from  f3e9990   Add another matching string for libidn
   new  a5baafc   Fix FTBFS in perlcritic runner with Test::Perl::Critic 
1.03

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 debian/changelog  |  3 +++
 t/scripts/01-critic/runner.pl | 20 +++-
 2 files changed, 6 insertions(+), 17 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Jenkins build is back to normal : lintian-tests_sid #631

2015-08-16 Thread jenkins

See

Bug#795641: Reworked patch

2015-08-16 Thread Rafael Kitover

I have removed all file IO by opening a scalar ref to the in-memory file 
instead.

I am using Data::Alias to avoid copying texts in memory (dep added.)

Code has been simplified and allows passing a qr// or a sub{} .




0001-fix-common-lic.-false-pos.-in-new-style-copyright.patch
Description: Binary data

41 matches

Mail list logo