[lintian] branch master updated (7ea5b28 -> 5fe6061)
This is an automated email from the git hooks/post-receive script. jwilk pushed a change to branch master in repository lintian. from 7ea5b28 c/application-not-library: Fix typo new 5fe6061 c/po-debconf: Fix typo The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/po-debconf.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: c/po-debconf: Fix typo
This is an automated email from the git hooks/post-receive script. jwilk pushed a commit to branch master in repository lintian. commit 5fe606119b907fb4119bf98c0baded94ee9d1255 Author: Jakub Wilk Date: Mon Sep 14 22:26:53 2015 +0200 c/po-debconf: Fix typo --- checks/po-debconf.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checks/po-debconf.pm b/checks/po-debconf.pm index 262a69e..179938f 100644 --- a/checks/po-debconf.pm +++ b/checks/po-debconf.pm @@ -45,7 +45,7 @@ sub run { $potfiles_in_path = $debian_po_dir->resolve_path('POTFILES.in'); } -# First, check wether this package seems to use debconf but not +# First, check whether this package seems to use debconf but not # po-debconf. Read the templates file and look at the template # names it provides, since some shared templates aren't # translated. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[PATCH] c/po-debconf: Fix typo
--- checks/po-debconf.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checks/po-debconf.pm b/checks/po-debconf.pm index 262a69e..179938f 100644 --- a/checks/po-debconf.pm +++ b/checks/po-debconf.pm @@ -45,7 +45,7 @@ sub run { $potfiles_in_path = $debian_po_dir->resolve_path('POTFILES.in'); } -# First, check wether this package seems to use debconf but not +# First, check whether this package seems to use debconf but not # po-debconf. Read the templates file and look at the template # names it provides, since some shared templates aren't # translated. -- 2.5.1
Bug#798900: lintian: false positive: source-is-missing for non-minified JS files
Hi, good question… One might think of whitespace-to-filesize ratio? With indentation and line breaks human-readable code is expected to have vastly a different ratio than a minified version. Example for jQuery: $ ruby -e 'puts (f=ARGF.read).scan(/\s/).size/f.size.to_f' < jquery-2.1.4.js 0.24018465490292693 $ ruby -e 'puts (f=ARGF.read).scan(/\s/).size/f.size.to_f' < jquery-2.1.4.min.js 0.015472167881913568 The non-minified version is 1/4 whitespace! In contrast, the minifies version has just 1.5%. It’s difficult… if you have a JS parser ready you can also compute the ratio of one-letter variables/functions vs. total number. These will be off by a lot as well. Cheers Sascha > On 14 Sep 2015, at 19:55, Bastien ROUCARIES > wrote: > > On Mon, Sep 14, 2015 at 6:58 PM, Mattia Rizzolo wrote: >> control: affects -1 inkscape >> >> On Sun, Sep 13, 2015 at 09:46:37PM +, Sascha Steinbiss wrote: >>> I noticed today that there were two new Lintian errors on DDPO for my >>> 'aegean' >>> package >>> (https://lintian.debian.org/maintainer/sas...@steinbiss.name.html#aegean). >>> These seem to be fairly recent, and I took a look to see what could be >>> wrong. >>> >>> Looks like the JQuery DataTables libraries included are flagged as minified >>> without source on the basis that they have lines longer than 1024 >>> characters: >>> $ lintian -V >>> Lintian v2.5.37 >>> $ lintian --info --display-info --display-experimental --pedantic >>> --show-overrides aegean_0.13.0+dfsg-1.dsc >>> P: aegean source: source-contains-prebuilt-javascript-object >>> data/share/vendor/jquery.dataTables.js line length is 1397 characters >>> (>1024) >>> [...] >>> E: aegean source: source-is-missing data/share/vendor/jquery.dataTables.js >>> [...] >>> >>> But this file is not minified, it's there as full source code -- there is >>> only one >>> line (l.24) which is quite long (>1300 chars). I think this is a false >>> positive >>> (that has been recently introduced?) and looking at the line length alone is >>> probably not sufficient to reliably identify minified JS. >>> Any comments? >> >> Same thing for inkscape, though my line is 266 characters (>256) (I >> argue 256 is a really low number for such a check, and I wonder why >> Sascha report says another number). > > It is really over 80 cols. Do you have other idea in order to check ? > Maybe entropy of the line but I do not know how to compute it in > javascript, and where to put the level > > Bastien > >> -- >> regards, >>Mattia Rizzolo >> >> GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. >> more about me: http://mapreri.org : :' : >> Launchpad user: https://launchpad.net/~mapreri `. `'` >> Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Bug#798900: lintian: false positive: source-is-missing for non-minified JS files
On Mon, Sep 14, 2015 at 6:58 PM, Mattia Rizzolo wrote: > control: affects -1 inkscape > > On Sun, Sep 13, 2015 at 09:46:37PM +, Sascha Steinbiss wrote: >> I noticed today that there were two new Lintian errors on DDPO for my >> 'aegean' >> package >> (https://lintian.debian.org/maintainer/sas...@steinbiss.name.html#aegean). >> These seem to be fairly recent, and I took a look to see what could be wrong. >> >> Looks like the JQuery DataTables libraries included are flagged as minified >> without source on the basis that they have lines longer than 1024 characters: >> $ lintian -V >> Lintian v2.5.37 >> $ lintian --info --display-info --display-experimental --pedantic >> --show-overrides aegean_0.13.0+dfsg-1.dsc >> P: aegean source: source-contains-prebuilt-javascript-object >> data/share/vendor/jquery.dataTables.js line length is 1397 characters (>1024) >> [...] >> E: aegean source: source-is-missing data/share/vendor/jquery.dataTables.js >> [...] >> >> But this file is not minified, it's there as full source code -- there is >> only one >> line (l.24) which is quite long (>1300 chars). I think this is a false >> positive >> (that has been recently introduced?) and looking at the line length alone is >> probably not sufficient to reliably identify minified JS. >> Any comments? > > Same thing for inkscape, though my line is 266 characters (>256) (I > argue 256 is a really low number for such a check, and I wonder why > Sascha report says another number). It is really over 80 cols. Do you have other idea in order to check ? Maybe entropy of the line but I do not know how to compute it in javascript, and where to put the level Bastien > -- > regards, > Mattia Rizzolo > > GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. > more about me: http://mapreri.org : :' : > Launchpad user: https://launchpad.net/~mapreri `. `'` > Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Bug#798983: lintian: please check for libjs-* binary package name outside of web section
Package: lintian Version: 2.5.37 Severity: wishlist -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Please have lintian check for libjs-* binary package name outside of web section. I am getting tired of filing bugreports against esp. Ruby packagers properly separating javascript into reusable packages but forgetting to change section for that binary package. Obviously similar applies for other patterns, like these: *-doc *-example *-examples outside of doc section fonts-* outside of fonts section !py-* in python section - Jonas -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQIcBAEBAgAGBQJV9wUCAAoJECx8MUbBoAEhU4wP/jZK8t9doJ1T5ep3TCtCpmHr +xyon6TjLuOcs/q6k3lKe8fFfm0X/QC40kfvrL/dh2zB3TLuQtlB+6AhQVMiNTHC lMPW5LZKFyu8slJz9D8jjXomJwywefixrR5AZUufAeJ6+mUke+Ob/6xN2t8ZP5y3 vmK5cnyRNUit3RmJe1Z7PzLUm4kPsFc7xOS6ZkQKHgG6Ty/xxJxPNZD5fTOgqo3u yJieKtOpCtGm8xuAcCS5UonnTpAQ7pSX3X4wxij1mb/A2oEXuDOCip62bFiovCeX EQ5dm8UCkmlPF570SdHMFukeFj7cvUjeHz5qHbBKgHQIqxUIOk8u/4ezccRnOkGI ED7R9p7Y75vGyn34tM4pOQoXMN8H4Q2p7DIiGydTP7+DsqggOibI2+L9SQGFxKFk 9VXNpaaXpEwZHmdIpBf+84OlbYPcAws3YZ07fz0t2hX63aEj1M5c2JzoZ/PMVlv1 7hXvEtAcx3cwmsv14dqpkXGnuKexZ0GWyavqCR0ycGi/dsCDz8dKRLOJ/0HIXsb6 F383OLseab8QuC0G4iKscE3QQF/Rgo9Y8PPkSFzeKYrSslmKpZhYolEBsy67a1TZ mTERBKLqzGlL0LfJ6feojnVPe+MSHGmBhgyYb58fsj8Mpxu1tKdtTMSYQd5uOn// 7uxKp5Hf324H1gFfyDcm =spzN -END PGP SIGNATURE-
Bug#798900: lintian: false positive: source-is-missing for non-minified JS files
control: affects -1 inkscape On Sun, Sep 13, 2015 at 09:46:37PM +, Sascha Steinbiss wrote: > I noticed today that there were two new Lintian errors on DDPO for my 'aegean' > package > (https://lintian.debian.org/maintainer/sas...@steinbiss.name.html#aegean). > These seem to be fairly recent, and I took a look to see what could be wrong. > > Looks like the JQuery DataTables libraries included are flagged as minified > without source on the basis that they have lines longer than 1024 characters: > $ lintian -V > Lintian v2.5.37 > $ lintian --info --display-info --display-experimental --pedantic > --show-overrides aegean_0.13.0+dfsg-1.dsc > P: aegean source: source-contains-prebuilt-javascript-object > data/share/vendor/jquery.dataTables.js line length is 1397 characters (>1024) > [...] > E: aegean source: source-is-missing data/share/vendor/jquery.dataTables.js > [...] > > But this file is not minified, it's there as full source code -- there is > only one > line (l.24) which is quite long (>1300 chars). I think this is a false > positive > (that has been recently introduced?) and looking at the line length alone is > probably not sufficient to reliably identify minified JS. > Any comments? Same thing for inkscape, though my line is 266 characters (>256) (I argue 256 is a really low number for such a check, and I wonder why Sascha report says another number). -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: http://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: Digital signature
Processed: Re: Bug#798900: lintian: false positive: source-is-missing for non-minified JS files
Processing control commands: > affects -1 inkscape Bug #798900 [lintian] lintian: false positive: source-is-missing for non-minified JS files Added indication that 798900 affects inkscape -- 798900: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=798900 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems