[lintian] branch master updated (6458f8a -> 1cee79c)

2017-10-08 Thread Niels Thykier
This is an automated email from the git hooks/post-receive script.

nthykier pushed a change to branch master
in repository lintian.

  from  6458f8a   d/changelog: Add missing space
   new  1cee79c   Correct d/changelog + lintian.xml to use $XDG_DATA_HOME

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 debian/changelog | 4 ++--
 doc/lintian.xml  | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



Processed: tagging 839124

2017-10-08 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> tags 839124 + help
Bug #839124 [lintian] lintian: please add some helpful advice how to fix 
tags/dbus-policy-at-console
Added tag(s) help.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
839124: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=839124
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Build failed in Jenkins: lintian-tests_sid #1995

2017-10-08 Thread jenkins
See 


Changes:

[niels] Restore /home/moon/.lintian as profile/data root dir

[niels] lintian.xml: Mention XDG_CONFIG_HOME/lintian/ next to

--
[...truncated 239.01 KB...]
Adding debian:Deutsche_Telekom_Root_CA_2.pem
Adding debian:DST_Root_CA_X3.pem
Adding debian:DST_ACES_CA_X6.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_EV_2009.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_2009.pem
Adding debian:Cybertrust_Global_Root.pem
Adding debian:Comodo_Trusted_Services_root.pem
Adding debian:Comodo_Secure_Services_root.pem
Adding debian:Comodo_AAA_Services_root.pem
Adding debian:China_Internet_Network_Information_Center_EV_Certificates_Root.pem
Adding debian:Chambers_of_Commerce_Root_-_2008.pem
Adding debian:Certum_Trusted_Network_CA_2.pem
Adding debian:Certum_Trusted_Network_CA.pem
Adding debian:Certum_Root_CA.pem
Adding debian:Certplus_Root_CA_G2.pem
Adding debian:Certplus_Root_CA_G1.pem
Adding debian:Certplus_Class_2_Primary_CA.pem
Adding debian:Certinomis_-_Root_CA.pem
Warning: there was a problem reading the certificate file 
/etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem. Message:
  /etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem (No such file or directory)
Adding debian:Certigna.pem
Adding debian:Camerfirma_Global_Chambersign_Root.pem
Adding debian:Camerfirma_Chambers_of_Commerce_Root.pem
Adding debian:COMODO_RSA_Certification_Authority.pem
Adding debian:COMODO_ECC_Certification_Authority.pem
Adding debian:COMODO_Certification_Authority.pem
Adding debian:CNNIC_ROOT.pem
Adding debian:CFCA_EV_ROOT.pem
Adding debian:CA_Disig_Root_R2.pem
Adding debian:CA_Disig_Root_R1.pem
Adding debian:Buypass_Class_3_Root_CA.pem
Adding debian:Buypass_Class_2_Root_CA.pem
Adding debian:Baltimore_CyberTrust_Root.pem
Adding debian:Autoridad_de_Certificacion_Firmaprofesional_CIF_A62634068.pem
Adding debian:Atos_TrustedRoot_2011.pem
Adding debian:Amazon_Root_CA_4.pem
Adding debian:Amazon_Root_CA_3.pem
Adding debian:Amazon_Root_CA_2.pem
Adding debian:Amazon_Root_CA_1.pem
Adding debian:AffirmTrust_Premium_ECC.pem
Adding debian:AffirmTrust_Premium.pem
Adding debian:AffirmTrust_Networking.pem
Adding debian:AffirmTrust_Commercial.pem
Adding debian:AddTrust_Qualified_Certificates_Root.pem
Adding debian:AddTrust_Public_Services_Root.pem
Adding debian:AddTrust_Low-Value_Services_Root.pem
Adding debian:AddTrust_External_Root.pem
Adding debian:Actalis_Authentication_Root_CA.pem
Adding debian:AC_RAIZ_FNMT-RCM.pem
Adding debian:ACEDICOM_Root.pem
Adding debian:ACCVRAIZ1.pem
done.
Setting up openjdk-8-jdk-headless:amd64 (8u144-b01-2) ...
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/idlj to 
provide /usr/bin/idlj (idlj) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jdeps to 
provide /usr/bin/jdeps (jdeps) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/wsimport to 
provide /usr/bin/wsimport (wsimport) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/rmic to 
provide /usr/bin/rmic (rmic) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jinfo to 
provide /usr/bin/jinfo (jinfo) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jsadebugd to 
provide /usr/bin/jsadebugd (jsadebugd) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/native2ascii 
to provide /usr/bin/native2ascii (native2ascii) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstat to 
provide /usr/bin/jstat (jstat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javac to 
provide /usr/bin/javac (javac) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javah to 
provide /usr/bin/javah (javah) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstack to 
provide /usr/bin/jstack (jstack) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jrunscript to 
provide /usr/bin/jrunscript (jrunscript) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javadoc to 
provide /usr/bin/javadoc (javadoc) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jhat to 
provide /usr/bin/jhat (jhat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javap to 
provide /usr/bin/javap (javap) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jar to provide 
/usr/bin/jar (jar) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/xjc to provide 
/usr/bin/xjc (xjc) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/schemagen to 
provide /usr/bin/schemagen (schemagen) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jps to provide 
/usr/bin/jps (jps) in auto mode
update-alternatives:

[lintian] 01/01: dplint: Correct order of @RESTRICTED_INCLUDE_DIRS

2017-10-08 Thread Niels Thykier
This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 483b31108ecceb090d1ce429c6a5fe2ab0630691
Author: Niels Thykier 
Date:   Sun Oct 8 07:08:17 2017 +

dplint: Correct order of @RESTRICTED_INCLUDE_DIRS

Signed-off-by: Niels Thykier 
---
 debian/changelog | 3 +++
 frontend/dplint  | 6 +++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index f1e8183..1ff55b7 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -64,6 +64,9 @@ lintian (2.5.55) UNRELEASED; urgency=medium
   user profiles and data files.  It was advertised as such in the
   documentation but the code actually only used the XDG_DATA_HOME
   path.  Thanks to Daniel Kauffman for the report.  (Closes: #875636)
++ [NT] Correct the order of restricted search paths (user directories
+  and /etc/lintian).  It incorrectly used /etc/lintian before the
+  user directory.
 
   * lib/Lintian/Util.pm:
 + [NT] Rename the "fail" subroutine to "internal_error" to better
diff --git a/frontend/dplint b/frontend/dplint
index 988c32b..e36281f 100755
--- a/frontend/dplint
+++ b/frontend/dplint
@@ -138,11 +138,11 @@ sub setup_env {
 my $cwd = getcwd();
 $data_home = "${cwd}/${data_home}";
 }
-unshift(@RESTRICTED_INCLUDE_DIRS, $data_home)
+push(@RESTRICTED_INCLUDE_DIRS, $data_home)
   if defined($data_home) && -d $data_home;
-unshift(@RESTRICTED_INCLUDE_DIRS, $legacy_user_data)
+push(@RESTRICTED_INCLUDE_DIRS, $legacy_user_data)
 if defined($legacy_user_data) && -d $legacy_user_data;
-unshift(@RESTRICTED_INCLUDE_DIRS, '/etc/lintian')
+push(@RESTRICTED_INCLUDE_DIRS, '/etc/lintian')
   if -d '/etc/lintian';
 }
 

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: dplint: Fix perltidy issue

2017-10-08 Thread Niels Thykier
This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit a551be33949ecd576e9a44a4bfe0ecc8ed99055b
Author: Niels Thykier 
Date:   Sun Oct 8 07:12:18 2017 +

dplint: Fix perltidy issue

Signed-off-by: Niels Thykier 
---
 frontend/dplint | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/frontend/dplint b/frontend/dplint
index e36281f..f3c799e 100755
--- a/frontend/dplint
+++ b/frontend/dplint
@@ -130,7 +130,7 @@ sub setup_env {
 $data_home = data_home('lintian');
 }
 if (exists($ENV{'HOME'})) {
-$legacy_user_data = "$ENV{HOME}/.lintian"
+$legacy_user_data = "$ENV{HOME}/.lintian";
 }
 if (defined($data_home) and $data_home !~ m@^/@) {
 # Turn the path into an absolute one.  Just in case
@@ -141,7 +141,7 @@ sub setup_env {
 push(@RESTRICTED_INCLUDE_DIRS, $data_home)
   if defined($data_home) && -d $data_home;
 push(@RESTRICTED_INCLUDE_DIRS, $legacy_user_data)
-if defined($legacy_user_data) && -d $legacy_user_data;
+  if defined($legacy_user_data) && -d $legacy_user_data;
 push(@RESTRICTED_INCLUDE_DIRS, '/etc/lintian')
   if -d '/etc/lintian';
 }

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



Processed: Re: lintian ignores profiles under $HOME

2017-10-08 Thread Debian Bug Tracking System
Processing control commands:

> tags -1 confirmed pending
Bug #875636 [lintian] lintian ignores profiles under $HOME
Added tag(s) confirmed.

-- 
875636: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=875636
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#875636: lintian ignores profiles under $HOME

2017-10-08 Thread Niels Thykier
Control: tags -1 confirmed pending

On Tue, 12 Sep 2017 13:32:05 -0700 Daniel Kauffman
 wrote:
> Package: lintian
> Version: 2.5.50.4
> Severity: important
> 
> lintian ignores profiles under $HOME.  Previous versions of lintian 
> recognized profiles under $HOME.  I'm not sure exactly when the 
> regression happened.  At least some version of lintian in Jessie worked.
> 
> The order in which lintian searches for profiles is documented at 
> https://lintian.debian.org/manual/section-2.5.html in section 2.5.1.  
> But in my case the search seems to be skipping $HOME.
> 
> Here is a transcript showing the issue:
> 
> [...]

Hi,


 * The code supports "$XDG_CONFIG_HOME/lintian/profiles" (defaults to
   $HOME/.local/share/lintian/profiles), which can be used as a work
   around.

 * This was not documented but will be in 2.5.55.

 * I have re-added support for $HOME/.lintian, which will also land
   in 2.5.55.

Thanks,
~Niels



Build failed in Jenkins: lintian-tests_sid #1996

2017-10-08 Thread jenkins
See 


Changes:

[niels] d/changelog: Add missing space

[niels] Correct d/changelog + lintian.xml to use $XDG_DATA_HOME

--
[...truncated 238.56 KB...]
Adding debian:EC-ACC.pem
Adding debian:E-Tugra_Certification_Authority.pem
Adding debian:DigiCert_Trusted_Root_G4.pem
Adding debian:DigiCert_High_Assurance_EV_Root_CA.pem
Adding debian:DigiCert_Global_Root_G3.pem
Adding debian:DigiCert_Global_Root_G2.pem
Adding debian:DigiCert_Global_Root_CA.pem
Adding debian:DigiCert_Assured_ID_Root_G3.pem
Adding debian:DigiCert_Assured_ID_Root_G2.pem
Adding debian:DigiCert_Assured_ID_Root_CA.pem
Adding debian:Deutsche_Telekom_Root_CA_2.pem
Adding debian:DST_Root_CA_X3.pem
Adding debian:DST_ACES_CA_X6.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_EV_2009.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_2009.pem
Adding debian:Cybertrust_Global_Root.pem
Adding debian:Comodo_Trusted_Services_root.pem
Adding debian:Comodo_Secure_Services_root.pem
Adding debian:Comodo_AAA_Services_root.pem
Adding debian:China_Internet_Network_Information_Center_EV_Certificates_Root.pem
Adding debian:Chambers_of_Commerce_Root_-_2008.pem
Adding debian:Certum_Trusted_Network_CA_2.pem
Adding debian:Certum_Trusted_Network_CA.pem
Adding debian:Certum_Root_CA.pem
Adding debian:Certplus_Root_CA_G2.pem
Adding debian:Certplus_Root_CA_G1.pem
Adding debian:Certplus_Class_2_Primary_CA.pem
Adding debian:Certinomis_-_Root_CA.pem
Warning: there was a problem reading the certificate file 
/etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem. Message:
  /etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem (No such file or directory)
Adding debian:Certigna.pem
Adding debian:Camerfirma_Global_Chambersign_Root.pem
Adding debian:Camerfirma_Chambers_of_Commerce_Root.pem
Adding debian:COMODO_RSA_Certification_Authority.pem
Adding debian:COMODO_ECC_Certification_Authority.pem
Adding debian:COMODO_Certification_Authority.pem
Adding debian:CNNIC_ROOT.pem
Adding debian:CFCA_EV_ROOT.pem
Adding debian:CA_Disig_Root_R2.pem
Adding debian:CA_Disig_Root_R1.pem
Adding debian:Buypass_Class_3_Root_CA.pem
Adding debian:Buypass_Class_2_Root_CA.pem
Adding debian:Baltimore_CyberTrust_Root.pem
Adding debian:Autoridad_de_Certificacion_Firmaprofesional_CIF_A62634068.pem
Adding debian:Atos_TrustedRoot_2011.pem
Adding debian:Amazon_Root_CA_4.pem
Adding debian:Amazon_Root_CA_3.pem
Adding debian:Amazon_Root_CA_2.pem
Adding debian:Amazon_Root_CA_1.pem
Adding debian:AffirmTrust_Premium_ECC.pem
Adding debian:AffirmTrust_Premium.pem
Adding debian:AffirmTrust_Networking.pem
Adding debian:AffirmTrust_Commercial.pem
Adding debian:AddTrust_Qualified_Certificates_Root.pem
Adding debian:AddTrust_Public_Services_Root.pem
Adding debian:AddTrust_Low-Value_Services_Root.pem
Adding debian:AddTrust_External_Root.pem
Adding debian:Actalis_Authentication_Root_CA.pem
Adding debian:AC_RAIZ_FNMT-RCM.pem
Adding debian:ACEDICOM_Root.pem
Adding debian:ACCVRAIZ1.pem
done.
Setting up openjdk-8-jdk-headless:amd64 (8u144-b01-2) ...
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/idlj to 
provide /usr/bin/idlj (idlj) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jdeps to 
provide /usr/bin/jdeps (jdeps) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/wsimport to 
provide /usr/bin/wsimport (wsimport) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/rmic to 
provide /usr/bin/rmic (rmic) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jinfo to 
provide /usr/bin/jinfo (jinfo) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jsadebugd to 
provide /usr/bin/jsadebugd (jsadebugd) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/native2ascii 
to provide /usr/bin/native2ascii (native2ascii) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstat to 
provide /usr/bin/jstat (jstat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javac to 
provide /usr/bin/javac (javac) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javah to 
provide /usr/bin/javah (javah) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstack to 
provide /usr/bin/jstack (jstack) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jrunscript to 
provide /usr/bin/jrunscript (jrunscript) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javadoc to 
provide /usr/bin/javadoc (javadoc) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jhat to 
provide /usr/bin/jhat (jhat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javap to 
provide /usr/bin/javap (javap) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jar to pro

[lintian] branch master updated (1cee79c -> 483b311)

2017-10-08 Thread Niels Thykier
This is an automated email from the git hooks/post-receive script.

nthykier pushed a change to branch master
in repository lintian.

  from  1cee79c   Correct d/changelog + lintian.xml to use $XDG_DATA_HOME
   new  483b311   dplint: Correct order of @RESTRICTED_INCLUDE_DIRS

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 debian/changelog | 3 +++
 frontend/dplint  | 6 +++---
 2 files changed, 6 insertions(+), 3 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: t: Fix syntax error in desc file

2017-10-08 Thread Niels Thykier
This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 0973c21a1e262d1ca7f202f4682d67c33ed591c5
Author: Niels Thykier 
Date:   Sun Oct 8 07:28:14 2017 +

t: Fix syntax error in desc file

Signed-off-by: Niels Thykier 
---
 t/tests/binaries-from-other-arch/desc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/t/tests/binaries-from-other-arch/desc 
b/t/tests/binaries-from-other-arch/desc
index a26bf83..9d9b68e 100644
--- a/t/tests/binaries-from-other-arch/desc
+++ b/t/tests/binaries-from-other-arch/desc
@@ -1,8 +1,7 @@
 Testname: binaries-from-other-arch
-Architecture: any
+Architecture: amd64 i386
 Version: 1.0
 Description: Test package with a pseudo binary from a different architecture
-Architecture: amd64 i386
 Test-For:
  apparently-corrupted-elf-binary
  binary-from-other-architecture

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch master updated (483b311 -> a551be3)

2017-10-08 Thread Niels Thykier
This is an automated email from the git hooks/post-receive script.

nthykier pushed a change to branch master
in repository lintian.

  from  483b311   dplint: Correct order of @RESTRICTED_INCLUDE_DIRS
   new  a551be3   dplint: Fix perltidy issue

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 frontend/dplint | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



Build failed in Jenkins: lintian-tests_sid #1997

2017-10-08 Thread jenkins
See 

--
[...truncated 238.56 KB...]
Adding debian:EC-ACC.pem
Adding debian:E-Tugra_Certification_Authority.pem
Adding debian:DigiCert_Trusted_Root_G4.pem
Adding debian:DigiCert_High_Assurance_EV_Root_CA.pem
Adding debian:DigiCert_Global_Root_G3.pem
Adding debian:DigiCert_Global_Root_G2.pem
Adding debian:DigiCert_Global_Root_CA.pem
Adding debian:DigiCert_Assured_ID_Root_G3.pem
Adding debian:DigiCert_Assured_ID_Root_G2.pem
Adding debian:DigiCert_Assured_ID_Root_CA.pem
Adding debian:Deutsche_Telekom_Root_CA_2.pem
Adding debian:DST_Root_CA_X3.pem
Adding debian:DST_ACES_CA_X6.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_EV_2009.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_2009.pem
Adding debian:Cybertrust_Global_Root.pem
Adding debian:Comodo_Trusted_Services_root.pem
Adding debian:Comodo_Secure_Services_root.pem
Adding debian:Comodo_AAA_Services_root.pem
Adding debian:China_Internet_Network_Information_Center_EV_Certificates_Root.pem
Adding debian:Chambers_of_Commerce_Root_-_2008.pem
Adding debian:Certum_Trusted_Network_CA_2.pem
Adding debian:Certum_Trusted_Network_CA.pem
Adding debian:Certum_Root_CA.pem
Adding debian:Certplus_Root_CA_G2.pem
Adding debian:Certplus_Root_CA_G1.pem
Adding debian:Certplus_Class_2_Primary_CA.pem
Adding debian:Certinomis_-_Root_CA.pem
Warning: there was a problem reading the certificate file 
/etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem. Message:
  /etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem (No such file or directory)
Adding debian:Certigna.pem
Adding debian:Camerfirma_Global_Chambersign_Root.pem
Adding debian:Camerfirma_Chambers_of_Commerce_Root.pem
Adding debian:COMODO_RSA_Certification_Authority.pem
Adding debian:COMODO_ECC_Certification_Authority.pem
Adding debian:COMODO_Certification_Authority.pem
Adding debian:CNNIC_ROOT.pem
Adding debian:CFCA_EV_ROOT.pem
Adding debian:CA_Disig_Root_R2.pem
Adding debian:CA_Disig_Root_R1.pem
Adding debian:Buypass_Class_3_Root_CA.pem
Adding debian:Buypass_Class_2_Root_CA.pem
Adding debian:Baltimore_CyberTrust_Root.pem
Adding debian:Autoridad_de_Certificacion_Firmaprofesional_CIF_A62634068.pem
Adding debian:Atos_TrustedRoot_2011.pem
Adding debian:Amazon_Root_CA_4.pem
Adding debian:Amazon_Root_CA_3.pem
Adding debian:Amazon_Root_CA_2.pem
Adding debian:Amazon_Root_CA_1.pem
Adding debian:AffirmTrust_Premium_ECC.pem
Adding debian:AffirmTrust_Premium.pem
Adding debian:AffirmTrust_Networking.pem
Adding debian:AffirmTrust_Commercial.pem
Adding debian:AddTrust_Qualified_Certificates_Root.pem
Adding debian:AddTrust_Public_Services_Root.pem
Adding debian:AddTrust_Low-Value_Services_Root.pem
Adding debian:AddTrust_External_Root.pem
Adding debian:Actalis_Authentication_Root_CA.pem
Adding debian:AC_RAIZ_FNMT-RCM.pem
Adding debian:ACEDICOM_Root.pem
Adding debian:ACCVRAIZ1.pem
done.
Setting up openjdk-8-jdk-headless:amd64 (8u144-b01-2) ...
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/idlj to 
provide /usr/bin/idlj (idlj) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jdeps to 
provide /usr/bin/jdeps (jdeps) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/wsimport to 
provide /usr/bin/wsimport (wsimport) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/rmic to 
provide /usr/bin/rmic (rmic) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jinfo to 
provide /usr/bin/jinfo (jinfo) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jsadebugd to 
provide /usr/bin/jsadebugd (jsadebugd) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/native2ascii 
to provide /usr/bin/native2ascii (native2ascii) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstat to 
provide /usr/bin/jstat (jstat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javac to 
provide /usr/bin/javac (javac) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javah to 
provide /usr/bin/javah (javah) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstack to 
provide /usr/bin/jstack (jstack) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jrunscript to 
provide /usr/bin/jrunscript (jrunscript) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javadoc to 
provide /usr/bin/javadoc (javadoc) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jhat to 
provide /usr/bin/jhat (jhat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javap to 
provide /usr/bin/javap (javap) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jar to provide 
/usr/bin/jar (jar) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/xjc to provide 
/usr/bin/x

Build failed in Jenkins: lintian-tests_sid #1998

2017-10-08 Thread jenkins
See 


Changes:

[niels] dplint: Correct order of @RESTRICTED_INCLUDE_DIRS

[niels] dplint: Fix perltidy issue

--
[...truncated 236.84 KB...]
Warning: there was a problem reading the certificate file 
/etc/ssl/certs/NetLock_Arany_=Class_Gold=_F?tan?s?tv?ny.pem. Message:
  /etc/ssl/certs/NetLock_Arany_=Class_Gold=_F?tan?s?tv?ny.pem (No such file or 
directory)
Adding debian:Microsec_e-Szigno_Root_CA_2009.pem
Adding debian:LuxTrust_Global_Root_2.pem
Adding debian:Izenpe.com.pem
Adding debian:IdenTrust_Public_Sector_Root_CA_1.pem
Adding debian:IdenTrust_Commercial_Root_CA_1.pem
Adding debian:ISRG_Root_X1.pem
Adding debian:Hongkong_Post_Root_CA_1.pem
Adding debian:Hellenic_Academic_and_Research_Institutions_RootCA_2015.pem
Adding debian:Hellenic_Academic_and_Research_Institutions_RootCA_2011.pem
Adding debian:Hellenic_Academic_and_Research_Institutions_ECC_RootCA_2015.pem
Adding debian:Go_Daddy_Root_Certificate_Authority_-_G2.pem
Adding debian:Go_Daddy_Class_2_CA.pem
Adding debian:Global_Chambersign_Root_-_2008.pem
Adding debian:GlobalSign_Root_CA_-_R3.pem
Adding debian:GlobalSign_Root_CA_-_R2.pem
Adding debian:GlobalSign_Root_CA.pem
Adding debian:GlobalSign_ECC_Root_CA_-_R5.pem
Adding debian:GlobalSign_ECC_Root_CA_-_R4.pem
Adding debian:GeoTrust_Universal_CA_2.pem
Adding debian:GeoTrust_Universal_CA.pem
Adding debian:GeoTrust_Primary_Certification_Authority_-_G3.pem
Adding debian:GeoTrust_Primary_Certification_Authority_-_G2.pem
Adding debian:GeoTrust_Primary_Certification_Authority.pem
Adding debian:GeoTrust_Global_CA_2.pem
Adding debian:GeoTrust_Global_CA.pem
Adding debian:Entrust_Root_Certification_Authority_-_G2.pem
Adding debian:Entrust_Root_Certification_Authority_-_EC1.pem
Adding debian:Entrust_Root_Certification_Authority.pem
Adding debian:Entrust.net_Premium_2048_Secure_Server_CA.pem
Adding debian:EE_Certification_Centre_Root_CA.pem
Adding debian:EC-ACC.pem
Adding debian:E-Tugra_Certification_Authority.pem
Adding debian:DigiCert_Trusted_Root_G4.pem
Adding debian:DigiCert_High_Assurance_EV_Root_CA.pem
Adding debian:DigiCert_Global_Root_G3.pem
Adding debian:DigiCert_Global_Root_G2.pem
Adding debian:DigiCert_Global_Root_CA.pem
Adding debian:DigiCert_Assured_ID_Root_G3.pem
Adding debian:DigiCert_Assured_ID_Root_G2.pem
Adding debian:DigiCert_Assured_ID_Root_CA.pem
Adding debian:Deutsche_Telekom_Root_CA_2.pem
Adding debian:DST_Root_CA_X3.pem
Adding debian:DST_ACES_CA_X6.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_EV_2009.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_2009.pem
Adding debian:Cybertrust_Global_Root.pem
Adding debian:Comodo_Trusted_Services_root.pem
Adding debian:Comodo_Secure_Services_root.pem
Adding debian:Comodo_AAA_Services_root.pem
Adding debian:China_Internet_Network_Information_Center_EV_Certificates_Root.pem
Adding debian:Chambers_of_Commerce_Root_-_2008.pem
Adding debian:Certum_Trusted_Network_CA_2.pem
Adding debian:Certum_Trusted_Network_CA.pem
Adding debian:Certum_Root_CA.pem
Adding debian:Certplus_Root_CA_G2.pem
Adding debian:Certplus_Root_CA_G1.pem
Adding debian:Certplus_Class_2_Primary_CA.pem
Adding debian:Certinomis_-_Root_CA.pem
Warning: there was a problem reading the certificate file 
/etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem. Message:
  /etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem (No such file or directory)
Adding debian:Certigna.pem
Adding debian:Camerfirma_Global_Chambersign_Root.pem
Adding debian:Camerfirma_Chambers_of_Commerce_Root.pem
Adding debian:COMODO_RSA_Certification_Authority.pem
Adding debian:COMODO_ECC_Certification_Authority.pem
Adding debian:COMODO_Certification_Authority.pem
Adding debian:CNNIC_ROOT.pem
Adding debian:CFCA_EV_ROOT.pem
Adding debian:CA_Disig_Root_R2.pem
Adding debian:CA_Disig_Root_R1.pem
Adding debian:Buypass_Class_3_Root_CA.pem
Adding debian:Buypass_Class_2_Root_CA.pem
Adding debian:Baltimore_CyberTrust_Root.pem
Adding debian:Autoridad_de_Certificacion_Firmaprofesional_CIF_A62634068.pem
Adding debian:Atos_TrustedRoot_2011.pem
Adding debian:Amazon_Root_CA_4.pem
Adding debian:Amazon_Root_CA_3.pem
Adding debian:Amazon_Root_CA_2.pem
Adding debian:Amazon_Root_CA_1.pem
Adding debian:AffirmTrust_Premium_ECC.pem
Adding debian:AffirmTrust_Premium.pem
Adding debian:AffirmTrust_Networking.pem
Adding debian:AffirmTrust_Commercial.pem
Adding debian:AddTrust_Qualified_Certificates_Root.pem
Adding debian:AddTrust_Public_Services_Root.pem
Adding debian:AddTrust_Low-Value_Services_Root.pem
Adding debian:AddTrust_External_Root.pem
Adding debian:Actalis_Authentication_Root_CA.pem
Adding debian:AC_RAIZ_FNMT-RCM.pem
Adding debian:ACEDICOM_Root.pem
Adding debian:ACCVRAIZ1.pem
done.
Setting up openjdk-8-jdk-headless:amd64 (8u144-b01-2) ...
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/idlj to 
provide /usr/bin/idlj (idlj) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jdeps to 
provide

[lintian] branch master updated (a551be3 -> 0973c21)

2017-10-08 Thread Niels Thykier
This is an automated email from the git hooks/post-receive script.

nthykier pushed a change to branch master
in repository lintian.

  from  a551be3   dplint: Fix perltidy issue
   new  0973c21   t: Fix syntax error in desc file

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 t/tests/binaries-from-other-arch/desc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: spelling: Add another correction

2017-10-08 Thread Paul Wise
This is an automated email from the git hooks/post-receive script.

pabs pushed a commit to branch master
in repository lintian.

commit db8fefc16aef1bf0580b46b1960048a74f6221b7
Author: Paul Wise 
Date:   Sun Oct 8 15:47:09 2017 +0800

spelling: Add another correction
---
 data/spelling/corrections | 1 +
 1 file changed, 1 insertion(+)

diff --git a/data/spelling/corrections b/data/spelling/corrections
index db73d28..174b41b 100644
--- a/data/spelling/corrections
+++ b/data/spelling/corrections
@@ -3039,6 +3039,7 @@ recommened||recommended
 recommented||recommended
 rectange||rectangle
 rectanges||rectangles
+recude||reduce
 recurrance||recurrence
 recursivly||recursively
 recusion||recursion

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



Build failed in Jenkins: lintian-tests_sid #1999

2017-10-08 Thread jenkins
See 

--
[...truncated 236.84 KB...]
Warning: there was a problem reading the certificate file 
/etc/ssl/certs/NetLock_Arany_=Class_Gold=_F?tan?s?tv?ny.pem. Message:
  /etc/ssl/certs/NetLock_Arany_=Class_Gold=_F?tan?s?tv?ny.pem (No such file or 
directory)
Adding debian:Microsec_e-Szigno_Root_CA_2009.pem
Adding debian:LuxTrust_Global_Root_2.pem
Adding debian:Izenpe.com.pem
Adding debian:IdenTrust_Public_Sector_Root_CA_1.pem
Adding debian:IdenTrust_Commercial_Root_CA_1.pem
Adding debian:ISRG_Root_X1.pem
Adding debian:Hongkong_Post_Root_CA_1.pem
Adding debian:Hellenic_Academic_and_Research_Institutions_RootCA_2015.pem
Adding debian:Hellenic_Academic_and_Research_Institutions_RootCA_2011.pem
Adding debian:Hellenic_Academic_and_Research_Institutions_ECC_RootCA_2015.pem
Adding debian:Go_Daddy_Root_Certificate_Authority_-_G2.pem
Adding debian:Go_Daddy_Class_2_CA.pem
Adding debian:Global_Chambersign_Root_-_2008.pem
Adding debian:GlobalSign_Root_CA_-_R3.pem
Adding debian:GlobalSign_Root_CA_-_R2.pem
Adding debian:GlobalSign_Root_CA.pem
Adding debian:GlobalSign_ECC_Root_CA_-_R5.pem
Adding debian:GlobalSign_ECC_Root_CA_-_R4.pem
Adding debian:GeoTrust_Universal_CA_2.pem
Adding debian:GeoTrust_Universal_CA.pem
Adding debian:GeoTrust_Primary_Certification_Authority_-_G3.pem
Adding debian:GeoTrust_Primary_Certification_Authority_-_G2.pem
Adding debian:GeoTrust_Primary_Certification_Authority.pem
Adding debian:GeoTrust_Global_CA_2.pem
Adding debian:GeoTrust_Global_CA.pem
Adding debian:Entrust_Root_Certification_Authority_-_G2.pem
Adding debian:Entrust_Root_Certification_Authority_-_EC1.pem
Adding debian:Entrust_Root_Certification_Authority.pem
Adding debian:Entrust.net_Premium_2048_Secure_Server_CA.pem
Adding debian:EE_Certification_Centre_Root_CA.pem
Adding debian:EC-ACC.pem
Adding debian:E-Tugra_Certification_Authority.pem
Adding debian:DigiCert_Trusted_Root_G4.pem
Adding debian:DigiCert_High_Assurance_EV_Root_CA.pem
Adding debian:DigiCert_Global_Root_G3.pem
Adding debian:DigiCert_Global_Root_G2.pem
Adding debian:DigiCert_Global_Root_CA.pem
Adding debian:DigiCert_Assured_ID_Root_G3.pem
Adding debian:DigiCert_Assured_ID_Root_G2.pem
Adding debian:DigiCert_Assured_ID_Root_CA.pem
Adding debian:Deutsche_Telekom_Root_CA_2.pem
Adding debian:DST_Root_CA_X3.pem
Adding debian:DST_ACES_CA_X6.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_EV_2009.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_2009.pem
Adding debian:Cybertrust_Global_Root.pem
Adding debian:Comodo_Trusted_Services_root.pem
Adding debian:Comodo_Secure_Services_root.pem
Adding debian:Comodo_AAA_Services_root.pem
Adding debian:China_Internet_Network_Information_Center_EV_Certificates_Root.pem
Adding debian:Chambers_of_Commerce_Root_-_2008.pem
Adding debian:Certum_Trusted_Network_CA_2.pem
Adding debian:Certum_Trusted_Network_CA.pem
Adding debian:Certum_Root_CA.pem
Adding debian:Certplus_Root_CA_G2.pem
Adding debian:Certplus_Root_CA_G1.pem
Adding debian:Certplus_Class_2_Primary_CA.pem
Adding debian:Certinomis_-_Root_CA.pem
Warning: there was a problem reading the certificate file 
/etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem. Message:
  /etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem (No such file or directory)
Adding debian:Certigna.pem
Adding debian:Camerfirma_Global_Chambersign_Root.pem
Adding debian:Camerfirma_Chambers_of_Commerce_Root.pem
Adding debian:COMODO_RSA_Certification_Authority.pem
Adding debian:COMODO_ECC_Certification_Authority.pem
Adding debian:COMODO_Certification_Authority.pem
Adding debian:CNNIC_ROOT.pem
Adding debian:CFCA_EV_ROOT.pem
Adding debian:CA_Disig_Root_R2.pem
Adding debian:CA_Disig_Root_R1.pem
Adding debian:Buypass_Class_3_Root_CA.pem
Adding debian:Buypass_Class_2_Root_CA.pem
Adding debian:Baltimore_CyberTrust_Root.pem
Adding debian:Autoridad_de_Certificacion_Firmaprofesional_CIF_A62634068.pem
Adding debian:Atos_TrustedRoot_2011.pem
Adding debian:Amazon_Root_CA_4.pem
Adding debian:Amazon_Root_CA_3.pem
Adding debian:Amazon_Root_CA_2.pem
Adding debian:Amazon_Root_CA_1.pem
Adding debian:AffirmTrust_Premium_ECC.pem
Adding debian:AffirmTrust_Premium.pem
Adding debian:AffirmTrust_Networking.pem
Adding debian:AffirmTrust_Commercial.pem
Adding debian:AddTrust_Qualified_Certificates_Root.pem
Adding debian:AddTrust_Public_Services_Root.pem
Adding debian:AddTrust_Low-Value_Services_Root.pem
Adding debian:AddTrust_External_Root.pem
Adding debian:Actalis_Authentication_Root_CA.pem
Adding debian:AC_RAIZ_FNMT-RCM.pem
Adding debian:ACEDICOM_Root.pem
Adding debian:ACCVRAIZ1.pem
done.
Setting up openjdk-8-jdk-headless:amd64 (8u144-b01-2) ...
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/idlj to 
provide /usr/bin/idlj (idlj) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jdeps to 
provide /usr/bin/jdeps (jdeps) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/wsimport to 
prov

[lintian] branch master updated (0973c21 -> db8fefc)

2017-10-08 Thread Paul Wise
This is an automated email from the git hooks/post-receive script.

pabs pushed a change to branch master
in repository lintian.

  from  0973c21   t: Fix syntax error in desc file
   new  db8fefc   spelling: Add another correction

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 data/spelling/corrections | 1 +
 1 file changed, 1 insertion(+)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



Build failed in Jenkins: lintian-tests_sid #2000

2017-10-08 Thread jenkins
See 


Changes:

[niels] t: Fix syntax error in desc file

--
[...truncated 238.48 KB...]
Adding debian:EE_Certification_Centre_Root_CA.pem
Adding debian:EC-ACC.pem
Adding debian:E-Tugra_Certification_Authority.pem
Adding debian:DigiCert_Trusted_Root_G4.pem
Adding debian:DigiCert_High_Assurance_EV_Root_CA.pem
Adding debian:DigiCert_Global_Root_G3.pem
Adding debian:DigiCert_Global_Root_G2.pem
Adding debian:DigiCert_Global_Root_CA.pem
Adding debian:DigiCert_Assured_ID_Root_G3.pem
Adding debian:DigiCert_Assured_ID_Root_G2.pem
Adding debian:DigiCert_Assured_ID_Root_CA.pem
Adding debian:Deutsche_Telekom_Root_CA_2.pem
Adding debian:DST_Root_CA_X3.pem
Adding debian:DST_ACES_CA_X6.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_EV_2009.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_2009.pem
Adding debian:Cybertrust_Global_Root.pem
Adding debian:Comodo_Trusted_Services_root.pem
Adding debian:Comodo_Secure_Services_root.pem
Adding debian:Comodo_AAA_Services_root.pem
Adding debian:China_Internet_Network_Information_Center_EV_Certificates_Root.pem
Adding debian:Chambers_of_Commerce_Root_-_2008.pem
Adding debian:Certum_Trusted_Network_CA_2.pem
Adding debian:Certum_Trusted_Network_CA.pem
Adding debian:Certum_Root_CA.pem
Adding debian:Certplus_Root_CA_G2.pem
Adding debian:Certplus_Root_CA_G1.pem
Adding debian:Certplus_Class_2_Primary_CA.pem
Adding debian:Certinomis_-_Root_CA.pem
Warning: there was a problem reading the certificate file 
/etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem. Message:
  /etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem (No such file or directory)
Adding debian:Certigna.pem
Adding debian:Camerfirma_Global_Chambersign_Root.pem
Adding debian:Camerfirma_Chambers_of_Commerce_Root.pem
Adding debian:COMODO_RSA_Certification_Authority.pem
Adding debian:COMODO_ECC_Certification_Authority.pem
Adding debian:COMODO_Certification_Authority.pem
Adding debian:CNNIC_ROOT.pem
Adding debian:CFCA_EV_ROOT.pem
Adding debian:CA_Disig_Root_R2.pem
Adding debian:CA_Disig_Root_R1.pem
Adding debian:Buypass_Class_3_Root_CA.pem
Adding debian:Buypass_Class_2_Root_CA.pem
Adding debian:Baltimore_CyberTrust_Root.pem
Adding debian:Autoridad_de_Certificacion_Firmaprofesional_CIF_A62634068.pem
Adding debian:Atos_TrustedRoot_2011.pem
Adding debian:Amazon_Root_CA_4.pem
Adding debian:Amazon_Root_CA_3.pem
Adding debian:Amazon_Root_CA_2.pem
Adding debian:Amazon_Root_CA_1.pem
Adding debian:AffirmTrust_Premium_ECC.pem
Adding debian:AffirmTrust_Premium.pem
Adding debian:AffirmTrust_Networking.pem
Adding debian:AffirmTrust_Commercial.pem
Adding debian:AddTrust_Qualified_Certificates_Root.pem
Adding debian:AddTrust_Public_Services_Root.pem
Adding debian:AddTrust_Low-Value_Services_Root.pem
Adding debian:AddTrust_External_Root.pem
Adding debian:Actalis_Authentication_Root_CA.pem
Adding debian:AC_RAIZ_FNMT-RCM.pem
Adding debian:ACEDICOM_Root.pem
Adding debian:ACCVRAIZ1.pem
done.
Setting up openjdk-8-jdk-headless:amd64 (8u144-b01-2) ...
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/idlj to 
provide /usr/bin/idlj (idlj) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jdeps to 
provide /usr/bin/jdeps (jdeps) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/wsimport to 
provide /usr/bin/wsimport (wsimport) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/rmic to 
provide /usr/bin/rmic (rmic) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jinfo to 
provide /usr/bin/jinfo (jinfo) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jsadebugd to 
provide /usr/bin/jsadebugd (jsadebugd) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/native2ascii 
to provide /usr/bin/native2ascii (native2ascii) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstat to 
provide /usr/bin/jstat (jstat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javac to 
provide /usr/bin/javac (javac) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javah to 
provide /usr/bin/javah (javah) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstack to 
provide /usr/bin/jstack (jstack) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jrunscript to 
provide /usr/bin/jrunscript (jrunscript) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javadoc to 
provide /usr/bin/javadoc (javadoc) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jhat to 
provide /usr/bin/jhat (jhat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javap to 
provide /usr/bin/javap (javap) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jar to provide 
/usr/bi

[lintian] branch 875964-please-warn-about-files-in-usrlibpythonxydist-packagestestsinitpy created (now 5e64380)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch 
875964-please-warn-about-files-in-usrlibpythonxydist-packagestestsinitpy
in repository lintian.

at  5e64380   t/scripts/pod-spelling.t: Ignore dbgsym

No new revisions were added by this update.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: tests/control-file-pendantic-space: Prevent a test regression caused by 52766dc7364d318.

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 75591c0073eb3b95259bc9f90908e2a620c6f311
Author: Chris Lamb 
Date:   Sun Oct 8 09:18:49 2017 +0100

tests/control-file-pendantic-space: Prevent a test regression caused by 
52766dc7364d318.
---
 t/tests/control-file-pedantic-space/debian/debian/control.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/tests/control-file-pedantic-space/debian/debian/control.in 
b/t/tests/control-file-pedantic-space/debian/debian/control.in
index 5ed48ab..6eae925 100644
--- a/t/tests/control-file-pedantic-space/debian/debian/control.in
+++ b/t/tests/control-file-pedantic-space/debian/debian/control.in
@@ -1,5 +1,5 @@
 Source:  {$source}
-Priority:extra
+Priority:optional
 Section:   {$section}
 Maintainer: {$author}
 Standards-Version: {$standards_version}

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch master updated (db8fefc -> 75591c0)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  db8fefc   spelling: Add another correction
   new  75591c0   tests/control-file-pendantic-space: Prevent a test 
regression caused by 52766dc7364d318.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 t/tests/control-file-pedantic-space/debian/debian/control.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch 873612-please-check-latest-debian-changelog-entry-without-new-date-for-sources-as-well created (now 7ab0917)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch 
873612-please-check-latest-debian-changelog-entry-without-new-date-for-sources-as-well
in repository lintian.

at  7ab0917   Move latest-debian-changelog-entry-without-new-date tag 
into a new check of type "source". (Closes: #873612)

This branch includes the following new commits:

   new  7ab0917   Move latest-debian-changelog-entry-without-new-date tag 
into a new check of type "source". (Closes: #873612)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch check-tag-documentation created (now 00d9d2d)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch check-tag-documentation
in repository lintian.

at  00d9d2d   t: Update documentation to reflect check-tag's replacement

This branch includes the following new commits:

   new  00d9d2d   t: Update documentation to reflect check-tag's replacement

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: .

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch bad-distribution-in-debian-changelog-873520
in repository lintian.

commit 7e1279b9de46fb9b8813dbe13dfbaaa55768f930
Author: Chris Lamb 
Date:   Tue Aug 29 09:25:51 2017 +0100

.
---
 checks/changelog-file.desc | 13 +
 checks/changelog-file.pm   |  7 +++
 t/tests/distribution-multiple-bad/tags |  1 +
 3 files changed, 21 insertions(+)

diff --git a/checks/changelog-file.desc b/checks/changelog-file.desc
index df848ac..7f18d95 100644
--- a/checks/changelog-file.desc
+++ b/checks/changelog-file.desc
@@ -420,3 +420,16 @@ Info: The changelog entry references a temporary security 
identifier,
  please replace the TEMP identifier with a short description of the
  issue.
 Ref: #787929, #807892
+
+Tag: bad-distribution-in-changelog-file
+Severity: important
+Certainty: certain
+Info: You've specified an unknown target distribution for your upload in
+ the debian/changelog file.  It is possible that you are uploading
+ for a different distribution than the one Lintian is checking for.  In
+ that case, passing --profile $VENDOR may fix this warning.
+ .
+ Note that the distributions non-free and contrib are no
+ longer valid. You'll have to use distribution unstable and
+ Section: non-free/xxx or Section: contrib/xxx instead.
+Ref: policy 5.6.14
diff --git a/checks/changelog-file.pm b/checks/changelog-file.pm
index 26b5d7a..bcc4f7e 100644
--- a/checks/changelog-file.pm
+++ b/checks/changelog-file.pm
@@ -38,6 +38,7 @@ use Lintian::Data ();
 
 my $BUGS_NUMBER
   = Lintian::Data->new('changelog-file/bugs-number', qr/\s*=\s*/o);
+my $KNOWN_DISTS = Lintian::Data->new('changes-file/known-dists');
 
 my $SPELLING_ERROR_IN_NEWS
   = spelling_tag_emitter('spelling-error-in-news-debian');
@@ -295,6 +296,12 @@ sub run {
 }
 }
 
+my $distribution = $entries[0]->Distribution;
+if (!$KNOWN_DISTS->known($distribution)) {
+# bad distribution entry
+tag 'bad-distribution-in-changelog-file', $distribution;
+}
+
 if (@entries > 1) {
 my $second_timestamp = $entries[1]->Timestamp;
 
diff --git a/t/tests/distribution-multiple-bad/tags 
b/t/tests/distribution-multiple-bad/tags
index eb545f3..affa071 100644
--- a/t/tests/distribution-multiple-bad/tags
+++ b/t/tests/distribution-multiple-bad/tags
@@ -3,4 +3,5 @@ E: distribution-multiple-bad changes: 
bad-distribution-in-changes-file bar
 E: distribution-multiple-bad changes: bad-distribution-in-changes-file foo
 E: distribution-multiple-bad changes: bad-distribution-in-changes-file 
foo-backportss
 E: distribution-multiple-bad changes: multiple-distributions-in-changes-file 
stable foo-backportss bar foo
+E: distribution-multiple-bad: bad-distribution-in-changelog-file stable 
foo-backportss bar foo
 I: distribution-multiple-bad changes: backports-changes-missing

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/03: Open new version

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch experimental2.5.36
in repository lintian.

commit 5791fea77c4e7d05cba9d02ceb2b2cb252fe8a76
Author: Bastien ROUCARIÈS 
Date:   Tue Aug 4 18:03:52 2015 +0200

Open new version

Signed-off-by: Bastien ROUCARIÈS 
---
 debian/changelog | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index 1193628..cc3fcbd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+lintian (2.5.36) UNRELEASED; urgency=medium
+
+  XXX: generate tag summary with private/generate-tag-summary
+
+ -- Bastien Roucariès   Tue, 04 Aug 2015 
17:28:59 +0200
+
 lintian (2.5.35) unstable; urgency=medium
 
   * Summary of tag changes:

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: Move latest-debian-changelog-entry-without-new-date tag into a new check of type "source". (Closes: #873612)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch 
873612-please-check-latest-debian-changelog-entry-without-new-date-for-sources-as-well
in repository lintian.

commit 7ab09171ee4335556f78e2b4359d64d30a1b3ea2
Author: Chris Lamb 
Date:   Wed Sep 6 08:25:49 2017 +0100

Move latest-debian-changelog-entry-without-new-date tag into a new check of 
type "source". (Closes: #873612)
---
 checks/changelog-file.desc |  2 +-
 checks/changelog-file.pm   |  2 +-
 checks/source-changelog.desc   | 18 
 checks/source-changelog.pm | 52 ++
 debian/changelog   |  3 ++
 profiles/debian/main.profile   |  5 ++--
 t/tests/changelog-file-general/desc|  1 +
 t/tests/changelog-file-general/tags|  3 +-
 t/tests/changelog-file-unreleased/desc |  4 ++-
 t/tests/legacy-foo++/desc  |  1 +
 t/tests/legacy-foo++/tags  |  3 +-
 11 files changed, 87 insertions(+), 7 deletions(-)

diff --git a/checks/changelog-file.desc b/checks/changelog-file.desc
index df848ac..07b4346 100644
--- a/checks/changelog-file.desc
+++ b/checks/changelog-file.desc
@@ -195,7 +195,7 @@ Info: The NEWS.Debian file must be valid UTF-8, an encoding 
of the Unicode
   $ iconv -f ISO-8859-1 -t UTF-8 NEWS.Debian > NEWS.Debian.new
   $ mv NEWS.Debian.new NEWS.Debian
 
-Tag: latest-debian-changelog-entry-without-new-date
+Tag: latest-changelog-entry-without-new-date
 Severity: important
 Certainty: certain
 Info: The latest Debian changelog entry has either the same or even an
diff --git a/checks/changelog-file.pm b/checks/changelog-file.pm
index 26b5d7a..74a03be 100644
--- a/checks/changelog-file.pm
+++ b/checks/changelog-file.pm
@@ -299,7 +299,7 @@ sub run {
 my $second_timestamp = $entries[1]->Timestamp;
 
 if ($first_timestamp && $second_timestamp) {
-tag 'latest-debian-changelog-entry-without-new-date'
+tag 'latest-changelog-entry-without-new-date'
   unless (($first_timestamp - $second_timestamp) > 0
 or lc($entries[0]->Distribution) eq 'unreleased');
 }
diff --git a/checks/source-changelog.desc b/checks/source-changelog.desc
new file mode 100644
index 000..32f4615
--- /dev/null
+++ b/checks/source-changelog.desc
@@ -0,0 +1,18 @@
+Check-Script: source-changelog
+Author: Chris Lamb 
+Type: source
+Needs-Info: changelog-file, unpacked
+Info: This script checks if a source package conforms to policy
+ with regard to changelog files.
+ .
+ Each source package should have a debian/changelog file.
+
+Tag: latest-debian-changelog-entry-without-new-date
+Severity: important
+Certainty: certain
+Info: The latest Debian changelog entry has either the same or even an
+ older date as the entry before.
+ .
+ This can result in subtle bugs due to the SOURCE_DATE_EPOCH
+ environment variable being the same between the older and newer
+ versions.
diff --git a/checks/source-changelog.pm b/checks/source-changelog.pm
new file mode 100644
index 000..d37c4d5
--- /dev/null
+++ b/checks/source-changelog.pm
@@ -0,0 +1,52 @@
+# source-changelog -- lintian check script -*- perl -*-
+
+# Copyright (C) 2017 Chris Lamb 
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, you can find it on the World Wide
+# Web at http://www.gnu.org/copyleft/gpl.html, or write to the Free
+# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
+# MA 02110-1301, USA.
+
+package Lintian::source_changelog;
+use strict;
+use warnings;
+use autodie;
+use Parse::DebianChangelog;
+use Lintian::Tags qw(tag);
+
+sub run {
+my ($pkg, undef, $info, undef, undef) = @_;
+
+my @entries = $info->changelog->data;
+if (@entries > 1) {
+my $first_timestamp = $entries[0]->Timestamp;
+my $second_timestamp = $entries[1]->Timestamp;
+
+if ($first_timestamp && $second_timestamp) {
+tag 'latest-debian-changelog-entry-without-new-date'
+  unless (($first_timestamp - $second_timestamp) > 0
+or lc($entries[0]->Distribution) eq 'unreleased');
+}
+}
+
+return;
+}
+
+1;
+
+# Local Variables:
+# indent-tabs-mode: nil
+# cperl-indent-level: 4
+# End:
+# vim: syntax=perl sw=4 sts=4 sr et
diff --git a/debian/changelog b/debian/changelog
index bb90f6e..b1cc73a 100644
--- a/debian/changel

[lintian] branch experimental2.5.36 created (now 5321123)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch experimental2.5.36
in repository lintian.

at  5321123   Detect suspicious use of ln that could be replaced by 
dpkg-maintscript-helper

This branch includes the following new commits:

   new  5791fea   Open new version
   new  5e19d4f   Use compat 9
   new  5321123   Detect suspicious use of ln that could be replaced by 
dpkg-maintscript-helper

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 02/03: Use compat 9

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch experimental2.5.36
in repository lintian.

commit 5e19d4f51023f2759a33bfba41ac51f93fcf25d3
Author: Bastien ROUCARIÈS 
Date:   Tue Aug 4 18:28:26 2015 +0200

Use compat 9

Signed-off-by: Bastien ROUCARIÈS 
---
 debian/changelog| 3 +++
 debian/compat   | 2 +-
 debian/source/lintian-overrides | 2 --
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index cc3fcbd..637c760 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,9 @@ lintian (2.5.36) UNRELEASED; urgency=medium
 
   XXX: generate tag summary with private/generate-tag-summary
 
+  * debian/compat:
++ [BR] Use compat version 9.
+
  -- Bastien Roucariès   Tue, 04 Aug 2015 
17:28:59 +0200
 
 lintian (2.5.35) unstable; urgency=medium
diff --git a/debian/compat b/debian/compat
index 7f8f011..ec63514 100644
--- a/debian/compat
+++ b/debian/compat
@@ -1 +1 @@
-7
+9
diff --git a/debian/source/lintian-overrides b/debian/source/lintian-overrides
index ac36a06..bcb48cd 100644
--- a/debian/source/lintian-overrides
+++ b/debian/source/lintian-overrides
@@ -8,5 +8,3 @@ lintian source: unused-build-dependency-on-cdbs
 lintian source: build-depends-on-python-dev-with-no-arch-any
 # We use hardening-includes for the hardening-check binary
 lintian source: build-depends-on-obsolete-package build-depends: 
hardening-includes => use dpkg-buildflags instead
-# we use old compat version in order to ease backport
-lintian source: package-uses-old-debhelper-compat-version 7

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: t: Update documentation to reflect check-tag's replacement

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch check-tag-documentation
in repository lintian.

commit 00d9d2d1bae068553f213b40c3212cb192ab0acc
Author: Chris Lamb 
Date:   Mon Aug 24 21:28:18 2015 +0200

t: Update documentation to reflect check-tag's replacement

Signed-off-by: Chris Lamb 
---
 t/changes/README | 2 +-
 t/debs/README| 2 +-
 t/runtests   | 4 ++--
 t/source/README  | 2 +-
 t/tests/README   | 7 ---
 5 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/t/changes/README b/t/changes/README
index 547bdaf..2ee06de 100644
--- a/t/changes/README
+++ b/t/changes/README
@@ -53,7 +53,7 @@ Give only the test name, not the full path.
 It's often more useful to run every test that is relevant to a
 particular tag.  To do that, run:
 
-debian/rules check-tag tag=
+debian/rules runtests onlyrun=tag:
 
 This will run all tests that list that tag in the .tags file.
 
diff --git a/t/debs/README b/t/debs/README
index 4d01906..541393f 100644
--- a/t/debs/README
+++ b/t/debs/README
@@ -87,7 +87,7 @@ To run a specific test case, run:
 It's often more useful to run every test that is relevant to a
 particular tag.  To do that, run:
 
-debian/rules check-tag tag=
+debian/rules runtests onlyrun=tag:
 
 This will run all tests that list that tag in the tags file.
 
diff --git a/t/runtests b/t/runtests
index e93a0fe..6000d52 100755
--- a/t/runtests
+++ b/t/runtests
@@ -21,8 +21,8 @@
 # MA 02110-1301, USA.
 
 # The harness for Lintian's new test suite.  Normally run through the runtests
-# or check-tag targets in debian/rules.  For detailed information on the test
-# suite layout and naming conventions, see t/tests/README.
+# targets in debian/rules.  For detailed information on the test suite layout
+# and naming conventions, see t/tests/README.
 #
 # The build output is directed to build.pkgname in the testing-directory.
 
diff --git a/t/source/README b/t/source/README
index a268f4c..0dc6d21 100644
--- a/t/source/README
+++ b/t/source/README
@@ -80,7 +80,7 @@ To run a specific test case, run:
 It's often more useful to run every test that is relevant to a
 particular tag.  To do that, run:
 
-debian/rules check-tag tag=
+debian/rules runtests onlyrun=tag:
 
 This will run all tests that list that tag in the tags file.
 
diff --git a/t/tests/README b/t/tests/README
index 19b9dde..cfb5759 100644
--- a/t/tests/README
+++ b/t/tests/README
@@ -237,7 +237,7 @@ file name, not the full path.
 It's often more useful to run every test that is relevant to a
 particular tag.  To do that, run:
 
-debian/rules check-tag tag=
+debian/rules runtests onlyrun=tag:
 
 This will run all tests that list that tag in either Test-For or
 Test-Against.
@@ -270,8 +270,9 @@ issued.
 
 Be sure to use Test-For and Test-Against for tags that are targets of
 a particular test case.  The test harness will ensure that the test
-case behaves correctly, and that metadata is used for the check-tag
-target and when checking test coverage.
+case behaves correctly, and that metadata is used for the runtests
+target (when called with the onlyrun=tag: filter) and when checking test
+coverage.
 
 The test template uses debhelper 7.  Use debhelper 7 features whenever
 possible rather than replacing the rules file with a more verbose one.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 03/03: Detect suspicious use of ln that could be replaced by dpkg-maintscript-helper

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch experimental2.5.36
in repository lintian.

commit 532112399f1dbf17c838ed0ddd09adcfcc03c135
Author: Bastien ROUCARIÈS 
Date:   Wed Aug 5 14:24:05 2015 +0200

Detect suspicious use of ln that could be replaced by 
dpkg-maintscript-helper

Signed-off-by: Bastien ROUCARIÈS 
---
 checks/scripts.desc   | 11 +++
 data/scripts/maintainer-script-bad-command|  1 +
 debian/changelog  |  4 
 t/scripts/implemented-tags.t  |  1 +
 t/tests/scripts-maintainer-general/debian/debian/postinst |  7 +++
 t/tests/scripts-maintainer-general/desc   |  1 +
 t/tests/scripts-maintainer-general/tags   |  1 +
 7 files changed, 26 insertions(+)

diff --git a/checks/scripts.desc b/checks/scripts.desc
index 979393a..a8b4d7d 100644
--- a/checks/scripts.desc
+++ b/checks/scripts.desc
@@ -628,6 +628,17 @@ Info:  The maintainer script apparently runs 'adduser 
--system'
  adduser --no-create-home --home /nonexistent instead.
 Ref: fhs homeuserhomedirectories, adduser(8)
 
+Tag: maintainer-script-may-use-dir_to_symlink_helper
+Severity: serious
+Certainty: possible
+Experimental: yes
+Info: The maintainer script apparently change a directory to a symlink
+ not using dir_to_symlink command of dpkg-maintscript-helper, that take
+ great care to avoid a lot of problems.
+ .
+ Please use the dpkg-maintscript-helper dir_to_symlink command.
+Ref: dpkg-maintscript-helper(1)
+
 Tag: maintainer-script-empty
 Severity: minor
 Certainty: certain
diff --git a/data/scripts/maintainer-script-bad-command 
b/data/scripts/maintainer-script-bad-command
index b0794a6..bfad17a 100644
--- a/data/scripts/maintainer-script-bad-command
+++ b/data/scripts/maintainer-script-bad-command
@@ -42,6 +42,7 @@ maintainer-script-should-not-use-start-stop-daemon
  ~~ 0 ~~
 maintainer-script-should-not-use-update-alternatives-remove ~~ 1 ~~
~~^postrm$  ~~\b update\-alternatives\s+\-\-remove\b
 maintainer-script-should-not-use-update-alternatives-set~~ 1 ~~
~~  
~~^(?!\s*echo\s+["'][^'"]*)\bupdate\-alternatives\s+\-\-(?:set|set\-selections|config)\b
 trailing-slash-for-dpkg-maintscript-helper-symlink_to_dir   ~~ 1 ~~
~~  ~~ dpkg-maintscript-helper\s+symlink_to_dir\s+[^\s]+/\s
+maintainer-script-may-use-dir_to_symlink_helper ~~ 1 ~~
~~  ~~ ln[ ]*-f?s.*doc
 # sendmail use override do not change it now
 suidregister-used-in-maintainer-script  ~~ 1 ~~
~~  ~~\bsuidregister\b
 
diff --git a/debian/changelog b/debian/changelog
index 637c760..de5aef8 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,10 @@ lintian (2.5.36) UNRELEASED; urgency=medium
 
   XXX: generate tag summary with private/generate-tag-summary
 
+  * checks/scripts.desc:
++ [BR] Detect suspicious use of ln -s that could be replaced by
+  dpkg-maintscript-helper.
+
   * debian/compat:
 + [BR] Use compat version 9.
 
diff --git a/t/scripts/implemented-tags.t b/t/scripts/implemented-tags.t
index aaed590..82316de 100755
--- a/t/scripts/implemented-tags.t
+++ b/t/scripts/implemented-tags.t
@@ -47,6 +47,7 @@ our $EXCLUDE =join(
   ^hardening-.*$
   ^privacy-breach-.*$
   ^maintainer-script-should-not-.*$
+  ^maintainer-script-may-.*$
   ^install-info-used-in-maintainer-script$
   ^license-problem-cc-by-nc-sa$
   ^license-problem-json-evil$
diff --git a/t/tests/scripts-maintainer-general/debian/debian/postinst 
b/t/tests/scripts-maintainer-general/debian/debian/postinst
index 39c4731..2346e0f 100755
--- a/t/tests/scripts-maintainer-general/debian/debian/postinst
+++ b/t/tests/scripts-maintainer-general/debian/debian/postinst
@@ -197,4 +197,11 @@ dpkg-maintscript-helper symlink_to_dir \
 adduser --system --quiet --ingroup ntp --no-create-home ntp
 adduser festival --quiet --system --ingroup audio --no-create-home
 
+# detect usage that could be replaced by dpkg-maintscript-helper
+if [ -d /usr/share/doc/tworld ]; then
+   if rmdir /usr/share/doc/tworld 2>/dev/null; then
+   ln -s tworld-data /usr/share/doc/tworld
+   fi
+fi
+
 #DEBHELPER#
diff --git a/t/tests/scripts-maintainer-general/desc 
b/t/tests/scripts-maintainer-general/desc
index fab5701..2d83d1b 100644
--- a/t/tests/scripts-maintainer-general/desc
+++ b/t/tests/scripts-maintainer-general/desc
@@ -35,4 +35,5 @@ Test-For:
  read-in-maintainer-script
  suidregister-used-in-maintainer-script
  trailing-slash-for-dpkg-maintscript-helper-symlink_to_dir
+ maintainer-script-may-use-dir_to_symlink_helper
 References: Debian Bug#532984
diff --git a/t/tests/scripts-maintainer-general/tags 
b/t/tests/scripts-maintainer-general/tags
index 39a2f55..068a

[lintian] branch bad-distribution-in-debian-changelog-873520 created (now 7e1279b)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch bad-distribution-in-debian-changelog-873520
in repository lintian.

at  7e1279b   .

This branch includes the following new commits:

   new  7e1279b   .

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch githubredir created (now 75bbb02)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch githubredir
in repository lintian.

at  75bbb02   Warn if debian/watch uses deprecated 
githubredir.debian.net scraper

This branch includes the following new commits:

   new  75bbb02   Warn if debian/watch uses deprecated 
githubredir.debian.net scraper

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch false-positive-binary-file-built-without-lfs-support-on-x32-871956 created (now d947c83)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch 
false-positive-binary-file-built-without-lfs-support-on-x32-871956
in repository lintian.

at  d947c83   Clarify explanation of 
description-starts-with-leading-spaces tag. Thanks to Taylor Kline 
 for the report and patch. (Closes: #849622)

No new revisions were added by this update.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch js-package-outside-of-web created (now cc808e1)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch js-package-outside-of-web
in repository lintian.

at  cc808e1   c/fields: Check for for libjs-* outside of web section. 
(Closes: #798983)

This branch includes the following new commits:

   new  cc808e1   c/fields: Check for for libjs-* outside of web section. 
(Closes: #798983)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch gzip-no-name created (now e7b52b4)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch gzip-no-name
in repository lintian.

at  e7b52b4   New tag gzip-called-without-no-name-option

This branch includes the following new commits:

   new  e7b52b4   New tag gzip-called-without-no-name-option

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch false-positive-source-is-missing-bug-for-cssbrowserselectorjs-874381 created (now 72d95b8)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch 
false-positive-source-is-missing-bug-for-cssbrowserselectorjs-874381
in repository lintian.

at  72d95b8   Avoid false positives in missing source checks for "CSS 
Browser Selector". (Closes: #874381)

No new revisions were added by this update.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch add-flag-list-tags-that-will-list-all-tags-lintian-knows-about-779675 created (now 63f08a2)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch 
add-flag-list-tags-that-will-list-all-tags-lintian-knows-about-779675
in repository lintian.

at  63f08a2   Add a --list-tags option to print all tags Lintian knows 
about. Thanks to Rajendra Gokhale for the suggestion. (Closes: #779675)

No new revisions were added by this update.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: c/fields: Check for for libjs-* outside of web section. (Closes: #798983)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch js-package-outside-of-web
in repository lintian.

commit cc808e1717fe343569f83f4ef8a8af2be72861a5
Author: Chris Lamb 
Date:   Fri Aug 26 10:50:11 2016 +0100

c/fields: Check for for libjs-* outside of web section. (Closes: #798983)

Signed-off-by: Chris Lamb 
---
 checks/fields.pm  |  1 +
 t/tests/fields-wrong-section/debian/debian/control.in | 11 +++
 t/tests/fields-wrong-section/tags |  1 +
 3 files changed, 13 insertions(+)

diff --git a/checks/fields.pm b/checks/fields.pm
index 8ceacf6..1e1baf4 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -109,6 +109,7 @@ my @NAME_SECTION_MAPPINGS = (
 [qr/^lib.*-(?:ocaml|camlp4)-dev$/ => 'ocaml'],
 [qr/^lib.*-dev$/  => 'libdevel'],
 [qr/^gir\d+\.\d+-.*-\d+\.\d+$/=> 'introspection'],
+[qr/^libjs-/  => 'web'],
 );
 
 my %VCS_EXTRACT = (
diff --git a/t/tests/fields-wrong-section/debian/debian/control.in 
b/t/tests/fields-wrong-section/debian/debian/control.in
index d04e073..7cdc238 100644
--- a/t/tests/fields-wrong-section/debian/debian/control.in
+++ b/t/tests/fields-wrong-section/debian/debian/control.in
@@ -82,6 +82,17 @@ Description: {$description} (OCaml)
  things.  It should not be installed like a regular package.  It may
  be an empty package.
 
+Package: libjs-{$source}
+Architecture: any
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Description: {$description} (Javascript)
+ Test for web section.
+ .
+ This is a test package designed to exercise some feature or tag of
+ Lintian.  It is part of the Lintian test suite and may do very odd
+ things.  It should not be installed like a regular package.  It may
+ be an empty package.
+
 Package: libghc-{$source}
 Architecture: {$architecture}
 Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
diff --git a/t/tests/fields-wrong-section/tags 
b/t/tests/fields-wrong-section/tags
index 5258a66..15a9ad1 100644
--- a/t/tests/fields-wrong-section/tags
+++ b/t/tests/fields-wrong-section/tags
@@ -10,6 +10,7 @@ W: libfields-wrong-section-ocaml-dev: 
wrong-section-according-to-package-name li
 W: libfields-wrong-section-perl: wrong-section-according-to-package-name 
libfields-wrong-section-perl => perl
 W: libfields-wrong-section-ruby1.8: wrong-section-according-to-package-name 
libfields-wrong-section-ruby1.8 => ruby
 W: libghc-fields-wrong-section: wrong-section-according-to-package-name 
libghc-fields-wrong-section => haskell
+W: libjs-fields-wrong-section: wrong-section-according-to-package-name 
libjs-fields-wrong-section => web
 W: libphp-fields-wrong-section: wrong-section-according-to-package-name 
libphp-fields-wrong-section => php
 W: python-fields-wrong-section: wrong-section-according-to-package-name 
python-fields-wrong-section => python
 W: r-cran-fields-wrong-section: wrong-section-according-to-package-name 
r-cran-fields-wrong-section => gnu-r

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch init.d-script-needs-depends-on-lsb-base created (now c09ecd4)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch init.d-script-needs-depends-on-lsb-base
in repository lintian.

at  c09ecd4   Check scripts using init-functions without lsb-base 
Depends.

This branch includes the following new commits:

   new  c09ecd4   Check scripts using init-functions without lsb-base 
Depends.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch lamby/wip/854134 created (now 49681fd)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch lamby/wip/854134
in repository lintian.

at  49681fd   .

This branch includes the following new commits:

   new  49681fd   .

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: New tag gzip-called-without-no-name-option

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch gzip-no-name
in repository lintian.

commit e7b52b435bca9a4940782a76f3db6d21ac832791
Author: Chris Lamb 
Date:   Thu Aug 27 20:15:33 2015 +0200

New tag gzip-called-without-no-name-option
---
 checks/rules.desc |  6 ++
 checks/rules.pm   |  4 
 t/tests/rules-general/debian/debian/rules | 10 ++
 t/tests/rules-general/desc|  3 ++-
 t/tests/rules-general/tags|  2 ++
 5 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/checks/rules.desc b/checks/rules.desc
index bea0e17..aa63ffa 100644
--- a/checks/rules.desc
+++ b/checks/rules.desc
@@ -247,3 +247,9 @@ Info: The source package does not have both a build-arch 
and a build-indep
  .
  Please consider adding both the build-arch and build-indep targets.
 
+Tag: gzip-called-without-no-name-option
+Severity: normal
+Certainty: possible
+Info: The rules files appears to call gzip without specifying the
+ -n option. This introduces timestamps into the binary package,
+ rendering the package unreproducible.
diff --git a/checks/rules.pm b/checks/rules.pm
index e1fdf73..0e646bf 100644
--- a/checks/rules.pm
+++ b/checks/rules.pm
@@ -219,6 +219,10 @@ sub run {
 tag 'debian-rules-makemaker-prefix-is-deprecated', "line $.";
 }
 
+if ($line =~ m/\bgzip\b/ && $line !~ m/\s-\w*n\w*\b/) {
+tag 'gzip-called-without-no-name-option', "line $.";
+}
+
 # General assignment - save the variable
 if (/^\s*(?:\S+\s+)*?(\S+)\s*([:\?\+])?=\s*(.*+)?$/so) {
 # This is far too simple from a theoretical PoV, but should do
diff --git a/t/tests/rules-general/debian/debian/rules 
b/t/tests/rules-general/debian/debian/rules
index cddbc03..1c4c31e 100755
--- a/t/tests/rules-general/debian/debian/rules
+++ b/t/tests/rules-general/debian/debian/rules
@@ -9,3 +9,13 @@ clean:
dh_clean
echo $(DEB_BUILD_OPTS) $(PWD)
@echo $(_)
+
+dh_auto_build:
+   # Bad
+   touch filename && gzip filename
+   touch filename && gzip -9 filename
+   
+   # Good
+   gzip -9nmore filename
+   gzip -n9 filename
+   gzip filename -n9
diff --git a/t/tests/rules-general/desc b/t/tests/rules-general/desc
index 1f41c20..417eba5 100644
--- a/t/tests/rules-general/desc
+++ b/t/tests/rules-general/desc
@@ -7,4 +7,5 @@ Test-For:
  debian-rules-should-not-automatically-update-control
  debian-rules-should-not-use-DEB_BUILD_OPTS
  debian-rules-should-not-use-pwd
- debian-rules-should-not-use-underscore-variable
\ No newline at end of file
+ debian-rules-should-not-use-underscore-variable
+ gzip-called-without-no-name-option
diff --git a/t/tests/rules-general/tags b/t/tests/rules-general/tags
index 3e7351b..415e097 100644
--- a/t/tests/rules-general/tags
+++ b/t/tests/rules-general/tags
@@ -3,3 +3,5 @@ E: rules-general source: 
debian-rules-should-not-automatically-update-control li
 W: rules-general source: debian-rules-should-not-use-DEB_BUILD_OPTS line 10
 W: rules-general source: debian-rules-should-not-use-pwd line 10
 W: rules-general source: debian-rules-should-not-use-underscore-variable line 
11
+W: rules-general source: gzip-called-without-no-name-option line 15
+W: rules-general source: gzip-called-without-no-name-option line 16

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: Warn if debian/watch uses deprecated githubredir.debian.net scraper

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch githubredir
in repository lintian.

commit 75bbb02a367409d5a66be300ef7db09ce0d10e89
Author: Chris Lamb 
Date:   Mon Oct 26 22:04:08 2015 +

Warn if debian/watch uses deprecated githubredir.debian.net scraper

Signed-off-by: Chris Lamb 
---
 checks/watch-file.desc | 13 +
 checks/watch-file.pm   |  4 
 t/tests/watch-file-general/debian/debian/watch |  5 -
 t/tests/watch-file-general/desc|  1 +
 t/tests/watch-file-general/tags|  2 ++
 5 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/checks/watch-file.desc b/checks/watch-file.desc
index 1b66da7..1ae2a8a 100644
--- a/checks/watch-file.desc
+++ b/checks/watch-file.desc
@@ -116,6 +116,19 @@ Info: The watch file specifies a SourceForge page or 
download server
  project and  with the name of the tarball
  distributed within that project.  Adjust the filename regex as necessary.
 
+Tag: debian-watch-file-uses-deprecated-githubredir
+Severity: important
+Certainty: certain
+Ref: https://lists.debian.org/debian-devel-announce/2014/10/msg0.html
+Info: The watch file specifies a githubredir.debia.net URL, which is deprecated
+ Instead, use direct links to the tags page:
+ .
+  version=3
+  https://github.com///tags .*/(.*)\.tar\.gz
+ .
+ replacing  and  with the Github
+ username and project respectfully.
+
 Tag: debian-watch-file-specifies-wrong-upstream-version
 Severity: normal
 Certainty: certain
diff --git a/checks/watch-file.pm b/checks/watch-file.pm
index 46ab633..737c25b 100644
--- a/checks/watch-file.pm
+++ b/checks/watch-file.pm
@@ -122,6 +122,10 @@ sub run {
 if (m,\b\Qhttp://pypi.python.org/\E,) {
 tag 'debian-watch-file-accesses-pypi-over-http', "line $.";
 }
+if (m%githubredir\.debian\.net%) {
+tag 'debian-watch-file-uses-deprecated-githubredir',
+  "line $.";
+}
 
 if (
 m{ (?:https?|ftp)://
diff --git a/t/tests/watch-file-general/debian/debian/watch 
b/t/tests/watch-file-general/debian/debian/watch
index 71b4717..e322710 100644
--- a/t/tests/watch-file-general/debian/debian/watch
+++ b/t/tests/watch-file-general/debian/debian/watch
@@ -26,4 +26,7 @@ http://pypi.python.org/foo scripts\.([\d.]+)\.tar\.gz debian 
uupdate
 # Unsupported PyPI URL.
 https://pypi.python.org/packages/source/p/pip/ pip-(\S+)\.tar\.gz
 
-# without any pgpsigurlmangle
\ No newline at end of file
+# Deprecated githubredir
+http://githubredir.debian.net/github/username/project /(.*).tar.gz
+
+# without any pgpsigurlmangle
diff --git a/t/tests/watch-file-general/desc b/t/tests/watch-file-general/desc
index 64d09c9..0e7a20e 100644
--- a/t/tests/watch-file-general/desc
+++ b/t/tests/watch-file-general/desc
@@ -15,5 +15,6 @@ Test-For:
  debian-watch-file-unknown-version
  debian-watch-file-unsupported-pypi-url
  debian-watch-file-uses-deprecated-sf-redirector-method
+ debian-watch-file-uses-deprecated-githubredir
  debian-watch-may-check-gpg-signature
 References: Debian Bug#510398
diff --git a/t/tests/watch-file-general/tags b/t/tests/watch-file-general/tags
index a80f45b..1c54f22 100644
--- a/t/tests/watch-file-general/tags
+++ b/t/tests/watch-file-general/tags
@@ -1,4 +1,5 @@
 E: watch-file-general source: debian-watch-file-unsupported-pypi-url line 27
+E: watch-file-general source: debian-watch-file-uses-deprecated-githubredir 
line 30
 I: watch-file-general source: debian-watch-file-accesses-pypi-over-http line 24
 I: watch-file-general source: 
debian-watch-file-should-dversionmangle-not-uversionmangle line 5
 P: watch-file-general source: debian-watch-may-check-gpg-signature
@@ -8,6 +9,7 @@ W: watch-file-general source: 
debian-watch-file-should-mangle-version line 12
 W: watch-file-general source: debian-watch-file-should-mangle-version line 14
 W: watch-file-general source: debian-watch-file-should-mangle-version line 15
 W: watch-file-general source: debian-watch-file-should-mangle-version line 27
+W: watch-file-general source: debian-watch-file-should-mangle-version line 30
 W: watch-file-general source: debian-watch-file-should-use-sf-redirector line 
12
 W: watch-file-general source: debian-watch-file-should-use-sf-redirector line 
14
 W: watch-file-general source: debian-watch-file-should-use-sf-redirector line 
15

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/02: Factor out hard-coded list of possible upstream key locations to the "common/signing-key-filenames" Lintian::Data resource.

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch lamby/wip/upstream-signing-833585
in repository lintian.

commit 947e2278715944eee4362105c74eae793eea0a9f
Author: Chris Lamb 
Date:   Sat Jul 15 20:31:55 2017 +0100

Factor out hard-coded list of possible upstream key locations to the 
"common/signing-key-filenames" Lintian::Data resource.
---
 checks/watch-file.pm  | 7 ++-
 data/common/signing-key-filenames | 5 +
 debian/changelog  | 3 +++
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/checks/watch-file.pm b/checks/watch-file.pm
index bfa5d92..ca651f0 100644
--- a/checks/watch-file.pm
+++ b/checks/watch-file.pm
@@ -28,6 +28,7 @@ use autodie;
 use Lintian::Tags qw(tag);
 
 our $WATCH_VERSION = Lintian::Data->new('watch-file/version', qr/\s*=\s*/o);
+our $SIGNING_KEY_FILENAMES = 
Lintian::Data->new('common/signing-key-filenames');
 
 sub run {
 my (undef, undef, $info) = @_;
@@ -185,12 +186,8 @@ sub run {
 tag 'debian-watch-may-check-gpg-signature' unless ($withgpgverification);
 
 if ($withgpgverification) {
-my @key_names = (
-qw(upstream-signing-key.pgp upstream/signing-key.pgp
-  upstream/signing-key.asc)
-);
 my $found = 0;
-for my $key_name (@key_names) {
+for my $key_name ($SIGNING_KEY_FILENAMES->all) {
 my $path = $info->index_resolved_path("debian/$key_name");
 if ($path and $path->is_file) {
 $found = 1;
diff --git a/data/common/signing-key-filenames 
b/data/common/signing-key-filenames
new file mode 100644
index 000..f358063
--- /dev/null
+++ b/data/common/signing-key-filenames
@@ -0,0 +1,5 @@
+# Manually maintained list of possible upstream signing key locations
+#
+upstream-signing-key.pgp
+upstram/signing-key.pgp
+upstream/signing-key.asc
diff --git a/debian/changelog b/debian/changelog
index 1a24833..a252b91 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -60,6 +60,9 @@ lintian (2.5.52) UNRELEASED; urgency=medium
   DH_BUILD_MAINT_OPTIONS. (Closes: #833691)
   * checks/udev.{desc,pm}:
 + [NT] New check by Petter Reinholdtsen.
+  * checks/watch-file.pm:
++ [CL] Factor out hard-coded list of possible upstream key locations
+  to the "common/signing-key-filenames" Lintian::Data resource.
 
   * commands/lintian.pm:
 + [NT] Attempt to clean up on SIGTERM (like with SIGINT).

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch maint-scripts-missing-interpreter-843428 created (now 4c06631)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch maint-scripts-missing-interpreter-843428
in repository lintian.

at  4c06631   Check that maintainer scripts start with #!. (Closes: 
#843428)

This branch includes the following new commits:

   new  4c06631   Check that maintainer scripts start with #!. (Closes: 
#843428)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch lamby/wip/upstream-signing-833585 created (now 7b93b94)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch lamby/wip/upstream-signing-833585
in repository lintian.

at  7b93b94   Check for the presence of a signature if an upstream 
signing key is present. (Closes: #833585)

This branch includes the following new commits:

   new  947e227   Factor out hard-coded list of possible upstream key 
locations to the "common/signing-key-filenames" Lintian::Data resource.
   new  7b93b94   Check for the presence of a signature if an upstream 
signing key is present. (Closes: #833585)

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: .

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch lamby/wip/854134
in repository lintian.

commit 49681fd2ecdaab84cf56862a17dd133d41095df9
Author: Chris Lamb 
Date:   Mon Jul 10 16:39:56 2017 +0100

.
---
 checks/menu-format.pm | 21 +++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/checks/menu-format.pm b/checks/menu-format.pm
index 3de4490..cae21c6 100644
--- a/checks/menu-format.pm
+++ b/checks/menu-format.pm
@@ -179,6 +179,19 @@ sub run {
 }
 }
 
+# Find the icon files in the package for verification.
+my @icons;
+warn "hi";
+if (my $dir = $info->index("usr/share/icons/hicolor")) {
+   warn $dir;
+for my $file ($dir->children) {
+next unless $file->is_file;
+next unless $file->basename =~ m/\.png$/;
+   warn "saw icon $file";
+push(@icons, $file);
+}
+}
+
 # Verify all the desktop files.
 for my $desktop_file (@desktop_files) {
 verify_desktop_file($desktop_file, $pkg, $info, \%desktop_cmds);
@@ -638,9 +651,13 @@ sub verify_desktop_file {
 
 # test if missing Keywords (only if NoDisplay is not set)
 if (!defined $vals{NoDisplay}) {
-if (!defined $vals{Icon}) {
+if (defined $vals{Icon}) {
+   #warn "ICON=" . $vals{'Icon'};
+   #warn "index" . $info->index('//usr');
+#tag 'desktop-entry-lacks-icon-entry', "fooo $file $vals";
+} else {
 tag 'desktop-entry-lacks-icon-entry', $file;
-}
+   }
 if (!defined $vals{Keywords}) {
 tag 'desktop-entry-lacks-keywords-entry', $file;
 }

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: Check that maintainer scripts start with #!. (Closes: #843428)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch maint-scripts-missing-interpreter-843428
in repository lintian.

commit 4c06631753449b6baed1264932d684766597b615
Author: Chris Lamb 
Date:   Thu Jul 20 22:58:44 2017 +0100

Check that maintainer scripts start with #!. (Closes: #843428)
---
 collection/scripts  | 13 +++--
 debian/changelog|  3 +++
 .../debian/debian/postinst  |  9 +
 .../debian/debian/postrm|  7 +++
 .../scripts-does-not-start-with-shebang/debian/debian/rules |  8 
 t/tests/scripts-does-not-start-with-shebang/debian/true.c   |  5 +
 t/tests/scripts-does-not-start-with-shebang/desc|  6 ++
 t/tests/scripts-does-not-start-with-shebang/tags|  1 +
 8 files changed, 50 insertions(+), 2 deletions(-)

diff --git a/collection/scripts b/collection/scripts
index 1fabc86..f4b5fa3 100755
--- a/collection/scripts
+++ b/collection/scripts
@@ -69,8 +69,17 @@ sub collect {
 open(my $ctrl_fd, '>', "$dir/control-scripts");
 for my $path ($info->control_index('')->children) {
 next unless $path->is_open_ok;
-my $scriptpath = shebang_line($path);
-next unless defined($scriptpath);
+# Only collect maintainer scripts
+next unless $path =~ m/^(pre|post)(inst|rm)$/;
+
+# Allow ELF binaries
+my $magic;
+my $fd = $path->open;
+if (read($fd, $magic, 4)) {
+next if $magic eq "\x7FELF";
+}
+close($fd);
+my $scriptpath = shebang_line($path) // '';
 
 # Remove everything after the first space (i.e. any options)
 $scriptpath =~ s/\s++ .++ \Z//xsm;
diff --git a/debian/changelog b/debian/changelog
index e549e03..57a0633 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -82,6 +82,9 @@ lintian (2.5.52) UNRELEASED; urgency=medium
 + [CL] Factor out hard-coded list of possible upstream key locations
   to the "common/signing-key-filenames" Lintian::Data resource.
 
+  * collection/scripts:
++ [CL] Check that maintainer scripts start with #!.  (Closes: #843428)
+
   * commands/lintian.pm:
 + [NT] Attempt to clean up on SIGTERM (like with SIGINT).
 + [CL] Allow the use of suppress-tags=[,[,]] in
diff --git a/t/tests/scripts-does-not-start-with-shebang/debian/debian/postinst 
b/t/tests/scripts-does-not-start-with-shebang/debian/debian/postinst
new file mode 100644
index 000..9438152
--- /dev/null
+++ b/t/tests/scripts-does-not-start-with-shebang/debian/debian/postinst
@@ -0,0 +1,9 @@
+#!/bin/sh
+
+# This file should not be triggered by script-without-interpreter
+
+set -e
+
+true
+
+#DEBHELPER#
diff --git a/t/tests/scripts-does-not-start-with-shebang/debian/debian/postrm 
b/t/tests/scripts-does-not-start-with-shebang/debian/debian/postrm
new file mode 100644
index 000..5a2a7e7
--- /dev/null
+++ b/t/tests/scripts-does-not-start-with-shebang/debian/debian/postrm
@@ -0,0 +1,7 @@
+# This file should be triggered by script-without-interpreter
+
+set -e
+
+true
+
+#DEBHELPER#
diff --git a/t/tests/scripts-does-not-start-with-shebang/debian/debian/rules 
b/t/tests/scripts-does-not-start-with-shebang/debian/debian/rules
new file mode 100755
index 000..84ab89a
--- /dev/null
+++ b/t/tests/scripts-does-not-start-with-shebang/debian/debian/rules
@@ -0,0 +1,8 @@
+#!/usr/bin/make -f
+
+%:
+   dh $@
+
+override_dh_installdeb:
+   dh_installdeb
+   gcc -o debian/$(shell dh_listpackages)/DEBIAN/preinst true.c
diff --git a/t/tests/scripts-does-not-start-with-shebang/debian/true.c 
b/t/tests/scripts-does-not-start-with-shebang/debian/true.c
new file mode 100644
index 000..8479e67
--- /dev/null
+++ b/t/tests/scripts-does-not-start-with-shebang/debian/true.c
@@ -0,0 +1,5 @@
+int
+main(void)
+{
+return 0;
+}
diff --git a/t/tests/scripts-does-not-start-with-shebang/desc 
b/t/tests/scripts-does-not-start-with-shebang/desc
new file mode 100644
index 000..f999796
--- /dev/null
+++ b/t/tests/scripts-does-not-start-with-shebang/desc
@@ -0,0 +1,6 @@
+Testname: scripts-does-not-start-with-shebang
+Type: native
+Version: 1.0
+Description: Check for maintainer scripts that do not start with #!
+Test-For:
+ script-without-interpreter
diff --git a/t/tests/scripts-does-not-start-with-shebang/tags 
b/t/tests/scripts-does-not-start-with-shebang/tags
new file mode 100644
index 000..c93921a
--- /dev/null
+++ b/t/tests/scripts-does-not-start-with-shebang/tags
@@ -0,0 +1 @@
+E: scripts-does-not-start-with-shebang: script-without-interpreter 
control/postrm

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: Check scripts using init-functions without lsb-base Depends.

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch init.d-script-needs-depends-on-lsb-base
in repository lintian.

commit c09ecd4c2a776461d68ce9449e95169348cb79a4
Author: Chris Lamb 
Date:   Sat Oct 1 16:05:06 2016 +0100

Check scripts using init-functions without lsb-base Depends.

Emit a tag for initscripts that source the /lib/lsb/init-functions utility
functions without declaring the corresponding dependency on lsb-base
(>= 3.0-6).

Closes: #838997
Signed-off-by: Chris Lamb 
---
 checks/init.d.desc |  6 ++
 checks/init.d.pm   | 12 +++-
 .../files-bad-perm-owner/debian/debian/control.in  |  2 +-
 t/tests/init.d-general/debian/debian/control.in|  6 +-
 t/tests/init.d-lsb-depends/debian/debian/init  | 71 ++
 t/tests/init.d-lsb-depends/desc|  4 ++
 t/tests/init.d-lsb-depends/tags|  1 +
 .../init.d-lsb-headers/debian/debian/control.in| 16 ++---
 t/tests/init.d-script-registration/tags|  1 +
 t/tests/legacy-scripts/tags|  1 +
 t/tests/scripts-calls-init-script/tags |  1 +
 t/tests/systemd-general/tags   |  1 +
 12 files changed, 107 insertions(+), 15 deletions(-)

diff --git a/checks/init.d.desc b/checks/init.d.desc
index ce33ba5..5b19b3a 100644
--- a/checks/init.d.desc
+++ b/checks/init.d.desc
@@ -370,3 +370,9 @@ Info: The given init script declares a dependency on the
  totally broken.
 Ref: https://wiki.debian.org/LSBInitScripts
 
+Tag: init.d-script-needs-depends-on-lsb-base
+Severity: important
+Certainty: possible
+Info: The given init script sources the /lib/lsb/init-functions 
utility
+ functions without declaring the corresponding dependency on lsb-base
+ (>= 3.0-6).
diff --git a/checks/init.d.pm b/checks/init.d.pm
index f91afa1..7b0fa7d 100644
--- a/checks/init.d.pm
+++ b/checks/init.d.pm
@@ -198,7 +198,7 @@ sub run {
 
 # Check if file exists in package and check the script for
 # other issues if it was included in the package.
-check_init($initd_path);
+check_init($initd_path, $info);
 }
 
 return unless $initd_dir and $initd_dir->is_dir;
@@ -222,7 +222,7 @@ sub run {
 # coverage in the first pass.
 unless ($initd_postinst{$script->basename}) {
 tag $tagname, $script;
-check_init($script);
+check_init($script, $info);
 }
 }
 
@@ -230,7 +230,7 @@ sub run {
 }
 
 sub check_init {
-my ($initd_path) = @_;
+my ($initd_path, $info) = @_;
 
 # In an upstart system, such as Ubuntu, init scripts are symlinks to
 # upstart-job.  It doesn't make sense to check the syntax of upstart-job,
@@ -321,6 +321,12 @@ sub check_init {
 while ($l =~ s/^[^\#]*?(start|stop|restart|force-reload|status)//o) {
 $tag{$1} = 1;
 }
+
+if ($l =~ m{^\s*\.\s+/lib/lsb/init-functions}
+&& !$info->relation('strong')->implies('lsb-base (>= 3.0-6)')) {
+tag 'init.d-script-needs-depends-on-lsb-base',
+  $initd_path, "(line $.)";
+}
 }
 close($fd);
 
diff --git a/t/tests/files-bad-perm-owner/debian/debian/control.in 
b/t/tests/files-bad-perm-owner/debian/debian/control.in
index 0286455..60b27bc 100644
--- a/t/tests/files-bad-perm-owner/debian/debian/control.in
+++ b/t/tests/files-bad-perm-owner/debian/debian/control.in
@@ -7,7 +7,7 @@ Build-Depends: {$build_depends}
 
 Package: binary
 Architecture: all
-Depends: $\{misc:Depends\},
+Depends: $\{misc:Depends\}, lsb-base (>= 3.0-6)
 Description: {$description}
  This is a test package designed to exercise some feature or tag of
  Lintian.  It is part of the Lintian test suite and may do very odd
diff --git a/t/tests/init.d-general/debian/debian/control.in 
b/t/tests/init.d-general/debian/debian/control.in
index 7bd9f10..2b08fe1 100644
--- a/t/tests/init.d-general/debian/debian/control.in
+++ b/t/tests/init.d-general/debian/debian/control.in
@@ -7,7 +7,7 @@ Build-Depends: {$build_depends}
 
 Package: {$source}
 Architecture: {$architecture}
-Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}, lsb-base (>= 3.0-6)
 Description: {$description}
  This is a test package designed to exercise some feature or tag of
  Lintian.  It is part of the Lintian test suite and may do very odd
@@ -15,7 +15,7 @@ Description: {$description}
 
 Package: {$source}-bugs
 Architecture: {$architecture}
-Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}, lsb-base (>= 3.0-6)
 Description: {$description} -- bugs
  Test some simple bugs in the check
  .
@@ -35,7 +35,7 @@ Description: {$description} -- bad script interpreter
 
 Package: {$source}-sourcing-without-test
 Architecture: {$architecture}
-Depends: $\{shlibs:Depends\}, $\{misc:Depends\

[lintian] 02/02: Check for the presence of a signature if an upstream signing key is present. (Closes: #833585)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch lamby/wip/upstream-signing-833585
in repository lintian.

commit 7b93b9471778f2e6fe5bccdd1272f42ff9674312
Author: Chris Lamb 
Date:   Sun Jul 16 09:28:39 2017 +0100

Check for the presence of a signature if an upstream signing key is 
present. (Closes: #833585)
---
 checks/changes-file.desc   |  7 +++
 checks/changes-file.pm | 24 +-
 debian/changelog   |  3 +++
 ...nges-file-missing-upstream-signature.changes.in | 21 +++
 ...s-file-missing-upstream-signature.debian.tar.xz |  0
 .../changes-file-missing-upstream-signature.desc   |  5 +
 ...ges-file-missing-upstream-signature.orig.tar.xz |  0
 .../changes-file-missing-upstream-signature.tags   |  0
 8 files changed, 59 insertions(+), 1 deletion(-)

diff --git a/checks/changes-file.desc b/checks/changes-file.desc
index 4506ccc..48515f7 100644
--- a/checks/changes-file.desc
+++ b/checks/changes-file.desc
@@ -179,3 +179,10 @@ Info: The distribution in the Changes field 
copied from
  debian/changelog indicates that this package was not intended
  to be released yet.
 Ref: #542747
+
+Tag: orig-tarball-missing-upstream-signature
+Severity: important
+Certainty: certain
+Info: The packaging includes an upstream signing key but the corresponding
+ .asc signature for one or more source tarballs are not included
+ in your .changes file.
diff --git a/checks/changes-file.pm b/checks/changes-file.pm
index 4b56525..3b215f9 100644
--- a/checks/changes-file.pm
+++ b/checks/changes-file.pm
@@ -29,9 +29,10 @@ use Lintian::Data;
 use Lintian::Util qw(get_file_checksum);
 
 my $KNOWN_DISTS = Lintian::Data->new('changes-file/known-dists');
+my $SIGNING_KEY_FILENAMES = Lintian::Data->new('common/signing-key-filenames');
 
 sub run {
-my (undef, undef, $info) = @_;
+my (undef, undef, $info, undef, $group) = @_;
 
 # If we don't have a Format key, something went seriously wrong.
 # Tag the file and skip remaining processing.
@@ -175,12 +176,33 @@ sub run {
 check_maintainer($info->field('changed-by'), 'changed-by');
 }
 
+my $has_signing_key = 1;
+my $src = $group->get_source_processable;
+if ($src) {
+for my $key_name ($SIGNING_KEY_FILENAMES->all) {
+my $path = $src->info->index_resolved_path("debian/$key_name");
+if ($path and $path->is_file) {
+$has_signing_key = 1;
+last;
+}
+}
+}
+
 my $files = $info->files;
 my $path = readlink($info->lab_data_path('changes'));
 $path =~ s#/[^/]+$##;
 foreach my $file (keys %$files) {
 my $file_info = $files->{$file};
 
+# Ensure orig tarballs have a signature if we have an upstream
+# signature.
+if (   $has_signing_key
+&& $file =~ m/\.orig\.tar\./
+&& $file !~ m/\.asc$/
+&& not exists $files->{"$file.asc"}) {
+tag 'orig-tarball-missing-upstream-signature', "$file";
+}
+
 # check section
 if (   ($file_info->{section} eq 'non-free')
 or ($file_info->{section} eq 'contrib')) {
diff --git a/debian/changelog b/debian/changelog
index a252b91..f619c70 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -13,6 +13,9 @@ lintian (2.5.52) UNRELEASED; urgency=medium
 + [NT] Remove check for missing versioned build-depends for dpkg
   and debhlper when using Build-Profiles.  The necessary versions
   are now in oldstable.
+  * checks/changes-file.{desc,pm}:
++ [CL] Check for the presence of a signature if an upstream signing
+  key is present.  (Closes: #833585)
   * checks/copyright-file.{desc,pm}:
 + [CL] Rename copyright-contains-dh-make-perl-boilerplate to
   copyright-contains-automatically-extracted-boilerplate as it can
diff --git a/t/changes/changes-file-missing-upstream-signature.changes.in 
b/t/changes/changes-file-missing-upstream-signature.changes.in
new file mode 100644
index 000..f4d6250
--- /dev/null
+++ b/t/changes/changes-file-missing-upstream-signature.changes.in
@@ -0,0 +1,21 @@
+Format: 1.8
+Date: {$date}
+Source: {$source}
+Binary: {$source}
+Architecture: source all
+Version: {$version}
+Distribution: unstable
+Urgency: low
+Maintainer: {$author}
+Changed-By: {$author}
+Files:
+ d41d8cd98f00b204e9800998ecf8427e 0 devel optional {$source}.orig.tar.xz
+ d41d8cd98f00b204e9800998ecf8427e 0 devel optional {$source}.debian.tar.xz
+Checksums-Sha1:
+ da39a3ee5e6b4b0d3255bfef95601890afd80709 0 {$source}.orig.tar.xz
+ da39a3ee5e6b4b0d3255bfef95601890afd80709 0 {$source}.debian.tar.xz
+Checksums-Sha256:
+ e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 0 
{$source}.orig.tar.xz
+ e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 0 
{$source}.debian.tar.xz
+Description:
+ {$source} - {$descrip

[lintian] 01/01: spelling: None were -> None was.

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch none-were-over-none-was
in repository lintian.

commit eb00e28a1add9e6be590d828b8aab1f0f110a86c
Author: Chris Lamb 
Date:   Tue Apr 18 17:04:59 2017 +0100

spelling: None were -> None was.

Signed-off-by: Chris Lamb 
---
 data/spelling/corrections-multiword | 1 +
 1 file changed, 1 insertion(+)

diff --git a/data/spelling/corrections-multiword 
b/data/spelling/corrections-multiword
index 7341e05..071808a 100644
--- a/data/spelling/corrections-multiword
+++ b/data/spelling/corrections-multiword
@@ -24,3 +24,4 @@
 (?i)per say||per se
 (?i)these package||this package
 (?i)this packages||these packages
+(?i)none were||none was

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch new-package-packages-python2-module created (now 51a7a2a)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch new-package-packages-python2-module
in repository lintian.

at  51a7a2a   Add new-package-should-not-package-python2-module tag

This branch includes the following new commits:

   new  51a7a2a   Add new-package-should-not-package-python2-module tag

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: Check for packages using sensible-utils without declaring a dependency after its split from debianutils. (Closes: #872611)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch sensible-utils-872611
in repository lintian.

commit 780b3eb917dcf1d9e7e36c87892511d43c604377
Author: Chris Lamb 
Date:   Sat Aug 19 18:52:45 2017 -0700

Check for packages using sensible-utils without declaring a dependency 
after its split from debianutils. (Closes: #872611)
---
 checks/scripts.desc  | 13 +
 checks/scripts.pm| 16 
 debian/changelog |  2 ++
 .../debian/debian/install|  1 +
 .../debian/debian/postinst   |  7 +++
 .../debian/test-script   |  8 
 .../scripts-script-needs-depends-on-sensible-utils/desc  |  4 
 .../scripts-script-needs-depends-on-sensible-utils/tags  |  2 ++
 8 files changed, 53 insertions(+)

diff --git a/checks/scripts.desc b/checks/scripts.desc
index 8a5b6bb..7f7664b 100644
--- a/checks/scripts.desc
+++ b/checks/scripts.desc
@@ -752,3 +752,16 @@ Tag: elf-maintainer-script
 Severity: classification
 Certainty: certain
 Info: The maintainer script is an ELF binary.
+
+Tag: script-needs-depends-on-sensible-utils
+Severity: important
+Certainty: possible
+Info: The listed script uses one or more of the binaries in
+ sensible-utils but is missing a dependency for this package.
+ .
+ As part of the transition to split sensible-utils and
+ debianutils, the remaining Depends from
+ debianutils was removed in version 4.8.2.
+ .
+ In most cases, you will need to add a Depends on
+ sensible-utils.
diff --git a/checks/scripts.pm b/checks/scripts.pm
index d118dea..7828e85 100644
--- a/checks/scripts.pm
+++ b/checks/scripts.pm
@@ -349,6 +349,7 @@ sub run {
 if (check_script_syntax($interpreter, $path)) {
 script_tag('shell-script-fails-syntax-check', $filename);
 }
+check_script_uses_sensible_utils($path);
 }
 }
 
@@ -614,6 +615,7 @@ sub run {
 if (check_script_syntax("/bin/${base}", $path)) {
 tag 'maintainer-shell-script-fails-syntax-check', $file;
 }
+check_script_uses_sensible_utils($path);
 }
 }
 
@@ -1267,6 +1269,20 @@ sub check_script_syntax {
 return $?;
 }
 
+sub check_script_uses_sensible_utils {
+my ($path) = @_;
+my $fd = $path->open;
+while (<$fd>) {
+if (m/${LEADIN}(?:select-editor|sensible-(?:browser|editor|pager))\b/){
+tag 'script-needs-depends-on-sensible-utils',
+  $path->name, "(line $.)";
+last;
+}
+}
+close($fd);
+return;
+}
+
 sub remove_comments {
 local $_;
 
diff --git a/debian/changelog b/debian/changelog
index 64dbc0f..b70d933 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -64,6 +64,8 @@ lintian (2.5.53) UNRELEASED; urgency=medium
   valid shell prefix.  (Closes: #869587)
 + [CL] Check for missing calls to dpkg-maintscript-helper(1) in
   maintainer scripts.  (Closes: #872042)
++ [CL] Check for packages using sensible-utils without declaring a
+  dependency after its split from debianutils.  (Closes: #872611)
   * checks/testsuite.{desc,pm}:
 + [CL] Remove recommendations to add a "Testsuite: autopkgtest" field
   to debian/control as it is added when needed by dpkg-source(1)
diff --git 
a/t/tests/scripts-script-needs-depends-on-sensible-utils/debian/debian/install 
b/t/tests/scripts-script-needs-depends-on-sensible-utils/debian/debian/install
new file mode 100644
index 000..4c88597
--- /dev/null
+++ 
b/t/tests/scripts-script-needs-depends-on-sensible-utils/debian/debian/install
@@ -0,0 +1 @@
+test-script var/lib/test
diff --git 
a/t/tests/scripts-script-needs-depends-on-sensible-utils/debian/debian/postinst 
b/t/tests/scripts-script-needs-depends-on-sensible-utils/debian/debian/postinst
new file mode 100644
index 000..f369cc0
--- /dev/null
+++ 
b/t/tests/scripts-script-needs-depends-on-sensible-utils/debian/debian/postinst
@@ -0,0 +1,7 @@
+#!/bin/sh
+
+set -e
+
+sensible-pager
+
+#DEBHELPER#
diff --git 
a/t/tests/scripts-script-needs-depends-on-sensible-utils/debian/test-script 
b/t/tests/scripts-script-needs-depends-on-sensible-utils/debian/test-script
new file mode 100755
index 000..f0a46b2
--- /dev/null
+++ b/t/tests/scripts-script-needs-depends-on-sensible-utils/debian/test-script
@@ -0,0 +1,8 @@
+#!/bin/sh
+
+sensible-editor
+
+# sensible-pager false positive
+
+# Only report on the first match
+select-editor
diff --git a/t/tests/scripts-script-needs-depends-on-sensible-utils/desc 
b/t/tests/scripts-script-needs-depends-on-sensible-utils/desc
new file mode 100644
index 000..50a4c14
--- /dev/null
+++ b/t/tests/scripts-script-needs-depends-on-sensible-utils/desc
@@ -0,0 +1,4 @@
+Testname: scripts-scr

[lintian] branch sensible-utils-872611 created (now 780b3eb)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch sensible-utils-872611
in repository lintian.

at  780b3eb   Check for packages using sensible-utils without declaring 
a dependency after its split from debianutils. (Closes: #872611)

This branch includes the following new commits:

   new  780b3eb   Check for packages using sensible-utils without declaring 
a dependency after its split from debianutils. (Closes: #872611)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: Add new-package-should-not-package-python2-module tag

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch new-package-packages-python2-module
in repository lintian.

commit 51a7a2a34804af18c1a103f87c2a482372200e1b
Author: Chris Lamb 
Date:   Tue Jul 5 20:14:00 2016 +0200

Add new-package-should-not-package-python2-module tag

The 2.x series of Python is due for deprecation and will not be maintained
past 2020 so it is recommended that Python 2 modules are not packaged
unless necessary.

Signed-off-by: Chris Lamb 
---
 checks/scripts.desc  | 13 +
 checks/scripts.pm|  7 +++
 t/tests/scripts-python2/debian/debian/control.in | 15 +++
 t/tests/scripts-python2/desc |  8 
 t/tests/scripts-python2/tags |  1 +
 5 files changed, 44 insertions(+)

diff --git a/checks/scripts.desc b/checks/scripts.desc
index 12a642b..87a0c29 100644
--- a/checks/scripts.desc
+++ b/checks/scripts.desc
@@ -752,3 +752,16 @@ Severity: classification
 Certainty: possible
 Info: The maintainer scripts of the package one or more auto-generated
  shell snippets inserted by the listed debhelper tool.
+
+Tag: new-package-should-not-package-python2-module
+Severity: wishlist
+Certainty: certain
+Info: This package appears to be the first packaging of a new upstream
+ software package but it appears to package a module for Python 2.
+ .
+ The 2.x series of Python is due for deprecation and will not be maintained
+ past 2020 so it is recommended that Python 2 modules are not packaged unless
+ necessary.
+ .
+ This warning can be ignored if the package is not intended for Debian or
+ if it is a split of an existing Debian package.
diff --git a/checks/scripts.pm b/checks/scripts.pm
index 5959e95..de4fcd7 100644
--- a/checks/scripts.pm
+++ b/checks/scripts.pm
@@ -1103,6 +1103,13 @@ sub run {
 }
 }
 
+my @entries = $info->changelog->data;
+
+if (@entries == 1) {
+  tag 'new-package-should-not-package-python2-module', $pkg
+if $pkg =~ /^python-/
+}
+
 return;
 }
 
diff --git a/t/tests/scripts-python2/debian/debian/control.in 
b/t/tests/scripts-python2/debian/debian/control.in
new file mode 100644
index 000..993dee7
--- /dev/null
+++ b/t/tests/scripts-python2/debian/debian/control.in
@@ -0,0 +1,15 @@
+Source: {$source}
+Priority: extra
+Section: python
+Maintainer: {$author}
+Standards-Version: {$standards_version}
+Build-Depends: debhelper (>= 9)
+
+Package: python-{$source}
+Architecture: all
+Depends: $\{misc:Depends\}, python2.7
+Description: {$description}
+ This is a test package designed to exercise some feature or tag of
+ Lintian.  It is part of the Lintian test suite and may do very odd
+ things.  It should not be installed like a regular package.  It may
+ be an empty package.
diff --git a/t/tests/scripts-python2/desc b/t/tests/scripts-python2/desc
new file mode 100644
index 000..56dba16
--- /dev/null
+++ b/t/tests/scripts-python2/desc
@@ -0,0 +1,8 @@
+Testname: scripts-python2
+Sequence: 6000
+Version: 1.0
+Description: Check various Python 2 issues
+Skeleton: pedantic
+Options: --pedantic -I -E
+Test-For:
+ new-package-should-not-package-python2-module
diff --git a/t/tests/scripts-python2/tags b/t/tests/scripts-python2/tags
new file mode 100644
index 000..685f534
--- /dev/null
+++ b/t/tests/scripts-python2/tags
@@ -0,0 +1 @@
+I: python-scripts-python2: new-package-should-not-package-python2-module 
python-scripts-python2

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch sl2 created (now e24e54d)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch sl2
in repository lintian.

at  e24e54d   Detect bad flag in pkg-config

This branch includes the following new commits:

   new  5d74221   Prepare detection of arch problem in pkg-config
   new  4b430e0   Detect cross architecture pkg-config
   new  08a105f   Add changelog for previous commit
   new  e24e54d   Detect bad flag in pkg-config

The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch service-files-missing-install-key-false-positives created (now b380c64)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch 
service-files-missing-install-key-false-positives
in repository lintian.

at  b380c64   c/systemd: Don't emit 
systemd-service-file-missing-install-key for Type=oneshot.

This branch includes the following new commits:

   new  7866432   c/systemd: Reduce certainty of 
systemd-service-file-missing-install-key.
   new  7c6c8b1   c/systemd.pm: Don't emit 
systemd-service-file-missing-install-key for "template" .service files.
   new  b4584f2   c/systemd: Don't emit 
systemd-service-file-missing-install-key if it contain an "Also=" section.
   new  b380c64   c/systemd: Don't emit 
systemd-service-file-missing-install-key for Type=oneshot.

The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch none-were-over-none-was created (now eb00e28)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch none-were-over-none-was
in repository lintian.

at  eb00e28   spelling: None were -> None was.

This branch includes the following new commits:

   new  eb00e28   spelling: None were -> None was.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: Check for PACKAGE.maintscript files that include "maint-script-parameters".

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch maintscript
in repository lintian.

commit 20b477392929dc2838a302386598f34ed3361a7c
Author: Chris Lamb 
Date:   Sun Sep 18 23:26:02 2016 +0100

Check for PACKAGE.maintscript files that include "maint-script-parameters".
---
 checks/debhelper.desc  |  8 
 checks/debhelper.pm| 10 ++
 .../debian/debian/maintscript  |  4 
 t/tests/maintscript-includes-maint-script-parameters/desc  |  6 ++
 t/tests/maintscript-includes-maint-script-parameters/tags  |  3 +++
 5 files changed, 31 insertions(+)

diff --git a/checks/debhelper.desc b/checks/debhelper.desc
index 9b9d046..3317d56 100644
--- a/checks/debhelper.desc
+++ b/checks/debhelper.desc
@@ -361,3 +361,11 @@ Info: The listed target in debian/rules command is a 
likely misspelling.
  Implementation detail: The typo is detected by using "Levenshtein
  edit distance".  Therefore, if the typo involve several characters,
  Lintian may not detect it.
+
+Tag: maintscript-includes-maint-script-parameters
+Severity: normal
+Certainty: possible
+Info: Lines in a debian/*.maintscript correspond to
+  dpkg-maintscript-helper(1) commands and parameters.  However, the
+  "maint-script-parameters" should not be included as debhelper will add those
+  automatically. See dh_installdeb(1) for more information.
diff --git a/checks/debhelper.pm b/checks/debhelper.pm
index ad80fc8..6cbfb58 100644
--- a/checks/debhelper.pm
+++ b/checks/debhelper.pm
@@ -354,6 +354,16 @@ sub run {
 _tag_if_executable($file);
 } elsif ($basename =~ m/^ex\.|\.ex$/i) {
 tag 'dh-make-template-in-source', $file;
+} elsif ($basename =~ m/^(?:(.*)\.)?maintscript$/) {
+next unless $file->is_open_ok;
+my $fd = $file->open;
+while (<$fd>) {
+if (m/--\s+"\$(?:@|{@})"\s*$/) {
+tag 'maintscript-includes-maint-script-parameters',
+$basename, "(line $.)";
+}
+}
+close($fd);
 } elsif ($basename =~ m/^(?:.+\.)?debhelper(?:\.log)?$/){
 # The regex matches "debhelper", but debhelper/Dh_Lib does not
 # make those, so skip it.
diff --git 
a/t/tests/maintscript-includes-maint-script-parameters/debian/debian/maintscript
 
b/t/tests/maintscript-includes-maint-script-parameters/debian/debian/maintscript
new file mode 100644
index 000..6a583d7
--- /dev/null
+++ 
b/t/tests/maintscript-includes-maint-script-parameters/debian/debian/maintscript
@@ -0,0 +1,4 @@
+rm_conffile /etc/correct.conf 0.2~ foo
+rm_conffile /etc/incorrect.conf 0.2~ foo -- "$@"
+rm_conffile /etc/incorrect.conf 0.2~ foo -- "${@}"
+rm_conffile /etc/incorrect.conf 0.2~ foo  --  "$@" 
diff --git a/t/tests/maintscript-includes-maint-script-parameters/desc 
b/t/tests/maintscript-includes-maint-script-parameters/desc
new file mode 100644
index 000..0313ac0
--- /dev/null
+++ b/t/tests/maintscript-includes-maint-script-parameters/desc
@@ -0,0 +1,6 @@
+Testname: maintscript-includes-maint-script-parameters
+Sequence: 6000
+Version: 1.0
+Description: Check for dh_installdeb .maintscript files
+Test-For:
+ maintscript-includes-maint-script-parameters
diff --git a/t/tests/maintscript-includes-maint-script-parameters/tags 
b/t/tests/maintscript-includes-maint-script-parameters/tags
new file mode 100644
index 000..088f8c3
--- /dev/null
+++ b/t/tests/maintscript-includes-maint-script-parameters/tags
@@ -0,0 +1,3 @@
+W: maintscript-includes-maint-script-parameters source: 
maintscript-includes-maint-script-parameters maintscript (line 2)
+W: maintscript-includes-maint-script-parameters source: 
maintscript-includes-maint-script-parameters maintscript (line 3)
+W: maintscript-includes-maint-script-parameters source: 
maintscript-includes-maint-script-parameters maintscript (line 4)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 02/04: Detect cross architecture pkg-config

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch sl2
in repository lintian.

commit 4b430e0122631bb90dcb1bccbadf0aae36a0fb02
Author: Bastien ROUCARIÈS 
Date:   Sat Jul 5 12:08:03 2014 +0200

Detect cross architecture pkg-config

Cross architecture pkg-config file are not acceptable. Warn about it.

Signed-off-by: Bastien ROUCARIÈS 
---
 checks/files.desc   |  5 +
 checks/files.pm | 21 +++--
 .../debian/generated/arch-include-arch.pc.in|  6 ++
 t/tests/files-pkgconfig/post_test   |  1 +
 t/tests/files-pkgconfig/tags|  3 ++-
 5 files changed, 29 insertions(+), 7 deletions(-)

diff --git a/checks/files.desc b/checks/files.desc
index f9df988..a77c94c 100644
--- a/checks/files.desc
+++ b/checks/files.desc
@@ -1499,6 +1499,11 @@ Info: The arch all pkg-config file contains a reference 
to a multi-arch path.
  Another likely cause is using debhelper 9 or newer (thus enabling
  multi-arch paths by default) on a package without multi-arch support.
  The usual cure in this case is to update it for multi-arch.
+ .
+ Last but not least, this file could contains a reference to a cross
+ architecture. Like for instance a x86_64-linux-gnu pkg-config file
+ referencing a i386-linux-gnu file. In this case the usual cure is to
+ fix this path.
 
 Tag: dir-or-file-in-home
 Severity: serious
diff --git a/checks/files.pm b/checks/files.pm
index b723c7a..35b0e40 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -571,26 +571,35 @@ sub run {
 }
 #  arch-indep pkconfig
 elsif ($file->is_regular_file
-&& $fname =~ m,^usr/(?:lib|share)/pkgconfig/[^/]+\.pc$,) {
+&& $fname
+=~ m,^usr/(?:lib(/[^/]+)?|share)/pkgconfig/[^/]+\.pc$,) {
+my $pkg_config_arch = $1 // '';
+$pkg_config_arch =~ s,\A/,,ms;
+
 open(my $fd, '<:raw', $info->unpacked($file));
 my $sfd = Lintian::SlidingWindow->new($fd);
-
   BLOCK:
 while (my $block = $sfd->readwindow()) {
 # check if pkgconfig file include path point to
 # arch specific dir
+  MULTI_ARCH_DIR:
 foreach my $multiarch_dir ($MULTIARCH_DIRS->all) {
-my $regex
-  = $MULTIARCH_DIRS->value($multiarch_dir)->{'match'};
+my $value =  $MULTIARCH_DIRS->value($multiarch_dir);
+my $pkgconfig_dir = $value->{'dir'};
+my $regex = $value->{'match'};
+if ($pkg_config_arch eq $pkgconfig_dir) {
+next MULTI_ARCH_DIR;
+}
 if ($block =~ m{$regex}) {
-tag 'pkg-config-multi-arch-wrong-dir',$file;
+tag 'pkg-config-multi-arch-wrong-dir',$file,
+  'full text contains architecture specific dir',
+  $pkgconfig_dir;
 last BLOCK;
 }
 }
 }
 close($fd);
 }
-   
 
 #- /usr/X11R6/
 # links to FHS locations are allowed
diff --git a/t/tests/files-pkgconfig/debian/generated/arch-include-arch.pc.in 
b/t/tests/files-pkgconfig/debian/generated/arch-include-arch.pc.in
new file mode 100644
index 000..f857bd8
--- /dev/null
+++ b/t/tests/files-pkgconfig/debian/generated/arch-include-arch.pc.in
@@ -0,0 +1,6 @@
+Name: arch-include-arch
+Description: A library that include some arch dir
+Requires:
+Version: 3.1.3
+Libs:
+Cflags: -I/usr/include/$(ARCH)/arch-include-arch
diff --git a/t/tests/files-pkgconfig/post_test 
b/t/tests/files-pkgconfig/post_test
new file mode 100644
index 000..6c64c5e
--- /dev/null
+++ b/t/tests/files-pkgconfig/post_test
@@ -0,0 +1 @@
+s/full text contains architecture specific dir \S+$/full text contains 
architecture specific dir ARCH/
diff --git a/t/tests/files-pkgconfig/tags b/t/tests/files-pkgconfig/tags
index 0df537c..a3933e9 100644
--- a/t/tests/files-pkgconfig/tags
+++ b/t/tests/files-pkgconfig/tags
@@ -1 +1,2 @@
-E: pkgconfig-all: pkg-config-multi-arch-wrong-dir 
usr/lib/pkgconfig/indep-include-arch.pc
+E: pkgconfig-all: pkg-config-multi-arch-wrong-dir 
usr/lib/pkgconfig/indep-include-arch.pc full text contains architecture 
specific dir ARCH
+E: pkgconfig-any: pkg-config-multi-arch-wrong-dir 
usr/lib/x86_64-linux-gnu/pkgconfig/arch-cross.pc full text contains 
architecture specific dir ARCH

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 03/04: Add changelog for previous commit

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch sl2
in repository lintian.

commit 08a105fd1f73d0675af98fa656a0993600565c0e
Author: Bastien ROUCARIÈS 
Date:   Sat Jul 5 12:20:19 2014 +0200

Add changelog for previous commit

Detect cross architecture pkg-config file.

Signed-off-by: Bastien ROUCARIÈS 
---
 debian/changelog | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/changelog b/debian/changelog
index 5f97401..fc98097 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -11,6 +11,7 @@ lintian (2.5.25) UNRELEASED; urgency=medium
   * checks/files.{desc,pm}:
 + [RG,NT] Check for invalid named p11-kit modules in
   /usr/share/p11-kit modules.  (Closes: #741346)
++ [BR] Detect cross architecture pkg-config file.
 
   * data/files/js-libraries:
 + [NT] Apply patch from Marcelo Jorge Vieira to correct

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: WIP: Add init.d-script-needs-depends-on-lsb-base-for-status-of-proc tag.

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch stricter-lsb-base-depends-839861
in repository lintian.

commit 0828c266ac77239fffe25e6bfe473603a4dfbad1
Author: Chris Lamb 
Date:   Sun Oct 9 12:35:42 2016 +0100

WIP: Add init.d-script-needs-depends-on-lsb-base-for-status-of-proc tag.
---
 checks/init.d.desc  |  7 +++
 checks/init.d.pm| 11 +--
 t/tests/init.d-lsb-depends/desc |  4 +++-
 t/tests/init.d-lsb-depends/tags |  1 +
 4 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/checks/init.d.desc b/checks/init.d.desc
index 5b19b3a..06bb64b 100644
--- a/checks/init.d.desc
+++ b/checks/init.d.desc
@@ -376,3 +376,10 @@ Certainty: possible
 Info: The given init script sources the /lib/lsb/init-functions 
utility
  functions without declaring the corresponding dependency on lsb-base
  (>= 3.0-6).
+
+Tag: init.d-script-needs-depends-on-lsb-base-for-status-of-proc
+Severity: important
+Certainty: possible
+Info: The given init script uses the status_of_proc utility from
+ /lib/lsb/init-functions utility functions without declaring the
+ corresponding dependency on lsb-base (>= 3.2-13).
diff --git a/checks/init.d.pm b/checks/init.d.pm
index 7b0fa7d..b3fa827 100644
--- a/checks/init.d.pm
+++ b/checks/init.d.pm
@@ -318,8 +318,10 @@ sub check_init {
 $needs_fs{'remote'} = 1 if ($l =~ m,^[^\#]*/usr/,);
 $needs_fs{'local'}  = 1 if ($l =~ m,^[^\#]*/var/,);
 
-while ($l =~ s/^[^\#]*?(start|stop|restart|force-reload|status)//o) {
-$tag{$1} = 1;
+if ($l =~ m{^[^\#]*?status_of_proc}
+&& !$info->relation('strong')->implies('lsb-base (>= 3.2-13)')) {
+tag 'init.d-script-needs-depends-on-lsb-base-for-status-of-proc',
+  $initd_path, "(line $.)";
 }
 
 if ($l =~ m{^\s*\.\s+/lib/lsb/init-functions}
@@ -327,6 +329,11 @@ sub check_init {
 tag 'init.d-script-needs-depends-on-lsb-base',
   $initd_path, "(line $.)";
 }
+
+# Modify $l as late as possible in loop
+while ($l =~ s/^[^\#]*?(start|stop|restart|force-reload|status)//o) {
+$tag{$1} = 1;
+}
 }
 close($fd);
 
diff --git a/t/tests/init.d-lsb-depends/desc b/t/tests/init.d-lsb-depends/desc
index e0f6565..4aa74fb 100644
--- a/t/tests/init.d-lsb-depends/desc
+++ b/t/tests/init.d-lsb-depends/desc
@@ -1,4 +1,6 @@
 Testname: init.d-lsb-depends
 Version: 1.0
 Description: Test for packages missing dependencies on lsb-base
-Test-For: init.d-script-needs-depends-on-lsb-base
+Test-For:
+ init.d-script-needs-depends-on-lsb-base
+ init.d-script-needs-depends-on-lsb-base-for-status-of-proc
diff --git a/t/tests/init.d-lsb-depends/tags b/t/tests/init.d-lsb-depends/tags
index 21e92fd..9d521ef 100644
--- a/t/tests/init.d-lsb-depends/tags
+++ b/t/tests/init.d-lsb-depends/tags
@@ -1 +1,2 @@
 E: init.d-lsb-depends: init.d-script-needs-depends-on-lsb-base 
etc/init.d/init.d-lsb-depends (line 30)
+E: init.d-lsb-depends: 
init.d-script-needs-depends-on-lsb-base-for-status-of-proc 
etc/init.d/init.d-lsb-depends (line 62)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch stricter-lsb-base-depends-839861 created (now 0828c26)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch stricter-lsb-base-depends-839861
in repository lintian.

at  0828c26   WIP: Add 
init.d-script-needs-depends-on-lsb-base-for-status-of-proc tag.

This branch includes the following new commits:

   new  0828c26   WIP: Add 
init.d-script-needs-depends-on-lsb-base-for-status-of-proc tag.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch maintscript created (now 20b4773)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch maintscript
in repository lintian.

at  20b4773   Check for PACKAGE.maintscript files that include 
"maint-script-parameters".

This branch includes the following new commits:

   new  20b4773   Check for PACKAGE.maintscript files that include 
"maint-script-parameters".

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: c/rules: Check for unnecessary SOURCE_DATE_EPOCH assignments

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch source-date-epoch-exported-by-dpkg
in repository lintian.

commit 3b10f7dbaecedb0a458c25cc0b8615b489d424af
Author: Chris Lamb 
Date:   Fri Jul 22 10:54:02 2016 +0100

c/rules: Check for unnecessary SOURCE_DATE_EPOCH assignments

As of dpkg 1.18.8, this is no longer necessary as dpkg exports this
variable if it is not already set (#75). This should encourage
removing some duplicated code from a lot of our rules files.

Signed-off-by: Chris Lamb 
---
 checks/rules.desc | 8 
 checks/rules.pm   | 2 ++
 t/tests/rules-general/debian/debian/rules | 2 ++
 t/tests/rules-general/desc| 3 ++-
 t/tests/rules-general/tags| 7 ---
 5 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/checks/rules.desc b/checks/rules.desc
index 25c565b..13bf4c2 100644
--- a/checks/rules.desc
+++ b/checks/rules.desc
@@ -248,3 +248,11 @@ Info: The source package does not have both a build-arch 
and a build-indep
  .
  Please consider adding both the build-arch and build-indep targets.
 
+Tag: unnecessary-source-date-epoch-assignment
+Severity: normal
+Certainty: certain
+Info: There is an assignment to a SOURCE_DATE_EPOCH variable in the
+  debian/rules file.  As of dpkg 1.18.8, this is no longer necessary
+  as dpkg exports this variable if it is not already set.
+  .
+  Consider removing this assignment.
diff --git a/checks/rules.pm b/checks/rules.pm
index bd3a141..ce77909 100644
--- a/checks/rules.pm
+++ b/checks/rules.pm
@@ -226,6 +226,8 @@ sub run {
 # rather well.
 my ($var, $value) = ($1, $2);
 $variables{$var} = $value;
+tag 'unnecessary-source-date-epoch-assignment', "line $."
+if $var eq "SOURCE_DATE_EPOCH";
 }
 
 # Keep track of whether this portion of debian/rules may be optional
diff --git a/t/tests/rules-general/debian/debian/rules 
b/t/tests/rules-general/debian/debian/rules
index cddbc03..121305a 100755
--- a/t/tests/rules-general/debian/debian/rules
+++ b/t/tests/rules-general/debian/debian/rules
@@ -2,6 +2,8 @@
 
 DEB_AUTO_UPDATE_DEBIAN_CONTROL = yes
 
+export SOURCE_DATE_EPOCH = $(shell date -d "$$(dpkg-parsechangelog -SDate)" 
+%s)
+
 %:
dh $@
 
diff --git a/t/tests/rules-general/desc b/t/tests/rules-general/desc
index 1f41c20..cab329e 100644
--- a/t/tests/rules-general/desc
+++ b/t/tests/rules-general/desc
@@ -7,4 +7,5 @@ Test-For:
  debian-rules-should-not-automatically-update-control
  debian-rules-should-not-use-DEB_BUILD_OPTS
  debian-rules-should-not-use-pwd
- debian-rules-should-not-use-underscore-variable
\ No newline at end of file
+ debian-rules-should-not-use-underscore-variable
+ unnecessary-source-date-epoch-assignment
diff --git a/t/tests/rules-general/tags b/t/tests/rules-general/tags
index 3e7351b..6675064 100644
--- a/t/tests/rules-general/tags
+++ b/t/tests/rules-general/tags
@@ -1,5 +1,6 @@
 E: rules-general source: clean-should-be-satisfied-by-build-depends debhelper
 E: rules-general source: debian-rules-should-not-automatically-update-control 
line 3
-W: rules-general source: debian-rules-should-not-use-DEB_BUILD_OPTS line 10
-W: rules-general source: debian-rules-should-not-use-pwd line 10
-W: rules-general source: debian-rules-should-not-use-underscore-variable line 
11
+W: rules-general source: debian-rules-should-not-use-DEB_BUILD_OPTS line 12
+W: rules-general source: debian-rules-should-not-use-pwd line 12
+W: rules-general source: debian-rules-should-not-use-underscore-variable line 
13
+W: rules-general source: unnecessary-source-date-epoch-assignment line 5

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 04/04: Detect bad flag in pkg-config

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch sl2
in repository lintian.

commit e24e54de93bf46708337dac7d21c899d8bcd863f
Author: Bastien ROUCARIÈS 
Date:   Sat Jul 5 13:55:38 2014 +0200

Detect bad flag in pkg-config

Bad flag in pkg-config could lead to FTBFS. Detect it.

Signed-off-by: Bastien ROUCARIÈS 
---
 checks/files.desc  |  8 +
 checks/files.pm| 17 ++-
 data/files/pkg-config-bad-regex| 35 ++
 debian/changelog   |  2 ++
 t/tests/files-pkgconfig/debian/indep-really-bad.pc | 29 ++
 t/tests/files-pkgconfig/tags   | 20 +
 6 files changed, 110 insertions(+), 1 deletion(-)

diff --git a/checks/files.desc b/checks/files.desc
index a77c94c..dd9a9ee 100644
--- a/checks/files.desc
+++ b/checks/files.desc
@@ -1505,6 +1505,14 @@ Info: The arch all pkg-config file contains a reference 
to a multi-arch path.
  referencing a i386-linux-gnu file. In this case the usual cure is to
  fix this path.
 
+Tag: pkg-config-bad-directive
+Severity: serious
+Certainty: possible
+Info: The pkg-config file contains a wrong directive.
+ .
+ The following file include a wrong directive. This could lead to
+ FTBFS or leak private compile flags to another package.
+
 Tag: dir-or-file-in-home
 Severity: serious
 Certainty: certain
diff --git a/checks/files.pm b/checks/files.pm
index 35b0e40..bf88c15 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -74,6 +74,10 @@ my $PRIVACY_BREAKER_TAG_ATTR= Lintian::Data->new(
 };
 });
 
+my $PKG_CONFIG_BAD_REGEX
+  = Lintian::Data->new('files/pkg-config-bad-regex',qr/~/,
+sub { return  qr/$_[0]/xsm;});
+
 my $COMPRESS_FILE_EXTENSIONS
   = Lintian::Data->new('files/compressed-file-extensions',
 qr/\s++/,sub { return qr/\Q$_[0]\E/ });
@@ -580,6 +584,8 @@ sub run {
 my $sfd = Lintian::SlidingWindow->new($fd);
   BLOCK:
 while (my $block = $sfd->readwindow()) {
+# remove continuation line
+$block =~ s,\\\n, ,gxsm;
 # check if pkgconfig file include path point to
 # arch specific dir
   MULTI_ARCH_DIR:
@@ -594,7 +600,16 @@ sub run {
 tag 'pkg-config-multi-arch-wrong-dir',$file,
   'full text contains architecture specific dir',
   $pkgconfig_dir;
-last BLOCK;
+last MULTI_ARCH_DIR;
+}
+}
+  PKG_CONFIG_TABOO:
+foreach my $taboo ($PKG_CONFIG_BAD_REGEX->all) {
+my $regex = $PKG_CONFIG_BAD_REGEX->value($taboo);
+if ($block =~ m{$regex}xms) {
+my $extra = $1 // '';
+$extra =~ s/\s+/ /g;
+tag 'pkg-config-bad-directive', $file, $extra;
 }
 }
 }
diff --git a/data/files/pkg-config-bad-regex b/data/files/pkg-config-bad-regex
new file mode 100644
index 000..e1bf596
--- /dev/null
+++ b/data/files/pkg-config-bad-regex
@@ -0,0 +1,35 @@
+# a list of pkg-config bad contruction
+# regex (xms)
+# found in omnithread3.pc
+^(?:[^:]*flags\h*:|[^=]*FLAGS\h*=) (?:\V*\h)? (-[DU]__linux__) \s
+^(?:[^:]*flags\h*:|[^=]*FLAGS\h*=) (?:\V*\h)? (-[DU]__x86_64__) \s
+^(?:[^:]*flags\h*:|[^=]*FLAGS\h*=) (?:\V*\h)? (-D__OSVERSION__=\d+) \s
+# found in znc.pc
+^(?:[^:]*flags\h*:|[^=]*FLAGS\h*=) (?:\V*\h)? (-g\d*) \s
+^(?:[^:]*flags\h*:|[^=]*FLAGS\h*=) (?:\V*\h)? (-D_FORTIFY_SOURCE=\d+) \s
+^(?:[^:]*flags\h*:|[^=]*FLAGS\h*=) (?:\V*\h)? (-O[s0-9]) \s
+^(?:[^:]*flags\h*:|[^=]*FLAGS\h*=) (?:\V*\h)? (-W\S*) \s
+^(?:[^:]*flags\h*:|[^=]*FLAGS\h*=) (?:\V*\h)? (-fvisibility=\w+) \s
+^(?:[^:]*flags\h*:|[^=]*FLAGS\h*=) (?:\V*\h)? (-fPI[CE]) \s
+# found in dolfin.pc
+^(?:[^:]*flags\h*:|[^=]*FLAGS\h*=) (?:\V*\h)? (-f(?:no-)?stack-protector) \s
+^(?:[^:]*flags\h*:|[^=]*FLAGS\h*=) (?:\V*\h)? (--param=ssp-buffer-size=\d+) \s
+^(?:[^:]*flags\h*:|[^=]*FLAGS\h*=) (?:\V*\h)? (-f(?:no-)?rounding-math) \s
+# found in clam_core.pc
+[:=\h](-[IL](?:/usr/local/|/var/cache/pbuilder/build/|/var/lib/s?buildd?/)\S*)\s
+# found in scilab.pc
+^((?:[cC]flags\h*:|CFLAGS\h*=) (?:\V*\h)? -l\S+) \s
+# found meep.pc
+^(?:[^:]*flags\h*:|[^=]*FLAGS\h*=) (?:\V*\h)? (-march=\S+) \s
+# found opensaml.pc
+^(?:[^:]*flags\h*:|[^=]*FLAGS\h*=) (?:\V*\h)? (-[DU]NDEBUG) \s
+# found in libspatialindex.pc
+^(?:[^:]*flags\h*:|[^=]*FLAGS\h*=) (?:\V*\h)? (-pedantic) \s
+# found in common-cpp.pc
+^(?:[^:]*flags\h*:|[^=]*FLAGS\h*=) (?:\V*\h)? (-[DU]NEW_STDCPP) \s
+^(?:[^:]*flags\h*:|[^=]*FLAGS\h*=) (?:\V*\h)? (-f(?:no-)?check-new) \s
+^(?:[^:]*flag

[lintian] branch typos-in-debhelper-commands created (now 65b0ea6)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch typos-in-debhelper-commands
in repository lintian.

at  65b0ea6   c/rules: Check for common typos in debian/rules target 
names.

This branch includes the following new commits:

   new  65b0ea6   c/rules: Check for common typos in debian/rules target 
names.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/04: Prepare detection of arch problem in pkg-config

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch sl2
in repository lintian.

commit 5d74221d77a4e330d37efa26c953f64190aff8fd
Author: Bastien ROUCARIÈS 
Date:   Sat Jul 5 11:30:53 2014 +0200

Prepare detection of arch problem in pkg-config

Generate cross arch pkg-config

Signed-off-by: Bastien ROUCARIÈS 
---
 t/tests/files-pkgconfig/debian/Makefile   | 7 ++-
 t/tests/files-pkgconfig/debian/generated/arch-cross.pc.in | 6 ++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/t/tests/files-pkgconfig/debian/Makefile 
b/t/tests/files-pkgconfig/debian/Makefile
index ca9f8c3..796e1bc 100644
--- a/t/tests/files-pkgconfig/debian/Makefile
+++ b/t/tests/files-pkgconfig/debian/Makefile
@@ -1,7 +1,12 @@
 ARCH=$(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
+ifeq ($(ARCH), x86_64-linux-gnu)
+ ARCH_CROSS=i386-linux-gnu
+else
+ ARCH_CROSS=x86_64-linux-gnu
+endif
 
 all:
-   find generated -name '*.pc.in' -exec sh -c 'echo "build" {} && sed 
s/\$$\(ARCH\)/$(ARCH)/ {} > `echo {} | sed s/\.pc\.in$$/\.pc/g`' \;
+   find generated -name '*.pc.in' -exec sh -c 'echo "build" {} && cat {} | 
sed s/\$$\(ARCH\)/$(ARCH)/g | sed s/\$$\(ARCH_CROSS\)/$(ARCH_CROSS)/g > `echo 
{} | sed s/\.pc\.in$$/\.pc/g`' \;
 
 install:
install -d $(DESTDIR)/usr/lib/pkgconfig/
diff --git a/t/tests/files-pkgconfig/debian/generated/arch-cross.pc.in 
b/t/tests/files-pkgconfig/debian/generated/arch-cross.pc.in
new file mode 100644
index 000..452d3a2
--- /dev/null
+++ b/t/tests/files-pkgconfig/debian/generated/arch-cross.pc.in
@@ -0,0 +1,6 @@
+Name: arch-cross
+Description: A library that include cross architecture
+Requires:
+Version: 3.1.3
+Libs:
+Cflags: -I/usr/include/$(ARCH_CROSS)/someconfig.h

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch typo-false-positive-834370 created (now 9fae431)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch typo-false-positive-834370
in repository lintian.

at  9fae431   c/debhelper.pm: Correct false positives in 
typo-in-debhelper-override-target when matching multiple targets, extra 
whitespace and wildcards.

This branch includes the following new commits:

   new  9fae431   c/debhelper.pm: Correct false positives in 
typo-in-debhelper-override-target when matching multiple targets, extra 
whitespace and wildcards.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: c/debhelper.pm: Correct false positives in typo-in-debhelper-override-target when matching multiple targets, extra whitespace and wildcards.

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch typo-false-positive-834370
in repository lintian.

commit 9fae431b5b4392a6920147e0864d44c305270d4f
Author: Chris Lamb 
Date:   Wed Aug 24 21:40:00 2016 +0100

c/debhelper.pm: Correct false positives in 
typo-in-debhelper-override-target when matching multiple targets, extra 
whitespace and wildcards.

Signed-off-by: Chris Lamb 
---
 checks/debhelper.pm | 11 ---
 .../debhelper-override-typos/debian/debian/rules| 21 +++--
 t/tests/debhelper-override-typos/tags   | 15 ---
 3 files changed, 39 insertions(+), 8 deletions(-)

diff --git a/checks/debhelper.pm b/checks/debhelper.pm
index 3883033..9babcfe 100644
--- a/checks/debhelper.pm
+++ b/checks/debhelper.pm
@@ -178,10 +178,15 @@ sub run {
 $dhcompatvalue = $1;
 # one can export and then set the value:
 $level = $1 if ($level);
-} elsif (/^override_(dh_[^:]+)/) {
+} elsif (/(.*override_dh_.*):/) {
+my $targets = $1;
 $needbuilddepends = 1;
-my $dhcommand = $1;
-if (not $dh_commands_depends->known($dhcommand)) {
+# Can be multiple targets per rule.
+while ($targets =~ /\boverride_(dh_[^\s]+)/g) {
+my $dhcommand = $1;
+# If maintainer is using wildcards, it's unlikely to be a typo.
+next if ($dhcommand =~ /%/);
+next if ($dh_commands_depends->known($dhcommand));
 # Unknown command, so check for likely misspellings
 foreach my $x (sort $dh_commands_depends->all) {
 if (distance($dhcommand, $x) < 3) {
diff --git a/t/tests/debhelper-override-typos/debian/debian/rules 
b/t/tests/debhelper-override-typos/debian/debian/rules
index 975c83a..1014f51 100755
--- a/t/tests/debhelper-override-typos/debian/debian/rules
+++ b/t/tests/debhelper-override-typos/debian/debian/rules
@@ -5,11 +5,28 @@
 
 # Good
 override_dh_install:
+override_dh_install :
+ override_dh_install: #
+prefix_override_dh_gconfs:
 override_dh_will_never_exist:
+override_dh_python2 override_dh_perl :
+override_dh_systemd_enable override_dh_systemd_disable:
+override_dh_auto_configure-% override_dh_auto_install-%:
+foo override_dh_installdeb bar override_dh_installxmlcatalogs: # combining 
regular and overrides
+
 
 # Bad
+override_dh_nump: # Multiple matches should emit only one tag
 override_dh_instakk:
+ override_dh_installcrons:
 override_dh_install_examples:
+override_dh_install_changelogs : # Extra space
+override_dh_perls override_dh_python2 : # Bad then good
+override_dh_python2 override_dh_perls : # Good then bad
+override_dh_instakk override_dh_install_examples : # Both broken, with space
+foo override_dh_installdebs bar override_dh_installxmlcatalog: # combining 
regular and overrides
+
+# Don't worry about anything beyond a colon even if wrong; it will fail anyway.
+override_dh_testdirs: override_dh_ucfs
 
-# Multiple matches should emit only one tag
-override_dh_nump:
+.PHONY: override_dh_ucfs
diff --git a/t/tests/debhelper-override-typos/tags 
b/t/tests/debhelper-override-typos/tags
index c8185b7..3c86a86 100644
--- a/t/tests/debhelper-override-typos/tags
+++ b/t/tests/debhelper-override-typos/tags
@@ -1,3 +1,12 @@
-W: debhelper-override-typos source: typo-in-debhelper-override-target 
override_dh_instakk -> override_dh_install (line 11)
-W: debhelper-override-typos source: typo-in-debhelper-override-target 
override_dh_install_examples -> override_dh_installexamples (line 12)
-W: debhelper-override-typos source: typo-in-debhelper-override-target 
override_dh_nump -> override_dh_numpy (line 15)
+W: debhelper-override-typos source: typo-in-debhelper-override-target 
override_dh_instakk -> override_dh_install (line 20)
+W: debhelper-override-typos source: typo-in-debhelper-override-target 
override_dh_instakk -> override_dh_install (line 26)
+W: debhelper-override-typos source: typo-in-debhelper-override-target 
override_dh_install_changelogs -> override_dh_installchangelogs (line 23)
+W: debhelper-override-typos source: typo-in-debhelper-override-target 
override_dh_install_examples -> override_dh_installexamples (line 22)
+W: debhelper-override-typos source: typo-in-debhelper-override-target 
override_dh_install_examples -> override_dh_installexamples (line 26)
+W: debhelper-override-typos source: typo-in-debhelper-override-target 
override_dh_installcrons -> override_dh_installcron (line 21)
+W: debhelper-override-typos source: typo-in-debhelper-override-target 
override_dh_installdebs -> override_dh_installdeb (line 27)
+W: debhelper-override-typos source: typo-in-debhelper-override-target 
override_dh_installxmlcatalog -> override_dh_installxmlcatalogs (line 27)
+W: debhelper-override-typos source: typo-in-debhelper-override-target 
override_dh_nump -> override_

[lintian] branch source-date-epoch-exported-by-dpkg created (now 3b10f7d)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch source-date-epoch-exported-by-dpkg
in repository lintian.

at  3b10f7d   c/rules: Check for unnecessary SOURCE_DATE_EPOCH 
assignments

This branch includes the following new commits:

   new  3b10f7d   c/rules: Check for unnecessary SOURCE_DATE_EPOCH 
assignments

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: c/rules: Check for common typos in debian/rules target names.

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch typos-in-debhelper-commands
in repository lintian.

commit 65b0ea6a12d8e9741d3c5bb22b5dbc62dce1d340
Author: Chris Lamb 
Date:   Sat Jul 30 13:31:40 2016 -0400

c/rules: Check for common typos in debian/rules target names.

Misspelling a target (eg. "override_dh_install_debconf") results in that
rule silently not being called. See #831772 for an example in the wild.

Signed-off-by: Chris Lamb 
---
 checks/debhelper.desc | 12 
 checks/debhelper.pm   | 15 ++-
 t/tests/debhelper-override-typos/debian/debian/control.in | 15 +++
 t/tests/debhelper-override-typos/debian/debian/rules  | 15 +++
 t/tests/debhelper-override-typos/desc |  5 +
 t/tests/debhelper-override-typos/tags |  3 +++
 6 files changed, 64 insertions(+), 1 deletion(-)

diff --git a/checks/debhelper.desc b/checks/debhelper.desc
index 155aeb8..9b9d046 100644
--- a/checks/debhelper.desc
+++ b/checks/debhelper.desc
@@ -349,3 +349,15 @@ Severity: classification
 Certainty: certain
 Info: This is the build system that Lintian believes the package is
  using.
+
+Tag: typo-in-debhelper-override-target
+Severity: normal
+Certainty: possible
+Info: The listed target in debian/rules command is a likely misspelling.
+ .
+ This can result in (for example) a dh_override_-style target
+ silently not being executed by make.
+ .
+ Implementation detail: The typo is detected by using "Levenshtein
+ edit distance".  Therefore, if the typo involve several characters,
+ Lintian may not detect it.
diff --git a/checks/debhelper.pm b/checks/debhelper.pm
index 2bb76fc..04394d9 100644
--- a/checks/debhelper.pm
+++ b/checks/debhelper.pm
@@ -23,6 +23,8 @@ use strict;
 use warnings;
 use autodie;
 
+use Text::Levenshtein qw(distance);
+
 use Lintian::Data;
 use Lintian::Relation;
 use Lintian::Tags qw(tag);
@@ -176,8 +178,19 @@ sub run {
 $dhcompatvalue = $1;
 # one can export and then set the value:
 $level = $1 if ($level);
-} elsif (/^override_dh_/) {
+} elsif (/^override_(dh_[^:]+)/) {
 $needbuilddepends = 1;
+my $dhcommand = $1;
+if (not $dh_commands_depends->known($dhcommand)) {
+# Unknown command, so check for likely misspellings
+foreach my $x (sort $dh_commands_depends->all) {
+if (distance($dhcommand, $x) < 3) {
+tag 'typo-in-debhelper-override-target',
+  "override_$dhcommand", '->', "override_$x", "(line 
$.)";
+last; # Only emit a single match
+}
+}
+}
 } elsif (m,^include\s+/usr/share/cdbs/,) {
 $inclcdbs = 1;
 $build_systems{'cdbs-without-debhelper.mk'} = 1
diff --git a/t/tests/debhelper-override-typos/debian/debian/control.in 
b/t/tests/debhelper-override-typos/debian/debian/control.in
new file mode 100644
index 000..b65617f
--- /dev/null
+++ b/t/tests/debhelper-override-typos/debian/debian/control.in
@@ -0,0 +1,15 @@
+Source: {$source}
+Priority: extra
+Section: {$section}
+Maintainer: {$author}
+Standards-Version: {$standards_version}
+Build-Depends-Indep: debhelper (>= 9), python
+
+Package: {$source}
+Architecture: {$architecture}
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Description: {$description}
+ This is a test package designed to exercise some feature or tag of
+ Lintian.  It is part of the Lintian test suite and may do very odd
+ things.  It should not be installed like a regular package.  It may
+ be an empty package.
diff --git a/t/tests/debhelper-override-typos/debian/debian/rules 
b/t/tests/debhelper-override-typos/debian/debian/rules
new file mode 100755
index 000..4cfb47f
--- /dev/null
+++ b/t/tests/debhelper-override-typos/debian/debian/rules
@@ -0,0 +1,15 @@
+#!/usr/bin/make -f
+
+%:
+   dh $@
+
+# Good
+override_dh_install:
+override_dh_will_never_exist:
+
+# Bad
+override_dh_instakk:
+override_dh_install_examples:
+
+# Multiple matches should emit only one tag
+override_dh_nump: # 
diff --git a/t/tests/debhelper-override-typos/desc 
b/t/tests/debhelper-override-typos/desc
new file mode 100644
index 000..637e35b
--- /dev/null
+++ b/t/tests/debhelper-override-typos/desc
@@ -0,0 +1,5 @@
+Testname: debhelper-override-typos
+Sequence: 6000
+Version: 1.0
+Description: Test for typos in override targets
+Test-For: typo-in-debhelper-override-target
diff --git a/t/tests/debhelper-override-typos/tags 
b/t/tests/debhelper-override-typos/tags
new file mode 100644
index 000..c8185b7
--- /dev/null
+++ b/t/tests/debhelper-override-typos/tags
@@ -0,0 +1,3 @@
+W: debhelper-override-typos source: typo-in-debhelper-override-target 
override_dh_instakk -> ove

[lintian] branch warn-if-filenames-contain-wildcard-characters-814326 created (now 95b7c75)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch 
warn-if-filenames-contain-wildcard-characters-814326
in repository lintian.

at  95b7c75   c/files: Warn if file name contains shell wildcard 
characters. (Closes: #814326)

This branch includes the following new commits:

   new  95b7c75   c/files: Warn if file name contains shell wildcard 
characters. (Closes: #814326)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch warn-about-dotcoverage-files-831864 created (now 55d0eee)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch warn-about-dotcoverage-files-831864
in repository lintian.

at  55d0eee   c/files: Warn about Python packages which ship 
coverage.py information. (Closes: #831864)

This branch includes the following new commits:

   new  55d0eee   c/files: Warn about Python packages which ship 
coverage.py information. (Closes: #831864)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: c/files: Warn if file name contains shell wildcard characters. (Closes: #814326)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch 
warn-if-filenames-contain-wildcard-characters-814326
in repository lintian.

commit 95b7c75133961abb3e15f9b602ccbad750bc8d78
Author: Chris Lamb 
Date:   Sat Aug 27 11:39:10 2016 +0100

c/files: Warn if file name contains shell wildcard characters. (Closes: 
#814326)

Signed-off-by: Chris Lamb 
---
 checks/files.desc |  8 
 checks/files.pm   |  4 
 t/tests/files-wildcard-characters/debian/.coverage|  0
 t/tests/files-wildcard-characters/debian/debian/rules | 11 +++
 t/tests/files-wildcard-characters/desc|  6 ++
 t/tests/files-wildcard-characters/tags|  2 ++
 6 files changed, 31 insertions(+)

diff --git a/checks/files.desc b/checks/files.desc
index 5ddc26b..8efd01b 100644
--- a/checks/files.desc
+++ b/checks/files.desc
@@ -1675,6 +1675,14 @@ Info: The given file is in PATH but consists of 
non-ASCII characters.
  Note that Lintian may be unable to display the filename accurately.
  Unprintable characters may have been replaced.
 
+Tag: file-name-contains-wildcard-character
+Severity: normal
+Certainty: possible
+Info: The file name contains shell wildcard characters.
+ .
+ These are most likely unexpanded wildcard characters from (for example)
+ debian/*.install files, or it may have been installed by accident.
+
 Tag: incorrect-naming-of-pkcs11-module
 Severity: important
 Certainty: certain
diff --git a/checks/files.pm b/checks/files.pm
index b546cf9..0266311 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -364,6 +364,10 @@ sub run {
 tag 'file-name-is-not-valid-UTF-8', $file;
 }
 
+if ($fname =~ m,[*?],) {
+  tag 'file-name-contains-wildcard-character', $file;
+}
+
 if ($file->is_hardlink) {
 my $link_target_dir = $link;
 $link_target_dir =~ s,[^/]*$,,;
diff --git a/t/tests/files-wildcard-characters/debian/.coverage 
b/t/tests/files-wildcard-characters/debian/.coverage
new file mode 100644
index 000..e69de29
diff --git a/t/tests/files-wildcard-characters/debian/debian/rules 
b/t/tests/files-wildcard-characters/debian/debian/rules
new file mode 100755
index 000..c14beca
--- /dev/null
+++ b/t/tests/files-wildcard-characters/debian/debian/rules
@@ -0,0 +1,11 @@
+#!/usr/bin/make -f
+
+PREFIX = 
$(CURDIR)/debian/files-wildcard-characters/usr/share/files-wildcard-characters
+
+%:
+   dh $@
+
+override_dh_auto_install:
+   mkdir -p $(PREFIX)
+   touch $(PREFIX)/star*
+   touch $(PREFIX)/question-mark?
diff --git a/t/tests/files-wildcard-characters/desc 
b/t/tests/files-wildcard-characters/desc
new file mode 100644
index 000..c8a779f
--- /dev/null
+++ b/t/tests/files-wildcard-characters/desc
@@ -0,0 +1,6 @@
+Testname: files-wildcard-characters
+Sequence: 6000
+Version: 1.0
+Description: Check for wildcard characters in filenames
+Test-For:
+ file-name-contains-wildcard-character
diff --git a/t/tests/files-wildcard-characters/tags 
b/t/tests/files-wildcard-characters/tags
new file mode 100644
index 000..d1ccd8a
--- /dev/null
+++ b/t/tests/files-wildcard-characters/tags
@@ -0,0 +1,2 @@
+W: files-wildcard-characters: file-name-contains-wildcard-character 
usr/share/files-wildcard-characters/question-mark?
+W: files-wildcard-characters: file-name-contains-wildcard-character 
usr/share/files-wildcard-characters/star*

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: c/files: Warn about Python packages which ship coverage.py information. (Closes: #831864)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch warn-about-dotcoverage-files-831864
in repository lintian.

commit 55d0eee57b107bd595913f737d8857677913cea6
Author: Chris Lamb 
Date:   Tue Sep 6 22:36:54 2016 +0100

c/files: Warn about Python packages which ship coverage.py information. 
(Closes: #831864)

Signed-off-by: Chris Lamb 
---
 checks/files.desc   | 12 
 checks/files.pm |  5 +
 t/tests/files-python-coverage/debian/.coverage  |  0
 t/tests/files-python-coverage/debian/debian/install |  1 +
 t/tests/files-python-coverage/desc  |  6 ++
 t/tests/files-python-coverage/tags  |  1 +
 6 files changed, 25 insertions(+)

diff --git a/checks/files.desc b/checks/files.desc
index 5ddc26b..1400a5c 100644
--- a/checks/files.desc
+++ b/checks/files.desc
@@ -846,6 +846,18 @@ Info: Python eggs should not be installed, since the 
Debian package is
  .
  The egg may contain pre-compiled Python bytecode or shared libraries.
 
+Tag: package-contains-python-coverage-file
+Severity: normal
+Certainty: certain
+Info: The package conains a file that looks like output from the Python
+ coverage.py tool.  These are generated by python{,3}-coverage during a test
+ run, noting which parts of the code have been executed.  They can then be
+ subsequently analyzed to identify code that could have been executed but was
+ not.
+ .
+ As they are are unlikely to be of utility to end-users, these files should be
+ removed from the package.
+
 Tag: package-installs-python-pycache-dir
 Severity: serious
 Certainty: certain
diff --git a/checks/files.pm b/checks/files.pm
index b546cf9..f4f7579 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -1102,6 +1102,11 @@ sub run {
 tag 'package-installs-python-egg', $file;
 }
 
+#  .coverage (coverage.py output)
+if ($file->basename eq ".coverage") {
+tag 'package-contains-python-coverage-file', $file;
+}
+
 #  /usr/lib/site-python
 if ($fname =~ m,^usr/lib/site-python/\S,) {
 tag 'file-in-usr-lib-site-python', $file;
diff --git a/t/tests/files-python-coverage/debian/.coverage 
b/t/tests/files-python-coverage/debian/.coverage
new file mode 100644
index 000..e69de29
diff --git a/t/tests/files-python-coverage/debian/debian/install 
b/t/tests/files-python-coverage/debian/debian/install
new file mode 100644
index 000..3b6a0bc
--- /dev/null
+++ b/t/tests/files-python-coverage/debian/debian/install
@@ -0,0 +1 @@
+.coverage /usr/share/files-python-coverage
diff --git a/t/tests/files-python-coverage/desc 
b/t/tests/files-python-coverage/desc
new file mode 100644
index 000..67126e6
--- /dev/null
+++ b/t/tests/files-python-coverage/desc
@@ -0,0 +1,6 @@
+Testname: files-python-coverage
+Sequence: 6000
+Version: 1.0
+Description: Check for Python .coverage files
+Test-For:
+ package-contains-python-coverage-file
diff --git a/t/tests/files-python-coverage/tags 
b/t/tests/files-python-coverage/tags
new file mode 100644
index 000..c943f51
--- /dev/null
+++ b/t/tests/files-python-coverage/tags
@@ -0,0 +1 @@
+W: files-python-coverage: package-contains-python-coverage-file 
usr/share/files-python-coverage/.coverage

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



Build failed in Jenkins: lintian-tests_sid #2001

2017-10-08 Thread jenkins
See 


Changes:

[pabs] spelling: Add another correction

--
[...truncated 238.54 KB...]
Adding debian:EC-ACC.pem
Adding debian:E-Tugra_Certification_Authority.pem
Adding debian:DigiCert_Trusted_Root_G4.pem
Adding debian:DigiCert_High_Assurance_EV_Root_CA.pem
Adding debian:DigiCert_Global_Root_G3.pem
Adding debian:DigiCert_Global_Root_G2.pem
Adding debian:DigiCert_Global_Root_CA.pem
Adding debian:DigiCert_Assured_ID_Root_G3.pem
Adding debian:DigiCert_Assured_ID_Root_G2.pem
Adding debian:DigiCert_Assured_ID_Root_CA.pem
Adding debian:Deutsche_Telekom_Root_CA_2.pem
Adding debian:DST_Root_CA_X3.pem
Adding debian:DST_ACES_CA_X6.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_EV_2009.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_2009.pem
Adding debian:Cybertrust_Global_Root.pem
Adding debian:Comodo_Trusted_Services_root.pem
Adding debian:Comodo_Secure_Services_root.pem
Adding debian:Comodo_AAA_Services_root.pem
Adding debian:China_Internet_Network_Information_Center_EV_Certificates_Root.pem
Adding debian:Chambers_of_Commerce_Root_-_2008.pem
Adding debian:Certum_Trusted_Network_CA_2.pem
Adding debian:Certum_Trusted_Network_CA.pem
Adding debian:Certum_Root_CA.pem
Adding debian:Certplus_Root_CA_G2.pem
Adding debian:Certplus_Root_CA_G1.pem
Adding debian:Certplus_Class_2_Primary_CA.pem
Adding debian:Certinomis_-_Root_CA.pem
Warning: there was a problem reading the certificate file 
/etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem. Message:
  /etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem (No such file or directory)
Adding debian:Certigna.pem
Adding debian:Camerfirma_Global_Chambersign_Root.pem
Adding debian:Camerfirma_Chambers_of_Commerce_Root.pem
Adding debian:COMODO_RSA_Certification_Authority.pem
Adding debian:COMODO_ECC_Certification_Authority.pem
Adding debian:COMODO_Certification_Authority.pem
Adding debian:CNNIC_ROOT.pem
Adding debian:CFCA_EV_ROOT.pem
Adding debian:CA_Disig_Root_R2.pem
Adding debian:CA_Disig_Root_R1.pem
Adding debian:Buypass_Class_3_Root_CA.pem
Adding debian:Buypass_Class_2_Root_CA.pem
Adding debian:Baltimore_CyberTrust_Root.pem
Adding debian:Autoridad_de_Certificacion_Firmaprofesional_CIF_A62634068.pem
Adding debian:Atos_TrustedRoot_2011.pem
Adding debian:Amazon_Root_CA_4.pem
Adding debian:Amazon_Root_CA_3.pem
Adding debian:Amazon_Root_CA_2.pem
Adding debian:Amazon_Root_CA_1.pem
Adding debian:AffirmTrust_Premium_ECC.pem
Adding debian:AffirmTrust_Premium.pem
Adding debian:AffirmTrust_Networking.pem
Adding debian:AffirmTrust_Commercial.pem
Adding debian:AddTrust_Qualified_Certificates_Root.pem
Adding debian:AddTrust_Public_Services_Root.pem
Adding debian:AddTrust_Low-Value_Services_Root.pem
Adding debian:AddTrust_External_Root.pem
Adding debian:Actalis_Authentication_Root_CA.pem
Adding debian:AC_RAIZ_FNMT-RCM.pem
Adding debian:ACEDICOM_Root.pem
Adding debian:ACCVRAIZ1.pem
done.
Setting up openjdk-8-jdk-headless:amd64 (8u144-b01-2) ...
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/idlj to 
provide /usr/bin/idlj (idlj) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jdeps to 
provide /usr/bin/jdeps (jdeps) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/wsimport to 
provide /usr/bin/wsimport (wsimport) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/rmic to 
provide /usr/bin/rmic (rmic) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jinfo to 
provide /usr/bin/jinfo (jinfo) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jsadebugd to 
provide /usr/bin/jsadebugd (jsadebugd) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/native2ascii 
to provide /usr/bin/native2ascii (native2ascii) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstat to 
provide /usr/bin/jstat (jstat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javac to 
provide /usr/bin/javac (javac) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javah to 
provide /usr/bin/javah (javah) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstack to 
provide /usr/bin/jstack (jstack) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jrunscript to 
provide /usr/bin/jrunscript (jrunscript) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javadoc to 
provide /usr/bin/javadoc (javadoc) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jhat to 
provide /usr/bin/jhat (jhat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javap to 
provide /usr/bin/javap (javap) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jar to provide 
/usr/bin/jar (jar) in auto mode
update-alternatives: using

[lintian] 02/04: c/systemd.pm: Don't emit systemd-service-file-missing-install-key for "template" .service files.

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch 
service-files-missing-install-key-false-positives
in repository lintian.

commit 7c6c8b12b962993fd3e06ee9453e25f3fef685fb
Author: Chris Lamb 
Date:   Thu Sep 8 12:33:36 2016 +0100

c/systemd.pm: Don't emit systemd-service-file-missing-install-key for 
"template" .service files.

Signed-off-by: Chris Lamb 
---
 checks/systemd.pm| 3 ++-
 t/tests/systemd-complex-service-file/debian/debian/install   | 3 ++-
 t/tests/systemd-complex-service-file/debian/debian/test@.service | 5 +
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/checks/systemd.pm b/checks/systemd.pm
index b6a2153..aa0e1d0 100644
--- a/checks/systemd.pm
+++ b/checks/systemd.pm
@@ -203,7 +203,8 @@ sub check_systemd_service_file {
   unless extract_service_file_values($file, 'Unit', 'Documentation',1);
 tag 'systemd-service-file-missing-install-key', $file,
   unless extract_service_file_values($file, 'Install', 'WantedBy',1)
-  or extract_service_file_values($file, 'Install', 'RequiredBy',1);
+  or extract_service_file_values($file, 'Install', 'RequiredBy',1)
+  or $file =~ m,@\.service$,;
 }
 
 return 1;
diff --git a/t/tests/systemd-complex-service-file/debian/debian/install 
b/t/tests/systemd-complex-service-file/debian/debian/install
index f4ca3c8..10c1616 100644
--- a/t/tests/systemd-complex-service-file/debian/debian/install
+++ b/t/tests/systemd-complex-service-file/debian/debian/install
@@ -1,3 +1,4 @@
 debian/test.service lib/systemd/system/
 debian/test2.service lib/systemd/system/
-debian/test3.service lib/systemd/system/
\ No newline at end of file
+debian/test3.service lib/systemd/system/
+debian/test@.service lib/systemd/system/
diff --git a/t/tests/systemd-complex-service-file/debian/debian/test@.service 
b/t/tests/systemd-complex-service-file/debian/debian/test@.service
new file mode 100644
index 000..d54ea5d
--- /dev/null
+++ b/t/tests/systemd-complex-service-file/debian/debian/test@.service
@@ -0,0 +1,5 @@
+[Unit]
+Documentation=https://www.example.com/
+
+[Service]
+ExecStart=/usr/bin/test

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 03/04: c/systemd: Don't emit systemd-service-file-missing-install-key if it contain an "Also=" section.

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch 
service-files-missing-install-key-false-positives
in repository lintian.

commit b4584f232df1f64dbabacbbac3b1496ccf2418f2
Author: Chris Lamb 
Date:   Thu Sep 8 12:36:57 2016 +0100

c/systemd: Don't emit systemd-service-file-missing-install-key if it 
contain an "Also=" section.

Signed-off-by: Chris Lamb 
---
 checks/systemd.pm| 1 +
 t/tests/systemd-complex-service-file/debian/debian/install   | 1 +
 t/tests/systemd-complex-service-file/debian/debian/test4.service | 8 
 3 files changed, 10 insertions(+)

diff --git a/checks/systemd.pm b/checks/systemd.pm
index aa0e1d0..b670c37 100644
--- a/checks/systemd.pm
+++ b/checks/systemd.pm
@@ -204,6 +204,7 @@ sub check_systemd_service_file {
 tag 'systemd-service-file-missing-install-key', $file,
   unless extract_service_file_values($file, 'Install', 'WantedBy',1)
   or extract_service_file_values($file, 'Install', 'RequiredBy',1)
+  or extract_service_file_values($file, 'Install', 'Also',1)
   or $file =~ m,@\.service$,;
 }
 
diff --git a/t/tests/systemd-complex-service-file/debian/debian/install 
b/t/tests/systemd-complex-service-file/debian/debian/install
index 10c1616..a4ea934 100644
--- a/t/tests/systemd-complex-service-file/debian/debian/install
+++ b/t/tests/systemd-complex-service-file/debian/debian/install
@@ -1,4 +1,5 @@
 debian/test.service lib/systemd/system/
 debian/test2.service lib/systemd/system/
 debian/test3.service lib/systemd/system/
+debian/test4.service lib/systemd/system/
 debian/test@.service lib/systemd/system/
diff --git a/t/tests/systemd-complex-service-file/debian/debian/test4.service 
b/t/tests/systemd-complex-service-file/debian/debian/test4.service
new file mode 100644
index 000..d63a719
--- /dev/null
+++ b/t/tests/systemd-complex-service-file/debian/debian/test4.service
@@ -0,0 +1,8 @@
+[Unit]
+Documentation=https://www.example.com/
+
+[Service]
+ExecStart=/usr/bin/test
+
+[Install]
+Also=test3

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/04: c/systemd: Reduce certainty of systemd-service-file-missing-install-key.

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch 
service-files-missing-install-key-false-positives
in repository lintian.

commit 78664328f5fe568ea15f7e57a4c5378425301e22
Author: Chris Lamb 
Date:   Thu Sep 8 12:24:05 2016 +0100

c/systemd: Reduce certainty of systemd-service-file-missing-install-key.

Signed-off-by: Chris Lamb 
---
 checks/systemd.desc   | 4 +---
 t/tests/systemd-complex-service-file/tags | 2 +-
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/checks/systemd.desc b/checks/systemd.desc
index 86bfa51..d4aea02 100644
--- a/checks/systemd.desc
+++ b/checks/systemd.desc
@@ -129,12 +129,10 @@ Ref: systemd.unit(5)
 
 Tag: systemd-service-file-missing-install-key
 Severity: normal
-Certainty: possible
+Certainty: wild-guess
 Info: The systemd service file does not contain a WantedBy= or
  RequiredBy= key in its [Install] section.
  .
  Forgetting to add such a line (e.g. WantedBy=multi-user.target)
  results in the service file not being started by default.
- .
- If this is intentional, please override this warning.
 Ref: systemd.unit(5)
diff --git a/t/tests/systemd-complex-service-file/tags 
b/t/tests/systemd-complex-service-file/tags
index fafa0e8..11095e2 100644
--- a/t/tests/systemd-complex-service-file/tags
+++ b/t/tests/systemd-complex-service-file/tags
@@ -1,5 +1,5 @@
 E: systemd-complex-service-file: service-key-has-whitespace 
lib/systemd/system/test3.service at line 3
 I: systemd-complex-service-file: 
systemd-service-file-missing-documentation-key lib/systemd/system/test3.service
-W: systemd-complex-service-file: systemd-service-file-missing-install-key 
lib/systemd/system/test2.service
+I: systemd-complex-service-file: systemd-service-file-missing-install-key 
lib/systemd/system/test2.service
 W: systemd-complex-service-file: 
systemd-service-file-refers-to-obsolete-target lib/systemd/system/test.service 
dbus.target
 W: systemd-complex-service-file: 
systemd-service-file-refers-to-obsolete-target lib/systemd/system/test2.service 
syslog.target

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch systemd-service-file-missing-wanted-by created (now cc4e773)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch systemd-service-file-missing-wanted-by
in repository lintian.

at  cc4e773   c/systemd: Warn about .service files with a potentially 
missing Install key

This branch includes the following new commits:

   new  cc4e773   c/systemd: Warn about .service files with a potentially 
missing Install key

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: c/systemd: Warn about .service files with a potentially missing Install key

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch systemd-service-file-missing-wanted-by
in repository lintian.

commit cc4e77351ce51f99b58555f012c88756b0bd2d5e
Author: Chris Lamb 
Date:   Fri Jul 29 09:25:06 2016 -0400

c/systemd: Warn about .service files with a potentially missing Install key

Signed-off-by: Chris Lamb 
---
 checks/systemd.desc  | 12 
 checks/systemd.pm|  3 +++
 .../systemd-complex-service-file/debian/debian/test.service  |  2 +-
 .../systemd-complex-service-file/debian/debian/test3.service |  3 +++
 t/tests/systemd-complex-service-file/desc|  1 +
 t/tests/systemd-complex-service-file/tags|  1 +
 6 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/checks/systemd.desc b/checks/systemd.desc
index 07dea64..529abb5 100644
--- a/checks/systemd.desc
+++ b/checks/systemd.desc
@@ -126,3 +126,15 @@ Info: The systemd service file does not contain a 
Documentation key.
  Documentation for systemd service files can be automatically viewed using
  systemctl help servicename if this field is present.
 Ref: systemd.unit(5)
+
+Tag: systemd-service-file-missing-install-key
+Severity: normal
+Certainty: possible
+Info: The systemd service file does not contain a WantedBy= or
+ RequiredBy= key in its [Install] section.
+ .
+ Forgetting to add such a line (e.g. WantedBy=multi-user.target)
+ results in the service file not being started by default.
+ .
+ If this is intentional, please override this warning.
+Ref: systemd.unit(5)
diff --git a/checks/systemd.pm b/checks/systemd.pm
index face504..3de56e5 100644
--- a/checks/systemd.pm
+++ b/checks/systemd.pm
@@ -201,6 +201,9 @@ sub check_systemd_service_file {
 if (not $file->is_symlink or $file->link ne '/dev/null') {
 tag 'systemd-service-file-missing-documentation-key', $file,
   unless extract_service_file_values($file, 'Unit', 'Documentation',1);
+tag 'systemd-service-file-missing-install-key', $file,
+  unless extract_service_file_values($file, 'Install', 'WantedBy',1)
+or extract_service_file_values($file, 'Install', 'RequiredBy',1);
 }
 
 return 1;
diff --git a/t/tests/systemd-complex-service-file/debian/debian/test.service 
b/t/tests/systemd-complex-service-file/debian/debian/test.service
index e62b6a1..60f401a 100644
--- a/t/tests/systemd-complex-service-file/debian/debian/test.service
+++ b/t/tests/systemd-complex-service-file/debian/debian/test.service
@@ -6,4 +6,4 @@ Documentation=https://www.freedesktop.org/wiki/Software/dbus/
 ExecStart=/usr/bin/test
 
 [Install]
-WantedBy=multi-user.target
+RequiredBy=multi-user.target
diff --git a/t/tests/systemd-complex-service-file/debian/debian/test3.service 
b/t/tests/systemd-complex-service-file/debian/debian/test3.service
index 5fe96f6..3862626 100644
--- a/t/tests/systemd-complex-service-file/debian/debian/test3.service
+++ b/t/tests/systemd-complex-service-file/debian/debian/test3.service
@@ -3,3 +3,6 @@
 [Unit]
 After=
 After = syslog.target
+
+[Install]
+WantedBy=multi-user.target
diff --git a/t/tests/systemd-complex-service-file/desc 
b/t/tests/systemd-complex-service-file/desc
index 98ec594..f0b46c1 100644
--- a/t/tests/systemd-complex-service-file/desc
+++ b/t/tests/systemd-complex-service-file/desc
@@ -7,3 +7,4 @@ Test-For:
  service-key-has-whitespace
  systemd-service-file-refers-to-obsolete-target
  systemd-service-file-missing-documentation-key
+ systemd-service-file-missing-install-key
diff --git a/t/tests/systemd-complex-service-file/tags 
b/t/tests/systemd-complex-service-file/tags
index 34cb40a..fafa0e8 100644
--- a/t/tests/systemd-complex-service-file/tags
+++ b/t/tests/systemd-complex-service-file/tags
@@ -1,4 +1,5 @@
 E: systemd-complex-service-file: service-key-has-whitespace 
lib/systemd/system/test3.service at line 3
 I: systemd-complex-service-file: 
systemd-service-file-missing-documentation-key lib/systemd/system/test3.service
+W: systemd-complex-service-file: systemd-service-file-missing-install-key 
lib/systemd/system/test2.service
 W: systemd-complex-service-file: 
systemd-service-file-refers-to-obsolete-target lib/systemd/system/test.service 
dbus.target
 W: systemd-complex-service-file: 
systemd-service-file-refers-to-obsolete-target lib/systemd/system/test2.service 
syslog.target

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 04/04: c/systemd: Don't emit systemd-service-file-missing-install-key for Type=oneshot.

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch 
service-files-missing-install-key-false-positives
in repository lintian.

commit b380c64f21805dca56cfa84c48b83cca5381b3ef
Author: Chris Lamb 
Date:   Thu Sep 8 12:48:09 2016 +0100

c/systemd: Don't emit systemd-service-file-missing-install-key for 
Type=oneshot.
---
 checks/systemd.pm| 1 +
 t/tests/systemd-complex-service-file/debian/debian/install   | 1 +
 t/tests/systemd-complex-service-file/debian/debian/test5.service | 6 ++
 3 files changed, 8 insertions(+)

diff --git a/checks/systemd.pm b/checks/systemd.pm
index b670c37..d22140c 100644
--- a/checks/systemd.pm
+++ b/checks/systemd.pm
@@ -205,6 +205,7 @@ sub check_systemd_service_file {
   unless extract_service_file_values($file, 'Install', 'WantedBy',1)
   or extract_service_file_values($file, 'Install', 'RequiredBy',1)
   or extract_service_file_values($file, 'Install', 'Also',1)
+  or grep { /^oneshot$/ } extract_service_file_values($file, 
'Service', 'Type')
   or $file =~ m,@\.service$,;
 }
 
diff --git a/t/tests/systemd-complex-service-file/debian/debian/install 
b/t/tests/systemd-complex-service-file/debian/debian/install
index a4ea934..763129d 100644
--- a/t/tests/systemd-complex-service-file/debian/debian/install
+++ b/t/tests/systemd-complex-service-file/debian/debian/install
@@ -2,4 +2,5 @@ debian/test.service lib/systemd/system/
 debian/test2.service lib/systemd/system/
 debian/test3.service lib/systemd/system/
 debian/test4.service lib/systemd/system/
+debian/test5.service lib/systemd/system/
 debian/test@.service lib/systemd/system/
diff --git a/t/tests/systemd-complex-service-file/debian/debian/test5.service 
b/t/tests/systemd-complex-service-file/debian/debian/test5.service
new file mode 100644
index 000..64a7562
--- /dev/null
+++ b/t/tests/systemd-complex-service-file/debian/debian/test5.service
@@ -0,0 +1,6 @@
+[Unit]
+Documentation=https://www.example.com/
+
+[Service]
+Type=oneshot
+ExecStart=/usr/bin/test

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: d/changelog: We now support XDG for user config/data

2017-10-08 Thread Niels Thykier
This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 6745d8843b12529407d5ed985539b01c36fa7499
Author: Niels Thykier 
Date:   Sun Oct 8 08:42:07 2017 +

d/changelog: We now support XDG for user config/data

Signed-off-by: Niels Thykier 
---
 debian/changelog | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/changelog b/debian/changelog
index 1ff55b7..5b366f9 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -58,6 +58,7 @@ lintian (2.5.55) UNRELEASED; urgency=medium
   user profiles and data files.  This has been supported for quite
   a while but the documentation incorrectly listed "$HOME/.lintian"
   instead (which in fact did not work for this purpose).
+  (Closes: #701477)
 
   * frontend/dplint:
 + [NT] Restore "$HOME/.lintian" as a directory that is used for

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



Processed: limit source to lintian, tagging 701477

2017-10-08 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> limit source lintian
Limiting to bugs with field 'source' containing at least one of 'lintian'
Limit currently set to 'source':'lintian'

> tags 701477 + pending
Bug #701477 [lintian] lintian: Should it support XDG for user 
configuration/data?
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
701477: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=701477
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Processed: retitle 701477 to lintian: Should it support XDG for user configuration/data?

2017-10-08 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> retitle 701477 lintian: Should it support XDG for user configuration/data?
Bug #701477 [lintian] lintian: Should it support XDG?
Changed Bug title to 'lintian: Should it support XDG for user 
configuration/data?' from 'lintian: Should it support XDG?'.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
701477: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=701477
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Jenkins build is back to normal : lintian-tests_sid #2002

2017-10-08 Thread jenkins
See 




Processed: tagging 660165

2017-10-08 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> tags 660165 + moreinfo
Bug #660165 [lintian] [new check] Source package names for R libraries (and 
others if appropriate).
Added tag(s) moreinfo.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
660165: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=660165
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



[lintian] branch master updated (75591c0 -> 6745d88)

2017-10-08 Thread Niels Thykier
This is an automated email from the git hooks/post-receive script.

nthykier pushed a change to branch master
in repository lintian.

  from  75591c0   tests/control-file-pendantic-space: Prevent a test 
regression caused by 52766dc7364d318.
   new  6745d88   d/changelog: We now support XDG for user config/data

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 debian/changelog | 1 +
 1 file changed, 1 insertion(+)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



Build failed in Jenkins: lintian-tests_stretch #1118

2017-10-08 Thread jenkins
See 


Changes:

[niels] t: Make test arch-specific to avoid FTBFS

[niels] L::CheckScript: Drop unused arguments in new

[niels] c/fields: Emit tag for priority extra

[niels] Restore /home/moon/.lintian as profile/data root dir

[niels] lintian.xml: Mention XDG_CONFIG_HOME/lintian/ next to

[niels] d/changelog: Add missing space

[niels] Correct d/changelog + lintian.xml to use $XDG_DATA_HOME

[niels] dplint: Correct order of @RESTRICTED_INCLUDE_DIRS

[niels] dplint: Fix perltidy issue

[niels] t: Fix syntax error in desc file

[pabs] spelling: Add another correction

[lamby] tests/control-file-pendantic-space: Prevent a test regression caused by

[niels] d/changelog: We now support XDG for user config/data

--
[...truncated 258.63 KB...]
tests::binaries-spelling: diff -u t/tests/binaries-spelling/tags 
/tmp/testrun/debian/test-out/tests/binaries-spelling/tags.binaries-spelling
--- t/tests/binaries-spelling/tags  2017-10-08 08:55:38.848392982 +
+++ /tmp/testrun/debian/test-out/tests/binaries-spelling/tags.binaries-spelling 
2017-10-08 09:05:43.758618410 +
@@ -1,4 +1,5 @@
 I: binaries-spelling: spelling-error-in-binary usr/bin/basic exprimental 
experimental
 I: binaries-spelling: spelling-error-in-binary usr/bin/basic speling spelling
 I: binaries-spelling: spelling-error-in-binary usr/bin/basic teh the
+W: binaries-spelling-dbgsym: priority-extra-is-replaced-by-priority-optional
 W: binaries-spelling: binary-without-manpage usr/bin/basic
fail tests::binaries-spelling: output differs!
S
tests::binaries-unsafe-open: diff -u t/tests/binaries-unsafe-open/tags 
/tmp/testrun/debian/test-out/tests/binaries-unsafe-open/tags.binaries-unsafe-open
--- t/tests/binaries-unsafe-open/tags   2017-10-08 08:55:38.848392982 +
+++ 
/tmp/testrun/debian/test-out/tests/binaries-unsafe-open/tags.binaries-unsafe-open
   2017-10-08 09:05:44.514570780 +
@@ -1 +1,2 @@
+W: binaries-unsafe-open-dbgsym: priority-extra-is-replaced-by-priority-optional
 W: binaries-unsafe-open: binary-without-manpage usr/bin/dummy||uname
fail tests::binaries-unsafe-open: output differs!
..
tests::binaries-embedded-libs: diff -u t/tests/binaries-embedded-libs/tags 
/tmp/testrun/debian/test-out/tests/binaries-embedded-libs/tags.binaries-embedded-libs
--- t/tests/binaries-embedded-libs/tags 2017-10-08 08:55:38.832394032 +
+++ 
/tmp/testrun/debian/test-out/tests/binaries-embedded-libs/tags.binaries-embedded-libs
   2017-10-08 09:05:47.318394112 +
@@ -15,3 +15,4 @@
 E: binaries-embedded-libs: embedded-library usr/bin/libxml2: libxml2
 E: binaries-embedded-libs: embedded-library usr/bin/mpfr: mpfr
 E: binaries-embedded-libs: embedded-library usr/bin/zlib: zlib
+W: binaries-embedded-libs-dbgsym: 
priority-extra-is-replaced-by-priority-optional
fail tests::binaries-embedded-libs: output differs!
.
tests::binaries-doesnt-match-sonames: diff -u 
t/tests/binaries-doesnt-match-sonames/tags 
/tmp/testrun/debian/test-out/tests/binaries-doesnt-match-sonames/tags.binaries-doesnt-match-sonames
--- t/tests/binaries-doesnt-match-sonames/tags  2017-10-08 08:55:38.832394032 
+
+++ 
/tmp/testrun/debian/test-out/tests/binaries-doesnt-match-sonames/tags.binaries-doesnt-match-sonames
 2017-10-08 09:05:50.410199281 +
@@ -1 +1,5 @@
+W: libany5gcc1v5-dbgsym: priority-extra-is-replaced-by-priority-optional
+W: libany6gcc1v6-dbgsym: priority-extra-is-replaced-by-priority-optional
+W: libanyq16-6-dbgsym: priority-extra-is-replaced-by-priority-optional
+W: mylibany-dbgsym: priority-extra-is-replaced-by-priority-optional
 W: mylibany: package-name-doesnt-match-sonames libany1
fail tests::binaries-doesnt-match-sonames: output differs!
SSS.


tests::files-wrong-ma-foreign: diff -u t/tests/files-wrong-ma-foreign/tags 
/tmp/testrun/debian/test-out/tests/files-wrong-ma-foreign/tags.files-wrong-ma-foreign
--- t/tests/files-wrong-ma-foreign/tags 2017-10-08 08:55:39.016381954 +
+++ 
/tmp/testrun/debian/test-out/tests/files-wrong-ma-foreign/tags.files-wrong-ma-foreign
   2017-10-08 09:08:31.991927035 +
@@ -1 +1,2 @@
 W: libpublic-dev: multiarch-foreign-shared-library
+W: libpublic1-dbgsym: priority-extra-is-replaced-by-priority-optional
fail tests::files-wrong-ma-foreign: output differs!

...S...
tests::shared-libs-exec-bit: diff -u t/tests/shared-libs-exec-bit/tags 
/tmp/testrun/debian/test-out/tests/shared-libs-exec-bit/tags.shared-libs-exec-bit
--- t/tests/shared-libs-exec-bit/tags   2017-10-08 08:55:39.068378540 +
+++ 
/tmp/testrun/debian/test-out/tests/shared-libs-exec-bit/tags.shared-libs-exe

Build failed in Jenkins: lintian-tests_stretch #1119

2017-10-08 Thread jenkins
See 

--
[...truncated 258.52 KB...]
fail tests::binaries-general: output differs!

tests::binaries-embedded-libs: diff -u t/tests/binaries-embedded-libs/tags 
/tmp/testrun/debian/test-out/tests/binaries-embedded-libs/tags.binaries-embedded-libs
--- t/tests/binaries-embedded-libs/tags 2017-10-08 09:25:11.799830617 +
+++ 
/tmp/testrun/debian/test-out/tests/binaries-embedded-libs/tags.binaries-embedded-libs
   2017-10-08 09:31:56.917064609 +
@@ -15,3 +15,4 @@
 E: binaries-embedded-libs: embedded-library usr/bin/libxml2: libxml2
 E: binaries-embedded-libs: embedded-library usr/bin/mpfr: mpfr
 E: binaries-embedded-libs: embedded-library usr/bin/zlib: zlib
+W: binaries-embedded-libs-dbgsym: 
priority-extra-is-replaced-by-priority-optional
fail tests::binaries-embedded-libs: output differs!
tests::binaries-unsafe-open: diff -u t/tests/binaries-unsafe-open/tags 
/tmp/testrun/debian/test-out/tests/binaries-unsafe-open/tags.binaries-unsafe-open
--- t/tests/binaries-unsafe-open/tags   2017-10-08 09:25:11.807830094 +
+++ 
/tmp/testrun/debian/test-out/tests/binaries-unsafe-open/tags.binaries-unsafe-open
   2017-10-08 09:31:56.933063569 +
@@ -1 +1,2 @@
+W: binaries-unsafe-open-dbgsym: priority-extra-is-replaced-by-priority-optional
 W: binaries-unsafe-open: binary-without-manpage usr/bin/dummy||uname
fail tests::binaries-unsafe-open: output differs!
tests::binaries-spelling: diff -u t/tests/binaries-spelling/tags 
/tmp/testrun/debian/test-out/tests/binaries-spelling/tags.binaries-spelling
--- t/tests/binaries-spelling/tags  2017-10-08 09:25:11.807830094 +
+++ /tmp/testrun/debian/test-out/tests/binaries-spelling/tags.binaries-spelling 
2017-10-08 09:31:57.097052909 +
@@ -1,4 +1,5 @@
 I: binaries-spelling: spelling-error-in-binary usr/bin/basic exprimental 
experimental
 I: binaries-spelling: spelling-error-in-binary usr/bin/basic speling spelling
 I: binaries-spelling: spelling-error-in-binary usr/bin/basic teh the
+W: binaries-spelling-dbgsym: priority-extra-is-replaced-by-priority-optional
 W: binaries-spelling: binary-without-manpage usr/bin/basic
fail tests::binaries-spelling: output differs!
S..
tests::binaries-doesnt-match-sonames: diff -u 
t/tests/binaries-doesnt-match-sonames/tags 
/tmp/testrun/debian/test-out/tests/binaries-doesnt-match-sonames/tags.binaries-doesnt-match-sonames
--- t/tests/binaries-doesnt-match-sonames/tags  2017-10-08 09:25:11.799830617 
+
+++ 
/tmp/testrun/debian/test-out/tests/binaries-doesnt-match-sonames/tags.binaries-doesnt-match-sonames
 2017-10-08 09:32:02.652691849 +
@@ -1 +1,5 @@
+W: libany5gcc1v5-dbgsym: priority-extra-is-replaced-by-priority-optional
+W: libany6gcc1v6-dbgsym: priority-extra-is-replaced-by-priority-optional
+W: libanyq16-6-dbgsym: priority-extra-is-replaced-by-priority-optional
+W: mylibany-dbgsym: priority-extra-is-replaced-by-priority-optional
 W: mylibany: package-name-doesnt-match-sonames libany1
fail tests::binaries-doesnt-match-sonames: output differs!
.S...SS.

.
tests::files-wrong-ma-foreign: diff -u t/tests/files-wrong-ma-foreign/tags 
/tmp/testrun/debian/test-out/tests/files-wrong-ma-foreign/tags.files-wrong-ma-foreign
--- t/tests/files-wrong-ma-foreign/tags 2017-10-08 09:25:11.887824865 +
+++ 
/tmp/testrun/debian/test-out/tests/files-wrong-ma-foreign/tags.files-wrong-ma-foreign
   2017-10-08 09:34:47.018658343 +
@@ -1 +1,2 @@
 W: libpublic-dev: multiarch-foreign-shared-library
+W: libpublic1-dbgsym: priority-extra-is-replaced-by-priority-optional
fail tests::files-wrong-ma-foreign: output differs!

...S...
tests::shared-libs-exec-bit: diff -u t/tests/shared-libs-exec-bit/tags 
/tmp/testrun/debian/test-out/tests/shared-libs-exec-bit/tags.shared-libs-exec-bit
--- t/tests/shared-libs-exec-bit/tags   2017-10-08 09:25:11.939821466 +
+++ 
/tmp/testrun/debian/test-out/tests/shared-libs-exec-bit/tags.shared-libs-exec-bit
   2017-10-08 09:36:04.221764873 +
@@ -1,3 +1,4 @@
 E: libexecbit1: shlib-with-executable-bit usr/lib/libexecbit.so.1.0.1 0755
+W: libexecbit1-dbgsym: priority-extra-is-replaced-by-priority-optional
 W: libexecbit1: non-standard-file-perm usr/lib/libbadperm.so.1.0.1 0600 != 0644
 W: libexecbit1: shlib-with-bad-permissions usr/lib/libbadperm.so.1.0.1 0600
fail tests::shared-libs-exec-bit: output differs!
tests::shared-libs-exec-stack: diff -u t/tests/shared-libs-exec-stack/tags 
/tmp/testrun/debian/test-out/tests/shared-libs-exec-stack/tags.shared-libs-exec-stack
--- t/tests/shared-libs-exec-stack/tags 2017-10-08 09:25:11.939821466 +
+++ 
/tmp/testrun/debia

[lintian] 01/01: c/fields: Skip priority extra->optional tag for auto-dbgsym

2017-10-08 Thread Niels Thykier
This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 29a528dfeb74b6fd728be9a7915fb0ee14fe9058
Author: Niels Thykier 
Date:   Sun Oct 8 10:12:29 2017 +

c/fields: Skip priority extra->optional tag for auto-dbgsym

Breaks the test suite in stable and it is not really actionable for a
maintainer.

Signed-off-by: Niels Thykier 
---
 checks/fields.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/checks/fields.pm b/checks/fields.pm
index cd9790f..549df72 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -578,7 +578,9 @@ sub run {
 unfold('priority', \$priority);
 
 if ($priority eq 'extra') {
-tag 'priority-extra-is-replaced-by-priority-optional';
+tag 'priority-extra-is-replaced-by-priority-optional'
+  if $type eq 'source'
+  or not $info->is_pkg_class('auto-generated');
 # Re-map to optional to avoid an additional warning from
 # lintian
 $priority = 'optional';

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch master updated (6745d88 -> 29a528d)

2017-10-08 Thread Niels Thykier
This is an automated email from the git hooks/post-receive script.

nthykier pushed a change to branch master
in repository lintian.

  from  6745d88   d/changelog: We now support XDG for user config/data
   new  29a528d   c/fields: Skip priority extra->optional tag for 
auto-dbgsym

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/fields.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



Jenkins build is back to normal : lintian-tests_stretch #1120

2017-10-08 Thread jenkins
See 




Jenkins build is back to normal : lintian-tests_jessie #1228

2017-10-08 Thread jenkins
See 




Bug#877999: lintian: false positive: license-problem-non-free-RFC debian/copyright

2017-10-08 Thread David Bremner
Package: lintian
Version: 2.5.54
Severity: important

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

The tag in the subject is generated for source package Racket. 

Severity is because this is used as an autoreject tag. Maybe that's not 
lintian's fault.

I suspect it's triggered by some discussion of the "Original License"
of some component of Racket.

It seems like you probably want to except debian/copyright from such a
check, since the presence of suspect text there does not reliably
indicate anything about the licensing. Also the whole idea of the
license of debian/copyright is probably not a good thing to devote
mental energy to.

- -- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (900, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.12.0-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_CA:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils  2.29.1-4
ii  bzip2 1.0.6-8.1
ii  diffstat  1.61-1+b1
ii  dpkg  1.18.24
ii  file  1:5.32-1
ii  gettext   0.19.8.1-4
ii  intltool-debian   0.35.0+20060710.4
ii  libapt-pkg-perl   0.1.33
ii  libarchive-zip-perl   1.59-1
ii  libclass-accessor-perl0.34-1
ii  libclone-perl 0.38-2+b2
ii  libdpkg-perl  1.18.24
ii  libemail-valid-perl   1.202-1
ii  libfile-basedir-perl  0.07-1
ii  libipc-run-perl   0.96-1
ii  liblist-moreutils-perl0.416-1+b3
ii  libparse-debianchangelog-perl 1.2.0-12
ii  libperl5.24 [libdigest-sha-perl]  5.24.1-7
ii  libperl5.26 [libdigest-sha-perl]  5.26.0-8
ii  libtext-levenshtein-perl  0.13-1
ii  libtimedate-perl  2.3000-2
ii  liburi-perl   1.72-1
ii  libxml-simple-perl2.24-1
ii  libyaml-libyaml-perl  0.63-2+b2
ii  man-db2.7.6.1-2
ii  patchutils0.3.4-2
ii  perl  5.26.0-8
ii  t1utils   1.40-2
ii  xz-utils  5.2.2-1.3

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b4

Versions of packages lintian suggests:
pn  binutils-multiarch 
ii  dpkg-dev   1.18.24
ii  libhtml-parser-perl3.72-3+b2
ii  libtext-template-perl  1.47-1

- -- no debconf information

-BEGIN PGP SIGNATURE-

iQGzBAEBCAAdFiEE3VS2dnyDRXKVCQCp8gKXHaSnniwFAlnaEV8ACgkQ8gKXHaSn
niwIWAv+NQHSWEydFQQpvFWrylXVjtxw4k+lq23F0ztteD2voVfAQFw8wUa2VPNK
Unb+4V0QnNN2TVPw3+LFm4Criq4Q0iJSd+M/PFjXd5X7tlK3CI9RrQRlodPDUNyK
BxFrpw3TmzV5uKnvdo28ziAeCfQybCQ0vHRUAT4a1a1eYGxQUQ4vxqWkosPWERg+
loIYpdh/+as/JHtUDpi/Wdu5ADZjJzMWJJRTHeyYYVYfQM9t6R8H04IwZdDyBpjl
YQvVEFAdSL5T37pnW1Ot8k4ZnUSh+XxeVEvLSB+ujCUl8yy8tQO2yJKKurEeDpuz
D+P2g4WUKrj8JVszoVyPwS49cQ4YE0ZhSSUB6QYm7aIx01gCplTeIYqKhchIaUKu
nXkFE7cAojwu1O6L/A1Mk9ZlLvlSlVDLweidH1MOLVNpd2jcJrdpgcUXHNtYEj+K
kyNv2yX3yYG0STYaptZFBool7xAMrYkcXghQCUdKgb+NgO99TwJNF2qla3fwoeSf
jdrYKxpA
=ZI8a
-END PGP SIGNATURE-



[lintian] branch master updated (29a528d -> 0ce8489)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  29a528d   c/fields: Skip priority extra->optional tag for 
auto-dbgsym
   new  0ce8489   Exempt debian/copyright from license-problem-non-free-RFC 
tag to avoid false-positives on meta-references. (Closes: #877999)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/cruft.pm| 1 +
 debian/changelog   | 3 +++
 .../cruft-non-free-rfc/debian/{src/rfc-3492.txt => debian/copyright}   | 2 ++
 3 files changed, 6 insertions(+)
 copy t/tests/cruft-non-free-rfc/debian/{src/rfc-3492.txt => debian/copyright} 
(96%)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] 01/01: Exempt debian/copyright from license-problem-non-free-RFC tag to avoid false-positives on meta-references. (Closes: #877999)

2017-10-08 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 0ce8489e105d80fb69cc07f98bf6b50d574cf4e8
Author: Chris Lamb 
Date:   Sun Oct 8 14:45:14 2017 +0100

Exempt debian/copyright from license-problem-non-free-RFC tag to avoid 
false-positives on meta-references. (Closes: #877999)
---
 checks/cruft.pm|  1 +
 debian/changelog   |  3 +++
 t/tests/cruft-non-free-rfc/debian/debian/copyright | 25 ++
 3 files changed, 29 insertions(+)

diff --git a/checks/cruft.pm b/checks/cruft.pm
index b49a52d..83c30ae 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -1249,6 +1249,7 @@ sub _rfc_whitelist_filename {
 $matchedkeyword,$licenseproblemhash, $licenseproblem,
 %matchedhash
 )= @_;
+return 0 if $name eq 'debian/copyright';
 my $lcname = lc($basename);
 
 foreach my $rfc_regexp ($RFC_WHITELIST->all) {
diff --git a/debian/changelog b/debian/changelog
index 5b366f9..f781977 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,6 +6,9 @@ lintian (2.5.55) UNRELEASED; urgency=medium
 + [CL] Drop copyright-year-in-future after all; it's just too error
   prone and time-consuming to maintain given the severity of the issues
   it can find.  (Closes: #877766)
+  * checks/cruft.pm:
++ [CL] Exempt debian/copyright from license-problem-non-free-RFC tag
+  to avoid false-positives on meta-references.  (Closes: #877999)
   * checks/debhelper.pm:
 + [AB] Also recognize dh-exec's "=>" arrow if surrounded by tabs.
   (Closes: #877905)
diff --git a/t/tests/cruft-non-free-rfc/debian/debian/copyright 
b/t/tests/cruft-non-free-rfc/debian/debian/copyright
new file mode 100644
index 000..f2134e7
--- /dev/null
+++ b/t/tests/cruft-non-free-rfc/debian/debian/copyright
@@ -0,0 +1,25 @@
+(False positive; debian/copyright should be ignored)
+
+Copyright (C) The Internet Society (1999).  All Rights Reserved.
+
+This document and translations of it may be copied and furnished to others,
+and derivative works that comment on or otherwise explain it or assist in
+its implementation may be prepared, copied, published and distributed, in
+whole or in part, without restriction of any kind, provided that the above
+copyright notice and this paragraph are included on all such copies and
+derivative works.  However, this document itself may not be modified in any
+way, such as by removing the copyright notice or references to the Internet
+Society or other Internet organizations, except as needed for the purpose of
+developing Internet standards in which case the procedures for copyrights
+defined in the Internet Standards process must be followed, or as required
+to translate it into languages other than English.
+
+The limited permissions granted above are perpetual and will not be revoked
+by the Internet Society or its successors or assigns.
+
+This document and the information contained herein is provided on an "AS IS"
+basis and THE INTERNET SOCIETY AND THE INTERNET ENGINEERING TASK FORCE
+DISCLAIMS ALL WARRANTIES, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO
+ANY WARRANTY THAT THE USE OF THE INFORMATION HEREIN WILL NOT INFRINGE ANY
+RIGHTS OR ANY IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A
+PARTICULAR PURPOSE.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



Processed: Re: lintian: false positive: license-problem-non-free-RFC debian/copyright

2017-10-08 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> tags 877999 + pending
Bug #877999 [lintian] lintian: false positive: license-problem-non-free-RFC 
debian/copyright
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
877999: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=877999
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#877999: lintian: false positive: license-problem-non-free-RFC debian/copyright

2017-10-08 Thread Chris Lamb
tags 877999 + pending
thanks

Fixed in Git:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=0ce8489e105d80fb69cc07f98bf6b50d574cf4e8


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-