Processed: Re: lintian: [patch] Warn about over-eagerly xz-compressed data.tar.xz
Processing commands for cont...@bugs.debian.org: > tags 829100 + pending Bug #829100 [lintian] lintian: [patch] Warn about over-eagerly xz-compressed data.tar.xz Added tag(s) pending. > thanks Stopping processing here. Please contact me if you need assistance. -- 829100: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=829100 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
[lintian] branch master updated (227ebde -> 1f8051c)
This is an automated email from the git hooks/post-receive script. lamby pushed a change to branch master in repository lintian. from 227ebde data/rules/should-not-use: Include the assigned value in the Lintian output for the debian-rules-should-not-use-DH_EXTRA_ADDONS tag. new 1f8051c Detect overly-compressed xz packages. (Closes: #829100) The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/rules.desc | 18 ++ data/rules/rules-should-not-use| 2 +- debian/changelog | 1 + .../debian/debian/rules| 10 ++ t/tests/rules-xz-compression-level-too-high/desc | 5 + t/tests/rules-xz-compression-level-too-high/tags | 2 ++ 6 files changed, 37 insertions(+), 1 deletion(-) create mode 100755 t/tests/rules-xz-compression-level-too-high/debian/debian/rules create mode 100644 t/tests/rules-xz-compression-level-too-high/desc create mode 100644 t/tests/rules-xz-compression-level-too-high/tags -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (07bc5df -> 598a4d6)
This is an automated email from the git hooks/post-receive script. lamby pushed a change to branch master in repository lintian. from 07bc5df checks/fields.desc: Downgrade severity of wrong-section-according-to-package-name from "W:" to "I:". (Closes: #883772) new 598a4d6 checks/rules.pm: Allow rules-not-should-not-use data-based tags to capture variables and include them in the emitted tag. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/rules.pm | 6 +- debian/changelog | 3 +++ 2 files changed, 8 insertions(+), 1 deletion(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Detect overly-compressed xz packages. (Closes: #829100)
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit 1f8051cb211c53a66c6c526828eee3fa90847cc9
Author: Chris Lamb
Date: Sat Jan 13 12:20:49 2018 +0530
Detect overly-compressed xz packages. (Closes: #829100)
---
checks/rules.desc | 18 ++
data/rules/rules-should-not-use| 2 +-
debian/changelog | 1 +
.../debian/debian/rules| 10 ++
t/tests/rules-xz-compression-level-too-high/desc | 5 +
t/tests/rules-xz-compression-level-too-high/tags | 2 ++
6 files changed, 37 insertions(+), 1 deletion(-)
diff --git a/checks/rules.desc b/checks/rules.desc
index 9ca7af8..4e89148 100644
--- a/checks/rules.desc
+++ b/checks/rules.desc
@@ -319,3 +319,21 @@ Info: The debian/rules file for this package has
an
.
Please add a call to dh_fixperms.
Ref: #885909
+
+Tag: xz-compression-level-too-high
+Severity: normal
+Certainty: certain
+Info: The debian/rules file for this package has a call to
+ dh_builddeb(1) that specifies an overly eager xz(1) compression
+ level.
+ .
+ Whilst higher levels might reduce the size of big files, it has the side
+ effect of consuming a lot of memory during both compression and
+ extraction.
+ .
+ This can not only also waste time unnecessarily, it can cause packages to
+ FTBFS or even fail to install in resource-constrained environments or
+ architectures.
+ .
+ Please remove the call and let dpkg-deb(1) select suitable defaults.
+Ref: #829100, dpkg-deb(1)
diff --git a/data/rules/rules-should-not-use b/data/rules/rules-should-not-use
index e17bbed..47cab90 100644
--- a/data/rules/rules-should-not-use
+++ b/data/rules/rules-should-not-use
@@ -9,4 +9,4 @@ debian-rules-should-not-use-DH_EXTRA_ADDONS ~~
^\s*DH_EXTRA_ADDONS\
debian-rules-should-not-use-or-modify-user-only-variable ~~ \bDEB_[^_
\t]+FLAGS_(?:SET|APPEND)\b
debian-rules-should-not-use-pwd ~~ \$[\(\{]PWD[\)\}]
debian-rules-should-not-use-underscore-variable ~~ \$[\(\{]_[\)\}]
-
+xz-compression-level-too-high~~
dh_builddeb\b.*--.*(?:-z\s*(?9).*-Z\s*xz|-Z\s*xz.*-z\s*(?9))
diff --git a/debian/changelog b/debian/changelog
index 1b46b54..58dd7da 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -32,6 +32,7 @@ lintian (2.5.69) UNRELEASED; urgency=medium
* data/rules/rules-should-not-use:
+ [CL] Include the assigned value in the Lintian output for the
debian-rules-should-not-use-DH_EXTRA_ADDONS tag.
++ [CL] Detect overly-compressed xz packages. (Closes: #829100)
-- Chris Lamb Tue, 09 Jan 2018 20:55:21 +0530
diff --git a/t/tests/rules-xz-compression-level-too-high/debian/debian/rules
b/t/tests/rules-xz-compression-level-too-high/debian/debian/rules
new file mode 100755
index 000..6034196
--- /dev/null
+++ b/t/tests/rules-xz-compression-level-too-high/debian/debian/rules
@@ -0,0 +1,10 @@
+#!/usr/bin/make -f
+
+%:
+ dh $@
+
+override_dh_builddeb:
+ dh_builddeb -- -Zxz -z 9
+ dh_builddeb -- -z9 -Z xz
+ dh_builddeb -- -z8 -Z xz
+ dh_builddeb -- -z9 -Zgzip
diff --git a/t/tests/rules-xz-compression-level-too-high/desc
b/t/tests/rules-xz-compression-level-too-high/desc
new file mode 100644
index 000..f234773
--- /dev/null
+++ b/t/tests/rules-xz-compression-level-too-high/desc
@@ -0,0 +1,5 @@
+Testname: rules-overeager-compression
+Version: 1.0
+Description: Test for over-eager tarball compression
+Test-For:
+ xz-compression-level-too-high
diff --git a/t/tests/rules-xz-compression-level-too-high/tags
b/t/tests/rules-xz-compression-level-too-high/tags
new file mode 100644
index 000..c711ddf
--- /dev/null
+++ b/t/tests/rules-xz-compression-level-too-high/tags
@@ -0,0 +1,2 @@
+W: rules-overeager-compression source: xz-compression-level-too-high 9 (line 7)
+W: rules-overeager-compression source: xz-compression-level-too-high 9 (line 8)
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (598a4d6 -> 227ebde)
This is an automated email from the git hooks/post-receive script. lamby pushed a change to branch master in repository lintian. from 598a4d6 checks/rules.pm: Allow rules-not-should-not-use data-based tags to capture variables and include them in the emitted tag. new 227ebde data/rules/should-not-use: Include the assigned value in the Lintian output for the debian-rules-should-not-use-DH_EXTRA_ADDONS tag. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: data/rules/rules-should-not-use | 2 +- debian/changelog| 3 +++ t/tests/rules-general/tags | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: data/rules/should-not-use: Include the assigned value in the Lintian output for the debian-rules-should-not-use-DH_EXTRA_ADDONS tag.
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit 227ebde4a289adf6c5deac968dc0142c3f409f4d
Author: Chris Lamb
Date: Sat Jan 13 12:15:43 2018 +0530
data/rules/should-not-use: Include the assigned value in the Lintian output
for the debian-rules-should-not-use-DH_EXTRA_ADDONS tag.
---
data/rules/rules-should-not-use | 2 +-
debian/changelog| 3 +++
t/tests/rules-general/tags | 2 +-
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/data/rules/rules-should-not-use b/data/rules/rules-should-not-use
index 098e9d4..e17bbed 100644
--- a/data/rules/rules-should-not-use
+++ b/data/rules/rules-should-not-use
@@ -5,7 +5,7 @@
#
debian-rules-should-not-automatically-update-control ~~
^\s*DEB_AUTO_UPDATE_DEBIAN_CONTROL\s*=\s*yes
debian-rules-should-not-use-DEB_BUILD_OPTS ~~
\$[\(\{]DEB_BUILD_OPTS[\)\}]
-debian-rules-should-not-use-DH_EXTRA_ADDONS ~~
^\s*DH_EXTRA_ADDONS\s*=
+debian-rules-should-not-use-DH_EXTRA_ADDONS ~~
^\s*DH_EXTRA_ADDONS\s*=\s*(?.*)\n
debian-rules-should-not-use-or-modify-user-only-variable ~~ \bDEB_[^_
\t]+FLAGS_(?:SET|APPEND)\b
debian-rules-should-not-use-pwd ~~ \$[\(\{]PWD[\)\}]
debian-rules-should-not-use-underscore-variable ~~ \$[\(\{]_[\)\}]
diff --git a/debian/changelog b/debian/changelog
index f859e79..1b46b54 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -29,6 +29,9 @@ lintian (2.5.69) UNRELEASED; urgency=medium
+ [CL] Ensure that NSS (Name Services Switch) modules are placed in the
"admin" section. Thanks to Mathieu Parent (sathieu) for the patch.
(Closes: #886961)
+ * data/rules/rules-should-not-use:
++ [CL] Include the assigned value in the Lintian output for the
+ debian-rules-should-not-use-DH_EXTRA_ADDONS tag.
-- Chris Lamb Tue, 09 Jan 2018 20:55:21 +0530
diff --git a/t/tests/rules-general/tags b/t/tests/rules-general/tags
index 660bfec..800c2d8 100644
--- a/t/tests/rules-general/tags
+++ b/t/tests/rules-general/tags
@@ -1,6 +1,6 @@
E: rules-general source: clean-should-be-satisfied-by-build-depends debhelper
E: rules-general source: debian-rules-should-not-automatically-update-control
line 3
W: rules-general source: debian-rules-should-not-use-DEB_BUILD_OPTS line 11
-W: rules-general source: debian-rules-should-not-use-DH_EXTRA_ADDONS line 4
+W: rules-general source: debian-rules-should-not-use-DH_EXTRA_ADDONS systemd
(line 4)
W: rules-general source: debian-rules-should-not-use-pwd line 11
W: rules-general source: debian-rules-should-not-use-underscore-variable line
12
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: checks/rules.pm: Allow rules-not-should-not-use data-based tags to capture variables and include them in the emitted tag.
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit 598a4d64c2cc5716f99939e454a6f3bac45276dd
Author: Chris Lamb
Date: Sat Jan 13 11:59:30 2018 +0530
checks/rules.pm: Allow rules-not-should-not-use data-based tags to capture
variables and include them in the emitted tag.
---
checks/rules.pm | 6 +-
debian/changelog | 3 +++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/checks/rules.pm b/checks/rules.pm
index 6d8483a..4b3086a 100644
--- a/checks/rules.pm
+++ b/checks/rules.pm
@@ -230,7 +230,11 @@ sub run {
foreach my $bad_construct ($BAD_CONSTRUCT_IN_RULES->all) {
my $badregex = $BAD_CONSTRUCT_IN_RULES->value($bad_construct);
if ($line =~ m/$badregex/) {
-tag $bad_construct, "line $.";
+if (defined($+{info})) {
+tag $bad_construct, $+{info}, "(line $.)";
+} else {
+tag $bad_construct, "line $.";
+}
}
}
diff --git a/debian/changelog b/debian/changelog
index f987b6b..f859e79 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -15,6 +15,9 @@ lintian (2.5.69) UNRELEASED; urgency=medium
new-package-should-not-package-python2-module tag.
+ [CL] Include the offending package name when warning about
new-package-should-not-package-python2-module.
+ * checks/rules.pm:
++ [CL] Allow rules-not-should-not-use data-based tags to capture
+ variables and include them in the emitted tag.
* checks/source-copyright.{desc,pm}:
+ [CL] Warn about insecure "Format:" URIs that reference debian.org.
Based on a patch by Nicolas Braud-Santoni. (Closes: #886930)
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
Bug#883772: lintian: please don't map implementation language to sections
tags 883772 + pending thanks Hi David, > In case you consider the previous not constructive ;), what about > lowering the severity to "pedantic"? Again, I share your opinion about the entire section thing, just that a bug against Lintian is the best forum for such a discussion :) Lets downgrade it from "W" to "I" at the very least: https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=07bc5dff9aa74e738a24b50b30a2dd8ea103ac27 Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Processed: Re: Bug#883772: lintian: please don't map implementation language to sections
Processing commands for cont...@bugs.debian.org: > tags 883772 + pending Bug #883772 [lintian] lintian: please don't map implementation language to sections Added tag(s) pending. > thanks Stopping processing here. Please contact me if you need assistance. -- 883772: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=883772 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
[lintian] 01/01: checks/fields.desc: Downgrade severity of wrong-section-according-to-package-name from "W:" to "I:". (Closes: #883772)
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit 07bc5dff9aa74e738a24b50b30a2dd8ea103ac27
Author: Chris Lamb
Date: Sat Jan 13 10:36:19 2018 +0530
checks/fields.desc: Downgrade severity of
wrong-section-according-to-package-name from "W:" to "I:". (Closes: #883772)
---
checks/fields.desc| 2 +-
debian/changelog | 3 +++
t/tests/fields-general/tags | 2 +-
t/tests/fields-wrong-section/tags | 36 ++--
t/tests/legacy-libbaz/tags| 6 +++---
5 files changed, 26 insertions(+), 23 deletions(-)
diff --git a/checks/fields.desc b/checks/fields.desc
index 65e5f2e..ee25072 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -949,7 +949,7 @@ Info: The Dm-Upload-Allowed field in this package is set to
something
may not work as expected.
Tag: wrong-section-according-to-package-name
-Severity: normal
+Severity: wishlist
Certainty: possible
Info: This package has a name suggesting that it belongs to a section
other than the one it is currently categorized in.
diff --git a/debian/changelog b/debian/changelog
index 80a29cf..f987b6b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -5,6 +5,9 @@ lintian (2.5.69) UNRELEASED; urgency=medium
* checks/cruft.pm:
+ [CL] Ignore TeX \section (etc.) titles when checking for GFDL
license. Thanks, Norbert Preining for the report. (Closes: #863384)
+ * checks/fields.desc:
++ [CL] Downgrade severity of wrong-section-according-to-package-name
+ from "W:" to "I:". (Closes: #883772)
* checks/python.{pm,desc}:
+ [CL] Don't emit new-package-should-not-package-python2-module if
the maintainer justifies its inclusion in the changelog entry.
diff --git a/t/tests/fields-general/tags b/t/tests/fields-general/tags
index 05241eb..8a4f663 100644
--- a/t/tests/fields-general/tags
+++ b/t/tests/fields-general/tags
@@ -1,5 +1,5 @@
I: fields-general source: debian-control-has-obsolete-dbg-package
fields-general-dbg
+I: fields-general-debug: wrong-section-according-to-package-name
fields-general-debug
W: fields-general source: dbg-package-missing-depends fields-general-dbg
W: fields-general-dbg: superfluous-clutter-in-homepage
[lintian] branch master updated (41bb733 -> 07bc5df)
This is an automated email from the git hooks/post-receive script. lamby pushed a change to branch master in repository lintian. from 41bb733 checks/cruft.pm: Ignore TeX \section (etc.) titles when checking for GFDL license. Thanks, Norbert Preining for the report. (Closes: #863384) new 07bc5df checks/fields.desc: Downgrade severity of wrong-section-according-to-package-name from "W:" to "I:". (Closes: #883772) The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/fields.desc| 2 +- debian/changelog | 3 +++ t/tests/fields-general/tags | 2 +- t/tests/fields-wrong-section/tags | 36 ++-- t/tests/legacy-libbaz/tags| 6 +++--- 5 files changed, 26 insertions(+), 23 deletions(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Bug#883772: lintian: please don't map implementation language to sections
Chris Lamb writes: > Hey David! > >> the programming-language sections are a mess > > Whilst I don't necessarily disagree, I'm not sure what the next steps > for Lintian are here. > > Putting it another way, I see you linked #802488 but until that gets > some kind of resolution (or some change to Policy), what is there for > us to do..? Let me turn that question around. In the absence of clear policy [1] of what belongs in the programming language sections, why should lintian recommend adding things to them? At best it's busywork for maintainers and ftp-masters, and at worst it's making things worse for our users [2]. In case you consider the previous not constructive ;), what about lowering the severity to "pedantic"? [1]: In either the ftp-master reject-faq sense, or the debian policy sense [2]: Assuming some users care about sections as a way to find packages.
Bug#505857: lintian: false positive debian-watch-file-should-mangle-version
Hi, On 12 January 2018 at 12:37, Osamu Aoki wrote: [...] > But what is this "[1]This is on my ToDo list for DEHS2 anyway." in bug > report? Raphael, are you still working on something? My work on DEHS2 is long dead, and I don't remember having actually split uscan into a module - only checkbashisms. Last time I looked at the code it seemed straight forward to at least split the watch file parsing, the target download and parsing by watch file version, and the version mangling stuff. If that's still the case, perhaps it could be a very first version? Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net
Processed: tagging 505857
Processing control commands: > tags 505857 - pending Bug #505857 [lintian] [checks/watch-file] false positive debian-watch-file-should-mangle-version Removed tag(s) pending. -- 505857: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505857 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#505857: tagging 505857
control: tags 505857 - pending thanks Osamu
Bug#505857: lintian: false positive debian-watch-file-should-mangle-version
Hi,
Bug:
https://bugs.debian.org/505857
https://bugs.debian.org/884880 (cloned bug of above)
I just updated manpage of uscan to reduce stress of our fellow DDs for
Bug #884880.
I agree with
> 3.- Long term solution:
> Turn some portions of uscan into a perl module[1] and use it to extract the
> dversionmangle regex.
I agree uscan deserves more code refactoring and it should expose its
internal utilities to other codes. Unfortunately, my skill and time is
not up for the task.
So I simply addressed Chris's concern https://bugs.debian.org/884880#57
by updating the manpage to point people to the pertinent information. I
hope the recent checkin is good enough.
57ea0c53 ("uscan: clarify the importance of version=4", 2018-01-12)
But what is this "[1]This is on my ToDo list for DEHS2 anyway." in bug
report? Raphael, are you still working on something?
Regards,
Osamu
Processed: Bug#505857 marked as pending
Processing commands for cont...@bugs.debian.org: > tag 505857 pending Bug #505857 [lintian] [checks/watch-file] false positive debian-watch-file-should-mangle-version Added tag(s) pending. > thanks Stopping processing here. Please contact me if you need assistance. -- 505857: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505857 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#863384: lintian: check license-problem-gfdl-invariants is incorrect
> > https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=41bb73396b9a203598295c8c290ff0b322119f0a Thanks. Norbert -- PREINING Norbert http://www.preining.info Accelia Inc. +JAIST +TeX Live +Debian Developer GPG: 0x860CDC13 fp: F7D8 A928 26E3 16A1 9FA0 ACF0 6CAC A448 860C DC13
