Bug#887428: lintian: Use of uninitialized value in string ne at /usr/share/perl5/Lintian/Collect/Package.pm line 579

2018-01-16 Thread Hilmar Preuße
Package: lintian
Version: 2.5.70
Severity: normal

Dear Maintainer,

   * What led up to the situation?

I'm building a package. After the build is done, lintian is called and writes a 
lot of these messages:

Use of uninitialized value $target in string ne at 
/usr/share/perl5/Lintian/Collect/Package.pm line 579, <$_[...]> line 2798.
Use of uninitialized value in string ne at 
/usr/share/perl5/Lintian/Collect/Package.pm line 579, <$_[...]> line 2798.
Use of uninitialized value $target in string ne at 
/usr/share/perl5/Lintian/Collect/Package.pm line 579, <$_[...]> line 2798.
Use of uninitialized value in string ne at 
/usr/share/perl5/Lintian/Collect/Package.pm line 579, <$_[...]> line 2798.

I'm pretty shure this was introduced in 2.5.68.

Hilmar
-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 4.14.0-3-686-pae (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_GB.UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set 
to en_GB.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils  2.29.1-13
ii  bzip2 1.0.6-8.1
ii  diffstat  1.61-1+b1
ii  dpkg  1.19.0.4
ii  file  1:5.32-1
ii  gettext   0.19.8.1-4
ii  intltool-debian   0.35.0+20060710.4
ii  libapt-pkg-perl   0.1.33
ii  libarchive-zip-perl   1.60-1
ii  libclass-accessor-perl0.51-1
ii  libclone-perl 0.39-1
ii  libdigest-sha-perl6.01-1
ii  libdpkg-perl  1.19.0.4
ii  libemail-valid-perl   1.202-1
ii  libfile-basedir-perl  0.07-1
ii  libipc-run-perl   0.96-1
ii  liblist-moreutils-perl0.416-1+b3
ii  libparse-debianchangelog-perl 1.2.0-12
ii  libperl5.26 [libdigest-sha-perl]  5.26.1-4
ii  libtext-levenshtein-perl  0.13-1
ii  libtimedate-perl  2.3000-2
ii  liburi-perl   1.73-1
ii  libxml-simple-perl2.24-1
ii  libyaml-libyaml-perl  0.63-2+b2
ii  man-db2.7.6.1-4
ii  patchutils0.3.4-2
ii  perl  5.26.1-4
ii  t1utils   1.41-2
ii  xz-utils  5.2.2-1.3

Versions of packages lintian recommends:
pn  libperlio-gzip-perl  

Versions of packages lintian suggests:
pn  binutils-multiarch 
ii  dpkg-dev   1.19.0.4
ii  libhtml-parser-perl3.72-3+b2
ii  libtext-template-perl  1.47-1

-- no debconf information



Bug#887428: lintian: Use of uninitialized value in string ne at /usr/share/perl5/Lintian/Collect/Package.pm line 579

2018-01-16 Thread Chris Lamb

Hi Hilmar, 

> I'm building a package. After the build is done, lintian is called and 
> writes a lot of these messages:

But what is the package called..? :) How might I reproduce this? 


Regards, 

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#887428: lintian: Use of uninitialized value in string ne at /usr/share/perl5/Lintian/Collect/Package.pm line 579

2018-01-16 Thread Hilmar Preuße

Am 16.01.2018 um 16:40 teilte Chris Lamb mit:

Hi Chris,


I'm building a package. After the build is done, lintian is called and
writes a lot of these messages:


But what is the package called..? :) How might I reproduce this?

Hmm, this is proftp 1.3.6, not yet in the archive. I could upload 
orig.tar.gz, debian.tar.gz anywhere if you like to. Please drop me a note.


Hilmar
--
#206401 http://counter.li.org



Bug#886219: lintian should be less pedantic about latest policy version

2018-01-16 Thread Ian Jackson
Mattia Rizzolo writes ("Re: Bug#886219: lintian should be less pedantic about 
latest policy version"):
> Currently there are two related tags:
> * https://lintian.debian.org/tags/out-of-date-standards-version.html
>   which is reported when an upload is done and the date of the
>   changelog is older than the date of a policy release newer than what
>   is in Std-Ver. (I.e. a package doesn't get this if no uploads are
>   done, but it assumes that when somebody updates a package the
>   maintainer checks whether it is compliant to the very last Policy
>   update, which IMHO it is totally reasonable…?)

I'm afraid I disagree.  I think it is not reasonable to expect a
maintainer to always double-check for the latest policy updates on
every upload.  Even for packages I care a lot about I check for policy
updates on each package only once or twice per Debian release.

> If you update your package you should spend your time checking it is
> still Policy compliant (how would you know it is otherwise without
> checking?!),

I think a maintainer can safely rely on the rest of the Debian project
not declaring your package buggy enough that you definitely need to do
something about it right now.  Unless one hears to the contrary some
other way, of course.

Ian.



Bug#886219: lintian should be less pedantic about latest policy version

2018-01-16 Thread Ian Jackson
Sean Whitton writes ("Re: Bug#886219: lintian should be less pedantic about 
latest policy version"):
> Let me first say exactly what change I'd recommend:
> - out-of-date-standards-version should be I: or P: instead of W:
> - ancient-standards-version should remain W:
> - ancient-standards-version should be triggered when S-V contains a
>   release of Policy from the previous stable release cycle
...
> You argue that
> - whenever a maintainer uploads a package and S-V is out-of-date, they
>   should work through the relevant entries in the Policy Manual's
>   Upgrading Checklist
> - Policy Manual releases should be infrequent to avoid maintainers
>   having to do this too often
> 
> On the contrary, I argue that
> - the only thing that should be /required/ when uploading a package is
>   making the package non-trivially better than the current version in
>   unstable
> - updating S-V should never block uploading other improvements
> - there are good reasons to release the Policy Manual frequently, and
>   this should not be blocked by the expectation that everyone respond to
>   those new versions in their very next uploads.

Thank you, Sean, for arguing this so much better than I am doing.

> Also relevant here is Enrico's talk at DebConf17,[1] where he cautioned
> against manipulating volunteers into doing work.  Requiring prerequisite
> work that is not necessary for co-ordinating with other volunteers might
> well fall into that category.
> 
> [1] https://debconf17.debconf.org/talks/92/

I clearly must watch this talk.

Ian.



Bug#887428: lintian: Use of uninitialized value in string ne at /usr/share/perl5/Lintian/Collect/Package.pm line 579

2018-01-16 Thread Niels Thykier
On Tue, 16 Jan 2018 21:10:53 +0530 Chris Lamb  wrote:
> 
> Hi Hilmar, 
> 
> > I'm building a package. After the build is done, lintian is called and 
> > writes a lot of these messages:
> 
> But what is the package called..? :) How might I reproduce this? 
> 
> 
> Regards, 
> 
> -- 
>   ,''`.
>  : :'  : Chris Lamb
>  `. `'`  la...@debian.org / chris-lamb.co.uk
>`-
> 
> 

This bug appears to be reproducible on lindsay.d.o:

"""
linday.d.o $ grep 'Use of uninitialized ' lintian.log -c
4148
"""

(In case you are missing material for debugging)

Thanks,
~Niels



[lintian] 01/01: lib/Lintian/Collect/Package.pm: Fix "Use of uninitialized value in string ne" warnings that would have appeared as part of the src-orig-index handling in 2.5.66. (Closes: #887428)

2018-01-16 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 1d7d5f746fe774c5e0d6bde66bbcdb2d181f73d8
Author: Chris Lamb 
Date:   Wed Jan 17 08:57:27 2018 +1100

lib/Lintian/Collect/Package.pm: Fix "Use of uninitialized value in string 
ne" warnings that would have appeared as part of the src-orig-index handling in 
2.5.66. (Closes: #887428)
---
 debian/changelog   | 5 +
 lib/Lintian/Collect/Package.pm | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index 6eaca4c..f4ec5fe 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,11 @@ lintian (2.5.71) UNRELEASED; urgency=medium
 
   XXX: generate tag summary
 
+  * lib/Lintian/Collect/Package.pm:
++ [CL] Fix "Use of uninitialized value in string ne" warnings that
+  would have appeared as part of the src-orig-index handling in 2.5.66.
+  (Closes: #887428)
+
  -- Chris Lamb   Tue, 16 Jan 2018 18:03:37 +1100
 
 lintian (2.5.70) unstable; urgency=medium
diff --git a/lib/Lintian/Collect/Package.pm b/lib/Lintian/Collect/Package.pm
index 8a12dee..5b95f60 100644
--- a/lib/Lintian/Collect/Package.pm
+++ b/lib/Lintian/Collect/Package.pm
@@ -576,7 +576,7 @@ sub _fetch_index_data {
   | Lintian::Path::TYPE_HARDLINK;
 $le->{link} = $target;
 }
-if ($target ne $e->{name}) {
+if (defined($target) and $target ne $e->{name}) {
 $idxh{$target}{'_path_info'}
   = ($idxh{$target}{'_path_info'}
   & ~Lintian::Path::TYPE_HARDLINK)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch master updated (deb202d -> 1d7d5f7)

2018-01-16 Thread Chris Lamb
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  deb202d   Open new changelog entry for 2.5.71.
   new  1d7d5f7   lib/Lintian/Collect/Package.pm: Fix "Use of uninitialized 
value in string ne" warnings that would have appeared as part of the 
src-orig-index handling in 2.5.66. (Closes: #887428)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 debian/changelog   | 5 +
 lib/Lintian/Collect/Package.pm | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



Bug#887428: lintian: Use of uninitialized value in string ne at /usr/share/perl5/Lintian/Collect/Package.pm line 579

2018-01-16 Thread Chris Lamb
tags 887428 + pending
found 887428 2.5.66
thanks

Fixed in Git:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=1d7d5f746fe774c5e0d6bde66bbcdb2d181f73d8


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Processed: Re: lintian: Use of uninitialized value in string ne at /usr/share/perl5/Lintian/Collect/Package.pm line 579

2018-01-16 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> tags 887428 + pending
Bug #887428 [lintian] lintian: Use of uninitialized value in string ne at 
/usr/share/perl5/Lintian/Collect/Package.pm line 579
Added tag(s) pending.
> found 887428 2.5.66
Bug #887428 [lintian] lintian: Use of uninitialized value in string ne at 
/usr/share/perl5/Lintian/Collect/Package.pm line 579
Marked as found in versions lintian/2.5.66.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
887428: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=887428
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



[lintian] 01/01: spelling: Add another correction

2018-01-16 Thread Paul Wise
This is an automated email from the git hooks/post-receive script.

pabs pushed a commit to branch master
in repository lintian.

commit c8226feef6014673f820e5f9a4ab7ea526d8991d
Author: Paul Wise 
Date:   Wed Jan 17 12:35:20 2018 +0800

spelling: Add another correction
---
 data/spelling/corrections | 1 +
 1 file changed, 1 insertion(+)

diff --git a/data/spelling/corrections b/data/spelling/corrections
index 08fbf37..06c1e4b 100644
--- a/data/spelling/corrections
+++ b/data/spelling/corrections
@@ -637,6 +637,7 @@ certicate||certificate
 certicates||certificates
 certifcate||certificate
 certifcates||certificates
+certificat||certificate
 challanage||challenge
 challange||challenge
 challanges||challenges

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git



[lintian] branch master updated (1d7d5f7 -> c8226fe)

2018-01-16 Thread Paul Wise
This is an automated email from the git hooks/post-receive script.

pabs pushed a change to branch master
in repository lintian.

  from  1d7d5f7   lib/Lintian/Collect/Package.pm: Fix "Use of uninitialized 
value in string ne" warnings that would have appeared as part of the 
src-orig-index handling in 2.5.66. (Closes: #887428)
   new  c8226fe   spelling: Add another correction

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 data/spelling/corrections | 1 +
 1 file changed, 1 insertion(+)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git