[lintian] branch master updated (5639a80 -> 869ffa8)
This is an automated email from the git hooks/post-receive script.
lamby pushed a change to branch master
in repository lintian.
from 5639a80 Check "$vendor.series" (not "series.$vendor") when
checking for the patch-file-present-but-not-mentioned-in-series tag.
new 869ffa8 checks/patch-systems.pm: Check basename for README or
README.patches for subdirs.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.
Summary of changes:
checks/patch-systems.pm | 6 ++
.../debian/debian/patches/{ => subdir}/README | 0
2 files changed, 2 insertions(+), 4 deletions(-)
copy t/tests/patch-systems-quilt-general/debian/debian/patches/{ =>
subdir}/README (100%)
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: checks/patch-systems.pm: Check basename for README or README.patches for subdirs.
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit 869ffa875c700e324f2b256ba403a14506efb0ad
Author: Chris Lamb
Date: Mon Jan 22 19:58:26 2018 +1100
checks/patch-systems.pm: Check basename for README or README.patches for
subdirs.
---
checks/patch-systems.pm | 6 ++
.../patch-systems-quilt-general/debian/debian/patches/subdir/README | 1 +
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/checks/patch-systems.pm b/checks/patch-systems.pm
index 557e0b1..fb2e629 100644
--- a/checks/patch-systems.pm
+++ b/checks/patch-systems.pm
@@ -48,10 +48,7 @@ sub run {
return if not $droot;
my $dpdir = $droot->resolve_path('patches');
my $patch_series;
-my %known_files = (
-'README' => 1,
-'README.patches' => 1,
-);
+my %known_files;
# Find debian/patches/series, assuming debian/patches is a (symlink to a)
# dir. There are cases, where it is a file (ctwm: #778556)
@@ -243,6 +240,7 @@ sub run {
}
foreach my $file ($dpdir->children('breadth-first')) {
+next if $file->basename =~ /^README(\.patches)?$/;
# Use path relative to debian/patches for "subdir/foo"
my $name = substr($file, length $dpdir);
tag 'patch-file-present-but-not-mentioned-in-series', $name
diff --git
a/t/tests/patch-systems-quilt-general/debian/debian/patches/subdir/README
b/t/tests/patch-systems-quilt-general/debian/debian/patches/subdir/README
new file mode 100644
index 000..843d249
--- /dev/null
+++ b/t/tests/patch-systems-quilt-general/debian/debian/patches/subdir/README
@@ -0,0 +1 @@
+false positive for patch-file-present-but-not-mentioned-in-series tag
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Clarify that paragraph ordering matters in the description of the unused-file-paragraph-in-dep5-copyright tag. (Closes: #762261)
This is an automated email from the git hooks/post-receive script. lamby pushed a commit to branch master in repository lintian. commit 21a7e4bc54cdffabf34e7811d58b91cfe718ac50 Author: Chris Lamb Date: Mon Jan 22 22:10:37 2018 +1100 Clarify that paragraph ordering matters in the description of the unused-file-paragraph-in-dep5-copyright tag. (Closes: #762261) --- checks/source-copyright.desc | 8 ++-- debian/changelog | 3 +++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/checks/source-copyright.desc b/checks/source-copyright.desc index 65acc21..9240999 100644 --- a/checks/source-copyright.desc +++ b/checks/source-copyright.desc @@ -320,8 +320,12 @@ Tag: unused-file-paragraph-in-dep5-copyright Severity: minor Certainty: possible Ref: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ -Info: The Files paragraph in debian/copyright is superfluous as it is - never used to match any files. You should be able to safely remove it. +Info: The Files paragraph in debian/copyright appears to be + superfluous as it is does not match any files. + . + You should be able to safely remove it. + . + This can also be caused by incorrect relative ordering of paragraphs. Tag: source-includes-file-in-files-excluded Severity: serious diff --git a/debian/changelog b/debian/changelog index 8b455a3..a5dcceb 100644 --- a/debian/changelog +++ b/debian/changelog @@ -13,6 +13,9 @@ lintian (2.5.72) UNRELEASED; urgency=medium patch-file-present-but-not-mentioned-in-series tag. + [CL] Check "$vendor.series" (not "series.$vendor") when checking for the patch-file-present-but-not-mentioned-in-series tag. + * checks/source-copyright.desc: ++ [CL] Clarify that paragraph ordering matters in the description of + the unused-file-paragraph-in-dep5-copyright tag. (Closes: #762261) -- Chris Lamb Sun, 21 Jan 2018 16:42:25 +1100 -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (869ffa8 -> 21a7e4b)
This is an automated email from the git hooks/post-receive script. lamby pushed a change to branch master in repository lintian. from 869ffa8 checks/patch-systems.pm: Check basename for README or README.patches for subdirs. new 21a7e4b Clarify that paragraph ordering matters in the description of the unused-file-paragraph-in-dep5-copyright tag. (Closes: #762261) The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/source-copyright.desc | 8 ++-- debian/changelog | 3 +++ 2 files changed, 9 insertions(+), 2 deletions(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: debian/copyright: Add missing initials for Gergely Nagy, Sylvestre Ledru and Steve Langasek. (Closes: #831729)
This is an automated email from the git hooks/post-receive script. lamby pushed a commit to branch master in repository lintian. commit 4df4b67f1c4865eaedd9ab6525ac337bfc3e7bdd Author: Chris Lamb Date: Mon Jan 22 22:14:23 2018 +1100 debian/copyright: Add missing initials for Gergely Nagy, Sylvestre Ledru and Steve Langasek. (Closes: #831729) --- debian/changelog | 4 debian/copyright | 3 +++ 2 files changed, 7 insertions(+) diff --git a/debian/changelog b/debian/changelog index a5dcceb..9d223c0 100644 --- a/debian/changelog +++ b/debian/changelog @@ -17,6 +17,10 @@ lintian (2.5.72) UNRELEASED; urgency=medium + [CL] Clarify that paragraph ordering matters in the description of the unused-file-paragraph-in-dep5-copyright tag. (Closes: #762261) + * debian/copyright: ++ [CL] Add missing initials for Gergely Nagy, Sylvestre Ledru and Steve + Langasek. (Closes: #831729) + -- Chris Lamb Sun, 21 Jan 2018 16:42:25 +1100 lintian (2.5.71) unstable; urgency=medium diff --git a/debian/copyright b/debian/copyright index 77cf868..90eff39 100644 --- a/debian/copyright +++ b/debian/copyright @@ -31,6 +31,9 @@ Comment: PW == Paul Wise CL == Chris Lamb EB == Edward Betts + GN == Gergely Nagy + SL == Sylvestre Ledru + SRL == Steve Langasek . Lintian is maintained in git. The current development version may be checked out from: -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (21a7e4b -> 4df4b67)
This is an automated email from the git hooks/post-receive script. lamby pushed a change to branch master in repository lintian. from 21a7e4b Clarify that paragraph ordering matters in the description of the unused-file-paragraph-in-dep5-copyright tag. (Closes: #762261) new 4df4b67 debian/copyright: Add missing initials for Gergely Nagy, Sylvestre Ledru and Steve Langasek. (Closes: #831729) The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: debian/changelog | 4 debian/copyright | 3 +++ 2 files changed, 7 insertions(+) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Bug#762261: new tag unused-file-paragraph-in-dep5-copyright is rather confusing
tags 762261 + pending thanks Fixed in Git: https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=21a7e4bc54cdffabf34e7811d58b91cfe718ac50 Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#720913: lintian: F-P package-contains-empty-directory with triggers
tags 720913 + moreinfo thanks Niels Thykier wrote: > A notable example here is libreoffice that contains an empty dir and > installs a trigger for it[1]. > > [1] > http://lintian.debian.org/full/debian-openoff...@lists.debian.org.html#libreoffice Can you clarify what you mean by trigger here? I don't see anything in the package's control scripts, not in src:libreoffice Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Processed: Re: new tag unused-file-paragraph-in-dep5-copyright is rather confusing
Processing commands for cont...@bugs.debian.org: > tags 762261 + pending Bug #762261 [lintian] new tag unused-file-paragraph-in-dep5-copyright is rather confusing Added tag(s) pending. > thanks Stopping processing here. Please contact me if you need assistance. -- 762261: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762261 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Re: lintian: commiters' initials missing from d/copyright
Processing commands for cont...@bugs.debian.org: > tags 831729 + pending Bug #831729 [src:lintian] lintian: commiters' initials missing from d/copyright Added tag(s) pending. > thanks Stopping processing here. Please contact me if you need assistance. -- 831729: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=831729 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Re: lintian: F-P package-contains-empty-directory with triggers
Processing commands for cont...@bugs.debian.org: > tags 720913 + moreinfo Bug #720913 [lintian] lintian: F-P package-contains-empty-directory with triggers Added tag(s) moreinfo. > thanks Stopping processing here. Please contact me if you need assistance. -- 720913: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=720913 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#831729: lintian: commiters' initials missing from d/copyright
tags 831729 + pending thanks Fixed in Git: https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=4df4b67f1c4865eaedd9ab6525ac337bfc3e7bdd Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#869547: udev-rule-missing-subsystem false-positive when rules file uses a GOTO
Hi Didier, > usb-modeswitch-data ships with 40-usb_modeswitch.rules [0] which has 388 > rules that all trigger the udev-rule-missing-subsystem lintian warning. > Point is, that file has all the matching entries within a SUBSYSTEM/GOTO > block How common are GOTO blocks in .rules files? Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#762261: lintian: introduce a inexistent-file-in-dep5-copyright rather confusing
Control: clone -1 -2 Control: tag -2 - pending Control: retitle -2 lintian: introduce a inexistent-file-in-dep5-copyright Control: severity -2 wishlist On Sat, Sep 20, 2014 at 11:15:16AM +0200, Mattia Rizzolo wrote: > 1) split the check in something like inexistent-file-in-dep5-copyright and >overridden-file-paragraph-in-dep5-copyright > 2) extend the description to tell about the importance of the paragraph order So now point 2 has been committed to git, but after all I believe the first one should be done *as well*, so I'm cloning/retiteling for it. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Processed: lintian: introduce a inexistent-file-in-dep5-copyright rather confusing
Processing control commands: > clone -1 -2 Bug #762261 [lintian] new tag unused-file-paragraph-in-dep5-copyright is rather confusing Bug 762261 cloned as bug 888001 > tag -2 - pending Bug #888001 [lintian] new tag unused-file-paragraph-in-dep5-copyright is rather confusing Removed tag(s) pending. > retitle -2 lintian: introduce a inexistent-file-in-dep5-copyright Bug #888001 [lintian] new tag unused-file-paragraph-in-dep5-copyright is rather confusing Changed Bug title to 'lintian: introduce a inexistent-file-in-dep5-copyright' from 'new tag unused-file-paragraph-in-dep5-copyright is rather confusing'. > severity -2 wishlist Bug #888001 [lintian] lintian: introduce a inexistent-file-in-dep5-copyright Severity set to 'wishlist' from 'minor' -- 762261: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762261 888001: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888001 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Re: lintian: introduce a inexistent-file-in-dep5-copyright
Processing commands for cont...@bugs.debian.org: > retitle 888001 lintian: split a new "non-existent-file-in-dep5-copyright" tag > from unused-file-paragraph-in-dep5-copyright Bug #888001 [lintian] lintian: introduce a inexistent-file-in-dep5-copyright Changed Bug title to 'lintian: split a new "non-existent-file-in-dep5-copyright" tag from unused-file-paragraph-in-dep5-copyright' from 'lintian: introduce a inexistent-file-in-dep5-copyright'. > thanks Stopping processing here. Please contact me if you need assistance. -- 888001: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888001 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
[lintian] 01/01: spelling: Add another correction
This is an automated email from the git hooks/post-receive script. pabs pushed a commit to branch master in repository lintian. commit b91bd57a7b0451b4783d5317a22a4ed2fbbcb2a1 Author: Paul Wise Date: Tue Jan 23 08:20:03 2018 +0800 spelling: Add another correction --- data/spelling/corrections | 1 + 1 file changed, 1 insertion(+) diff --git a/data/spelling/corrections b/data/spelling/corrections index 9d6376f..86ef528 100644 --- a/data/spelling/corrections +++ b/data/spelling/corrections @@ -2368,6 +2368,7 @@ leats||least leightweight||lightweight lengh||length lenghs||lengths +lenghtening||lengthening lenght||length lenghts||lengths lenghty||lengthy -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (4df4b67 -> b91bd57)
This is an automated email from the git hooks/post-receive script. pabs pushed a change to branch master in repository lintian. from 4df4b67 debian/copyright: Add missing initials for Gergely Nagy, Sylvestre Ledru and Steve Langasek. (Closes: #831729) new b91bd57 spelling: Add another correction The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: data/spelling/corrections | 1 + 1 file changed, 1 insertion(+) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: spelling: Add another correction
This is an automated email from the git hooks/post-receive script. pabs pushed a commit to branch master in repository lintian. commit 2f529aeeef2b7b5a7132a4ad3f95f780d0d8db05 Author: Paul Wise Date: Tue Jan 23 08:39:13 2018 +0800 spelling: Add another correction --- data/spelling/corrections | 1 + 1 file changed, 1 insertion(+) diff --git a/data/spelling/corrections b/data/spelling/corrections index 86ef528..e8c8626 100644 --- a/data/spelling/corrections +++ b/data/spelling/corrections @@ -3850,6 +3850,7 @@ tranlations||translations tranlation||translation tranparently||transparently tranparent||transparent +tranport||transport transalte||translate transations||transactions transation||transaction -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (b91bd57 -> 2f529ae)
This is an automated email from the git hooks/post-receive script. pabs pushed a change to branch master in repository lintian. from b91bd57 spelling: Add another correction new 2f529ae spelling: Add another correction The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: data/spelling/corrections | 1 + 1 file changed, 1 insertion(+) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Processed: Re: lintian: * matches too much in overrides?
Processing commands for cont...@bugs.debian.org: > retitle 878557 lintian: * matches too much in overrides? Bug #878557 [lintian] lintian: * matches too much? Changed Bug title to 'lintian: * matches too much in overrides?' from 'lintian: * matches too much?'. > thanks Stopping processing here. Please contact me if you need assistance. -- 878557: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878557 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
[lintian] 01/01: Ensure xfonts-foo are recognised as part of the "x11" section to match the definition on https://packages.debian.org/en/sid/. (Closes: #878609)
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit 9df7f66ef14f64f3bf1de49bfb188c7ee817eb67
Author: Chris Lamb
Date: Tue Jan 23 14:51:28 2018 +1100
Ensure xfonts-foo are recognised as part of the "x11" section to match the
definition on https://packages.debian.org/en/sid/. (Closes: #878609)
---
data/fields/name_section_mappings | 3 ++-
debian/changelog | 5 +
.../fields-wrong-section/debian/debian/control.in | 23 ++
t/tests/fields-wrong-section/tags | 2 ++
4 files changed, 32 insertions(+), 1 deletion(-)
diff --git a/data/fields/name_section_mappings
b/data/fields/name_section_mappings
index fba241b..6c67cae 100644
--- a/data/fields/name_section_mappings
+++ b/data/fields/name_section_mappings
@@ -33,7 +33,8 @@ lib.*-cil(?:-dev)?$ => cli-mono
^lib.*-(tcl|lua|gst)$ => interpreters
# data files
^gir\d+\.\d+-.*-\d+\.\d+$=> introspection
-^(?:x?fonts|ttf)- => fonts
+^xfonts-=> x11
+^(?:fonts|ttf)- => fonts
^lib(?:nss|pam)-=> admin
^(?:aspell|hunspell|myspell|mythes)-=> localization
^hyphen-[a-z]{2}(?:-[a-z]{2})?$ => localization
diff --git a/debian/changelog b/debian/changelog
index 9d223c0..9355142 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -17,6 +17,11 @@ lintian (2.5.72) UNRELEASED; urgency=medium
+ [CL] Clarify that paragraph ordering matters in the description of
the unused-file-paragraph-in-dep5-copyright tag. (Closes: #762261)
+ * data/fields/name_section_mappings:
++ [CL] Ensure xfonts-foo are recognised as part of the "x11" section to
+ match the definition on https://packages.debian.org/en/sid/.
+ (Closes: #878609)
+
* debian/copyright:
+ [CL] Add missing initials for Gergely Nagy, Sylvestre Ledru and Steve
Langasek. (Closes: #831729)
diff --git a/t/tests/fields-wrong-section/debian/debian/control.in
b/t/tests/fields-wrong-section/debian/debian/control.in
index 73bc853..e745d90 100644
--- a/t/tests/fields-wrong-section/debian/debian/control.in
+++ b/t/tests/fields-wrong-section/debian/debian/control.in
@@ -228,3 +228,26 @@ Description: {$description} (PAM module with number suffix)
Lintian. It is part of the Lintian test suite and may do very odd
things. It should not be installed like a regular package. It may
be an empty package.
+
+Package: fonts-{$source}1
+Architecture: all
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Multi-Arch: foreign
+Description: {$description} (fonts)
+ Test for font modules.
+ .
+ This is a test package designed to exercise some feature or tag of
+ Lintian. It is part of the Lintian test suite and may do very odd
+ things. It should not be installed like a regular package. It may
+ be an empty package.
+
+Package: xfonts-{$source}1
+Architecture: all
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Description: {$description} (xfonts)
+ Test for xfonts modules.
+ .
+ This is a test package designed to exercise some feature or tag of
+ Lintian. It is part of the Lintian test suite and may do very odd
+ things. It should not be installed like a regular package. It may
+ be an empty package.
diff --git a/t/tests/fields-wrong-section/tags
b/t/tests/fields-wrong-section/tags
index ac9a891..d6e8996 100644
--- a/t/tests/fields-wrong-section/tags
+++ b/t/tests/fields-wrong-section/tags
@@ -2,6 +2,7 @@ I: fields-wrong-section source:
debian-control-has-obsolete-dbg-package fields-w
I: fields-wrong-section-contrib-doc: wrong-section-according-to-package-name
fields-wrong-section-contrib-doc => contrib/doc
I: fields-wrong-section-dbg: wrong-section-according-to-package-name
fields-wrong-section-dbg => debug
I: fields-wrong-section-doc: wrong-section-according-to-package-name
fields-wrong-section-doc => doc
+I: fonts-fields-wrong-section1: wrong-section-according-to-package-name
fonts-fields-wrong-section1 => fonts
I: gir1.2-fields-wrong-section-0.1: wrong-section-according-to-package-name
gir1.2-fields-wrong-section-0.1 => introspection
I: libfields-wrong-section-cil: wrong-section-according-to-package-name
libfields-wrong-section-cil => cli-mono
I: libfields-wrong-section-dev: wrong-section-according-to-package-name
libfields-wrong-section-dev => libdevel
@@ -18,3 +19,4 @@ I: libphp-fields-wrong-section:
wrong-section-according-to-package-name libphp-f
I: python-fields-wrong-section: wrong-section-according-to-package-name
python-fields-wrong-section => python
I: python3-fields-wrong-section: wrong-section-according-to-package-name
python3-fields-wrong-section => python
I: r-cran-fields-wrong-section: wrong-section-according-to-package-name
r-cran-fields-wrong-section => gnu-r
+I: xfonts-fields-wrong-section1: wrong-section-accordin
[lintian] 01/01: Also check xfonts-foo for font-package-not-multi-arch-foreign.
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit 396ec6085e9e715343500c9905b34eb9173f7cad
Author: Chris Lamb
Date: Tue Jan 23 14:54:29 2018 +1100
Also check xfonts-foo for font-package-not-multi-arch-foreign.
---
checks/fields.pm | 2 +-
debian/changelog | 2 ++
t/tests/fields-wrong-section/debian/debian/control.in | 1 +
3 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/checks/fields.pm b/checks/fields.pm
index 976f6fb..cf341c9 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -357,7 +357,7 @@ sub run {
}
if ($type eq 'binary'){
-if ($pkg =~ /^fonts-/) {
+if ($pkg =~ /^x?fonts-/) {
tag 'font-package-not-multi-arch-foreign'
unless $info->field('multi-arch', 'no')
=~ m/^(?:foreign|allowed)$/o;
diff --git a/debian/changelog b/debian/changelog
index 9355142..0274543 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,6 +6,8 @@ lintian (2.5.72) UNRELEASED; urgency=medium
+ [CL] Warn about packages that use about dh_systemd_enable or
dh_systemd_start overrides whilst using debhelper compat level 11 as
they are no longer being called. (Closes: #887899)
+ * checks/fields.pm:
++ [CL] Also check xfonts-foo for font-package-not-multi-arch-foreign.
* checks/patch-systems.{desc,pm}:
+ [CL] Ignore files called "README" or "README.patches" when checking
packages for patch-file-present-but-not-mentioned-in-series.
diff --git a/t/tests/fields-wrong-section/debian/debian/control.in
b/t/tests/fields-wrong-section/debian/debian/control.in
index e745d90..dc8fa8b 100644
--- a/t/tests/fields-wrong-section/debian/debian/control.in
+++ b/t/tests/fields-wrong-section/debian/debian/control.in
@@ -244,6 +244,7 @@ Description: {$description} (fonts)
Package: xfonts-{$source}1
Architecture: all
Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Multi-Arch: foreign
Description: {$description} (xfonts)
Test for xfonts modules.
.
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (9df7f66 -> 396ec60)
This is an automated email from the git hooks/post-receive script. lamby pushed a change to branch master in repository lintian. from 9df7f66 Ensure xfonts-foo are recognised as part of the "x11" section to match the definition on https://packages.debian.org/en/sid/. (Closes: #878609) new 396ec60 Also check xfonts-foo for font-package-not-multi-arch-foreign. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/fields.pm | 2 +- debian/changelog | 2 ++ t/tests/fields-wrong-section/debian/debian/control.in | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (2f529ae -> 9df7f66)
This is an automated email from the git hooks/post-receive script. lamby pushed a change to branch master in repository lintian. from 2f529ae spelling: Add another correction new 9df7f66 Ensure xfonts-foo are recognised as part of the "x11" section to match the definition on https://packages.debian.org/en/sid/. (Closes: #878609) The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: data/fields/name_section_mappings | 3 ++- debian/changelog | 5 + .../fields-wrong-section/debian/debian/control.in | 23 ++ t/tests/fields-wrong-section/tags | 2 ++ 4 files changed, 32 insertions(+), 1 deletion(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Bug#878609: lintian: detection of xfonts- packages as section fonts
tags 878609 + pending thanks Fixed in Git: https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=9df7f66ef14f64f3bf1de49bfb188c7ee817eb67 Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Processed: Re: lintian: detection of xfonts- packages as section fonts
Processing commands for cont...@bugs.debian.org: > tags 878609 + pending Bug #878609 [lintian] lintian: detection of xfonts- packages as section fonts Added tag(s) pending. > thanks Stopping processing here. Please contact me if you need assistance. -- 878609: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878609 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
[lintian] 01/01: Downgrade extra-license-file from "W" to "I". (Closes: #740118)
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit 0b70f0a2aab84f196be14364fbc74f43c83c9f29
Author: Chris Lamb
Date: Tue Jan 23 14:57:56 2018 +1100
Downgrade extra-license-file from "W" to "I". (Closes: #740118)
---
checks/files.desc| 2 +-
debian/changelog | 2 ++
t/tests/files-extra-license/tags | 2 +-
t/tests/legacy-filenames/tags| 6 +++---
4 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/checks/files.desc b/checks/files.desc
index e099893..3d1f980 100644
--- a/checks/files.desc
+++ b/checks/files.desc
@@ -554,7 +554,7 @@ Info: This package installs a file perllocal.pod.
Since that
existed there.
Tag: extra-license-file
-Severity: normal
+Severity: wishlist
Certainty: possible
Ref: policy 12.5
Info: All license information should be collected in the
diff --git a/debian/changelog b/debian/changelog
index 0274543..98ec83a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -8,6 +8,8 @@ lintian (2.5.72) UNRELEASED; urgency=medium
they are no longer being called. (Closes: #887899)
* checks/fields.pm:
+ [CL] Also check xfonts-foo for font-package-not-multi-arch-foreign.
+ * checks/files.desc:
++ [CL] Downgrade extra-license-file from "W" to "I". (Closes: #740118)
* checks/patch-systems.{desc,pm}:
+ [CL] Ignore files called "README" or "README.patches" when checking
packages for patch-file-present-but-not-mentioned-in-series.
diff --git a/t/tests/files-extra-license/tags b/t/tests/files-extra-license/tags
index 2dbaffc..34216da 100644
--- a/t/tests/files-extra-license/tags
+++ b/t/tests/files-extra-license/tags
@@ -1 +1 @@
-W: files-extra-license: extra-license-file
usr/share/doc/files-extra-license/license.txt
+I: files-extra-license: extra-license-file
usr/share/doc/files-extra-license/license.txt
diff --git a/t/tests/legacy-filenames/tags b/t/tests/legacy-filenames/tags
index 566c392..4fe90c4 100644
--- a/t/tests/legacy-filenames/tags
+++ b/t/tests/legacy-filenames/tags
@@ -38,6 +38,9 @@ E: more-filename-games: no-copyright-file
I: filename-games: no-md5sums-control-file
I: filename-games: package-contains-empty-directory usr/games/
I: filenames: duplicated-compressed-file usr/share/filenames/prototype.js.gz
+I: filenames: extra-license-file usr/share/pixmaps/COPYING
+I: filenames: extra-license-file usr/share/pixmaps/license.foo
+I: filenames: extra-license-file usr/share/pixmaps/license.txt
I: filenames: no-md5sums-control-file
I: filenames: package-contains-empty-directory
usr/lib/ma-dir/perl/version/.arch-ids/
I: filenames: package-contains-empty-directory usr/lib/ma-dir/perl/version/.be/
@@ -84,9 +87,6 @@ W: filenames: embedded-javascript-library
usr/share/filenames/yahoo-dom-event.js
W: filenames: embedded-javascript-library usr/share/filenames/yahoo-min.js
please use libjs-yui
W: filenames: executable-not-elf-or-script usr/bin/bin/bad
W: filenames: executable-not-elf-or-script usr/bin/mh/read
-W: filenames: extra-license-file usr/share/pixmaps/COPYING
-W: filenames: extra-license-file usr/share/pixmaps/license.foo
-W: filenames: extra-license-file usr/share/pixmaps/license.txt
W: filenames: file-in-unusual-dir files/ .tif
W: filenames: file-in-unusual-dir files/".tif
W: filenames: file-in-unusual-dir files/'\
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (396ec60 -> 0b70f0a)
This is an automated email from the git hooks/post-receive script. lamby pushed a change to branch master in repository lintian. from 396ec60 Also check xfonts-foo for font-package-not-multi-arch-foreign. new 0b70f0a Downgrade extra-license-file from "W" to "I". (Closes: #740118) The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/files.desc| 2 +- debian/changelog | 2 ++ t/tests/files-extra-license/tags | 2 +- t/tests/legacy-filenames/tags| 6 +++--- 4 files changed, 7 insertions(+), 5 deletions(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Processed: Re: lintian: extra-license-file severity overblown?
Processing commands for cont...@bugs.debian.org: > tags 740118 + pending Bug #740118 [lintian] lintian: extra-license-file severity overblown? Added tag(s) pending. > thanks Stopping processing here. Please contact me if you need assistance. -- 740118: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=740118 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#740118: lintian: extra-license-file severity overblown?
tags 740118 + pending thanks > is it really worth the effort to remove files which upstream > has asked to be installed with the package? Mmm. Fixed in Git: https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=0b70f0a2aab84f196be14364fbc74f43c83c9f29 Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#537609: [checks/scripts] warns about commands in never-called shell functions
tags 537609 + moreinfo thanks Hi Rene, > W: openoffice.org-pdfimport: maintainer-script-needs-depends-on-ucf preinst Could you supply us with the offending shell snippet? Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#888074: lintian FTBFS on armhf: spelling-error-in-binary false positives (?)
Source: lintian Version: 2.5.70 Severity: serious https://tests.reproducible-builds.org/debian/rb-pkg/unstable/armhf/lintian.html ... tests::binaries-golang: diff -u t/tests/binaries-golang/tags /build/1st/lintian-2.5.71/debian/test-out/tests/binaries-golang/tags.binaries-golang --- t/tests/binaries-golang/tags2018-01-21 05:24:47.0 + +++ /build/1st/lintian-2.5.71/debian/test-out/tests/binaries-golang/tags.binaries-golang 2018-01-21 11:16:29.392843265 + @@ -0,0 +1 @@ +I: binaries-golang: spelling-error-in-binary usr/lib/foo/static cymK CMYK fail tests::binaries-golang: output differs! . tests::binaries-general: diff -u t/tests/binaries-general/tags /build/1st/lintian-2.5.71/debian/test-out/tests/binaries-general/tags.binaries-general --- t/tests/binaries-general/tags 2018-01-21 05:24:47.0 + +++ /build/1st/lintian-2.5.71/debian/test-out/tests/binaries-general/tags.binaries-general 2018-01-21 11:16:39.152838686 + @@ -6,6 +6,7 @@ E: binaries-general: library-in-debug-or-profile-should-not-be-stripped usr/lib/debug/usr/share/foo/basic E: binaries-general: statically-linked-binary usr/bin/static E: binaries-general: unstripped-binary-or-object usr/bin/unstripped +I: binaries-general: spelling-error-in-binary usr/bin/static cymK CMYK W: binaries-general: binary-compiled-with-profiling-enabled usr/share/foo/basic W: binaries-general: binary-without-manpage usr/bin/static W: binaries-general: binary-without-manpage usr/bin/unstripped fail tests::binaries-general: output differs! ..S.S.S. ..S.S..SS... S... S... ...SS.. tests::legacy-binary: diff -u t/tests/legacy-binary/tags /build/1st/lintian-2.5.71/debian/test-out/tests/binary/tags.binary --- t/tests/legacy-binary/tags 2018-01-21 05:24:47.0 + +++ /build/1st/lintian-2.5.71/debian/test-out/tests/binary/tags.binary 2018-01-21 11:37:39.777391006 + @@ -59,6 +59,10 @@ I: binary: desktop-entry-lacks-keywords-entry usr/share/applications/goodbye.desktop I: binary: desktop-entry-lacks-keywords-entry usr/share/applications/hello.desktop I: binary: no-md5sums-control-file +I: binary: spelling-error-in-binary boot/hello/hello-static cymK CMYK +I: binary: spelling-error-in-binary usr/bin/hello-static cymK CMYK +I: binary: spelling-error-in-binary usr/bin/hello.static cymK CMYK +I: binary: spelling-error-in-binary usr/bin/static-hello cymK CMYK W: binary source: ancient-standards-version 3.2.1 (released 2000-08-24) (current is CURRENT) W: binary source: debian-rules-ignores-make-clean-error line 14 W: binary source: debian-rules-missing-recommended-target build-indep fail tests::legacy-binary: output differs! . Skipped/disabled tests: [debs] deb-format-wrong-order: Unmet test dependencies: dpkg (<< 1.17.2) [tests] binaries-from-other-arch: architecture mismatch binaries-multiarch: architecture mismatch binaries-multiarch-wrong-dir: architecture mismatch changelog-file-strange-date: Unmet test dependencies: dpkg (<< 1.18.2) deb-format-udeb-compression: Unmet test dependencies: dpkg (<< 1.18.11) debconf-config-not-executable: Unmet test dependencies: dpkg (<< 1.19.0) debhelper-compat: Unmet test dependencies: debhelper (<< 9.20151101~) debhelper-compat-empty: Unmet test dependencies: debhelper (<< 9.20151101~) files-multiarch-foreign-files: architecture mismatch runtests-arch-amd64: architecture mismatch runtests-arch-i386: architecture mismatch shared-libs-non-pic-i386: architecture mismatch upstream-metadata-invalid-yml: (disabled) YAML::XS executes code by default and code has not been converted version-substvars-obsolete: Unmet test dependencies: dpkg (<< 1.17.2) Failed tests (3) tests::binaries-golang tests::binaries-general tests::legacy-binary debian/rules:48: recipe for target 'runtests' failed make[1]: *** [runtests] Error 1
[lintian] 01/01: Avoid a false positive for spelling-error-in-binary that was causing a FTBFS on armhf. (Closes: #888074)
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit bfa3e1a33014307c9f37ff8e2d216b8ca112290c
Author: Chris Lamb
Date: Tue Jan 23 15:59:32 2018 +1100
Avoid a false positive for spelling-error-in-binary that was causing a
FTBFS on armhf. (Closes: #888074)
---
checks/binaries.pm | 1 +
debian/changelog | 3 +++
2 files changed, 4 insertions(+)
diff --git a/checks/binaries.pm b/checks/binaries.pm
index cead9f1..269302c 100644
--- a/checks/binaries.pm
+++ b/checks/binaries.pm
@@ -393,6 +393,7 @@ sub run {
'writeN' => 1, # The Go stdlib text/tabwriter pkg contains "writeN"
'writeN' => 1, # The Go stdlib text/tabwriter pkg contains "writeN"
'ot' => 1, # The Go stdlib runtime/ package contains "ot"
+'cymK' => 1, # The Go runtime contains "cymK" (#888074)
};
my $tag_emitter
= spelling_tag_emitter('spelling-error-in-binary', $file);
diff --git a/debian/changelog b/debian/changelog
index 98ec83a..074a2dd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,9 @@ lintian (2.5.72) UNRELEASED; urgency=medium
XXX: generate tag summary
+ * checks/binaries.pm:
++ [CL] Avoid a false positive for spelling-error-in-binary that was
+ causing a FTBFS on armhf. (Closes: #888074)
* checks/debhelper.{desc,pm}:
+ [CL] Warn about packages that use about dh_systemd_enable or
dh_systemd_start overrides whilst using debhelper compat level 11 as
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (0b70f0a -> bfa3e1a)
This is an automated email from the git hooks/post-receive script. lamby pushed a change to branch master in repository lintian. from 0b70f0a Downgrade extra-license-file from "W" to "I". (Closes: #740118) new bfa3e1a Avoid a false positive for spelling-error-in-binary that was causing a FTBFS on armhf. (Closes: #888074) The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/binaries.pm | 1 + debian/changelog | 3 +++ 2 files changed, 4 insertions(+) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (bfa3e1a -> 2e927b3)
This is an automated email from the git hooks/post-receive script. lamby pushed a change to branch master in repository lintian. from bfa3e1a Avoid a false positive for spelling-error-in-binary that was causing a FTBFS on armhf. (Closes: #888074) new 2e927b3 checks/binaries.pm: Drop a duplicate line in spelling-error-in-binary exceptions. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/binaries.pm | 1 - debian/changelog | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: checks/binaries.pm: Drop a duplicate line in spelling-error-in-binary exceptions.
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit 2e927b3a689243eb5bf4b40b1cc01f35b5483511
Author: Chris Lamb
Date: Tue Jan 23 16:01:35 2018 +1100
checks/binaries.pm: Drop a duplicate line in spelling-error-in-binary
exceptions.
---
checks/binaries.pm | 1 -
debian/changelog | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/checks/binaries.pm b/checks/binaries.pm
index 269302c..b3b2775 100644
--- a/checks/binaries.pm
+++ b/checks/binaries.pm
@@ -391,7 +391,6 @@ sub run {
'tEh' => 1, # From #782902, too
'ang' => 1, # The Go stdlib html/ package contains "ang;"
'writeN' => 1, # The Go stdlib text/tabwriter pkg contains "writeN"
-'writeN' => 1, # The Go stdlib text/tabwriter pkg contains "writeN"
'ot' => 1, # The Go stdlib runtime/ package contains "ot"
'cymK' => 1, # The Go runtime contains "cymK" (#888074)
};
diff --git a/debian/changelog b/debian/changelog
index 074a2dd..313e8f1 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -5,6 +5,7 @@ lintian (2.5.72) UNRELEASED; urgency=medium
* checks/binaries.pm:
+ [CL] Avoid a false positive for spelling-error-in-binary that was
causing a FTBFS on armhf. (Closes: #888074)
++ [CL] Drop a duplicate line in spelling-error-in-binary exceptions.
* checks/debhelper.{desc,pm}:
+ [CL] Warn about packages that use about dh_systemd_enable or
dh_systemd_start overrides whilst using debhelper compat level 11 as
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
Bug#888074: lintian FTBFS on armhf: spelling-error-in-binary false positives (?)
tags 888074 + pending thanks Thanks, fixed in Git: https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=bfa3e1a33014307c9f37ff8e2d216b8ca112290c Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Processed: Re: lintian FTBFS on armhf: spelling-error-in-binary false positives (?)
Processing commands for cont...@bugs.debian.org: > tags 888074 + pending Bug #888074 [src:lintian] lintian FTBFS on armhf: spelling-error-in-binary false positives (?) Added tag(s) pending. > thanks Stopping processing here. Please contact me if you need assistance. -- 888074: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888074 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#818609: lintian: python-script-but-no-python-dep false positive
tags 818609 + moreinfo thanks Hi, > The python-script-but-no-python-dep check is being triggered despite > the dependency existing I can't reproduce this; as in, this package is missing the dependencies for me! $ dget lava-dev dget: retrieving http://127.0.0.1/deb.debian.org/pool/main/l/lava-server/lava-dev_2018.1-2_all.deb % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 39832 100 398320 0 39832 0 0:00:01 --:--:-- 0:00:01 37.9M $ dpkg -I lava-dev_2018.1-2_all.deb | grep Depends Depends: build-essential, ca-certificates, devscripts, dpkg-dev, debootstrap (>= 1.0.86), debhelper (>= 9.20160709), fakeroot, git, libdistro-info-perl, node-uglify, libjs-excanvas, libjs-jquery-cookie, libjs-jquery, libjs-jquery-watermark, libjs-jquery-flot (>= 0.8.2), libjs-jquery-ui, pep8 | python-pep8, python-guestfs, python-nose, python-netifaces, python3-sphinx (>= 1.4), python-setuptools, python-pexpect (>= 4.2), python3-sphinx-bootstrap-theme, python-requests, python-zmq, python-yaml, python-voluptuous (>= 0.8.8), docbook-xsl, xsltproc, python-mock Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Processed: Re: lintian: python-script-but-no-python-dep false positive
Processing commands for cont...@bugs.debian.org: > tags 818609 + moreinfo Bug #818609 [lintian] lintian: python-script-but-no-python-dep false positive Added tag(s) moreinfo. > thanks Stopping processing here. Please contact me if you need assistance. -- 818609: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=818609 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Re: Lintian tag pre-depends-directly-on-multiarch-support too much debhelper-centric
Processing commands for cont...@bugs.debian.org: > tags 798762 + moreinfo Bug #798762 [lintian] Lintian tag pre-depends-directly-on-multiarch-support too much debhelper-centric Added tag(s) moreinfo. > thanks Stopping processing here. Please contact me if you need assistance. -- 798762: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=798762 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#798762: Lintian tag pre-depends-directly-on-multiarch-support too much debhelper-centric
tags 798762 + moreinfo thanks Hi, > Lintian tag pre-depends-directly-on-multiarch-support too much > debhelper-centric It seems like this was not applied. That sucks. However, do we still need this now that the issue (and the stable release in question) was quite some time ago? Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
[lintian] 01/01: Do not emit "license-problem-php-license" when the source comes from pecl.php.net: "The last agreement with FTP Masters was that PHP license is OK when the sources some from PECL repo
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit 87ea6311efd38fbd01c5a43b87d5d05b435e692c
Author: Chris Lamb
Date: Tue Jan 23 17:06:18 2018 +1100
Do not emit "license-problem-php-license" when the source comes from
pecl.php.net: "The last agreement with FTP Masters was that PHP license is OK
when the sources some from PECL repository." (Closes: #810780)
---
checks/cruft.desc | 3 +++
checks/cruft.pm | 63 +++
debian/changelog | 5 +
3 files changed, 44 insertions(+), 27 deletions(-)
diff --git a/checks/cruft.desc b/checks/cruft.desc
index 91753bb..59e7de8 100644
--- a/checks/cruft.desc
+++ b/checks/cruft.desc
@@ -629,6 +629,9 @@ Certainty: possible
Info: This package appears to be covered by version 3.0 (exactly) of the
PHP license. This license is not applicable to anything that is not PHP
and has no contributions from the PHP Group.
+ .
+ This tag is not emitted for packages from pecl.php.net as determined by
+ the Source: header in debian/copyright.
Ref: https://ftp-master.debian.org/REJECT-FAQ.html
Tag: license-problem-gfdl-invariants
diff --git a/checks/cruft.pm b/checks/cruft.pm
index cad619d..03d616d 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -930,11 +930,11 @@ sub full_text_check {
# permission to distribute those.
if(
_license_check(
-$source_pkg, $name,
-$basename,$NON_DISTRIBUTABLE_LICENSES,
-$block,$blocknumber,
-\$cleanedblock,\%matchedkeyword,
-\%licenseproblemhash
+$info, $source_pkg,
+$name,$basename,
+$NON_DISTRIBUTABLE_LICENSES,$block,
+$blocknumber,\$cleanedblock,
+\%matchedkeyword,\%licenseproblemhash
)
){
return;
@@ -947,9 +947,10 @@ sub full_text_check {
}
_license_check(
-$source_pkg, $name, $basename,
-$NON_FREE_LICENSES,$block, $blocknumber,
-\$cleanedblock, \%matchedkeyword,\%licenseproblemhash
+$info, $source_pkg, $name,
+$basename,$NON_FREE_LICENSES,$block,
+$blocknumber,\$cleanedblock, \%matchedkeyword,
+\%licenseproblemhash
);
# check only in block 0
@@ -1163,10 +1164,10 @@ sub _tag_gfdl {
# return True in case of license problem
sub _check_gfdl_license_problem {
my (
-$source_pkg, $name,$basename,
-$block,$blocknumber,$cleanedblock,
-$matchedkeyword,$licenseproblemhash,$licenseproblem,
-%matchedhash
+$info, $source_pkg, $name,
+$basename,$block,$blocknumber,
+$cleanedblock,$matchedkeyword,$licenseproblemhash,
+$licenseproblem,%matchedhash
)= @_;
my $rawgfdlsections = $matchedhash{rawgfdlsections} || '';
my $rawcontextbefore = $matchedhash{rawcontextbefore} || '';
@@ -1276,10 +1277,10 @@ sub _check_gfdl_license_problem {
# whitelist good rfc
sub _rfc_whitelist_filename {
my (
-$source_pkg, $name, $basename,
-$block,$blocknumber, $cleanedblock,
-$matchedkeyword,$licenseproblemhash, $licenseproblem,
-%matchedhash
+$info, $source_pkg, $name,
+$basename,$block,$blocknumber,
+$cleanedblock,$matchedkeyword,$licenseproblemhash,
+$licenseproblem,%matchedhash
)= @_;
return 0 if $name eq 'debian/copyright';
my $lcname = lc($basename);
@@ -1297,12 +1298,19 @@ sub _rfc_whitelist_filename {
# whitelist php source
sub _php_source_whitelist {
my (
-$source_pkg, $name, $basename,
-$block,$blocknumber, $cleanedblock,
-$matchedkeyword,$licenseproblemhash, $licenseproblem,
-%matchedhash
+$info, $source_pkg, $name,
+$basename,$block,$blocknumber,
+$cleanedblock,$matchedkeyword,$licenseproblemhash,
+$licenseproblem,%matchedhash
)= @_;
+my $copyright_path = $info->index_resolved_path('debian/copyright');
+if ($copyright_path
+and $copyright_path->file_contents
+=~ m{^Source: https?://pecl.php.net/package/.*$}m) {
+return 0;
+}
+
if($source_pkg =~ m,^php\d*(?:\.\d+)?$,xms) {
return 0;
}
@@ -1460,9 +1468,10 @@ sub _md5sum_based_check {
# check bad license
sub _license_check {
my (
-$source_pkg, $name, $basename,
-$licensesdatas, $block, $blocknumber,
-$cleanedblock,$matchedkeyword, $licenseproblemhash
+$info, $source_pkg, $name,
+$basename,$licensesdatas, $block,
+$blocknumber,$cleanedblock,$matchedkeyword,
+$licenseproblemhash
)= @_;
my $ret = 0;
@@ -1517,10 +1526,10 @@ sub _license_check {
if(defined($licenseproblemdata->{'callsub'})) {
my $subresult= $licenseproblemdata
[lintian] branch master updated (2e927b3 -> 87ea631)
This is an automated email from the git hooks/post-receive script. lamby pushed a change to branch master in repository lintian. from 2e927b3 checks/binaries.pm: Drop a duplicate line in spelling-error-in-binary exceptions. new 87ea631 Do not emit "license-problem-php-license" when the source comes from pecl.php.net: "The last agreement with FTP Masters was that PHP license is OK when the sources some from PECL repository." (Closes: #810780) The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/cruft.desc | 3 +++ checks/cruft.pm | 63 +++ debian/changelog | 5 + 3 files changed, 44 insertions(+), 27 deletions(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Add missing files from previous commit.
This is an automated email from the git hooks/post-receive script. lamby pushed a commit to branch master in repository lintian. commit 079df6146471b4f4e2725375ea1b870c48d88f96 Author: Chris Lamb Date: Tue Jan 23 17:06:57 2018 +1100 Add missing files from previous commit. --- .../cruft-bad-php-unrel/debian/debian/copyright| 20 ++ t/tests/cruft-bad-php-unrel/debian/src/2_01.txt| 70 t/tests/cruft-bad-php-unrel/debian/src/2_02.txt| 75 ++ t/tests/cruft-bad-php-unrel/debian/src/3_01.txt| 55 t/tests/cruft-bad-php-unrel/desc | 6 ++ t/tests/cruft-bad-php-unrel/tags | 0 6 files changed, 226 insertions(+) diff --git a/t/tests/cruft-bad-php-unrel/debian/debian/copyright b/t/tests/cruft-bad-php-unrel/debian/debian/copyright new file mode 100644 index 000..8513b32 --- /dev/null +++ b/t/tests/cruft-bad-php-unrel/debian/debian/copyright @@ -0,0 +1,20 @@ +Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ +Source: https://pecl.php.net/package/foo + +Files: * +Copyright: 2011 J. Random Hacker +License: GPL-2 + This package is free software; you can redistribute it and/or modify it under + the terms of the GNU General Public License as published by the Free Software + Foundation; version 2 dated June, 1991. + . + This package is distributed in the hope that it will be useful, but WITHOUT + ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS + FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. + . + You should have received a copy of the GNU General Public License along with + this package; if not, write to the Free Software Foundation, Inc., 51 Franklin + St, Fifth Floor, Boston, MA 02110-1301, USA. + . + On Debian systems, the full text of the GNU General Public License version 2 + can be found in the file `/usr/share/common-licenses/GPL-2'. diff --git a/t/tests/cruft-bad-php-unrel/debian/src/2_01.txt b/t/tests/cruft-bad-php-unrel/debian/src/2_01.txt new file mode 100644 index 000..0dc7725 --- /dev/null +++ b/t/tests/cruft-bad-php-unrel/debian/src/2_01.txt @@ -0,0 +1,70 @@ + + The PHP License, version 2.01 +Copyright (c) 1999 The PHP Group. All rights reserved. + + +Redistribution and use in source and binary forms, with or without +modification, is permitted provided that the following conditions +are met: + + 1. Redistributions of source code must retain the above copyright + notice, this list of conditions and the following disclaimer. + + 2. Redistributions in binary form must reproduce the above + copyright notice, this list of conditions and the following + disclaimer in the documentation and/or other materials provided + with the distribution. + + 3. The name "PHP" must not be used to endorse or promote products + derived from this software without prior permission from the +PHP Group. This does not apply to add-on libraries or tools +that work in conjunction with PHP. In such a case the PHP +name may be used to indicate that the product supports PHP. + + 4. The PHP Group may publish revised and/or new versions of the + license from time to time. Each version will be given a +distinguishing version number. + Once covered code has been published under a particular version +of the license, you may always continue to use it under the +terms of that version. You may also choose to use such covered +code under the terms of any subsequent version of the license +published by the PHP Group. No one other than the PHP Group has +the right to modify the terms applicable to covered code created +under this License. + + 5. Redistributions of any form whatsoever must retain the following + acknowledgment: + "This product includes PHP, freely available from +http://www.php.net/";. + + 6. Permission to freely distribute and use Zend as an integrated + part of PHP is granted, under the conditions of version 0.91 +of the Zend License. +The license is bundled with the Zend engine, and is available +at http://www.zend.com/license/0_91.txt, or by contacting +lice...@zend.com. + + + +THIS SOFTWARE IS PROVIDED BY THE PHP DEVELOPMENT TEAM ``AS IS'' AND +ANY EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, +THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A +PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE PHP +DEVELOPMENT TEAM OR ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, +INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR +SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
[lintian] branch master updated (87ea631 -> 079df61)
This is an automated email from the git hooks/post-receive script.
lamby pushed a change to branch master
in repository lintian.
from 87ea631 Do not emit "license-problem-php-license" when the source
comes from pecl.php.net: "The last agreement with FTP Masters was that PHP
license is OK when the sources some from PECL repository." (Closes: #810780)
new 079df61 Add missing files from previous commit.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../debian/debian/copyright | 11 +--
.../debian/src/2_01.txt | 0
.../debian/src/2_02.txt | 0
.../debian/src/3_01.txt | 0
t/tests/cruft-bad-php-unrel/desc | 6 ++
.../deb-format-record-size => tests/cruft-bad-php-unrel}/tags | 0
6 files changed, 7 insertions(+), 10 deletions(-)
copy t/tests/{source-copyright-source-files-excluded =>
cruft-bad-php-unrel}/debian/debian/copyright (86%)
copy t/tests/{cruft-bad-php => cruft-bad-php-unrel}/debian/src/2_01.txt (100%)
copy t/tests/{cruft-bad-php => cruft-bad-php-unrel}/debian/src/2_02.txt (100%)
copy t/tests/{cruft-bad-php => cruft-bad-php-unrel}/debian/src/3_01.txt (100%)
create mode 100644 t/tests/cruft-bad-php-unrel/desc
copy t/{debs/deb-format-record-size => tests/cruft-bad-php-unrel}/tags (100%)
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
Bug#810780: lintian: license-problem-php-license is wrong when source comes from pecl.php.net
tags 810780 + pending thanks Fixed in Git: https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=87ea6311efd38fbd01c5a43b87d5d05b435e692c https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=079df6146471b4f4e2725375ea1b870c48d88f96 Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Processed: Re: lintian: license-problem-php-license is wrong when source comes from pecl.php.net
Processing commands for cont...@bugs.debian.org: > tags 810780 + pending Bug #810780 [lintian] lintian: license-problem-php-license is wrong when source comes from pecl.php.net Added tag(s) pending. > thanks Stopping processing here. Please contact me if you need assistance. -- 810780: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=810780 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#818609: lintian: python-script-but-no-python-dep false positive
On Tue, 23 Jan 2018 11:11:30 +0530 Chris Lamb wrote: > tags 818609 + moreinfo > thanks > > Hi, > > > The python-script-but-no-python-dep check is being triggered despite > > the dependency existing > > I can't reproduce this; as in, this package is missing the > dependencies for me! > > $ dget lava-dev > dget: retrieving > http://127.0.0.1/deb.debian.org/pool/main/l/lava-server/lava-dev_2018.1-2_all.deb > % Total% Received % Xferd Average Speed TimeTime Time > Current Dload Upload Total SpentLeft Speed 100 39832 100 > 398320 0 39832 0 0:00:01 --:--:-- 0:00:01 37.9M > > $ dpkg -I lava-dev_2018.1-2_all.deb | grep Depends > Depends: build-essential, ca-certificates, devscripts, dpkg-dev, > debootstrap (>= 1.0.86), debhelper (>= 9.20160709), fakeroot, git, > libdistro-info-perl, node-uglify, libjs-excanvas, > libjs-jquery-cookie, libjs-jquery, libjs-jquery-watermark, > libjs-jquery-flot (>= 0.8.2), libjs-jquery-ui, pep8 | python-pep8, > python-guestfs, python-nose, python-netifaces, python3-sphinx (>= > 1.4), python-setuptools, python-pexpect (>= 4.2), > python3-sphinx-bootstrap-theme, python-requests, python-zmq, > python-yaml, python-voluptuous (>= 0.8.8), docbook-xsl, xsltproc, > python-mock > There are 10 packages there which already have that strict Depends which lintian expects. The packaging already has the lintian advice for calculating dependencies with debhelper but no such dependency is calculated. So is debhelper wrong here to not add (a completely redundant) dependency or is lintian wrong to not handle dependencies already listed? There really is no point adding the spurious dependency covered by this lintian warning. -- Neil Williams = http://www.linux.codehelp.co.uk/ pgpc0tL1iXyuf.pgp Description: OpenPGP digital signature
