Processed: your mail

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> retitle 441807 lintian: Check dependencies on -data packages
Bug #441807 [lintian] [checks/control-file] check dependencies on -data packages
Changed Bug title to 'lintian: Check dependencies on -data packages' from 
'[checks/control-file] check dependencies on -data packages'.
> retitle 542713 lintian: Warn about outdated watch file versions
Bug #542713 [lintian] [checks/watch-file] Warn about outdated watch file 
versions
Bug #669709 [lintian] lintian: check deban/watch::version
Changed Bug title to 'lintian: Warn about outdated watch file versions' from 
'[checks/watch-file] Warn about outdated watch file versions'.
Changed Bug title to 'lintian: Warn about outdated watch file versions' from 
'lintian: check deban/watch::version'.
> retitle 554006 lintian: Warn if package ships files in /etc/cron.* without 
> depending on cron
Bug #554006 [lintian] [new check] Warn if package ships files in /etc/cron.* 
without depending on cron
Changed Bug title to 'lintian: Warn if package ships files in /etc/cron.* 
without depending on cron' from '[new check] Warn if package ships files in 
/etc/cron.* without depending on cron'.
> retitle 554688 lintian: Check for safe use of uscan in get-orig-source
Bug #554688 [lintian] [new check] Verify safe use of uscan in get-orig-source
Changed Bug title to 'lintian: Check for safe use of uscan in get-orig-source' 
from '[new check] Verify safe use of uscan in get-orig-source'.
> retitle 602304 lintian: Please check debian/patches for DEP 3 syntax
Bug #602304 [lintian] lintian: Please check debian/patches for DEP 3 syntax
Ignoring request to change the title of bug#602304 to the same title
> retitle 631011 lintian: Add embedded-libcharls
Bug #631011 [lintian] lintian: add embedded-libcharls
Changed Bug title to 'lintian: Add embedded-libcharls' from 'lintian: add 
embedded-libcharls'.
> retitle 643735 lintian: Add check for manpages to verify TH matches FILENAME
Bug #643735 [lintian] lintian: Add check for manual page to verify TH matches 
FILENAME.N
Changed Bug title to 'lintian: Add check for manpages to verify TH matches 
FILENAME' from 'lintian: Add check for manual page to verify TH matches 
FILENAME.N'.
> retitle 660165 lintian: Source package names for R libraries (and others)
Bug #660165 [lintian] [new check] Source package names for R libraries (and 
others if appropriate).
Changed Bug title to 'lintian: Source package names for R libraries (and 
others)' from '[new check] Source package names for R libraries (and others if 
appropriate).'.
> retitle 702671 lintian: Please make missing-debian-source-format proper
Bug #702671 [lintian] please make missing-debian-source-format proper W
Changed Bug title to 'lintian: Please make missing-debian-source-format proper' 
from 'please make missing-debian-source-format proper W'.
> retitle 709139 lintian: Add check for Debian copyright owners in 
> debian/copyright
Bug #709139 [lintian] lintian: add debian/copyright check for Debian copyright 
owwners
Changed Bug title to 'lintian: Add check for Debian copyright owners in 
debian/copyright' from 'lintian: add debian/copyright check for Debian 
copyright owwners'.
> retitle 712511 lintian: Should check for references to update-notifier in 
> postinst
Bug #712511 [lintian] lintian: should check for references to update-notifier 
in postinst
Changed Bug title to 'lintian: Should check for references to update-notifier 
in postinst' from 'lintian: should check for references to update-notifier in 
postinst'.
> retitle 717595 lintian: Please check for update-rc.d "start" and "stop" 
> argument usage
Bug #717595 [lintian] lintian: Please check for update-rc.d "start" and "stop" 
argument usage
Bug #733156 [lintian] piuparts: add check for: update-rc.d: warning: start and 
stop actions are no longer supported; falling back to defaults
Ignoring request to change the title of bug#717595 to the same title
Changed Bug title to 'lintian: Please check for update-rc.d "start" and "stop" 
argument usage' from 'piuparts: add check for: update-rc.d: warning: start and 
stop actions are no longer supported; falling back to defaults'.
> retitle 722084 lintian: Please add Ruby pkg team checks
Bug #722084 [lintian] lintian: [checks] Add Ruby pkg team checks to lintian
Changed Bug title to 'lintian: Please add Ruby pkg team checks' from 'lintian: 
[checks] Add Ruby pkg team checks to lintian'.
> retitle 731340 lintian: Check if debian/upstream files are valid YAML
Bug #731340 [lintian] lintian: [new check] Check if debian/upstream files are 
valid YAML
Changed Bug title to 'lintian: Check if debian/upstream files are valid YAML' 
from 'lintian: [new check] Check if debian/upstream files are valid YAML'.
> retitle 754730 lintian: Check that packages should not depend on apparmor
Bug #754730 [lintian] packages should not depend on apparmor
Changed Bug title to 'lintian: Check that packages should not depend on 
apparmor' from 'packages should not d

Bug#760021: lintian: Check for files that are not wrap-and-sort formatted

[Chris Lamb]

tags 760021 + wontfix
thanks

I'm going to tag this as wontfix for now due to the reasons outlined
above :)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#543260: lintian: Please revisit or temper patch-system-but-no-source-readme

[Chris Lamb]

Chris Lamb wrote:

> Please revisit or temper patch-system-but-no-source-readme

Given that we actively recommend against source formats other than
"3.0 (quilt)" (where we don't emit this tag; see #553207) I am happy
to close this bug.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Processed: Re: lintian: Check for files that are not wrap-and-sort formatted

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 760021 + wontfix
Bug #760021 [lintian] lintian: Check for files that are not wrap-and-sort 
formatted
Added tag(s) wontfix.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
760021: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760021
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

[lintian] 02/07: checs/java.pm: Use dirname(...) over regular expressions.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit ff645070dafaa2f5e4d2d0ff30d875610987f432
Author: Chris Lamb 
Date:   Mon Jan 29 01:44:17 2018 +

checs/java.pm: Use dirname(...) over regular expressions.
---
 checks/java.pm | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/checks/java.pm b/checks/java.pm
index 98a0a6b..16b2fd6 100644
--- a/checks/java.pm
+++ b/checks/java.pm
@@ -53,7 +53,7 @@ sub run {
 my $files = $java_info->{$jar_file}{files};
 my $manifest = $java_info->{$jar_file}{manifest};
 my $operm = $info->index($jar_file)->operm;
-my $jar_dir;
+my $jar_dir = dirname($jar_file);
 my $classes = 0;
 my $datafiles = 1;
 my $cp = '';
@@ -69,10 +69,7 @@ sub run {
 # Ignore Mozilla's jar files, see #635495
 next if $jar_file =~ m#usr/lib/xul(?:-ext|runner[^/]*+)/#o;
 
-$jar_dir = $jar_file;
-$jar_dir =~ s,[^/]+$,,o;
 $has_jars = 1;
-
 if($jar_file =~ m#^usr/share/java/[^/]+\.jar$#o) {
 $has_public_jars = 1;
 }

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/07: Check for .jar files that do not match the Debian Java policy. (Closes: #791552)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit d14ed8a3ae8fadcfec771d3d2befc2da6585667b
Author: Chris Lamb 
Date:   Mon Jan 29 01:43:24 2018 +

Check for .jar files that do not match the Debian Java policy. (Closes: 
#791552)
---
 checks/java.desc  | 8 
 checks/java.pm| 5 -
 debian/changelog  | 3 +++
 t/tests/java-class-format/desc| 1 +
 t/tests/java-classpath/desc   | 1 +
 t/tests/java-jars/debian/debian/libtesta-java.install | 1 +
 t/tests/java-jars/debian/debian/rules | 1 +
 t/tests/java-jars/desc| 2 ++
 t/tests/java-jars/tags| 1 +
 9 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/checks/java.desc b/checks/java.desc
index fd31dad..269975b 100644
--- a/checks/java.desc
+++ b/checks/java.desc
@@ -98,3 +98,11 @@ Severity: normal
 Certainty: certain
 Info: The package contains a Jar file, but Lintian is unable to parse it.
  It is possible that the Jar file is corrupt.
+
+Tag: bad-jar-name
+Severity: normal
+Certainty: certain
+Info: The package contains a specified Jar file, but the name does not
+ correspond to Java policy guidelines. This can cause tools in the Debian
+ Java toolchain to fail.
+Ref: java-policy 2.4
diff --git a/checks/java.pm b/checks/java.pm
index 8157d64..98a0a6b 100644
--- a/checks/java.pm
+++ b/checks/java.pm
@@ -23,11 +23,12 @@ use strict;
 use warnings;
 use autodie;
 
+use File::Basename;
 use List::MoreUtils qw(any none);
 use Lintian::Data ();
 
 use Lintian::Tags qw(tag);
-use Lintian::Util qw(normalize_pkg_path);
+use Lintian::Util qw(normalize_pkg_path $PKGNAME_REGEX);
 
 our $MAX_BYTECODE = Lintian::Data->new('java/constants', qr/\s*=\s*/o);
 
@@ -75,6 +76,8 @@ sub run {
 if($jar_file =~ m#^usr/share/java/[^/]+\.jar$#o) {
 $has_public_jars = 1;
 }
+tag 'bad-jar-name', $jar_file
+  unless basename($jar_file) =~ /^$PKGNAME_REGEX\.jar$/;
 # check for common code files like .class or .clj (Clojure files)
 foreach
   my $class (grep { m/\.(?:class|cljc?)$/oi } sort keys %{$files}){
diff --git a/debian/changelog b/debian/changelog
index 00a99f5..781beea 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -14,6 +14,9 @@ lintian (2.5.73) UNRELEASED; urgency=medium
 + [CL] Warn about Multi-Arch: same packages that ship
   architecture-specific Lintian overrides. Thanks to Sebastian
   Ramacher for the report.  (Closes: #787469)
+  * checks/java.{desc,pm}:
++ [CL] Check for .jar files that do not match the Debian Java policy.
+  (Closes: #791552)
   * checks/patch-systems.{desc,pm}:
 + [CL] Emit a pedantic warning for packages that are using the dpatch
   patch system.  (Closes: #884500)
diff --git a/t/tests/java-class-format/desc b/t/tests/java-class-format/desc
index c406c31..dd044da 100644
--- a/t/tests/java-class-format/desc
+++ b/t/tests/java-class-format/desc
@@ -3,6 +3,7 @@ Type: non-native
 Version: 1.0-1
 Description: Various checks for Java Class format
 Section: java
+Test-Depends: javahelper
 Test-For:
  incompatible-java-bytecode-format
  unknown-java-class-version
diff --git a/t/tests/java-classpath/desc b/t/tests/java-classpath/desc
index a78980d..1b378dc 100644
--- a/t/tests/java-classpath/desc
+++ b/t/tests/java-classpath/desc
@@ -4,5 +4,6 @@ Version: 1.0-1
 Description: Various checks about JAR files
 Author: Vincent Fourmond 
 Section: java
+Test-Depends: javahelper
 Test-For:
  classpath-contains-relative-path
diff --git a/t/tests/java-jars/debian/debian/libtesta-java.install 
b/t/tests/java-jars/debian/debian/libtesta-java.install
index da83d4a..a6483d5 100644
--- a/t/tests/java-jars/debian/debian/libtesta-java.install
+++ b/t/tests/java-jars/debian/debian/libtesta-java.install
@@ -1,2 +1,3 @@
+0.jar usr/share/java/
 testb.jar usr/lib/
 testc.jar usr/bin
diff --git a/t/tests/java-jars/debian/debian/rules 
b/t/tests/java-jars/debian/debian/rules
index 4811f4b..fd11dcc 100755
--- a/t/tests/java-jars/debian/debian/rules
+++ b/t/tests/java-jars/debian/debian/rules
@@ -5,6 +5,7 @@
 override_jh_build:
jh_build --javacopts='-target 1.7' --javacopts='-source 1.7'
cp testa.jar testb.jar
+   cp testa.jar 0.jar
unzip testa.jar
zip -r codeless.jar META-INF/
zip -r manifestless.jar org/
diff --git a/t/tests/java-jars/desc b/t/tests/java-jars/desc
index 77b8cb7..21123a8 100644
--- a/t/tests/java-jars/desc
+++ b/t/tests/java-jars/desc
@@ -4,7 +4,9 @@ Version: 1.0-1
 Description: Various checks about JAR files
 Author: Vincent Fourmond 
 Section: java
+Test-Depends: javahelper
 Test-For:
+ bad-jar-name
  codeless-jar
  executable-jar-without-main-class
  jar-not-in-usr-share
diff 

[lintian] 03/07: Improve the description-synopsis-might-not-be-phrased-properly tag also detect multiple sentences and improve the tag description. (Closes: #778427)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 518f2979822557024a3501e9a731e51ceb8220ea
Author: Chris Lamb 
Date:   Mon Jan 29 02:38:41 2018 +

Improve the description-synopsis-might-not-be-phrased-properly tag also 
detect multiple sentences and improve the tag description. (Closes: #778427)
---
 checks/description.desc   | 15 +--
 checks/description.pm |  2 +-
 debian/changelog  |  5 -
 t/tests/description-general/debian/debian/control.in  |  9 +
 t/tests/description-general/tags  |  1 +
 .../fields-excessive-priority-for-library-package/desc|  2 +-
 t/tests/fields-version-bad-rc/desc|  2 +-
 7 files changed, 26 insertions(+), 10 deletions(-)

diff --git a/checks/description.desc b/checks/description.desc
index a7cef96..789f16c 100644
--- a/checks/description.desc
+++ b/checks/description.desc
@@ -141,13 +141,16 @@ Info: The extended description contains the statement 
that it was
 Tag: description-synopsis-might-not-be-phrased-properly
 Severity: minor
 Certainty: possible
-Info: The synopsis (first line in the package "Description:" field, the
- short description) ends with a full stop "." character. This is not
- necessary, as the synopsis doesn't need to be a full sentence. It is
- recommended that a descriptive phrase is used instead.
+Info: The package synopsis (also known as the "short" descriptiom,, ie. the
+ first line in the package "Description:" field) either ends with a full
+ stop "." character or starts another additonal sentence.
  .
- Note also that the synopsis is not part of the rest of the "Description:"
- field.
+ This is not necessary as the synopsis does nott need to be a full
+ sentence.  It is recommended that a single descriptive phrase is used
+ instead.
+ .
+ Note also that the synopsis is not part of the rest of the "long"
+ Description: field.
 Ref: devref 6.2.2
 
 Tag: description-synopsis-is-duplicated
diff --git a/checks/description.pm b/checks/description.pm
index 6396466..5fb86ba 100644
--- a/checks/description.pm
+++ b/checks/description.pm
@@ -85,7 +85,7 @@ sub run {
 if ($synopsis =~ m/^(an?|the)\s/i) {
 tag 'description-synopsis-starts-with-article';
 }
-if ($synopsis =~ m/(?http://lintian.debian.org/>
 
+Package: {$source}-5
+Architecture: {$architecture}
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Description: {$source} starts a sentence. Then starts another.
+ This is a test package designed to exercise some feature or tag of
+ Lintian.  It is part of the Lintian test suite and may do very odd
+ things.  It should not be installed like a regular package.  It may
+ be an empty package.
+
 Package: {$source}-ends-etc
 Architecture: {$architecture}
 Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
diff --git a/t/tests/description-general/tags b/t/tests/description-general/tags
index c9b1bb1..9733f16 100644
--- a/t/tests/description-general/tags
+++ b/t/tests/description-general/tags
@@ -12,6 +12,7 @@ E: foo-duplicate: description-is-pkg-name foo duplicate
 I: description-general source: duplicate-long-description foo-duplicate 
foo-bar-duplicate
 I: description-general-3: using-first-person-in-description line 5: I
 I: description-general-4: capitalization-error-in-description debian Debian
+I: description-general-5: description-synopsis-might-not-be-phrased-properly
 I: description-general-syn-spelling: 
capitalization-error-in-description-synopsis debian Debian
 I: description-general: description-synopsis-might-not-be-phrased-properly
 W: description-general-2: description-starts-with-leading-spaces
diff --git a/t/tests/fields-excessive-priority-for-library-package/desc 
b/t/tests/fields-excessive-priority-for-library-package/desc
index 3d8f2f7..58a7002 100644
--- a/t/tests/fields-excessive-priority-for-library-package/desc
+++ b/t/tests/fields-excessive-priority-for-library-package/desc
@@ -1,5 +1,5 @@
 Testname: fields-excessive-priority-for-library-package
 Version: 1.0
-Description: Library packages with excessive Priority field.
+Description: Library packages with excessive Priority field
 Test-For:
  excessive-priority-for-library-package
diff --git a/t/tests/fields-version-bad-rc/desc 
b/t/tests/fields-version-bad-rc/desc
index 9141d13..f8d5cfb 100644
--- a/t/tests/fields-version-bad-rc/desc
+++ b/t/tests/fields-version-bad-rc/desc
@@ -1,5 +1,5 @@
 Testname: fields-version-bad-rc
 Version: 1.0+rc3-1
-Description: Test for bad release cand. versions
+Description: Test for bad release candidate versions
 Type: non-native
 Test-For: rc-version-greater-than-expected-version

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 07/07: Add support for passing .buildinfo files to Lintian. (Closes: #853274)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 459ff1784653250fdbd1fd1802a0e9667bec68fd
Author: Chris Lamb 
Date:   Mon Jan 29 10:08:04 2018 +

Add support for passing .buildinfo files to Lintian. (Closes: #853274)
---
 README.md  |   4 +-
 commands/lintian.pm|   8 +-
 debian/changelog   |   4 +
 lib/Lintian/Collect.pm |   3 +
 lib/Lintian/Collect/Buildinfo.pm   | 189 +
 lib/Lintian/Lab.pm |   1 +
 lib/Lintian/Lab/Manifest.pm|  12 +++
 lib/Lintian/Processable/Package.pm |   8 +-
 lib/Lintian/ProcessableGroup.pm|  73 --
 lib/Lintian/ProcessablePool.pm |  28 --
 t/scripts/Lintian/Lab/repair.t |   2 +-
 11 files changed, 284 insertions(+), 48 deletions(-)

diff --git a/README.md b/README.md
index 2d6c7b8..7184412 100644
--- a/README.md
+++ b/README.md
@@ -4,8 +4,8 @@ Lintian - Static Debian package analysis tool
 Lintian is a static analysis tool for finding many bugs, policy
 violations and other issues in Debian based packages.  It can process
 binary Debian packages (.deb), micro/installer packages (.udeb),
-Debian source packages (.dsc) and (to a limited degree) the "changes"
-files.
+Debian source packages (.dsc) and (to a limited degree) the "buildinfo"
+and "changes" files.
 
 
 Running Lintian
diff --git a/commands/lintian.pm b/commands/lintian.pm
index 0c80a6f..9f2a838 100755
--- a/commands/lintian.pm
+++ b/commands/lintian.pm
@@ -1508,17 +1508,15 @@ sub setup_work_pool {
 for my $arg (@ARGV) {
 # file?
 if (-f $arg) {
-if ($arg =~ m/\.(?:u?deb|dsc|changes)$/o){
+if ($arg =~ m/\.(?:u?deb|dsc|changes|buildinfo)$/o){
 eval {$pool->add_file($arg);};
 if ($@) {
 print STDERR "Skipping $arg: $@";
 $exit_code = 2;
 }
 } else {
-fatal_error(
-join(q{ },
-"bad package file name $arg",
-'(neither .deb, .udeb, .changes or .dsc file)'));
+fatal_error("bad package file name $arg (neither .deb, "
+  . '.udeb, .changes .dsc or .buildinfo file)');
 }
 } else {
 # parameter is a package name--so look it up
diff --git a/debian/changelog b/debian/changelog
index bb301ed..e9c825c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -43,6 +43,10 @@ lintian (2.5.73) UNRELEASED; urgency=medium
 + [CL] Detect "backports" (and "backport") as overly generic Python
   module names.  (Closes: #888559)
 
+  * lib/Lintian/*:
++ [CL] Add support for passing .buildinfo files to Lintian.
+  (Closes: #853274)
+
  -- Chris Lamb   Fri, 26 Jan 2018 16:33:51 +1100
 
 lintian (2.5.72) unstable; urgency=medium
diff --git a/lib/Lintian/Collect.pm b/lib/Lintian/Collect.pm
index b1a4e30..60bc49d 100644
--- a/lib/Lintian/Collect.pm
+++ b/lib/Lintian/Collect.pm
@@ -87,6 +87,9 @@ sub new {
 } elsif ($type eq 'binary' or $type eq 'udeb') {
 require Lintian::Collect::Binary;
 $object = Lintian::Collect::Binary->new($pkg);
+} elsif ($type eq 'buildinfo') {
+require Lintian::Collect::Buildinfo;
+$object = Lintian::Collect::Buildinfo->new($pkg);
 } elsif ($type eq 'changes') {
 require Lintian::Collect::Changes;
 $object = Lintian::Collect::Changes->new($pkg);
diff --git a/lib/Lintian/Collect/Buildinfo.pm b/lib/Lintian/Collect/Buildinfo.pm
new file mode 100644
index 000..6b2b399
--- /dev/null
+++ b/lib/Lintian/Collect/Buildinfo.pm
@@ -0,0 +1,189 @@
+# -*- perl -*-
+# Lintian::Collect::Buildinfo -- interface to .buildinfo file data collection
+
+# Copyright (C) 2018 Chris Lamb
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by the Free
+# Software Foundation; either version 2 of the License, or (at your option)
+# any later version.
+#
+# This program is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+# more details.
+#
+# You should have received a copy of the GNU General Public License along with
+# this program.  If not, see .
+
+package Lintian::Collect::Buildinfo;
+
+use strict;
+use warnings;
+use parent 'Lintian::Collect';
+
+use Lintian::Util qw(strip);
+
+=head1 NAME
+
+Lintian::Collect::Buildinfo - Lintian interface to .buildinfo file data 
collection
+
+=head1 SYNOPSIS
+
+my ($name, $type) = ('foobar_1.2_i386.buildinfo', 'changes');
+my $collect = Lintian::Collect->new($name, $type);
+my $files = $collect->files;
+
+fo

[lintian] 06/07: Upgrade severity of missing-debian-source-format from wishlist ("I") to normal ("W"). (Closes: #702671)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit f2145e0eaf4ab01aacb8821e0a51c071435e
Author: Chris Lamb 
Date:   Mon Jan 29 09:19:59 2018 +

Upgrade severity of missing-debian-source-format from wishlist ("I") to 
normal ("W"). (Closes: #702671)
---
 checks/debian-source-dir.desc   | 2 +-
 debian/changelog| 3 +++
 t/source/debian-source-dir-traversal-2/tags | 2 +-
 t/tests/debian-source-dir-general/tags  | 2 +-
 4 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/checks/debian-source-dir.desc b/checks/debian-source-dir.desc
index 5bc7d75..277e8eb 100644
--- a/checks/debian-source-dir.desc
+++ b/checks/debian-source-dir.desc
@@ -6,7 +6,7 @@ Info: This script looks for mistakes in debian/source/* files.
 Needs-Info: unpacked, diffstat
 
 Tag: missing-debian-source-format
-Severity: wishlist
+Severity: normal
 Certainty: certain
 Info: Explicitly selecting a source format by putting the format in
  debian/source/format is recommended.  This allows for
diff --git a/debian/changelog b/debian/changelog
index 4a5db1f..bb301ed 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -5,6 +5,9 @@ lintian (2.5.73) UNRELEASED; urgency=medium
   * checks/cruft.pm:
 + [CL] When looking for the source of "build/foo/bar.min.js", also
   check "src/foo/bar.js".  (Closes: #832027)
+  * checks/debian-source-dir.desc:
++ [CL] Upgrade severity of missing-debian-source-format from wishlist
+  ("I") to normal ("W").  (Closes: #702671)
   * checks/description.{desc.pm}:
 + [CL] Check for packages that mention planned/upcoming features in
   their long description.  (Closes: #782990)
diff --git a/t/source/debian-source-dir-traversal-2/tags 
b/t/source/debian-source-dir-traversal-2/tags
index 0d572f7..0ec4693 100644
--- a/t/source/debian-source-dir-traversal-2/tags
+++ b/t/source/debian-source-dir-traversal-2/tags
@@ -1,4 +1,4 @@
 E: debian-source-dir-traversal-2 source: source-contains-unsafe-symlink 
debian/source
-I: debian-source-dir-traversal-2 source: missing-debian-source-format
 W: debian-source-dir-traversal-2 source: debhelper-compat-file-is-missing
+W: debian-source-dir-traversal-2 source: missing-debian-source-format
 W: debian-source-dir-traversal-2 source: 
package-uses-deprecated-debhelper-compat-version 1
diff --git a/t/tests/debian-source-dir-general/tags 
b/t/tests/debian-source-dir-general/tags
index 9c16f21..ce61b85 100644
--- a/t/tests/debian-source-dir-general/tags
+++ b/t/tests/debian-source-dir-general/tags
@@ -1,2 +1,2 @@
 E: debian-source-dir-general source: unknown-file-in-debian-source formt
-I: debian-source-dir-general source: missing-debian-source-format
+W: debian-source-dir-general source: missing-debian-source-format

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 05/07: Check for override_dh_auto_test targets that do not check DEB_BUILD_OPTIONS for "nocheck". (Closes: #712394)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit deaf67c91e17072d7963b457c9a7f16c2ee309e4
Author: Chris Lamb 
Date:   Mon Jan 29 09:01:27 2018 +

Check for override_dh_auto_test targets that do not check DEB_BUILD_OPTIONS 
for "nocheck". (Closes: #712394)
---
 checks/rules.desc | 19 +++
 checks/rules.pm   | 12 ++--
 debian/changelog  |  3 +++
 .../debian/debian/rules   |  8 
 .../desc  |  5 +
 .../tags  |  0
 .../debian/debian/rules   |  9 +
 .../desc  |  5 +
 .../tags  |  0
 .../debian/debian/rules   |  7 +++
 .../desc  |  5 +
 .../tags  |  1 +
 12 files changed, 72 insertions(+), 2 deletions(-)

diff --git a/checks/rules.desc b/checks/rules.desc
index 4e89148..25fe627 100644
--- a/checks/rules.desc
+++ b/checks/rules.desc
@@ -337,3 +337,22 @@ Info: The debian/rules file for this package has 
a call to
  .
  Please remove the call and let dpkg-deb(1) select suitable defaults.
 Ref: #829100, dpkg-deb(1)
+
+Tag: override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
+Severity: normal
+Certainty: possible
+Info: The debian/rules file for this package has an
+ override_dh_auto_test target that does not appear to
+ check DEB_BUILD_PROFILES against nocheck.
+ .
+ As this check is not automatically performed by debhelper(1), the
+ specified testsuite is run regardless of using the nocheck
+ build profile.
+ .
+ Please add a check such as:
+ .
+  override_dh_auto_test:
+  ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
+  ./run-upstream-testsuite
+  endif
+Ref: https://wiki.debian.org/BuildProfileSpec#Registered_profile_names
diff --git a/checks/rules.pm b/checks/rules.pm
index 4b3086a..3e1b2c3 100644
--- a/checks/rules.pm
+++ b/checks/rules.pm
@@ -166,7 +166,7 @@ sub run {
 my @indep_rules = (qr/^build$/, qr/^build-indep$/, qr/^binary-indep$/);
 my (@current_targets, %rules_per_target,  %debhelper_group);
 my (%seen, %overridden);
-my $maybe_skipping;
+my ($maybe_skipping, @conditionals);
 my %variables;
 my $uses_makefile_pl = 0;
 my $includes = 0;
@@ -251,7 +251,8 @@ sub run {
 }
 
 # Keep track of whether this portion of debian/rules may be optional
-if (/^ifn?(?:eq|def)\s/) {
+if (/^ifn?(?:eq|def)\s(.*)/) {
+push(@conditionals, $1);
 $maybe_skipping++;
 } elsif (/^endif\s/) {
 $maybe_skipping--;
@@ -438,6 +439,13 @@ sub run {
 @{$rules_per_target{"override_$cmd"}};
 }
 
+if (my $line = $overridden{'dh_auto_test'}) {
+tag 'override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES',
+  "(line $line)"
+  if $rules_per_target{'override_dh_auto_test'}
+  and none { m/(DEB_BUILD_OPTIONS|nocheck)/ } @conditionals;
+}
+
 # Make sure that all the required build dependencies are there.  Don't
 # issue missing-build-dependency errors for debhelper, since there's
 # another test that does that and it would just be a duplicate.
diff --git a/debian/changelog b/debian/changelog
index 161807d..4a5db1f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -25,6 +25,9 @@ lintian (2.5.73) UNRELEASED; urgency=medium
   * checks/patch-systems.{desc,pm}:
 + [CL] Emit a pedantic warning for packages that are using the dpatch
   patch system.  (Closes: #884500)
+  * checks/rules.pm:
++ [CL] Check for override_dh_auto_test targets that do not check
+  DEB_BUILD_OPTIONS for "nocheck".  (Closes: #712394)
   * checks/source-copyright.{desc,pm}:
 + [CL] Warn about packages that specify a Files-Excluded header without
   a valid Format header as the former will be ignored by uscan(1).
diff --git 
a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/debian/debian/rules
 
b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/debian/debian/rules
new file mode 100755
index 000..a205d48
--- /dev/null
+++ 
b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/debian/debian/rules
@@ -0,0 +1,8 @@
+#!/usr/bin/make -f
+
+%:
+   dh $@
+
+# Empty target follows
+override_dh_auto_test:
+   # comment
diff --git 
a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/desc 
b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/desc
new file mode 100644
index 000..09f3706
--- /dev/null
+++ b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/desc
@@ -0,0 +1,

[lintian] 04/07: Check for packages that specify binary dependencies on toolchain packages such as cdbs or debhelper. (Closes: #700953)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit d177589edbef64aa837ff3984f9fa387ec3d819c
Author: Chris Lamb 
Date:   Mon Jan 29 05:28:31 2018 +

Check for packages that specify binary dependencies on toolchain packages 
such as cdbs or debhelper. (Closes: #700953)
---
 checks/fields.desc  | 12 +++-
 checks/fields.pm|  5 +
 data/fields/toolchain   |  2 ++
 debian/changelog|  2 ++
 t/tests/fields-depends-general/debian/debian/control.in |  4 ++--
 t/tests/fields-depends-general/desc |  1 +
 t/tests/fields-depends-general/tags |  2 ++
 7 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/checks/fields.desc b/checks/fields.desc
index fe4dbbe..24f0f58 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -1406,7 +1406,7 @@ Certainty: possible
 Info: Based on the content of the maintainer and uploader fields this
  package is co-maintained but there are no Vcs-* fields.
  .
- It is recommended that shared maintenance of packages are co-ordinated
+ It is recommended 
  via a revision control system.
 
 Tag: multi-arch-same-package-has-arch-specific-overrides
@@ -1415,3 +1415,13 @@ Certainty: certain
 Info: The specified file contains architecture-specific Lintian overrides
  but this package is declared as Multi-Arch: same.
 Ref: lintian 2.4.3, #787406
+
+Tag: binary-package-depends-on-toolchain-package
+Severity: normal
+Certainty: possible
+Info: The package specifies a binary dependecy on a "toolchain" package
+ such as debhelper or cdbs. This is likely to a mistake as these packages
+ are typically specified as build-dependencis.
+ .
+ If the package intentionally requires such a dependency, please add a
+ Lintian override.
diff --git a/checks/fields.pm b/checks/fields.pm
index c0a3509..872a6ec 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -43,6 +43,7 @@ use constant {
 };
 
 our $KNOWN_ESSENTIAL = Lintian::Data->new('fields/essential');
+our $KNOWN_TOOLCHAIN = Lintian::Data->new('fields/toolchain');
 our $KNOWN_METAPACKAGES = Lintian::Data->new('fields/metapackages');
 our $NO_BUILD_DEPENDS = Lintian::Data->new('fields/no-build-depends');
 our $KNOWN_SECTIONS = Lintian::Data->new('fields/archive-sections');
@@ -893,6 +894,10 @@ sub run {
 && $pkg !~ m/-(?:dev|docs?|tools|bin)$/
 && $part_d_orig =~ m/-docs?$/);
 
+tag 'binary-package-depends-on-toolchain-package',
+  "$field: $part_d_orig"
+  if $KNOWN_TOOLCHAIN->known($d_pkg);
+
 # default-jdk-doc must depend on openjdk-X-doc (or
 # classpath-doc) to be useful; other packages
 # should depend on default-jdk-doc if they want
diff --git a/data/fields/toolchain b/data/fields/toolchain
new file mode 100644
index 000..d1d9497
--- /dev/null
+++ b/data/fields/toolchain
@@ -0,0 +1,2 @@
+cdbs
+debhelper
diff --git a/debian/changelog b/debian/changelog
index 5766f66..161807d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -17,6 +17,8 @@ lintian (2.5.73) UNRELEASED; urgency=medium
 + [CL] Warn about Multi-Arch: same packages that ship
   architecture-specific Lintian overrides. Thanks to Sebastian
   Ramacher for the report.  (Closes: #787469)
++ [CL] Check for packages that specify binary dependencies on toolchain
+  packages such as cdbs or debhelper.  (Closes: #700953)
   * checks/java.{desc,pm}:
 + [CL] Check for .jar files that do not match the Debian Java policy.
   (Closes: #791552)
diff --git a/t/tests/fields-depends-general/debian/debian/control.in 
b/t/tests/fields-depends-general/debian/debian/control.in
index de9129a..2844548 100644
--- a/t/tests/fields-depends-general/debian/debian/control.in
+++ b/t/tests/fields-depends-general/debian/debian/control.in
@@ -12,7 +12,7 @@ Depends: $\{shlibs:Depends\}, $\{misc:Depends\}, xorg, bash,
  conflict-dep, gawk | awk, new-package | xbase-clients (>= 0.1), {$source},
  gaim (>= 0.1), emacs21, emacs22, emacs23, makedev, libtest-simple-perl (>= 
0.98),
  packaging-dev, xfont-a, emacs22-gtk, emacs23-el, emacs23-nox, emacs23-lucid,
- emacs222, perl-modules
+ emacs222, perl-modules, debhelper
 Breaks: package-without-version, {$source} (<< 0.1),
  replaced-wo-version
 Replaces: replaced-wo-version
@@ -25,7 +25,7 @@ Description: {$description}
 Package: lib{$source}
 Architecture: {$architecture}
 Depends: $\{shlibs:Depends\}, $\{misc:Depends\}, libdb1-compat, 
perl-modules-5.22
-Recommends: debconf-doc
+Recommends: debconf-doc, cdbs
 Section: libs
 Description: {$description} -- fake library
  This is a fake library designed to exercise some feature or tag of
diff --git a/t/tests/fields-depends-gene

[lintian] branch master updated (f444db6 -> 459ff17)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  f444db6   Check for packages that mention planned/upcoming features 
in their long description. (Closes: #782990)
   new  d14ed8a   Check for .jar files that do not match the Debian Java 
policy. (Closes: #791552)
   new  ff64507   checs/java.pm: Use dirname(...) over regular expressions.
   new  518f297   Improve the 
description-synopsis-might-not-be-phrased-properly tag also detect multiple 
sentences and improve the tag description. (Closes: #778427)
   new  d177589   Check for packages that specify binary dependencies on 
toolchain packages such as cdbs or debhelper. (Closes: #700953)
   new  deaf67c   Check for override_dh_auto_test targets that do not check 
DEB_BUILD_OPTIONS for "nocheck". (Closes: #712394)
   new  f2145e0   Upgrade severity of missing-debian-source-format from 
wishlist ("I") to normal ("W"). (Closes: #702671)
   new  459ff17   Add support for passing .buildinfo files to Lintian. 
(Closes: #853274)

The 7 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 README.md  |  4 +-
 checks/debian-source-dir.desc  |  2 +-
 checks/description.desc| 15 +++--
 checks/description.pm  |  2 +-
 checks/fields.desc | 12 +++-
 checks/fields.pm   |  5 ++
 checks/java.desc   |  8 +++
 checks/java.pm | 10 +--
 checks/rules.desc  | 19 ++
 checks/rules.pm| 12 +++-
 commands/lintian.pm|  8 +--
 data/fields/toolchain  |  2 +
 debian/changelog   | 20 +-
 lib/Lintian/Collect.pm |  3 +
 lib/Lintian/Collect/{Changes.pm => Buildinfo.pm}   | 22 +++
 lib/Lintian/Lab.pm |  1 +
 lib/Lintian/Lab/Manifest.pm| 12 
 lib/Lintian/Processable/Package.pm |  8 +--
 lib/Lintian/ProcessableGroup.pm| 73 +-
 lib/Lintian/ProcessablePool.pm | 28 ++---
 t/scripts/Lintian/Lab/repair.t |  2 +-
 t/source/debian-source-dir-traversal-2/tags|  2 +-
 t/tests/debian-source-dir-general/tags |  2 +-
 .../description-general/debian/debian/control.in   |  9 +++
 t/tests/description-general/tags   |  1 +
 .../debian/debian/control.in   |  4 +-
 t/tests/fields-depends-general/desc|  1 +
 t/tests/fields-depends-general/tags|  2 +
 .../desc   |  2 +-
 t/tests/fields-version-bad-rc/desc |  2 +-
 t/tests/java-class-format/desc |  1 +
 t/tests/java-classpath/desc|  1 +
 .../java-jars/debian/debian/libtesta-java.install  |  1 +
 t/tests/java-jars/debian/debian/rules  |  1 +
 t/tests/java-jars/desc |  2 +
 t/tests/java-jars/tags |  1 +
 .../debian/debian/rules|  8 +++
 .../desc   |  5 ++
 .../tags   |  0
 .../debian/debian/rules|  9 +++
 .../desc   |  5 ++
 .../tags   |  0
 .../debian/debian/rules|  7 +++
 .../desc   |  5 ++
 .../tags   |  1 +
 45 files changed, 258 insertions(+), 82 deletions(-)
 create mode 100644 data/fields/toolchain
 copy lib/Lintian/Collect/{Changes.pm => Buildinfo.pm} (82%)
 create mode 100755 
t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/debian/debian/rules
 create mode 100644 
t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/desc
 copy t/{debs/deb-format-record-size => 
tests/rules-dh-auto-test-does-not-check-deb-build-options-empty}/tags (100%)
 create mode 100755 
t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel/debian/debian/rules
 create mode 100644 
t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel/desc
 copy t/{debs/deb-format-record-size => 
tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel}/tags (100%)
 create mode 100755 
t/tests/rules-dh-auto-test-does-not-check-deb-build-options/debian/debian/rules
 creat

Bug#700953: lintian: Warn about binary packages depending on debhelper, cdbs etc.

[Chris Lamb]

tags 700953 + pending
thanks

Fixed in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=d177589edbef64aa837ff3984f9fa387ec3d819c


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#702671: lintian: Please make missing-debian-source-format proper

[Chris Lamb]

tags 702671 + pending
thanks

Fixed in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=f2145e0eaf4ab01aacb8821e0a51c071435e


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#712394: lintian: Warn if override_dh_auto_test target doesn't check for DEB_BUILD_OPTIONS=nocheck

[Chris Lamb]

tags 712394 + pending
thanks

Fixed in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=deaf67c91e17072d7963b457c9a7f16c2ee309e4


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#778427: lintian: Possible improvement to description-synopsis-might-not-be-phrased-properly

[Chris Lamb]

tags 778427 + pending
thanks

Fixed in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=518f2979822557024a3501e9a731e51ceb8220ea


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#791552: lintian: Verify that .jar filename complies with Debian Java Policy

[Chris Lamb]

tags 791552 + pending
thanks

Fixed in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=d14ed8a3ae8fadcfec771d3d2befc2da6585667b


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Processed: Re: lintian: Warn if override_dh_auto_test target doesn't check for DEB_BUILD_OPTIONS=nocheck

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 712394 + pending
Bug #712394 [lintian] lintian: Warn if override_dh_auto_test target doesn't 
check for DEB_BUILD_OPTIONS=nocheck
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
712394: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=712394
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#853274: lintian: Please recurse into .buildinfo to find .debs

[Chris Lamb]

tags 853274 + pending
thanks

Fixed in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=459ff1784653250fdbd1fd1802a0e9667bec68fd


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Processed: Re: lintian: Please recurse into .buildinfo to find .debs

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 853274 + pending
Bug #853274 [lintian] lintian: Please recurse into .buildinfo to find .debs
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
853274: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=853274
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Processed: Re: lintian: Warn about binary packages depending on debhelper, cdbs etc.

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 700953 + pending
Bug #700953 [lintian] lintian: Warn about binary packages depending on 
debhelper, cdbs etc.
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
700953: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=700953
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Processed: Re: lintian: Verify that .jar filename complies with Debian Java Policy

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 791552 + pending
Bug #791552 [lintian] lintian: Verify that .jar filename complies with Debian 
Java Policy
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
791552: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=791552
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Processed: Re: lintian: Please make missing-debian-source-format proper

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 702671 + pending
Bug #702671 [lintian] lintian: Please make missing-debian-source-format proper
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
702671: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=702671
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Processed: Re: lintian: Possible improvement to description-synopsis-might-not-be-phrased-properly

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 778427 + pending
Bug #778427 [lintian] lintian: Possible improvement to 
description-synopsis-might-not-be-phrased-properly
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
778427: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=778427
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

[lintian] branch master updated (459ff17 -> 3a3ce2f)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  459ff17   Add support for passing .buildinfo files to Lintian. 
(Closes: #853274)
   new  3a3ce2f   Correct spelling test failures by adding buildinfo the 
"known good" word list.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 t/scripts/pod-spelling.t | 1 +
 1 file changed, 1 insertion(+)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: Correct spelling test failures by adding buildinfo the "known good" word list.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 3a3ce2f77a05ef49d721984ee899b3beb7d917c4
Author: Chris Lamb 
Date:   Mon Jan 29 15:19:58 2018 +

Correct spelling test failures by adding buildinfo the "known good" word 
list.
---
 t/scripts/pod-spelling.t | 1 +
 1 file changed, 1 insertion(+)

diff --git a/t/scripts/pod-spelling.t b/t/scripts/pod-spelling.t
index 5b38a96..4fd1015 100755
--- a/t/scripts/pod-spelling.t
+++ b/t/scripts/pod-spelling.t
@@ -122,6 +122,7 @@ REMOVESLASH STAMPFILE TAGNAME TCODE TESTDATA BLOCKSIZE jN
 POSIX t1c2pfb init runtime txt executability writability
 INHANDLE OUTHANDLES UTC timestamp faux tagname READMEs Testname
 debhelper dh buildpackage uaccess udev AppStream plugdev dbgsym
+buildinfo
 
 __END__
 

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Build failed in Jenkins: lintian-tests_sid #2498

[jenkins]

See 


Changes:

[lamby] Check for .jar files that do not match the Debian Java policy. (Closes:

[lamby] checs/java.pm: Use dirname(...) over regular expressions.

[lamby] Improve the description-synopsis-might-not-be-phrased-properly tag also

[lamby] Check for packages that specify binary dependencies on toolchain

[lamby] Check for override_dh_auto_test targets that do not check

[lamby] Upgrade severity of missing-debian-source-format from wishlist ("I") to

[lamby] Add support for passing .buildinfo files to Lintian. (Closes: #853274)

--
[...truncated 244.87 KB...]
Adding debian:DST_ACES_CA_X6.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_EV_2009.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_2009.pem
Adding debian:Cybertrust_Global_Root.pem
Adding debian:Comodo_Trusted_Services_root.pem
Adding debian:Comodo_Secure_Services_root.pem
Adding debian:Comodo_AAA_Services_root.pem
Adding debian:China_Internet_Network_Information_Center_EV_Certificates_Root.pem
Adding debian:Chambers_of_Commerce_Root_-_2008.pem
Adding debian:Certum_Trusted_Network_CA_2.pem
Adding debian:Certum_Trusted_Network_CA.pem
Adding debian:Certum_Root_CA.pem
Adding debian:Certplus_Root_CA_G2.pem
Adding debian:Certplus_Root_CA_G1.pem
Adding debian:Certplus_Class_2_Primary_CA.pem
Adding debian:Certinomis_-_Root_CA.pem
Warning: there was a problem reading the certificate file 
/etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem. Message:
  /etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem (No such file or directory)
Adding debian:Certigna.pem
Adding debian:Camerfirma_Global_Chambersign_Root.pem
Adding debian:Camerfirma_Chambers_of_Commerce_Root.pem
Adding debian:COMODO_RSA_Certification_Authority.pem
Adding debian:COMODO_ECC_Certification_Authority.pem
Adding debian:COMODO_Certification_Authority.pem
Adding debian:CNNIC_ROOT.pem
Adding debian:CFCA_EV_ROOT.pem
Adding debian:CA_Disig_Root_R2.pem
Adding debian:CA_Disig_Root_R1.pem
Adding debian:Buypass_Class_3_Root_CA.pem
Adding debian:Buypass_Class_2_Root_CA.pem
Adding debian:Baltimore_CyberTrust_Root.pem
Adding debian:Autoridad_de_Certificacion_Firmaprofesional_CIF_A62634068.pem
Adding debian:Atos_TrustedRoot_2011.pem
Adding debian:Amazon_Root_CA_4.pem
Adding debian:Amazon_Root_CA_3.pem
Adding debian:Amazon_Root_CA_2.pem
Adding debian:Amazon_Root_CA_1.pem
Adding debian:AffirmTrust_Premium_ECC.pem
Adding debian:AffirmTrust_Premium.pem
Adding debian:AffirmTrust_Networking.pem
Adding debian:AffirmTrust_Commercial.pem
Adding debian:AddTrust_Qualified_Certificates_Root.pem
Adding debian:AddTrust_Public_Services_Root.pem
Adding debian:AddTrust_Low-Value_Services_Root.pem
Adding debian:AddTrust_External_Root.pem
Adding debian:Actalis_Authentication_Root_CA.pem
Adding debian:AC_RAIZ_FNMT-RCM.pem
Adding debian:ACEDICOM_Root.pem
Adding debian:ACCVRAIZ1.pem
done.
Setting up openjdk-8-jdk-headless:amd64 (8u151-b12-1) ...
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/idlj to 
provide /usr/bin/idlj (idlj) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jdeps to 
provide /usr/bin/jdeps (jdeps) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/wsimport to 
provide /usr/bin/wsimport (wsimport) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/rmic to 
provide /usr/bin/rmic (rmic) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jinfo to 
provide /usr/bin/jinfo (jinfo) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jsadebugd to 
provide /usr/bin/jsadebugd (jsadebugd) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/native2ascii 
to provide /usr/bin/native2ascii (native2ascii) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstat to 
provide /usr/bin/jstat (jstat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javac to 
provide /usr/bin/javac (javac) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javah to 
provide /usr/bin/javah (javah) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstack to 
provide /usr/bin/jstack (jstack) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jrunscript to 
provide /usr/bin/jrunscript (jrunscript) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javadoc to 
provide /usr/bin/javadoc (javadoc) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jhat to 
provide /usr/bin/jhat (jhat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javap to 
provide /usr/bin/javap (javap) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jar to provide 
/usr/bin/jar (jar) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-op

Jenkins build is back to normal : lintian-tests_sid #2499

[jenkins]

See 

Bug#684286: lintian: Please add check for MA:foreign package with files in /usr/lib/

[Chris Lamb]

Bastien ROUCARIÈS wrote:

> Patch here

.. but there is no patch! :)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Re: [lintian] 04/07: Check for packages that specify binary dependencies on toolchain packages such as cdbs or debhelper. (Closes: #700953)

[Niels Thykier]

Chris Lamb:
> This is an automated email from the git hooks/post-receive script.
> 
> lamby pushed a commit to branch master
> in repository lintian.
> 
> commit d177589edbef64aa837ff3984f9fa387ec3d819c
> Author: Chris Lamb 
> Date:   Mon Jan 29 05:28:31 2018 +
> 
> Check for packages that specify binary dependencies on toolchain packages 
> such as cdbs or debhelper. (Closes: #700953)
> ---
>  [...]
> diff --git a/checks/fields.desc b/checks/fields.desc
> index fe4dbbe..24f0f58 100644
> --- a/checks/fields.desc
> +++ b/checks/fields.desc
> [...]
> +
> +Tag: binary-package-depends-on-toolchain-package
> +Severity: normal
> +Certainty: possible
> +Info: The package specifies a binary dependecy on a "toolchain" package
> + such as debhelper or cdbs. This is likely to a mistake as these packages
> + are typically specified as build-dependencis.
> + .
> + If the package intentionally requires such a dependency, please add a
> + Lintian override.
> diff --git a/checks/fields.pm b/checks/fields.pm
> index c0a3509..872a6ec 100644
> --- a/checks/fields.pm
> +++ b/checks/fields.pm
> @@ -43,6 +43,7 @@ use constant {
>  };
>  
>  our $KNOWN_ESSENTIAL = Lintian::Data->new('fields/essential');
> +our $KNOWN_TOOLCHAIN = Lintian::Data->new('fields/toolchain');
>  our $KNOWN_METAPACKAGES = Lintian::Data->new('fields/metapackages');
>  our $NO_BUILD_DEPENDS = Lintian::Data->new('fields/no-build-depends');
>  our $KNOWN_SECTIONS = Lintian::Data->new('fields/archive-sections');
> @@ -893,6 +894,10 @@ sub run {
>  && $pkg !~ m/-(?:dev|docs?|tools|bin)$/
>  && $part_d_orig =~ m/-docs?$/);
>  
> +tag 'binary-package-depends-on-toolchain-package',
> +  "$field: $part_d_orig"
> +  if $KNOWN_TOOLCHAIN->known($d_pkg);
> +
>  # default-jdk-doc must depend on openjdk-X-doc (or
>  # classpath-doc) to be useful; other packages
>  # should depend on default-jdk-doc if they want
> [...]
> 

Hi,

I think this check is too simple;  there are plenty of packages with a
legitimate dependency on debhelper, such as all of packages providing a
dh_* tool.

Thanks,
~Niels

Re: [lintian] 04/07: Check for packages that specify binary dependencies on toolchain packages such as cdbs or debhelper. (Closes: #700953)

[Chris Lamb]

Hi Niels,

> this check is too simple;  there are plenty of packages with a
> legitimate dependency on debhelper, such as all of packages providing a
> dh_* tool.

Any ideas? I mean, it's easily to exclude "dh-*", but the rest are a
pretty random bunch.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

[lintian] 03/04: Check for inconsistencies between "Files" and Checksums-* sections in .changes files. (Closes: #658542)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit a5aa7a0878781ec64e5fbfbfd278c04b32edc0be
Author: Chris Lamb 
Date:   Mon Jan 29 19:07:08 2018 +

Check for inconsistencies between "Files" and Checksums-* sections in 
.changes files. (Closes: #658542)
---
 checks/changes-file.desc |  7 +++
 checks/changes-file.pm   | 11 +++
 debian/changelog |  2 ++
 3 files changed, 20 insertions(+)

diff --git a/checks/changes-file.desc b/checks/changes-file.desc
index b7a11e6..13b347b 100644
--- a/checks/changes-file.desc
+++ b/checks/changes-file.desc
@@ -80,6 +80,13 @@ Info: The actual checksum does not match what's listed in the
  .changes file.
 Ref: policy 5.6.21, policy 5.6.24
 
+Tag: checksum-count-mismatch-in-changes-file
+Severity: serious
+Certainty: certain
+Info: The number of checksums .changes file for the
+ specified algorithm does not match the number of files.
+Ref: policy 5.6.21, policy 5.6.24
+
 Tag: bad-section-in-changes-file
 Severity: important
 Certainty: certain
diff --git a/checks/changes-file.pm b/checks/changes-file.pm
index 5f37ad2..35a82d4 100644
--- a/checks/changes-file.pm
+++ b/checks/changes-file.pm
@@ -195,6 +195,7 @@ sub run {
 
 my $files = $info->files;
 my $path = readlink($info->lab_data_path('changes'));
+my %num_checksums;
 $path =~ s#/[^/]+$##;
 foreach my $file (keys %$files) {
 my $file_info = $files->{$file};
@@ -239,6 +240,7 @@ sub run {
 next unless exists $file_info->{checksums}{$alg};
 
 my $real_checksum = get_file_checksum($alg, $filename);
+$num_checksums{$alg}++;
 
 if ($real_checksum ne $file_info->{checksums}{$alg}{sum}) {
 tag 'checksum-mismatch-in-changes-file', $alg, $file;
@@ -246,6 +248,15 @@ sub run {
 }
 }
 
+# Check that we have a consistent number of checksums and files
+foreach my $alg (keys %num_checksums) {
+my $seen = $num_checksums{$alg};
+my $expected = keys %{$files};
+tag 'checksum-count-mismatch-in-changes-file',
+  "$seen $alg checksums != $expected files"
+  if $seen != $expected;
+}
+
 return;
 }
 
diff --git a/debian/changelog b/debian/changelog
index 5a4a67b..e240d0a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -21,6 +21,8 @@ lintian (2.5.73) UNRELEASED; urgency=medium
   file-size-mismatch-in-changes-file and
   checksum-mismatch-in-changes-file tags were not being checked if a
   package contained an upstream signature.
++ [CL] Check for inconsistencies between "Files" and Checksums-*
+  sections in .changes files.  (Closes: #658542)
   * checks/fields.{desc,pm}:
 + [CL] Add a pedantic warning for co-maintained packages that are not
   managed in a revision control system.  (Closes: #884497)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (3a3ce2f -> 3532dd3)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  3a3ce2f   Correct spelling test failures by adding buildinfo the 
"known good" word list.
   new  2f1efb4   Check for source format 1.0 files that ship upstream 
signatures as this is not supported in stretch. (Closes: #823190)
   new  352c3eb   Fix an issue where the bad-section-in-changes-file, 
file-size-mismatch-in-changes-file and checksum-mismatch-in-changes-file tags 
were not being checked if a package contained an upstream signature. package 
contained an upstream signature.
   new  a5aa7a0   Check for inconsistencies between "Files" and Checksums-* 
sections in .changes files. (Closes: #658542)
   new  3532dd3   Add Adam to copyright to make the AUTHOR section somewhat 
more consistent.

The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/changes-file.desc | 17 +
 checks/changes-file.pm   | 20 ++--
 debian/changelog |  9 +
 lib/Lintian/Collect/Buildinfo.pm |  1 +
 4 files changed, 45 insertions(+), 2 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/04: Check for source format 1.0 files that ship upstream signatures as this is not supported in stretch. (Closes: #823190)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 2f1efb44994b066c22a985c09a853fc9583aacf8
Author: Chris Lamb 
Date:   Mon Jan 29 16:20:07 2018 +

Check for source format 1.0 files that ship upstream signatures as this is 
not supported in stretch. (Closes: #823190)
---
 checks/changes-file.desc | 10 ++
 checks/changes-file.pm   |  5 +
 debian/changelog |  3 +++
 3 files changed, 18 insertions(+)

diff --git a/checks/changes-file.desc b/checks/changes-file.desc
index 27fbf60..b7a11e6 100644
--- a/checks/changes-file.desc
+++ b/checks/changes-file.desc
@@ -199,3 +199,13 @@ Info: The packaging includes an upstream signing key but 
the corresponding
  .
  Support for signatures was added to pristine-tar in version 1.41
  and support in git-buildpackage is being tracked in #872864.
+
+Tag: source-format-1.0-with-upstream-signature
+Severity: normal
+Certainty: certain
+Info: The packaging includes an upstream signature but the package uses
+ source format "1.0".
+ .
+ Whilst these have been supported for extraction and building since dpkg
+ 1.18.5, this means they are unsupported in stretch.
+Ref: dpkg-source(1), #823190
diff --git a/checks/changes-file.pm b/checks/changes-file.pm
index d8254a9..74f99ba 100644
--- a/checks/changes-file.pm
+++ b/checks/changes-file.pm
@@ -23,6 +23,8 @@ use strict;
 use warnings;
 use autodie;
 
+use List::Moreutils qw(any);
+
 use Lintian::Tags qw(tag);
 use Lintian::Check qw(check_maintainer);
 use Lintian::Data;
@@ -186,6 +188,9 @@ sub run {
 last;
 }
 }
+tag 'source-format-1.0-with-upstream-signature'
+  if $src->info->field('format', '1.0') eq '1.0'
+  and any { m/\.asc$/ } %{$info->files};
 }
 
 my $files = $info->files;
diff --git a/debian/changelog b/debian/changelog
index e9c825c..fdd2b49 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -14,6 +14,9 @@ lintian (2.5.73) UNRELEASED; urgency=medium
 + [CL] Improve the description-synopsis-might-not-be-phrased-properly
   tag also detect multiple sentences and improve the tag description.
   (Closes: #778427)
+  * checks/changes-file.{desc.pm}:
++ [CL] Check for source format 1.0 files that ship upstream signatures
+  as this is not supported in stretch.  (Closes: #823190)
   * checks/fields.{desc,pm}:
 + [CL] Add a pedantic warning for co-maintained packages that are not
   managed in a revision control system.  (Closes: #884497)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 04/04: Add Adam to copyright to make the AUTHOR section somewhat more consistent.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 3532dd3c66567c42289fa2ee6653f779807aeb3f
Author: Chris Lamb 
Date:   Mon Jan 29 19:11:57 2018 +

Add Adam to copyright to make the AUTHOR section somewhat more consistent.
---
 lib/Lintian/Collect/Buildinfo.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/Lintian/Collect/Buildinfo.pm b/lib/Lintian/Collect/Buildinfo.pm
index 6b2b399..c6f03c8 100644
--- a/lib/Lintian/Collect/Buildinfo.pm
+++ b/lib/Lintian/Collect/Buildinfo.pm
@@ -1,6 +1,7 @@
 # -*- perl -*-
 # Lintian::Collect::Buildinfo -- interface to .buildinfo file data collection
 
+# Copyright (C) 2010 Adam D. Barratt
 # Copyright (C) 2018 Chris Lamb
 #
 # This program is free software; you can redistribute it and/or modify it

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 02/04: Fix an issue where the bad-section-in-changes-file, file-size-mismatch-in-changes-file and checksum-mismatch-in-changes-file tags were not being checked if a package contained an upst

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 352c3eb6bc2286e29b6ee3af4d198334f6277856
Author: Chris Lamb 
Date:   Mon Jan 29 18:53:36 2018 +

Fix an issue where the bad-section-in-changes-file, 
file-size-mismatch-in-changes-file and checksum-mismatch-in-changes-file tags 
were not being checked if a package contained an upstream signature. package 
contained an upstream signature.
---
 checks/changes-file.pm | 4 ++--
 debian/changelog   | 4 
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/checks/changes-file.pm b/checks/changes-file.pm
index 74f99ba..5f37ad2 100644
--- a/checks/changes-file.pm
+++ b/checks/changes-file.pm
@@ -205,8 +205,8 @@ sub run {
 && $file =~ m/\.orig(-[A-Za-z\d-]+)?\.tar\./
 && $file !~ m/\.asc$/
 && $info->field('version') !~ m/(?:dfsg|debian|ds|repack)/) {
-next if exists $files->{"$file.asc"};
-tag 'orig-tarball-missing-upstream-signature', $file;
+tag 'orig-tarball-missing-upstream-signature', $file
+  unless exists $files->{"$file.asc"};
 }
 
 # check section
diff --git a/debian/changelog b/debian/changelog
index fdd2b49..5a4a67b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -17,6 +17,10 @@ lintian (2.5.73) UNRELEASED; urgency=medium
   * checks/changes-file.{desc.pm}:
 + [CL] Check for source format 1.0 files that ship upstream signatures
   as this is not supported in stretch.  (Closes: #823190)
++ [CL] Fix an issue where the bad-section-in-changes-file,
+  file-size-mismatch-in-changes-file and
+  checksum-mismatch-in-changes-file tags were not being checked if a
+  package contained an upstream signature.
   * checks/fields.{desc,pm}:
 + [CL] Add a pedantic warning for co-maintained packages that are not
   managed in a revision control system.  (Closes: #884497)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#658542: lintian: Does not report inconsistencies between "files" and "checksum" sections in changes file

[Chris Lamb]

tags 658542 + pending
thanks

Fixed in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=a5aa7a0878781ec64e5fbfbfd278c04b32edc0be


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Processed: Re: lintian: Does not report inconsistencies between "files" and "checksum" sections in changes file

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 658542 + pending
Bug #658542 [lintian] lintian: Does not report inconsistencies between "files" 
and "checksum" sections in changes file
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
658542: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=658542
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#823190: lintian: Please error out on orig tarball sigs for source 1.0

[Chris Lamb]

tags 823190 + pending
thanks

Fixed in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=2f1efb44994b066c22a985c09a853fc9583aacf8


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Processed: Re: lintian: Please error out on orig tarball sigs for source 1.0

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 823190 + pending
Bug #823190 [lintian] lintian: Please error out on orig tarball sigs for source 
1.0
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
823190: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823190
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Re: [lintian] 04/07: Check for packages that specify binary dependencies on toolchain packages such as cdbs or debhelper. (Closes: #700953)

[Niels Thykier]

Chris Lamb:
> Hi Niels,
> 
>> this check is too simple;  there are plenty of packages with a
>> legitimate dependency on debhelper, such as all of packages providing a
>> dh_* tool.
> 
> Any ideas? I mean, it's easily to exclude "dh-*", but the rest are a
> pretty random bunch.
> 
> 
> Regards,
> 

We have a bunch of data files mapping dh_* commands to packages. I
suspect it is "just" a question of reversing those mappings.

Thanks,
~Niels

Build failed in Jenkins: lintian-tests_sid #2500

[jenkins]

See 


Changes:

[lamby] Check for source format 1.0 files that ship upstream signatures as this

[lamby] Fix an issue where the bad-section-in-changes-file,

[lamby] Check for inconsistencies between "Files" and Checksums-* sections in

[lamby] Add Adam to copyright to make the AUTHOR section somewhat more

--
[...truncated 1004.19 KB...]
tests::testsuite-unnecessary-testsuite-autopkgtest-header
tests::testsuite-unnecessary-testsuite-autopkgtest-header
tests::po-debconf-general
tests::po-debconf-general
tests::scripts-maintainer-script-empty
tests::scripts-maintainer-script-empty
tests::scripts-ocamlrun
tests::scripts-ocamlrun
tests::source-copyright-dep5-syntax-error
tests::source-copyright-dep5-syntax-error
tests::scripts-uses-perl4-libs-with-dep
tests::scripts-uses-perl4-libs-with-dep
tests::patch-systems-empty-series
tests::patch-systems-empty-series
tests::source-copyright-unknown-uri
tests::source-copyright-unknown-uri
tests::filename-length-really-really-really-really-long-package-name
tests::filename-length-really-really-really-really-long-package-name
tests::rules-dh-unused-target
tests::shared-libs-exec-bit
tests::rules-dh-unused-target
tests::shared-libs-exec-bit
tests::rules-not-makefile
tests::rules-not-makefile
tests::shared-libs-dev-symlink-fp
tests::shared-libs-dev-symlink-fp
tests::scripts-calls-init-script
tests::scripts-calls-init-script
tests::legacy-debconf
tests::legacy-debconf
tests::group-checks-file-conflict
tests::group-checks-file-conflict
tests::ocaml-general
tests::ocaml-general
tests::standards-version-timewarp
tests::standards-version-timewarp
tests::patch-systems-quilt-no-series
tests::patch-systems-quilt-no-series
tests::triggers-general
tests::triggers-general
tests::systemd-general
tests::systemd-general
tests::source-copyright-wildcard-matching
tests::scripts-diversions
tests::source-copyright-wildcard-matching
tests::scripts-diversions
tests::source-copyright-empty-field
tests::spelling-multiword
tests::source-copyright-empty-field
tests::spelling-multiword
tests::scripts-script-needs-depends-on-sensible-utils
tests::scripts-script-needs-depends-on-sensible-utils
tests::java-classpath
tests::java-classpath
tests::source-copyright-wiki-uri
tests::source-copyright-wiki-uri
tests::rules-override-dh-foo-does-not-call-dh-foo
tests::rules-override-dh-foo-does-not-call-dh-foo
tests::rules-perl-makemaker
tests::rules-perl-makemaker
tests::patch-systems-no-patch-system
tests::patch-systems-no-patch-system
tests::standards-version-invalid
tests::standards-version-invalid
tests::rules-special-variables
tests::rules-missing-targets-with-includes
tests::rules-special-variables
tests::patch-systems-quilt-general
tests::patch-systems-quilt-general
tests::rules-missing-targets-with-includes
tests::scripts-control-interpreters
tests::scripts-control-interpreters
tests::rules-dh-unused-target-nonempty
tests::rules-dh-unused-target-nonempty
tests::java-jars
tests::java-jars
tests::testsuite-autopkgtest-missing
tests::testsuite-autopkgtest-missing
tests::spelling-general
tests::spelling-general
tests::scripts-diversions-variables
tests::scripts-diversions-variables
tests::shared-libs-exec-stack
tests::shared-libs-exec-stack
tests::spelling-package-name
tests::spelling-package-name
tests::source-copyright-unique
tests::source-copyright-unique
tests::python-build-depends-on-sphinx
tests::python-build-depends-on-sphinx
tests::scripts-exec
tests::scripts-exec
tests::legacy-filenames
tests::legacy-filenames
tests::rules-sets-dpkg-architecture-variable
tests::rules-sets-dpkg-architecture-variable
tests::standards-version-newer
tests::standards-version-newer
tests::patch-systems-quilt-no-depends
tests::patch-systems-quilt-no-depends
tests::rules-symlink
tests::rules-symlink
tests::patch-systems-quilt-debian-changes
tests::patch-systems-quilt-debian-changes
tests::legacy-debug
tests::legacy-debug
tests::rules-missing-targets-with-known-includes
tests::rules-missing-targets-with-known-includes
tests::maintscript-includes-maint-script-parameters
tests::legacy-relations
tests::legacy-relations
tests::maintscript-includes-maint-script-parameters
tests::source-copyright-source-files-excluded
tests::source-copyright-source-files-excluded
tests::shared-libs-multi-arch-foreign
tests::shared-libs-multi-arch-foreign
tests::legacy-etcfiles
tests::legacy-etcfiles
tests::source-copyright-files-excluded-without-copyright

Bug#823190: lintian: Please error out on orig tarball sigs for source 1.0

[Mattia Rizzolo]

On Tue, Jan 30, 2018 at 12:45:56AM +0530, Chris Lamb wrote:
> tags 823190 + pending
> thanks
> 
> Fixed in Git, pending upload:

Errr, no.

Since 1.18.something dpkg can handle unpacking of 1.18.15, and since
dpkg 1.19.0 it also creates them.  yes it was a issue back then but now
it's correctly handled, and dak accepts them since last week.

>   
> https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=2f1efb44994b066c22a985c09a853fc9583aacf8

Please revert this commit and close this bug as no action needed
anymore.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#823190: marked as done (lintian: Please error out on orig tarball sigs for source 1.0)

[Debian Bug Tracking System]

Your message dated Tue, 30 Jan 2018 01:33:14 +0530
with message-id 
<1517256194.267206.1252269960.49494...@webmail.messagingengine.com>
and subject line Re: Bug#823190: lintian: Please error out on orig tarball sigs 
for source 1.0
has caused the Debian Bug report #823190,
regarding lintian: Please error out on orig tarball sigs for source 1.0
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
823190: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823190
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Version: 2.5.44
Severity: wishlist

Hi!

With dpkg 1.18.5, orig tarball signatures for format 1.0 will be
accepted for extraction and building, which means stable systems will
not be able to extract them. Extraction of orig taball signatures for
format >= 2.0 have been accepted since dpkg 1.17.20, so these are
safe to use.

It would be nice if lintian could error out when finding an orig
tarball signature on source format 1.0 packages.

The pattern for the signature is «.orig.tar.gz.asc».

Thanks,
Guillem
--- End Message ---
--- Begin Message ---
Mattia Rizzolo wrote:

> Errr, no.

:/--- End Message ---

[lintian] 01/05: data/common/dh_addons: Move/create from data/debhelper/dh_addons as we plan to use it elsewhere.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 5a181d6202c0c7f5f5822c011ae233562d37feae
Author: Chris Lamb 
Date:   Mon Jan 29 19:42:47 2018 +

data/common/dh_addons: Move/create from data/debhelper/dh_addons as we plan 
to use it elsewhere.
---
 checks/debhelper.pm  | 2 +-
 data/{debhelper => common}/dh_addons | 0
 data/debhelper/dh_addons-manual  | 2 +-
 debian/changelog | 3 +++
 private/refresh-debhelper-data   | 9 -
 5 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/checks/debhelper.pm b/checks/debhelper.pm
index 6331fff..d5d17bc 100644
--- a/checks/debhelper.pm
+++ b/checks/debhelper.pm
@@ -41,7 +41,7 @@ my $maint_commands = 
Lintian::Data->new('debhelper/maint_commands');
 my $dh_commands_depends = Lintian::Data->new('debhelper/dh_commands', '=');
 my $filename_configs = Lintian::Data->new('debhelper/filename-config-files');
 my $dh_ver_deps= Lintian::Data->new('debhelper/dh_commands-manual', qr/\|\|/o);
-my $dh_addons = Lintian::Data->new('debhelper/dh_addons', '=');
+my $dh_addons = Lintian::Data->new('common/dh_addons', '=');
 my $dh_addons_manual
   = Lintian::Data->new('debhelper/dh_addons-manual', qr/\|\|/o);
 my $compat_level = Lintian::Data->new('debhelper/compat-level',qr/=/);
diff --git a/data/debhelper/dh_addons b/data/common/dh_addons
similarity index 100%
rename from data/debhelper/dh_addons
rename to data/common/dh_addons
diff --git a/data/debhelper/dh_addons-manual b/data/debhelper/dh_addons-manual
index 3e05c3c..8133f14 100644
--- a/data/debhelper/dh_addons-manual
+++ b/data/debhelper/dh_addons-manual
@@ -1,5 +1,5 @@
 # Manually maintained list of dependencies needed for dh addons. This overrides
-# information from data/debhelper/dh_addons (the latter file is automatically
+# information from data/common/dh_addons (the latter file is automatically
 # generated).
 #
 # Please keep this sorted.
diff --git a/debian/changelog b/debian/changelog
index e240d0a..068c5a1 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -48,6 +48,9 @@ lintian (2.5.73) UNRELEASED; urgency=medium
   first paragraph. Thank to Christoph Biedl for the report and idea.
   (Closes: #879235)
 
+  * data/common/dh_addons:
++ [CL] Move/create from data/debhelper/dh_addons as we plan to use
+  it elsewhere.
   * data/files/python-generic-modules:
 + [CL] Detect "backports" (and "backport") as overly generic Python
   module names.  (Closes: #888559)
diff --git a/private/refresh-debhelper-data b/private/refresh-debhelper-data
index 8cc1515..35b0022 100755
--- a/private/refresh-debhelper-data
+++ b/private/refresh-debhelper-data
@@ -134,13 +134,20 @@ else
 cat dh_commands \
 | cut -d '=' -f 2 | sort -u > dh_packages
 
-for f in commands addons packages; do
+for f in commands packages; do
 rf="$lintian_data/debhelper/dh_$f"
 [ ! -f "$rf" ] ||
 mv "$rf" "${rf}.old"
 create_data_file "$rf" < "dh_$f"
 done
 
+for f in addons; do
+rf="$lintian_data/general/dh_$f"
+[ ! -f "$rf" ] ||
+mv "$rf" "${rf}.old"
+create_data_file "$rf" < "dh_$f"
+done
+
 wget dists/sid/main/binary-i386/Packages.gz
 gunzip Packages.gz
 for package in $(cat dh_packages); do

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 02/05: Re-add text removed accidentally in d177589edb.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit c2aadbc0b0f5a7c22073836b555ca6c27fe50e2e
Author: Chris Lamb 
Date:   Mon Jan 29 19:44:09 2018 +

Re-add text removed accidentally in d177589edb.
---
 checks/fields.desc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/checks/fields.desc b/checks/fields.desc
index 24f0f58..b59983f 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -1406,7 +1406,7 @@ Certainty: possible
 Info: Based on the content of the maintainer and uploader fields this
  package is co-maintained but there are no Vcs-* fields.
  .
- It is recommended 
+ It is recommended that shared maintenance of packages are co-ordinated
  via a revision control system.
 
 Tag: multi-arch-same-package-has-arch-specific-overrides

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (3532dd3 -> 7901a91)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  3532dd3   Add Adam to copyright to make the AUTHOR section somewhat 
more consistent.
   new  5a181d6   data/common/dh_addons: Move/create from 
data/debhelper/dh_addons as we plan to use it elsewhere.
   new  c2aadbc   Re-add text removed accidentally in d177589edb.
   new  d88e606   Import MoreUtils as MoreUtils
   new  ed26b6a   Avoid false-positives with 
'binary-package-depends-on-toolchain-package' for various debhelper addons. 
Thanks Niels!
   new  7901a91   Revert "Check for source format 1.0 files that ship 
upstream signatures as this is not supported in stretch. (Closes: #823190)"

The 5 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/changes-file.desc | 10 --
 checks/changes-file.pm   |  5 -
 checks/debhelper.pm  |  2 +-
 checks/fields.desc   |  2 +-
 checks/fields.pm |  6 +-
 data/{debhelper => common}/dh_addons |  0
 data/debhelper/dh_addons-manual  |  2 +-
 debian/changelog |  5 +++--
 private/refresh-debhelper-data   |  9 -
 9 files changed, 19 insertions(+), 22 deletions(-)
 rename data/{debhelper => common}/dh_addons (100%)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 04/05: Avoid false-positives with 'binary-package-depends-on-toolchain-package' for various debhelper addons. Thanks Niels!

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit ed26b6aa85ab65bae2c61081db671ffb89d888ea
Author: Chris Lamb 
Date:   Mon Jan 29 20:01:56 2018 +

Avoid false-positives with 'binary-package-depends-on-toolchain-package' 
for various debhelper addons. Thanks Niels!
---
 checks/fields.pm | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/checks/fields.pm b/checks/fields.pm
index 872a6ec..e6a55ae 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -104,6 +104,9 @@ my $NAME_SECTION_MAPPINGS = Lintian::Data->new(
 return {'regex' =>  qr/$_[0]/x, 'section' => $_[1]};
 });
 
+our $DH_ADDONS = Lintian::Data->new('common/dh_addons', '=');
+our %DH_ADDONS_VALUES = map { $DH_ADDONS->value($_) => 1 } $DH_ADDONS->all;
+
 my %VCS_EXTRACT = (
 browser => sub { return @_;},
 arch=> sub { return @_;},
@@ -896,7 +899,8 @@ sub run {
 
 tag 'binary-package-depends-on-toolchain-package',
   "$field: $part_d_orig"
-  if $KNOWN_TOOLCHAIN->known($d_pkg);
+  if $KNOWN_TOOLCHAIN->known($d_pkg)
+  and not $DH_ADDONS_VALUES{$pkg};
 
 # default-jdk-doc must depend on openjdk-X-doc (or
 # classpath-doc) to be useful; other packages

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 05/05: Revert "Check for source format 1.0 files that ship upstream signatures as this is not supported in stretch. (Closes: #823190)"

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 7901a910df44554f5052bc09a4cb68c08f6d40e8
Author: Chris Lamb 
Date:   Mon Jan 29 20:04:17 2018 +

Revert "Check for source format 1.0 files that ship upstream signatures as 
this is not supported in stretch. (Closes: #823190)"

This reverts commit 2f1efb44994b066c22a985c09a853fc9583aacf8.
---
 checks/changes-file.desc | 10 --
 checks/changes-file.pm   |  5 -
 debian/changelog |  2 --
 3 files changed, 17 deletions(-)

diff --git a/checks/changes-file.desc b/checks/changes-file.desc
index 13b347b..55dacb3 100644
--- a/checks/changes-file.desc
+++ b/checks/changes-file.desc
@@ -206,13 +206,3 @@ Info: The packaging includes an upstream signing key but 
the corresponding
  .
  Support for signatures was added to pristine-tar in version 1.41
  and support in git-buildpackage is being tracked in #872864.
-
-Tag: source-format-1.0-with-upstream-signature
-Severity: normal
-Certainty: certain
-Info: The packaging includes an upstream signature but the package uses
- source format "1.0".
- .
- Whilst these have been supported for extraction and building since dpkg
- 1.18.5, this means they are unsupported in stretch.
-Ref: dpkg-source(1), #823190
diff --git a/checks/changes-file.pm b/checks/changes-file.pm
index cc68fe7..6be546e 100644
--- a/checks/changes-file.pm
+++ b/checks/changes-file.pm
@@ -23,8 +23,6 @@ use strict;
 use warnings;
 use autodie;
 
-use List::MoreUtils qw(any);
-
 use Lintian::Tags qw(tag);
 use Lintian::Check qw(check_maintainer);
 use Lintian::Data;
@@ -188,9 +186,6 @@ sub run {
 last;
 }
 }
-tag 'source-format-1.0-with-upstream-signature'
-  if $src->info->field('format', '1.0') eq '1.0'
-  and any { m/\.asc$/ } %{$info->files};
 }
 
 my $files = $info->files;
diff --git a/debian/changelog b/debian/changelog
index 068c5a1..1573b28 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -15,8 +15,6 @@ lintian (2.5.73) UNRELEASED; urgency=medium
   tag also detect multiple sentences and improve the tag description.
   (Closes: #778427)
   * checks/changes-file.{desc.pm}:
-+ [CL] Check for source format 1.0 files that ship upstream signatures
-  as this is not supported in stretch.  (Closes: #823190)
 + [CL] Fix an issue where the bad-section-in-changes-file,
   file-size-mismatch-in-changes-file and
   checksum-mismatch-in-changes-file tags were not being checked if a

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 03/05: Import MoreUtils as MoreUtils

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit d88e606bf109604253631bf29084ba8249c28704
Author: Chris Lamb 
Date:   Mon Jan 29 19:54:22 2018 +

Import MoreUtils as MoreUtils
---
 checks/changes-file.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/checks/changes-file.pm b/checks/changes-file.pm
index 35a82d4..cc68fe7 100644
--- a/checks/changes-file.pm
+++ b/checks/changes-file.pm
@@ -23,7 +23,7 @@ use strict;
 use warnings;
 use autodie;
 
-use List::Moreutils qw(any);
+use List::MoreUtils qw(any);
 
 use Lintian::Tags qw(tag);
 use Lintian::Check qw(check_maintainer);

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#823190: lintian: Please error out on orig tarball sigs for source 1.0

[Mattia Rizzolo]

On Mon, Jan 29, 2018 at 09:01:48PM +0100, Mattia Rizzolo wrote:
> Since 1.18.something dpkg can handle unpacking of 1.18.15, and since
> dpkg 1.19.0 it also creates them.  yes it was a issue back then but now
> it's correctly handled, and dak accepts them since last week.

More info in this ftp.debian.org's bug: https://bugs.debian.org/888448

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Jenkins build is back to normal : lintian-tests_sid #2501

[jenkins]

See 

Bug#712394: lintian: Warn if override_dh_auto_test target doesn't check for DEB_BUILD_OPTIONS=nocheck

[Mattia Rizzolo]

On Mon, Jan 29, 2018 at 08:24:47PM +0530, Chris Lamb wrote:
> Fixed in Git, pending upload:
> 
>   
> https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=deaf67c91e17072d7963b457c9a7f16c2ee309e4

That commit does the following:
+if (my $line = $overridden{'dh_auto_test'}) {
+tag 'override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES',
+  "(line $line)"
+  if $rules_per_target{'override_dh_auto_test'}
+  and none { m/(DEB_BUILD_OPTIONS|nocheck)/ } @conditionals;
+}

This is going to trigger tons of false positives for packages doing
something like:

override_dh_auto_test:
FOO=bar dh_auto_test
-rm -f file-containing-test-output

which is otherwise file and respects DEB_BUILD_OPTIONS=nocheck.

I think it's very hard to properly detect such cases, but a way to avoid
all those fpos would be to exclude the tags from overrides containing a
call to dh_auto_test: this will lead to some false negatives (for
packages that in their override_dh_auto_test do something that effectly
is not idenpotent and probably causes ftbfs for nocheck, or stuff like
that), but it's probably a lot better than the many fpos I can think of.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#888809: lintian: VCS URLs and salsa.d.o

[Paul Wise]

Package: lintian
Version: 2.5.72
Severity: wishlist

Recent git versions give a warning when redirecting URLs. Salsa redirects git 
to URLs ending in ".git/" and redirects browsers to the
URL not ending in ".git/" or ".git".

Accordingly, the Vcs-Git field should end in ".git" or ".git/" and the
Vcs-Browser field should not end in ".git" or ".git/".

In addition the salsa web interface prints URLs ending in ".git" rather
than URLs ending in ".git/" so the former should be preferred in any
lintian output.

I have no idea how salsa deals with repository names that end in
".git", but I guess git URLs will be something like ".../foo.git.git".

$ git clone https://salsa.debian.org/debian/wiki.debian.org ; rm -rf 
wiki.debian.org
Cloning into 'wiki.debian.org'...
warning: redirecting to https://salsa.debian.org/debian/wiki.debian.org.git/
remote: Counting objects: 1351, done.
remote: Compressing objects: 100% (553/553), done.
remote: Total 1351 (delta 721), reused 1340 (delta 717)
Receiving objects: 100% (1351/1351), 195.20 KiB | 112.00 KiB/s, done.
Resolving deltas: 100% (721/721), done.

$ git clone https://salsa.debian.org/debian/wiki.debian.org.git ; rm -rf 
wiki.debian.org
Cloning into 'wiki.debian.org'...
remote: Counting objects: 1351, done.
remote: Compressing objects: 100% (553/553), done.
remote: Total 1351 (delta 721), reused 1340 (delta 717)
Receiving objects: 100% (1351/1351), 195.20 KiB | 164.00 KiB/s, done.
Resolving deltas: 100% (721/721), done.

$ wget https://salsa.debian.org/debian/wiki.debian.org.git ; rm -f 
wiki.debian.org*
--2018-01-30 14:27:34--  https://salsa.debian.org/debian/wiki.debian.org.git
Resolving salsa.debian.org (salsa.debian.org)... 209.87.16.44, 
2607:f8f0:614:1::1274:44
Connecting to salsa.debian.org (salsa.debian.org)|209.87.16.44|:443... 
connected.
HTTP request sent, awaiting response... 302 Found
Location: https://salsa.debian.org/debian/wiki.debian.org [following]
--2018-01-30 14:27:36--  https://salsa.debian.org/debian/wiki.debian.org
Reusing existing connection to salsa.debian.org:443.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]
Saving to: ‘wiki.debian.org.git’

wiki.debian.org.git[  <=>   
  ]  28.97K 
  103KB/sin 0.3s

2018-01-30 14:27:36 (103 KB/s) - ‘wiki.debian.org.git’ saved [29668]

-- 
bye,
pabs

https://wiki.debian.org/PaulWise


signature.asc
Description: This is a digitally signed message part

[lintian] 04/06: Emit a warning about documentation packages that end with -docs. (Closes: #664520)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 7d61bab2a2d953b238e1befc44417e5b63f505a5
Author: Chris Lamb 
Date:   Tue Jan 30 02:03:23 2018 +

Emit a warning about documentation packages that end with -docs. (Closes: 
#664520)
---
 checks/fields.desc   |  9 +
 checks/fields.pm |  1 +
 debian/changelog |  2 ++
 .../debian/debian/control.in | 16 
 t/tests/fields-unusual-doc-package-name/desc |  6 ++
 t/tests/fields-unusual-doc-package-name/tags |  1 +
 6 files changed, 35 insertions(+)

diff --git a/checks/fields.desc b/checks/fields.desc
index b59983f..5db1cbc 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -1425,3 +1425,12 @@ Info: The package specifies a binary dependecy on a 
"toolchain" package
  .
  If the package intentionally requires such a dependency, please add a
  Lintian override.
+
+Tag: unusual-documentation-package-name
+Severity: wishlist
+Certainty: certain
+Info: The specified package appears to be a documentation package
+ that ends with the string "-docs". It is recommended that such
+ packages use the more usual "-doc" suffix instead.
+ .
+ Please remove the superfluous trailing "s" from the package name.
diff --git a/checks/fields.pm b/checks/fields.pm
index e6a55ae..a042b08 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -254,6 +254,7 @@ sub run {
 unfold('package', \$name);
 tag 'bad-package-name' unless $name =~ /^$PKGNAME_REGEX$/i;
 tag 'package-not-lowercase' if ($name =~ /[A-Z]/);
+tag 'unusual-documentation-package-name' if $name =~ /-docs$/;
 }
 }
 
diff --git a/debian/changelog b/debian/changelog
index 9996324..8bae08d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -31,6 +31,8 @@ lintian (2.5.73) UNRELEASED; urgency=medium
   Ramacher for the report.  (Closes: #787469)
 + [CL] Check for packages that specify binary dependencies on toolchain
   packages such as cdbs or debhelper.  (Closes: #700953)
++ [CL] Emit a warning about documentation packages that end with -docs.
+  (Closes: #664520)
   * checks/java.{desc,pm}:
 + [CL] Check for .jar files that do not match the Debian Java policy.
   (Closes: #791552)
diff --git a/t/tests/fields-unusual-doc-package-name/debian/debian/control.in 
b/t/tests/fields-unusual-doc-package-name/debian/debian/control.in
new file mode 100644
index 000..5ee5357
--- /dev/null
+++ b/t/tests/fields-unusual-doc-package-name/debian/debian/control.in
@@ -0,0 +1,16 @@
+Source: {$source}
+Priority: optional
+Section: doc
+Maintainer: {$author}
+Standards-Version: {$standards_version}
+Build-Depends: {$build_depends}
+Rules-Requires-Root: no
+
+Package: {$source}-docs
+Architecture: all
+Depends: $\{misc:Depends\},
+Description: {$description}
+ This is a test package designed to exercise some feature or tag of
+ Lintian.  It is part of the Lintian test suite and may do very odd
+ things.  It should not be installed like a regular package.  It may
+ be an empty package.
diff --git a/t/tests/fields-unusual-doc-package-name/desc 
b/t/tests/fields-unusual-doc-package-name/desc
new file mode 100644
index 000..b716a5e
--- /dev/null
+++ b/t/tests/fields-unusual-doc-package-name/desc
@@ -0,0 +1,6 @@
+Testname: fields-unusual-doc-package-name
+Version: 1.0
+Type: native
+Description: Check for -docs packages
+Test-For:
+ unusual-documentation-package-name
diff --git a/t/tests/fields-unusual-doc-package-name/tags 
b/t/tests/fields-unusual-doc-package-name/tags
new file mode 100644
index 000..c092cdd
--- /dev/null
+++ b/t/tests/fields-unusual-doc-package-name/tags
@@ -0,0 +1 @@
+I: fields-unusual-doc-package-name-docs: unusual-documentation-package-name

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/06: Ask maintainers to add a comment header to debian/copyright if their package is in contrib or non-free. (Closes: #773562)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 82763046d0a6ae7668cd23af2102b0b79ac73a84
Author: Chris Lamb 
Date:   Mon Jan 29 22:19:02 2018 +

Ask maintainers to add a comment header to debian/copyright if their 
package is in contrib or non-free. (Closes: #773562)
---
 checks/source-copyright.desc   | 11 +++
 checks/source-copyright.pm |  6 +-
 debian/changelog   |  2 ++
 .../desc   |  6 ++
 .../tags   |  0
 .../debian/debian/copyright| 23 ++
 .../desc   |  6 ++
 .../tags   |  1 +
 8 files changed, 54 insertions(+), 1 deletion(-)

diff --git a/checks/source-copyright.desc b/checks/source-copyright.desc
index e90086a..313bb1b 100644
--- a/checks/source-copyright.desc
+++ b/checks/source-copyright.desc
@@ -390,3 +390,14 @@ Info: The specified paragraph in the machine readable 
copyright file references
  As the paragraphs is matched on a "last match wins" principle, all proceeding
  paragraphs are overridden.
 Ref: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+
+Tag: missing-explanation-for-contrib-or-non-free-package
+Severity: wishlist
+Certainty: certain
+Info: The specified package is in the contrib or non-free archive
+ area but does not include a "Comment" (or "Disclaimer") header in
+ its copyright file.
+ .
+ Please add a brief comment why this package cannot be part of the
+ main Debian distribution.
+Ref: policy 12.5
diff --git a/checks/source-copyright.pm b/checks/source-copyright.pm
index 1432e2c..8bbbf5a 100644
--- a/checks/source-copyright.pm
+++ b/checks/source-copyright.pm
@@ -30,7 +30,7 @@ use constant {
 WC_TYPE_DECENDANTS => 'DECENDANTS',
 };
 
-use List::MoreUtils qw(any);
+use List::MoreUtils qw(any none);
 use Text::Levenshtein qw(distance);
 
 use Lintian::Relation::Version qw(versions_compare);
@@ -278,6 +278,10 @@ sub _parse_dep5 {
   "(line $lines[0]{'format'})";
 }
 
+tag 'missing-explanation-for-contrib-or-non-free-package'
+  if $info->source_field('section') =~ m{^(contrib|non-free)(/.+)?$}
+  and none { defined $first_para->{$_} } qw(comment disclaimer);
+
 my (undef, $full_license_header, undef,@short_licenses_header)
   =parse_license($first_para->{'license'}, 1);
 for my $short_license (@short_licenses_header) {
diff --git a/debian/changelog b/debian/changelog
index 1573b28..a3035f2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -45,6 +45,8 @@ lintian (2.5.73) UNRELEASED; urgency=medium
 + [CL] Warn when a "Files: *" DEP-5 paragraph exists but it is not the
   first paragraph. Thank to Christoph Biedl for the report and idea.
   (Closes: #879235)
++ [CL] Ask maintainers to add a comment header to debian/copyright if
+  their package is in contrib or non-free.  (Closes: #773562)
 
   * data/common/dh_addons:
 + [CL] Move/create from data/debhelper/dh_addons as we plan to use
diff --git a/t/tests/source-copyright-missing-non-free-explanation-unrel/desc 
b/t/tests/source-copyright-missing-non-free-explanation-unrel/desc
new file mode 100644
index 000..2e51af5
--- /dev/null
+++ b/t/tests/source-copyright-missing-non-free-explanation-unrel/desc
@@ -0,0 +1,6 @@
+Testname: source-copyright-missing-non-free-explanation-unrel
+Version: 1.0
+Description: Test for missing contrib/non-free explanations
+Section: contrib/doc
+Test-Against:
+ missing-explanation-for-contrib-or-non-free-package
diff --git a/t/tests/source-copyright-missing-non-free-explanation-unrel/tags 
b/t/tests/source-copyright-missing-non-free-explanation-unrel/tags
new file mode 100644
index 000..e69de29
diff --git 
a/t/tests/source-copyright-missing-non-free-explanation/debian/debian/copyright 
b/t/tests/source-copyright-missing-non-free-explanation/debian/debian/copyright
new file mode 100644
index 000..5c38963
--- /dev/null
+++ 
b/t/tests/source-copyright-missing-non-free-explanation/debian/debian/copyright
@@ -0,0 +1,23 @@
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: Lintian
+Upstream-Contact: 
+Source: http://lintian.debian.org
+
+Files: *
+Copyright: 2009, Russ Allbery 
+License: GPL-2+
+ This program is free software; you may redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 2, or (at your option)
+ any later version.
+ .
+ This is distributed in the hope that it will be useful, but without
+ any warranty; without even the implied warranty of merchantability or
+ fitness for a particular purpose. See the GNU General Public License
+ for more details.
+ .
+ A copy of the

[lintian] 03/06: Check for upstream tarballs that ship examples but none is installed in any binary package. (Closes: #539326)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 86ea33e221ee682f40cb3451378d7d34993fcfb7
Author: Chris Lamb 
Date:   Mon Jan 29 23:19:08 2018 +

Check for upstream tarballs that ship examples but none is installed in any 
binary package. (Closes: #539326)
---
 checks/cruft.desc   | 10 ++
 checks/cruft.pm | 21 ++---
 debian/changelog|  4 +++-
 .../debian/debian/examples  |  1 +
 .../debian/examples/testsuite   |  1 +
 .../desc|  7 +++
 .../tags|  0
 .../debian/examples/testsuite   |  1 +
 .../cruft-package-does-not-install-examples/desc|  7 +++
 .../cruft-package-does-not-install-examples/tags|  1 +
 10 files changed, 49 insertions(+), 4 deletions(-)

diff --git a/checks/cruft.desc b/checks/cruft.desc
index 59e7de8..40c6cae 100644
--- a/checks/cruft.desc
+++ b/checks/cruft.desc
@@ -924,3 +924,13 @@ Info: The package appears to use AC_PATH_PROG to 
discover the
  A better way would be to use the PKG_PROG_PKG_CONFIG macro from
  pkg.m4 and then using the $PKG_CONFIG shell variable.
 Ref: #884798
+
+Tag: package-does-not-install-examples
+Severity: pedantic
+Certainty: possible
+Info: The original source tarball contains the specified examples
+ directory. However, no examples are installed in any binary packages.
+ .
+ Please use dh_installexamples to install these to the most
+ relevant package.
+Ref: dh_installexamples(1)
diff --git a/checks/cruft.pm b/checks/cruft.pm
index 0beda52..7eb7116 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -40,6 +40,7 @@ use constant INSANE_LINE_LENGTH => 512;
 use constant SAFE_LINE_LENGTH => 256;
 
 use File::Basename qw(basename);
+use List::MoreUtils qw(any);
 
 use Lintian::Data;
 use Lintian::Relation ();
@@ -335,7 +336,7 @@ our @TRAILING_WHITESPACE_FILES = (
 );
 
 sub run {
-my (undef, undef, $info, $proc) = @_;
+my (undef, undef, $info, $proc, $group) = @_;
 my $source_pkg = $proc->pkg_src;
 my $d_files = $info->index_resolved_path('debian/files');
 
@@ -372,7 +373,7 @@ sub run {
 }elsif (not $info->native) {
 check_diffstat($info->diffstat, \%warned);
 }
-find_cruft($source_pkg, $info, \%warned, $ltinbd);
+find_cruft($source_pkg, $info, \%warned, $ltinbd, $group);
 
 for my $file (@EOL_TERMINATORS_FILES) {
 my $path = $info->index_resolved_path("debian/$file");
@@ -564,7 +565,7 @@ sub istestset {
 # "source-contains" tag.  The tag isn't entirely accurate, but it's better
 # than creating yet a third set of tags, and this gets the severity right.
 sub find_cruft {
-my ($source_pkg, $info, $warned, $ltinbd) = @_;
+my ($source_pkg, $info, $warned, $ltinbd, $group) = @_;
 my $prefix = ($info->native ? 'diff-contains' : 'source-contains');
 my @worklist;
 
@@ -604,6 +605,8 @@ sub find_cruft {
 last;
 }
 }
+tag 'package-does-not-install-examples', $entry
+  if $basename eq 'examples' and not _ships_examples($group);
 }
 
 push(@worklist, $entry->children);
@@ -1550,6 +1553,18 @@ sub _license_check {
 return $ret;
 }
 
+sub _ships_examples {
+my ($group) = @_;
+my @procs = $group->get_processables('binary');
+return if not @procs;
+foreach my $binpkg (@procs) {
+my $name = $binpkg->pkg_name;
+my @files = $binpkg->info->sorted_index;
+return 1 if any { m{^usr/share/doc/$name/examples/$} } @files;
+}
+return;
+}
+
 1;
 
 # Local Variables:
diff --git a/debian/changelog b/debian/changelog
index a3035f2..9996324 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,9 +2,11 @@ lintian (2.5.73) UNRELEASED; urgency=medium
 
   XXX: generate tag summary
 
-  * checks/cruft.pm:
+  * checks/cruft.{desc,pm}:
 + [CL] When looking for the source of "build/foo/bar.min.js", also
   check "src/foo/bar.js".  (Closes: #832027)
++ [CL] Check for upstream tarballs that ship examples but none is
+  installed in any binary package.  (Closes: #539326)
   * checks/debian-source-dir.desc:
 + [CL] Upgrade severity of missing-debian-source-format from wishlist
   ("I") to normal ("W").  (Closes: #702671)
diff --git 
a/t/tests/cruft-package-does-not-install-examples-unrel/debian/debian/examples 
b/t/tests/cruft-package-does-not-install-examples-unrel/debian/debian/examples
new file mode 100644
index 000..e39721e
--- /dev/null
+++ 
b/t/tests/cruft-package-does-not-install-examples-unrel/debian/debian/examples
@@ -0,0 +1 @@
+examples/*
diff --git 
a/t/tests/cruft-package-does-not-install-examples-unrel/debian/examples/testsuite
 
b/t/tests/cruft-

[lintian] 02/06: Rewrite missing-field-in-dep5-copyright to use List::MoreUtils.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 33e013b3330b2f330e406d7b8fd130912686fca2
Author: Chris Lamb 
Date:   Mon Jan 29 22:25:17 2018 +

Rewrite missing-field-in-dep5-copyright to use List::MoreUtils.
---
 checks/source-copyright.pm | 8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/checks/source-copyright.pm b/checks/source-copyright.pm
index 8bbbf5a..bb1f64c 100644
--- a/checks/source-copyright.pm
+++ b/checks/source-copyright.pm
@@ -272,12 +272,10 @@ sub _parse_dep5 {
 }
 }
 check_files_excluded($info, $first_para->{'files-excluded'} // '');
-if (not defined $first_para->{'format'}
-and not defined $first_para->{'format-specification'}){
-tag 'missing-field-in-dep5-copyright', 'format',
-  "(line $lines[0]{'format'})";
-}
 
+tag 'missing-field-in-dep5-copyright', 'format',
+  "(line $lines[0]{'format'})"
+  if none { defined $first_para->{$_} } qw(format format-specification);
 tag 'missing-explanation-for-contrib-or-non-free-package'
   if $info->source_field('section') =~ m{^(contrib|non-free)(/.+)?$}
   and none { defined $first_para->{$_} } qw(comment disclaimer);

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (7901a91 -> c1a33d5)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  7901a91   Revert "Check for source format 1.0 files that ship 
upstream signatures as this is not supported in stretch. (Closes: #823190)"
   new  8276304   Ask maintainers to add a comment header to 
debian/copyright if their package is in contrib or non-free. (Closes: #773562)
   new  33e013b   Rewrite missing-field-in-dep5-copyright to use 
List::MoreUtils.
   new  86ea33e   Check for upstream tarballs that ship examples but none 
is installed in any binary package. (Closes: #539326)
   new  7d61bab   Emit a warning about documentation packages that end with 
-docs. (Closes: #664520)
   new  c941722   Lower severity of 
override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES.
   new  c1a33d5   Try and avoid some false positives in 
override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES thanks to suggestion by 
Mattia. Maybe this will be too noisy after all.

The 6 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/cruft.desc   | 10 ++
 checks/cruft.pm | 21 ++---
 checks/fields.desc  |  9 +
 checks/fields.pm|  1 +
 checks/rules.desc   |  2 +-
 checks/rules.pm |  4 +++-
 checks/source-copyright.desc| 11 +++
 checks/source-copyright.pm  | 14 --
 debian/changelog|  8 +++-
 .../debian/debian/examples  |  1 +
 .../debian/examples/testsuite   |  1 +
 .../desc|  7 +++
 .../tags|  0
 .../debian/examples/testsuite   |  1 +
 .../cruft-package-does-not-install-examples/desc|  7 +++
 .../cruft-package-does-not-install-examples/tags|  1 +
 .../debian/debian/control.in|  4 ++--
 t/tests/fields-unusual-doc-package-name/desc|  6 ++
 t/tests/fields-unusual-doc-package-name/tags|  1 +
 .../tags|  2 +-
 .../desc|  6 ++
 .../tags|  0
 .../debian/debian}/copyright|  3 ---
 .../desc|  6 ++
 .../tags|  1 +
 25 files changed, 109 insertions(+), 18 deletions(-)
 create mode 100644 
t/tests/cruft-package-does-not-install-examples-unrel/debian/debian/examples
 create mode 100644 
t/tests/cruft-package-does-not-install-examples-unrel/debian/examples/testsuite
 create mode 100644 t/tests/cruft-package-does-not-install-examples-unrel/desc
 copy t/{debs/deb-format-record-size => 
tests/cruft-package-does-not-install-examples-unrel}/tags (100%)
 create mode 100644 
t/tests/cruft-package-does-not-install-examples/debian/examples/testsuite
 create mode 100644 t/tests/cruft-package-does-not-install-examples/desc
 create mode 100644 t/tests/cruft-package-does-not-install-examples/tags
 copy t/tests/{files-python-module-has-overly-generic-name => 
fields-unusual-doc-package-name}/debian/debian/control.in (92%)
 create mode 100644 t/tests/fields-unusual-doc-package-name/desc
 create mode 100644 t/tests/fields-unusual-doc-package-name/tags
 create mode 100644 
t/tests/source-copyright-missing-non-free-explanation-unrel/desc
 copy t/{debs/deb-format-record-size => 
tests/source-copyright-missing-non-free-explanation-unrel}/tags (100%)
 copy t/{templates/source/skel => 
tests/source-copyright-missing-non-free-explanation/debian/debian}/copyright 
(88%)
 create mode 100644 t/tests/source-copyright-missing-non-free-explanation/desc
 create mode 100644 t/tests/source-copyright-missing-non-free-explanation/tags

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 05/06: Lower severity of override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit c941722bbc0c87aca813a7b22517e0b9e6df8376
Author: Chris Lamb 
Date:   Tue Jan 30 06:56:36 2018 +

Lower severity of override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES.
---
 checks/rules.desc| 2 +-
 t/tests/rules-dh-auto-test-does-not-check-deb-build-options/tags | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/checks/rules.desc b/checks/rules.desc
index 25fe627..9d28c33 100644
--- a/checks/rules.desc
+++ b/checks/rules.desc
@@ -339,7 +339,7 @@ Info: The debian/rules file for this package has a 
call to
 Ref: #829100, dpkg-deb(1)
 
 Tag: override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
-Severity: normal
+Severity: wishlist
 Certainty: possible
 Info: The debian/rules file for this package has an
  override_dh_auto_test target that does not appear to
diff --git a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/tags 
b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/tags
index 17e0c15..a94f974 100644
--- a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/tags
+++ b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/tags
@@ -1 +1 @@
-W: rules-dh-auto-test-does-not-check-deb-build-options source: 
override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES (line 6)
+I: rules-dh-auto-test-does-not-check-deb-build-options source: 
override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES (line 6)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 06/06: Try and avoid some false positives in override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES thanks to suggestion by Mattia. Maybe this will be too noisy after all.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit c1a33d5f43b5662d55cfdf76573d90125dfb3cef
Author: Chris Lamb 
Date:   Tue Jan 30 06:58:38 2018 +

Try and avoid some false positives in 
override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES thanks to suggestion by 
Mattia. Maybe this will be too noisy after all.
---
 checks/rules.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/checks/rules.pm b/checks/rules.pm
index 3e1b2c3..b31200a 100644
--- a/checks/rules.pm
+++ b/checks/rules.pm
@@ -443,7 +443,9 @@ sub run {
 tag 'override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES',
   "(line $line)"
   if $rules_per_target{'override_dh_auto_test'}
-  and none { m/(DEB_BUILD_OPTIONS|nocheck)/ } @conditionals;
+  and none { m/(DEB_BUILD_OPTIONS|nocheck)/ } @conditionals
+  and none { m/\bdh_auto_test\b/ }
+$rules_per_target{'override_dh_auto_test'};
 }
 
 # Make sure that all the required build dependencies are there.  Don't

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#539326: lintian: Detect upstream examples not shipped by the package

[Chris Lamb]

tags 539326 + pending
thanks

Fixed in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=86ea33e221ee682f40cb3451378d7d34993fcfb7


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#773562: lintian: Detect non-free and contrib packages without a Disclaimer in debian/copyright

[Chris Lamb]

tags 773562 + pending
thanks

Fixed in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=82763046d0a6ae7668cd23af2102b0b79ac73a84


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Processed: Re: lintian: Detect non-free and contrib packages without a Disclaimer in debian/copyright

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 773562 + pending
Bug #773562 [lintian] lintian: Detect non-free and contrib packages without a 
Disclaimer in debian/copyright
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
773562: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=773562
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Processed: Re: lintian: Unusual documentation package name, foo-docs

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 664520 + pending
Bug #664520 [lintian] lintian: Unusual documentation package name, foo-docs
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
664520: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=664520
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#712394: lintian: Warn if override_dh_auto_test target doesn't check for DEB_BUILD_OPTIONS=nocheck

[Chris Lamb]

Hi Mattia,

> This is going to trigger tons of false positives for packages doing
> something like:
> 
> override_dh_auto_test:
> FOO=bar dh_auto_test
> -rm -f file-containing-test-output

Thanks. I've incorporated your idea in:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=c1a33d5f43b5662d55cfdf76573d90125dfb3cef

… and lowered the severity here:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=c1a33d5f43b5662d55cfdf76573d90125dfb3cef

We might just end up reverting the whole thing, naturally, but let's see
how we go for now...


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#664520: lintian: Unusual documentation package name, foo-docs

[Chris Lamb]

tags 664520 + pending
thanks

Fixed in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=7d61bab2a2d953b238e1befc44417e5b63f505a5


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Processed: Re: lintian: Detect upstream examples not shipped by the package

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 539326 + pending
Bug #539326 [lintian] lintian: Detect upstream examples not shipped by the 
package
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
539326: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=539326
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

[lintian] branch master updated (c1a33d5 -> 7ea11f7)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  c1a33d5   Try and avoid some false positives in 
override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES thanks to suggestion by 
Mattia. Maybe this will be too noisy after all.
   new  7ea11f7   Don't emit a warning if we have no 'section'.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/source-copyright.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: Don't emit a warning if we have no 'section'.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 7ea11f79ebbe5f0bd76fd6b71c210551ef16226f
Author: Chris Lamb 
Date:   Tue Jan 30 07:26:31 2018 +

Don't emit a warning if we have no 'section'.
---
 checks/source-copyright.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/checks/source-copyright.pm b/checks/source-copyright.pm
index bb1f64c..1a56b03 100644
--- a/checks/source-copyright.pm
+++ b/checks/source-copyright.pm
@@ -277,7 +277,7 @@ sub _parse_dep5 {
   "(line $lines[0]{'format'})"
   if none { defined $first_para->{$_} } qw(format format-specification);
 tag 'missing-explanation-for-contrib-or-non-free-package'
-  if $info->source_field('section') =~ m{^(contrib|non-free)(/.+)?$}
+  if $info->source_field('section', '') =~ m{^(contrib|non-free)(/.+)?$}
   and none { defined $first_para->{$_} } qw(comment disclaimer);
 
 my (undef, $full_license_header, undef,@short_licenses_header)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Build failed in Jenkins: lintian-tests_sid #2502

[jenkins]

See 


Changes:

[lamby] Ask maintainers to add a comment header to debian/copyright if their

[lamby] Rewrite missing-field-in-dep5-copyright to use List::MoreUtils.

[lamby] Check for upstream tarballs that ship examples but none is installed in

[lamby] Emit a warning about documentation packages that end with -docs.

[lamby] Lower severity of

[lamby] Try and avoid some false positives in

--
[...truncated 245.89 KB...]
Adding debian:COMODO_Certification_Authority.pem
Adding debian:CNNIC_ROOT.pem
Adding debian:CFCA_EV_ROOT.pem
Adding debian:CA_Disig_Root_R2.pem
Adding debian:CA_Disig_Root_R1.pem
Adding debian:Buypass_Class_3_Root_CA.pem
Adding debian:Buypass_Class_2_Root_CA.pem
Adding debian:Baltimore_CyberTrust_Root.pem
Adding debian:Autoridad_de_Certificacion_Firmaprofesional_CIF_A62634068.pem
Adding debian:Atos_TrustedRoot_2011.pem
Adding debian:Amazon_Root_CA_4.pem
Adding debian:Amazon_Root_CA_3.pem
Adding debian:Amazon_Root_CA_2.pem
Adding debian:Amazon_Root_CA_1.pem
Adding debian:AffirmTrust_Premium_ECC.pem
Adding debian:AffirmTrust_Premium.pem
Adding debian:AffirmTrust_Networking.pem
Adding debian:AffirmTrust_Commercial.pem
Adding debian:AddTrust_Qualified_Certificates_Root.pem
Adding debian:AddTrust_Public_Services_Root.pem
Adding debian:AddTrust_Low-Value_Services_Root.pem
Adding debian:AddTrust_External_Root.pem
Adding debian:Actalis_Authentication_Root_CA.pem
Adding debian:AC_RAIZ_FNMT-RCM.pem
Adding debian:ACEDICOM_Root.pem
Adding debian:ACCVRAIZ1.pem
done.
Setting up openjdk-8-jdk-headless:amd64 (8u151-b12-1) ...
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/idlj to 
provide /usr/bin/idlj (idlj) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jdeps to 
provide /usr/bin/jdeps (jdeps) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/wsimport to 
provide /usr/bin/wsimport (wsimport) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/rmic to 
provide /usr/bin/rmic (rmic) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jinfo to 
provide /usr/bin/jinfo (jinfo) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jsadebugd to 
provide /usr/bin/jsadebugd (jsadebugd) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/native2ascii 
to provide /usr/bin/native2ascii (native2ascii) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstat to 
provide /usr/bin/jstat (jstat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javac to 
provide /usr/bin/javac (javac) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javah to 
provide /usr/bin/javah (javah) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstack to 
provide /usr/bin/jstack (jstack) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jrunscript to 
provide /usr/bin/jrunscript (jrunscript) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javadoc to 
provide /usr/bin/javadoc (javadoc) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jhat to 
provide /usr/bin/jhat (jhat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javap to 
provide /usr/bin/javap (javap) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jar to provide 
/usr/bin/jar (jar) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/xjc to provide 
/usr/bin/xjc (xjc) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/schemagen to 
provide /usr/bin/schemagen (schemagen) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jps to provide 
/usr/bin/jps (jps) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/extcheck to 
provide /usr/bin/extcheck (extcheck) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jmap to 
provide /usr/bin/jmap (jmap) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstatd to 
provide /usr/bin/jstatd (jstatd) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jdb to provide 
/usr/bin/jdb (jdb) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/serialver to 
provide /usr/bin/serialver (serialver) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/wsgen to 
provide /usr/bin/wsgen (wsgen) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jcmd to 
provide /usr/bin/jcmd (jcmd) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jarsigner to 
provide /usr/bin/jarsigner (jarsigner) in auto mode
Setting up default-jre-headles