Bug#894870: lintian could ask maintainers to use dh_auto_*

2018-04-04 Thread Helmut Grohne 
Package: lintian
Severity: wishlist
User: helm...@debian.org
Usertags: rebootstrap

Chris asked me to file this vague idea as a bug to keep track of the
discussion. If the discussion winds down, please don't hesitate to close
this as wontfix.

While making packages cross buildable, I noticed another *very* common
fix pattern and I am wondering how to automate it. The pattern is
actually multiple ones:

 * s!\./configure !dh_auto_configure -- !
 * s/cmake /dh_auto_configure -- /
 * s/qmake /dh_auto_configure -- /
 * s/\$(MAKE)/dh_auto_build --/

The reason why this helps is that debhelper has knowledge of cross
compilation in many cases. It passes additional flags for each of these
commands.

Now it's not quite as simple as depicted here. Let me share some
experience and explain corner cases.

 * Some ./configure scripts are very old or not generated by autotools.
   In such cases, dh_auto_configure may be unusable, because it passes
   unrecognized flags.
 * When applying any of these, one must add "debhelper (>= 7)" to
   Build-Depends.
 * When converting ./configure, it is often useful to drop redundant
   flags such as --prefix=/usr --mandir=... --infodir=... and others.
 * Depending on the compat level, dh_auto_configure passes a multiarch
   --libdir which might not work with a package immediately.
 * When doing out-of-tree builds with autotools, one usually uses
   "cd builddir && ../configure ..." and that should be translated to
   --builddirectory. Sometimes though it is "cd src && ./configure ..."
   in which case, it needs to be --sourcedirectory.
 * For cmake, most packages use out of tree builds (with a different
   directory name from debhelper) and thus often requires
   --builddirectory.
 * When substituting $(MAKE), be careful to distinguish dh_auto_build
   and dh_auto_install.
 * Some packages have multiple build systems and need to explicitly
   select one.

You'll find lots of example patches at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=rebootstrap;users=helm...@debian.org
Check only ones with "FTCBFS", "build architecture" is a good title
filter as well.

If we add something like this, I think it cannot be above certainty
possible, because there are so many cases, where this choice has a good
reason. This is certainly not a "copy & paste"-kind of advice, but one
where the packager needs to think about the implications. It's more akin
to "please increase the compatibility level", which can break in
similarly subtle ways.

Additional benefits (or caveats):
 * For some build systems (e.g. cmake) dh_auto_configure automatically
   passes dpkg-buildflags.
 * For the makefile buildsystem, dh_auto_install tries to prevent
   stripping (in higher compat levels) to get useful -dbgsym packages.

In any case, the real lesson learned here is that our tool diversity has
a significant cost. In a sense, a lot of my patches have converted
packages to become more standard debhelper packages. Such uniformity
lets us eliminate whole bug classes with little changes and that's
something I've used a lot as at least Niels knows. I had to replicate a
few of these for cdbs. From this experience, I think that we should more
aggressively try to move away from tool diversity. Other areas (such as
maintainer script removal or R³) also benefit from decreased tool
diversity.

Now it reads more like this mail should have gone to d-devel. Can we
turn this into something useful anyhow?

Helmut

Jenkins build is back to normal : lintian-tests_stretch-backports #324

2018-04-04 Thread jenkins 
See

[lintian] branch master updated (cd31f7c -> f3b1265)

2018-04-04 Thread Paul Wise 
This is an automated email from the git hooks/post-receive script.

pabs pushed a change to branch master
in repository lintian.

  from  cd31f7c   Spelling fixes. (Closes: #894834)
   new  f3b1265   spelling: Add another correction

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 data/spelling/corrections | 1 +
 1 file changed, 1 insertion(+)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: spelling: Add another correction

2018-04-04 Thread Paul Wise 
This is an automated email from the git hooks/post-receive script.

pabs pushed a commit to branch master
in repository lintian.

commit f3b1265323b7b292bad94d21a85e65a15996a7e4
Author: Paul Wise 
Date:   Thu Apr 5 07:13:17 2018 +0800

spelling: Add another correction
---
 data/spelling/corrections | 1 +
 1 file changed, 1 insertion(+)

diff --git a/data/spelling/corrections b/data/spelling/corrections
index ad134ee..1b44e92 100644
--- a/data/spelling/corrections
+++ b/data/spelling/corrections
@@ -1535,6 +1535,7 @@ environent||environment
 eqivalent||equivalent
 equiped||equipped
 equitorial||equatorial
+equivalant||equivalent
 equivelant||equivalent
 equivilant||equivalent
 equvalent||equivalent

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Processed: Re: lintian: [PATCH] Spelling fixes

2018-04-04 Thread Debian Bug Tracking System 
Processing commands for cont...@bugs.debian.org:

> tags 894834 + pending
Bug #894834 [lintian] lintian: [PATCH] Spelling fixes
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
894834: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894834
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#894834: lintian: [PATCH] Spelling fixes

2018-04-04 Thread Chris Lamb 
tags 894834 + pending
thanks

Thanks! Applied in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=cd31f7cb0954cd64175667e4cfdbecf113d7e5d3


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

[lintian] 02/02: Spelling fixes. (Closes: #894834)

2018-04-04 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit cd31f7cb0954cd64175667e4cfdbecf113d7e5d3
Author: Ville Skyttä 
Date:   Wed Apr 4 20:21:59 2018 +0300

Spelling fixes. (Closes: #894834)
---
 checks/fields.desc   | 4 ++--
 checks/patch-systems.pm  | 2 +-
 checks/python.desc   | 2 +-
 checks/source-copyright.desc | 2 +-
 commands/lintian.pm  | 2 +-
 debian/changelog | 4 
 6 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/checks/fields.desc b/checks/fields.desc
index a832039..18f528f 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -1458,7 +1458,7 @@ Info: This package has a relationship with the 
default-mta virtual
  default-mta and mail-transport-agent should only ever be in a set of
  alternatives together, with default-mta listed first.
  .
- Please add a "or" depedency on mail-transport-agent after
+ Please add a "or" dependency on mail-transport-agent after
  default-mta.
 
 Tag: mail-transport-agent-dependency-does-not-specify-default-mta
@@ -1471,7 +1471,7 @@ Info: This package has a relationship with the 
mail-transport-agent
  default-mta and mail-transport-agent should only ever be in a set of
  alternatives together, with default-mta listed first.
  .
- Please add a "or" depedency on default-mta before
+ Please add a "or" dependency on default-mta before
  mail-transport-agent.
 
 Tag: default-mta-dependency-not-listed-first
diff --git a/checks/patch-systems.pm b/checks/patch-systems.pm
index 06e1eae..c98a335 100644
--- a/checks/patch-systems.pm
+++ b/checks/patch-systems.pm
@@ -285,7 +285,7 @@ sub check_patch {
 my $tag_emitter
   = spelling_tag_emitter('spelling-error-in-patch-description',
 $patch_file);
-# Check the first line seperately to avoid duplicates
+# Check the first line separately to avoid duplicates
 foreach my $x (split(/\n/, $description, 2)) {
 check_spelling($x, $group->info->spelling_exceptions,$tag_emitter);
 }
diff --git a/checks/python.desc b/checks/python.desc
index c68b94b..9b5b9ad 100644
--- a/checks/python.desc
+++ b/checks/python.desc
@@ -43,7 +43,7 @@ Info: This source package appears to generate the specified 
Python 2 package
  package and, if not, consider removing it.
  .
  Alternatively, ensure that the corresponding package specifies the
- ${python3:Depends} substvar in its binary depedencies.
+ ${python3:Depends} substvar in its binary dependencies.
 
 Tag: build-depends-on-python-sphinx-only
 Severity: normal
diff --git a/checks/source-copyright.desc b/checks/source-copyright.desc
index fbe3034..e848c89 100644
--- a/checks/source-copyright.desc
+++ b/checks/source-copyright.desc
@@ -53,7 +53,7 @@ Severity: pedantic
 Certainty: certain
 Ref: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
 Info: Format URI of the machine-readable copyright file uses the plain HTTP
- unencrypted transport protocol.  Using HTTPS is prefered since policy 4.0.0.
+ unencrypted transport protocol.  Using HTTPS is preferred since policy 4.0.0.
  .
  Please use
  
https://www.debian.org/doc/packaging-manuals/copyright-format/version/
diff --git a/commands/lintian.pm b/commands/lintian.pm
index abcfed8..45ee25a 100755
--- a/commands/lintian.pm
+++ b/commands/lintian.pm
@@ -194,7 +194,7 @@ EOT-EOT-EOT
 print <<"EOT-EOT-EOT";
 --tag-display-limit X Specify "tag per package" display limit
 --no-tag-display-limitDisable "tag per package" display limit
-  (equivalant to --tag-display-limit=0)
+  (equivalent to --tag-display-limit=0)
 EOT-EOT-EOT
 }
 
diff --git a/debian/changelog b/debian/changelog
index 6370ebe..d67e72d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -42,6 +42,10 @@ lintian (2.5.81) UNRELEASED; urgency=medium
   $LoadBlessed option of YAML::XS if we have version 0.69 or above
   Thanks to Dylan Aïssi for the report.  (Closes: #894747)
 
+  * commands/lintian.pm, checks/{fields,patch-systems,python}, ...:
++ [CL] Apply patch from Ville Skyttä correcting many spelling mistakes
+  in Lintian itself.  Thanks!  (Closes: #894834)
+
   * lib/Lintian/Check.pm:
 + [CL] Avoid false positives in spelling detection by allowing "(s)"
   suffixes instead of universally stripping all parenthesis.  This

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (7b092a1 -> cd31f7c)

2018-04-04 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  7b092a1   checks/testsuite.desc: Point references to salsa.d.o 
(Closes: #894820)
   new  7d13022   Add missing "[CL] " prefix.
   new  cd31f7c   Spelling fixes. (Closes: #894834)

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/fields.desc   | 4 ++--
 checks/patch-systems.pm  | 2 +-
 checks/python.desc   | 2 +-
 checks/source-copyright.desc | 2 +-
 commands/lintian.pm  | 2 +-
 debian/changelog | 8 ++--
 6 files changed, 12 insertions(+), 8 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/02: Add missing "[CL] " prefix.

2018-04-04 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 7d13022f9d34bc8191b8fe289c32ca9dbde057da
Author: Chris Lamb 
Date:   Wed Apr 4 22:47:00 2018 +0100

Add missing "[CL] " prefix.
---
 debian/changelog | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 67c3401..6370ebe 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -37,8 +37,8 @@ lintian (2.5.81) UNRELEASED; urgency=medium
   udev-rule-missing-subsystem tag when SUBSYSTEM GOTO is not the last
   "GOTO" statement.  Thanks!  (Closes: #894356)
   * checks/upstream-metadata.pm:
-+ Re-enable YAML parsing of upstream metadata which was disabled in
-  2.5.51 (via #861958) to close CVE-2017-8829 as we can now use the
++ [CL] Re-enable YAML parsing of upstream metadata which was disabled
+  in 2.5.51 (via #861958) to close CVE-2017-8829 as we can now use the
   $LoadBlessed option of YAML::XS if we have version 0.69 or above
   Thanks to Dylan Aïssi for the report.  (Closes: #894747)
 

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#894820: lintian: Point testsuite references to salsa.d.o

2018-04-04 Thread Chris Lamb 
tags 894820 + pending
thanks

Applied in Git, pending upload. Thanks!

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=7b092a1c931d7c8cbe7859f3ac0a5312850e3ffb


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Processed: Re: lintian: Point testsuite references to salsa.d.o

2018-04-04 Thread Debian Bug Tracking System 
Processing commands for cont...@bugs.debian.org:

> tags 894820 + pending
Bug #894820 [lintian] lintian: Point testsuite references to salsa.d.o
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
894820: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894820
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

[lintian] branch master updated (aa5aab2 -> 7b092a1)

2018-04-04 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  aa5aab2   checks/testsuite.pm: Add missing 'needs-reboot' 
restriction. (Closes: #894817)
   new  7b092a1   checks/testsuite.desc: Point references to salsa.d.o 
(Closes: #894820)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/testsuite.desc | 24 
 debian/changelog  |  4 +++-
 2 files changed, 15 insertions(+), 13 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: checks/testsuite.desc: Point references to salsa.d.o (Closes: #894820)

2018-04-04 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 7b092a1c931d7c8cbe7859f3ac0a5312850e3ffb
Author: Georg Faerber 
Date:   Wed Apr 4 16:26:25 2018 +0200

checks/testsuite.desc: Point references to salsa.d.o (Closes: #894820)
---
 checks/testsuite.desc | 24 
 debian/changelog  |  4 +++-
 2 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/checks/testsuite.desc b/checks/testsuite.desc
index 2266193..1b03368 100644
--- a/checks/testsuite.desc
+++ b/checks/testsuite.desc
@@ -29,7 +29,7 @@ Certainty: certain
 Info: Runtime test names in debian/tests/control are only allowed to
  contain decimal digits, lowercase ASCII letters, plus or minus signs,
  dots or slashes.
-Ref: 
https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: 
https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: inconsistent-testsuite-field
 Severity: wishlist
@@ -37,28 +37,28 @@ Certainty: certain
 Info: The package provides a debian/tests/control file but no
  Testsuite field in the dsc file, or the field exists but not the
  file.
-Ref: 
https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: 
https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: missing-runtime-tests-field
 Severity: normal
 Certainty: certain
 Info: A mandatory field is missing in some paragraph of the
  debian/tests/control file.
-Ref: 
https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: 
https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: exclusive-runtime-tests-field
 Severity: normal
 Certainty: certain
 Info: Exclusive field are specified in some paragraph of the
  debian/tests/control file.
-Ref: 
https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: 
https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: missing-runtime-test-file
 Severity: normal
 Certainty: possible
 Info: A test file listed in the debian/tests/control file does not
  exist in the package source.
-Ref: 
https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: 
https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: runtime-test-file-is-not-a-regular-file
 Severity: wishlist
@@ -66,7 +66,7 @@ Certainty: certain
 Info: A runtime test listed by debian/tests/control is not a regular
  file or a relative symbolic link to a regular file in the source
  package.
-Ref: 
https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: 
https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: syntax-error-in-debian-tests-control
 Severity: normal
@@ -76,7 +76,7 @@ Info: The debian/tests/control file didn't pass Debian 
control file
  .
  This issue may hide other issues as Lintian skips some checks on the
  file in this case.
-Ref: 
https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: 
https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: unknown-runtime-tests-feature
 Severity: pedantic
@@ -84,7 +84,7 @@ Certainty: wild-guess
 Info: A paragraph in debian/tests/control mentions a non-standard
  value for the Features field. Though allowed, this may indicate an
  error, as the value will be ignored.
-Ref: 
https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: 
https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: unknown-runtime-tests-field
 Severity: pedantic
@@ -92,7 +92,7 @@ Certainty: wild-guess
 Info: A paragraph in debian/tests/control mentions a non-standard
  field. Though allowed, this may indicate an error, as the whole
  paragraph will be ignored.
-Ref: 
https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: 
https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: unknown-runtime-tests-restriction
 Severity: pedantic
@@ -100,7 +100,7 @@ Certainty: wild-guess
 Info: A paragraph in debian/tests/control mentions a non-standard
  value for the Restrictions field. Though allowed, this may indicate an
  error, as the whole paragraph will be ignored.
-Ref: 
https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: 
https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: unknown-testsuite
 Severity: normal
@@ -108,7 +108,7 @@ Certainty: certain
 Info: The dsc file sets Testsuite to an unrecognised value. This
  field is most probably copied by

Bug#894834: lintian: [PATCH] Spelling fixes

2018-04-04 Thread Ville Skyttä 
Package: lintian
Severity: minor

Patch with spelling fixes against current git master is attached.
>From 9d696a6a60db01b3c069a46a5c33a31e179a8100 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ville=20Skytt=C3=A4?= 
Date: Wed, 4 Apr 2018 20:21:59 +0300
Subject: [PATCH] Spelling fixes

---
 checks/fields.desc   | 4 ++--
 checks/patch-systems.pm  | 2 +-
 checks/python.desc   | 2 +-
 checks/source-copyright.desc | 2 +-
 commands/lintian.pm  | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/checks/fields.desc b/checks/fields.desc
index a832039c3..18f528f30 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -1458,7 +1458,7 @@ Info: This package has a relationship with the 
default-mta virtual
  default-mta and mail-transport-agent should only ever be in a set of
  alternatives together, with default-mta listed first.
  .
- Please add a "or" depedency on mail-transport-agent after
+ Please add a "or" dependency on mail-transport-agent after
  default-mta.
 
 Tag: mail-transport-agent-dependency-does-not-specify-default-mta
@@ -1471,7 +1471,7 @@ Info: This package has a relationship with the 
mail-transport-agent
  default-mta and mail-transport-agent should only ever be in a set of
  alternatives together, with default-mta listed first.
  .
- Please add a "or" depedency on default-mta before
+ Please add a "or" dependency on default-mta before
  mail-transport-agent.
 
 Tag: default-mta-dependency-not-listed-first
diff --git a/checks/patch-systems.pm b/checks/patch-systems.pm
index 06e1eaead..c98a33510 100644
--- a/checks/patch-systems.pm
+++ b/checks/patch-systems.pm
@@ -285,7 +285,7 @@ sub check_patch {
 my $tag_emitter
   = spelling_tag_emitter('spelling-error-in-patch-description',
 $patch_file);
-# Check the first line seperately to avoid duplicates
+# Check the first line separately to avoid duplicates
 foreach my $x (split(/\n/, $description, 2)) {
 check_spelling($x, $group->info->spelling_exceptions,$tag_emitter);
 }
diff --git a/checks/python.desc b/checks/python.desc
index c68b94bd3..9b5b9ad16 100644
--- a/checks/python.desc
+++ b/checks/python.desc
@@ -43,7 +43,7 @@ Info: This source package appears to generate the specified 
Python 2 package
  package and, if not, consider removing it.
  .
  Alternatively, ensure that the corresponding package specifies the
- ${python3:Depends} substvar in its binary depedencies.
+ ${python3:Depends} substvar in its binary dependencies.
 
 Tag: build-depends-on-python-sphinx-only
 Severity: normal
diff --git a/checks/source-copyright.desc b/checks/source-copyright.desc
index fbe3034dc..e848c893c 100644
--- a/checks/source-copyright.desc
+++ b/checks/source-copyright.desc
@@ -53,7 +53,7 @@ Severity: pedantic
 Certainty: certain
 Ref: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
 Info: Format URI of the machine-readable copyright file uses the plain HTTP
- unencrypted transport protocol.  Using HTTPS is prefered since policy 4.0.0.
+ unencrypted transport protocol.  Using HTTPS is preferred since policy 4.0.0.
  .
  Please use
  
https://www.debian.org/doc/packaging-manuals/copyright-format/version/
diff --git a/commands/lintian.pm b/commands/lintian.pm
index abcfed803..45ee25a18 100755
--- a/commands/lintian.pm
+++ b/commands/lintian.pm
@@ -194,7 +194,7 @@ EOT-EOT-EOT
 print <<"EOT-EOT-EOT";
 --tag-display-limit X Specify "tag per package" display limit
 --no-tag-display-limitDisable "tag per package" display limit
-  (equivalant to --tag-display-limit=0)
+  (equivalent to --tag-display-limit=0)
 EOT-EOT-EOT
 }
 
-- 
2.14.1

Bug#894820: lintian: Point testsuite references to salsa.d.o

2018-04-04 Thread Georg Faerber 
Package: lintian
Version: 2.5.80
Tags: patch

Hi,

The attached patch points the references in checks/testsuite.desc to
salsa.d.o.

Thanks for your work,
cheers,
Georg
From d9e30d4702140a9b1be2d085b18700f059fd5c19 Mon Sep 17 00:00:00 2001
From: Georg Faerber 
Date: Wed, 4 Apr 2018 16:26:25 +0200
Subject: [PATCH] checks/testsuite.desc: Point references to salsa.d.o
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

---
 checks/testsuite.desc | 24 
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/checks/testsuite.desc b/checks/testsuite.desc
index 226619377..1b03368dd 100644
--- a/checks/testsuite.desc
+++ b/checks/testsuite.desc
@@ -29,7 +29,7 @@ Certainty: certain
 Info: Runtime test names in debian/tests/control are only allowed to
  contain decimal digits, lowercase ASCII letters, plus or minus signs,
  dots or slashes.
-Ref: https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: inconsistent-testsuite-field
 Severity: wishlist
@@ -37,28 +37,28 @@ Certainty: certain
 Info: The package provides a debian/tests/control file but no
  Testsuite field in the dsc file, or the field exists but not the
  file.
-Ref: https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: missing-runtime-tests-field
 Severity: normal
 Certainty: certain
 Info: A mandatory field is missing in some paragraph of the
  debian/tests/control file.
-Ref: https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: exclusive-runtime-tests-field
 Severity: normal
 Certainty: certain
 Info: Exclusive field are specified in some paragraph of the
  debian/tests/control file.
-Ref: https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: missing-runtime-test-file
 Severity: normal
 Certainty: possible
 Info: A test file listed in the debian/tests/control file does not
  exist in the package source.
-Ref: https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: runtime-test-file-is-not-a-regular-file
 Severity: wishlist
@@ -66,7 +66,7 @@ Certainty: certain
 Info: A runtime test listed by debian/tests/control is not a regular
  file or a relative symbolic link to a regular file in the source
  package.
-Ref: https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: syntax-error-in-debian-tests-control
 Severity: normal
@@ -76,7 +76,7 @@ Info: The debian/tests/control file didn't pass Debian control file
  .
  This issue may hide other issues as Lintian skips some checks on the
  file in this case.
-Ref: https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: unknown-runtime-tests-feature
 Severity: pedantic
@@ -84,7 +84,7 @@ Certainty: wild-guess
 Info: A paragraph in debian/tests/control mentions a non-standard
  value for the Features field. Though allowed, this may indicate an
  error, as the value will be ignored.
-Ref: https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: unknown-runtime-tests-field
 Severity: pedantic
@@ -92,7 +92,7 @@ Certainty: wild-guess
 Info: A paragraph in debian/tests/control mentions a non-standard
  field. Though allowed, this may indicate an error, as the whole
  paragraph will be ignored.
-Ref: https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: unknown-runtime-tests-restriction
 Severity: pedantic
@@ -100,7 +100,7 @@ Certainty: wild-guess
 Info: A paragraph in debian/tests/control mentions a non-standard
  value for the Restrictions field. Though allowed, this may indicate an
  error, as the whole paragraph will be ignored.
-Ref: https://anonscm.debian.org/git/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
+Ref: https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
 
 Tag: unknown-testsuite
 Severity: normal
@@ -108,7 +108,7 @@ Certainty: certain
 Info: The dsc file sets

Bug#894817: lintian: Missing autopkgtest 'needs-reboot' restriction (false positive)

2018-04-04 Thread Chris Lamb 
tags 894817 + pending
thanks

Thanks Georg - applied in Git, now pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=aa5aab2ff970a6740efd8cdf21f83dc5262374c2


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Processed: Re: lintian: Missing autopkgtest 'needs-reboot' restriction (false positive)

2018-04-04 Thread Debian Bug Tracking System 
Processing commands for cont...@bugs.debian.org:

> tags 894817 + pending
Bug #894817 [lintian] lintian: Missing autopkgtest 'needs-reboot' restriction 
(false positive)
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
894817: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894817
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

[lintian] branch master updated (d200a28 -> aa5aab2)

2018-04-04 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  d200a28   Update the re-enabling on YAML parsing to support all 
versions of libyaml-libyaml-perl. This avoids a backport.
   new  aa5aab2   checks/testsuite.pm: Add missing 'needs-reboot' 
restriction. (Closes: #894817)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/testsuite.pm | 1 +
 debian/changelog| 3 +++
 2 files changed, 4 insertions(+)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: checks/testsuite.pm: Add missing 'needs-reboot' restriction. (Closes: #894817)

2018-04-04 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit aa5aab2ff970a6740efd8cdf21f83dc5262374c2
Author: Georg Faerber 
Date:   Wed Apr 4 15:30:42 2018 +0200

checks/testsuite.pm: Add missing 'needs-reboot' restriction. (Closes: 
#894817)
---
 checks/testsuite.pm | 1 +
 debian/changelog| 3 +++
 2 files changed, 4 insertions(+)

diff --git a/checks/testsuite.pm b/checks/testsuite.pm
index 58321e6..faff939 100644
--- a/checks/testsuite.pm
+++ b/checks/testsuite.pm
@@ -51,6 +51,7 @@ my %KNOWN_RESTRICTIONS = map { $_ => 1 } qw(
   build-needed
   isolation-container
   isolation-machine
+  needs-reboot
   needs-recommends
   needs-root
   rw-build-tree
diff --git a/debian/changelog b/debian/changelog
index 320adaa..2db9d47 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -27,6 +27,9 @@ lintian (2.5.81) UNRELEASED; urgency=medium
 + [CL] Avoid false-positives in Mallard XML files; 
   tags are anchor element and not followed automatically. Thanks to
   Simon McVittie for the report.  (Closes: #894690)
+  * checks/testsuite.pm:
++ [CL] Apply patch from Georg Faerber to add missing "needs-reboot" to
+  the list of known autopkgtest restrictions.  (Closes: #894817)
   * checks/udev.pm:
 + [CL] Apply patch from Thomas Dallmair to avoid false positives in the
   udev-rule-missing-subsystem tag when SUBSYSTEM GOTO is not the last

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#894817: lintian: Missing autopkgtest 'needs-reboot' restriction (false positive)

2018-04-04 Thread Georg Faerber 
Package: lintian
Version: 2.5.80
Tags: patch

Hi,

lintian is currently missing the autopkgtest 'needs-reboot' restriction,
see [1]. This leads to false positives. Patch attached.

Thanks for your work,
cheers,
Georg


[1] 
https://salsa.debian.org/ci-team/autopkgtest/blob/master/doc/README.package-tests.rst#L229
From f60201b03eb1cc6b341cca13895874e3232701eb Mon Sep 17 00:00:00 2001
From: Georg Faerber 
Date: Wed, 4 Apr 2018 15:30:42 +0200
Subject: [PATCH] checks/testsuite.pm: Add missing 'needs-reboot' restriction
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

---
 checks/testsuite.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/checks/testsuite.pm b/checks/testsuite.pm
index 58321e665..faff9391e 100644
--- a/checks/testsuite.pm
+++ b/checks/testsuite.pm
@@ -51,6 +51,7 @@ my %KNOWN_RESTRICTIONS = map { $_ => 1 } qw(
   build-needed
   isolation-container
   isolation-machine
+  needs-reboot
   needs-recommends
   needs-root
   rw-build-tree
-- 
2.17.0



signature.asc
Description: Digital signature

[lintian] branch master updated (d1045e7 -> d200a28)

2018-04-04 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  d1045e7   spelling: Add several corrections
   new  d200a28   Update the re-enabling on YAML parsing to support all 
versions of libyaml-libyaml-perl. This avoids a backport.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/upstream-metadata.pm| 2 ++
 debian/changelog   | 4 ++--
 debian/control | 4 ++--
 t/tests/upstream-metadata-invalid-yml/desc | 1 +
 4 files changed, 7 insertions(+), 4 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: Update the re-enabling on YAML parsing to support all versions of libyaml-libyaml-perl. This avoids a backport.

2018-04-04 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit d200a280aa2f0527883a95d41c4545b36b9d8106
Author: Chris Lamb 
Date:   Wed Apr 4 14:31:24 2018 +0100

Update the re-enabling on YAML parsing to support all versions of 
libyaml-libyaml-perl. This avoids a backport.
---
 checks/upstream-metadata.pm| 2 ++
 debian/changelog   | 4 ++--
 debian/control | 4 ++--
 t/tests/upstream-metadata-invalid-yml/desc | 1 +
 4 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/checks/upstream-metadata.pm b/checks/upstream-metadata.pm
index 4e2da86..5e58ae6 100644
--- a/checks/upstream-metadata.pm
+++ b/checks/upstream-metadata.pm
@@ -39,6 +39,8 @@ sub run {
 }
 
 if ($yamlfile->is_open_ok) {
+# Need 0.69 for $LoadBlessed (#861958)
+return if $YAML::XS::VERSION < 0.69;
 my $yaml;
 eval { $yaml = YAML::XS::LoadFile($yamlfile->fs_path); };
 if (!$yaml) {
diff --git a/debian/changelog b/debian/changelog
index 0135a08..320adaa 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -34,8 +34,8 @@ lintian (2.5.81) UNRELEASED; urgency=medium
   * checks/upstream-metadata.pm:
 + Re-enable YAML parsing of upstream metadata which was disabled in
   2.5.51 (via #861958) to close CVE-2017-8829 as we can now use the
-  $LoadBlessed option of YAML:XS.  Thanks to Dylan Aïssi for the
-  report.  (Closes: #894747)
+  $LoadBlessed option of YAML::XS if we have version 0.69 or above
+  Thanks to Dylan Aïssi for the report.  (Closes: #894747)
 
   * lib/Lintian/Check.pm:
 + [CL] Avoid false positives in spelling detection by allowing "(s)"
diff --git a/debian/control b/debian/control
index 6337ab4..8bdf463 100644
--- a/debian/control
+++ b/debian/control
@@ -55,7 +55,7 @@ Build-Depends: aspell ,
libtext-template-perl ,
libtimedate-perl ,
liburi-perl ,
-   libyaml-libyaml-perl (>= 0.69) ,
+   libyaml-libyaml-perl ,
libxml-simple-perl ,
man-db ,
node-uglify ,
@@ -102,7 +102,7 @@ Depends: binutils,
  libtext-levenshtein-perl,
  libtimedate-perl,
  liburi-perl,
- libyaml-libyaml-perl (>= 0.69),
+ libyaml-libyaml-perl,
  libxml-simple-perl,
  man-db,
  patchutils,
diff --git a/t/tests/upstream-metadata-invalid-yml/desc 
b/t/tests/upstream-metadata-invalid-yml/desc
index fb4d259..fc7a1c7 100644
--- a/t/tests/upstream-metadata-invalid-yml/desc
+++ b/t/tests/upstream-metadata-invalid-yml/desc
@@ -1,4 +1,5 @@
 Testname: upstream-metadata-invalid-yml
 Version: 1.0
 Description: Tests for upstream-metadata being invalid yml
+Test-Depends: libyaml-libyaml-perl (>= 0.69)
 Test-For: upstream-metadata-yaml-invalid

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Build failed in Jenkins: lintian-tests_stretch-backports #323

2018-04-04 Thread jenkins 
See 


Changes:

[lamby] Avoid false-positives in Mallard XML files;  tags are

[lamby] Re-enable YAML parsing of upstream metadata which was disabled in 2.5.51

[lamby] Add a minimum requirement for libyaml-libyaml-perl for $LoadBlessed;

[smcv] gir: Only treat *.gir files in usr/share/gir-1.0 as GIR

[smcv] gir: Allow a Provides on the canonical name for typelib packages

[smcv] gir: -dev can Depend on a typelib that Provides the canonical name

[smcv] t/tests/gir: Add a test-case for bundling multiple related typelibs

[smcv] gir: Replace underscore in typelib name with hyphen in package name

[lamby] Wrap changelog entry.

[lamby] Apply a patch series from Simon McVittie to match the Gobject

[pabs] spelling: Add several corrections

--
[...truncated 147.41 KB...]
 libclass-accessor-perl,
 libclone-perl,
 libdigest-sha-perl,
 libdpkg-perl,
 libemail-valid-perl,
# libfile-basedir-perl is deliberately *not* installed on our archive-wide
# processing host
 libfile-basedir-perl,
 libipc-run-perl,
 liblist-moreutils-perl,
 libparse-debianchangelog-perl,
 libtext-levenshtein-perl,
 libtimedate-perl,
 liburi-perl,
 libyaml-libyaml-perl (>= 0.69),
 libxml-simple-perl,
 man-db,
 patchutils,
 perl,
 t1utils,
 xz-utils,
 ${misc:Depends},
 ${perl:Depends},
Recommends: libperlio-gzip-perl,
Suggests: binutils-multiarch,
  dpkg-dev,
  libhtml-parser-perl,
  libtext-template-perl,
Breaks: funny-manpages (<< 1.3-5.1),
pkg-perl-tools (<< 0.23)
Replaces: funny-manpages (<< 1.3-5.1)
Multi-Arch: foreign
Description: Debian package checker
 Lintian dissects Debian packages and reports bugs and policy
 violations. It contains automated checks for many aspects of Debian
 policy as well as some checks for common errors.
 .
 It uses an archive directory, called laboratory, in which it stores
 information about the packages it examines.  It can keep this
 information between multiple invocations in order to avoid repeating
 expensive data-collection operations. This makes it possible to check the
 complete Debian archive for bugs, in a reasonable time.
 .
 This package is useful for all people who want to check Debian
 packages for compliance with Debian policy. Every Debian maintainer
 should check packages with this tool before uploading them to the
 archive.
 .
 This version of Lintian is calibrated for policy version 4.1.3.
dh_testdir
dh_testroot
dh_prep
dh_testdir
dh_testroot
dh_install
dh_install: Compatibility levels before 9 are deprecated (level 7 in use)
dh_installdocs
dh_installdocs: Compatibility levels before 9 are deprecated (level 7 in use)
dh_installchangelogs
dh_compress
dh_fixperms
dh_installdeb
dh_installdeb: Compatibility levels before 9 are deprecated (level 7 in use)
dh_gencontrol
dh_md5sums
dh_builddeb
dpkg-deb: building package 'lintian-build-deps' in 
'../lintian-build-deps_2.5.81_all.deb'.

The package has been created.
Attention, the package has been created in the current directory,
not in ".." as indicated by the message above!
Selecting previously unselected package lintian-build-deps.
(Reading database ... 28753 files and directories currently installed.)
Preparing to unpack lintian-build-deps_2.5.81_all.deb ...
Unpacking lintian-build-deps (2.5.81) ...
Reading package lists...
Building dependency tree...
Reading state information...
Correcting dependencies...Starting pkgProblemResolver with broken count: 1
Starting 2 pkgProblemResolver with broken count: 1
Investigating (0) lintian-build-deps:amd64 < 2.5.81 @iU mK Nb Ib >
Broken lintian-build-deps:amd64 Depends on libyaml-libyaml-perl:amd64 < 0.63-2 
@ii mK > (>= 0.69)
  Removing lintian-build-deps:amd64 because I can't find 
libyaml-libyaml-perl:amd64
Done
 Done
Starting pkgProblemResolver with broken count: 0
Starting 2 pkgProblemResolver with broken count: 0
Done
The following additional packages will be installed:
  emacs25-bin-common emacs25-common emacs25-nox emacsen-common libasound2
  libasound2-data libdbus-1-3 libgpm2 libjpeg62-turbo liblockfile-bin
  liblockfile1 libtext-template-perl libxml-libxml-perl
  libxml-namespacesupport-perl libxml-sax-base-perl libxml-sax-perl
  libxml-simple-perl lynx lynx-common ucf zip
Suggested packages:
  emacs25-common-non-dfsg ncurses-term libasound2-plugins alsa-utils gpm
Recommended packages:
  emacs25-el dbus libxml-sax-expat-perl
The following packages will be REMOVED:
  lintian-build-deps
The following NEW packages will be installed:
  emacs25-bin-common emacs25-common emacs25-nox emacsen-common libasound2
  libasound2-data libdbus-1-3 libgpm2 libjpeg62-turbo liblockfile-bin
  liblockfile1 libtext-template-perl libxml-libxml-perl
  libxml-namespacesupport-perl

Jenkins build is back to normal : lintian-tests_buster #744

2018-04-04 Thread jenkins 
See

Jenkins build is back to normal : lintian-tests_sid #2759

2018-04-04 Thread jenkins 
See

[lintian] branch master updated (fe02a51 -> d1045e7)

2018-04-04 Thread Paul Wise 
This is an automated email from the git hooks/post-receive script.

pabs pushed a change to branch master
in repository lintian.

  from  fe02a51   Apply a patch series from Simon McVittie to match the 
Gobject Introspection policy. (Closes: #881491)
   new  d1045e7   spelling: Add several corrections

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 data/spelling/corrections | 2 ++
 1 file changed, 2 insertions(+)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: spelling: Add several corrections

2018-04-04 Thread Paul Wise 
This is an automated email from the git hooks/post-receive script.

pabs pushed a commit to branch master
in repository lintian.

commit d1045e7691630c736bea3a942d45311ad794133c
Author: Paul Wise 
Date:   Wed Apr 4 18:11:35 2018 +0800

spelling: Add several corrections
---
 data/spelling/corrections | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/data/spelling/corrections b/data/spelling/corrections
index 0554085..ad134ee 100644
--- a/data/spelling/corrections
+++ b/data/spelling/corrections
@@ -2507,6 +2507,8 @@ messge||message
 messges||messages
 messsage||message
 messsages||messages
+metacharater||metacharacter
+metacharaters||metacharacters
 microprocesspr||microprocessor
 milisecond||millisecond
 miliseconds||milliseconds

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Processed: Re: lintian: update gir checks for gobject-introspection/1.54.1-3 mini-policy

2018-04-04 Thread Debian Bug Tracking System 
Processing commands for cont...@bugs.debian.org:

> tags 881491 + pending
Bug #881491 [lintian] lintian: update gir checks for 
gobject-introspection/1.54.1-3 mini-policy
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
881491: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=881491
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#881491: lintian: update gir checks for gobject-introspection/1.54.1-3 mini-policy

2018-04-04 Thread Chris Lamb 
tags 881491 + pending
thanks

Hey,

Awesome stuff Simon. Applied in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=fe02a5111809c41190372c3fd7519f24c4d57221


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

[lintian] 06/07: Wrap changelog entry.

2018-04-04 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 350d6354b6a0d1ee5fc809228ba9393198c8469c
Author: Chris Lamb 
Date:   Wed Apr 4 09:34:18 2018 +0100

Wrap changelog entry.
---
 debian/changelog | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index c3017c1..c1156db 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -30,8 +30,8 @@ lintian (2.5.81) UNRELEASED; urgency=medium
   * checks/upstream-metadata.pm:
 + Re-enable YAML parsing of upstream metadata which was disabled in
   2.5.51 (via #861958) to close CVE-2017-8829 as we can now use the
-  $LoadBlessed option of YAML:XS. Thanks to Dylan Aïssi for the report.
-  (Closes: #894747)
+  $LoadBlessed option of YAML:XS.  Thanks to Dylan Aïssi for the
+  report.  (Closes: #894747)
 
   * lib/Lintian/Check.pm:
 + [CL] Avoid false positives in spelling detection by allowing "(s)"

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 07/07: Apply a patch series from Simon McVittie to match the Gobject Introspection policy. (Closes: #881491)

2018-04-04 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit fe02a5111809c41190372c3fd7519f24c4d57221
Author: Chris Lamb 
Date:   Wed Apr 4 09:34:09 2018 +0100

Apply a patch series from Simon McVittie to match the Gobject Introspection 
policy. (Closes: #881491)
---
 debian/changelog | 4 
 1 file changed, 4 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index c1156db..0135a08 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -10,6 +10,10 @@ lintian (2.5.81) UNRELEASED; urgency=medium
 + [CL] Add a pedantic warning for upstream tarballs that contain empty
   directories as these can cause problems with git-buildpackage.
   Thanks to Balint Reczey for the idea!  (Closes: #894368)
+  * checks/gir.{desc,pm}:
++ [CL] Apply a patch series from Simon McVittie to match the Gobject
+  Introspection policy and fixing a series of false-positives. Thanks!
+  (Closes: #881491)
   * checks/java.{desc,pm}:
 + [CL] Apply patch from Bas Couwenberg to bump the maximum permissible
   bytecode version number now that openjdk-9 is now the default-jdk.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 02/07: gir: Allow a Provides on the canonical name for typelib packages

2018-04-04 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit e5a28eb3220087a98905f6612247d53e5709f4c7
Author: Simon McVittie 
Date:   Sat Nov 11 14:04:20 2017 +

gir: Allow a Provides on the canonical name for typelib packages

It's OK for closely related typelibs to be grouped together, as was done
for packages like GLib, GTK+ and Tracker, as long as they are expected
to bump introspection ABI version at the same time. The new mini-policy
version in gobject-introspection/1.54.1-3 recommends that they have
a Provides on all the package names that would have been used if they
were separated (for example gir1.2-gtk-3.0 Provides gir1.2-gdk-3.0 and
gir1.2-gdkx11-3.0). If this is done, we can detect it and suppress the
typelib-package-name-does-not-match tag.

Signed-off-by: Simon McVittie 
---
 checks/gir.desc | 15 ++-
 checks/gir.pm   |  3 ++-
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/checks/gir.desc b/checks/gir.desc
index 611b4ac..b154d6a 100644
--- a/checks/gir.desc
+++ b/checks/gir.desc
@@ -48,11 +48,16 @@ Certainty: possible
 Info: GObject-Introspection binary typelibs (Foo-23.typelib)
  should normally be made available in a package named gir1.2-foo-23.
  .
- Please ignore and override this tag if the typelib is deliberately shipped
- in a package whose name does not match the typelib's machine-readable name.
- For example, gir1.2-glib-2.0 is named for the GLib-2.0
- typelib, but also contains the GObject-2.0 and Gio-2.0
- typelibs; this is unconventional, but is allowed.
+ If multiple typelibs are shipped in the same package, then that package
+ should have versioned Provides for the names that would have been
+ used for separate packages. This arrangement should only be used if the
+ included typelibs' versions are expected to remain the same at all times.
+ .
+ For example, gir1.2-gtk-3.0 is named for the Gtk-3.0
+ typelib, but also contains the Gdk-3.0 and GdkX11-3.0
+ typelibs. It should have versioned Provides entries for
+ gir1.2-gdk-3.0 (= ${binary:Version})
+ and gir1.2-gdkx11-3.0 (= ${binary:Version}) to indicate this.
 Ref: /usr/share/doc/gobject-introspection/policy.txt
 
 Tag: typelib-section-not-introspection
diff --git a/checks/gir.pm b/checks/gir.pm
index b64d195..5001ea0 100644
--- a/checks/gir.pm
+++ b/checks/gir.pm
@@ -121,7 +121,8 @@ sub _run_binary {
 foreach my $typelib (@typelibs) {
 my $expected = 'gir1.2-' . lc($typelib->basename);
 $expected =~ s/\.typelib$//;
-if ($pkg ne $expected) {
+if ($pkg ne $expected
+and not $info->relation('provides')->implies($expected)) {
 tag('typelib-package-name-does-not-match', $typelib, $expected);
 }
 }

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 03/07: gir: -dev can Depend on a typelib that Provides the canonical name

2018-04-04 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 619274079617873eb49d4f36b5fb28a8bcfbf1f0
Author: Simon McVittie 
Date:   Sat Nov 11 14:01:03 2017 +

gir: -dev can Depend on a typelib that Provides the canonical name

If gir1.2-foo-1.0 bundles typelibs for both Foo-1.0 and FooBar-1.0
(as seen in gir1.2-glib-2.0 and gir1.2-gtk-3.0), and the -dev package
containing the GIR XML for Foo-1.0 and FooBar-1.0 depends on
gir1.2-foo-1.0, then it is unnecessary to depend on gir1.2-foobar-1.0
as well.

Signed-off-by: Simon McVittie 
---
 checks/gir.desc | 21 +
 checks/gir.pm   | 12 +++-
 2 files changed, 24 insertions(+), 9 deletions(-)

diff --git a/checks/gir.desc b/checks/gir.desc
index b154d6a..2c5980a 100644
--- a/checks/gir.desc
+++ b/checks/gir.desc
@@ -32,14 +32,19 @@ Info: Development packages that contain 
GObject-Introspection XML files
  (for example gir1.2-foo-23 (= ${binary:Version}) when using
  debhelper).
  .
- Please ignore and override this tag if the typelib is shipped in a package
- whose name does not match the typelib's machine-readable name, and the
- development package correctly depends on that package instead. For example,
- gir1.2-glib-2.0 is named for the GLib-2.0 typelib, but
- also contains the GObject-2.0 and Gio-2.0 typelibs, so
- it is correct that libglib2.0-dev depends on
- gir1.2-glib-2.0 but not on gir1.2-gobject-2.0 or
- gir1.2-gio-2.0.
+ If multiple typelibs are shipped in the same package, then that package
+ should have versioned Provides for the names that would have been
+ used for separate packages. In this case, Lintian does not emit this tag
+ when a group of binary packages from the same source is checked together.
+ .
+ For example, libgtk-3-dev contains Gtk-3.0.gir,
+ Gdk-3.0.gir and GdkX11-3.0.gir.
+ gir1.2-gtk-3.0 contains all three corresponding typelibs,
+ so it is sufficient for libgtk-3-dev to depend on
+ gir1.2-gtk-3.0. Giving gir1.2-gtk-3.0 Provides
+ entries for gir1.2-gdk-3.0 (= ${binary:Version})
+ and gir1.2-gdkx11-3.0 (= ${binary:Version}) signals this
+ situation to Lintian.
 Ref: /usr/share/doc/gobject-introspection/policy.txt
 
 Tag: typelib-package-name-does-not-match
diff --git a/checks/gir.pm b/checks/gir.pm
index 5001ea0..90d4ae1 100644
--- a/checks/gir.pm
+++ b/checks/gir.pm
@@ -109,10 +109,20 @@ sub _run_binary {
 }
 }
 
-foreach my $gir (@girs) {
+  GIR: foreach my $gir (@girs) {
 my $expected = 'gir1.2-' . lc($gir->basename);
 $expected =~ s/\.gir$//;
 my $version = $info->field('version');
+
+foreach my $bin ($group->get_binary_processables) {
+next unless $bin->pkg_name =~ m/^gir1\.2-/;
+my $other = $bin->pkg_name.' (= '.$bin->info->field('version').')';
+if ($bin->info->relation('provides')->implies($expected)
+and $info->relation('strong')->implies($other)) {
+next GIR;
+}
+}
+
 if (not $info->relation('strong')->implies("$expected (= $version)")) {
 tag('gir-missing-typelib-dependency', $gir, $expected);
 }

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 04/07: t/tests/gir: Add a test-case for bundling multiple related typelibs

2018-04-04 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 893f6ee5daf65399b7d8e9c302709c49bf43bc4b
Author: Simon McVittie 
Date:   Sat Nov 11 14:11:01 2017 +

t/tests/gir: Add a test-case for bundling multiple related typelibs

Signed-off-by: Simon McVittie 
---
 t/tests/gir/debian/debian/control.in  | 1 +
 t/tests/gir/debian/debian/gir1.2-good-42.install  | 1 +
 t/tests/gir/debian/debian/libgood-42-dev.install  | 1 +
 t/tests/gir/debian/usr/lib/girepository-1.0/GoodExtras-42.typelib | 1 +
 t/tests/gir/debian/usr/share/gir-1.0/GoodExtras-42.gir| 1 +
 t/tests/gir/tags  | 1 +
 6 files changed, 6 insertions(+)

diff --git a/t/tests/gir/debian/debian/control.in 
b/t/tests/gir/debian/debian/control.in
index 5e3b192..4c18167 100644
--- a/t/tests/gir/debian/debian/control.in
+++ b/t/tests/gir/debian/debian/control.in
@@ -20,6 +20,7 @@ Description: {$description}
 Package: gir1.2-good-42
 Section: introspection
 Architecture: any
+Provides: gir1.2-goodextras-42 (= $\{binary:Version\})
 Depends: $\{gir:Depends\}, $\{shlibs:Depends\}, $\{misc:Depends\}, libgood-42-0
 Description: {$description} - GIR
  This is a test package designed to exercise some feature or tag of
diff --git a/t/tests/gir/debian/debian/gir1.2-good-42.install 
b/t/tests/gir/debian/debian/gir1.2-good-42.install
index 5f80ac4..5f1692f 100644
--- a/t/tests/gir/debian/debian/gir1.2-good-42.install
+++ b/t/tests/gir/debian/debian/gir1.2-good-42.install
@@ -1 +1,2 @@
 usr/lib/girepository-1.0/Good-42.typelib
+usr/lib/girepository-1.0/GoodExtras-42.typelib
diff --git a/t/tests/gir/debian/debian/libgood-42-dev.install 
b/t/tests/gir/debian/debian/libgood-42-dev.install
index ae66896..1bc5a2c 100644
--- a/t/tests/gir/debian/debian/libgood-42-dev.install
+++ b/t/tests/gir/debian/debian/libgood-42-dev.install
@@ -1,2 +1,3 @@
 usr/share/gir-1.0/Good-42.gir
+usr/share/gir-1.0/GoodExtras-42.gir
 usr/lib/libgood-42-dev-dummy
diff --git a/t/tests/gir/debian/usr/lib/girepository-1.0/GoodExtras-42.typelib 
b/t/tests/gir/debian/usr/lib/girepository-1.0/GoodExtras-42.typelib
new file mode 100644
index 000..64fba42
--- /dev/null
+++ b/t/tests/gir/debian/usr/lib/girepository-1.0/GoodExtras-42.typelib
@@ -0,0 +1 @@
+not really a typelib
diff --git a/t/tests/gir/debian/usr/share/gir-1.0/GoodExtras-42.gir 
b/t/tests/gir/debian/usr/share/gir-1.0/GoodExtras-42.gir
new file mode 100644
index 000..59e267d
--- /dev/null
+++ b/t/tests/gir/debian/usr/share/gir-1.0/GoodExtras-42.gir
@@ -0,0 +1 @@
+not really GIR
diff --git a/t/tests/gir/tags b/t/tests/gir/tags
index 4350bd6..d358220 100644
--- a/t/tests/gir/tags
+++ b/t/tests/gir/tags
@@ -1,6 +1,7 @@
 E: gir1.2-bad: typelib-in-arch-all-package 
usr/lib/girepository-1.0/Bad-23.typelib
 I: gir1.2-bad: typelib-not-in-multiarch-directory 
usr/lib/girepository-1.0/Bad-23.typelib 
usr/lib/${DEB_HOST_MULTIARCH}/girepository-1.0
 I: gir1.2-good-42: typelib-not-in-multiarch-directory 
usr/lib/girepository-1.0/Good-42.typelib usr/lib/MULTIARCH/girepository-1.0
+I: gir1.2-good-42: typelib-not-in-multiarch-directory 
usr/lib/girepository-1.0/GoodExtras-42.typelib 
usr/lib/MULTIARCH/girepository-1.0
 W: gir source: typelib-missing-gir-depends gir1.2-bad
 W: gir1.2-bad: gir-in-arch-all-package usr/share/gir-1.0/Bad-23.gir
 W: gir1.2-bad: gir-missing-typelib-dependency usr/share/gir-1.0/Bad-23.gir 
gir1.2-bad-23

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (4db80ed -> fe02a51)

2018-04-04 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  4db80ed   Add a minimum requirement for libyaml-libyaml-perl for 
$LoadBlessed; thanks Mattia!
   new  e884be9   gir: Only treat *.gir files in usr/share/gir-1.0 as GIR
   new  e5a28eb   gir: Allow a Provides on the canonical name for typelib 
packages
   new  6192740   gir: -dev can Depend on a typelib that Provides the 
canonical name
   new  893f6ee   t/tests/gir: Add a test-case for bundling multiple 
related typelibs
   new  0d88c6c   gir: Replace underscore in typelib name with hyphen in 
package name
   new  350d635   Wrap changelog entry.
   new  fe02a51   Apply a patch series from Simon McVittie to match the 
Gobject Introspection policy. (Closes: #881491)

The 7 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/gir.desc| 36 ++
 checks/gir.pm  | 22 +++--
 debian/changelog   |  8 +++--
 t/tests/gir/debian/debian/control.in   |  1 +
 t/tests/gir/debian/debian/gir1.2-good-42.install   |  1 +
 t/tests/gir/debian/debian/libgood-42-dev.install   |  1 +
 .../{Bad-23.typelib => GoodExtras-42.typelib}  |  0
 .../gir-1.0/{Bad-23.gir => GoodExtras-42.gir}  |  0
 t/tests/gir/tags   |  1 +
 9 files changed, 52 insertions(+), 18 deletions(-)
 copy t/tests/gir/debian/usr/lib/girepository-1.0/{Bad-23.typelib => 
GoodExtras-42.typelib} (100%)
 copy t/tests/gir/debian/usr/share/gir-1.0/{Bad-23.gir => GoodExtras-42.gir} 
(100%)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git