[lintian] branch master updated (48f066f -> d1d7333)

2018-04-06 Thread Paul Wise 
This is an automated email from the git hooks/post-receive script.

pabs pushed a change to branch master
in repository lintian.

  from  48f066f   spelling: Add several corrections
   new  d1d7333   spelling: Add another correction

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 data/spelling/corrections | 1 +
 1 file changed, 1 insertion(+)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: spelling: Add another correction

2018-04-06 Thread Paul Wise 
This is an automated email from the git hooks/post-receive script.

pabs pushed a commit to branch master
in repository lintian.

commit d1d73339ee91d1dd97900708d48eb64dd70a8f3b
Author: Paul Wise 
Date:   Sat Apr 7 13:22:56 2018 +0800

spelling: Add another correction
---
 data/spelling/corrections | 1 +
 1 file changed, 1 insertion(+)

diff --git a/data/spelling/corrections b/data/spelling/corrections
index 3e02863..2b05505 100644
--- a/data/spelling/corrections
+++ b/data/spelling/corrections
@@ -281,6 +281,7 @@ ang||and
 anlysis||analysis
 anniversery||anniversary
 annoncement||announcement
+annonymous||anonymous
 annouce||announce
 annouced||announced
 annoucement||announcement

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Build failed in Jenkins: lintian-tests_stretch-backports #336

2018-04-06 Thread jenkins 
See 


--
Started by upstream project "lintian-tests_buster" build number 757
originally caused by:
 Started by upstream project "lintian-tests_sid" build number 2773
 originally caused by:
  Started by an SCM change
[EnvInject] - Loading node environment variables.
Building on master in workspace 

Wiping out workspace first.
Cloning the remote Git repository
Cloning repository git://anonscm.debian.org/lintian/lintian.git
 > git init 
 >  # 
 > timeout=10
Fetching upstream changes from git://anonscm.debian.org/lintian/lintian.git
 > git --version # timeout=10
 > git fetch --tags --progress git://anonscm.debian.org/lintian/lintian.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://anonscm.debian.org/lintian/lintian.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://anonscm.debian.org/lintian/lintian.git # 
 > timeout=10
Fetching upstream changes from git://anonscm.debian.org/lintian/lintian.git
 > git fetch --tags --progress git://anonscm.debian.org/lintian/lintian.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
git://anonscm.debian.org/lintian/lintian.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:862)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1129)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1160)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1203)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1727)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress git://anonscm.debian.org/lintian/lintian.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: fatal: unable to connect to anonscm.debian.org:
anonscm.debian.org[0: 5.153.231.21]: errno=Connection refused
anonscm.debian.org[1: 2001:41c8:1000:21::21:21]: errno=Network is unreachable


at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1996)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1715)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:405)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:860)
... 11 more
ERROR: Error fetching remote repo 'origin'

[lintian] branch master updated (786da4c -> 48f066f)

2018-04-06 Thread Paul Wise 
This is an automated email from the git hooks/post-receive script.

pabs pushed a change to branch master
in repository lintian.

  from  786da4c   Add offending interpreter to all X-script-but-no-X-dep 
tags.
   new  48f066f   spelling: Add several corrections

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 data/spelling/corrections | 2 ++
 1 file changed, 2 insertions(+)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: spelling: Add several corrections

2018-04-06 Thread Paul Wise 
This is an automated email from the git hooks/post-receive script.

pabs pushed a commit to branch master
in repository lintian.

commit 48f066fa14245d8bfba9ab4a05f4daf430393940
Author: Paul Wise 
Date:   Sat Apr 7 08:11:36 2018 +0800

spelling: Add several corrections
---
 data/spelling/corrections | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/data/spelling/corrections b/data/spelling/corrections
index 20dbfcd..3e02863 100644
--- a/data/spelling/corrections
+++ b/data/spelling/corrections
@@ -2584,6 +2584,7 @@ mumbers||numbers
 musn't||mustn't
 mutiple||multiple
 mutliple||multiple
+myslef||myself
 nam||name
 nams||names
 navagating||navigating
@@ -4258,6 +4259,7 @@ woudn't||wouldn't
 woud||would
 would'nt||wouldn't
 would't||wouldn't
+wraper||wrapper
 writeing||writing
 writen||written
 writting||writing

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Processed: Re: lintian: please nag about get-orig-source targets that only call uscan

2018-04-06 Thread Debian Bug Tracking System 
Processing commands for cont...@bugs.debian.org:

> tags 895036 + pending
Bug #895036 [lintian] lintian: please nag about get-orig-source targets that 
only call uscan
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
895036: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895036
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#895036: lintian: please nag about get-orig-source targets that only call uscan

2018-04-06 Thread Chris Lamb 
tags 895036 + pending
thanks

Fixed in Git, pending upload :)

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=e686928ffda5e618630a86854926b0cb65a3098f


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

[lintian] 01/01: Add offending interpreter to all X-script-but-no-X-dep tags.

2018-04-06 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 786da4c032cc25f97a0fe95260d5795cfebb1c9b
Author: Chris Lamb 
Date:   Fri Apr 6 19:33:26 2018 +0100

Add offending interpreter to all X-script-but-no-X-dep tags.
---
 t/tests/scripts-missing-dep/tags | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/tests/scripts-missing-dep/tags b/t/tests/scripts-missing-dep/tags
index 30e7081..89c4108 100644
--- a/t/tests/scripts-missing-dep/tags
+++ b/t/tests/scripts-missing-dep/tags
@@ -3,7 +3,7 @@ E: scripts-missing-dep: mawk-script-but-no-mawk-dep 
usr/bin/mawk-script #!/usr/b
 E: scripts-missing-dep: php-script-but-no-php-cli-dep usr/bin/php-script 
#!/usr/bin/php
 E: scripts-missing-dep: python-script-but-no-python-dep usr/bin/python-script 
#!/usr/bin/python
 E: scripts-missing-dep: ruby-script-but-no-ruby-dep usr/bin/ruby-script 
#!/usr/bin/ruby
-E: scripts-missing-dep: tclsh-script-but-no-tclsh-dep usr/bin/tclsh-script
-E: scripts-missing-dep: wish-script-but-no-wish-dep usr/bin/wish-script
+E: scripts-missing-dep: tclsh-script-but-no-tclsh-dep usr/bin/tclsh-script 
#!/usr/bin/tclsh
+E: scripts-missing-dep: wish-script-but-no-wish-dep usr/bin/wish-script 
#!/usr/bin/wish
 W: scripts-missing-dep: maintainer-script-needs-depends-on-adduser postinst
 W: scripts-missing-dep: maintainer-script-needs-depends-on-update-inetd 
postinst

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (e686928 -> 786da4c)

2018-04-06 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  e686928   Warn about packages that have apparently unnecessary 
"get-orig-source" targets such as single-line calls to uscan(1). (Closes: 
#895036)
   new  786da4c   Add offending interpreter to all X-script-but-no-X-dep 
tags.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 t/tests/scripts-missing-dep/tags | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#818609: lintian: python-script-but-no-python-dep false positive

2018-04-06 Thread Chris Lamb 
Hi Neil,

> $ /usr/share/lava-server/debian-dev-build.sh -p lava-server

I tried building as per your instructions but it starting re-cloning
a bunch of stuff within the chroot, after installing fuse, grub, node
etc. etc. …

Could you simply provide this lava-dev .deb somewhere publically? :)

> the upstream helper script builds whatever is in the git working
> tree, without fussing about uncommitted changes like git-bp.

As an aside: I understand that git-buildpackage is not for everyone,
but here is a great example of where common, shared tools would really
have a benefit and would save this round trip to fixing this issue. I
mean, this script seems a *lot* more fuss than just committing first
or passing --git-ignore-new … !)


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#895036: lintian: please nag about get-orig-source targets that only call uscan

2018-04-06 Thread Chris Lamb 
Mattia Rizzolo wrote:

> Nonetheless, I know there are plenty of packages having that target with
> the only goal of calling uscan (see for example all of pkg-mate
> packages).

For example, this is mate-sensors-applet:

  get-orig-source:
  uscan --noconf --force-download --rename --download-current-version 
--destdir=..


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#895036: lintian: please nag about get-orig-source targets that only call uscan

2018-04-06 Thread Mattia Rizzolo 
Package: lintian
Version: 2.5.80
Severity: wishlist

Now with policy 4.1.4, people are encouraged to move from get-orig-source
to uscan + files-excluded.

Nonetheless, I know there are plenty of packages having that target with
the only goal of calling uscan (see for example all of pkg-mate
packages).

I find such target quite odd:
1) people ought to be able to call uscan themselves
2) people should call uscan with whatever options they prefer, I don't
   see why somebody should put some random preferences in d/rules
3) the duplication across packages is obnoxious, with all the effort
   than by debhelper to reduce it


-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#895023: marked as done (lintian: Please add a pedantic warning for get-orig-source targets)

2018-04-06 Thread Debian Bug Tracking System 
Your message dated Fri, 06 Apr 2018 13:49:11 +0100
with message-id 
<1523018951.350343.1328790648.4b8a1...@webmail.messagingengine.com>
and subject line Re: Bug#895023: lintian: Please add a pedantic warning for 
get-orig-source targets
has caused the Debian Bug report #895023,
regarding lintian: Please add a pedantic warning for get-orig-source targets
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
895023: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895023
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Version: 2.5.80
Severity: wishlist

Hi,

Please add a pedantic warning for get-orig-source targets: From
Policy 4.1.4:

  4.9
The ``get-orig-source`` rules target has been removed.  Packages
should use ``debian/watch`` and uscan instead.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
--- End Message ---
--- Begin Message ---
Hi Mattia,

> https://salsa.debian.org/dbnpolicy/policy/commit/91c77649c52d3c88cd9310f8802c61574194c860

Ah!

> > Cool, so at least that bit should have been covered in:
> > 
> >   
> > https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=c20e79a879cfbe1ce0e0d70f7ac6a56e0508e3b9
> 
> yep.

Neat, closing this then. :)  I wasn't 100% sure of this change, hence
filing the bug in the first place (so I would probably avoid potential
intepretation of "Please don't" as bluntness in the future!)


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   ` End Message ---

Bug#895023: lintian: Please add a pedantic warning for get-orig-source targets

2018-04-06 Thread Mattia Rizzolo 
On Fri, Apr 06, 2018 at 12:48:25PM +0100, Chris Lamb wrote:
> Hi Mattia,
> 
> > Whilst the upgrade checklist says "should use d/watch instead"
> 
> So this is just unfortunate/incorrect wording in policy "diff"? 

Pretty much.
Also see:
https://salsa.debian.org/dbnpolicy/policy/commit/e4d185bba13d9e8932f33b5fabcd5ad5a8d5fa07
https://salsa.debian.org/dbnpolicy/policy/commit/91c77649c52d3c88cd9310f8802c61574194c860

> > the actual policy simply removed the 'get-orig-source' paragraph
> 
> Cool, so at least that bit should have been covered in:
> 
>   
> https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=c20e79a879cfbe1ce0e0d70f7ac6a56e0508e3b9

yep.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#895023: lintian: Please add a pedantic warning for get-orig-source targets

2018-04-06 Thread Chris Lamb 
Hi Mattia,

> Whilst the upgrade checklist says "should use d/watch instead"

So this is just unfortunate/incorrect wording in policy "diff"? I
didn't follow the discussion that led to this change, alas.

> the actual policy simply removed the 'get-orig-source' paragraph

Cool, so at least that bit should have been covered in:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=c20e79a879cfbe1ce0e0d70f7ac6a56e0508e3b9


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#818609: lintian: python-script-but-no-python-dep false positive

2018-04-06 Thread Neil Williams 
On Fri, 06 Apr 2018 11:53:25 +0100
Chris Lamb  wrote:

> tags 818609 + moreinfo
> thanks
> 
> Chris Lamb wrote:
> 
> > > $ lintian weboob_1.3-1_all.deb
> > > E: weboob: python-script-but-no-python-dep
> > > usr/share/weboob/imm-o-matic  
> > 
> > I believe you are missing a dependency on Python 3 for this
> > script.   
> […]
> > https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=8385bfa725a324d8591343179e0207d72aec9511
> >   
> 
> Neil, is this the cause of your issue too? My lava-server packages
> here don't seem to have render-template.py (or I'm missing something
> obvious!)

Upstream have since moved on to exclusive Python3 support but lintian
is still getting this wrong. Before the following change, yes, lintian
spots these files:

neil@sylvester:lava-server (master)$ git diff
diff --git a/share/download-test-suites-api.py 
b/share/download-test-suites-api.py
index 96ffe1a8..43b319b2 100755
--- a/share/download-test-suites-api.py
+++ b/share/download-test-suites-api.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # -*- coding: utf-8 -*-
 #
 #  download-test-suites-api.py
diff --git a/share/render-template.py b/share/render-template.py
index 011745cf..ffad2879 100755
--- a/share/render-template.py
+++ b/share/render-template.py
@@ -1,4 +1,4 @@
-#! /usr/bin/python
+#! /usr/bin/python3
 
 """
 This script is particularly intended for those adding new devices to LAVA
diff --git a/share/validate_devices.py b/share/validate_devices.py
index fd53b808..b65cf25e 100755
--- a/share/validate_devices.py
+++ b/share/validate_devices.py
@@ -1,4 +1,4 @@
-#! /usr/bin/python
+#! /usr/bin/python3
 
 """
 This script is to check the combination of the Jinja2 device-type templates

After building with these changes, lintian gets it wrong:

neil@sylvester:lava-server (master)$ lintian -o 
/tmp/tmp.WrhJ2TmpXH/lava-dev_2018.2+7171.458f470e-1_all.deb
W: lava-dev: binary-package-depends-on-toolchain-package depends: debhelper (>= 
9.20160709)
E: lava-dev: python-script-but-no-python-dep 
usr/share/lava-server/download-test-suites-api.py
E: lava-dev: python-script-but-no-python-dep 
usr/share/lava-server/render-template.py
E: lava-dev: python-script-but-no-python-dep 
usr/share/lava-server/validate_devices.py

$ dpkg -I /tmp/tmp.WrhJ2TmpXH/lava-dev_2018.2+7171.458f470e-1_all.deb|grep 
Depends
 Depends: build-essential, ca-certificates, devscripts, dpkg-dev,
 debootstrap (>= 1.0.86), debhelper (>= 9.20160709), fakeroot, git,
 libdistro-info-perl, node-uglify, libjs-excanvas, libjs-jquery-cookie,
 libjs-jquery, libjs-jquery-watermark, libjs-jquery-flot (>= 0.8.2),
 libjs-jquery-ui, python3 | python3-all | python3-dev |
 python3-all-dev, python3-setuptools, python3-dateutil,
 python3-guestfs, python3-nose, python3-netifaces, python3-pexpect (>=
 4.2), pep8 | python3-pep8, python3-sphinx (>= 1.4),
 python3-sphinx-bootstrap-theme, python3-requests, python3-zmq,
 python3-yaml, python3-voluptuous (>= 0.8.8), docbook-xsl, xsltproc

If you have time to reproduce, we have a build script helper. Install
lava-dev (in chroot or wherever), git clone
http://git.linaro.org/lava/lava-server.git , cd lava-server then:

$ /usr/share/lava-server/debian-dev-build.sh -p lava-server

Is it something to do with the scripts being in /usr/share ?
dh_python3 doesn't notice files in /usr/share

$ dpkg-query -W lintian
lintian 2.5.80

I'll be putting the above git diff into review today, so the master
branch will likely have this change soon. However, the upstream helper
script builds whatever is in the git working tree, without fussing
about uncommitted changes like git-bp.

> 
> 
> Best wishes,
> 
> -- 
>   ,''`.
>  : :'  : Chris Lamb
>  `. `'`  la...@debian.org / chris-lamb.co.uk
>`-


-- 


Neil Williams
=
http://www.linux.codehelp.co.uk/



pgpDyd8KB867T.pgp
Description: OpenPGP digital signature

Bug#895023: lintian: Please add a pedantic warning for get-orig-source targets

2018-04-06 Thread Mattia Rizzolo 
On Fri, Apr 06, 2018 at 11:55:38AM +0100, Chris Lamb wrote:
> Please add a pedantic warning for get-orig-source targets: From
> Policy 4.1.4:
> 
>   4.9
> The ``get-orig-source`` rules target has been removed.  Packages
> should use ``debian/watch`` and uscan instead.

Please don't.
Whilst the upgrade checklist says "should use d/watch instead", the
actual policy simply removed the 'get-orig-source' paragraph, therefore
simply that target is not standardized anymore.  And as you probably
guess maintainer can put whatever target they want in their d/rules :)


I would be fine with such pedantic tag if lintian checked for e.g.
get-orig-source targets that only call uscan, those are idiotic for me.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#540294: closed by Niels Thykier <ni...@thykier.net> (Bug#540294: fixed in lintian 2.5.51)

2018-04-06 Thread Chris Lamb 
tags 540294 + moreinfo
thanks

Hi Simon & Emilio,

> The feature request in #540294 has not been implemented, although I'm
> not sure how feasible it really is.

Indeed and well-spotted! Okay, to move this forward I was wondering if
someone could provide some concrete offending headers for this test? I'm
guessing we should also include the " -b branchname" suffix too?


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Processed: Re: Bug#540294: closed by Niels Thykier <ni...@thykier.net> (Bug#540294: fixed in lintian 2.5.51)

2018-04-06 Thread Debian Bug Tracking System 
Processing commands for cont...@bugs.debian.org:

> tags 540294 + moreinfo
Bug #540294 [lintian] [new check] Check if Vcs-* and changelog distribution 
match
Added tag(s) moreinfo.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
540294: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=540294
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#895023: lintian: Please add a pedantic warning for get-orig-source targets

2018-04-06 Thread Chris Lamb 
Package: lintian
Version: 2.5.80
Severity: wishlist

Hi,

Please add a pedantic warning for get-orig-source targets: From
Policy 4.1.4:

  4.9
The ``get-orig-source`` rules target has been removed.  Packages
should use ``debian/watch`` and uscan instead.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#818609: lintian: python-script-but-no-python-dep false positive

2018-04-06 Thread Chris Lamb 
tags 818609 + moreinfo
thanks

Chris Lamb wrote:

> > $ lintian weboob_1.3-1_all.deb
> > E: weboob: python-script-but-no-python-dep usr/share/weboob/imm-o-matic
> 
> I believe you are missing a dependency on Python 3 for this script. 
[…]
> https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=8385bfa725a324d8591343179e0207d72aec9511

Neil, is this the cause of your issue too? My lava-server packages here
don't seem to have render-template.py (or I'm missing something obvious!)


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Processed: Re: Bug#818609: lintian: python-script-but-no-python-dep false positive

2018-04-06 Thread Debian Bug Tracking System 
Processing commands for cont...@bugs.debian.org:

> tags 818609 + moreinfo
Bug #818609 [lintian] lintian: python-script-but-no-python-dep false positive
Ignoring request to alter tags of bug #818609 to the same tags previously set
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
818609: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=818609
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#818609: lintian: python-script-but-no-python-dep false positive

2018-04-06 Thread Chris Lamb 
Hi Marc,

> $ lintian weboob_1.3-1_all.deb
> E: weboob: python-script-but-no-python-dep usr/share/weboob/imm-o-matic

I believe you are missing a dependency on Python 3 for this script. I
would concede this is a little misleading so have updated the output
to include the offending shebang:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=8385bfa725a324d8591343179e0207d72aec9511

I trust this resolves your issue. :)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

[lintian] 01/01: Also include the offending/unknown shebang in the output of missing (unversioned) interpreters.

2018-04-06 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 8385bfa725a324d8591343179e0207d72aec9511
Author: Chris Lamb 
Date:   Fri Apr 6 11:45:20 2018 +0100

Also include the offending/unknown shebang in the output of missing 
(unversioned) interpreters.
---
 checks/scripts.pm   | 2 +-
 debian/changelog| 3 +++
 t/tests/legacy-scripts/tags | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/checks/scripts.pm b/checks/scripts.pm
index 1b5d96d..0d70e2a 100644
--- a/checks/scripts.pm
+++ b/checks/scripts.pm
@@ -502,7 +502,7 @@ sub run {
 $depends =~ s/\$1/$version/g;
 unless ($all_parsed->implies($depends)) {
 if ($base =~ /^(python|ruby)/) {
-tag "$1-script-but-no-$1-dep", $filename;
+tag "$1-script-but-no-$1-dep", $filename,"#!$interpreter";
 } else {
 tag 'missing-dep-for-interpreter', "$base => $depends",
   "($filename)", "#!$interpreter";
diff --git a/debian/changelog b/debian/changelog
index a88cd98..bb2bdda 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -31,6 +31,9 @@ lintian (2.5.81) UNRELEASED; urgency=medium
 + [CL] Stop recommending that packages with repacked tarballs specify a
   get-orig-source target; this was removed in Debian Policy 4.1.4 in
   favour of uscan(1) and debian/watch.
+  * checks/scripts.pm:
++ [CL] Also include the offending/unknown shebang in the output of
+  missing (unversioned) interpreters.
   * checks/source-copyright.desc:
 + [CL] Change the severity from pedantic ("P:") to info ("I:") for the
   missing-explanation-for-repacked-upstream-tarball tag.
diff --git a/t/tests/legacy-scripts/tags b/t/tests/legacy-scripts/tags
index ff6dbc8..3dbd72e 100644
--- a/t/tests/legacy-scripts/tags
+++ b/t/tests/legacy-scripts/tags
@@ -19,7 +19,7 @@ E: scripts: php-script-but-no-php-cli-dep 
usr/share/scripts/php7.0foo #!/usr/bin
 E: scripts: php-script-but-no-php-cli-dep usr/share/scripts/phpenvfoo #!php
 E: scripts: php-script-but-no-php-cli-dep usr/share/scripts/phpfoo 
#!/usr/bin/php
 E: scripts: python-package-missing-depends-on-python
-E: scripts: python-script-but-no-python-dep usr/bin/py2.Xfoo
+E: scripts: python-script-but-no-python-dep usr/bin/py2.Xfoo #!python2.2
 E: scripts: python-script-but-no-python-dep usr/bin/pyfoo #!python
 E: scripts: script-without-interpreter control/prerm
 E: scripts: shell-script-fails-syntax-check usr/bin/sh-broken

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (638bf2d -> 8385bfa)

2018-04-06 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  638bf2d   Change the severity from pedantic ("P:") to info ("I:") 
for the missing-explanation-for-repacked-upstream-tarball tag.
   new  8385bfa   Also include the offending/unknown shebang in the output 
of missing (unversioned) interpreters.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/scripts.pm   | 2 +-
 debian/changelog| 3 +++
 t/tests/legacy-scripts/tags | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (c20e79a -> 638bf2d)

2018-04-06 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  c20e79a   Stop recommending that packages with repacked tarballs 
specify a get-orig-source target; this was removed in Debian Policy 4.1.4 in 
favour of uscan(1) and debian/watch.
   new  638bf2d   Change the severity from pedantic ("P:") to info ("I:") 
for the missing-explanation-for-repacked-upstream-tarball tag.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/source-copyright.desc | 2 +-
 debian/changelog | 3 +++
 t/tests/source-copyright-missing-repack-explanation/tags | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: Change the severity from pedantic ("P:") to info ("I:") for the missing-explanation-for-repacked-upstream-tarball tag.

2018-04-06 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 638bf2d4a9a3256a49eaccb5180a1504fdfef7ef
Author: Chris Lamb 
Date:   Fri Apr 6 10:30:55 2018 +0100

Change the severity from pedantic ("P:") to info ("I:") for the 
missing-explanation-for-repacked-upstream-tarball tag.
---
 checks/source-copyright.desc | 2 +-
 debian/changelog | 3 +++
 t/tests/source-copyright-missing-repack-explanation/tags | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/checks/source-copyright.desc b/checks/source-copyright.desc
index e848c89..0750602 100644
--- a/checks/source-copyright.desc
+++ b/checks/source-copyright.desc
@@ -403,7 +403,7 @@ Info: The specified package is in the contrib or non-free 
archive
 Ref: policy 12.5
 
 Tag: missing-explanation-for-repacked-upstream-tarball
-Severity: pedantic
+Severity: wishlist
 Certainty: possible
 Info: The version of this package contains dfsg, ds,
  or debian which normally indicates that the upstream source
diff --git a/debian/changelog b/debian/changelog
index 2d0b314..a88cd98 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -31,6 +31,9 @@ lintian (2.5.81) UNRELEASED; urgency=medium
 + [CL] Stop recommending that packages with repacked tarballs specify a
   get-orig-source target; this was removed in Debian Policy 4.1.4 in
   favour of uscan(1) and debian/watch.
+  * checks/source-copyright.desc:
++ [CL] Change the severity from pedantic ("P:") to info ("I:") for the
+  missing-explanation-for-repacked-upstream-tarball tag.
   * checks/testsuite.{desc,pm}:
 + [CL] Apply patch from Georg Faerber to add missing "needs-reboot" to
   the list of known autopkgtest restrictions.  (Closes: #894817)
diff --git a/t/tests/source-copyright-missing-repack-explanation/tags 
b/t/tests/source-copyright-missing-repack-explanation/tags
index ba4c3b5..cfb0a40 100644
--- a/t/tests/source-copyright-missing-repack-explanation/tags
+++ b/t/tests/source-copyright-missing-repack-explanation/tags
@@ -1,2 +1,2 @@
+I: source-copyright-missing-repack-explanation source: 
missing-explanation-for-repacked-upstream-tarball
 P: source-copyright-missing-repack-explanation source: 
debian-watch-does-not-check-gpg-signature
-P: source-copyright-missing-repack-explanation source: 
missing-explanation-for-repacked-upstream-tarball

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (be909d3 -> c20e79a)

2018-04-06 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  be909d3   spelling: Add several corrections
   new  4b53945   Add 4.1.4 as a known Standards-Version.
   new  c20e79a   Stop recommending that packages with repacked tarballs 
specify a get-orig-source target; this was removed in Debian Policy 4.1.4 in 
favour of uscan(1) and debian/watch.

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/rules.desc  | 10 --
 checks/rules.pm|  4 
 data/rules/policy-rules|  3 ---
 data/standards-version/release-dates   |  1 +
 debian/changelog   |  7 +++
 debian/control |  4 ++--
 t/runtests |  2 +-
 t/tests/legacy-maintainer-scripts/desc |  1 -
 t/tests/legacy-maintainer-scripts/tags |  1 -
 t/tests/legacy-scripts/desc|  1 -
 t/tests/legacy-scripts/tags|  1 -
 t/tests/rules-missing-targets/desc |  1 -
 t/tests/rules-missing-targets/tags |  1 -
 13 files changed, 11 insertions(+), 26 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/02: Add 4.1.4 as a known Standards-Version.

2018-04-06 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 4b5394587719e750849a5c64f9150a37fb41d440
Author: Chris Lamb 
Date:   Thu Apr 5 18:36:14 2018 +0100

Add 4.1.4 as a known Standards-Version.
---
 data/standards-version/release-dates | 1 +
 debian/changelog | 3 +++
 debian/control   | 4 ++--
 t/runtests   | 2 +-
 4 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/data/standards-version/release-dates 
b/data/standards-version/release-dates
index 500ddd2..15fb3aa 100644
--- a/data/standards-version/release-dates
+++ b/data/standards-version/release-dates
@@ -7,6 +7,7 @@
 #
 # date '+%s' -d ''
 
+4.1.4  1522944496
 4.1.3  1514413860
 4.1.2  1512080585
 4.1.1  1506553200
diff --git a/debian/changelog b/debian/changelog
index d67e72d..9f2909f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -46,6 +46,9 @@ lintian (2.5.81) UNRELEASED; urgency=medium
 + [CL] Apply patch from Ville Skyttä correcting many spelling mistakes
   in Lintian itself.  Thanks!  (Closes: #894834)
 
+  * data/standards-version/release-dates:
++ [CL] Add 4.1.4 as a known Standards-Version.
+
   * lib/Lintian/Check.pm:
 + [CL] Avoid false positives in spelling detection by allowing "(s)"
   suffixes instead of universally stripping all parenthesis.  This
diff --git a/debian/control b/debian/control
index 8bdf463..456016f 100644
--- a/debian/control
+++ b/debian/control
@@ -71,7 +71,7 @@ Build-Depends: aspell ,
unzip ,
xz-utils ,
zip ,
-Standards-Version: 4.1.3
+Standards-Version: 4.1.4
 Rules-Requires-Root: no
 Vcs-Git: https://anonscm.debian.org/git/lintian/lintian.git
 Vcs-Browser: https://anonscm.debian.org/git/lintian/lintian.git
@@ -136,4 +136,4 @@ Description: Debian package checker
  should check packages with this tool before uploading them to the
  archive.
  .
- This version of Lintian is calibrated for policy version 4.1.3.
+ This version of Lintian is calibrated for policy version 4.1.4.
diff --git a/t/runtests b/t/runtests
index 7ac1d93..b2cc8b3 100755
--- a/t/runtests
+++ b/t/runtests
@@ -108,7 +108,7 @@ our @DPKG_BUILDPACKAGE_CMD = (
 qw(-iNEVER_MATCH_ANYTHING -INEVER_MATCH_ANYTHING),
 qw(--source-option=--auto-commit),
 );
-our $STANDARDS_VERSION = '4.1.3';
+our $STANDARDS_VERSION = '4.1.4';
 our $ARCHITECTURE = safe_qx(qw(dpkg-architecture -qDEB_HOST_ARCH));
 my $RUNNER_TS = (stat($0))[9];
 chomp $ARCHITECTURE;

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 02/02: Stop recommending that packages with repacked tarballs specify a get-orig-source target; this was removed in Debian Policy 4.1.4 in favour of uscan(1) and debian/watch.

2018-04-06 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit c20e79a879cfbe1ce0e0d70f7ac6a56e0508e3b9
Author: Chris Lamb 
Date:   Fri Apr 6 10:00:06 2018 +0100

Stop recommending that packages with repacked tarballs specify a 
get-orig-source target; this was removed in Debian Policy 4.1.4 in favour of 
uscan(1) and debian/watch.
---
 checks/rules.desc  | 10 --
 checks/rules.pm|  4 
 data/rules/policy-rules|  3 ---
 debian/changelog   |  4 
 t/tests/legacy-maintainer-scripts/desc |  1 -
 t/tests/legacy-maintainer-scripts/tags |  1 -
 t/tests/legacy-scripts/desc|  1 -
 t/tests/legacy-scripts/tags|  1 -
 t/tests/rules-missing-targets/desc |  1 -
 t/tests/rules-missing-targets/tags |  1 -
 10 files changed, 4 insertions(+), 23 deletions(-)

diff --git a/checks/rules.desc b/checks/rules.desc
index 747c613..f12f6e6 100644
--- a/checks/rules.desc
+++ b/checks/rules.desc
@@ -60,16 +60,6 @@ Info: The debian/rules file for this package does 
not provide
  These targets will be required by policy in the future, so should be
  added to prevent future breakage.
 
-Tag: debian-rules-missing-good-practice-target-dfsg
-Severity: wishlist
-Certainty: certain
-Ref: policy 4.9, devref 6.7.8.2
-Info: The debian/rules file for this package does not provide
- one of the good practice targets.
- .
- If your packaged is repacked from non-dfsg source, you should add a
- get-orig-source target.
-
 Tag: debian-rules-uses-deprecated-makefile
 Severity: normal
 Certainty: certain
diff --git a/checks/rules.pm b/checks/rules.pm
index 20ae09f..9403e4a 100644
--- a/checks/rules.pm
+++ b/checks/rules.pm
@@ -409,10 +409,6 @@ sub run {
 tag 'debian-rules-missing-required-target', $target;
 } elsif ($typerule eq 'recommended_allindep') {
 tag 'debian-rules-missing-recommended-target', $target;
-} elsif ($typerule eq 'goodpractice_dfsg') {
-tag 'debian-rules-missing-good-practice-target-dfsg',
-  $target
-  if $info->repacked;
 } else {
 $typerule ||= '';
 croak(
diff --git a/data/rules/policy-rules b/data/rules/policy-rules
index a86de92..f698949 100644
--- a/data/rules/policy-rules
+++ b/data/rules/policy-rules
@@ -5,8 +5,6 @@
 # - "required"  => For required rules (prior to 3.9.4)
 # - recommended_allindep => For the new required targets in 3.9.4
 #(these used to just be recommended)
-# - goodpractice_dfsg => Target recommended for repacked packages
-#(e.g. packages with non-free files removed)
 build required
 binaryrequired
 binary-arch   required
@@ -14,4 +12,3 @@ binary-indep  required
 clean required
 build-archrecommended_allindep
 build-indep   recommended_allindep
-get-orig-source   goodpractice_dfsg
diff --git a/debian/changelog b/debian/changelog
index 9f2909f..2d0b314 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -27,6 +27,10 @@ lintian (2.5.81) UNRELEASED; urgency=medium
 + [CL] Avoid false-positives in Mallard XML files; 
   tags are anchor element and not followed automatically. Thanks to
   Simon McVittie for the report.  (Closes: #894690)
+  * checks/rules.{desc,pm}:
++ [CL] Stop recommending that packages with repacked tarballs specify a
+  get-orig-source target; this was removed in Debian Policy 4.1.4 in
+  favour of uscan(1) and debian/watch.
   * checks/testsuite.{desc,pm}:
 + [CL] Apply patch from Georg Faerber to add missing "needs-reboot" to
   the list of known autopkgtest restrictions.  (Closes: #894817)
diff --git a/t/tests/legacy-maintainer-scripts/desc 
b/t/tests/legacy-maintainer-scripts/desc
index 6cb932c..9b9706e 100644
--- a/t/tests/legacy-maintainer-scripts/desc
+++ b/t/tests/legacy-maintainer-scripts/desc
@@ -10,7 +10,6 @@ Test-For:
  config-does-not-load-confmodule
  debhelper-but-no-misc-depends
  debian-changelog-file-contains-invalid-email-address
- debian-rules-missing-good-practice-target-dfsg
  debian-watch-file-in-native-package
  debian-watch-file-should-mangle-version
  debian-watch-file-unknown-version
diff --git a/t/tests/legacy-maintainer-scripts/tags 
b/t/tests/legacy-maintainer-scripts/tags
index 6dc884f..fa9f06a 100644
--- a/t/tests/legacy-maintainer-scripts/tags
+++ b/t/tests/legacy-maintainer-scripts/tags
@@ -36,7 +36,6 @@ E: maintainer-scripts: read-in-maintainer-script prerm:64
 E: maintainer-scripts: read-in-maintainer-script prerm:65
 E: maintainer-scripts: read-in-maintainer-script prerm:66
 E: maintainer-scripts: wrong-debian-qa-group-name QA group 

-I: maintainer-scripts source: debian-rules-missing-good-practice-target-dfsg 
get-orig-source