Bug#818609: lintian: python-script-but-no-python-dep false positive

2018-04-09 Thread Neil Williams 
On Fri, 06 Apr 2018 19:41:08 +0100
Chris Lamb  wrote:

> Hi Neil,
> 
> > $ /usr/share/lava-server/debian-dev-build.sh -p lava-server  
> 
> I tried building as per your instructions but it starting re-cloning
> a bunch of stuff within the chroot, after installing fuse, grub, node
> etc. etc. …

It's simply cloning the debian/ directory out of the git packaging
repo. This is an upstream script for upstream developers.

> 
> Could you simply provide this lava-dev .deb somewhere publically? :)

https://staging.validation.linaro.org/static/docs/v2/installing_on_debian.html#lava-repositories

http://images.validation.linaro.org/staging-repo/pool/main/l/lava-server/

> > the upstream helper script builds whatever is in the git working
> > tree, without fussing about uncommitted changes like git-bp.  
> 
> As an aside: I understand that git-buildpackage is not for everyone,
> but here is a great example of where common, shared tools would really
> have a benefit and would save this round trip to fixing this issue. I
> mean, this script seems a *lot* more fuss than just committing first
> or passing --git-ignore-new … !)

This isn't about git-ignore anything, this is about building upstream
packages with (sometimes) untested and uncommitted upstream changes to
be able to do the testing prior to and during code review. Making
debian/patches for that is a complete nonsense. This script is for
upstream work with static Debian packaging. Same process is then used
to build the nightly builds which are used for functional testing well
before any release. Debian tooling is completely useless for all of
that upstream work, indeed dpkg is actively obstructive - hence the
need for the lava-dev scripts.

-- 


Neil Williams
=
http://www.linux.codehelp.co.uk/



pgpJ_qmcBDWPe.pgp
Description: OpenPGP digital signature

Bug#890873: lintian: gcc-8-cross-ports makes lintian fork-bomb, consume all memory and fill the disk

2018-04-09 Thread Chris Lamb 
Hi Niels,

> I had a look in the logs and it is not clear to me that the blacklist is
> working

  --- /srv/lindsay.debian.org/config.yaml 2018-04-09 09:57:18.859643045 +
  +++ /srv/lindsay.debian.org/config.yaml 2018-04-09 09:57:58.336325579 +
  @@ -68,4 +68,4 @@
 LINTIAN_SOURCE: https://anonscm.debian.org/git/lintian/lintian.git
   
   blacklist:
  -  - gcc-8-cross-ports (#890873)
  +  - gcc-8-cross-ports # (#890873)
  

 "I believe that has some significance for our problem."

— Richard Feynman


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Processed: Re: lintian: Check for bad-distribution in debian/changelog too

2018-04-09 Thread Debian Bug Tracking System 
Processing commands for cont...@bugs.debian.org:

> tags 873520 + moreinfo
Bug #873520 [src:lintian] lintian: Check for bad-distribution in 
debian/changelog too
Bug #878838 [src:lintian] Please add foolproof warning distribution=UNRELEASED
Added tag(s) moreinfo.
Added tag(s) moreinfo.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
873520: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=873520
878838: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878838
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#895284: lintian: dh --with python3 needs dh-python, not satisfied by python3:any|python3-all:any as suggested

2018-04-09 Thread Julian Andres Klode 
Package: lintian
Severity: normal

lintian tells you that --with python3 needs 

   python3:any | python3-dev:any | python3-all:any | python3-all-dev:any

which is true, but it also needs a dependency on dh-python,
unless the -dev packages are used.

-- 
debian developer - deb.li/jak | jak-linux.org - free software dev
ubuntu core developer  i speak de, en

[lintian] 03/04: lib/Lintian/Collect/Package.pm: Also allow for links, etc. in permission field.

2018-04-09 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 00a4b17ed3519541b2c35e8ccd360e2665a65100
Author: Chris Lamb 
Date:   Mon Apr 9 08:50:44 2018 +0100

lib/Lintian/Collect/Package.pm: Also allow for links, etc. in permission 
field.
---
 lib/Lintian/Collect/Package.pm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/Lintian/Collect/Package.pm b/lib/Lintian/Collect/Package.pm
index 713a93b..48838d9 100644
--- a/lib/Lintian/Collect/Package.pm
+++ b/lib/Lintian/Collect/Package.pm
@@ -444,8 +444,7 @@ sub _fetch_index_data {
 # Note this cannot ever be 100% reliable as the filename might contain
 # "fake" dates.
 ($perm,$ownership,$size,$date,$time,$name)
-  = $line
-  =~ /^([-drwx]{10}) (.*?) (\d+) ([-\d]{10}) ([:\d]{5,8}) (.*)$/;
+  = $line=~ /^(.{10}) (.*?) (\d+) ([-\d]{10}) ([:\d]{5,8}) (.*)$/;
 $ownership =~ s/\s+$//;
 
 $file{'date_time'} = "${date} ${time}";

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/04: lib/Lintian/Collect/Package.pm: Allow optional seconds field in line parsing regex too.

2018-04-09 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 29e952076d0f4cfe60e90b5bb01f612faf3a66ae
Author: Chris Lamb 
Date:   Mon Apr 9 08:46:31 2018 +0100

lib/Lintian/Collect/Package.pm: Allow optional seconds field in line 
parsing regex too.
---
 lib/Lintian/Collect/Package.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Lintian/Collect/Package.pm b/lib/Lintian/Collect/Package.pm
index cb31a22..2f9c46c 100644
--- a/lib/Lintian/Collect/Package.pm
+++ b/lib/Lintian/Collect/Package.pm
@@ -445,7 +445,7 @@ sub _fetch_index_data {
 # "fake" dates.
 ($perm,$ownership,$size,$date,$time,$name)
   = $line
-  =~ /^([-drwx]{10}) (.*?) (\d+) (\d{4}-\d\d-\d\d) (\d\d:\d\d) (.*)$/;
+  =~ /^([-drwx]{10}) (.*?) (\d+) (\d{4}-\d\d-\d\d) ([:\d]{5,8}) (.*)$/;
 $ownership =~ s/\s+$//;
 
 $file{'date_time'} = "${date} ${time}";

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 02/04: lib/Lintian/Collect/Package.pm: Simplify date portion parsing.

2018-04-09 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit a455026d0f71ceb433023fca85e8ea0cdc27ab3c
Author: Chris Lamb 
Date:   Mon Apr 9 08:50:09 2018 +0100

lib/Lintian/Collect/Package.pm: Simplify date portion parsing.
---
 lib/Lintian/Collect/Package.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Lintian/Collect/Package.pm b/lib/Lintian/Collect/Package.pm
index 2f9c46c..713a93b 100644
--- a/lib/Lintian/Collect/Package.pm
+++ b/lib/Lintian/Collect/Package.pm
@@ -445,7 +445,7 @@ sub _fetch_index_data {
 # "fake" dates.
 ($perm,$ownership,$size,$date,$time,$name)
   = $line
-  =~ /^([-drwx]{10}) (.*?) (\d+) (\d{4}-\d\d-\d\d) ([:\d]{5,8}) (.*)$/;
+  =~ /^([-drwx]{10}) (.*?) (\d+) ([-\d]{10}) ([:\d]{5,8}) (.*)$/;
 $ownership =~ s/\s+$//;
 
 $file{'date_time'} = "${date} ${time}";

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 04/04: Add a special case for the python3 addon as it needs a dependency on dh-python unless the -dev packages are used. (Closes: #895284)

2018-04-09 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit b02a1df6380a35510e00cbf1b10dac6c9966f4be
Author: Chris Lamb 
Date:   Mon Apr 9 17:31:21 2018 +0100

Add a special case for the python3 addon as it needs a dependency on 
dh-python unless the -dev packages are used. (Closes: #895284)
---
 checks/debhelper.pm  | 10 ++
 debian/changelog |  4 
 .../debian/debian/control.in | 16 
 .../debhelper-dh-with-python3-unrel/debian/debian/rules  |  4 
 t/tests/debhelper-dh-with-python3-unrel/desc |  5 +
 t/tests/debhelper-dh-with-python3-unrel/tags |  0
 .../debian/debian/control.in | 16 
 .../debhelper-dh-with-python3-unrel2/debian/debian/rules |  4 
 t/tests/debhelper-dh-with-python3-unrel2/desc|  6 ++
 t/tests/debhelper-dh-with-python3-unrel2/tags|  0
 .../debhelper-dh-with-python3/debian/debian/control.in   | 16 
 t/tests/debhelper-dh-with-python3/debian/debian/rules|  4 
 t/tests/debhelper-dh-with-python3/desc   |  5 +
 t/tests/debhelper-dh-with-python3/tags   |  1 +
 14 files changed, 91 insertions(+)

diff --git a/checks/debhelper.pm b/checks/debhelper.pm
index 3c65281..d5f731d 100644
--- a/checks/debhelper.pm
+++ b/checks/debhelper.pm
@@ -465,6 +465,16 @@ sub run {
 while (my ($dep, $addon) = each %missingbdeps_addons) {
 tag 'missing-build-dependency-for-dh-addon', "$addon => $dep"
   unless ($bdepends_noarch->implies($dep));
+
+# As a special case, the python3 addon needs a dependency on
+# dh-python unless the -dev packages are used.
+my $pkg = 'dh-python';
+tag 'missing-build-dependency-for-dh-addon',"$addon => $pkg"
+  if $addon eq 'python3'
+  && $bdepends_noarch->implies($dep)
+  && !$bdepends_noarch->implies(
+'python3-dev:any | python3-all-dev:any')
+  && !$bdepends_noarch->implies($pkg);
 }
 
 $dh_bd_version = $level if not defined($dh_bd_version);
diff --git a/debian/changelog b/debian/changelog
index d284aa9..0a5275c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,10 @@ lintian (2.5.82) UNRELEASED; urgency=medium
 
   XXX: generate tag summary
 
+  * checks/debhelper.pm:
++ [CL] Add a special case for the python3 addon as it needs a
+  dependency on dh-python unless the -dev packages are used.
+  Thanks to Julian Andres Klode for the report.  (Closes: #895284)
   * checks/python.pm:
 + [CL] Apply patch from Pierre-Elliott Bécue to loosen the changelog
   parsing of the new-package-should-not-package-python2-module tag to
diff --git a/t/tests/debhelper-dh-with-python3-unrel/debian/debian/control.in 
b/t/tests/debhelper-dh-with-python3-unrel/debian/debian/control.in
new file mode 100644
index 000..6182a2f
--- /dev/null
+++ b/t/tests/debhelper-dh-with-python3-unrel/debian/debian/control.in
@@ -0,0 +1,16 @@
+Source: {$source}
+Priority: optional
+Section: python
+Maintainer: {$author}
+Standards-Version: {$standards_version}
+Build-Depends: {$build_depends}, python3, dh-python
+Rules-Requires-Root: no
+
+Package: python3-{$source}
+Architecture: {$architecture}
+Depends: $\{misc:Depends\}
+Description: {$description}
+ This is a test package designed to exercise some feature or tag of
+ Lintian.  It is part of the Lintian test suite and may do very odd
+ things.  It should not be installed like a regular package.  It may
+ be an empty package.
diff --git a/t/tests/debhelper-dh-with-python3-unrel/debian/debian/rules 
b/t/tests/debhelper-dh-with-python3-unrel/debian/debian/rules
new file mode 100755
index 000..25115de
--- /dev/null
+++ b/t/tests/debhelper-dh-with-python3-unrel/debian/debian/rules
@@ -0,0 +1,4 @@
+#!/usr/bin/make -f
+
+%:
+   dh $@ --with python3
diff --git a/t/tests/debhelper-dh-with-python3-unrel/desc 
b/t/tests/debhelper-dh-with-python3-unrel/desc
new file mode 100644
index 000..e5418cb
--- /dev/null
+++ b/t/tests/debhelper-dh-with-python3-unrel/desc
@@ -0,0 +1,5 @@
+Testname: debhelper-dh-with-python3-unrel
+Version: 1.0
+Description: Check dependency requirements for dh --with python3 (false 
positive)
+Test-Against:
+ missing-build-dependency-for-dh-addon
diff --git a/t/tests/debhelper-dh-with-python3-unrel/tags 
b/t/tests/debhelper-dh-with-python3-unrel/tags
new file mode 100644
index 000..e69de29
diff --git a/t/tests/debhelper-dh-with-python3-unrel2/debian/debian/control.in 
b/t/tests/debhelper-dh-with-python3-unrel2/debian/debian/control.in
new file mode 100644
index 000..2e9a3c7
--- /dev/null
+++ b/t/tests/debhelper-dh-with-python3-unrel2/debian/debian/control.in
@@ -0,0 +1,16 @@
+Source: {$source}
+Priority: optional
+Section: python
+

[lintian] branch master updated (a75f3ed -> b02a1df)

2018-04-09 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  a75f3ed   Allow spaces within the ownership field of tar -tvf 
output whilst still allowing spaces in filenames. (Closes: #895175)
   new  29e9520   lib/Lintian/Collect/Package.pm: Allow optional seconds 
field in line parsing regex too.
   new  a455026   lib/Lintian/Collect/Package.pm: Simplify date portion 
parsing.
   new  00a4b17   lib/Lintian/Collect/Package.pm: Also allow for links, 
etc. in permission field.
   new  b02a1df   Add a special case for the python3 addon as it needs a 
dependency on dh-python unless the -dev packages are used. (Closes: #895284)

The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/debhelper.pm| 10 ++
 debian/changelog   |  4 
 lib/Lintian/Collect/Package.pm |  3 +--
 .../debian/debian/control.in   |  6 +++---
 .../debian/debian/rules|  2 +-
 t/tests/debhelper-dh-with-python3-unrel/desc   |  5 +
 .../debhelper-dh-with-python3-unrel}/tags  |  0
 .../debian/debian/control.in   |  6 +++---
 .../debian/debian/rules|  2 +-
 t/tests/debhelper-dh-with-python3-unrel2/desc  |  6 ++
 .../debhelper-dh-with-python3-unrel2}/tags |  0
 .../debian/debian/control.in   |  6 +++---
 .../debian/debian/rules|  2 +-
 t/tests/debhelper-dh-with-python3/desc |  5 +
 t/tests/debhelper-dh-with-python3/tags |  1 +
 15 files changed, 44 insertions(+), 14 deletions(-)
 copy t/tests/{debhelper-lacks-versioned-deps => 
debhelper-dh-with-python3-unrel}/debian/debian/control.in (82%)
 copy t/tests/{debhelper-dh-quilt-addon-but-quilt-source-format => 
debhelper-dh-with-python3-unrel}/debian/debian/rules (51%)
 create mode 100644 t/tests/debhelper-dh-with-python3-unrel/desc
 copy t/{debs/deb-format-record-size => 
tests/debhelper-dh-with-python3-unrel}/tags (100%)
 copy t/tests/{fields-no-homepage => 
debhelper-dh-with-python3-unrel2}/debian/debian/control.in (82%)
 copy t/tests/{debhelper-dh-quilt-addon-but-quilt-source-format => 
debhelper-dh-with-python3-unrel2}/debian/debian/rules (51%)
 create mode 100644 t/tests/debhelper-dh-with-python3-unrel2/desc
 copy t/{debs/deb-format-record-size => 
tests/debhelper-dh-with-python3-unrel2}/tags (100%)
 copy t/tests/{debhelper-lacks-versioned-deps => 
debhelper-dh-with-python3}/debian/debian/control.in (83%)
 copy t/tests/{debhelper-dh-quilt-addon-but-quilt-source-format => 
debhelper-dh-with-python3}/debian/debian/rules (51%)
 create mode 100644 t/tests/debhelper-dh-with-python3/desc
 create mode 100644 t/tests/debhelper-dh-with-python3/tags

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#895284: lintian: dh --with python3 needs dh-python, not satisfied by python3:any|python3-all:any as suggested

2018-04-09 Thread Chris Lamb 
tags 895284 + pending
thanks

Fixed in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=b02a1df6380a35510e00cbf1b10dac6c9966f4be


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Processed: Re: lintian: dh --with python3 needs dh-python, not satisfied by python3:any|python3-all:any as suggested

2018-04-09 Thread Debian Bug Tracking System 
Processing commands for cont...@bugs.debian.org:

> tags 895284 + pending
Bug #895284 [lintian] lintian: dh --with python3 needs dh-python, not satisfied 
by python3:any|python3-all:any as suggested
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
895284: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895284
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Build failed in Jenkins: lintian-tests_sid #2779

2018-04-09 Thread jenkins 
See 


Changes:

[lamby] lib/Lintian/Collect/Package.pm: Allow optional seconds field in line

[lamby] lib/Lintian/Collect/Package.pm: Simplify date portion parsing.

[lamby] lib/Lintian/Collect/Package.pm: Also allow for links, etc. in permission

[lamby] Add a special case for the python3 addon as it needs a dependency on

--
[...truncated 235.65 KB...]
Adding debian:AffirmTrust_Premium.pem
Adding debian:AffirmTrust_Networking.pem
Adding debian:AffirmTrust_Commercial.pem
Adding debian:AddTrust_Qualified_Certificates_Root.pem
Adding debian:AddTrust_Public_Services_Root.pem
Adding debian:AddTrust_Low-Value_Services_Root.pem
Adding debian:AddTrust_External_Root.pem
Adding debian:Actalis_Authentication_Root_CA.pem
Adding debian:AC_RAIZ_FNMT-RCM.pem
Adding debian:ACEDICOM_Root.pem
Adding debian:ACCVRAIZ1.pem
done.
Setting up openjdk-9-jdk-headless:amd64 (9.0.4+12-4) ...
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jlink to 
provide /usr/bin/jlink (jlink) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/idlj to 
provide /usr/bin/idlj (idlj) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jdeps to 
provide /usr/bin/jdeps (jdeps) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/wsimport to 
provide /usr/bin/wsimport (wsimport) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/rmic to 
provide /usr/bin/rmic (rmic) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jinfo to 
provide /usr/bin/jinfo (jinfo) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jstat to 
provide /usr/bin/jstat (jstat) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/javadoc to 
provide /usr/bin/javadoc (javadoc) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jmod to 
provide /usr/bin/jmod (jmod) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/javah to 
provide /usr/bin/javah (javah) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jhsdb to 
provide /usr/bin/jhsdb (jhsdb) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jstack to 
provide /usr/bin/jstack (jstack) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jrunscript to 
provide /usr/bin/jrunscript (jrunscript) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/javac to 
provide /usr/bin/javac (javac) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/javap to 
provide /usr/bin/javap (javap) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jar to provide 
/usr/bin/jar (jar) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jaotc to 
provide /usr/bin/jaotc (jaotc) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/policytool to 
provide /usr/bin/policytool (policytool) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/schemagen to 
provide /usr/bin/schemagen (schemagen) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jshell to 
provide /usr/bin/jshell (jshell) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jps to provide 
/usr/bin/jps (jps) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/xjc to provide 
/usr/bin/xjc (xjc) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jmap to 
provide /usr/bin/jmap (jmap) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jdeprscan to 
provide /usr/bin/jdeprscan (jdeprscan) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jimage to 
provide /usr/bin/jimage (jimage) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jstatd to 
provide /usr/bin/jstatd (jstatd) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jdb to provide 
/usr/bin/jdb (jdb) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/serialver to 
provide /usr/bin/serialver (serialver) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/wsgen to 
provide /usr/bin/wsgen (wsgen) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jcmd to 
provide /usr/bin/jcmd (jcmd) in auto mode
update-alternatives: using /usr/lib/jvm/java-9-openjdk-amd64/bin/jarsigner to 
provide /usr/bin/jarsigner (jarsigner) in auto mode
Setting up default-jdk-headless (2:1.9-63) ...
Setting up lintian-build-deps (2.5.82) ...
Processing triggers for libc-bin (2.27-3) ...
Processing triggers for systemd (238-4) ...
Processing triggers for dictionaries-common (1.27.2) ...
as

[lintian] 02/05: Ensure we have all the build/test depencencies for our debhelper-dh-with-python3* tests.

2018-04-09 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 397c9349061e0de7e6d97078ac9ecd9d43a435dd
Author: Chris Lamb 
Date:   Mon Apr 9 19:39:52 2018 +0100

Ensure we have all the build/test depencencies for our 
debhelper-dh-with-python3* tests.
---
 debian/control| 1 +
 t/tests/debhelper-dh-with-python3-unrel/desc  | 1 +
 t/tests/debhelper-dh-with-python3-unrel2/desc | 1 +
 t/tests/debhelper-dh-with-python3/desc| 1 +
 4 files changed, 4 insertions(+)

diff --git a/debian/control b/debian/control
index ae21ecb..c383c8d 100644
--- a/debian/control
+++ b/debian/control
@@ -22,6 +22,7 @@ Build-Depends: aspell ,
default-jdk-headless  | default-jdk ,
 # Use bash as a Jessie indicator (dh-elpa is only used for a test)
dh-elpa  | bash (<< 4.4) ,
+   dh-python ,
diffstat ,
docbook-utils,
docbook-xml,
diff --git a/t/tests/debhelper-dh-with-python3-unrel/desc 
b/t/tests/debhelper-dh-with-python3-unrel/desc
index e5418cb..b60dd80 100644
--- a/t/tests/debhelper-dh-with-python3-unrel/desc
+++ b/t/tests/debhelper-dh-with-python3-unrel/desc
@@ -1,5 +1,6 @@
 Testname: debhelper-dh-with-python3-unrel
 Version: 1.0
 Description: Check dependency requirements for dh --with python3 (false 
positive)
+Test-Depends: dh-python
 Test-Against:
  missing-build-dependency-for-dh-addon
diff --git a/t/tests/debhelper-dh-with-python3-unrel2/desc 
b/t/tests/debhelper-dh-with-python3-unrel2/desc
index 8ac74b0..773bed7 100644
--- a/t/tests/debhelper-dh-with-python3-unrel2/desc
+++ b/t/tests/debhelper-dh-with-python3-unrel2/desc
@@ -2,5 +2,6 @@ Testname: debhelper-dh-with-python3-unrel2
 Version: 1.0
 Description: Check dependency requirements for dh --with python3 (false 
positive)
 Architecture: any
+Test-Depends: dh-python
 Test-Against:
  missing-build-dependency-for-dh-addon
diff --git a/t/tests/debhelper-dh-with-python3/desc 
b/t/tests/debhelper-dh-with-python3/desc
index c66b69f..ef1f0cf 100644
--- a/t/tests/debhelper-dh-with-python3/desc
+++ b/t/tests/debhelper-dh-with-python3/desc
@@ -1,5 +1,6 @@
 Testname: debhelper-dh-with-python3
 Version: 1.0
 Description: Check dependency requirements for dh --with python3
+Test-Depends: dh-python
 Test-For:
  missing-build-dependency-for-dh-addon

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (b02a1df -> 425c2f8)

2018-04-09 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  b02a1df   Add a special case for the python3 addon as it needs a 
dependency on dh-python unless the -dev packages are used. (Closes: #895284)
   new  67806e7   debian/control: Drop some extra whitespace.
   new  397c934   Ensure we have all the build/test depencencies for our 
debhelper-dh-with-python3* tests.
   new  7d887c0   lib/Lintian/Profile.pm: Add missing "check" noun to "... 
references unknown $check" error message.
   new  fb04da2   Add support for derivative-specific field parsing to 
allow enforcement of additional restrictions (eg. updating Vcs-Git, etc.)
   new  425c2f8   Add support for derivative-specific version validation to 
permit enforcement of additional restrictions on the version number.

The 5 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/changes-file.desc   | 10 ++
 checks/changes-file.pm | 10 ++
 checks/fields.desc | 18 ++
 checks/fields.pm   | 22 ++
 data/changes-file/derivative-versions  |  5 +
 data/fields/derivative-fields  |  5 +
 debian/changelog   |  7 +++
 debian/control |  3 ++-
 lib/Lintian/Profile.pm |  2 +-
 t/tests/debhelper-dh-with-python3-unrel/desc   |  1 +
 t/tests/debhelper-dh-with-python3-unrel2/desc  |  1 +
 t/tests/debhelper-dh-with-python3/desc |  1 +
 .../main/data/changes-file/derivative-versions |  1 +
 vendors/pureos/main/data/fields/derivative-fields  |  8 
 14 files changed, 92 insertions(+), 2 deletions(-)
 create mode 100644 data/changes-file/derivative-versions
 create mode 100644 data/fields/derivative-fields
 create mode 100644 vendors/pureos/main/data/changes-file/derivative-versions
 create mode 100644 vendors/pureos/main/data/fields/derivative-fields

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/05: debian/control: Drop some extra whitespace.

2018-04-09 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 67806e7fece8ecb35597e0f2f3c029c53c8c4875
Author: Chris Lamb 
Date:   Mon Apr 9 19:39:25 2018 +0100

debian/control: Drop some extra whitespace.
---
 debian/control | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index 456016f..ae21ecb 100644
--- a/debian/control
+++ b/debian/control
@@ -21,7 +21,7 @@ Build-Depends: aspell ,
 # it is not available in Jessie.
default-jdk-headless  | default-jdk ,
 # Use bash as a Jessie indicator (dh-elpa is only used for a test)
-   dh-elpa   | bash (<< 4.4) ,
+   dh-elpa  | bash (<< 4.4) ,
diffstat ,
docbook-utils,
docbook-xml,

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 03/05: lib/Lintian/Profile.pm: Add missing "check" noun to "... references unknown $check" error message.

2018-04-09 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 7d887c088b3b8d268d33d8f6d75330eb41c85915
Author: Chris Lamb 
Date:   Mon Apr 9 17:52:28 2018 +0100

lib/Lintian/Profile.pm: Add missing "check" noun to "... references unknown 
$check" error message.
---
 lib/Lintian/Profile.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Lintian/Profile.pm b/lib/Lintian/Profile.pm
index 75c01a6..374d241 100644
--- a/lib/Lintian/Profile.pm
+++ b/lib/Lintian/Profile.pm
@@ -591,7 +591,7 @@ sub _load_check {
 last;
 }
 }
-croak "$profile references unknown $check" unless defined $dir;
+croak "$profile references unknown check $check" unless defined $dir;
 return $self->_parse_check($check, $dir);
 }
 

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 05/05: Add support for derivative-specific version validation to permit enforcement of additional restrictions on the version number.

2018-04-09 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 425c2f8ef19e53aa90b12292803818d29a99ab19
Author: Chris Lamb 
Date:   Mon Apr 9 19:36:12 2018 +0100

Add support for derivative-specific version validation to permit 
enforcement of additional restrictions on the version number.
---
 checks/changes-file.desc  | 10 ++
 checks/changes-file.pm| 10 ++
 data/changes-file/derivative-versions |  5 +
 debian/changelog  |  4 
 vendors/pureos/main/data/changes-file/derivative-versions |  1 +
 5 files changed, 30 insertions(+)

diff --git a/checks/changes-file.desc b/checks/changes-file.desc
index 55dacb3..5919f52 100644
--- a/checks/changes-file.desc
+++ b/checks/changes-file.desc
@@ -206,3 +206,13 @@ Info: The packaging includes an upstream signing key but 
the corresponding
  .
  Support for signatures was added to pristine-tar in version 1.41
  and support in git-buildpackage is being tracked in #872864.
+
+Tag: invalid-version-number-for-derivative
+Severity: serious
+Certainty: certain
+Info: The version number for this package does not comply with the
+ required format for this Debian derivative.
+ .
+ Derivative distributions of Debian may enforce additional restrictions
+ on the version in order to ensure that forked (or packages that are
+ otherwise modified) are marked as such.
diff --git a/checks/changes-file.pm b/checks/changes-file.pm
index 6ca14e4..bed1a87 100644
--- a/checks/changes-file.pm
+++ b/checks/changes-file.pm
@@ -32,6 +32,8 @@ use Lintian::Util qw(get_file_checksum);
 
 my $KNOWN_DISTS = Lintian::Data->new('changes-file/known-dists');
 my $SIGNING_KEY_FILENAMES = Lintian::Data->new('common/signing-key-filenames');
+my $DERIVATIVE_VERSIONS= Lintian::Data->new('changes-file/derivative-versions',
+qr/\s*~~\s*/, sub { $_[1]; });
 
 sub run {
 my (undef, undef, $info, undef, $group) = @_;
@@ -254,6 +256,14 @@ sub run {
   if $seen != $expected;
 }
 
+# Check version field
+my $version = $info->field('version');
+foreach my $re ($DERIVATIVE_VERSIONS->all) {
+next if $version =~ m/$re/;
+my $explanation = $DERIVATIVE_VERSIONS->value($re);
+tag 'invalid-version-number-for-derivative', $version,"($explanation)";
+}
+
 return;
 }
 
diff --git a/data/changes-file/derivative-versions 
b/data/changes-file/derivative-versions
new file mode 100644
index 000..02fd409
--- /dev/null
+++ b/data/changes-file/derivative-versions
@@ -0,0 +1,5 @@
+# Derivative-specific version number validation
+#
+# format: $regex ~~ explanation
+
+.  ~~  always matches
diff --git a/debian/changelog b/debian/changelog
index f06645b..cd5166b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,10 @@ lintian (2.5.82) UNRELEASED; urgency=medium
 
   XXX: generate tag summary
 
+  * checks/changes-file.{desc,pm}:
++ [CL] Add support for derivative-specific version validation to permit
+  enforcement of additional restrictions on the version number such as
+  being suffixed by "derivativeos1", etc.
   * checks/debhelper.pm:
 + [CL] Add a special case for the python3 addon as it needs a
   dependency on dh-python unless the -dev packages are used.
diff --git a/vendors/pureos/main/data/changes-file/derivative-versions 
b/vendors/pureos/main/data/changes-file/derivative-versions
new file mode 100644
index 000..7cf86d2
--- /dev/null
+++ b/vendors/pureos/main/data/changes-file/derivative-versions
@@ -0,0 +1 @@
+pureos\d+$ ~~  must end with pureosX

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 04/05: Add support for derivative-specific field parsing to allow enforcement of additional restrictions (eg. updating Vcs-Git, etc.)

2018-04-09 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit fb04da2937a68ae795d6d9c5f9bd520ce5b0f364
Author: Chris Lamb 
Date:   Mon Apr 9 19:34:23 2018 +0100

Add support for derivative-specific field parsing to allow enforcement of 
additional restrictions (eg. updating Vcs-Git, etc.)
---
 checks/fields.desc| 18 ++
 checks/fields.pm  | 22 ++
 data/fields/derivative-fields |  5 +
 debian/changelog  |  3 +++
 vendors/pureos/main/data/fields/derivative-fields |  8 
 5 files changed, 56 insertions(+)

diff --git a/checks/fields.desc b/checks/fields.desc
index 18f528f..b78568f 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -1497,3 +1497,21 @@ Info: This package has a relationship with a 
mail-transport-agent but
  Please change the dependency to:
  .
   default-mta | pkgname | mail-transport-agent
+
+Tag: invalid-field-for-derivative
+Severity: serious
+Certainty: certain
+Info: The specified field in debian/control does not match the
+ required format for this Debian derivative.
+ .
+ Derivative distributions of Debian may enforce additional restrictions
+ on such fields for many reasons including ensuring that:
+ .
+   - Debian maintainers are not contacted for forked or packages that
+ are otherwise modified by the derivative.
+   - The original maintainer is still credited for their work (eg. in a
+ XSBC-Original-Maintainer fied.
+   - References to revision control systems (eg. Vcs-Git) are
+ pointing to the correct, updated location.
+   - Fields that become misleading in the context of a derivative are
+ removed.
diff --git a/checks/fields.pm b/checks/fields.pm
index 50d41eb..4b36ad7 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -57,6 +57,16 @@ our $KNOWN_VCS_BROWSERS
 
 our %KNOWN_ARCHIVE_PARTS = map { $_ => 1 } ('non-free', 'contrib');
 
+my $DERIVATIVE_FIELDS = Lintian::Data->new(
+'fields/derivative-fields',
+qr/\s*\~\~\s*/,
+sub {
+my ($regexp, $explanation) = split(/\s*\~\~\s*/, $_[1], 2);
+return {
+'regexp' => qr/$regexp/,
+'explanation' => $explanation,
+};
+});
 my $KNOWN_PRIOS = Lintian::Data->new('fields/priorities');
 
 our @supported_source_formats = (qr/1\.0/, qr/3\.0\s*\((quilt|native)\)/);
@@ -1419,6 +1429,18 @@ sub run {
 tag 'no-strong-digests-in-dsc'
   if $type eq 'source' && !$info->field('checksums-sha256');
 
+#- Derivative-specific field checks
+
+if ($type eq 'source') {
+foreach my $field ($DERIVATIVE_FIELDS->all) {
+my $val = $info->field($field, '-');
+my $data = $DERIVATIVE_FIELDS->value($field);
+tag 'invalid-field-for-derivative',
+  "$field: $val ($data->{'explanation'})"
+  if $val !~ m/$data->{'regexp'}/;
+}
+}
+
 #- Field checks (without checking the value)
 
 for my $field (keys %{$info->field}) {
diff --git a/data/fields/derivative-fields b/data/fields/derivative-fields
new file mode 100644
index 000..36600f1
--- /dev/null
+++ b/data/fields/derivative-fields
@@ -0,0 +1,5 @@
+# Derivative-specific field validation
+#
+# format: field ~~ ^regex$ ~~ explanation
+
+source ~~  .   ~~  always matches
diff --git a/debian/changelog b/debian/changelog
index 0a5275c..f06645b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,6 +6,9 @@ lintian (2.5.82) UNRELEASED; urgency=medium
 + [CL] Add a special case for the python3 addon as it needs a
   dependency on dh-python unless the -dev packages are used.
   Thanks to Julian Andres Klode for the report.  (Closes: #895284)
+  * checks/fields.{desc,pm}:
++ [CL] Add support for derivative-specific field parsing to allow
+  enforcement of additional restrictions (eg. updating Vcs-Git, etc.)
   * checks/python.pm:
 + [CL] Apply patch from Pierre-Elliott Bécue to loosen the changelog
   parsing of the new-package-should-not-package-python2-module tag to
diff --git a/vendors/pureos/main/data/fields/derivative-fields 
b/vendors/pureos/main/data/fields/derivative-fields
new file mode 100644
index 000..5c9eba8
--- /dev/null
+++ b/vendors/pureos/main/data/fields/derivative-fields
@@ -0,0 +1,8 @@
+maintainer ~~  ^PureOS Maintainers 
$  ~~ != PureOS Maintainers 

+uploaders  ~~  ^-$ 
~~ field must be empty
+xsbc-original-maintainer   ~~  .   
~~ must be set to original Maintainer field
+vcs-cvs~~  ^-$ 
~~ field must be empty
+vcs-hg ~~  ^-$

[lintian] 01/01: Add missing changlog entries.

2018-04-09 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 12be328ce406ee0e18d92524423e1efcbc318915
Author: Chris Lamb 
Date:   Mon Apr 9 19:54:52 2018 +0100

Add missing changlog entries.

These were meant to be split into separate commits from
fb04da2937a68ae795d6d9c5f9bd520ce5b0f364 and
425c2f8ef19e53aa90b12292803818d29a99ab19.
---
 debian/changelog | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index cd5166b..593aa1c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -24,6 +24,12 @@ lintian (2.5.82) UNRELEASED; urgency=medium
   some currently-problematic packages such as gcc-8-cross-ports
   preventing the update of https://lintian.debian.org/.  (See #890873)
 
+  * vendors/pureos/main/data/changes-file/derivative-versions:
++ [CL] Ensure that PureOS packages always end with (eg. pureosX).
+  * vendors/pureos/main/data/fields/derivative-fields:
++ [CL] Add PureOS-specific field name validation, such as ensuring the
+  Maintainer field is updated to the mailing list.
+
   * lib/Lintian/Collect/Package.pm:
 + [CL] Allow spaces within the ownership field of tar -tvf output
   whilst still allowing spaces in filenames.  (Closes: #895175)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (425c2f8 -> 12be328)

2018-04-09 Thread Chris Lamb 
This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  425c2f8   Add support for derivative-specific version validation to 
permit enforcement of additional restrictions on the version number.
   new  12be328   Add missing changlog entries.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 debian/changelog | 6 ++
 1 file changed, 6 insertions(+)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Jenkins build is back to normal : lintian-tests_sid #2780

2018-04-09 Thread jenkins 
See

Bug#818609: lintian: python-script-but-no-python-dep false positive

2018-04-09 Thread Chris Lamb 
Dear Neil,

> > Could you provide this lava-dev .deb somewhere publically?

Thanks for this. So:

$ wget 
http://images.validation.linaro.org/staging-repo/pool/main/l/lava-server/lava-dev_2018.2+7234.16764207-1+_all.deb

   $ lintian lava-dev_2018.2+7234.16764207-1+_all.deb
  […]
  E: lava-dev: python-script-but-no-python-dep usr/share/lava-
 server/validate_devices.py #!/usr/bin/python

But:

$ dpkg -I lava-dev_2018.2+7234.16764207-1+_all.deb
 Depends: build-essential, ca-certificates, devscripts, dpkg-dev,
 debootstrap (>= 1.0.86), debhelper (>= 9.20160709), fakeroot, git,
 libdistro-info-perl, node-uglify, libjs-excanvas, libjs-jquery-
 cookie, libjs-jquery, libjs-jquery-watermark, libjs-jquery-flot
 (>= 0.8.2), libjs-jquery-ui, pep8 | python-pep8, python-guestfs,
 python-nose, python-netifaces, python3-sphinx (>= 1.4), python-
 setuptools, python-pexpect (>= 4.2), python3-sphinx-bootstrap-
 theme, python-requests, python-zmq, python-yaml, python-voluptuous
 (>= 0.8.8), docbook-xsl, xsltproc, python-mock

> > As an aside: I understand that git-buildpackage is not for everyone,
> > but here is a great example of where common, shared tools would really
> > have a benefit and would save this round trip to fixing this issue.
> 
> This isn't about git-ignore anything, this is about building upstream
> packages with (sometimes) untested and uncommitted upstream changes to
> be able to do the testing prior to and during code review. Making
> debian/patches for that is a complete nonsense. 

Alas, I think at least one of us is confused or misinterpreting the
other here..  Or, perhaps, you are not aware that git- buildpackage
is perfectly capable of doing such snapshots, indeed without
debian/patches. Perhaps you last used an old version? This is
almost certainly a conversation to be had elsewhere, mind you!

  :)


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-