[Git][lintian/lintian][master] 12 commits: Remove declaration of default skeleton.

2019-01-24 Thread Chris Lamb
Chris Lamb pushed to branch master at lintian / lintian


Commits:
baa83a28 by Felix Lechner at 2019-01-24T22:28:50Z
Remove declaration of default skeleton.

The default skeleton is 'default'. That was sufficient when skeletons
were specific to suites: Each suite had a default skeleton. When the
tag-related tests no longer have suites, those skeletons require more
meaninful names. The name of each such skeleton will then have to be
mentioned in any test specification that uses it. Removes the
declaration of a default skeleton.

Gbp-Dch: ignore

Signed-off-by: Chris Lamb 

- - - - -
05c3c6bf by Felix Lechner at 2019-01-24T22:28:55Z
Rename skeletons and move them to the folder a level above.

Move all skeleton files to the common, non-suite specific folder one level
above. Also give them meaningful names that are different from the overloaded
'default'.

Gbp-Dch: ignore

Signed-off-by: Chris Lamb 

- - - - -
c1214168 by Felix Lechner at 2019-01-24T22:28:56Z
Remove suite as a consideration for skeleton selection.

The selection of skeletons was previously suite-specific. Remove all references
to suites from the test runner, except for the suites 'tags' and 
'scripts'.
Also look for skeletons in a non-suite specific location. Also no longer store
the suite in the 'desc' file recorded in a test's work directory.

Gbp-Dch: ignore

Signed-off-by: Chris Lamb 

- - - - -
04788399 by Felix Lechner at 2019-01-24T22:28:59Z
Refer to Skeleton 'upload-builder-only' in tests that require it.

Uses the new and more meaningful name of the same skeleton. Was previously
known as builder-only in suite tests.

Gbp-Dch: ignore

Signed-off-by: Chris Lamb 

- - - - -
9228145e by Felix Lechner at 2019-01-24T22:29:02Z
Refer to Skeleton 'upload-non-native' in tests that require it.

Uses the new and more meaningful name of the same skeleton. Was previously
known as non-native in suite tests.

Gbp-Dch: ignore

Signed-off-by: Chris Lamb 

- - - - -
436d92ad by Felix Lechner at 2019-01-24T22:29:04Z
Refer to Skeleton 'upload-native' in tests that require it.

Uses the new and more meaningful name of the same skeleton. Was previously
known as default in suite tests.

Gbp-Dch: ignore

Signed-off-by: Chris Lamb 

- - - - -
ec756ed8 by Felix Lechner at 2019-01-24T22:29:06Z
Refer to Skeleton 'deb' in tests that require it.

Uses the new and more meaningful name of the same skeleton. Was previously
known as default in suite debs.

Gbp-Dch: ignore

Signed-off-by: Chris Lamb 

- - - - -
fa598250 by Felix Lechner at 2019-01-24T22:29:11Z
Refer to Skeleton 'changes' in tests that require it.

Uses the new and more meaningful name of the same skeleton. Was previously
known as default in suite changes.

Gbp-Dch: Ignore

Signed-off-by: Chris Lamb 

- - - - -
f508b43a by Felix Lechner at 2019-01-24T22:29:14Z
Refer to Skeleton 'dsc' in tests that require it.

Uses the new and more meaningful name of the same skeleton. Was previously
known as default in suite source.

Gbp-Dch: ignore

Signed-off-by: Chris Lamb 

- - - - -
0d7d378a by Felix Lechner at 2019-01-24T22:29:15Z
Adjust harness tests for lack of suites or default skeletons.

Remove suite references from the internal harness tests and explicitly declare
the use of skeletons.

Gbp-Dch: Ignore

Signed-off-by: Chris Lamb 

- - - - -
1b943bcb by Felix Lechner at 2019-01-24T22:29:21Z
Update README for new use of skeletons in tests.

Also updates the reference to a tests output data, including the log, in
../debian/test-out.

Gbp-Dch: ignore

Signed-off-by: Chris Lamb 

- - - - -
ff9e8056 by Felix Lechner at 2019-01-24T22:29:39Z
Ensure that "explicit skeletons" are now required, the first step to 
make tests freely groupable. (MR: !132)

- - - - -


30 changed files:

- lib/Test/Lintian/ConfigFile.pm
- lib/Test/Lintian/Prepare.pm
- lib/Test/Lintian/Run.pm
- t/changes/changed-by-localhost/desc
- t/changes/changed-by-malformed/desc
- t/changes/changed-by-no-name/desc
- t/changes/changed-by-root-email/desc
- t/changes/changed-by-root/desc
- t/changes/changes-bad-ubuntu-distribution/desc
- t/changes/changes-directory-traversal/desc
- t/changes/changes-distribution-mismatch/desc
- t/changes/changes-experimental-mismatch/desc
- t/changes/changes-file-bad-section/desc
- t/changes/changes-file-size-checksum-mismatch/desc
- t/changes/changes-missing-fields/desc
- t/changes/changes-missing-format/desc
- t/changes/changes-unreleased/desc
- t/debs/changelog-file-syntax/desc
- t/debs/control-field-traversal-4/desc
- t/debs/control-files-bad/desc
- t/debs/control-files-traversal/desc
- t/debs/control-files-weird-files/desc
- t/debs/copyright-file-foreign-package/desc
- t/debs/deb-format-ancient-file/desc
- t/debs/deb-format-errors-tar/desc
- t/debs/deb-format-extra-member/desc
- t/debs/deb-format-extra-underscore-member-be

Processed: Bug #920228 in lintian marked as pending

2019-01-24 Thread Debian Bug Tracking System
Processing control commands:

> tag -1 pending
Bug #920228 [lintian] lintian: Should locate/parse .buildinfo file if mentioned 
in .changes
Added tag(s) pending.

-- 
920228: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=920228
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Processed: Bug #920376 in lintian marked as pending

2019-01-24 Thread Debian Bug Tracking System
Processing control commands:

> tag -1 pending
Bug #920376 [lintian] lintian: Add a check for binaries using obsolete DES 
encryption
Added tag(s) pending.

-- 
920376: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=920376
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#920376: lintian: Add a check for binaries using obsolete DES encryption

2019-01-24 Thread Zack Weinberg
Package: lintian
Version: 2.5.123
Severity: wishlist
Tags: patch

The attached patch adds a Lintian check for binaries using the obsolete
DES encryption functions that were made inaccessible to newly linked
binaries in glibc 2.28.  See the patch's commit message for more detail.

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils   2.31.1-11
ii  bzip2  1.0.6-9
ii  diffstat   1.62-1
ii  dpkg   1.19.4
ii  dpkg-dev   1.19.4
ii  file   1:5.35-2
ii  gettext0.19.8.1-9
ii  gpg2.2.12-1
ii  intltool-debian0.35.0+20060710.5
ii  libapt-pkg-perl0.1.34+b1
ii  libarchive-zip-perl1.64-1
ii  libcgi-pm-perl 4.40-1
ii  libclass-accessor-perl 0.51-1
ii  libclone-perl  0.41-1+b1
pn  libdigest-sha-perl 
ii  libdpkg-perl   1.19.4
ii  libemail-valid-perl1.202-1
ii  libfile-basedir-perl   0.08-1
ii  libio-async-perl   0.72-1
ii  libipc-run-perl20180523.0-1
ii  liblist-moreutils-perl 0.416-1+b4
ii  libparse-debianchangelog-perl  1.2.0-13
ii  libtext-levenshtein-perl   0.13-1
ii  libtimedate-perl   2.3000-2
ii  liburi-perl1.76-1
ii  libxml-simple-perl 2.25-1
ii  libyaml-libyaml-perl   0.76+repack-1
ii  man-db 2.8.5-1
ii  patchutils 0.3.4-2
ii  perl   5.28.1-3
ii  t1utils1.41-3
ii  xz-utils   5.2.2-1.3

Versions of packages lintian recommends:
pn  libperlio-gzip-perl  

Versions of packages lintian suggests:
pn  binutils-multiarch 
ii  libhtml-parser-perl3.72-3+b3
ii  libtext-template-perl  1.54-1

-- no debconf information
>From d79acb92725ef2ddbc2b33eba62a4e7b7f361a3d Mon Sep 17 00:00:00 2001
From: Zack Weinberg 
Date: Thu, 24 Jan 2019 15:40:26 -0500
Subject: [PATCH] Add a check for binaries using obsolete DES encryption.

libcrypt.so.1 (part of glibc) used to provide a set of functions that
allowed raw use of the DES block cipher.  Encryption with DES is now
inherently insecure (any use of single DES can be broken by brute
force) and therefore these functions were made inaccessible to newly
linked programs in glibc 2.28.

Any program in the archive that unconditionally uses one of these
functions will FTBFS with glibc 2.28.  Any program that conditionally
uses one of these functions may be falling back to an internal
implementation of DES and therefore have a security bug.

Therefore, I propose this new lintian check, which detects use of the
functions that were removed from libcrypt.so.1.  In sid it is arguably
redundant (since any program that would fail this check will FTBFS
anyway) but applying this check to the stable archive would detect
programs that were conditionally using these functions and need to be
audited for security bugs.
---
 checks/binaries.desc  | 45 
 checks/binaries.pm| 10 +++-
 data/binaries/obsolete-crypt-functions| 13 +
 t/tests/binaries-obsolete-des/desc|  7 +++
 t/tests/binaries-obsolete-des/orig/Makefile   | 51 +++
 t/tests/binaries-obsolete-des/orig/dummy.pod  | 12 +
 .../binaries-obsolete-des/orig/uses-encrypt.c | 30 +++
 .../orig/uses-encrypt_r.c | 33 
 .../binaries-obsolete-des/orig/uses-fcrypt.c  | 21 
 .../binaries-obsolete-des/orig/uses-setkey.c  | 45 
 .../orig/uses-setkey_r.c  | 48 +
 t/tests/binaries-obsolete-des/tags|  5 ++
 12 files changed, 319 insertions(+), 1 deletion(-)
 create mode 100644 data/binaries/obsolete-crypt-functions
 create mode 100644 t/tests/binaries-obsolete-des/desc
 create mode 100644 t/tests/binaries-obsolete-des/orig/Makefile
 create mode 100644 t/tests/binaries-obsolete-des/orig/dummy.pod
 create mode 100644 t/tests/binaries-obsolete-des/orig/uses-encrypt.c
 create mode 100644 t/tests/binaries-obsolete-des/orig/uses-encrypt_r.c
 create mode 100644 t/tests/binaries-obsolete-des/orig/uses-fcrypt.c
 create mode 100644 t/tests/binaries-obsolete-des/orig/uses-setkey.c
 create mode 100644 t/tests/binaries-obsolete-des/orig/uses-setkey_r.c
 create mode 100644 t/tests/binaries-obsolete-des/tags

diff --git a/checks/bina

Bug#920314: lintian: vcs-field-has-unexpected-spaces has false positives for Vcs-Hg that specify a branch

2019-01-24 Thread Chris Lamb
tags 920314 - moreinfo
retitle 920314 lintian: vcs-field-has-unexpected-spaces has false positives for 
Vcs-Hg that specify a branch
thanks

Hi Jeremy,

> >   * Can you confirm that "hg clone  -b foo" works? If so, we
> > should update Policy to (at least) also permit "-b branchname"
> > or "[branchname]" for Mercurial repos.
> 
> The manpage suggests that -b works for hg, but hg is rare enough in
> Debian that I'm not personally interested in updating policy for it.

I've filed #920355 against Policy for this. "Be the change...", right?

> I agree with the suggestions here that none of these are currently
> valid according to Debian Policy.

Doesn't mean that Lintian can't deviate! I'll update it now to
allow -b for Vcs-Hg and link to the relevant section in Policy.


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org 🍥 chris-lamb.co.uk
   `-



Processed: Re: Bug#920314: lintian: vcs-field-has-unexpected-spaces has false positives for Vcs-Hg that specify a branch

2019-01-24 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> tags 920314 - moreinfo
Bug #920314 [src:lintian] lintian: vcs-field-has-unexpected-spaces has false 
positives
Removed tag(s) moreinfo.
> retitle 920314 lintian: vcs-field-has-unexpected-spaces has false positives 
> for Vcs-Hg that specify a branch
Bug #920314 [src:lintian] lintian: vcs-field-has-unexpected-spaces has false 
positives
Changed Bug title to 'lintian: vcs-field-has-unexpected-spaces has false 
positives for Vcs-Hg that specify a branch' from 'lintian: 
vcs-field-has-unexpected-spaces has false positives'.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
920314: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=920314
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#920314: lintian: vcs-field-has-unexpected-spaces has false positives

2019-01-24 Thread Jeremy Bicha
On Thu, Jan 24, 2019 at 3:43 AM Chris Lamb  wrote:
>   * Can you confirm that "hg clone  -b foo" works? If so, we
> should update Policy to (at least) also permit "-b branchname"
> or "[branchname]" for Mercurial repos.

The manpage suggests that -b works for hg, but hg is rare enough in
Debian that I'm not personally interested in updating policy for it.

I agree with the suggestions here that none of these are currently
valid according to Debian Policy. Could you please update the Lintian
extended description for this tag to link to
https://www.debian.org/doc/debian-policy/ch-controlfields.html#version-control-system-vcs-fields
?
Once that's done, feel free to close this bug.

Thanks,
Jeremy Bicha



lintian_2.5.123~bpo9+1_amd64.changes ACCEPTED into stretch-backports

2019-01-24 Thread Debian FTP Masters



Accepted:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Format: 1.8
Date: Thu, 24 Jan 2019 09:44:53 +0100
Source: lintian
Binary: lintian
Built-For-Profiles: nocheck
Architecture: source all
Version: 2.5.123~bpo9+1
Distribution: stretch-backports
Urgency: medium
Maintainer: Debian Lintian Maintainers 
Changed-By: Chris Lamb 
Description:
 lintian- Debian package checker
Closes: 907072 919162 919604 919740 919839 919979
Changes:
 lintian (2.5.123~bpo9+1) stretch-backports; urgency=medium
 .
   * Rebuild for stretch-backports.
 .
 lintian (2.5.123) unstable; urgency=medium
 .
   * Summary of tag changes:
 + Added:
   - inconsistent-appstream-metadata-license
   - package-contains-python-header-in-incorrect-directory
 + Renamed:
   - package-contains-usr-unmerged-pathnames ->
 package-contains-real-file-outside-usr
 .
   [ Chris Lamb ]
   * Group warnings that only differ on the architecture in the HTML
 reports. (Closes: #919162)
   * Prevent a large number false-positives when checking "new style" init
 scripts that use "#!/usr/bin/env /lib/init/init-d-script" as their
 shebang. (Closes: #919604)
   * Check for packages that ship headers in /usr/include/python3.x.
 (Closes: #919979)
   * Check for inconsistencies between debian/copyright and the information
 embedded/duplicated in AppStream metadata files. Thanks to Daniel Kahn
 Gillmor for the idea. (Closes: #907072)
   * package-contains-usr-unmerged-pathnames tag:
 - Prevent false-positives for leading directories. (Closes: #919839)
 - Rename from package-contains-real-file-outside-usr.
 - Move to "Classification" severity instead of a pedantic/experimental
   combination.
   * Use a verb in the debian-changelog-line-too-short tag description.
   * Use "state cache" vs "state-cache" consistently between source and
 binary packages when printing warnings during report generation.
   * Update added/removed tag summary generation code to match "WIP" now we
 are using gbp-dch(1).
 .
   [ Niels Thykier ]
   * lib/lintian: Do entry removals asynchroniously in temp labs.
   * Lintian::Unpacker:
 * Migrate to use IO::Async.
 * Refactor to extract a "find_next_task"-sub(-generator).
 * Add a simple queue to avoid some overhead.
 * Support prioritizing unpacking by collections.
 .
   [ Felix Lechner ]
   * Template cleanup: (MR: !131)
 - Rename tests-watchfile and tests-pedantic.
 - Use renamed template sets in skeletons for suite tests.
 - Move upstream/metadata from debian-native to debian-extra-non-native.
 - Delete unused template set source-arch-independent.
 .
   [ Mike Miller ]
   * Reword the description of the description-too-long tag to match the
 actual check. (Closes: #919740)
 .
   [ Paul Wise ]
   * Add several spelling corrections.
Checksums-Sha1:
 b9b6ccba066f7e2ce1ed5d2035d128f98b8bf66c 3596 lintian_2.5.123~bpo9+1.dsc
 e048865c426fc41922d6460f2a47af26c60e96a9 1636456 lintian_2.5.123~bpo9+1.tar.xz
 9e798a4174b00c040a2b3eeddc57d24a9103714a 1188918 lintian_2.5.123~bpo9+1_all.deb
 d7eb21be3aee0df35d0cea42a85582e0af9c88ec 8835 
lintian_2.5.123~bpo9+1_amd64.buildinfo
Checksums-Sha256:
 154e703d0863698886eeb8359b4332714bdb7f405bfda090cce084db3b7cf71d 3596 
lintian_2.5.123~bpo9+1.dsc
 b589726ce4dd0ed7aac00ecfc1f66244ec8971063260a03e16d5bc25749de35a 1636456 
lintian_2.5.123~bpo9+1.tar.xz
 11bcbd046f79fe2a5571cd074ecba6e8c339a487f72d7eec1a29b8875d49e556 1188918 
lintian_2.5.123~bpo9+1_all.deb
 a777d0feffed6f47949d3db31722eeceb3624921dfe0989ed6a2162e7f45f263 8835 
lintian_2.5.123~bpo9+1_amd64.buildinfo
Files:
 f065409950337625b6d8697d5e77e05b 3596 devel optional lintian_2.5.123~bpo9+1.dsc
 e712422bd16968bb51ca3e0d1cee7ae6 1636456 devel optional 
lintian_2.5.123~bpo9+1.tar.xz
 f2986fbddc7f45457770b01fd37d1cc9 1188918 devel optional 
lintian_2.5.123~bpo9+1_all.deb
 2911a02548bf6a492df1c49c2d62502e 8835 devel optional 
lintian_2.5.123~bpo9+1_amd64.buildinfo

-BEGIN PGP SIGNATURE-

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAlxJfDsACgkQHpU+J9Qx
HljTDQ//VAJh2kh6Xa5W14m1X6/ze4P9oP7OpNV5mgN4SnGptc9hWm7Dqn2rJVzW
l5Qt7/6nCPYLKpdArWkjIDzHtGaDQegfgmBysmateLiuTlNDbzJvZG2jSqCmU/b3
69P+MXt554w0P9uaDK1s7F9iqnJWMy1HhtP2Rs7w3qx7xrRubL0Y3hbnRDTogzpu
AJ9X23PBR179ea/0vlwFQ3PskI1y+M3+3KHBXOMvXBjPhJYIzg1oga94mHaJs5AZ
vR9bkCBYMSYph2H8zeVwfzNy3uSoPx1aYOxYMftmcyWiI3SX5/afazsWz8LPlceK
zlhapxsx319cH/AUcYKIknRr+gscXOhumvMItuh1YxrcdA5Vl+tgA0Fu0K3sODDX
PpEpt4fqAGuoEWTGGXKwvPKs5K3bVXYxzwpv1K5OCB0dnZqCIhyPZE9Duc03mDWN
qqX3/i96SLzcRTKeMEBJAe14Tmefalwa3pNd032clV70S1Kb+HkTaB1rsG9IOckW
GyL8YeX9JHXw/P4+9nDOskZIY5/mDBoRPcbxKrJ1drOMdSH4MReZ33LAkYFgpxtl
+y5sv/C1OndDDU8Dc9wbJ4VPq3eALvwEU/b9S1OShrCXOxETh5I3G1r4t7FBx4pw
TTGNxotkE3qZ46f4q7ZGFvjg3MpcrahUfLqT3p27cVMK5K+3LEU=
=hPmV
-END PGP SIGNATURE-


Thank you for your contribution to Debian.



Processing of lintian_2.5.123~bpo9+1_amd64.changes

2019-01-24 Thread Debian FTP Masters
lintian_2.5.123~bpo9+1_amd64.changes uploaded successfully to localhost
along with the files:
  lintian_2.5.123~bpo9+1.dsc
  lintian_2.5.123~bpo9+1.tar.xz
  lintian_2.5.123~bpo9+1_all.deb
  lintian_2.5.123~bpo9+1_amd64.buildinfo

Greetings,

Your Debian queue daemon (running on host usper.debian.org)



[Git][lintian/lintian][stretch-backports] 41 commits: Open new changelog entry for 2.5.123.

2019-01-24 Thread Chris Lamb
Chris Lamb pushed to branch stretch-backports at lintian / lintian


Commits:
f1528fe0 by Chris Lamb at 2019-01-17T16:55:41Z
Open new changelog entry for 2.5.123.

- - - - -
0324556c by Chris Lamb at 2019-01-17T19:40:03Z
Check for inconsistencies between debian/copyright and the information 
embedded/duplicated in AppStream metadata files. Thanks to Daniel Kahn Gillmor 
for the idea. (Closes: #907072)

- - - - -
8508ef61 by Paul Wise at 2019-01-17T23:03:03Z
spelling: Add another correction

- - - - -
ce62604a by Chris Lamb at 2019-01-17T23:12:40Z
Prevent a large number false-positives when checking "new style" init 
scripts that use "#!/usr/bin/env /lib/init/init-d-script" as their 
shebang. (Closes: #919604)

- - - - -
eb5a0c0d by Paul Wise at 2019-01-18T03:31:45Z
spelling: Add another correction

- - - - -
fe67de11 by Paul Wise at 2019-01-19T00:10:36Z
spelling: Add another correction

- - - - -
cfabebb1 by Paul Wise at 2019-01-19T04:20:59Z
spelling: Add several corrections

- - - - -
988a8132 by Mike Miller at 2019-01-19T10:20:03Z
Reword the description of the description-too-long tag to match the actual 
check. (Closes: #919740, MR: !130)

Signed-off-by: Chris Lamb 

- - - - -
7cbc5efd by Niels Thykier at 2019-01-19T10:29:15Z
Migrate L::Unpacker to use IO::Async

We have to use the "simple" fork to avoid a deadlock in some
collections.  It seems to be a bit of feature interaction between
IO::Async and IPC::Run.  Nevertheless, with the $loop->fork variant,
it all works.

Signed-off-by: Niels Thykier 

- - - - -
14b2908e by Niels Thykier at 2019-01-19T10:29:15Z
L::Unpacker: Refactor to extract a "find_next_task"-sub(-generator)

Signed-off-by: Niels Thykier 

- - - - -
8a547e6a by Niels Thykier at 2019-01-19T10:29:17Z
lintian: Do entry removals asynchroniously in temp labs

Signed-off-by: Niels Thykier 

- - - - -
8a0d1d66 by Niels Thykier at 2019-01-19T10:29:17Z
L::Unpacker: Add a simple queue to avoid some overhead

Signed-off-by: Niels Thykier 

- - - - -
cd8bada7 by Niels Thykier at 2019-01-19T10:29:18Z
L::Unpacker: Support prioritizing unpacking by collections

Signed-off-by: Niels Thykier 

- - - - -
9b719dda by Niels Thykier at 2019-01-19T10:29:19Z
Apply perltidy

Signed-off-by: Niels Thykier 

- - - - -
c192da83 by Chris Lamb at 2019-01-19T12:14:55Z
Duplicate tests for package-contains-real-file-outside-usr into a new test. 
(re. MR: !128)

Gbp-dch: Ignore

- - - - -
43ab6dbe by Chris Lamb at 2019-01-19T12:14:55Z
Prevent false-positives for leading directory entries when checking for files 
installed outside of /usr. (re. MR: !128)

- - - - -
1b88453c by Chris Lamb at 2019-01-19T12:14:55Z
Move package-contains-real-file-outside-usr to "Classification" 
severity instead of a pedantic/experimental combination. (re. MR: !128)

- - - - -
93c118af by Chris Lamb at 2019-01-19T12:14:55Z
Rename package-contains-real-file-outside-usr to 
package-contains-usr-unmerged-pathnames. (re. MR: !128)

- - - - -
d48d72f0 by Paul Wise at 2019-01-20T00:17:07Z
spelling: Add several corrections

- - - - -
aed80274 by Felix Lechner at 2019-01-21T11:52:56Z
Rename template set tests-watchfile to debian-extra-non-native.

This template set will in the near future also hold other non-native
files, such as upstream/metadata. The name is no longer appropriate.
Renames the template set.

Signed-off-by: Chris Lamb 

- - - - -
c6db2d74 by Felix Lechner at 2019-01-21T11:53:15Z
Rename template set tests-pedantic to debian-native.

The name was created when the template sets was moved to a suite
independent location. In the near future, the set will hold only files
that are used in native packages. Renames the template set.

Signed-off-by: Chris Lamb 

- - - - -
ee4a8e49 by Felix Lechner at 2019-01-21T11:53:27Z
Use renamed template sets in skeletons for suite tests.

This modifies the skeleton for suite tests to use the new names for
the renamed template sets. It is part of a cleanup in templates.

Signed-off-by: Chris Lamb 

- - - - -
e60610d7 by Felix Lechner at 2019-01-21T11:53:35Z
Move upstream/metadata from debian-native to debian-extra-non-native.

In the future, all files used in non-native source packages will be
broken out in the template set debian-extra-non-native. Moves upstream
related files into the template set.

Signed-off-by: Chris Lamb 

- - - - -
7c0c60c0 by Felix Lechner at 2019-01-21T11:53:40Z
Use debian-native in suite source.

Suite source uses a template set that is similar to debian-native. Use
debian-native instead so that the other one can be deleted.

Signed-off-by: Chris Lamb 

- - - - -
07bf552f by Felix Lechner at 2019-01-21T11:53:43Z
Delete unused template set source-arch-independent.

This template set is no longer being used. Removes the template set.

Signed-off-by: Chris Lamb 

[Git][lintian/lintian] Pushed new tag 2.5.123_bpo9+1

2019-01-24 Thread Chris Lamb
Chris Lamb pushed new tag 2.5.123_bpo9+1 at lintian / lintian

-- 
View it on GitLab: https://salsa.debian.org/lintian/lintian/tree/2.5.123_bpo9+1
You're receiving this email because of your account on salsa.debian.org.


Bug#920314: lintian: vcs-field-has-unexpected-spaces has false positives

2019-01-24 Thread Mattia Rizzolo
On Wed, Jan 23, 2019 at 08:55:34PM -0500, Jeremy Bicha wrote:
> I think all of these are false positives except for rust-num-cpus.
> 
> https://lintian.debian.org/tags/vcs-field-has-unexpected-spaces.html

Really none of them are:

* vcs-git git://git.debian.org/mirrorer/inoticoming.git --branch debian
-> s/--branch/-b/
* vcs-git -b dpkg 
https://anonscm.debian.org/git/pkg-request-tracker/libmodule-install-rtx-perl.git
-> move the `-b dpkg` to the end, policy says it needs to be there
* vcs-hg http://youpibouh.thefreecat.org/loadlin/loadlin.hg/ -b debian
-> -b is not valid for vcs-hg according to policy
* vcs-git https://salsa.debian.org/rust-team/debcargo-conf.git src/num-cpus
-> this one probably wanted to wrap "src/nom-cpus" in square
brakets, as that's a syntax understood by vcswatch to say "inside
this subdirectory".  Not sure if lintian already knows of that, and
last I checked policy had yet to integrate that change.


So I think the only reasonable things to do here are only:
 * if you think -b is needed in vcs-hg, open a bug in policy
 * check if the "[subdirectory]" syntax is understood by lintian and
   check the progress status in policy

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature


Processed: Re: Bug#920314: lintian: vcs-field-has-unexpected-spaces has false positives

2019-01-24 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> tags 920314 + moreinfo
Bug #920314 [src:lintian] lintian: vcs-field-has-unexpected-spaces has false 
positives
Added tag(s) moreinfo.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
920314: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=920314
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#920314: lintian: vcs-field-has-unexpected-spaces has false positives

2019-01-24 Thread Chris Lamb
tags 920314 + moreinfo
thanks

Hi Jeremy,

> In particular, -b or --branch should be allowed

Curiously, Policy only permits "-b" (ie. not "--branch") in the
case of Vcs-Git. I infer that no other combination (eg. "--branch"
with Vcs-Hg is strictly legal Policy-wise.

To quote §5.6.26:

In the case of Git, the value consists of a URL, optionally
followed by the word -b and the name of a branch in the
indicated repository.

-- 
https://www.debian.org/doc/debian-policy/ch-controlfields.html#version-control-system-vcs-fields

Two questions:

  * Can you confirm that "hg clone  -b foo" works? If so, we
should update Policy to (at least) also permit "-b branchname"
or "[branchname]" for Mercurial repos.

  * Should we also petition for "--branch" to be in Policy too? I
don't see much value in that as, aesthetically, I prefer the
"[branchname]" syntax.

(Lintian can be updated orthogonal to all this, just tagging as
moreinfo so we don't end up reverting/changing this later.)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org 🍥 chris-lamb.co.uk
   `-