[Git][lintian/lintian][master] 9 commits: Update copyright years in debian/copyright

2022-06-11 Thread Axel Beckert (@abe)


Axel Beckert pushed to branch master at lintian / lintian


Commits:
1b26acec by Axel Beckert at 2022-06-11T17:00:27+02:00
Update copyright years in debian/copyright

… before lintian starts complaining about it. ;-)

- - - - -
648144e9 by Axel Beckert at 2022-06-11T18:59:43+02:00
Run perltidy over bin/lintian and private/{runtests,refresh-perl-provides}

Lintian's own tests t/scripts/01-critic/{bin,private}.t fail otherwise.

- - - - -
625526b0 by Axel Beckert at 2022-06-11T18:59:48+02:00
Remove unnecessary usage of UTF-8 from bin/lintian until 
https://github.com/Perl-Critic/Perl-Critic/issues/925 is fixed

- - - - -
a60e8001 by Axel Beckert at 2022-06-11T18:59:48+02:00
Run perltidy over t/scripts/{spellintian,…/hintextract,…/tag-coverage}.t

Lintian's own test t/scripts/01-critic/scripts.t fails otherwise.

- - - - -
5651c63f by Axel Beckert at 2022-06-11T19:24:51+02:00
Run perltidy over lib

Lintian's own test t/scripts/01-critic/libs.t fails otherwise.

It still fails, but no more for 167 files, now only for 64 files.

- - - - -
615d6623 by Axel Beckert at 2022-06-11T22:03:40+02:00
Replace UTF-8 characters in mostly Copyright comments until 
https://github.com/Perl-Critic/Perl-Critic/issues/925 is fixed

Actually all of them are copyright comment except for a single Unicode
SECTION SIGN character somewhere else.

- - - - -
1c04b37c by Axel Beckert at 2022-06-11T22:03:40+02:00
Replace UTF-8 characters in code with \N{…} until 
https://github.com/Perl-Critic/Perl-Critic/issues/925 is fixed

Lintian's own test t/scripts/01-critic/libs.t fails otherwise.

- - - - -
fe229196 by Axel Beckert at 2022-06-11T22:07:49+02:00
Remove literal unicode character U+0334 COMBINING TILDE OVERLAY which likely 
had been added accidentally

… slightly over 10 years ago and nobody noticed so far.

For more details see
https://lists.debian.org/msgid-search/20220611194509.ykyasxuwnss6m...@sym.noone.org

- - - - -
34198690 by Axel Beckert at 2022-06-11T22:13:50+02:00
data/…/perl-provides updated by running "d…/rules 
refresh-perl-provides"

- - - - -


30 changed files:

- bin/lintian
- data/fields/perl-provides
- debian/copyright
- lib/Lintian/Archive.pm
- lib/Lintian/Changelog.pm
- lib/Lintian/Check/Apache2.pm
- lib/Lintian/Check/ApplicationNotLibrary.pm
- lib/Lintian/Check/AppstreamMetadata.pm
- lib/Lintian/Check/Binaries/Architecture/Other.pm
- lib/Lintian/Check/Binaries/Hardening.pm
- lib/Lintian/Check/Binaries/LargeFileSupport.pm
- lib/Lintian/Check/Binaries/Location.pm
- lib/Lintian/Check/Binaries/Obsolete/Crypt.pm
- lib/Lintian/Check/Binaries/Prerequisites.pm
- lib/Lintian/Check/Binaries/Prerequisites/Numpy.pm
- lib/Lintian/Check/Binaries/Rpath.pm
- lib/Lintian/Check/Binaries/Spelling.pm
- lib/Lintian/Check/Binaries/Static.pm
- lib/Lintian/Check/BuildSystems/Autotools.pm
- lib/Lintian/Check/BuildSystems/Autotools/Libtool.pm
- lib/Lintian/Check/BuildSystems/Cmake.pm
- lib/Lintian/Check/BuildSystems/Waf.pm
- lib/Lintian/Check/Cruft.pm
- lib/Lintian/Check/DebFormat.pm
- lib/Lintian/Check/Debhelper.pm
- lib/Lintian/Check/Debian/Changelog.pm
- lib/Lintian/Check/Debian/Control/Field/BuiltUsing.pm
- lib/Lintian/Check/Debian/Control/Field/Relation.pm
- lib/Lintian/Check/Debian/Copyright.pm
- lib/Lintian/Check/Debian/Copyright/ApacheNotice.pm


The diff was not included because it is too large.


View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/compare/d53aff545cd8e66e5137e6f24a031cb8d1adad07...3419869095c6d8d05e7e770c0281af51855db3ef

-- 
View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/compare/d53aff545cd8e66e5137e6f24a031cb8d1adad07...3419869095c6d8d05e7e770c0281af51855db3ef
You're receiving this email because of your account on salsa.debian.org.




Literal Unicode COMBINING TILDE OVERLAY in checks/group-check.pm (now lib/Lintian/Check/GroupChecks.pm)

2022-06-11 Thread Axel Beckert
Hi Niels,

while hunting down the fallout of
https://github.com/Perl-Critic/Perl-Critic/issues/925 in Lintian's
test suite, I stumbled upon this confusing line of code:

98:join(' |̈́ ', $one->name, @provides_one));
[…]
108:join(' | ', $two->name, @provides_two));

Note that the joining string of the first join() contains the Unicode
character U+0334 "COMBINING TILDE OVERLAY" after the pipe.

Via "git blame" I traced the introduction of that character (and
actually both these lines) to this commit from 2012 (!):

commit 1d64fd8a88d18511d45af4e8fd64f4d4f38b43d3
Author: Niels Thykier 
Date:   Sat May 12 23:03:44 2012 +0200

group-check: Include Provides in the Conflicts check

Signed-off-by: Niels Thykier 

I will very likely remove that unexpected Unicode character because
— especially with the second line not having it — it just doesn't seem
to make any sense.

Nevertheless I would like to know if this was an accident which has
been undetected for 10 years (and one month :-) or if this COMBINING
TILDE OVERLAY character was added was on purpose. (In case of the
latter, I'd be very curious about that purpose. :-)

Kind regards, Axel
-- 
PGP: 2FF9CD59612616B5  /~\  Plain Text Ribbon Campaign, http://arc.pasp.de/
Mail: a...@deuxchevaux.org  \ /  Say No to HTML in E-Mail and Usenet
Mail+Jabber: a...@noone.org  X
https://axel.beckert.ch/   / \  I love long mails: https://email.is-not-s.ms/


signature.asc
Description: PGP signature


[Git][lintian/lintian][master] Replace all occurrences of "Copyright ©" with "Copyright (C)" again until...

2022-06-11 Thread Axel Beckert (@abe)


Axel Beckert pushed to branch master at lintian / lintian


Commits:
d53aff54 by Axel Beckert at 2022-06-11T16:49:27+02:00
Replace all occurrences of "Copyright ©" with "Copyright 
(C)" again until https://github.com/Perl-Critic/Perl-Critic/issues/925 is 
fixed

This more or less reverts 1a3f6eeeaef3f31aa28e699a82f509b7a7d50fc3
(Replace "Copyright (C)" with the Unicode copyright symbol in our own
code for consistency.) for now.

- - - - -


30 changed files:

- bin/lintian
- bin/lintian-annotate-hints
- bin/lintian-explain-tags
- bin/spellintian
- commands/reporting-harness.pm
- commands/reporting-html-reports.pm
- commands/reporting-lintian-harness.pm
- commands/reporting-sync-state.pm
- lib/Lintian/Archive.pm
- lib/Lintian/Changelog.pm
- lib/Lintian/Changelog/Entry.pm
- lib/Lintian/Changelog/Version.pm
- lib/Lintian/Check.pm
- lib/Lintian/Check/Apache2.pm
- lib/Lintian/Check/ApplicationNotLibrary.pm
- lib/Lintian/Check/AppstreamMetadata.pm
- lib/Lintian/Check/Apt.pm
- lib/Lintian/Check/Archive/File/Name/Length.pm
- lib/Lintian/Check/Archive/Liberty/Mismatch.pm
- lib/Lintian/Check/Archive/NonFree/Autobuild.pm
- lib/Lintian/Check/Binaries.pm
- lib/Lintian/Check/Binaries/Architecture.pm
- lib/Lintian/Check/Binaries/Architecture/Other.pm
- lib/Lintian/Check/Binaries/Corrupted.pm
- lib/Lintian/Check/Binaries/DebugSymbols.pm
- lib/Lintian/Check/Binaries/DebugSymbols/Detached.pm
- lib/Lintian/Check/Binaries/Hardening.pm
- lib/Lintian/Check/Binaries/LargeFileSupport.pm
- lib/Lintian/Check/Binaries/Location.pm
- lib/Lintian/Check/Binaries/Obsolete/Crypt.pm


The diff was not included because it is too large.


View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/commit/d53aff545cd8e66e5137e6f24a031cb8d1adad07

-- 
View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/commit/d53aff545cd8e66e5137e6f24a031cb8d1adad07
You're receiving this email because of your account on salsa.debian.org.




Bug#999768: lintian: false report: adopted-extended-field

2022-06-11 Thread Axel Beckert
Hi Francesco,

Francesco Poli wrote:
> More than 6 months later, it seems that this bug is still unfixed in
> lintian: running lintian/2.114.0 produces the same complaints.

Correct.

See https://bugs.debian.org/1012289 formerly known as "O: lintian".

> Is there any hope this bug can get fixed soon, along with the other RC
> bugs currently open against lintian, so that lintian can work better in
> sid (and also migrate to testing, see bug [#1003643] ...)?

I'm now working on a new lintian release and I will work on the
currently open RC bugs.


> By the way: a new version (4.6.1) of Debian Policy has been released

No wonder if noone was working on Lintian proper. There's a pull
request for this
(https://salsa.debian.org/lintian/lintian/-/merge_requests/393),
though and I'll likely merge it once I fixed the more severe and more
pressing issues, namely failing the failing autopkgtests in current
git HEAD (first) and the RC bug reports (second).

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE



Bug#1011057: marked as done (lintian: Add warning if a *.postinst file does not have #DEBHELPER#)

2022-06-11 Thread Debian Bug Tracking System
Your message dated Sat, 11 Jun 2022 15:06:21 +0200
with message-id <20220611130620.irdj3n5jhmzce...@sym.noone.org>
and subject line Re: Bug#1011057: lintian: Add warning if a *.postinst file 
does not have #DEBHELPER#
has caused the Debian Bug report #1011057,
regarding lintian: Add warning if a *.postinst file does not have #DEBHELPER#
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1011057: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1011057
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Version: 2.104.0
Severity: wishlist

Dear Maintainer,

It might be useful that lintian checked that each *.postinst contains
the #DEBHELPER# string.

For example, I noticed a missing #DEBHELPER# when creating a package
that installed a systemd service but it did not start as expected.

Thank you very much,

-- System Information:
Debian Release: 11.3
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-security')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-13-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=ca_ES.UTF-8, LC_CTYPE=ca_ES.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils2.35.2-2
ii  bzip2   1.0.8-4
ii  diffstat1.64-1
ii  dpkg1.20.9
ii  dpkg-dev1.20.9
ii  file1:5.39-3
ii  gettext 0.21-4
ii  gpg 2.2.27-2+deb11u1
ii  intltool-debian 0.35.0+20060710.5
ii  libapt-pkg-perl 0.1.39
ii  libarchive-zip-perl 1.68-1
ii  libcapture-tiny-perl0.48-1
ii  libclass-xsaccessor-perl1.19-3+b7
ii  libclone-perl   0.45-1+b1
ii  libconfig-tiny-perl 2.26-1
ii  libcpanel-json-xs-perl  4.25-1+b1
ii  libdata-dpath-perl  0.58-1
ii  libdata-validate-domain-perl0.10-1.1
ii  libdevel-size-perl  0.83-1+b2
ii  libdpkg-perl1.20.9
ii  libemail-address-xs-perl1.04-1+b3
ii  libfile-basedir-perl0.08-1
ii  libfile-find-rule-perl  0.34-1
ii  libfont-ttf-perl1.06-1.1
ii  libhtml-html5-entities-perl 0.004-1.1
ii  libipc-run3-perl0.048-2
ii  libjson-maybexs-perl1.004003-1
ii  liblist-compare-perl0.55-1
ii  liblist-moreutils-perl  0.430-2
ii  liblist-utilsby-perl0.11-1
ii  libmoo-perl 2.004004-1
ii  libmoox-aliases-perl0.001006-1.1
ii  libnamespace-clean-perl 0.27-1
ii  libpath-tiny-perl   0.118-1
ii  libperlio-gzip-perl 0.19-1+b7
ii  libproc-processtable-perl   0.59-2+b1
ii  libsereal-decoder-perl  4.018+ds-1+b1
ii  libsereal-encoder-perl  4.018+ds-1+b1
ii  libtext-glob-perl   0.11-1
ii  libtext-levenshteinxs-perl  0.03-4+b8
ii  libtext-markdown-discount-perl  0.12-1+b1
ii  libtext-xslate-perl 3.5.8-1+b1
ii  libtime-duration-perl   1.21-1
ii  libtime-moment-perl 0.44-1+b3
ii  libtimedate-perl2.3300-2
ii  libtry-tiny-perl0.30-1
ii  libtype-tiny-perl   1.012001-2
ii  libunicode-utf8-perl0.62-1+b2
ii  liburi-perl 5.08-1
ii  libxml-libxml-perl  2.0134+dfsg-2+b1
ii  libyaml-libyaml-perl0.82+repack-1+b1
ii  lzip1.22-3
ii  lzop1.04-2
ii  man-db  2.9.4-2
ii  patchutils  0.4.2-1
ii  perl [libdigest-sha-perl]   5.32.1-4+deb11u2
ii  t1utils 1.41-4
ii  unzip   6.0-26
ii  xz-utils5.2.5-2

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch 
pn  libtext-template-perl  

-- no debconf information
--- End Message ---
--- Begin Message ---
Control: notfound -1 2.104.0

Hi Carles,

Carles Pina i Estany wrote:
> > https://lintian.debian.org/tags/maintainer-script-lacks-debhelper-token
[…]
> I had a look at lintian's source code and realised of what happened.
> (I'm testing and reading lintian v2.104.0)
> 
> I was running:
> $ lintian package.deb # on the binary package
> 
> If I run:
> $ li