Processed: Bug#1003353 marked as pending in lintian
Processing control commands: > tag -1 pending Bug #1003353 [lintian] lintian: Cannot use brackets in suppression rules? Ignoring request to alter tags of bug #1003353 to the same tags previously set -- 1003353: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003353 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Re: Bug#1003353: lintian: Cannot use brackets in suppression rules?
Processing control commands: > tag -1 + pending patch Bug #1003353 [lintian] lintian: Cannot use brackets in suppression rules? Added tag(s) patch. -- 1003353: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003353 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#1003353: lintian: Cannot use brackets in suppression rules?
Control: tag -1 + pending patch
Hi Samuel,
Samuel Thibault wrote:
> Seeing that qa.debian.org is using version 2.114.123 of lintian, I
> upgraded my lintian from its git tree, only to find that it seems I
> cannot update my suppression rule according to the new output:
>
> W: libbrlapi-dev: bad-whatis-entry
> [usr/share/man/man3/brlapi_authClientPacket_t.3.gz]
> W: libbrlapi-dev: mismatched-override bad-whatis-entry
> [usr/share/man/man3/brlapi_*] [usr/share/lintian/overrides/libbrlapi-dev:2]
>
> I did have updated this rule to include brackets:
>
> bad-whatis-entry [usr/share/man/man3/brlapi_*]
>
> but that doesn't seem to be working. I also tried to use escaping (which
> had fixed things for the ${} case), but to no avail:
>
> bad-whatis-entry \[usr/share/man/man3/brlapi_*\]
Using * or ? in place of the brackets probably would have worked.
Cause was the switch of was this commit from 6 months ago:
commit 139009d5a54225ebff4509ec37b979cb898c17fe
Author: Felix Lechner
Date: Wed Dec 1 21:46:24 2021 -0800
Use Text::Glob to match hint contexts with override patterns.
Replaces a trusted homegrown routine.
Gbp-Dch: ignore
I neither understand why you would replace something "trusted" and
additionally not even plan to mention such a invasive commit in the
changelog.
And because Text::Glob also interprets brackets (and curly braces) and
you can't disable that, such issues were just waiting to happen.
And together with the brackets using "pointed hints" concept
introduced at around the same time, this caused really havoc.
> Lintian has recently been annoying enough that I'm unsure I'd continue
> monitoring its output any more.
*nod* JFYI, in case you didn't notice it (it happend months after your
bug report), but there was an "O: lintian" WNPP bug report in the
meantime: https://bugs.debian.org/1012289
So I'm now trying to clean up the shattered remains which the previous
(recent) Lintian maintainer(s) left behind.
For now I'm trying to get a current lintian version back into Testing,
i.e. I'm concentrating on RC and important bugs as well as bugs which
are annoying and easy to fix, e.g. those with a patch or MR.
At least the lintian internal test suite is no more failing. Although
it likely has some false negatives as it seems that the test suite is
no more able to run more than one check in one test. And running a
test against multiple checks at the same time seems critical to write
tests for issues like this one. Meh.
Anyway, my feature branch for this bug report is
https://salsa.debian.org/lintian/lintian/-/commits/brackets-in-overrides-rc-bug-1003353
but I will likely force-push that branch some more times, so the
commit message in
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003353#50 might
become stale soon while I refine the commit before that (which
contains a test for this bug), but the patch will likely stay valid.
You also might get further such mails when I force-push new histories
in that feature branch. I hope you don't mind, but I wanted to publish
what I already have.
Regards, Axel
--
,''`. | Axel Beckert , https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
signature.asc
Description: PGP signature
[Git][lintian/lintian] Pushed new branch brackets-in-overrides-rc-bug-1003353
Axel Beckert pushed new branch brackets-in-overrides-rc-bug-1003353 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/brackets-in-overrides-rc-bug-1003353 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] README.developers.pod: Explain the difference between a check and a test
Axel Beckert pushed to branch master at lintian / lintian Commits: f28bde63 by Axel Beckert at 2022-06-20T01:32:51+02:00 README.developers.pod: Explain the difference between a check and a test - - - - - 1 changed file: - doc/README.developers.pod Changes: = doc/README.developers.pod = @@ -100,6 +100,11 @@ most important ones: =over 4 +=item Check + +A library checking specific aspects of a package, changes file, +etc. which usually can emit multiple tags. + =item Emit (Tag) Tag that was not suppressed and was triggered. @@ -133,6 +138,10 @@ counted in statistics. Not to be confused with "Overridden". Issue reported by Lintian. +=item Test + +An internal test of Lintian. + =back =head2 Useful tricks View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f28bde63f1c4c00ddaf65b80ba4aee10186d205b -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f28bde63f1c4c00ddaf65b80ba4aee10186d205b You're receiving this email because of your account on salsa.debian.org.
Processed: Bug#1003353 marked as pending in lintian
Processing control commands: > tag -1 pending Bug #1003353 [lintian] lintian: Cannot use brackets in suppression rules? Added tag(s) pending. -- 1003353: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003353 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Re: tagging 1012326, tagging 1012690, tagging 1012464, tagging 1001317, tagging 1012221, tagging 1011807 ...
Processing control commands: > notfound 1003353 2.114.0 Bug #1003353 [lintian] lintian: Cannot use brackets in suppression rules? No longer marked as found in versions lintian/2.114.0. -- 1003353: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003353 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#1003353: tagging 1012326, tagging 1012690, tagging 1012464, tagging 1001317, tagging 1012221, tagging 1011807 ...
Control: notfound 1003353 2.114.0 Hi Andreas, Andreas Beckmann wrote: > found 1003353 2.114.0 please explain what makes you think that this issue is present in lintian 2.114.0 as currently in Debian Unstable. The submitter clearly said he ran into it when he bumped his lintian copy to git HEAD. And as far as I can see that problem is only present if Lintian uses Text::Glob for evaluating wildcards in overrides and that got introduced 32 commits _AFTER_ the 2.114.0 release: commit 139009d5a54225ebff4509ec37b979cb898c17fe Author: Felix Lechner Date: Wed Dec 1 21:46:24 2021 -0800 Use Text::Glob to match hint contexts with override patterns. Replaces a trusted homegrown routine. Gbp-Dch: ignore (No idea why this was marked "Gbp-Dch: Ignore" as it has quite some impact, also on dependencies and build-dependencies. *grrr*) And: ~/lintian/lintian → git describe 139009d5a54225ebff4509ec37b979cb898c17fe 2.114.0-32-g139009d5a ^^ Which is the reason why I marked this bug report as NOT being found in 2.114.0 a few days ago. (And now again.) So please refrain from marking this specific bug report as found in 2.114.0 again unless you have a really good reason to do so. Thanks in advance! Regards, Axel -- ,''`. | Axel Beckert , https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE signature.asc Description: PGP signature
