[lintian] 03/03: Warn about renamed tag
This is an automated email from the git hooks/post-receive script.
rouca pushed a commit to branch tagrename
in repository lintian.
commit ab1af5d4ab4a9b42f335576aa3c9fe21867f19eb
Author: Bastien ROUCARIÈS
Date: Sat Aug 15 22:56:25 2015 +0200
Warn about renamed tag
Signed-off-by: Bastien ROUCARIÈS
---
checks/lintian.desc | 10 ++
lib/Lintian/Tags.pm | 9 +++--
t/tests/overrides-shown/desc | 3 ++-
t/tests/overrides-shown/tags | 1 +
t/tests/overrides/desc | 2 ++
t/tests/overrides/tags | 1 +
6 files changed, 23 insertions(+), 3 deletions(-)
diff --git a/checks/lintian.desc b/checks/lintian.desc
index 3b57382..15c93d7 100644
--- a/checks/lintian.desc
+++ b/checks/lintian.desc
@@ -18,6 +18,16 @@ Info: Lintian discovered an unused override entry in its
database.
If the override is unused, please remove it from the overrides file.
+Tag: renamed-override
+Severity: pedantic
+Certainty: certain
+Info: Lintian discovered an renamed override entry in its database.
+ Lintian tag are sometime renamed in order to improve description.
+ .
+ Override file is dynamically translated by lintian. Nevertheless
+ please replace the old name by the new name.
+
+
Tag: malformed-override
Severity: important
Certainty: certain
diff --git a/lib/Lintian/Tags.pm b/lib/Lintian/Tags.pm
index b0ef395..65590bd 100644
--- a/lib/Lintian/Tags.pm
+++ b/lib/Lintian/Tags.pm
@@ -605,7 +605,8 @@ sub file_overrides {
next unless $found;
}
-if ($last_over && $last_over->tag eq $rawtag && !scalar
@$comments) {
+if ($last_over && $last_over->tag eq $rawtag && !scalar @$comments)
+{
# There are no new comments, no "empty line" in between and
# this tag is the same as the last, so we "carry over" the
# comment from the previous override (if any).
@@ -624,8 +625,12 @@ sub file_overrides {
# tag will be changed here if renamed reread
$tag = $tagover->{'tag'};
+unless($tag eq $rawtag) {
+tag('renamed-override',"$rawtag => $tag at line $.");
+}
+
# treat here ignored overrides
- if ($profile && !$profile->is_overridable($tag)) {
+if ($profile && !$profile->is_overridable($tag)) {
$self->{ignored_overrides}{$tag}++;
next;
}
diff --git a/t/tests/overrides-shown/desc b/t/tests/overrides-shown/desc
index 3becd5f..d44a42a 100644
--- a/t/tests/overrides-shown/desc
+++ b/t/tests/overrides-shown/desc
@@ -1,7 +1,8 @@
Testname: overrides-shown
Sequence: 1500
Version: 1.0
-Options: --show-overrides -I -E
+Skeleton: pedantic
+Options: --pedantic --show-overrides -I -E
Sort: no
Architecture: any
Description: Test override handling
diff --git a/t/tests/overrides-shown/tags b/t/tests/overrides-shown/tags
index 075742d..1ae7b6d 100644
--- a/t/tests/overrides-shown/tags
+++ b/t/tests/overrides-shown/tags
@@ -1,3 +1,4 @@
+P: overrides-shown: renamed-override package-install-apt-sources =>
package-installs-apt-sources at line 18
N: renamed tag
O: overrides-shown: package-installs-apt-sources etc/apt/sources.list.d/
N: renamed tag
diff --git a/t/tests/overrides/desc b/t/tests/overrides/desc
index e27a624..a1edb0a 100644
--- a/t/tests/overrides/desc
+++ b/t/tests/overrides/desc
@@ -1,5 +1,7 @@
Testname: overrides
Sequence: 1500
Version: 1.0
+Skeleton: pedantic
+Options: --pedantic -I -E
Description: Test override handling
Architecture: any
diff --git a/t/tests/overrides/tags b/t/tests/overrides/tags
index 8cbb094..0557d93 100644
--- a/t/tests/overrides/tags
+++ b/t/tests/overrides/tags
@@ -2,3 +2,4 @@ I: overrides: FSSTND-dir-in-manual-page
usr/share/man/man1/foo.1.gz:12 /usr/info
I: overrides: FSSTND-dir-in-manual-page usr/share/man/man1/foo.1.gz:13
/usr/man/
I: overrides: FSSTND-dir-in-manual-page usr/share/man/man1/foo.1.gz:14
/usr/adm/
N: 12 tags overridden (2 errors, 1 warning, 9 info)
+P: overrides: renamed-override package-install-apt-sources =>
package-installs-apt-sources at line 18
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Avoid false positive for sensible-utils itself
This is an automated email from the git hooks/post-receive script.
rouca pushed a commit to branch master
in repository lintian.
commit 35b69820edd338e526c1d04b3bdf91c7812b24cb
Author: Bastien ROUCARIÈS
Date: Mon Mar 12 13:46:18 2018 +0100
Avoid false positive for sensible-utils itself
---
checks/scripts.pm | 3 ++-
debian/changelog | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/checks/scripts.pm b/checks/scripts.pm
index 8fcc1d0..1b5d96d 100644
--- a/checks/scripts.pm
+++ b/checks/scripts.pm
@@ -249,7 +249,8 @@ sub run {
my $str_deps = $info->relation('strong');
my $has_sensible_utils
=Lintian::Relation->and($str_deps, $info->relation('recommends'))
- ->implies('sensible-utils');
+ ->implies('sensible-utils')
+ || ($pkg eq 'sensible-utils');
for my $filename (sort keys %{$info->scripts}) {
my $interpreter = $info->scripts->{$filename}{interpreter};
diff --git a/debian/changelog b/debian/changelog
index 550a932..5abe532 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -11,6 +11,8 @@ lintian (2.5.80) UNRELEASED; urgency=medium
package has explicit Build-Depends on dpkg-dev (>= 1.18.8) or
debhelper (>= 10.10). Thanks to Andreas Metzler for the report.
(Closes: #892549)
+ * checks/script.pm:
++ [BR] Fix FP with sensible-utils need to depends on sensible-utils.
* checks/fields.{desc,pm}:
+ [CL] Clarify the meaning of the
depends-on-build-essential-package-without-using-version tag by
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/02: Read file as a whole for utf8 testing
This is an automated email from the git hooks/post-receive script.
rouca pushed a commit to branch utf8fix
in repository lintian.
commit 7c1c0565ab32869788107efb359078ca90c1fb6b
Author: Bastien ROUCARIÈS
Date: Tue Jul 21 23:31:42 2015 +0200
Read file as a whole for utf8 testing
Avoid a test failure latter
---
lib/Test/Lintian.pm | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/lib/Test/Lintian.pm b/lib/Test/Lintian.pm
index 68cbb6e..4566152 100644
--- a/lib/Test/Lintian.pm
+++ b/lib/Test/Lintian.pm
@@ -77,7 +77,7 @@ use Lintian::Profile;
use Lintian::Tag::Info;
use Lintian::Tags;
use Lintian::Util
- qw(read_dpkg_control slurp_entire_file is_string_utf8_encoded);
+ qw(read_dpkg_control slurp_entire_file file_is_encoded_in_non_utf8);
# We want data files loaded early to avoid problems with missing data
# files ending up in releases (like in 2.5.17 and 2.5.18).
@@ -174,6 +174,14 @@ sub test_check_desc {
foreach my $desc_file (map { _find_check($find_opt, $_) } @descs) {
my ($header, @tagpara);
+# check utf-8
+my $not_utf8_line = file_is_encoded_in_non_utf8($path);
+if ($not_utf8_line) {
+$builder->ok(0, "$desc_file is not utf-8");
+$builder->diag("Error: line $not_utf8_line");
+next;
+}
+
eval {($header, @tagpara) = read_dpkg_control($desc_file);};
if (my $err = $@) {
$err =~ s/ at .*? line \d+\s*\n//;
@@ -339,11 +347,6 @@ sub test_check_desc {
or $builder->diag("$content_type $cname: $tag ($1)\n");
}
-$builder->ok(
-is_string_utf8_encoded($info),
-'Tag info must be written in UTF-8'
-) or $builder->diag("$content_type $cname: $tag\n");
-
# Check the tag info for unescaped <> or for unknown tags (which
# probably indicate the same thing).
while ($info =~ s,<([^\s>]+)(?:\s+href=\"[^\"]+\")?>.*?,,s) {
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] 02/02: read_dpkg_control using utf8
This is an automated email from the git hooks/post-receive script.
rouca pushed a commit to branch utf8fix
in repository lintian.
commit c163818e0d98b104922979b4fc8f01621e35e64c
Author: Bastien ROUCARIÈS
Date: Tue Jul 21 23:36:11 2015 +0200
read_dpkg_control using utf8
Avoid mojibake on html page
---
lib/Lintian/Util.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Lintian/Util.pm b/lib/Lintian/Util.pm
index 2b6e9e4..8eb35b2 100644
--- a/lib/Lintian/Util.pm
+++ b/lib/Lintian/Util.pm
@@ -619,7 +619,7 @@ autodie exceptions if open or close fails.
sub read_dpkg_control {
my ($file, $flags, $lines) = @_;
-open(my $CONTROL, '<', $file);
+open(my $CONTROL, '<:encoding(utf8)', $file);
my @data = parse_dpkg_control($CONTROL, $flags, $lines);
close($CONTROL);
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Detect wasm prebuilt file
This is an automated email from the git hooks/post-receive script.
rouca pushed a commit to branch wasm
in repository lintian.
commit 6182305d061d1042e3a2008b43f9994a3e55dbd6
Author: Bastien ROUCARIÈS
Date: Fri Feb 2 10:48:37 2018 +0100
Detect wasm prebuilt file
wasm have the potential to be like minified javascript.
Detect early
---
checks/cruft.desc | 12
data/cruft/warn-file-type | 1 +
debian/changelog | 1 +
t/tests/cruft-wasm/desc| 10 ++
t/tests/cruft-wasm/pre_upstream| 11 +++
t/tests/cruft-wasm/tags| 2 ++
t/tests/cruft-wasm/upstream/README | 1 +
7 files changed, 38 insertions(+)
diff --git a/checks/cruft.desc b/checks/cruft.desc
index 40c6cae..ab55382 100644
--- a/checks/cruft.desc
+++ b/checks/cruft.desc
@@ -537,6 +537,18 @@ Info: The source tarball contains a prebuilt binary for
Microsoft Windows.
the upstream distribution instead. If not, you may want to ask upstream
to provide source-only tarballs.
+Tag: source-contains-prebuilt-wasm-binary
+Severity: pedantic
+Certainty: certain
+Info: The source tarball contains a prebuilt binary wasm object.
+ They are usually provided for the convenience of users. These files
+ usually just take up space in the tarball and need to be rebuilt from
+ source.
+ .
+ Check if upstream also provides source-only tarballs that you can use as
+ the upstream distribution instead. If not, you may want to ask upstream
+ to provide source-only tarballs.
+
Tag: source-contains-waf-binary
Severity: important
Certainty: certain
diff --git a/data/cruft/warn-file-type b/data/cruft/warn-file-type
index 22b9c36..dd60910 100644
--- a/data/cruft/warn-file-type
+++ b/data/cruft/warn-file-type
@@ -15,3 +15,4 @@ source-contains-prebuilt-javascript-object ~~ .*
source-contains-prebuilt-python-object ~~ ^python \s \d(\.\d+)? \s
byte-compiled~~ .*
~~ s/(?i)(?:\.cpython-\d{2}|\.pypy)?\.py[co]$/.py/
source-contains-prebuilt-silverlight-object ~~ ^Zip \s archive \s data
~~ (?i)\.xac$
source-contains-prebuilt-windows-binary ~~
\b(?:PE(?:32|64)|(?:MS-DOS|COFF)\s executable)\b
+source-contains-prebuilt-wasm-binary~~ ^WebAssembly \s \(wasm\) \s
binary \s module
diff --git a/debian/changelog b/debian/changelog
index 61ca98f..2bdb566 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -7,6 +7,7 @@ lintian (2.5.73) UNRELEASED; urgency=medium
check "src/foo/bar.js". (Closes: #832027)
+ [CL] Check for upstream tarballs that ship examples but none is
installed in any binary package. (Closes: #539326)
++ [BR] Check for wasm file. (Closes: #889102)
* checks/debian-source-dir.desc:
+ [CL] Upgrade severity of missing-debian-source-format from wishlist
("I") to normal ("W"). (Closes: #702671)
diff --git a/t/tests/cruft-wasm/desc b/t/tests/cruft-wasm/desc
new file mode 100644
index 000..d9cf8dd
--- /dev/null
+++ b/t/tests/cruft-wasm/desc
@@ -0,0 +1,10 @@
+Testname: cruft-wasm
+Version: 1.0-1
+Description: Misc errors related to wasm
+Skeleton: pedantic
+Options: --pedantic -I -E
+Architecture: any
+Type: non-native
+Test-For:
+ source-contains-prebuilt-wasm-binary
+Test-Depends: file (>= 1:5.32)
diff --git a/t/tests/cruft-wasm/pre_upstream b/t/tests/cruft-wasm/pre_upstream
new file mode 100755
index 000..12344f9
--- /dev/null
+++ b/t/tests/cruft-wasm/pre_upstream
@@ -0,0 +1,11 @@
+#!/bin/sh
+#
+# Create all the various junk that shouldn't exist in the diff so that we can
+# trigger all the tags.
+
+set -e
+dir="$1"
+srcdir="$1"
+
+printf "\0asm\001\0\0\0" > "$srcdir/fake.wasm"
+
diff --git a/t/tests/cruft-wasm/tags b/t/tests/cruft-wasm/tags
new file mode 100644
index 000..3401a43
--- /dev/null
+++ b/t/tests/cruft-wasm/tags
@@ -0,0 +1,2 @@
+P: cruft-wasm source: debian-watch-does-not-check-gpg-signature
+P: cruft-wasm source: source-contains-prebuilt-wasm-binary fake.wasm
diff --git a/t/tests/cruft-wasm/upstream/README
b/t/tests/cruft-wasm/upstream/README
new file mode 100644
index 000..a6a4fce
--- /dev/null
+++ b/t/tests/cruft-wasm/upstream/README
@@ -0,0 +1 @@
+This include fake wasm file
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] 02/03: Rename variable $tag to $rawtag in order to clarify code
This is an automated email from the git hooks/post-receive script.
rouca pushed a commit to branch tagrename
in repository lintian.
commit 8fc290d5c5b07ee519669c7e367b6bf15f5f35dc
Author: Bastien ROUCARIÈS
Date: Sat Aug 15 22:42:16 2015 +0200
Rename variable $tag to $rawtag in order to clarify code
Signed-off-by: Bastien ROUCARIÈS
---
lib/Lintian/Tags.pm | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/lib/Lintian/Tags.pm b/lib/Lintian/Tags.pm
index 13c5612..b0ef395 100644
--- a/lib/Lintian/Tags.pm
+++ b/lib/Lintian/Tags.pm
@@ -548,14 +548,15 @@ sub file_overrides {
) {
# Valid - so far at least
my ($opkg_name, $archlist, $opkg_type, $tagdata)= ($1, $2, $3, $4);
-my ($tag, $extra) = split(m/ /o, $tagdata, 2);
+my ($rawtag, $extra) = split(m/ /o, $tagdata, 2);
+my $tag;
my $tagover;
my $data;
if ($opkg_type and $opkg_type ne $info->{type}) {
tag(
'malformed-override',
join(q{ },
-"Override of $tag for package type $opkg_type",
+"Override of $rawtag for package type $opkg_type",
"(expecting $info->{type}) at line $."));
next;
}
@@ -564,7 +565,7 @@ sub file_overrides {
'malformed-override',
join(q{ },
'Architecture list for arch:all package',
-"at line $. (for tag $tag)"));
+"at line $. (for tag $rawtag)"));
next;
}
if ($archlist) {
@@ -584,7 +585,7 @@ sub file_overrides {
'malformed-override',
join(q{ },
"Unknown architecture \"$a\"",
-"at line $. (for tag $tag)"));
+"at line $. (for tag $rawtag)"));
next OVERRIDE;
}
}
@@ -594,7 +595,7 @@ sub file_overrides {
'malformed-override',
join(q{ },
'Inconsistent architecture negation',
-"at line $. (for tag $tag)"));
+"at line $. (for tag $rawtag)"));
next;
}
# missing wildcard checks and sanity checking archs $arch
@@ -604,7 +605,7 @@ sub file_overrides {
next unless $found;
}
-if ($last_over && $last_over->tag eq $tag && !scalar @$comments) {
+if ($last_over && $last_over->tag eq $rawtag && !scalar
@$comments) {
# There are no new comments, no "empty line" in between and
# this tag is the same as the last, so we "carry over" the
# comment from the previous override (if any).
@@ -619,7 +620,7 @@ sub file_overrides {
'comments' => $comments,
};
$comments = [];
-$tagover = Lintian::Tag::Override->new($tag, $data);
+$tagover = Lintian::Tag::Override->new($rawtag, $data);
# tag will be changed here if renamed reread
$tag = $tagover->{'tag'};
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Detect if license-short-name are unique in source copyright
This is an automated email from the git hooks/post-receive script.
rouca pushed a commit to branch unique
in repository lintian.
commit 642508bccd1029e399be302e30145982a98ce10e
Author: Bastien ROUCARIÈS
Date: Sun Nov 16 19:50:44 2014 +0100
Detect if license-short-name are unique in source copyright
Signed-off-by: Bastien ROUCARIÈS
---
checks/source-copyright.desc | 9
checks/source-copyright.pm | 17 +-
debian/changelog | 3 ++-
t/tests/source-copyright-unique/debian/NEWS| 1 +
t/tests/source-copyright-unique/debian/README | 1 +
.../debian/debian/copyright| 27 ++
t/tests/source-copyright-unique/desc | 6 +
t/tests/source-copyright-unique/tags | 5
8 files changed, 67 insertions(+), 2 deletions(-)
diff --git a/checks/source-copyright.desc b/checks/source-copyright.desc
index 59c4459..914ff34 100644
--- a/checks/source-copyright.desc
+++ b/checks/source-copyright.desc
@@ -252,6 +252,15 @@ Info: One of the file paragraph reference in the
or short names followed by license exceptions making up
the first line must be described in stand-alone License paragraphs.
+Tag: dep5-copyright-license-name-not-unique
+Severity: normal
+Certainty: possible
+Ref: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Info: This paragraph define an already defined license.
+ .
+ According to specification the short license name are guaranteed
+ to be unique within a single copyright file.
+
Tag: invalid-escape-sequence-in-dep5-copyright
Severity: normal
Certainty: possible
diff --git a/checks/source-copyright.pm b/checks/source-copyright.pm
index 5e60197..2eda3b4 100644
--- a/checks/source-copyright.pm
+++ b/checks/source-copyright.pm
@@ -231,6 +231,7 @@ sub _parse_dep5 {
my %standalone_licenses;
my %required_standalone_licenses;
my %short_licenses_seen;
+my %full_licenses_seen;
for my $field (keys %{$first_para}) {
my $renamed_to = $dep5_renamed_fields{$field};
@@ -255,6 +256,7 @@ sub _parse_dep5 {
if(defined($full_license_header)) {
for (@short_licenses_header) {
$standalone_licenses{$_} = 1;
+$full_licenses_seen{$_} = 1;
}
}
@@ -296,7 +298,13 @@ sub _parse_dep5 {
"(paragraph at line $current_line)";
}else {
for (@short_licenses) {
-$standalone_licenses{$_} = $i;
+if(defined($full_licenses_seen{$_})) {
+tag 'dep5-copyright-license-name-not-unique',
+ "(paragraph at line $current_line)";
+} else {
+$standalone_licenses{$_} = $i;
+$full_licenses_seen{$_} = $current_line;
+}
$short_licenses_seen{$_} = $i;
}
}
@@ -382,6 +390,13 @@ sub _parse_dep5 {
$short_licenses_seen{$_} = $i;
if (not defined($full_license)) {
$required_standalone_licenses{$_} = $i;
+} else {
+if(defined($full_licenses_seen{$_})) {
+tag 'dep5-copyright-license-name-not-unique',
+ "(paragraph at line $current_line)";
+} else {
+$full_licenses_seen{$_} = $current_line;
+}
}
}
}else {
diff --git a/debian/changelog b/debian/changelog
index f5b3067..9b4e28b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,12 +3,13 @@ lintian (2.5.31) UNRELEASED; urgency=medium
* checks/fields.desc:
+ [BR] Add reference to build-depends-on-metapackage
(Closes: #767107).
- * checks/source-copyright.pm:
+ * checks/source-copyright.{desc,pm}:
+ [BR] Fix a false positive for
missing-license-paragraph-in-dep5-copyright tag.
Do not allow to reference header paragraph,
emit a specific tag.
(Closes: #766118).
++ [BR] Detect if license short name are unique.
* collection/strings:
+ [NT] Pass "-a" to strings to avoid possible security
diff --git a/t/tests/source-copyright-unique/debian/NEWS
b/t/tests/source-copyright-unique/debian/NEWS
new file mode 100644
index 000..8a7f3d9
--- /dev/null
+++ b/t/tests/source-copyright-unique/debian/NEWS
@@ -0,0 +1 @@
+no news
\ No newline at end of file
diff --git a/t/tests/source-copyright-unique/debian/README
b/t/tests/source-copyright-unique/debian/README
new file mode 100644
index 000..1a9d2ad
--- /dev/null
+++ b/t/tests/source-copyright-unique/debian/README
@@ -0,0 +1 @@
+trivial
diff --git a/t/tests/source-copyrigh
[lintian] 01/03: Allow tag to be renamed
This is an automated email from the git hooks/post-receive script.
rouca pushed a commit to branch tagrename
in repository lintian.
commit f7dbaff42c945e329f9fc1329000e330c6c8fac7
Author: Bastien ROUCARIÈS
Date: Sat Aug 15 21:51:28 2015 +0200
Allow tag to be renamed
Allow renaming tag.
---
data/override/renamed-tags | 7 +++
lib/Lintian/Tag/Override.pm | 9 +
lib/Lintian/Tags.pm | 12
.../debian/debian/overrides-shown.lintian-overrides | 3 +++
t/tests/overrides-shown/tags | 4
t/tests/overrides/debian/debian/install | 1 +
t/tests/overrides/debian/debian/overrides.lintian-overrides | 3 +++
t/tests/overrides/tags | 2 +-
8 files changed, 36 insertions(+), 5 deletions(-)
diff --git a/data/override/renamed-tags b/data/override/renamed-tags
new file mode 100644
index 000..7dab546
--- /dev/null
+++ b/data/override/renamed-tags
@@ -0,0 +1,7 @@
+# list of renamed tag old name => new name. Please alpha sort by old name
+dep5-file-paragraph-reference-header-paragraph =>
dep5-file-paragraph-references-header-paragraph
+package-install-apt-preferences => package-installs-apt-preferences
+package-install-apt-sources => package-installs-apt-sources
+package-install-ieee-data => package-installs-ieee-data
+package-install-into-obsolete-dir => package-installs-into-obsolete-dir
+privacy-breach-may-use-debian-package => privacy-breach-uses-embedded-file
diff --git a/lib/Lintian/Tag/Override.pm b/lib/Lintian/Tag/Override.pm
index 28e0634..20132a4 100644
--- a/lib/Lintian/Tag/Override.pm
+++ b/lib/Lintian/Tag/Override.pm
@@ -22,6 +22,7 @@ use strict;
use warnings;
use parent qw(Class::Accessor::Fast);
+use Lintian::Data;
=head1 NAME
@@ -72,9 +73,17 @@ considered a pattern.
=cut
+# renamed tag list
+my $RENAMED_TAGS = Lintian::Data->new('override/renamed-tags',qr/\s*=>\s*/);
+
sub new {
my ($type, $tag, $data) = @_;
$data = {} unless defined $data;
+
+if($RENAMED_TAGS->known($tag)) {
+$tag = $RENAMED_TAGS->value($tag);
+}
+
my $self = {
'arch' => $data->{'arch'},
'comments' => $data->{'comments'},
diff --git a/lib/Lintian/Tags.pm b/lib/Lintian/Tags.pm
index aea037f..13c5612 100644
--- a/lib/Lintian/Tags.pm
+++ b/lib/Lintian/Tags.pm
@@ -603,10 +603,6 @@ sub file_overrides {
}
next unless $found;
}
-if ($profile && !$profile->is_overridable($tag)) {
-$self->{ignored_overrides}{$tag}++;
-next;
-}
if ($last_over && $last_over->tag eq $tag && !scalar @$comments) {
# There are no new comments, no "empty line" in between and
@@ -624,6 +620,14 @@ sub file_overrides {
};
$comments = [];
$tagover = Lintian::Tag::Override->new($tag, $data);
+# tag will be changed here if renamed reread
+$tag = $tagover->{'tag'};
+
+# treat here ignored overrides
+ if ($profile && !$profile->is_overridable($tag)) {
+$self->{ignored_overrides}{$tag}++;
+next;
+}
$info->{'overrides-data'}{$tag}{$extra} = $tagover;
$info->{overrides}{$tag}{$extra} = 0;
$last_over = $tagover;
diff --git
a/t/tests/overrides-shown/debian/debian/overrides-shown.lintian-overrides
b/t/tests/overrides-shown/debian/debian/overrides-shown.lintian-overrides
index dd2884b..04ae11b 100644
--- a/t/tests/overrides-shown/debian/debian/overrides-shown.lintian-overrides
+++ b/t/tests/overrides-shown/debian/debian/overrides-shown.lintian-overrides
@@ -14,4 +14,7 @@ FSSTND-dir-in-manual-page usr/share/man/man1/foo.1.gz:2*
FSSTND-dir-in-manual-page */foo.1.gz:5 /usr/doc/
FSSTND-dir-in-manual-page */foo.1.gz:3*
+# renamed tag
+package-install-apt-sources *
+
#FSSTND-dir-in-manual-page usr/share/man/man1/foo.1.gz * more occurrences not
shown
diff --git a/t/tests/overrides-shown/tags b/t/tests/overrides-shown/tags
index 2ffaf8c..075742d 100644
--- a/t/tests/overrides-shown/tags
+++ b/t/tests/overrides-shown/tags
@@ -1,3 +1,7 @@
+N: renamed tag
+O: overrides-shown: package-installs-apt-sources etc/apt/sources.list.d/
+N: renamed tag
+O: overrides-shown: package-installs-apt-sources etc/apt/sources.list.d/foo.1
N: exact extra information
O: overrides-shown: FSSTND-dir-in-manual-page usr/share/man/man1/foo.1.gz:4
/usr/dict/
N: These are wildcard overrides
diff --git a/t/tests/overrides/debian/debian/install
b/t/tests/overrides/debian/debian/install
new file mode
[lintian] branch tagrename created (now ab1af5d)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch tagrename in repository lintian. at ab1af5d Warn about renamed tag This branch includes the following new commits: new f7dbaff Allow tag to be renamed new 8fc290d Rename variable $tag to $rawtag in order to clarify code new ab1af5d Warn about renamed tag The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (4c4667d -> 35b6982)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch master in repository lintian. from 4c4667d spelling: Add another correction new 35b6982 Avoid false positive for sensible-utils itself The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/scripts.pm | 3 ++- debian/changelog | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch symlink created (now 5e4bb9c)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch symlink in repository lintian. at 5e4bb9c t/tests/java-*: Require a recent enough java version No new revisions were added by this update. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch utf8fix created (now c163818)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch utf8fix in repository lintian. at c163818 read_dpkg_control using utf8 This branch includes the following new commits: new 7c1c056 Read file as a whole for utf8 testing new c163818 read_dpkg_control using utf8 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch symlink deleted (was 5e4bb9c)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch symlink in repository lintian. was 5e4bb9c t/tests/java-*: Require a recent enough java version The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch wasm created (now 6182305)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch wasm in repository lintian. at 6182305 Detect wasm prebuilt file This branch includes the following new commits: new 6182305 Detect wasm prebuilt file The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch wasm deleted (was 6182305)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch wasm in repository lintian. was 6182305 Detect wasm prebuilt file This change permanently discards the following revisions: discards 6182305 Detect wasm prebuilt file -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch unique created (now 642508b)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch unique in repository lintian. at 642508b Detect if license-short-name are unique in source copyright This branch includes the following new commits: new 642508b Detect if license-short-name are unique in source copyright The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch unique deleted (was 642508b)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch unique in repository lintian. was 642508b Detect if license-short-name are unique in source copyright This change permanently discards the following revisions: discards 642508b Detect if license-short-name are unique in source copyright -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch utf8fix deleted (was c163818)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch utf8fix in repository lintian. was c163818 read_dpkg_control using utf8 This change permanently discards the following revisions: discards c163818 read_dpkg_control using utf8 discards 7c1c056 Read file as a whole for utf8 testing -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch tagrename deleted (was ab1af5d)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch tagrename in repository lintian. was ab1af5d Warn about renamed tag This change permanently discards the following revisions: discards ab1af5d Warn about renamed tag discards 8fc290d Rename variable $tag to $rawtag in order to clarify code discards f7dbaff Allow tag to be renamed -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Bug#898273: [lintian] Detect conflict between package.json version and debian control version
Package: lintian Version: 2.5.84 Severity: minor Hi, Npm package use package.json for checking version (see https://docs.npmjs.com/getting-started/semantic-versioning). control use the debian way. it will be nice to detect difference between the package.json file and the control file If package is section javascript search all file named package.json, parse it and control against control depends (including optional that go to recommand or suggest). Bastien signature.asc Description: This is a digitally signed message part.
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
Package: lintian Version: 2.5.89 Severity: normal Hi, Documentation file (*.md, LICENSE, CHANGES, PATENTS) do not belong to this dir .eslintrc are jslint config file and should not be installed .npmignore is used in order to publish file under npm so do not install *.woff, *.ttf, *.woff. are fonts so go to fonts package signature.asc Description: This is a digitally signed message part.
[Git][lintian/lintian] Pushed new branch tag-non-official-wording
Bastien Roucariès pushed new branch tag-non-official-wording at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/tree/tag-non-official-wording You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new branch javascript-lib
Bastien Roucariès pushed new branch javascript-lib at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/tree/javascript-lib You're receiving this email because of your account on salsa.debian.org.
[lintian] 01/01: Add new donation website
This is an automated email from the git hooks/post-receive script. rouca pushed a commit to branch master in repository lintian. commit 067aa412a3a228ff111cc61e57ce989e66fb9295 Author: Bastien ROUCARIÈS Date: Fri Aug 11 19:10:22 2017 +0200 Add new donation website --- data/files/privacy-breaker-websites | 2 +- debian/changelog | 2 ++ .../debian/src/privacy-breach-donation/apache.html | 5 + t/tests/files-privacybreach/tags | 1 + 4 files changed, 9 insertions(+), 1 deletion(-) diff --git a/data/files/privacy-breaker-websites b/data/files/privacy-breaker-websites index 58e1f7f..4398dd8 100644 --- a/data/files/privacy-breaker-websites +++ b/data/files/privacy-breaker-websites @@ -10,7 +10,7 @@ privacy-breach-google-adsense ~~^(?:[^\./]+\.)?(?:googlesyndication\.com/pagead/(?:show_ads\.js|js/)|google-analytics\.com/(?:ga|urchin)\.js) privacy-breach-google-cse ~~^(?:[^\./]+\.)?google\.[^\./]+\.?/(:?afsonline/show_afs_search\.js|cse/api/branding\.css|coop/cse/brand\?[^/]+)$ privacy-breach-google-plus ~~(?:^(?:[^\./]+\.)?google\.[^\./]+\.?/js/plusone\.[^\./]+\Z|^plus\.google\.com/) -privacy-breach-donation ~~(?:(?:donate|paypal|support)\.(gif|jpe?g|png|svg)$|^(?:[^\./]+\.)?(?:flattr\.(?:com|net)|paypal(?:objects)?\.com|pledgie\.com|xoom\.com)/) +privacy-breach-donation ~~(?:(?:donate|paypal|support)(?:[^/_.]*)?(?:_?small)?\.(gif|jpe?g|png|svg)$|^(?:[^\./]+\.)?(?:flattr\.(?:com|net)|paypal(?:objects)?\.com|pledgie\.com|xoom\.com)/) privacy-breach-facebook ~~^(?:[^\./]+\.)?(?:facebook\.com|static\.ak\.fbcdn\.net)(?:/|\Z) privacy-breach-logo ~~(?:^(?:sflogo\.)?(?:sourceforge|sf)\.[^\./]+/sflogo\.php\?|/logos?/|(?:acrobat|clanlib|(?:fav|github-)?icons?|logos?_?(?:\d+|small)|mascot[^\./]*|youtube-icon[^\./]*|twitter_logo[^\./]*|doxygen|forkme_[^/\.]*|logos?_[^/\.]*|logos?)\.(gif|ico|jpe?g|png|svg)$) privacy-breach-piwik ~~/piwik\.php\? diff --git a/debian/changelog b/debian/changelog index 28e972b..72aa031 100644 --- a/debian/changelog +++ b/debian/changelog @@ -70,6 +70,8 @@ lintian (2.5.53) UNRELEASED; urgency=medium libsass, libytnef, and taglib. + [RG] Use an additional string to detect embedded copies of openjpeg2. (Closes: #762956) + * data/files/privacy-breaker-websites: ++ [BR] Detect custom donation logos like apache. * commands/lintian.pm: + [CL] Apply patch from Maia Everett to avoid British spelling when diff --git a/t/tests/files-privacybreach/debian/src/privacy-breach-donation/apache.html b/t/tests/files-privacybreach/debian/src/privacy-breach-donation/apache.html new file mode 100644 index 000..4dccf51 --- /dev/null +++ b/t/tests/files-privacybreach/debian/src/privacy-breach-donation/apache.html @@ -0,0 +1,5 @@ + + +Donate to apache https://www.apache.org/images/supportapache-small.png"; /> + + \ No newline at end of file diff --git a/t/tests/files-privacybreach/tags b/t/tests/files-privacybreach/tags index bcd3168..31a5db1 100644 --- a/t/tests/files-privacybreach/tags +++ b/t/tests/files-privacybreach/tags @@ -1,3 +1,4 @@ +E: files-privacybreach: privacy-breach-donation usr/share/files-privacy-breach/privacy-breach-donation/apache.html (https://www.apache.org/images/supportapache-small.png) E: files-privacybreach: privacy-breach-donation usr/share/files-privacy-breach/privacy-breach-donation/flattr.html (http://tools.flattr.net/widgets/thing.html?thing=947300;noheader=1) E: files-privacybreach: privacy-breach-donation usr/share/files-privacy-breach/privacy-breach-donation/flattrbuttonhtml4.xml E: files-privacybreach: privacy-breach-donation usr/share/files-privacy-breach/privacy-breach-donation/flattrbuttonhtml5.xml -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (b3305ed -> 067aa41)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch master in repository lintian. from b3305ed Move uploader-address-causes-mail-loops-or-bounces to Test-Against. new 067aa41 Add new donation website The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: data/files/privacy-breaker-websites | 2 +- debian/changelog | 2 ++ .../debian/src/privacy-breach-donation/apache.html | 5 + t/tests/files-privacybreach/tags | 1 + 4 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 t/tests/files-privacybreach/debian/src/privacy-breach-donation/apache.html -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Detect generic counter
This is an automated email from the git hooks/post-receive script. rouca pushed a commit to branch master in repository lintian. commit 808cc74065c4b6cdbd0bda3582b79b2b4a35e154 Author: Bastien ROUCARIÈS Date: Fri Aug 11 19:36:12 2017 +0200 Detect generic counter --- data/files/privacy-breaker-websites | 2 +- debian/changelog | 1 + .../debian/src/privacy-breach-statistics-website/img.html| 5 + t/tests/files-privacybreach/tags | 1 + 4 files changed, 8 insertions(+), 1 deletion(-) diff --git a/data/files/privacy-breaker-websites b/data/files/privacy-breaker-websites index 4398dd8..da3ee40 100644 --- a/data/files/privacy-breaker-websites +++ b/data/files/privacy-breaker-websites @@ -14,7 +14,7 @@ privacy-breach-donation ~~(?:(?:donate|paypal|support)( privacy-breach-facebook ~~^(?:[^\./]+\.)?(?:facebook\.com|static\.ak\.fbcdn\.net)(?:/|\Z) privacy-breach-logo ~~(?:^(?:sflogo\.)?(?:sourceforge|sf)\.[^\./]+/sflogo\.php\?|/logos?/|(?:acrobat|clanlib|(?:fav|github-)?icons?|logos?_?(?:\d+|small)|mascot[^\./]*|youtube-icon[^\./]*|twitter_logo[^\./]*|doxygen|forkme_[^/\.]*|logos?_[^/\.]*|logos?)\.(gif|ico|jpe?g|png|svg)$) privacy-breach-piwik ~~/piwik\.php\? -privacy-breach-statistics-website ~~^(?:(?:[^\./]+\.)?(?:count\.digitalpoint\.com|cruel-carlota\.pagodabox\.com|linkexchange\.com|nedstatbasic\.net|onestat\.com|sitemeter\.com|statcounter\.com|webstats\.motigo\.com|digit\.com)(?:/|\Z)|/count(?:er)?\.cgi\?[^/]*\Z) +privacy-breach-statistics-website ~~^(?:(?:[^\./]+\.)?(?:cruel-carlota\.pagodabox\.com|linkexchange\.com|nedstatbasic\.net|onestat\.com|sitemeter\.com|statcounter\.com|webstats\.motigo\.com|digit\.com)(?:/|\Z)|/count(?:er)?\.cgi\?[^/]*\Z|\Acount(?:er)?\.) privacy-breach-w3c-valid-html ~~^(?:(?:[^\./]+\.)?w3.org/(?:icons/valid-|css-validator/images/)(?:[^/]+)?$|validator\.w3\.org(?:/|\Z)) # already packaged under debian (please alpha sort by package name privacy-breach-uses-embedded-file-bootstrap ~~/bootstrap(?:-(?:\d\.?)+(b\d+)?)?(?:\.min)?\.(?:js|css)\Z ~~ privacy-breach-uses-embedded-file ~~ You may use libjs-bootstrap package. diff --git a/debian/changelog b/debian/changelog index 72aa031..df8c2f5 100644 --- a/debian/changelog +++ b/debian/changelog @@ -72,6 +72,7 @@ lintian (2.5.53) UNRELEASED; urgency=medium openjpeg2. (Closes: #762956) * data/files/privacy-breaker-websites: + [BR] Detect custom donation logos like apache. ++ [BR] Detect generic counter website. * commands/lintian.pm: + [CL] Apply patch from Maia Everett to avoid British spelling when diff --git a/t/tests/files-privacybreach/debian/src/privacy-breach-statistics-website/img.html b/t/tests/files-privacybreach/debian/src/privacy-breach-statistics-website/img.html new file mode 100644 index 000..748e2f2 --- /dev/null +++ b/t/tests/files-privacybreach/debian/src/privacy-breach-statistics-website/img.html @@ -0,0 +1,5 @@ + + +Counter http://counter.ceres.dti.ne.jp/cgi-bin/count.cgi?df=knak.01.dat|dd=d|ft=0|md=10|comma=y|srgb=00ff00|prgb=ff|trgb=black" /> + + \ No newline at end of file diff --git a/t/tests/files-privacybreach/tags b/t/tests/files-privacybreach/tags index 31a5db1..1a8c601 100644 --- a/t/tests/files-privacybreach/tags +++ b/t/tests/files-privacybreach/tags @@ -38,6 +38,7 @@ E: files-privacybreach: privacy-breach-logo usr/share/files-privacy-breach/priva E: files-privacybreach: privacy-breach-logo usr/share/files-privacy-breach/privacy-breach-twitter/logotwitter.xml (https://g.twimg.com/twitter_logo_blue.png) E: files-privacybreach: privacy-breach-piwik usr/share/files-privacy-breach/privacy-breach-piwik/piwik.html E: files-privacybreach: privacy-breach-piwik usr/share/files-privacy-breach/privacy-breach-piwik/piwikvariant.html +E: files-privacybreach: privacy-breach-statistics-website usr/share/files-privacy-breach/privacy-breach-statistics-website/img.html (http://counter.ceres.dti.ne.jp/cgi-bin/count.cgi?df=knak.01.dat|dd=d|ft=0|md=10|comma=y|srgb=00ff00|prgb=ff|trgb=black) E: files-privacybreach: privacy-breach-statistics-website usr/share/files-privacy-breach/privacy-breach-statistics-website/statcounter.xml E: files-privacybreach: privacy-breach-statistics-website usr/share/files-privacy-breach/privacy-breach-statistics-website/statcounter2.js E: files-privacybreach: privacy-breach-twitter usr/share/files-privacy-breach/privacy-breach-twitter/awstat.xml -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (067aa41 -> 808cc74)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch master in repository lintian. from 067aa41 Add new donation website new 808cc74 Detect generic counter The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: data/files/privacy-breaker-websites | 2 +- debian/changelog | 1 + .../debian/src/privacy-breach-statistics-website/img.html| 5 + t/tests/files-privacybreach/tags | 1 + 4 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 t/tests/files-privacybreach/debian/src/privacy-breach-statistics-website/img.html -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Avoid false positive for link to license
This is an automated email from the git hooks/post-receive script.
rouca pushed a commit to branch master
in repository lintian.
commit 213f0301aeee5e4d71d258156f15a176c5c0ea51
Author: Bastien ROUCARIÈS
Date: Fri Aug 11 22:02:48 2017 +0200
Avoid false positive for link to license
It is not a privacy breach. Future lintian could suggest to replace with
local link nevertheless
---
checks/files.pm| 10 ++
debian/changelog | 2 ++
.../src/old-false-positive/privacy-breach-generic/legal.xml| 5 +
3 files changed, 17 insertions(+)
diff --git a/checks/files.pm b/checks/files.pm
index 6e5f85e..af91648 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -2027,6 +2027,15 @@ sub _check_tag_url_privacy_breach {
}
}
+# False positive
+# legal.xml file of gnome
+# could be replaced by a link to local file but not really a privacy breach
+if($file->basename eq 'legal.xml'
+&& $tagattr eq 'link'
+&& $website =~ m{^creativecommons.org/licenses/}) {
+return;
+}
+
# track well known site
foreach my $breaker ($PRIVACY_BREAKER_WEBSITES->all) {
my $value = $PRIVACY_BREAKER_WEBSITES->value($breaker);
@@ -2042,6 +2051,7 @@ sub _check_tag_url_privacy_breach {
return;
}
}
+
# generic case
unless (exists $privacybreachhash->{'tag-generic-'.$website}){
tag 'privacy-breach-generic', $file, "($url)";
diff --git a/debian/changelog b/debian/changelog
index df8c2f5..69381fd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -36,6 +36,8 @@ lintian (2.5.53) UNRELEASED; urgency=medium
+ [CL] Ensure that python3-foo packages have "Section: python", not
just python2-foo. (Closes: #870272)
+ [RG] Do no longer require debug packages to be priority extra.
+ * checks/files.pm:
++ [BR] Avoid false positive privacy-breach-generic for legal.xml.
* checks/init.d.desc:
+ [RG] Do not recommend a versioned dependency on lsb-base in
init.d-script-needs-depends-on-lsb-base. (Closes: #847144)
diff --git
a/t/tests/files-privacybreach/debian/src/old-false-positive/privacy-breach-generic/legal.xml
b/t/tests/files-privacybreach/debian/src/old-false-positive/privacy-breach-generic/legal.xml
new file mode 100644
index 000..cb5d83f
--- /dev/null
+++
b/t/tests/files-privacybreach/debian/src/old-false-positive/privacy-breach-generic/legal.xml
@@ -0,0 +1,5 @@
+http://projectmallard.org/1.0/";
+ href="http://creativecommons.org/licenses/by-sa/3.0/";>
+ This work is licensed under a http://creativecommons.org/licenses/by-sa/3.0/";>Creative
+ Commons Attribution-ShareAlike 3.0 Unported License.
+
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (808cc74 -> 213f030)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch master in repository lintian. from 808cc74 Detect generic counter new 213f030 Avoid false positive for link to license The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/files.pm| 10 ++ debian/changelog | 2 ++ .../src/old-false-positive/privacy-breach-generic/legal.xml| 5 + 3 files changed, 17 insertions(+) create mode 100644 t/tests/files-privacybreach/debian/src/old-false-positive/privacy-breach-generic/legal.xml -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 02/02: Node- package should go to section javascript
This is an automated email from the git hooks/post-receive script. rouca pushed a commit to branch master in repository lintian. commit 313bc340e5a28bf8a2d1195a3161ccc3213bb0a4 Author: Bastien ROUCARIÈS Date: Fri Aug 25 22:26:44 2017 +0200 Node- package should go to section javascript --- data/fields/name_section_mappings | 3 ++- debian/changelog | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/data/fields/name_section_mappings b/data/fields/name_section_mappings index ca9c1de..30ff455 100644 --- a/data/fields/name_section_mappings +++ b/data/fields/name_section_mappings @@ -13,4 +13,5 @@ lib.*-cil(?:-dev)?$ => cli-mono ^lib.*-(?:ocaml|camlp4)-dev$ => ocaml ^lib.*-dev$ => libdevel ^gir\d+\.\d+-.*-\d+\.\d+$=> introspection -^libjs- => javascript \ No newline at end of file +^libjs- => javascript +^node- => javascript diff --git a/debian/changelog b/debian/changelog index af300a8..5eedfcd 100644 --- a/debian/changelog +++ b/debian/changelog @@ -86,6 +86,8 @@ lintian (2.5.53) UNRELEASED; urgency=medium libsass, libytnef, and taglib. + [RG] Use an additional string to detect embedded copies of openjpeg2. (Closes: #762956) + * data/fields/name_section_mappings: ++ [BR] node- package section is javascript. * data/fields/obsolete-packages: + [MR] Add dh-systemd. (Closes: #872076) * data/files/obsolete-paths: -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/02: Use Lintian::Data for section/name mapping
This is an automated email from the git hooks/post-receive script.
rouca pushed a commit to branch master
in repository lintian.
commit f71f3901fcc23db666d3de176526e91fd4f228a2
Author: Bastien ROUCARIÈS
Date: Fri Aug 25 22:22:39 2017 +0200
Use Lintian::Data for section/name mapping
---
checks/fields.pm | 34 +-
data/fields/name_section_mappings | 16
debian/changelog | 1 +
3 files changed, 30 insertions(+), 21 deletions(-)
diff --git a/checks/fields.pm b/checks/fields.pm
index cb91491..4ad96ad 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -96,23 +96,14 @@ our @known_java_pkg = map { qr/$_/ } (
);
# Mapping of package names to section names
-my @NAME_SECTION_MAPPINGS = (
-[qr/-docs?$/ => 'doc'],
-[qr/-dbg(?:sym)?$/=> 'debug'],
-[qr/^(?:python-)?zope/=> 'zope'],
-[qr/^python3?-/ => 'python'],
-[qr/^r-(?:cran|bioc|other)-/ => 'gnu-r'],
-[qr/^lib.*-perl$/ => 'perl'],
-[qr/^lib.*-cil(?:-dev)?$/ => 'cli-mono'],
-[qr/^lib.*-(?:java|gcj)$/ => 'java'],
-[qr/^(?:lib)php-/ => 'php'],
-[qr/^lib(?:hugs|ghc6?)-/ => 'haskell'],
-[qr/^lib.*-ruby(?:1\.\d)?$/ => 'ruby'],
-[qr/^lib.*-(?:ocaml|camlp4)-dev$/ => 'ocaml'],
-[qr/^lib.*-dev$/ => 'libdevel'],
-[qr/^gir\d+\.\d+-.*-\d+\.\d+$/=> 'introspection'],
-[qr/^libjs-/ => 'javascript'],
-);
+my $NAME_SECTION_MAPPINGS = Lintian::Data->new(
+'fields/name_section_mappings',
+qr/\s*=>\s*/,
+sub {
+my $regex = qr/$_[0]/x;
+$_[0] = $_[1];
+return $regex;
+});
my %VCS_EXTRACT = (
browser => sub { return @_;},
@@ -547,14 +538,15 @@ sub run {
# Check package name <-> section. oldlibs is a special case; let
# anything go there.
if ($parts[-1] ne 'oldlibs') {
-foreach my $map (@NAME_SECTION_MAPPINGS) {
-next unless ($pkg =~ $map->[0]);
+foreach my $section ($NAME_SECTION_MAPPINGS->all()) {
+my $regex = $NAME_SECTION_MAPPINGS->value($section);
+next unless ($pkg =~ m{$regex});
my $area = '';
$area = "$parts[0]/" if (scalar @parts == 2);
tag 'wrong-section-according-to-package-name',
- "$pkg => ${area}$map->[1]"
- unless $parts[-1] eq $map->[1];
+ "$pkg => ${area}$section"
+ unless $parts[-1] eq $section;
last;
}
}
diff --git a/data/fields/name_section_mappings
b/data/fields/name_section_mappings
new file mode 100644
index 000..ca9c1de
--- /dev/null
+++ b/data/fields/name_section_mappings
@@ -0,0 +1,16 @@
+# map between regex (x) of package => section
+-docs?$ => doc
+-dbg(?:sym)?$=> debug
+^(?:python-)?zope=> zope
+^python3?- => python
+^r-(?:cran|bioc|other)- => gnu-r
+^lib.*-perl$ => perl
+lib.*-cil(?:-dev)?$ => cli-mono
+^lib.*-(?:java|gcj)$ => java
+^(?:lib)php- => php
+^lib(?:hugs|ghc6?)- => haskell
+^lib.*-ruby(?:1\.\d)?$ => ruby
+^lib.*-(?:ocaml|camlp4)-dev$ => ocaml
+^lib.*-dev$ => libdevel
+^gir\d+\.\d+-.*-\d+\.\d+$=> introspection
+^libjs- => javascript
\ No newline at end of file
diff --git a/debian/changelog b/debian/changelog
index e7cbe8d..af300a8 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -43,6 +43,7 @@ lintian (2.5.53) UNRELEASED; urgency=medium
+ [CL] Ensure that python3-foo packages have "Section: python", not
just python2-foo. (Closes: #870272)
+ [RG] Do no longer require debug packages to be priority extra.
++ [BR] Use Lintian::Data for name/section mapping
* checks/files.pm:
+ [BR] Avoid false positive privacy-breach-generic for legal.xml.
* checks/init.d.desc:
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (87eafe4 -> 313bc34)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch master in repository lintian. from 87eafe4 Correct grammar of fixme-placeholders test. new f71f390 Use Lintian::Data for section/name mapping new 313bc34 Node- package should go to section javascript The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/fields.pm | 34 +- data/fields/name_section_mappings | 17 + debian/changelog | 3 +++ 3 files changed, 33 insertions(+), 21 deletions(-) create mode 100644 data/fields/name_section_mappings -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Detect installation of nodejs pacakge under naked root
This is an automated email from the git hooks/post-receive script.
rouca pushed a commit to branch master
in repository lintian.
commit c7387c304f2b39d788cc106ee6a3588900fae866
Author: Bastien ROUCARIÈS
Date: Fri Aug 25 22:57:17 2017 +0200
Detect installation of nodejs pacakge under naked root
---
checks/files.desc | 6 ++
checks/files.pm| 8
debian/changelog | 1 +
t/tests/files-nodejs/debian/debian/install | 1 +
t/tests/files-nodejs/debian/debian/rules | 16
t/tests/files-nodejs/debian/src/test.js| 1 +
t/tests/files-nodejs/debian/src/test.json | 1 +
t/tests/files-nodejs/desc | 5 +
t/tests/files-nodejs/tags | 2 ++
9 files changed, 41 insertions(+)
diff --git a/checks/files.desc b/checks/files.desc
index 639fe26..17888e1 100644
--- a/checks/files.desc
+++ b/checks/files.desc
@@ -1215,6 +1215,12 @@ Info: This package creates a potential privacy breach by
fetching W3C
Note that these icons are non-free and must not be copied into the
package. You could safely delete this W3C validation badge.
+Tag: node-package-install-in-nodejs-rootdir
+Severity: important
+Certainty: certain
+Info: This package contains a file under /usr/lib/nodejs
+ instead to /usr/lib/nodejs/${package}
+
Tag: embedded-feedparser-library
Severity: normal
Certainty: certain
diff --git a/checks/files.pm b/checks/files.pm
index b5dea67..0dfc84f 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -751,6 +751,14 @@ sub run {
elsif ($fname =~ m,^usr/lib/sgml/\S,) {
tag 'file-in-usr-lib-sgml', $file;
}
+# /usr/lib/node
+elsif ($fname =~ m,^usr/lib/nodejs/,) {
+if ($fname eq 'usr/lib/nodejs/package.json') {
+tag 'node-package-install-in-nodejs-rootdir', $fname;
+}elsif ($fname =~m,usr/lib/nodejs/[^/]*\.js$,) {
+tag 'node-package-install-in-nodejs-rootdir', $fname;
+}
+}
# perllocal.pod
elsif ($fname =~ m,^usr/lib/perl.*/perllocal.pod$,) {
tag 'package-installs-perllocal-pod', $file;
diff --git a/debian/changelog b/debian/changelog
index 5eedfcd..86ce822 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -46,6 +46,7 @@ lintian (2.5.53) UNRELEASED; urgency=medium
+ [BR] Use Lintian::Data for name/section mapping
* checks/files.pm:
+ [BR] Avoid false positive privacy-breach-generic for legal.xml.
++ [BR] Detect install to node package under /usr/lib/nodejs/[^/]*$
* checks/init.d.desc:
+ [RG] Do not recommend a versioned dependency on lsb-base in
init.d-script-needs-depends-on-lsb-base. (Closes: #847144)
diff --git a/t/tests/files-nodejs/debian/debian/install
b/t/tests/files-nodejs/debian/debian/install
new file mode 100644
index 000..1b91047
--- /dev/null
+++ b/t/tests/files-nodejs/debian/debian/install
@@ -0,0 +1 @@
+usr/
diff --git a/t/tests/files-nodejs/debian/debian/rules
b/t/tests/files-nodejs/debian/debian/rules
new file mode 100755
index 000..fbfddee
--- /dev/null
+++ b/t/tests/files-nodejs/debian/debian/rules
@@ -0,0 +1,16 @@
+#!/usr/bin/make -f
+PKG:=files-nodejs
+INSTPATH:=$(CURDIR)/debian/tmp/usr/lib/nodejs
+
+
+%:
+ dh $@
+
+override_dh_install:
+ mkdir -p $(INSTPATH)
+ cp src/test.js $(INSTPATH)/test.js
+ cp src/test.json $(INSTPATH)/package.json
+ dh_install
+
+
+
diff --git a/t/tests/files-nodejs/debian/src/test.js
b/t/tests/files-nodejs/debian/src/test.js
new file mode 100644
index 000..ca538a6
--- /dev/null
+++ b/t/tests/files-nodejs/debian/src/test.js
@@ -0,0 +1 @@
+/* test.js */
\ No newline at end of file
diff --git a/t/tests/files-nodejs/debian/src/test.json
b/t/tests/files-nodejs/debian/src/test.json
new file mode 100644
index 000..f0a3f50
--- /dev/null
+++ b/t/tests/files-nodejs/debian/src/test.json
@@ -0,0 +1 @@
+/* json test */
\ No newline at end of file
diff --git a/t/tests/files-nodejs/desc b/t/tests/files-nodejs/desc
new file mode 100644
index 000..0b481b8
--- /dev/null
+++ b/t/tests/files-nodejs/desc
@@ -0,0 +1,5 @@
+Testname: files-nodejs
+Version: 1.0
+Description: Check for nodejs problems
+Test-For:
+ node-package-install-in-nodejs-rootdir
diff --git a/t/tests/files-nodejs/tags b/t/tests/files-nodejs/tags
new file mode 100644
index 000..7492f8e
--- /dev/null
+++ b/t/tests/files-nodejs/tags
@@ -0,0 +1,2 @@
+E: files-nodejs: node-package-install-in-nodejs-rootdir
usr/lib/nodejs/package.json
+E: files-nodejs: node-package-install-in-nodejs-rootdir usr/lib/nodejs/test.js
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (313bc34 -> c7387c3)
This is an automated email from the git hooks/post-receive script.
rouca pushed a change to branch master
in repository lintian.
from 313bc34 Node- package should go to section javascript
new c7387c3 Detect installation of nodejs pacakge under naked root
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.
Summary of changes:
checks/files.desc| 6 ++
checks/files.pm | 8
debian/changelog | 1 +
.../debian/debian/install| 0
t/tests/files-nodejs/debian/debian/rules | 16
t/tests/files-nodejs/debian/src/test.js | 1 +
t/tests/files-nodejs/debian/src/test.json| 1 +
t/tests/files-nodejs/desc| 5 +
t/tests/files-nodejs/tags| 2 ++
9 files changed, 40 insertions(+)
copy t/tests/{cruft-minified-js => files-nodejs}/debian/debian/install (100%)
create mode 100755 t/tests/files-nodejs/debian/debian/rules
create mode 100644 t/tests/files-nodejs/debian/src/test.js
create mode 100644 t/tests/files-nodejs/debian/src/test.json
create mode 100644 t/tests/files-nodejs/desc
create mode 100644 t/tests/files-nodejs/tags
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (64e679b -> 8c41c05)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch master in repository lintian. from 64e679b Tidy gramma of some changelog entries. new f03634d Revert "Node- package should go to section javascript" new c64a1f8 Revert "Use Lintian::Data for section/name mapping" new bc97e6c Add storage qualifier to Lintian::Data new 988b493 Allow ordered type for Lintian::Data new d0f7559 Move to Lintian::Data section name mapping new 8c41c05 Node- package should go to section javascript The 6 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/fields.pm | 14 -- data/fields/name_section_mappings | 8 +--- debian/control| 2 ++ lib/Lintian/Data.pm | 27 --- 4 files changed, 39 insertions(+), 12 deletions(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Warn if debian/watch uses deprecated githubredir.debian.net scraper
This is an automated email from the git hooks/post-receive script. rouca pushed a commit to branch tmpjj in repository lintian. commit 139ed0bef309b9a59c21a503727609731c06d797 Author: Chris Lamb Date: Sun Jan 3 14:30:20 2016 +0100 Warn if debian/watch uses deprecated githubredir.debian.net scraper Signed-off-by: Chris Lamb --- checks/watch-file.desc | 13 + checks/watch-file.pm | 4 debian/changelog | 2 +- t/tests/watch-file-general/debian/debian/watch | 5 - t/tests/watch-file-general/desc| 1 + t/tests/watch-file-general/tags| 2 ++ 6 files changed, 25 insertions(+), 2 deletions(-) diff --git a/checks/watch-file.desc b/checks/watch-file.desc index 1b66da7..1ae2a8a 100644 --- a/checks/watch-file.desc +++ b/checks/watch-file.desc @@ -116,6 +116,19 @@ Info: The watch file specifies a SourceForge page or download server project andwith the name of the tarball distributed within that project. Adjust the filename regex as necessary. +Tag: debian-watch-file-uses-deprecated-githubredir +Severity: important +Certainty: certain +Ref: https://lists.debian.org/debian-devel-announce/2014/10/msg0.html +Info: The watch file specifies a githubredir.debia.net URL, which is deprecated + Instead, use direct links to the tags page: + . + version=3 + https://github.com/ / /tags .*/(.*)\.tar\.gz + . + replacing and with the Github + username and project respectfully. + Tag: debian-watch-file-specifies-wrong-upstream-version Severity: normal Certainty: certain diff --git a/checks/watch-file.pm b/checks/watch-file.pm index 46ab633..737c25b 100644 --- a/checks/watch-file.pm +++ b/checks/watch-file.pm @@ -122,6 +122,10 @@ sub run { if (m,\b\Qhttp://pypi.python.org/\E,) { tag 'debian-watch-file-accesses-pypi-over-http', "line $."; } +if (m%githubredir\.debian\.net%) { +tag 'debian-watch-file-uses-deprecated-githubredir', + "line $."; +} if ( m{ (?:https?|ftp):// diff --git a/debian/changelog b/debian/changelog index 60eafe9..15bf199 100644 --- a/debian/changelog +++ b/debian/changelog @@ -14,7 +14,7 @@ lintian (2.5.40) UNRELEASED; urgency=medium + [JW] Apply patch from Mattia Rizzolo to update the machine-readable copyright format specification URL. (Closes: #809248) + [BR] Improve description text of tag - dep5-copyright-license-name-not-unique. + dep5-copyright-license-name-not-unique. (Closes: #809651). * data/spelling/corrections*: diff --git a/t/tests/watch-file-general/debian/debian/watch b/t/tests/watch-file-general/debian/debian/watch index 71b4717..e322710 100644 --- a/t/tests/watch-file-general/debian/debian/watch +++ b/t/tests/watch-file-general/debian/debian/watch @@ -26,4 +26,7 @@ http://pypi.python.org/foo scripts\.([\d.]+)\.tar\.gz debian uupdate # Unsupported PyPI URL. https://pypi.python.org/packages/source/p/pip/ pip-(\S+)\.tar\.gz -# without any pgpsigurlmangle \ No newline at end of file +# Deprecated githubredir +http://githubredir.debian.net/github/username/project /(.*).tar.gz + +# without any pgpsigurlmangle diff --git a/t/tests/watch-file-general/desc b/t/tests/watch-file-general/desc index 64d09c9..0e7a20e 100644 --- a/t/tests/watch-file-general/desc +++ b/t/tests/watch-file-general/desc @@ -15,5 +15,6 @@ Test-For: debian-watch-file-unknown-version debian-watch-file-unsupported-pypi-url debian-watch-file-uses-deprecated-sf-redirector-method + debian-watch-file-uses-deprecated-githubredir debian-watch-may-check-gpg-signature References: Debian Bug#510398 diff --git a/t/tests/watch-file-general/tags b/t/tests/watch-file-general/tags index a80f45b..1c54f22 100644 --- a/t/tests/watch-file-general/tags +++ b/t/tests/watch-file-general/tags @@ -1,4 +1,5 @@ E: watch-file-general source: debian-watch-file-unsupported-pypi-url line 27 +E: watch-file-general source: debian-watch-file-uses-deprecated-githubredir line 30 I: watch-file-general source: debian-watch-file-accesses-pypi-over-http line 24 I: watch-file-general source: debian-watch-file-should-dversionmangle-not-uversionmangle line 5 P: watch-file-general source: debian-watch-may-check-gpg-signature @@ -8,6 +9,7 @@ W: watch-file-general source: debian-watch-file-should-mangle-version line 12 W: watch-file-general source: debian-watch-file-should-mangle-version line 14 W: watch-file-general source: debian-watch-file-should-mangle-version line 15 W: watch-file-general source: debian-watch-file-should-mangle-version line 27 +W: watch-file-general source: debian-watch-file-should-mangle-version line 30 W: watch-file-general source: debian-watch-file-should-use-sf-redirector line 12 W: watch-file-general source: debian-watch-file-should-use-sf-redir
[lintian] 01/01: Warn if debian/watch uses deprecated githubredir.debian.net scraper
This is an automated email from the git hooks/post-receive script. rouca pushed a commit to branch tmpy in repository lintian. commit e60c9ad0259cced3aed5a0984258fa475268bd29 Author: Chris Lamb Date: Sun Jan 3 14:30:20 2016 +0100 Warn if debian/watch uses deprecated githubredir.debian.net scraper Signed-off-by: Chris Lamb --- checks/watch-file.desc | 13 + checks/watch-file.pm | 4 debian/changelog | 8 ++-- t/tests/watch-file-general/debian/debian/watch | 5 - t/tests/watch-file-general/desc| 1 + t/tests/watch-file-general/tags| 2 ++ 6 files changed, 30 insertions(+), 3 deletions(-) diff --git a/checks/watch-file.desc b/checks/watch-file.desc index 1b66da7..1ae2a8a 100644 --- a/checks/watch-file.desc +++ b/checks/watch-file.desc @@ -116,6 +116,19 @@ Info: The watch file specifies a SourceForge page or download server project andwith the name of the tarball distributed within that project. Adjust the filename regex as necessary. +Tag: debian-watch-file-uses-deprecated-githubredir +Severity: important +Certainty: certain +Ref: https://lists.debian.org/debian-devel-announce/2014/10/msg0.html +Info: The watch file specifies a githubredir.debia.net URL, which is deprecated + Instead, use direct links to the tags page: + . + version=3 + https://github.com/ / /tags .*/(.*)\.tar\.gz + . + replacing and with the Github + username and project respectfully. + Tag: debian-watch-file-specifies-wrong-upstream-version Severity: normal Certainty: certain diff --git a/checks/watch-file.pm b/checks/watch-file.pm index 46ab633..737c25b 100644 --- a/checks/watch-file.pm +++ b/checks/watch-file.pm @@ -122,6 +122,10 @@ sub run { if (m,\b\Qhttp://pypi.python.org/\E,) { tag 'debian-watch-file-accesses-pypi-over-http', "line $."; } +if (m%githubredir\.debian\.net%) { +tag 'debian-watch-file-uses-deprecated-githubredir', + "line $."; +} if ( m{ (?:https?|ftp):// diff --git a/debian/changelog b/debian/changelog index 60eafe9..69c6892 100644 --- a/debian/changelog +++ b/debian/changelog @@ -10,12 +10,16 @@ lintian (2.5.40) UNRELEASED; urgency=medium checks. Thanks to Aurelien Jarno for the bug report. (Closes: #809262) + [BR] Detect old style config script and detect Mutli-arch error. - * checks/source-copyright.desc: + * checks/source-copyright.{desc,pm}: + [JW] Apply patch from Mattia Rizzolo to update the machine-readable copyright format specification URL. (Closes: #809248) + [BR] Improve description text of tag - dep5-copyright-license-name-not-unique. + dep5-copyright-license-name-not-unique. (Closes: #809651). + * checks/watch-file.{desc,pm}: ++ [BR] Apply patch from Chris Lamb , + warn if debian/watch uses deprecated + githubredir.debian.net scraper (Closes: #803106). * data/spelling/corrections*: + [JW] Add more corrections. diff --git a/t/tests/watch-file-general/debian/debian/watch b/t/tests/watch-file-general/debian/debian/watch index 71b4717..e322710 100644 --- a/t/tests/watch-file-general/debian/debian/watch +++ b/t/tests/watch-file-general/debian/debian/watch @@ -26,4 +26,7 @@ http://pypi.python.org/foo scripts\.([\d.]+)\.tar\.gz debian uupdate # Unsupported PyPI URL. https://pypi.python.org/packages/source/p/pip/ pip-(\S+)\.tar\.gz -# without any pgpsigurlmangle \ No newline at end of file +# Deprecated githubredir +http://githubredir.debian.net/github/username/project /(.*).tar.gz + +# without any pgpsigurlmangle diff --git a/t/tests/watch-file-general/desc b/t/tests/watch-file-general/desc index 64d09c9..0e7a20e 100644 --- a/t/tests/watch-file-general/desc +++ b/t/tests/watch-file-general/desc @@ -15,5 +15,6 @@ Test-For: debian-watch-file-unknown-version debian-watch-file-unsupported-pypi-url debian-watch-file-uses-deprecated-sf-redirector-method + debian-watch-file-uses-deprecated-githubredir debian-watch-may-check-gpg-signature References: Debian Bug#510398 diff --git a/t/tests/watch-file-general/tags b/t/tests/watch-file-general/tags index a80f45b..1c54f22 100644 --- a/t/tests/watch-file-general/tags +++ b/t/tests/watch-file-general/tags @@ -1,4 +1,5 @@ E: watch-file-general source: debian-watch-file-unsupported-pypi-url line 27 +E: watch-file-general source: debian-watch-file-uses-deprecated-githubredir line 30 I: watch-file-general source: debian-watch-file-accesses-pypi-over-http line 24 I: watch-file-general source: debian-watch-file-should-dversionmangle-not-uversionmangle line 5 P: watch-file-general source: debian-watch-may-check-gpg-signature @@ -8,6 +9,7 @@ W: watch-file-general source: debian-watch-file-should-mangle-version line 12 W: watch-file
[lintian] branch binariesPIC created (now 402a964)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch binariesPIC in repository lintian. at 402a964 Try to get static binaries This branch includes the following new commits: new 402a964 Try to get static binaries The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (8c41c05 -> 221f36d)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch master in repository lintian. from 8c41c05 Node- package should go to section javascript new 60fc451 Add a statistic tag for script interpreter new 221f36d Bump ancient time The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/scripts.desc | 5 + checks/scripts.pm | 3 +++ data/standards-version/ancient-date | 2 +- debian/changelog | 1 + t/tests/scripts-does-not-start-with-shebang/tags | 3 +++ t/tests/scripts-maintainer-script-classification/desc | 1 + t/tests/scripts-maintainer-script-classification/tags | 1 + 7 files changed, 15 insertions(+), 1 deletion(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch fixlintian created (now 01435bc)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch fixlintian in repository lintian. at 01435bc Fix lintian spurious warning This branch includes the following new commits: new 01435bc Fix lintian spurious warning The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch autogen created (now 973a7f9)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch autogen in repository lintian. at 973a7f9 Detect autogenerated microsoft visual c++ file This branch includes the following new commits: new 973a7f9 Detect autogenerated microsoft visual c++ file The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch fonthint created (now ffd2c0c)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch fonthint in repository lintian. at ffd2c0c Add detecting of adobe proprietary font hinting This branch includes the following new commits: new ffd2c0c Add detecting of adobe proprietary font hinting The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch gfdlfixup created (now b64b28a)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch gfdlfixup in repository lintian. at b64b28a Improve specificity of gfdl tagging of example This branch includes the following new commits: new b64b28a Improve specificity of gfdl tagging of example The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch gfdlrevision created (now 87949c6)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch gfdlrevision in repository lintian. at 87949c6 Add a few new path forbidden This branch includes the following new commits: new 7ba4c3a Improve cruft license check by using a sliding window and detect gfdl new 87949c6 Add a few new path forbidden The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch cc-by-sa created (now ad3e62b)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch cc-by-sa in repository lintian. at ad3e62b Detect cc-by-nc-sa This branch includes the following new commits: new ad3e62b Detect cc-by-nc-sa The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch masterold created (now 5593d2c)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch masterold in repository lintian. at 5593d2c Tag openjdk-6-jdk, openjdk-6-jre and openjdk-6-jre-headless as obsolete (See #720911). This branch includes the following new commits: new c7f4741 Add supress => suppress in the list of spelling mistakes new 5593d2c Tag openjdk-6-jdk, openjdk-6-jre and openjdk-6-jre-headless as obsolete (See #720911). The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 02/02: Tag openjdk-6-jdk, openjdk-6-jre and openjdk-6-jre-headless as obsolete (See #720911).
This is an automated email from the git hooks/post-receive script.
rouca pushed a commit to branch masterold
in repository lintian.
commit 5593d2c88f7c546c156f14341910bc3216c94400
Author: Sylvestre Ledru
Date: Tue Nov 26 16:17:28 2013 +0100
Tag openjdk-6-jdk, openjdk-6-jre and openjdk-6-jre-headless as obsolete
(See #720911).
Detect when the package build dep on java-compiler.
[BR] Improve wordings of checks/java.desc
[BR] Move description to checks/fields.desc
---
checks/fields.desc | 6 ++
checks/fields.pm | 5 +
data/fields/obsolete-packages| 5 +
debian/changelog | 5 +
t/tests/fields-java/debian/debian/control.in | 2 +-
t/tests/fields-java/tags | 4
6 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/checks/fields.desc b/checks/fields.desc
index 8751018..0989add 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -587,6 +587,12 @@ Info: The package declares a build-depends on an essential
package, e.g. dpkg,
is if you need a particular version of that package, in which case the
version should be given in the dependency.
+Tag: build-depends-on-an-obsolete-java-package
+Severity: normal
+Certainty: certain
+Info: The package build-depends on an obsolete java dependency.
+ It should built-depends on default-jdk instead.
+
Tag: build-depends-on-non-build-package
Severity: important
Certainty: certain
diff --git a/checks/fields.pm b/checks/fields.pm
index 2d103fb..e41cccf 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -974,6 +974,11 @@ sub run {
$d_pkg;
}
+if ( $d_pkg =~ m/^java-compiler$/o){
+tag 'build-depends-on-an-obsolete-java-package',
+ $d_pkg;
+}
+
if ($d_pkg =~ m/^libdb\d+\.\d+.*-dev$/o
and &$is_dep_field($field)) {
tag 'build-depends-on-versioned-berkeley-db',
diff --git a/data/fields/obsolete-packages b/data/fields/obsolete-packages
index c70a2a0..64595de 100644
--- a/data/fields/obsolete-packages
+++ b/data/fields/obsolete-packages
@@ -80,3 +80,8 @@ automake1.7
automake1.8
automake1.9
automake1.10
+
+# Deprecated in Jessie (#720911)
+openjdk-6-jdk
+openjdk-6-jre
+openjdk-6-jre-headless
diff --git a/debian/changelog b/debian/changelog
index 272c4d8..5a3090c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -7,6 +7,9 @@ lintian (2.5.20) UNRELEASED; urgency=low
license. (Closes: #724930)
+ [BR] Abstract sliding window algorithm and use it for
license check. (Closes: #720348)
+ * checks/fields.pm:
++ [SL] Returns a warning when a package build-deps on java-compiler
+ instead of default-jdk.
* checks/files.desc
+ [BR] Improve description of pkg-config-multi-arch-wrong-dir
tag. Add debhelper > 9 on non multi-arched package as a likely
@@ -20,6 +23,8 @@ lintian (2.5.20) UNRELEASED; urgency=low
* data/fields/obsolete-packages:
+ [NT] Apply patch from Eric Dorland to mark various versions
of automake as obsolete.
++ [SL] Tag openjdk-6-jdk, openjdk-6-jre and openjdk-6-jre-headless
+ as obsolete (See ##720911)
* data/fields/virtual-packages:
+ [NT] Refresh against sid. Thanks to Nicholas Breen for the
reminder. (Closes: #724866)
diff --git a/t/tests/fields-java/debian/debian/control.in
b/t/tests/fields-java/debian/debian/control.in
index 2b8801d..5125554 100644
--- a/t/tests/fields-java/debian/debian/control.in
+++ b/t/tests/fields-java/debian/debian/control.in
@@ -3,7 +3,7 @@ Priority: extra
Section: java
Maintainer: {$author}
Standards-Version: {$standards_version}
-Build-Depends: debhelper (>= 9), openjdk-6-doc
+Build-Depends: debhelper (>= 9), openjdk-6-doc, openjdk-6-jdk, java-compiler
Package: lib{$source}-java
Architecture: all
diff --git a/t/tests/fields-java/tags b/t/tests/fields-java/tags
index 7080a0f..77ba9af 100644
--- a/t/tests/fields-java/tags
+++ b/t/tests/fields-java/tags
@@ -1,4 +1,8 @@
+E: fields-java source: build-depends-on-obsolete-package build-depends:
openjdk-6-jdk
I: libfields-java-java: javalib-but-no-public-jars
+I: libfields-java-java: ored-depends-on-obsolete-package depends: openjdk-6-jre
+W: fields-java source: build-depends-on-an-obsolete-java-package java-compiler
W: fields-java source: build-depends-on-specific-java-doc-package openjdk-6-doc
+W: fields-java source: virtual-package-depends-without-real-package-depends
build-depends: java-compiler
W: libfields-java-java-doc: depends-on-specific-java-doc-package recommends
W: libfields-java-java: needless-dependency-on-jre
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] branch pedanticgfdlvariant created (now 14c7b6d)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch pedanticgfdlvariant in repository lintian. at 14c7b6d Warm about non official wording of gfdl This branch includes the following new commits: new 14c7b6d Warm about non official wording of gfdl The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch php created (now 14e20b3)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch php in repository lintian. at 14e20b3 php This branch includes the following new commits: new 14e20b3 php The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch newbranch created (now b161d2b)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch newbranch in repository lintian. at b161d2b check all This branch includes the following new commits: new 3260233 Word wrap mail template new b161d2b check all The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch patchdep3template created (now 11a689c)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch patchdep3template in repository lintian. at 11a689c Detect templated text on quilt patch This branch includes the following new commits: new 11a689c Detect templated text on quilt patch The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch sl created (now c5ab10b)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch sl in repository lintian. at c5ab10b Use a sliding window match for pkg-config file This branch includes the following new commits: new c5ab10b Use a sliding window match for pkg-config file The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch pre2.6.25 created (now c9f7a41)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch pre2.6.25 in repository lintian. at c9f7a41 Fix another false positive for minified source-is-missing This branch includes the following new commits: new c9f7a41 Fix another false positive for minified source-is-missing The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch searchindex.js created (now 5c1d6bb)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch searchindex.js in repository lintian. at 5c1d6bb Add myself as author of cruft No new revisions were added by this update. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch tagrename created (now ab1af5d)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch tagrename in repository lintian. at ab1af5d Warn about renamed tag This branch includes the following new commits: new f7dbaff Allow tag to be renamed new 8fc290d Rename variable $tag to $rawtag in order to clarify code new ab1af5d Warn about renamed tag The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch symlink created (now 5e4bb9c)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch symlink in repository lintian. at 5e4bb9c t/tests/java-*: Require a recent enough java version No new revisions were added by this update. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch temp created (now 482bc90)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch temp in repository lintian. at 482bc90 Raise to error some warnings This branch includes the following new commits: new 482bc90 Raise to error some warnings The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch temp2 created (now 715c4cc)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch temp2 in repository lintian. at 715c4cc Raise to error some warnings This branch includes the following new commits: new 715c4cc Raise to error some warnings The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch test created (now b7d7d3c)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch test in repository lintian. at b7d7d3c Merge branch 'master' of git://git.debian.org/git/lintian/lintian This branch includes the following new commits: new 4c5f38f Fix test suite new b7d7d3c Merge branch 'master' of git://git.debian.org/git/lintian/lintian The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch tmp created (now 5c1211a)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch tmp in repository lintian. at 5c1211a Detect -dbgsym file in control file This branch includes the following new commits: new 5c1211a Detect -dbgsym file in control file The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch tmp4 created (now 921060b)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch tmp4 in repository lintian. at 921060b Detect oui db in source file This branch includes the following new commits: new 2115c4e Detect embdedded ieee-data package new 921060b Detect oui db in source file The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch test2 created (now fe27e04)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch test2 in repository lintian. at fe27e04 Detect files pointing to builddir No new revisions were added by this update. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch tmp2 created (now 15f161d)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch tmp2 in repository lintian. at 15f161d Release Lintian/2.5.23.1 into unstable No new revisions were added by this update. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch tmp3 created (now 784250e)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch tmp3 in repository lintian. at 784250e Fix False positive for space-in-std-shortname-in-dep5-copyright with alternative licenses This branch includes the following new commits: new 784250e Fix False positive for space-in-std-shortname-in-dep5-copyright with alternative licenses The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 02/02: Merge branch 'master' of git://git.debian.org/git/lintian/lintian
This is an automated email from the git hooks/post-receive script. rouca pushed a commit to branch test in repository lintian. commit b7d7d3c77139f0cc34fa3b8f48324009a57e0494 Merge: 4c5f38f 98b6760 Author: Tomasz Buchert Date: Mon Jul 14 14:41:52 2014 +0200 Merge branch 'master' of git://git.debian.org/git/lintian/lintian Signed-off-by: Bastien ROUCARIÈS -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch tmp5 created (now a68519b)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch tmp5 in repository lintian. at a68519b Detect package shipping apt sources This branch includes the following new commits: new bbac77c Raise severity of package-contains-timestamped-gzip. new a68519b Detect package shipping apt sources The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch tmph created (now 1c0ffac)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch tmph in repository lintian. at 1c0ffac Check also arch:all config script This branch includes the following new commits: new 1c0ffac Check also arch:all config script The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch tmpj created (now 88b05b7)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch tmpj in repository lintian. at 88b05b7 Improve description of dep5-copyright-license-name-not-unique This branch includes the following new commits: new 88b05b7 Improve description of dep5-copyright-license-name-not-unique The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch tmpjj created (now 139ed0b)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch tmpjj in repository lintian. at 139ed0b Warn if debian/watch uses deprecated githubredir.debian.net scraper This branch includes the following new commits: new 139ed0b Warn if debian/watch uses deprecated githubredir.debian.net scraper The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch tmpe created (now 3bc2cdc)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch tmpe in repository lintian. at 3bc2cdc Improve speed of privacy check This branch includes the following new commits: new 88732a9 test new 3bc2cdc Improve speed of privacy check The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch tmpmaster created (now aaa7841)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch tmpmaster in repository lintian. at aaa7841 Add github icons as privacy breach logo No new revisions were added by this update. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch tmpjs created (now aef82ec)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch tmpjs in repository lintian. at aef82ec Fix a flase positive in missing dir handling This branch includes the following new commits: new aef82ec Fix a flase positive in missing dir handling The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch tmpy created (now e60c9ad)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch tmpy in repository lintian. at e60c9ad Warn if debian/watch uses deprecated githubredir.debian.net scraper This branch includes the following new commits: new e60c9ad Warn if debian/watch uses deprecated githubredir.debian.net scraper The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch tmpmove created (now 1a1cbf9)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch tmpmove in repository lintian. at 1a1cbf9 export $COMPRESS_FILE_EXTENSIONS_OR_ALL a list of all compressed extension. This branch includes the following new commits: new 1a1cbf9 export $COMPRESS_FILE_EXTENSIONS_OR_ALL a list of all compressed extension. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch utf8fix created (now c163818)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch utf8fix in repository lintian. at c163818 read_dpkg_control using utf8 This branch includes the following new commits: new 7c1c056 Read file as a whole for utf8 testing new c163818 read_dpkg_control using utf8 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch tmpmaster2 created (now 87eafe4)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch tmpmaster2 in repository lintian. at 87eafe4 Correct grammar of fixme-placeholders test. No new revisions were added by this update. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] branch unique created (now 642508b)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch unique in repository lintian. at 642508b Detect if license-short-name are unique in source copyright This branch includes the following new commits: new 642508b Detect if license-short-name are unique in source copyright The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Privacy breach is no longer experimental
This is an automated email from the git hooks/post-receive script. rouca pushed a commit to branch master in repository lintian. commit 078f48e04f3111e31596906a6d18ac78591480e5 Author: Bastien ROUCARIÈS Date: Fri Sep 15 11:25:36 2017 +0200 Privacy breach is no longer experimental --- checks/files.desc| 1 - debian/changelog | 1 + t/tests/files-privacybreach/tags | 50 3 files changed, 26 insertions(+), 26 deletions(-) diff --git a/checks/files.desc b/checks/files.desc index 6e8f18f..330f2f8 100644 --- a/checks/files.desc +++ b/checks/files.desc @@ -1021,7 +1021,6 @@ Ref: policy 4.13 Tag: privacy-breach-generic Severity: important Certainty: wild-guess -Experimental: yes Info: This package creates a potential privacy breach by fetching data from an external website at runtime. Please remove these scripts or external HTML resources. diff --git a/debian/changelog b/debian/changelog index 3f36ada..3f21085 100644 --- a/debian/changelog +++ b/debian/changelog @@ -67,6 +67,7 @@ lintian (2.5.53) UNRELEASED; urgency=medium + [BR] Detect install of node package under /usr/lib/nodejs/[^/]*$ + [CL] Check for packages shipping compiled Java class files. Thanks Carnë Draug . (Closes: #873211) ++ [BR] Privacy breach is no longer experimental. * checks/init.d.desc: + [RG] Do not recommend a versioned dependency on lsb-base in init.d-script-needs-depends-on-lsb-base. (Closes: #847144) diff --git a/t/tests/files-privacybreach/tags b/t/tests/files-privacybreach/tags index 0f3adbf..6a20d19 100644 --- a/t/tests/files-privacybreach/tags +++ b/t/tests/files-privacybreach/tags @@ -53,28 +53,28 @@ E: files-privacybreach: privacy-breach-uses-embedded-file usr/share/files-privac E: files-privacybreach: privacy-breach-uses-embedded-file usr/share/files-privacy-breach/privacy-breach-may-use-debian-package/libjs-openlayers.html You may use libjs-openlayers package. (http://openlayers.org/api/openlayers.js) E: files-privacybreach: privacy-breach-uses-embedded-file usr/share/files-privacy-breach/privacy-breach-may-use-debian-package/libjs-prototype.html You may use libjs-prototype package. (https://ajax.googleapis.com/ajax/libs/prototype/1.7.0.0/prototype.js) E: files-privacybreach: privacy-breach-w3c-valid-html usr/share/files-privacy-breach/privacy-breach-w3c-valid-html/htmlvalid.html (http://www.w3.org/icons/valid-xhtml10) -X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/applet.html (//1984.os/trackme2) -X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/applet.html (http://1984.os/trackme) -X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/audio.html (ftp://1984.os/tuxistrackingme.ogg) -X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/audiotrack.html (http://1984.os/notracking.vtt) -X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/div.html (//trackme.1984/index-3.html) -X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/div.html (http://trackme.1984/index-2.html) -X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/embed.html (//1984.os/givemydata2.swf) -X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/embed.html (http://1984.os/givemydata.swf) -X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/externalimg.xml (http://1984.ow/bigbrotheriswatchingyou.png) -X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/frame.html (http://1984.os/trackme_frame_c.htm) -X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/genericwebsite.html (http://www.example.com/trackme.js) -X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/googlefontapi.html (http://fonts.googleapis.com/css?family=open+sans) -X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/iframe.html (http://1984.ow/bigbrotheriswatchingyou.html) -X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/import.css (http://1984.wo/importtracking.css) -X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/importcss.html (http://trackme.css/track.css) -X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/input.html (http://1984.os/hiddentrackme.png) -X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy
[lintian] branch master updated (40e4668 -> 078f48e)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch master in repository lintian. from 40e4668 spelling: Add another correction new 078f48e Privacy breach is no longer experimental The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/files.desc| 1 - debian/changelog | 1 + t/tests/files-privacybreach/tags | 50 3 files changed, 26 insertions(+), 26 deletions(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Bug#889102: [lintian] Please detect source missing .wasm file
Package: lintian Version: 2.5.72 Severity: normal wasm are a new javascript to rust stuff. But source is still missing. See for instance node-source-map package under lib/*.wasm File give: mappings.wasm: WebAssembly (wasm) binary module version 0x1 (MVP) Will take it signature.asc Description: This is a digitally signed message part.
[lintian] 01/01: Detect wasm prebuilt file
This is an automated email from the git hooks/post-receive script.
rouca pushed a commit to branch master
in repository lintian.
commit 740e6738e364f18662264d5cdd14552bc869a54b
Author: Bastien ROUCARIÈS
Date: Fri Feb 2 10:48:37 2018 +0100
Detect wasm prebuilt file
wasm have the potential to be like minified javascript.
Detect early
---
checks/cruft.desc | 12
data/cruft/warn-file-type | 1 +
debian/changelog | 3 +++
t/tests/cruft-wasm/desc| 10 ++
t/tests/cruft-wasm/pre_upstream| 11 +++
t/tests/cruft-wasm/tags| 2 ++
t/tests/cruft-wasm/upstream/README | 1 +
7 files changed, 40 insertions(+)
diff --git a/checks/cruft.desc b/checks/cruft.desc
index d3cfeef..e4ec969 100644
--- a/checks/cruft.desc
+++ b/checks/cruft.desc
@@ -537,6 +537,18 @@ Info: The source tarball contains a prebuilt binary for
Microsoft Windows.
the upstream distribution instead. If not, you may want to ask upstream
to provide source-only tarballs.
+Tag: source-contains-prebuilt-wasm-binary
+Severity: pedantic
+Certainty: certain
+Info: The source tarball contains a prebuilt binary wasm object.
+ They are usually provided for the convenience of users. These files
+ usually just take up space in the tarball and need to be rebuilt from
+ source.
+ .
+ Check if upstream also provides source-only tarballs that you can use as
+ the upstream distribution instead. If not, you may want to ask upstream
+ to provide source-only tarballs.
+
Tag: source-contains-waf-binary
Severity: important
Certainty: certain
diff --git a/data/cruft/warn-file-type b/data/cruft/warn-file-type
index 22b9c36..dd60910 100644
--- a/data/cruft/warn-file-type
+++ b/data/cruft/warn-file-type
@@ -15,3 +15,4 @@ source-contains-prebuilt-javascript-object ~~ .*
source-contains-prebuilt-python-object ~~ ^python \s \d(\.\d+)? \s
byte-compiled~~ .*
~~ s/(?i)(?:\.cpython-\d{2}|\.pypy)?\.py[co]$/.py/
source-contains-prebuilt-silverlight-object ~~ ^Zip \s archive \s data
~~ (?i)\.xac$
source-contains-prebuilt-windows-binary ~~
\b(?:PE(?:32|64)|(?:MS-DOS|COFF)\s executable)\b
+source-contains-prebuilt-wasm-binary~~ ^WebAssembly \s \(wasm\) \s
binary \s module
diff --git a/debian/changelog b/debian/changelog
index 57a3bd0..2ed559f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,9 @@ lintian (2.5.74) UNRELEASED; urgency=medium
XXX: generate tag summary
+ * checks/cruft.{desc}:
++ [BR] Check for wasm file. (Closes: #889102)
+
-- Chris Lamb Sat, 03 Feb 2018 10:51:52 +
lintian (2.5.73) unstable; urgency=medium
diff --git a/t/tests/cruft-wasm/desc b/t/tests/cruft-wasm/desc
new file mode 100644
index 000..d9cf8dd
--- /dev/null
+++ b/t/tests/cruft-wasm/desc
@@ -0,0 +1,10 @@
+Testname: cruft-wasm
+Version: 1.0-1
+Description: Misc errors related to wasm
+Skeleton: pedantic
+Options: --pedantic -I -E
+Architecture: any
+Type: non-native
+Test-For:
+ source-contains-prebuilt-wasm-binary
+Test-Depends: file (>= 1:5.32)
diff --git a/t/tests/cruft-wasm/pre_upstream b/t/tests/cruft-wasm/pre_upstream
new file mode 100755
index 000..12344f9
--- /dev/null
+++ b/t/tests/cruft-wasm/pre_upstream
@@ -0,0 +1,11 @@
+#!/bin/sh
+#
+# Create all the various junk that shouldn't exist in the diff so that we can
+# trigger all the tags.
+
+set -e
+dir="$1"
+srcdir="$1"
+
+printf "\0asm\001\0\0\0" > "$srcdir/fake.wasm"
+
diff --git a/t/tests/cruft-wasm/tags b/t/tests/cruft-wasm/tags
new file mode 100644
index 000..3401a43
--- /dev/null
+++ b/t/tests/cruft-wasm/tags
@@ -0,0 +1,2 @@
+P: cruft-wasm source: debian-watch-does-not-check-gpg-signature
+P: cruft-wasm source: source-contains-prebuilt-wasm-binary fake.wasm
diff --git a/t/tests/cruft-wasm/upstream/README
b/t/tests/cruft-wasm/upstream/README
new file mode 100644
index 000..a6a4fce
--- /dev/null
+++ b/t/tests/cruft-wasm/upstream/README
@@ -0,0 +1 @@
+This include fake wasm file
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (6c92f7d -> 740e673)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch master in repository lintian. from 6c92f7d Open new changelog entry for 2.5.74. new 740e673 Detect wasm prebuilt file The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/cruft.desc | 12 data/cruft/warn-file-type | 1 + debian/changelog | 3 +++ t/tests/cruft-wasm/desc| 10 ++ t/tests/cruft-wasm/pre_upstream| 11 +++ t/tests/cruft-wasm/tags| 2 ++ t/tests/cruft-wasm/upstream/README | 1 + 7 files changed, 40 insertions(+) create mode 100644 t/tests/cruft-wasm/desc create mode 100755 t/tests/cruft-wasm/pre_upstream create mode 100644 t/tests/cruft-wasm/tags create mode 100644 t/tests/cruft-wasm/upstream/README -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/03: Detect new fragment for google cse
This is an automated email from the git hooks/post-receive script.
rouca pushed a commit to branch master
in repository lintian.
commit aaf6a73f04718e61f56fbc79b4ec6613ec4c2078
Author: Bastien ROUCARIÈS
Date: Sun Feb 4 22:36:55 2018 +0100
Detect new fragment for google cse
Signed-off-by: Bastien ROUCARIÈS
---
data/files/privacy-breaker-fragments | 7 ---
debian/changelog | 3 +++
.../debian/src/privacy-breach-google-cse/search.js | 14 ++
t/tests/files-privacybreach/tags | 1 +
4 files changed, 22 insertions(+), 3 deletions(-)
diff --git a/data/files/privacy-breaker-fragments
b/data/files/privacy-breaker-fragments
index 6412c19..2a329d0 100644
--- a/data/files/privacy-breaker-fragments
+++ b/data/files/privacy-breaker-fragments
@@ -19,11 +19,12 @@ customsearchcontrol~~
google\.search\.customsearchcontrol\s*\(\s*'
google.load~~ google\.load\s*\(\s*'search'
~~
privacy-breach-google-cse
customsearchengine ~~
~~
privacy-breach-google-cse
partner-pub~~ value\s*=\s*"partner-pub-\d+:?\d+"
~~
privacy-breach-google-cse
+cse.js ~~ //www[.]google[.]com/cse/cse[.]js\?cx[=]
~~
privacy-breach-google-cse
plusone~~
(?:]*>
~~ privacy-breach-facebook
piwik ~~
(?:piwik_url\s*=|[\'"]piwik\.js[\'\"]|end\s+piwik\h+(?:tag|code)|[\'\"]settrackerurl[\'\"])
~~ privacy-breach-piwik
pkbaseurl ~~ pkbaseurl\s*=
~~
privacy-breach-piwik
diff --git a/debian/changelog b/debian/changelog
index 1a2a138..7856ee0 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -18,6 +18,9 @@ lintian (2.5.74) UNRELEASED; urgency=medium
maintainer-script-should-not-use-recursive-chown-or-chmod tag.
Heavily based on a patch by Daniel Kahn Gillmor - thanks!
(Closes: #889489)
+
+ * data/files/privacy-breaker-fragments:
++ [BR] Detects new fragments for google cse
* commands/reporting-{html-reports,lintian-harness}.pm:
+ [NT] Register packages that fail during archive wide processing.
diff --git
a/t/tests/files-privacybreach/debian/src/privacy-breach-google-cse/search.js
b/t/tests/files-privacybreach/debian/src/privacy-breach-google-cse/search.js
new file mode 100644
index 000..001a08b
--- /dev/null
+++ b/t/tests/files-privacybreach/debian/src/privacy-breach-google-cse/search.js
@@ -0,0 +1,14 @@
+
+
+
+ (function() {
+var cx = '006134137889097767902:turn9fku95u';
+var gcse = document.createElement('offline-script');
+gcse.type = 'text/javascript';
+gcse.async = true;
+gcse.src = (document.location.protocol == 'https:' ? 'https:' : 'http:') +
+'//www.google.com/cse/cse.js?cx=' + cx;
+var s = document.getElementsByTagName('offline-script')[0];
+s.parentNode.insertBefore(gcse, s);
+ })();
+
diff --git a/t/tests/files-privacybreach/tags b/t/tests/files-privacybreach/tags
index f466087..36a6151 100644
--- a/t/tests/files-privacybreach/tags
+++ b/t/tests/files-privacybreach/tags
@@ -30,6 +30,7 @@ E: files-privacybreach: privacy-breach-google-cse
usr/share/files-privacy-breach
E: files-privacybreach: privacy-breach-google-cse
usr/share/files-privacy-breach/privacy-breach-google-cse/googlecseformtracking.xml
E: files-privacybreach: privacy-breach-google-cse
usr/share/files-privacy-breach/privacy-breach-google-cse/googlecseimagemagick.js
E: files-privacybreach: privacy-breach-google-cse
usr/share/files-privacy-breach/privacy-breach-google-cse/googlecsejs.xml
(http://www.google.fr/coop/cse/brand?form=cse-search-box&lang=en)
+E: files-privacybreach: privacy-breach-google-cse
usr/share/files-privacy-breach/privacy-breach-google-cse/search.js
E: files-privacybreach: privacy-breach-google-plus
usr/share/files-privacy-breach/privacy-breach-google-plus/asyncload.html
E: files-privacybreach: privacy-breach-google-plus
usr/share/files-privacy-breach/privacy-breach-google-plus/explicitload.html
(https://apis.google.com/js/plusone.js)
E: files-privacybreach: privacy-breach-google-plus
usr/share/files-privacy-breach/privacy-breach-google-plus/simplebutton.xml
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] 03/03: Improve debugging for tag/url
This is an automated email from the git hooks/post-receive script.
rouca pushed a commit to branch master
in repository lintian.
commit 918e9265add984f6bb1668590e8a91e9eb0b37e5
Author: Bastien ROUCARIÈS
Date: Sun Feb 4 22:46:02 2018 +0100
Improve debugging for tag/url
---
checks/files.pm | 2 +-
t/tests/files-privacybreach/tags | 50
2 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/checks/files.pm b/checks/files.pm
index 51ef64d..a6e8edd 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -2104,7 +2104,7 @@ sub _check_tag_url_privacy_breach {
# generic case
unless (exists $privacybreachhash->{'tag-generic-'.$website}){
-tag 'privacy-breach-generic', $file, "($url)";
+tag 'privacy-breach-generic', $file, "[$fulltag] ($url)";
$privacybreachhash->{'tag-generic-'.$website} = 1;
}
return;
diff --git a/t/tests/files-privacybreach/tags b/t/tests/files-privacybreach/tags
index 817bbd1..cfcf319 100644
--- a/t/tests/files-privacybreach/tags
+++ b/t/tests/files-privacybreach/tags
@@ -54,28 +54,28 @@ E: files-privacybreach: privacy-breach-uses-embedded-file
usr/share/files-privac
E: files-privacybreach: privacy-breach-uses-embedded-file
usr/share/files-privacy-breach/privacy-breach-may-use-debian-package/libjs-openlayers.html
You may use the libjs-openlayers package.
(http://openlayers.org/api/openlayers.js)
E: files-privacybreach: privacy-breach-uses-embedded-file
usr/share/files-privacy-breach/privacy-breach-may-use-debian-package/libjs-prototype.html
You may use the libjs-prototype package.
(https://ajax.googleapis.com/ajax/libs/prototype/1.7.0.0/prototype.js)
E: files-privacybreach: privacy-breach-w3c-valid-html
usr/share/files-privacy-breach/privacy-breach-w3c-valid-html/htmlvalid.html
(http://www.w3.org/icons/valid-xhtml10)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/applet.html
(//1984.os/trackme2)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/applet.html
(http://1984.os/trackme)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/audio.html
(ftp://1984.os/tuxistrackingme.ogg)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/audiotrack.html
(http://1984.os/notracking.vtt)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/div.html
(//trackme.1984/index-3.html)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/div.html
(http://trackme.1984/index-2.html)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/embed.html
(//1984.os/givemydata2.swf)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/embed.html
(http://1984.os/givemydata.swf)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/externalimg.xml
(http://1984.ow/bigbrotheriswatchingyou.png)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/frame.html
(http://1984.os/trackme_frame_c.htm)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/genericwebsite.html
(http://www.example.com/trackme.js)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/googlefontapi.html
(http://fonts.googleapis.com/css?family=open+sans)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/iframe.html
(http://1984.ow/bigbrotheriswatchingyou.html)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/import.css
(http://1984.wo/importtracking.css)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/importcss.html
(http://trackme.css/track.css)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/input.html
(http://1984.os/hiddentrackme.png)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/link.xml
(http://1984.org/style.css)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/object.html
(https://1984.os/hellotrackme.swf)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/source.html
(https://1984.os/tracking.mp3)
-W: files-privacybreach: privacy-breach-generic
usr/share/files-privacy-breach/privacy-breach-generic/track.html
(http://1984.os/notracking.vtt)
-W: files-privacybrea
[lintian] branch master updated (470de0e -> 918e926)
This is an automated email from the git hooks/post-receive script. rouca pushed a change to branch master in repository lintian. from 470de0e d/control: Add comment related to the libfile-basedir-perl dependency new aaf6a73 Detect new fragment for google cse new 34a907c Add debug for javascript fragment new 918e926 Improve debugging for tag/url The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/files.pm| 7 +- data/files/privacy-breaker-fragments | 7 +- debian/changelog | 5 + .../debian/src/privacy-breach-google-cse/search.js | 14 +++ t/tests/files-privacybreach/tags | 111 +++-- 5 files changed, 83 insertions(+), 61 deletions(-) create mode 100644 t/tests/files-privacybreach/debian/src/privacy-breach-google-cse/search.js -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Bug#692616: [lintian] patch
Package: lintian
Version: 2.5.10.2
control: tags -1 patch
A patch
--
Dr-Ing Bastien ROUCARIÈS uUniversité de Cergy/SATIE ENS Cachan
From 1652ca48021dd76cdcca785243f3de0ef9db1be0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bastien=20ROUCARI=C3=88S?=
Date: Tue, 11 Dec 2012 11:55:24 +0100
Subject: [PATCH] Add json checking
---
checks/cruft | 13 +
checks/cruft.desc |8
2 files changed, 21 insertions(+)
diff --git a/checks/cruft b/checks/cruft
index efd9b7a..f3249d9 100644
--- a/checks/cruft
+++ b/checks/cruft
@@ -406,6 +406,19 @@ sub find_cruft {
}
close F;
}
+
+# test license problem is source file (only text file)
+my $b = basename $name;
+if(-T $b) {
+open(my $F, '<', $b) or fail "can't open $name: $!";
+while(my $line = <$F>) {
+ # json evil license
+ if($line =~ m/Software\s+shall\s+be\s+used\s+for\s+Good\s*,?\s*not\s+Evil/i) {
+ tag 'license-problem-json-evil', $name;
+ }
+}
+close $F or fail "can not close opened file $name: $!"
+}
}
1;
diff --git a/checks/cruft.desc b/checks/cruft.desc
index 3c8d31d..b176347 100644
--- a/checks/cruft.desc
+++ b/checks/cruft.desc
@@ -478,3 +478,11 @@ Info: The given control file uses CRLF as line terminator
CR character in the file:
.
sed -i 's/\r//g' path/to/file
+
+Tag: license-problem-json-evil
+Severity: serious
+Certainty: possible
+Info: The given source file is copyrighted under the non free
+ license of json and the infamous clause:
+ The Software shall be used for Good, not Evil.
+Ref: http://wiki.debian.org/qa.debian.org/jsonevil
--
1.7.10.4
Bug#693918: patch
Package: lintian
Version: 2.5.10.2
control: retitle -1 [new check] Add check for missing keywords field in
.desktop file
control: tag -1 + patch
Patch here
--
Dr-Ing Bastien ROUCARIÈS uUniversité de Cergy/SATIE ENS Cachan
From d4363231a0d1ca72fe4625e578e2e65ed35bc238 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bastien=20ROUCARI=C3=88S?=
Date: Wed, 12 Dec 2012 07:35:22 +0100
Subject: [PATCH] Add desktop file with no keywords warning
---
checks/menu-format |8
checks/menu-format.desc | 11 +++
2 files changed, 19 insertions(+)
diff --git a/checks/menu-format b/checks/menu-format
index 34de8fa..1ad1743 100644
--- a/checks/menu-format
+++ b/checks/menu-format
@@ -95,6 +95,7 @@ my %known_desktop_keys = map { $_ => 1 }
Comment
Icon
Hidden
+ Keywords
OnlyShowIn
NotShowIn
TryExec
@@ -648,6 +649,13 @@ sub VerifyDesktopFile {
}
}
+# test if missing Keywords(only if NoDisplay is not set)
+if (!defined $vals{NoDisplay}) {
+if(!defined $vals{Keywords}) {
+tag 'desktop-entry-lacks-Keywords-entry', $file;
+}
+}
+
# Only test whether the binary is in the package if the desktop file is
# directly under /usr/share/applications. Too many applications use
# desktop files for other purposes with custom paths.
diff --git a/checks/menu-format.desc b/checks/menu-format.desc
index 1fc567d..e5e5ad0 100644
--- a/checks/menu-format.desc
+++ b/checks/menu-format.desc
@@ -306,6 +306,17 @@ Info: The categories for this desktop entry do not contain any Main
useful for checking the syntax of desktop entries.
Ref: http://standards.freedesktop.org/menu-spec/1.0/apa.html
+Tag: desktop-entry-lacks-Keywords-entry
+Severity: minor
+Certainty: certain
+Info: The categories for this desktop entry do not contain any
+ Keywords. Keywords should not be redundant with the values of Name
+ or GenericName.
+ .
+ The desktop-file-validate tool in the desktop-file-utils package is
+ useful for checking the syntax of desktop entries.
+Ref: http://standards.freedesktop.org/desktop-entry-spec/1.0/apc.html
+
Tag: desktop-entry-uses-reserved-category
Severity: normal
Certainty: certain
--
1.7.10.4
Bug#693918: patch
Package: lintian
Version: 2.5.10.2
control: retitle -1 [new check] Add check for missing keywords field in
.desktop file
control: tag -1 + patch
Patch here
--
Dr-Ing Bastien ROUCARIÈS uUniversité de Cergy/SATIE ENS Cachan
From d4363231a0d1ca72fe4625e578e2e65ed35bc238 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bastien=20ROUCARI=C3=88S?=
Date: Wed, 12 Dec 2012 07:35:22 +0100
Subject: [PATCH] Add desktop file with no keywords warning
---
checks/menu-format |8
checks/menu-format.desc | 11 +++
2 files changed, 19 insertions(+)
diff --git a/checks/menu-format b/checks/menu-format
index 34de8fa..1ad1743 100644
--- a/checks/menu-format
+++ b/checks/menu-format
@@ -95,6 +95,7 @@ my %known_desktop_keys = map { $_ => 1 }
Comment
Icon
Hidden
+ Keywords
OnlyShowIn
NotShowIn
TryExec
@@ -648,6 +649,13 @@ sub VerifyDesktopFile {
}
}
+# test if missing Keywords(only if NoDisplay is not set)
+if (!defined $vals{NoDisplay}) {
+if(!defined $vals{Keywords}) {
+tag 'desktop-entry-lacks-Keywords-entry', $file;
+}
+}
+
# Only test whether the binary is in the package if the desktop file is
# directly under /usr/share/applications. Too many applications use
# desktop files for other purposes with custom paths.
diff --git a/checks/menu-format.desc b/checks/menu-format.desc
index 1fc567d..e5e5ad0 100644
--- a/checks/menu-format.desc
+++ b/checks/menu-format.desc
@@ -306,6 +306,17 @@ Info: The categories for this desktop entry do not contain any Main
useful for checking the syntax of desktop entries.
Ref: http://standards.freedesktop.org/menu-spec/1.0/apa.html
+Tag: desktop-entry-lacks-Keywords-entry
+Severity: minor
+Certainty: certain
+Info: The categories for this desktop entry do not contain any
+ Keywords. Keywords should not be redundant with the values of Name
+ or GenericName.
+ .
+ The desktop-file-validate tool in the desktop-file-utils package is
+ useful for checking the syntax of desktop entries.
+Ref: http://standards.freedesktop.org/desktop-entry-spec/1.0/apc.html
+
Tag: desktop-entry-uses-reserved-category
Severity: normal
Certainty: certain
--
1.7.10.4
Bug#717633: [new check] check for dep-3 patch template
Package: lintian Version: 2.5.13 Severity: wishlist maxima debian/patches/5.29-refresh contains the following patch: Description: TODO: Put a short summary on the line above and replace this paragraph with a longer explanation of this change. Complete the meta-information with other relevant fields (see below for details). To make it easier, the information below has been extracted from the changelog. Adjust it or drop it. . maxima (5.30.0-1) UNRELEASED; urgency=low . * New upstream release Author: Camm Maguire --- The information above should follow the Patch Tagging Guidelines, please checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here are templates for supplementary fields that you might want to add: Origin: , Bug: Bug-Debian: http://bugs.debian.org/ Bug-Ubuntu: https://launchpad.net/bugs/ Forwarded: Reviewed-By: Last-Update: -- Please warm about this patch lacking documentation Bastien -- Dr-Ing Bastien ROUCARIÈS Université de Cergy/SATIE ENS Cachan -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1926936.69550.1374567238682.JavaMail.root@kuzco
Bug#720903: [general] Please allow lintian to not run in isolation
Package: lintian Version: 2.5.14 Severity: normal control: tags -1 + wontfix Some of the bug report here need to break the assumption of running linitan in isolation. According to manual: >same source analysis: Lintian checks packages in small isolated groups based >on the source package. Requiring the presence of all the dependencies to >provide the full results make it harder to run lintian (not to mention, it >makes "deterministic replay-ability" a lot harder as well). Tag this bug as wont fix -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/6971662.171413.1377499873091.JavaMail.root@kuzco
Bug#684286: [PATCH] Add precision about no-upstream-changelog.
Patch here -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1377720848-18307-1-git-send-email-roucaries.bast...@gmail.com
Bug#684286: [PATCH] Add precision about no-upstream-changelog.
Add advices about missing changelog: get in touch with upstream. --- checks/changelog-file.desc |3 +++ 1 file changed, 3 insertions(+) diff --git a/checks/changelog-file.desc b/checks/changelog-file.desc index a6269be..39f3d96 100644 --- a/checks/changelog-file.desc +++ b/checks/changelog-file.desc @@ -98,6 +98,9 @@ Info: The package does not install an upstream changelog file. If upstream package and add symlinks to the other packages, but this requires there be dependencies between the packages. Some only include it in a "central" binary package and omit it from more ancillary packages. + . + If upstream does not provide any meaningful changelog, you should get + in touch with them and persuade them to start providing one. Ref: policy 12.7 Tag: wrong-name-for-debian-changelog-file -- 1.7.10.4 -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1377720848-18307-2-git-send-email-roucaries.bast...@gmail.com
Bug#460174: [PATCH 1/3] Factorize the rules check between required and recommanded
Use a single hash for the rules checking between required and recommended.
---
checks/rules.pm | 46 ++
1 file changed, 22 insertions(+), 24 deletions(-)
diff --git a/checks/rules.pm b/checks/rules.pm
index bfb667c..ae272c5 100644
--- a/checks/rules.pm
+++ b/checks/rules.pm
@@ -17,6 +17,7 @@ package Lintian::rules;
use strict;
use warnings;
use autodie;
+use Carp qw(croak);
use List::MoreUtils qw(any);
@@ -94,10 +95,13 @@ my @RULE_CLEAN_DEPENDS =(
);
# The following targets are required per Policy.
-my %required = map { $_ => 1 } qw(build binary binary-arch binary-indep clean);
+my %required = map { $_ => 'required' } qw(build binary binary-arch
binary-indep clean);
# The following targets are recommended per Policy.
-my %recommended = map { $_ => 1 } qw(build-arch build-indep);
+my %recommended = map { $_ => 'recommended' } qw(build-arch build-indep);
+
+# The following rules are required or recommanded per policy
+my %policyrules = ( %required, %recommended);
# Rules about required debhelper command ordering. Each command is put into a
# class and the tag is issued if they're called in the wrong order for the
@@ -167,8 +171,7 @@ sub run {
my $targets = $KNOWN_MAKEFILES->value($makefile);
if (defined $targets){
foreach my $target (split m/\s*+,\s*+/o, $targets){
-$seen{$target}++ if $required{$target};
-$seen{$target}++ if $recommended{$target};
+$seen{$target}++ if $policyrules{$target};
}
} else {
$includes = 1;
@@ -257,15 +260,13 @@ sub run {
# we ought to "delay" it was a "=" variable rather
# than ":=" or "+=".
for (split m/\s++/o, rstrip($val)) {
-$seen{$_}++ if $required{$_};
-$seen{$_}++ if $recommended{$_};
+$seen{$_}++ if $policyrules{$_};
}
last;
}
# We don't know, so just mark the target as seen.
}
-$seen{$_}++ if $required{$_};
-$seen{$_}++ if $recommended{$_};
+$seen{$_}++ if $policyrules{$_};
}
next; #.PHONY implies the rest will not match
}
@@ -282,11 +283,8 @@ sub run {
if ($target =~ m/%/o) {
my $pattern = quotemeta $target;
$pattern =~ s/\\%/.*/g;
-for my $required (keys %required) {
-$seen{$required}++ if $required =~ m/$pattern/;
-}
-for my $recommended (keys %recommended) {
-$seen{$recommended}++ if $recommended =~ m/$pattern/;
+for my $policyrules (keys %policyrules) {
+$seen{$policyrules}++ if $policyrules =~ m/$pattern/;
}
} else {
# Is it $(VAR) ?
@@ -299,15 +297,13 @@ sub run {
# than ":=" or "+=".
local $_;
for (split m/\s++/o, rstrip($val)) {
-$seen{$_}++ if $required{$_};
-$seen{$_}++ if $recommended{$_};
+$seen{$_}++ if $policyrules{$_};
}
last;
}
# We don't know, so just mark the target as seen.
}
-$seen{$target}++ if $required{$target};
-$seen{$target}++ if $recommended{$target};
+$seen{$target}++ if $policyrules{$target};
}
if (any { $target =~ /$_/ } @arch_rules) {
push(@arch_rules, @depends);
@@ -365,14 +361,16 @@ sub run {
unless ($includes) {
my $rec = 0;
# Make sure all the required rules were seen.
-for my $target (sort keys %required) {
-tag 'debian-rules-missing-required-target', $target
- unless $seen{$target};
-}
-for my $target (sort keys %recommended) {
+for my $target (sort keys %policyrules) {
unless ($seen{$target}) {
-tag 'debian-rules-missing-recommended-target', $target;
-$rec++;
+if($policyrules{$target} eq 'required') {
+tag 'debian-rules-missing-required-target', $target;
+} elsif ($policyrules{$target} eq 'recommended') {
+tag 'debian-rules-missing-recommended-target', $target;
+$rec++;
+} else {
+croak 'unknown type of policy rules';
+}
Bug#460174: [PATCH 2/3] Add a check for get-orig-source
This will close #460174.
---
checks/rules.desc | 10 ++
checks/rules.pm| 23 ---
t/tests/rules-missing-targets/desc |4 +++-
t/tests/rules-missing-targets/tags |1 +
4 files changed, 30 insertions(+), 8 deletions(-)
diff --git a/checks/rules.desc b/checks/rules.desc
index 5a9dfe7..b8f29d5 100644
--- a/checks/rules.desc
+++ b/checks/rules.desc
@@ -59,6 +59,16 @@ Info: The debian/rules file for this package does
not provide
.
These targets will be required by policy in the future, so should be
added to prevent future breakage.
+
+Tag: debian-rules-missing-good-practice-target-dfsg
+Severity: normal
+Certainty: certain
+Ref: policy 4.9, devref 6.7.8.2
+Info: The debian/rules file for this package does not provide
+ one of the good practice targets.
+ .
+ If your packaged is repacked from non dfsg source, you should add a
+ get-orig-source target.
Tag: debian-rules-uses-deprecated-makefile
Severity: normal
diff --git a/checks/rules.pm b/checks/rules.pm
index ae272c5..e27bc34 100644
--- a/checks/rules.pm
+++ b/checks/rules.pm
@@ -98,10 +98,12 @@ my @RULE_CLEAN_DEPENDS =(
my %required = map { $_ => 'required' } qw(build binary binary-arch
binary-indep clean);
# The following targets are recommended per Policy.
-my %recommended = map { $_ => 'recommended' } qw(build-arch build-indep);
+my %recommendedbuild = map { $_ => 'recommended_allindep' } qw(build-arch
build-indep);
-# The following rules are required or recommanded per policy
-my %policyrules = ( %required, %recommended);
+my %goodpracticedfsg = map { $_ => 'goodpractice_dfsg' } qw(get-orig-source);
+
+# The following rules are required or recommended per policy
+my %policyrules = ( %required, %recommendedbuild, %goodpracticedfsg);
# Rules about required debhelper command ordering. Each command is put into a
# class and the tag is issued if they're called in the wrong order for the
@@ -129,6 +131,9 @@ sub run {
}
my $architecture = $info->field('architecture', '');
+my $version = $info->field('version');
+# If the version field is missing, we assume a neutral non-native one.
+$version = '0-1' unless defined $version;
open(my $rules_fd, '<', $rules);
@@ -359,22 +364,26 @@ sub run {
close($rules_fd);
unless ($includes) {
-my $rec = 0;
+my $rec_allindep = 0;
# Make sure all the required rules were seen.
for my $target (sort keys %policyrules) {
unless ($seen{$target}) {
if($policyrules{$target} eq 'required') {
tag 'debian-rules-missing-required-target', $target;
-} elsif ($policyrules{$target} eq 'recommended') {
+} elsif ($policyrules{$target} eq 'recommended_allindep') {
tag 'debian-rules-missing-recommended-target', $target;
-$rec++;
+$rec_allindep++;
+} elsif ($policyrules{$target} eq 'goodpractice_dfsg') {
+if ($version =~ /(dfsg|debian|ds)/) {
+tag 'debian-rules-missing-good-practice-target-dfsg',
$target;
+}
} else {
croak 'unknown type of policy rules';
}
}
}
-if ($rec) {
+if ($rec_allindep) {
my $all = 0;
my $notall = 0;
foreach my $p ($group->get_processables) {
diff --git a/t/tests/rules-missing-targets/desc
b/t/tests/rules-missing-targets/desc
index f92d7bb..6069129 100644
--- a/t/tests/rules-missing-targets/desc
+++ b/t/tests/rules-missing-targets/desc
@@ -1,7 +1,9 @@
Testname: rules-missing-targets
Sequence: 6000
-Version: 1.0
+Version: 1.0+dfsg-1
+Type: non-native
Description: Test for missing targets in debian/rules
Test-For:
+ debian-rules-missing-good-practice-target-dfsg
debian-rules-missing-recommended-target
package-would-benefit-from-build-arch-targets
diff --git a/t/tests/rules-missing-targets/tags
b/t/tests/rules-missing-targets/tags
index ef2f56a..f5724c6 100644
--- a/t/tests/rules-missing-targets/tags
+++ b/t/tests/rules-missing-targets/tags
@@ -1,3 +1,4 @@
+W: rules-missing-targets source:
debian-rules-missing-good-practice-target-dfsg get-orig-source
W: rules-missing-targets source: debian-rules-missing-recommended-target
build-arch
W: rules-missing-targets source: debian-rules-missing-recommended-target
build-indep
W: rules-missing-targets source: package-would-benefit-from-build-arch-targets
--
1.7.10.4
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/1377723926-22741-3-git-send-email-roucaries.bast...@gmail.com
Bug#460174: Revised patch
This time using a specific tag for dfsg problem: [PATCH 1/3] Factorize the rules check between required and [PATCH 2/3] Add a check for get-orig-source [PATCH 3/3] Push to Lintian::data checking of rules -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1377723926-22741-1-git-send-email-roucaries.bast...@gmail.com
Bug#460174: [PATCH 3/3] Push to Lintian::data checking of rules
Push to an external data the checking of required/recommended rule.
---
checks/rules.pm | 37 ++---
data/rules/policy-rules | 15 +++
2 files changed, 29 insertions(+), 23 deletions(-)
create mode 100644 data/rules/policy-rules
diff --git a/checks/rules.pm b/checks/rules.pm
index e27bc34..21fc8f1 100644
--- a/checks/rules.pm
+++ b/checks/rules.pm
@@ -34,6 +34,7 @@ our $ANYPYTHON_DEPEND
my $KNOWN_MAKEFILES = Lintian::Data->new('rules/known-makefiles', '\|\|');
my $DEPRECATED_MAKEFILES = Lintian::Data->new('rules/deprecated-makefiles');
+our $POLICYRULES = Lintian::Data->new('rules/policy-rules', qr/\s++/);
# Certain build tools must be listed in Build-Depends even if there are no
# arch-specific packages because they're required in order to run the clean
@@ -94,17 +95,6 @@ my @RULE_CLEAN_DEPENDS =(
[quilt => qr'^\t\s*(\S+=\S+\s+)*quilt\s'],
);
-# The following targets are required per Policy.
-my %required = map { $_ => 'required' } qw(build binary binary-arch
binary-indep clean);
-
-# The following targets are recommended per Policy.
-my %recommendedbuild = map { $_ => 'recommended_allindep' } qw(build-arch
build-indep);
-
-my %goodpracticedfsg = map { $_ => 'goodpractice_dfsg' } qw(get-orig-source);
-
-# The following rules are required or recommended per policy
-my %policyrules = ( %required, %recommendedbuild, %goodpracticedfsg);
-
# Rules about required debhelper command ordering. Each command is put into a
# class and the tag is issued if they're called in the wrong order for the
# classes. Unknown commands won't trigger this flag.
@@ -176,7 +166,7 @@ sub run {
my $targets = $KNOWN_MAKEFILES->value($makefile);
if (defined $targets){
foreach my $target (split m/\s*+,\s*+/o, $targets){
-$seen{$target}++ if $policyrules{$target};
+$seen{$target}++ if $POLICYRULES->known($target);
}
} else {
$includes = 1;
@@ -265,13 +255,13 @@ sub run {
# we ought to "delay" it was a "=" variable rather
# than ":=" or "+=".
for (split m/\s++/o, rstrip($val)) {
-$seen{$_}++ if $policyrules{$_};
+$seen{$_}++ if $POLICYRULES->known($_);
}
last;
}
# We don't know, so just mark the target as seen.
}
-$seen{$_}++ if $policyrules{$_};
+$seen{$_}++ if $POLICYRULES->known($_);
}
next; #.PHONY implies the rest will not match
}
@@ -288,8 +278,8 @@ sub run {
if ($target =~ m/%/o) {
my $pattern = quotemeta $target;
$pattern =~ s/\\%/.*/g;
-for my $policyrules (keys %policyrules) {
-$seen{$policyrules}++ if $policyrules =~ m/$pattern/;
+foreach(my $rulebypolicy = $POLICYRULES->all) {
+$seen{$rulebypolicy}++ if $rulebypolicy =~ m/$pattern/;
}
} else {
# Is it $(VAR) ?
@@ -302,13 +292,13 @@ sub run {
# than ":=" or "+=".
local $_;
for (split m/\s++/o, rstrip($val)) {
-$seen{$_}++ if $policyrules{$_};
+$seen{$_}++ if $POLICYRULES->known($_);
}
last;
}
# We don't know, so just mark the target as seen.
}
-$seen{$target}++ if $policyrules{$target};
+$seen{$target}++ if $POLICYRULES->known($target);
}
if (any { $target =~ /$_/ } @arch_rules) {
push(@arch_rules, @depends);
@@ -366,19 +356,20 @@ sub run {
unless ($includes) {
my $rec_allindep = 0;
# Make sure all the required rules were seen.
-for my $target (sort keys %policyrules) {
+foreach my $target ($POLICYRULES->all) {
unless ($seen{$target}) {
-if($policyrules{$target} eq 'required') {
+my $typerule = $POLICYRULES->value($target);
+if($typerule eq 'required') {
tag 'debian-rules-missing-required-target', $target;
-} elsif ($policyrules{$target} eq 'recommended_allindep') {
+} elsif ($typerule eq 'recommended_allindep') {
tag 'debian-rules-missing-recommended-target', $target;
$rec_allindep++;
-} elsif ($policyrules{$target} eq 'goodpractice_dfsg') {
+} elsif ($typerule eq 'goodpracti
Bug#721252: [PATCH 2/3] Silent false positive in po file of gtk-doc
Gtk-doc use some <_:link-1> for no invariant section. Silent this false
positive.
---
checks/cruft.pm| 14 +
.../debian/src/oldfalsepositive/gtk-doc.po | 21
2 files changed, 35 insertions(+)
create mode 100644
t/tests/cruft-gfdl-invariants/debian/src/oldfalsepositive/gtk-doc.po
diff --git a/checks/cruft.pm b/checks/cruft.pm
index aeee3ea..d9fd2f6 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -618,6 +618,20 @@ sub find_cruft {
tag 'license-problem-gfdl-invariants',$name;
$licenseproblemhash{'gfdl-invariants'} = 1;
}
+} elsif (
+$gfdlsections =~ m{
+\A with \s+ the \s* <_: \s* link-\d+ \s* /> \s*
+being \s+ list \s+ their \s+ titles \s*,? \s*
+with \s+ the \s* <_: \s* link-\d+ \s* /> \s*
+being \s+ list \s*,\s*
+(?:and\s+)? with \s+ the \s* <_:\s* link-\d+ \s*
/> \s*
+being \s+ list}xiso
+) {
+# fix a false positive in .po file
+unless ($name =~ m/\.po$/) {
+tag 'license-problem-gfdl-invariants',$name;
+$licenseproblemhash{'gfdl-invariants'} = 1;
+}
} else {
tag 'license-problem-gfdl-invariants', $name,
"\"$gfdlsections\"";
$licenseproblemhash{'gfdl-invariants'} = 1;
diff --git
a/t/tests/cruft-gfdl-invariants/debian/src/oldfalsepositive/gtk-doc.po
b/t/tests/cruft-gfdl-invariants/debian/src/oldfalsepositive/gtk-doc.po
new file mode 100644
index 000..2f6f58d
--- /dev/null
+++ b/t/tests/cruft-gfdl-invariants/debian/src/oldfalsepositive/gtk-doc.po
@@ -0,0 +1,21 @@
+#: C/fdl-appendix.xml:79(sect1/para)
+msgid ""
+"A <_:quote-1/> is a named appendix or a front-matter section of the <_:"
+"link-2/> that deals exclusively with the relationship of the publishers or "
+"authors of the Document to the Document's overall subject (or to related "
+"matters) and contains nothing that could fall directly within that overall "
+"subject. (For example, if the Document is in part a textbook of mathematics, "
+"a Secondary Section may not explain any mathematics.) The relationship could "
+"be a matter of historical connection with the subject or with related "
+"matters, or of legal, commercial, philosophical, ethical or political "
+"position regarding them."
+msgstr ""
+"Une <_:quote-1/> désigne une annexe au <_:link-2/>, ou toute information "
+"indiquant les rapports entre l'auteur ou l'éditeur et le sujet (ou tout "
+"autre sujet connexe) du Document, sans toutefois être en rapport direct avec "
+"le sujet lui-même (par exemple, si le Document est un manuel de "
+"mathématiques, une Section secondaire ne traitera d'aucune notion "
+"mathématique). Cette section peut contenir des informations relatives à "
+"l'historique du Document, des sources documentaires, des dispositions "
+"légales, commerciales, philosophiques, ou des positions éthiques ou "
+"politiques susceptibles de concerner le sujet traité."
--
1.7.10.4
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/1378029548-9794-2-git-send-email-roucaries.bast...@gmail.com
Bug#721252: [PATCH 3/3] Check gfdl harder
Remove included in the the sentence the copy is included, in order to check
harder gfdl file.
---
checks/cruft.pm |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/checks/cruft.pm b/checks/cruft.pm
index d9fd2f6..09827c8 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -506,7 +506,7 @@ sub find_cruft {
index($block, 'license') > -1
&& $block =~ m/gnu (?:\s+|\s*<\/span>\s*|\s*\}\s+)? free \s+
documentation \s+ license (?'rawgfdlsections'.{0,1024}?)
- a \s+ copy \s+ of \s+ the \s+ license \s+ is \s+
included/xsm
+ a \s+ copy \s+ of \s+ the \s+ license \s+ is/xsm
) {
if (!exists $licenseproblemhash{'gfdl-invariants'}) {
my $rawgfdlsections = $+{rawgfdlsections};
--
1.7.10.4
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/1378029548-9794-3-git-send-email-roucaries.bast...@gmail.com
Bug#721252: [PATCH 1/3] Clean up gfdl detection
Instead of using a variable for space like expression, tranform every space
like expression to space.
This is a net win of about 5% on execution time
---
checks/cruft.pm | 112 +++
1 file changed, 55 insertions(+), 57 deletions(-)
diff --git a/checks/cruft.pm b/checks/cruft.pm
index ac2a9fc..aeee3ea 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -505,101 +505,99 @@ sub find_cruft {
if (
index($block, 'license') > -1
&& $block =~ m/gnu (?:\s+|\s*<\/span>\s*|\s*\}\s+)? free \s+
- documentation \s+ license (?'gfdlsections'.{0,1024}?)
+ documentation \s+ license (?'rawgfdlsections'.{0,1024}?)
a \s+ copy \s+ of \s+ the \s+ license \s+ is \s+
included/xsm
) {
if (!exists $licenseproblemhash{'gfdl-invariants'}) {
-my $gfdlsections = $+{gfdlsections};
-# local space
-my $s = qr{(?:
- \s | # regular space(s)
+my $rawgfdlsections = $+{rawgfdlsections};
+my $gfdlsections = $rawgfdlsections;
+
+# delete some tag consider as space
+# order from more specific to less specific
+$gfdlsections =~ s{(?:
+ ^[-\+!<>] | # diff/patch lines
+ ^\.\\\" | # man comments
\@c(?:omment)? | # Tex info comment
- [%\*\"\|\\] | # String, C-style comment/javadoc
indent, quotes for strings, pipe and antislash in some txt
\"\s*, | # String array (e.g.
"line1",\n"line2")
,\s*\" | # String array (e.g. "line1"\n
,"line2"), seen in findutils
- \\n | # Verbatim \n in string array
- \n[-\+!<>] | # diff/patch lines
- \n\.\\\"| # man comments
| # (X)HTML line breaks
- | # xml link
- | # a link
- | # html paragraph
+ ]*?> | # xml link
+ ]*?> | # a link
+ ]*?> | # html paragraph
\(\*note.*?::\) | # info file note
-)}xsmo;
+ \\n | # Verbatim \n in string array
+ \s*[,\.;]\s*\Z | # final punctuation
+ \A\s*[,\.;]\s* | # punctuation at the beginning
+ [%\*\"\|\\]# String, C-style comment/javadoc
indent, quotes for strings, pipe and antislash in some txt
+)}{ }gxms;
+
+# delete double spacing now
+$gfdlsections =~ s{\s+}{ }gsm;
+$gfdlsections =~ s{\A\s+}{}gsm;
+$gfdlsections =~ s{\s+\Z}{}gsm;
+
+$gfdlsections =~ s/
+\A \s* version \s+ \d+(?:\.\d+)? \s+
+(?:or \s+ any \s+ later \s+ version \s+)?
+published \s+ by \s+ the \s+ Free \s+ Software \s+
Foundation \s*
+(?: [,\.;] \s*)?
+//xism;
+
# GFDL license, assume it is bad unless it
# explicitly states it has no "bad sections".
if (
$gfdlsections =~ m/
-no $s* Invariant $s+ Sections? $s* ,?
- $s+ (?:with$s+)? (?:the$s+)? no $s+
Front(?:\\?-)?$s*Cover $s+ (?:Texts?)? $s* ,? $s+ (?:and$s+)?
- (?:with$s+)? (?:the$s+)? no $s+
Back(?:\\?-)?$s*Cover/xiso
+no \s* Invariant \s+ Sections? \s* ,?
+ \s+ (?:with\s+)? (?:the\s+)? no \s+
Front(?:\s*\\?-)?\s*Cover (?:\s+Texts?)? \s* ,? \s+ (?:and\s+)?
+ (?:with\s+)? (?:the\s+)? no \s+
Back(?:\s*\\?-)?\s*Cover/xiso
) {
# no invariant
} elsif (
$gfdlsections =~ m/
-no $s+ Invariant $s+ Sections?,?
- $s+ (?:no$s+)? Front(?:[\\]?-)? $s+ or
- $s+ (?:no$s+)? Back(?:[\\]?-)?$s*Cover $s+
Texts?/xiso
+no \s+ Invariant \s+ Sections?,?
+ \s+ (?:no\s+)? Front(?:\s*[\\]?-)? \s+ or
+ \s+ (?:no\s+)? Back(?:\s*[\\]?-)?\s*Cover \s+
Texts?/xiso
) {
# no invariant variant (dict-foldoc)
} elsif (
-$gfdlsection
Bug#721252: [PATCH 3/3] Check gfdl harder
Remove included in the the sentence the copy is included, in order to check
harder gfdl file.
---
checks/cruft.pm |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/checks/cruft.pm b/checks/cruft.pm
index 16f146f..818704f 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -506,7 +506,7 @@ sub find_cruft {
index($block, 'license') > -1
&& $block =~ m/gnu (?:\s+|\s*<\/span>\s*|\s*\}\s+)? free \s+
documentation \s+ license (?'rawgfdlsections'.{0,1024}?)
- a \s+ copy \s+ of \s+ the \s+ license \s+ is \s+
included/xsm
+ a \s+ copy \s+ of \s+ the \s+ license \s+ is/xsm
) {
if (!exists $licenseproblemhash{'gfdl-invariants'}) {
my $rawgfdlsections = $+{rawgfdlsections};
--
1.7.10.4
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/1378239591-27805-3-git-send-email-roucaries.bast...@gmail.com
