Bug#505857: lintian: false positive debian-watch-file-should-mangle-version

[Raphael Geissert]

Hi,

On 12 January 2018 at 12:37, Osamu Aoki  wrote:
[...]
> But what is this "[1]This is on my ToDo list for DEHS2 anyway." in bug
> report? Raphael, are you still working on something?

My work on DEHS2 is long dead, and I don't remember having actually
split uscan into a module - only checkbashisms.

Last time I looked at the code it seemed straight forward to at least
split the watch file parsing, the target download and parsing by watch
file version, and the version mangling stuff.
If that's still the case, perhaps it could be a very first version?

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net

Bug#505857: lintian: false positive debian-watch-file-should-mangle-version

[Osamu Aoki]

Hi,

Bug:
 https://bugs.debian.org/505857
 https://bugs.debian.org/884880 (cloned bug of above)

I just updated manpage of uscan to reduce stress of our fellow DDs for
Bug #884880.

I agree with
> 3.- Long term solution:
> Turn some portions of uscan into a perl module[1] and use it to extract the
> dversionmangle regex.

I agree uscan deserves more code refactoring and it should expose its
internal utilities to other codes.  Unfortunately, my skill and time is
not up for the task.

So I simply addressed Chris's concern https://bugs.debian.org/884880#57
by updating the manpage to point people to the pertinent information.  I
hope the recent checkin is good enough.
 57ea0c53 ("uscan: clarify the importance of version=4", 2018-01-12)

But what is this "[1]This is on my ToDo list for DEHS2 anyway." in bug
report? Raphael, are you still working on something?

Regards,

Osamu

Processed: Re: Bug#505857: lintian: false positive debian-watch-file-should-mangle-version

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> clone 505857 -1
Bug #505857 [lintian] [checks/watch-file] false positive 
debian-watch-file-should-mangle-version
Bug 505857 cloned as bug 884880
> reassign -1 devscripts 2.17.11
Bug #884880 [lintian] [checks/watch-file] false positive 
debian-watch-file-should-mangle-version
Bug reassigned from package 'lintian' to 'devscripts'.
No longer marked as found in versions lintian/2.0.0 and lintian/2.5.65.
No longer marked as fixed in versions lintian/2.5.54.
Bug #884880 [devscripts] [checks/watch-file] false positive 
debian-watch-file-should-mangle-version
Marked as found in versions devscripts/2.17.11.
> severity -1 wishlist
Bug #884880 [devscripts] [checks/watch-file] false positive 
debian-watch-file-should-mangle-version
Severity set to 'wishlist' from 'minor'
> retitle -1 [uscan] Please clarify that spaces in debian/watch "opts" are only 
> valid in version 4
Bug #884880 [devscripts] [checks/watch-file] false positive 
debian-watch-file-should-mangle-version
Changed Bug title to '[uscan] Please clarify that spaces in debian/watch "opts" 
are only valid in version 4' from '[checks/watch-file] false positive 
debian-watch-file-should-mangle-version'.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
505857: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505857
884880: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884880
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#505857: lintian: false positive debian-watch-file-should-mangle-version

[Chris Lamb]

clone 505857 -1
reassign -1 devscripts 2.17.11
severity -1 wishlist
retitle -1 [uscan] Please clarify that spaces in debian/watch "opts" are only 
valid in version 4
thanks

Hi Christoph,

> The warning goes away when I remove the space after the comma.
> 
> The version with the space is the syntax documented in uscan(1):
> 
>   Multiple options option1, option2, option3, ... can be set as
>   opts="option1, option2, option3,  ...  " .

Only for version=4. :)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#505857: lintian: false positive debian-watch-file-should-mangle-version

[Christoph Berg]

Version: 2.5.65

Re: Roger Shimizu 2017-10-16 

Processed: Re: Bug#505857: lintian: false positive debian-watch-file-should-mangle-version

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> fixed 505857 2.5.54
Bug #505857 [lintian] [checks/watch-file] false positive 
debian-watch-file-should-mangle-version
Marked as fixed in versions lintian/2.5.54.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
505857: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505857
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#505857: lintian: false positive debian-watch-file-should-mangle-version

[Roger Shimizu]

On Mon, May 30, 2016 at 1:41 AM, Roger Shimizu  wrote:
> I met this false positive message, too. But in different case.
> I got the message when debian/watch is like:
>
> 
> opts="repack,compression=xz, \
>dversionmangle=s/\+ds\d*$//,repacksuffix=+ds, \
>
> 
>
> And lintian is happy when dversionmangle line moves to the 1st line:
>
> 
> opts="repack,compression=xz,dversionmangle=s/\+ds\d*$//,repacksuffix=+ds, \
>
> 

This issue got disappeared recently.
Maybe lintian already fixed this, after stretch released?

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1

Bug#505857: lintian: false positive debian-watch-file-should-mangle-version

[Roger Shimizu]

I met this false positive message, too. But in different case.
I got the message when debian/watch is like:


opts="repack,compression=xz, \
   dversionmangle=s/\+ds\d*$//,repacksuffix=+ds, \
   


And lintian is happy when dversionmangle line moves to the 1st line:


opts="repack,compression=xz,dversionmangle=s/\+ds\d*$//,repacksuffix=+ds, \
   


Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 17B3ACB1

Bug#505857: lintian: false positive debian-watch-file-should-mangle-version

[Russ Allbery]

Raphael Geissert [EMAIL PROTECTED] writes:

 3.- Long term solution:
 Turn some portions of uscan into a perl module[1] and use it to extract the
 dversionmangle regex.

 If there are really so many cases out there where this bug occurs and
 people is desperate to have it fixed instead of overriding the warning
 until a proper fix is available, am willing to work on 2. Otherwise, I
 will be working on the pm part of 3 some time soon, which just like the
 checkbashisms as pm stuff will need to be integrated in lintian
 afterwards.

3 is definitely the right solution in my opinion.

-- 
Russ Allbery ([EMAIL PROTECTED])   http://www.eyrie.org/~eagle/



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#505857: lintian: false positive debian-watch-file-should-mangle-version

[Frank Lichtenheld]

On Sun, Nov 16, 2008 at 11:21:09AM +0100, Jiří Paleček wrote:
 I'm getting a lintian warning an the package ltp:
 
 W: ltp source: debian-watch-file-should-mangle-version
 
 however, the watch file in question actually does mangle the version on  
 the line
 
 opts=dversionmangle=s/\+.*$// \
 http://sf.net/ltp/ltp-full-([0-9]+)\.tgz debian git-import-orig
 
 which correctly changes 20081031+dfsg to 20081031.

I think the check is fooled by your overreaching regex. If you
replace it with s/\+dfsg.*$// it should stop complaining.

Gruesse,
-- 
Frank Lichtenheld [EMAIL PROTECTED]
www: http://www.djpig.de/



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#505857: lintian: false positive debian-watch-file-should-mangle-version

[Jiří Paleček]

Hello,

On Fri, 28 Nov 2008 17:17:05 +0100, Frank Lichtenheld [EMAIL PROTECTED]  
wrote:



On Sun, Nov 16, 2008 at 11:21:09AM +0100, Jiří Paleček wrote:

I'm getting a lintian warning an the package ltp:

W: ltp source: debian-watch-file-should-mangle-version

however, the watch file in question actually does mangle the version on
the line

opts=dversionmangle=s/\+.*$// \
http://sf.net/ltp/ltp-full-([0-9]+)\.tgz debian git-import-orig

which correctly changes 20081031+dfsg to 20081031.


I think the check is fooled by your overreaching regex. If you
replace it with s/\+dfsg.*$// it should stop complaining.


That's posibble, but I think the check is stupid. I don't want to make the  
regexp more specific, because I sometimes make packages versioned like  
20081031+other_stuff+dfsg-1 and I want uscan to work on this too. It  
would probably be possible to silence the check by


 s/\+.*(?!dfsg)$//

which would totally defeat the purpose of the check.

Regards
Jiri Palecek



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#505857: lintian: false positive debian-watch-file-should-mangle-version

[Raphael Geissert]

Hi all,

1.- Short term workaround:
override the warning.

2.- Short term solution:
Extract and apply the dversionmangle regex on the package's version and check if
the Debian-specific bit is still around.

3.- Long term solution:
Turn some portions of uscan into a perl module[1] and use it to extract the
dversionmangle regex.

If there are really so many cases out there where this bug occurs and people is
desperate to have it fixed instead of overriding the warning until a proper fix
is available, am willing to work on 2. Otherwise, I will be working on the pm
part of 3 some time soon, which just like the checkbashisms as pm stuff will
need to be integrated in lintian afterwards.

So?

[1]This is on my ToDo list for DEHS2 anyway.

Cheers,
-- 
Raphael Geissert - Debian Maintainer
www.debian.org - get.debian.net





-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#505857: lintian: false positive debian-watch-file-should-mangle-version

[Jiří Paleček]

Package: lintian
Version: 2.0.0
Severity: normal

Hello,

I'm getting a lintian warning an the package ltp:

W: ltp source: debian-watch-file-should-mangle-version

however, the watch file in question actually does mangle the version on  
the line


opts=dversionmangle=s/\+.*$// \
http://sf.net/ltp/ltp-full-([0-9]+)\.tgz debian git-import-orig

which correctly changes 20081031+dfsg to 20081031.

Regards
   Jiri Palecek

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.24.3-test-pcw (SMP w/1 CPU core; PREEMPT)
Locale: LANG=cs_CZ, LC_CTYPE=cs_CZ (charmap=ISO-8859-2)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils  2.18.50.20080812-1 The GNU assembler, linker and  
bina
ii  diffstat  1.45-2 produces graph of changes  
introduc
ii  dpkg-dev  1.14.22Debian package development  
tools
ii  file  4.21-1 Determines file type using  
magic
ii  gettext   0.17-2 GNU Internationalization  
utilities
ii  intltool-debian   0.35.0+20060710.1  Help i18n of RFC822 compliant  
conf
ii  libdigest-sha-perl5.47-1 Perl extension for  
SHA-1/224/256/3
ii  libparse-debianchange 1.0-1  parse Debian changelogs and  
output
ii  libtimedate-perl  1.1600-6   Time and date functions for  
Perl
ii  liburi-perl   1.35-2 Manipulates and accesses URI  
strin

ii  man-db2.5.2-2on-line manual pager
ii  perl [libdigest-sha-p 5.10.0-13  Larry Wall's Practical  
Extraction


lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarchnone (no description available)
pn  libtext-template-perl none (no description available)
ii  man-db2.5.2-2on-line manual pager

-- no debconf information


--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]