Bug#573398: lintian: Outdated package-depends-on-hardcoded-libc check

2010-03-10 Thread Cyril Brulebois
Package: lintian
Version: 2.3.3
Severity: normal
Tags: patch

Hi,

for the package-depends-on-hardcoded-libc tag, a check is performed on
'glibc', which is 'eglibc' now, resulting in false positives. The
attached patch should fix this, although I didn't actually check
eglibc's binaries afterwards.

Thanks for considering.

Mraw,
KiBi.
>From b9229d511559c2e819dec83fa8676c261902f287 Mon Sep 17 00:00:00 2001
From: Cyril Brulebois 
Date: Tue, 9 Mar 2010 16:17:43 +0100
Subject: [PATCH] Fix package-depends-on-hardcoded-libc check.

The glibc source package was renamed into eglibc.
---
 checks/control-file |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/checks/control-file b/checks/control-file
index 66b34a7..f893b48 100644
--- a/checks/control-file
+++ b/checks/control-file
@@ -175,7 +175,7 @@ for my $control (@binary_controls) {
tag "package-depends-on-itself", $control->{package}, 
$dep_fields[$strong]
if $relation->implies($control->{package});
tag 'package-depends-on-hardcoded-libc', $control->{package}, 
$dep_fields[$strong]
-   if ($relation->implies($libcs) and $pkg ne "glibc");
+   if ($relation->implies($libcs) and $pkg ne "eglibc");
for my $weak (($strong + 1) .. $#dep_fields) {
next unless $control->{$dep_fields[$weak]};
for my $dependency (split /\s*,\s*/, 
$control->{$dep_fields[$weak]}) {
-- 
1.7.0



Bug#573398: lintian: Outdated package-depends-on-hardcoded-libc check

2010-03-20 Thread Raphael Geissert
Salut Cyril,

Cyril Brulebois wrote:
> 
> for the package-depends-on-hardcoded-libc tag, a check is performed on
> 'glibc', which is 'eglibc' now, resulting in false positives. The
> attached patch should fix this, although I didn't actually check
> eglibc's binaries afterwards.
> 

Thanks for the report and patch.
I'm fixing it in a slightly different way by still excluding glibc.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net



-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4ba53582.0f0bca0a.266b.6...@mx.google.com