Bug#602655: lintian: Please check for missing comma in Uploaders field (must in Policy 5.6.3)

2011-01-06 Thread Russ Allbery 
Niels Thykier  writes:

> I rechecked the code and it is not a problem. Email::Valid does indeed
> reject these names, but it is currently only applied to check the
>  part. The names are still checked by the old
> "home-made" regex approach.
>   Nevertheless I have added a name containing full stops in
> fields-uploaders to check potential regressions if we start using
> Email::Valid on the names as well.

Thanks!  And thank you for all your work on this, and on the test suite!
It's been really cool to see the commits flow by.

-- 
Russ Allbery (r...@debian.org)   



-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/874o9m7xfu@windlord.stanford.edu

Bug#602655: lintian: Please check for missing comma in Uploaders field (must in Policy 5.6.3)

2011-01-06 Thread Niels Thykier 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-06 01:01, Russ Allbery wrote:
> Niels Thykier  writes:
> 
>> I am considering to just make the switch to use Email::Valid. I have
>> attached a patch that makes the switch and introduces a regression test
>> to catch the particular issue in #602619.
> 
> The only caveat with using Email::Valid is that Debian Policy explicitly
> permits the non-RFC5322 address format:
> 
> John N. Doe 
> 
> where the name component contains a period and isn't quoted.  Does
> Email::Valid cope with that case?  If so, this sounds great, but we do
> need to allow that.
> 

I rechecked the code and it is not a problem. Email::Valid does indeed
reject these names, but it is currently only applied to check the
 part. The names are still checked by the old
"home-made" regex approach.
  Nevertheless I have added a name containing full stops in
fields-uploaders to check potential regressions if we start using
Email::Valid on the names as well.

~Niels
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNJZ1PAAoJEAVLu599gGRC1WsP/j7uuOYd4Zm37VqPYNaE/uJp
Fxv3WlC7v+AmI2cigEGezsj6Kj9dj6RnN93cR8Up5j6czdaoIVLRxdmx8sJOXvkT
r0vYLABJFXGxZU9laAJJOEBe4BnlMzMRteVtBR5RmeKKQ7IExxQ6tFBNgvCvegsl
2TlFPefzQwjVF462hlziHP2EKO+gUtygObluDlP2B7aqwAAqUs3AojsbPNElgmNl
ORTZO8nGbR8xvdLlP89KXuluzgYPbN7S5LvpjqwK4YJRECENn2NoS04mWGnDV55q
soJUto0pb4wthK1HadO1rnOnGt6pL6rPJiqzzxh5LXPtGSGAd9ewYrgEnyluvs+t
C/gDZw7rntZXvFyFJk8/i0h+o1UV4npI77EZk346jNcR/OkLBZYOG8Td6Idmn1qL
+wCizG70s/xeL++N6s5dXNInBO31qX3UiWqMAtfMd7qjjlvJe7tzDWPWQd1qblSA
Xb4T1e8bhKaqFSaUD3aOHLegpG8w5U96gvaGAuCvdxlGegzosx+fQ5Qg5MylC62o
TOce0kkrx+D3+YQiUir/U4awf5XktCEaqNtil2pF1j/6xue2iZbewMh1Pq42VBnm
0wCa56gm9yY1zYoWu/YS1NU9T0PFz6G+rLsrQSgtGS7cifBq8vnN3xTRsPzrKtN5
THHi5Amdzl9YxG+YL0fq
=bpq2
-END PGP SIGNATURE-



-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d259d4f.8090...@thykier.net

Bug#602655: lintian: Please check for missing comma in Uploaders field (must in Policy 5.6.3)

2011-01-05 Thread Niels Thykier 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-06 01:01, Russ Allbery wrote:
> Niels Thykier  writes:
> 
>> I am considering to just make the switch to use Email::Valid. I have
>> attached a patch that makes the switch and introduces a regression test
>> to catch the particular issue in #602619.
> 
> The only caveat with using Email::Valid is that Debian Policy explicitly
> permits the non-RFC5322 address format:
> 
> John N. Doe 
> 
> where the name component contains a period and isn't quoted.  Does
> Email::Valid cope with that case?  If so, this sounds great, but we do
> need to allow that.
> 

That might prove to be a problem here.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNJQuIAAoJEAVLu599gGRCy44QAI5lZaAE9AmwPwlHxlaFpuJS
6byLdPneii8D7PQbLfVHKdQC9vK0H10HZpd8TNeaU4PsusFCHa31VgUlkf4OyJgW
s5vF3ANC6Q7cDY/icg4axdam43C1wt9MsrOc5heBmwDml8/yMxXK2DwXXfhLnCUl
aJegxXkIdYONcmay8+5G3T9XCjXRssjUcFXexJ/P8YClY6kwpLgi7zaz23ZZ2BMK
k80+atTChUKdAMvpDImRXAZp6JrwKs73NKIBd/S4Yl/lS71tL5+aHLP+vAapY7j9
5ZbMzA/WqLsJ/CIUQhNQpHRRMh+bSADwvX9acOzzkL2aHkGLlxN+6zsu9m7ufvfR
pG82L5xF4D4P7jUT+AlmnCm4av4HQp2l329LMJGGQpkPQny53cTzlLNMPA6hcXMt
Itxfyo+xw05+gEa3wtC+3C4DQ/R5wsReMpPeTa+n2cLPNYdpHGy7TQhxvpcbaHun
kNdY6r5qXClVZtiZYoXtCZkwR5gYQ1xMxSj/n4050vWDaqOgQjRu0RfzBL86600+
TdlxD2bhn49d4bP86EuFr7RDRrG6zN5Qmwy8XsA697v1w7cVczyf+EwHLo3RR24Y
pLh5jK1bcljLmmsjqjRX+ymId62kifcp+B5tixIN+vmnpLP0Rpm/LzrWkYw/wlGT
bW1lFbDvaBYGmEMXgUYE
=sRDN
-END PGP SIGNATURE-



-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d250b8a.7090...@thykier.net

Bug#602655: lintian: Please check for missing comma in Uploaders field (must in Policy 5.6.3)

2011-01-05 Thread Russ Allbery 
Niels Thykier  writes:

> I am considering to just make the switch to use Email::Valid. I have
> attached a patch that makes the switch and introduces a regression test
> to catch the particular issue in #602619.

The only caveat with using Email::Valid is that Debian Policy explicitly
permits the non-RFC5322 address format:

John N. Doe 

where the name component contains a period and isn't quoted.  Does
Email::Valid cope with that case?  If so, this sounds great, but we do
need to allow that.

-- 
Russ Allbery (r...@debian.org)   



-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/87ipy2vr11@windlord.stanford.edu

Bug#602655: lintian: Please check for missing comma in Uploaders field (must in Policy 5.6.3)

2010-12-25 Thread Niels Thykier 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Hi

I am considering to just make the switch to use Email::Valid. I have
attached a patch that makes the switch and introduces a regression test
to catch the particular issue in #602619.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNFekwAAoJEAVLu599gGRCooEP/R/ZMEPkxCB7s0l5Et3qfT9x
7mEWUa8B5YLGVqN1BptfOITa4q9lO3gn/5B8QLlOGteGbzWqfwJH6SK3tsxEkvN9
KKKRwTMzunN5VNq/Wgkd3dEqH6ssmTKKf5QE7qGazUcC1hPCexrRx9VtMU1JZ01p
9bEn5wToO6fbPM1bF2PQbyQpzhu76RLmeHAdaSwYFQRkybGxawy01xT/RfDYkoCQ
oci9qDQu/ShGEU7AdKhidMqpPAdvdLHHhWLiBXiC7aOP07+8yFhVE31NMe1z6vBY
L7KaBp55rK2IzKNu0bD8265C9zGCLPDiOT2R3+uxaHUmneiIG53uhOyykkrf/Lkq
aFjDVJM2tVJtxzp3y6GKGC3fFyZFGLITTM50qOcVMKgK0aZvdxQ22Zov/EYIlWt9
/c4fVHwLaYElarsibIkwAZ1AYxJ/wQ743E9y5HniP4rJNf6tYwp/+1hcydoSuZNQ
J1uCzF73eiclmj37Q4cUwdfBbxIwsxJOTzUNA0LsrmuRYy2kUeR8GDZHg6Q19aGc
ZrhYHHUSMgSrnKZSjSUeI0fbIezVhwzAngXHYKN43w1krCH1v1bBaabW9RwGk3oN
4CUR8mBRQAet/kAEMu8NaFHM27yHvQ2v5wWwV0YHvnspNYgydrFLv1Y3GKXUuJ3R
/MCCiL31qaKG/KOQjL6q
=9sLf
-END PGP SIGNATURE-


0001-Made-Lintian-Check-use-Email-Valid-to-parse-emails-t.patch
Description: application/wine-extension-patch


0001-Made-Lintian-Check-use-Email-Valid-to-parse-emails-t.patch.sig
Description: Binary data

Bug#602655: lintian: Please check for missing comma in Uploaders field (must in Policy 5.6.3)

2010-11-06 Thread David Prévot 
Package: lintian
Version: 2.4.3
Severity: wishlist
Tags: patch

Please,

It would be really nice if Lintian could catch serious bug like #602619.

The naive attached patch permit to do so, but there must be nicer.

Regards

David

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (600, 'unstable'), (500, 'testing'), (500, 'stable'), (150, 
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.34-1-amd64 (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils   2.20.1-15 The GNU assembler, linker and bina
ii  diffstat   1.53-1produces graph of changes introduc
ii  dpkg-dev   1.15.8.5  Debian package development tools
ii  file   5.04-5Determines file type using "magic"
ii  gettext0.18.1.1-3GNU Internationalization utilities
ii  intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libapt-pkg-perl0.1.24+b1 Perl interface to libapt-pkg
ii  libclass-accessor-perl 0.34-1Perl module that automatically gen
ii  libipc-run-perl0.89-1Perl module for running processes
ii  libparse-debianchangel 1.1.1-2.1 parse Debian changelogs and output
ii  libtimedate-perl   1.2000-1  collection of modules to manipulat
ii  liburi-perl1.56-1module to manipulate and access UR
ii  locales2.11.2-7  Embedded GNU C Library: National L
ii  man-db 2.5.7-6   on-line manual pager
ii  perl [libdigest-sha-pe 5.10.1-16 Larry Wall's Practical Extraction 

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch (no description available)
pn  libtext-template-perl  (no description available)
ii  man-db2.5.7-6on-line manual pager

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/share/lintian/lib/Lintian/Check.pm (from lintian 
package)

*** /tmp/commit-2ff6f5a_Uploaders_comma.patch
commit 2ff6f5a6f6c036f9e0e97495c275b80d9080dc4f
Author: David Prévot 
Date:   Sat Nov 6 18:15:16 2010 -0400

Catch missing comma in Uploader field

diff --git a/lib/Lintian/Check.pm b/lib/Lintian/Check.pm
index 6d8cb36..c3abb22 100644
--- a/lib/Lintian/Check.pm
+++ b/lib/Lintian/Check.pm
@@ -159,7 +159,7 @@ sub check_maintainer {
 if (not $mail) {
 tag "$field-address-missing", $maintainer;
 } else {
-   if (not $malformed and $mail !~ /^[^()<>@,;:\\\"\[\]]+@(\S+\.)+\S+/) {
+   if (not $malformed and $mail !~ /^[^()<>@,;:\\\"\[\]]+@(\S+\.)+\S+/ or 
$mail =~ m/\s/) {
 tag "$field-address-malformed", $maintainer;
}
if ($mail =~ /(?:localhost|\.localdomain|\.localnet)$/) {



-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/20101106222508.26755.5833.report...@mikado.tilapin.org