Bug#664520: [lintian] 04/06: Emit a warning about documentation packages that end with -docs. (Closes: #664520)

2018-01-30 Thread Chris Lamb
Hi Mattia,

> I was thinking of that case just as an hypothetical, not as a real case.

Getcha. Again, just checking in case I was missing something or there was
a typo! I'll leave it for now; there's probably a good reason for the
foo-docs-bar examples and it makes the regex ugly.

Thanks!


-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#664520: [lintian] 04/06: Emit a warning about documentation packages that end with -docs. (Closes: #664520)

2018-01-30 Thread Mattia Rizzolo
On Tue, Jan 30, 2018 at 04:39:03PM +0530, Chris Lamb wrote:
> > According to the above, I wonder if you can also emit this worning
> > agaist /-docs-.+$/ or something more clever (to cover for the lang
> > codes).
> 
> I'm not seeing this in the archive right now JFTR, just in case I'm
> missing something..?

Right, I didn't check when writing that, but this is what my match would
catch:
% grep -E '^Package: .*-docs-.+$' /var/lib/apt/Packages
Package: fp-docs-3.0.4
Package: xorg-docs-core
%

Which are probably fine enough.
I was thinking of that case just as an hypothetical, not as a real case.
I'll let you choose if it's something to add to the check or not
(probably not indeed).

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature


Bug#664520: [lintian] 04/06: Emit a warning about documentation packages that end with -docs. (Closes: #664520)

2018-01-30 Thread Chris Lamb
Hi Mattia

> Please add a "Ref: Policy §12.3" here

Done in:

 
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=ed0282acfc5acca6c26f5ac563582d6b19a8be60

> According to the above, I wonder if you can also emit this worning
> agaist /-docs-.+$/ or something more clever (to cover for the lang
> codes).

I'm not seeing this in the archive right now JFTR, just in case I'm
missing something..?


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#664520: [lintian] 04/06: Emit a warning about documentation packages that end with -docs. (Closes: #664520)

2018-01-30 Thread Mattia Rizzolo
On Tue, Jan 30, 2018 at 07:00:28AM +, Chris Lamb wrote:
> +Tag: unusual-documentation-package-name
> +Severity: wishlist
> +Certainty: certain
> +Info: The specified package appears to be a documentation package
> + that ends with the string "-docs". It is recommended that such
> + packages use the more usual "-doc" suffix instead.
> + .
> + Please remove the superfluous trailing "s" from the package name.

Please add a "Ref: Policy §12.3" here.  From that policy section:
|The documentation package for the package package is conventionally
|named package-doc (or package-doc-language-code if there are separate
|documentation packages for multiple languages).


> +tag 'unusual-documentation-package-name' if $name =~ /-docs$/;

According to the above, I wonder if you can also emit this worning
agaist /-docs-.+$/ or something more clever (to cover for the lang
codes).

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature