Bug#884678: lintian: please consider debhelper compat 11 as stable
Chris Lamb:
> Hi Mattia,
>
>> -$data->{'dh_compat_level'} //= '9';
>> +$data->{'dh_compat_level'} //= '11';
>>
>> causes a ton of package-needs-versioned-debhelper-build-depends to be
>> emitted…
>
> I don't understand why this happens. Changing this does certainly change
> the default in tests. For example, here is "changelog-file-symlink"'s
> debian/control:
>
> 1 Source: changelog-file-symlink
> 2 Priority: optional
> 3 Section: devel
> 4 Maintainer: Debian Lintian Maintainers
> 5 Standards-Version: 4.1.2
> 6 Build-Depends: debhelper (>= 11~)
>
> .. so I have no idea why this fails the following test in
> checks/debhelper.pm:
>
> unless ($bdepends->implies("debhelper (>= ${dh_bd_version}~)")){
>
> $dh_bd_version is indeed 11 here.
>
>
> Regards,
>
Elementary my dear dr. Watson, the B-D in the .dsc.in.in file of the
test is hard coded!
"""
$ less t/source/changelog-file-symlink/dsc.in.in
Format: 1.0
[...]
Build-Depends: debhelper (>= 9)
[...]
"""
(Note that changelog-file-symlink name is reused between the t/tests and
the t/source suite. Only the latter fails).
Ideally, we would reduce the level of hard-coding here by ensuring that
the .dsc.in.in uses the substitution variable where possible. The use
of {$dh_compat_level} and .dsc.in.in are relatively "new inventions" so
many tests are still hard-coded.
Thanks,
~Niels
Bug#884678: lintian: please consider debhelper compat 11 as stable
Hi Mattia,
> -$data->{'dh_compat_level'} //= '9';
> +$data->{'dh_compat_level'} //= '11';
>
> causes a ton of package-needs-versioned-debhelper-build-depends to be
> emitted…
I don't understand why this happens. Changing this does certainly change
the default in tests. For example, here is "changelog-file-symlink"'s
debian/control:
1 Source: changelog-file-symlink
2 Priority: optional
3 Section: devel
4 Maintainer: Debian Lintian Maintainers
5 Standards-Version: 4.1.2
6 Build-Depends: debhelper (>= 11~)
.. so I have no idea why this fails the following test in
checks/debhelper.pm:
unless ($bdepends->implies("debhelper (>= ${dh_bd_version}~)")){
$dh_bd_version is indeed 11 here.
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
Bug#884678: lintian: please consider debhelper compat 11 as stable
tags 884678 + pending thanks Hey Mattia, Thanks for the patch; applied in Git: https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=aa4b6332a3f19c986ead41318f4fc9c5ef698b61 Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Processed: Re: Bug#884678: lintian: please consider debhelper compat 11 as stable
Processing control commands: > clone -1 -2 Bug #884678 [lintian] lintian: please consider debhelper compat 11 as stable Bug 884678 cloned as bug 884699 > retitle -2 lintian: please bump recommended debhelper compat to 11 Bug #884699 [lintian] lintian: please consider debhelper compat 11 as stable Changed Bug title to 'lintian: please bump recommended debhelper compat to 11' from 'lintian: please consider debhelper compat 11 as stable'. > severity -2 wishlist Bug #884699 [lintian] lintian: please bump recommended debhelper compat to 11 Severity set to 'wishlist' from 'normal' > tag -1 patch Bug #884678 [lintian] lintian: please consider debhelper compat 11 as stable Added tag(s) patch. -- 884678: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884678 884699: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884699 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#884678: lintian: please consider debhelper compat 11 as stable
Control: clone -1 -2 Control: retitle -2 lintian: please bump recommended debhelper compat to 11 Control: severity -2 wishlist Control: tag -1 patch On Mon, Dec 18, 2017 at 11:32:25AM +0100, Mattia Rizzolo wrote: > package-uses-experimental-debhelper-compat-version still triggers for > 11, but debhelper version 11 was released the other day > (https://tracker.debian.org/news/894669) and is now considered stable. > Please stop warning about it (if anything, recommend it!) Let's split this in two, the latter part requires more work. Attached a patch for the first part. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- From 177e75772426111841518c1dd2aee8bc3ea7f1ac Mon Sep 17 00:00:00 2001 From: Mattia Rizzolo Date: Mon, 18 Dec 2017 13:52:07 +0100 Subject: [PATCH] data/debhelper: Bump the experimental debhelper compat level to 12. Closes: #884678 Signed-off-by: Mattia Rizzolo --- data/debhelper/compat-level | 2 +- debian/changelog| 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/data/debhelper/compat-level b/data/debhelper/compat-level index 50006a331..759ed29a8 100644 --- a/data/debhelper/compat-level +++ b/data/debhelper/compat-level @@ -5,5 +5,5 @@ recommended=9 # warn if below this level deprecated=9 # warn if equal or above -experimental=11 +experimental=12 diff --git a/debian/changelog b/debian/changelog index 440b5c579..77e0af54c 100644 --- a/debian/changelog +++ b/debian/changelog @@ -2,6 +2,10 @@ lintian (2.5.66) UNRELEASED; urgency=medium XXX: generate tag summary + * data/debhelper/compat-level: ++ [MR] Bump the experimental debhelper compat level to 12. + (Closes: #884678) + -- Chris Lamb Mon, 18 Dec 2017 10:37:45 + lintian (2.5.65) unstable; urgency=medium -- 2.15.1 signature.asc Description: PGP signature
Bug#884678: lintian: please consider debhelper compat 11 as stable
On Mon, Dec 18, 2017 at 11:32:25AM +0100, Mattia Rizzolo wrote:
> package-uses-experimental-debhelper-compat-version still triggers for
> 11, but debhelper version 11 was released the other day
> (https://tracker.debian.org/news/894669) and is now considered stable.
> Please stop warning about it (if anything, recommend it!)
Here is the starting patch for it:
--- a/data/debhelper/compat-level
+++ b/data/debhelper/compat-level
@@ -1,9 +1,9 @@
# warn if no versioned depend below this level
pedantic=9
# warn (pedantic) if does not depend on this debhelper level
-recommended=9
+recommended=11
# warn if below this level
deprecated=9
# warn if equal or above
-experimental=11
+experimental=12
After that the testsuite falls apart, and will likely require some work
(and some more than basic knowledge about how it works).
I guess it would be nice to have the testsuite less tied to a given
debhelper compat level, doing
--- a/t/runtests
+++ b/t/runtests
@@ -1074,7 +1074,7 @@ sub check_test_is_sane {
$data->{options} ||= '-I -E';
$data->{todo} ||= 'no';
$data->{'test-depends'} //= '';
-$data->{'dh_compat_level'} //= '9';
+$data->{'dh_compat_level'} //= '11';
$data->{'default-build-depends'}
//= "debhelper (>= $data->{dh_compat_level}~)";
$data->{'extra-build-depends'} //= '';
causes a ton of package-needs-versioned-debhelper-build-depends to be
emitted…
So, not so straight forward :)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
Bug#884678: lintian: please consider debhelper compat 11 as stable
Package: lintian Version: 2.6.63 package-uses-experimental-debhelper-compat-version still triggers for 11, but debhelper version 11 was released the other day (https://tracker.debian.org/news/894669) and is now considered stable. Please stop warning about it (if anything, recommend it!) -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
