Bug#885974: lintian: warn about non-git Vcs fields hosted on Debian infrastructure

[Chris Lamb]

tags 885974 + pending
thanks

[Note renamed bug for clarity / prevention of flamewars!]

Fixed in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=51e416260cc4b84ce27f65e2fb8bfb132e84385d


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#885974: lintian: warn about non-git Vcs fields

[Mattia Rizzolo]

Control: clone -1 -2
Control: retitle -2 lintian: warn about 
orphaned-package-not-maintained-in-debian.org-infrastracture

On Mon, Jan 01, 2018 at 10:13:32PM +, Chris Lamb wrote:
> > > it would be a bit wrong to have Vcs-Svn actually point to a git repo…
> > Yes please start warning (not pedantic) now about Vcses hosted at
> > {anonscm,alioth,svn,bzr,hg,darcs,arch}.debian.org.
> 
> Non-sequitur? As I read it, Jeremy's comment was about mismatches.

TBH, I don't fully follow all of Jeremy's message.

> However, could you provide an initial description for the case of
> {anonscm,alioth,svn,bzr,hg,darcs,arch}.debian.org?

Tag: vcs-not-git-hosted-in-debian.org-infrastructure
Severity: normal
Certainty: certain
Info:
 The specified VCS is not Git but is nonetheless hosted in the
 *.debian.org infrastructure.
 .
 Alioth, the historical Debian forge, has been deprecated, and from now
 on only Git is supported and repositories are hosted on
 https://salsa.debian.org.
 .
 If you with to keep the packaging repository on another VCS you should
 move it elsewhere off the Debian official infrastructure; otherwise
 please convert your repository to Git and update the Vcs-* fields to
 point to the new URI.

Possible ref: 
https://lists.debian.org/debian-devel-announce/2017/08/msg8.html

Incredible as it may seem, there was no actual announce email saying
"hey, alioth is deprecated!"... so I wouldn't know where to point people
to.

Note that, differnetly from vcs-field-bitrotted matches, there are still
chances that there will be a read-only export of alioth after its
deprecation.

This is my suggestion for the -1 bug (#885974)

> > > What about QA packages? Maybe those at least should be using git
> > > hosted with Debian.
> > 
> > In general, I'd just warn about
> > orphaned-package-not-maintained-in-debian.org-infrastracture 
> 
> Fancy retitling this bug for the above and cloning another for this
> one? :)

So this is going to be -2:

Tag: orphaned-package-not-maintained-in-debian.org-infrastracture
Severity: normal
Certainty: certain
Info:
 This package is orphaned, and therefore all the wide Debian community
 collaborate to its maintenance, but the specified VCS field does not
 point to an area within the *.debian.org infrastructure, hence
 preventing other Debian Developer and external contributors to commit
 to its repository.
 .
 The specified VCS field is either stale from the time before it was
 orphaned, or otherwise wrong.

I can see how this wording has many (also grammatical) problems, but
I'm sure you'll be able to get something nice out of it.
Also feel free to rename the tag, perhaps making it start with 'vcs-' to
match other tags also checking the VCS fields.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Processed: Re: Bug#885974: lintian: warn about non-git Vcs fields

[Debian Bug Tracking System]

Processing control commands:

> clone -1 -2
Bug #885974 [src:lintian] lintian: warn about non-git Vcs fields
Bug 885974 cloned as bug 886057
> retitle -2 lintian: warn about 
> orphaned-package-not-maintained-in-debian.org-infrastracture
Bug #886057 [src:lintian] lintian: warn about non-git Vcs fields
Changed Bug title to 'lintian: warn about 
orphaned-package-not-maintained-in-debian.org-infrastracture' from 'lintian: 
warn about non-git Vcs fields'.

-- 
885974: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=885974
886057: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886057
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#885974: lintian: warn about non-git Vcs fields

[Chris Lamb]

Hi Mattia,

> > it would be a bit wrong to have Vcs-Svn actually point to a git repo…
> 
> Yes please start warning (not pedantic) now about Vcses hosted at
> {anonscm,alioth,svn,bzr,hg,darcs,arch}.debian.org.

Non-sequitur? As I read it, Jeremy's comment was about mismatches.

However, could you provide an initial description for the case of 
{anonscm,alioth,svn,bzr,hg,darcs,arch}.debian.org?

> > What about QA packages? Maybe those at least should be using git
> > hosted with Debian.
> 
> In general, I'd just warn about
> orphaned-package-not-maintained-in-debian.org-infrastracture 

Fancy retitling this bug for the above and cloning another for this
one? :)


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#885974: lintian: warn about non-git Vcs fields

[Mattia Rizzolo]

On Mon, Jan 01, 2018 at 08:39:55AM -0500, Jeremy Bicha wrote:
> On Mon, Jan 1, 2018 at 1:49 AM, Russ Allbery  wrote:
> > I would hold off on complaining about anonscm.  I'm pretty sure someone
> > will find a way to keep it going and redirecting, similar to the intention
> > with the mailing lists.
> 
> Should we warn now about any non-git vcs hosted at Debian?
> 
> Because even if there are redirects, it would be a bit wrong to have
> Vcs-Svn actually point to a git repo…

Yes please start warning (not pedantic) now about Vcses hosted at
{anonscm,alioth,svn,bzr,hg,darcs,arch}.debian.org.


And hell no, do not even think of warning about non-git hosted
elsewhere at all!

> What about QA packages? Maybe those at least should be using git
> hosted with Debian.

In general, I'd just warn about
orphaned-package-not-maintained-in-debian.org-infrastracture or
somesuch.  Then, if it's not maintained in git it would trigger the
above.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#885974: lintian: warn about non-git Vcs fields

[Jeremy Bicha]

On Mon, Jan 1, 2018 at 1:49 AM, Russ Allbery  wrote:
> I would hold off on complaining about anonscm.  I'm pretty sure someone
> will find a way to keep it going and redirecting, similar to the intention
> with the mailing lists.

Should we warn now about any non-git vcs hosted at Debian?

Because even if there are redirects, it would be a bit wrong to have
Vcs-Svn actually point to a git repo…

> (I host most of mine on my own infrastructure), and if someone wants to
> use Bzr or Subversion, I'm not sure that Lintian nagging them is going to
> change their mind.

What about QA packages? Maybe those at least should be using git
hosted with Debian.

Thanks,
Jeremy Bicha

Bug#885974: lintian: warn about non-git Vcs fields

[Russ Allbery]

Jeremy Bicha  writes:

> Here's some wording suggestions. Feel free to modify.

> Modify vcs-field-bitrotted (warning)
> Any *.debian.org repo except salsa.debian.org

I would hold off on complaining about anonscm.  I'm pretty sure someone
will find a way to keep it going and redirecting, similar to the intention
with the mailing lists.

> Add vcs-field-other-than-git (warning or info)

> After 1 May 2018, Debian will not offer any version control system
> hosting other than git. While maintainers are free to use other version
> control systems hosted elsewhere, most potential contributors are
> familiar with git.

Please not higher than info.

I question whether this should be higher than pedantic, or even that.
There's nothing that says that project VCSes have to be hosted with Debian
(I host most of mine on my own infrastructure), and if someone wants to
use Bzr or Subversion, I'm not sure that Lintian nagging them is going to
change their mind.

Think of it this way: Lintian is at its best when warning a maintainer
about some issue they may not have noticed.  But the chances that the
maintainer hasn't noticed they're not using Git, or that, at this point,
this isn't because of a conscious and intentional choice seems extremely
low.  So you're basically warning the maintainer about something they have
already intentionally chosen to do, and that's almost never going to go
over well.

-- 
Russ Allbery (r...@debian.org)   

Bug#885974: lintian: warn about non-git Vcs fields

[Jeremy Bicha]

Source: lintian
Version: 2.5.66

I think it's time for Lintian to warn about Vcs fields other than Git.

It looks like this was mentioned at https://bugs.debian.org/884503 but
no separate bug was filed for it. That bug points to
https://lists.debian.org/debian-devel/2015/12/msg00383.html . I think
the impression there was that it wasn't important enough to add to
lintian then.

An important difference now is that the Debian project plans to stop
offering any active VCS hosting except for git soon.

Here's some wording suggestions. Feel free to modify.

Modify vcs-field-bitrotted (warning)
Any *.debian.org repo except salsa.debian.org

All version control system hosting provided by Debian is expected to
become read-only on 1 May 2018 except for git hosting at
https://salsa.debian.org/ . For more information, see
https://wiki.debian.org/Salsa .

Add vcs-field-other-than-git (warning or info)

After 1 May 2018, Debian will not offer any version control system
hosting other than git. While maintainers are free to use other
version control systems hosted elsewhere, most potential contributors
are familiar with git.

Thanks,
Jeremy Bicha