Bug#895758: lintian -- when is a patch a patch (HG)

2018-04-15 Thread Thorsten Alteholz

Hi Chris,

On Sun, 15 Apr 2018, Chris Lamb wrote:

I could have sworn that already not all files in the patch/ directory
trigger such a message. But as I understand you right now, this is not the
case yet. So I am fine with it ...


Sorry, I don't understand what you mean here. :)  Can you rephrase?


if I understand you right, this lintian warning will be triggered by any 
file that is in patches/ but has no corresponding entry in series.

This is fine and I also don't need an exception for "my" *.patch_back.

I filed this wishlist bug because I wrongly thought that there is some 
kind of whitelist for such not needed files.


Does that make more sense?

   Thorsten



Bug#895758: lintian -- when is a patch a patch (HG)

2018-04-15 Thread Chris Lamb
Hi Thorsten,

> I could have sworn that already not all files in the patch/ directory 
> trigger such a message. But as I understand you right now, this is not the 
> case yet. So I am fine with it ...

Sorry, I don't understand what you mean here. :)  Can you rephrase?


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#895758: lintian -- when is a patch a patch (HG)

2018-04-15 Thread Thorsten Alteholz

Hi Chris,

On Sun, 15 Apr 2018, Chris Lamb wrote:

This might be a language thing but I would not know what "patch
back" would mean out of context. Indeed, even when I am pretty
sure what you are trying to achieve (temporarily ignore a patch?)


yes, thats what I wanted.

I could have sworn that already not all files in the patch/ directory 
trigger such a message. But as I understand you right now, this is not the 
case yet. So I am fine with it ...


  Thorsten



Processed: Re: Bug#895758: lintian -- when is a patch a patch (HG)

2018-04-15 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> retitle 895758 Ignore files ending in ".patch_back" in 
> patch-file-present-but-not-mentioned-in-series
Bug #895758 [lintian] lintian -- when is a patch a patch (HG)
Changed Bug title to 'Ignore files ending in ".patch_back" in 
patch-file-present-but-not-mentioned-in-series' from 'lintian -- when is a 
patch a patch (HG)'.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
895758: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895758
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#895758: lintian -- when is a patch a patch (HG)

2018-04-15 Thread Chris Lamb
retitle 895758 Ignore files ending in ".patch_back" in 
patch-file-present-but-not-mentioned-in-series
thanks

Hi Thorsten,

>   W: libosmo-sccp source: patch-file-present-but-not-mentioned-in-series 
>  02_set_version_explicitly.patch_back

This might be a language thing but I would not know what "patch
back" would mean out of context. Indeed, even when I am pretty
sure what you are trying to achieve (temporarily ignore a patch?)
it doesn't seem to parse for me. Sorry.

I'm not totally against have some kind of "ignore" pattern
(although, of course, IMHO this is somewhat unnecessary if you are
using a revision control system..) but I would be against "patch
back" being included on it.


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#895758: lintian -- when is a patch a patch (HG)

2018-04-15 Thread Thorsten Alteholz

Package: lintian
Version: 2.5.80
Severity: wishlist

My outreachy mentee renamed an old patch to:
  02_set_version_explicitly.patch_back

lintian complained about that with:
 W: libosmo-sccp source: patch-file-present-but-not-mentioned-in-series 
02_set_version_explicitly.patch_back

I would like to suggest that such a name will be ignored as valid filename 
for a patch (maybe a list of "valid" names can appear on lintian.d.o).


 Thorsten