Bug#1030586: lintian: Testsuite failure on some systems: 1h time offset in test ancient-source
Package: lintian Version: 2.116.3 Severity: important Tags: ftbfs While running Lintian's testsuite on a much faster system compared to my Sid amd64 running development workstation, I noticed the following test suite failure when running "private/runtests" or trying to build the package on a more modern and more performant box with Bookworm amd64. (Use "private/runtests -o test:ancient-source" to just run the affected test.) # Hints do not match # # --- debian/test-out/eval/checks/unpack/ancient-source/hints.specified.calibrated # +++ debian/test-out/eval/checks/unpack/ancient-source/hints.actual.parsed # -ancient-source (source): unpack-message-for-source tar: ancient-source-1.0/README: implausibly old time stamp 1969-12-31 23:59:59 # +ancient-source (source): unpack-message-for-source tar: ancient-source-1.0/README: implausibly old time stamp 1970-01-01 00:59:59 # debian/test-out/eval/checks/unpack/ancient-source/generic.t .. 1/1 # Failed test 'Lintian passes for ancient-source' # at /home/abe/debian/lintian/lib/Test/Lintian/Run.pm line 343. # Looks like you failed 1 test of 1. But I neither get that failure on my Sid amd64 development workstation nor on SalsaCI (https://salsa.debian.org/lintian/lintian/-/pipelines) nor in pbuilder nor on the buildd (https://buildd.debian.org/status/package.php?p=lintian). So I tried to find differences. $ als debian/test-out/packages/checks/unpack/ancient-source/ancient-source_1.0.orig.tar.gz ancient-source-1.0/README -rw-r--r-- root/root21 1970-01-01 00:59 ancient-source-1.0/README $ env TZ=GMT als debian/test-out/packages/checks/unpack/ancient-source/ancient-source_1.0.orig.tar.gz ancient-source-1.0/README -rw-r--r-- root/root21 1969-12-31 23:59 ancient-source-1.0/README But these two outputs are identical on both hosts, the one where the test fails and one of those where it doesn't fail. So the timestamp actually seems to be the same and it's just Lintian's parsing of it seems to differ. The only potentially relevant package version difference I found was tar, which is at 1.34+dfsg-1.1 in Sid and 1.34+dfsg-1 in Bookworm due to a recent FTBFS on 32-bit architectures. But the sole change was in debian/copyright and also downgrading the tar version in Sid to the one from Bookworm didn't make the test failing on Sid. Also running the test suite with "env TZ=GMT" prepended didn't make a difference. Additionally, build 2.116.2 did work on that very same box where 2.116.3 now FTBFS. So it seems to have caused been a recent change (since 2023-01-29) in Bookworm. Or maybe such a change just uncovered an older bug. The locales of two systems where it builds and where it no more builds: Builds fine: LANG=C.UTF-8 LANGUAGE= LC_CTYPE="C.UTF-8" LC_NUMERIC="C.UTF-8" LC_TIME="C.UTF-8" LC_COLLATE="C.UTF-8" LC_MONETARY="C.UTF-8" LC_MESSAGES="C.UTF-8" LC_PAPER="C.UTF-8" LC_NAME="C.UTF-8" LC_ADDRESS="C.UTF-8" LC_TELEPHONE="C.UTF-8" LC_MEASUREMENT="C.UTF-8" LC_IDENTIFICATION="C.UTF-8" LC_ALL= No more builds fine (but hasn't change since when it still built fine): LANG=C LANGUAGE= LC_CTYPE="C" LC_NUMERIC="C" LC_TIME="C" LC_COLLATE="C" LC_MONETARY="C" LC_MESSAGES="C" LC_PAPER="C" LC_NAME="C" LC_ADDRESS="C" LC_TELEPHONE="C" LC_MEASUREMENT="C" LC_IDENTIFICATION="C" LC_ALL= Also both systems have "Europe/Zurich" in their /etc/timezone. So I currently have no idea where the difference comes from or which environmental change (variables or package versions) triggers it. Cc'ing the Reproducible Builds project in the hope that they have an idea what could have caused the 1h offset in the testsuite on that one box. Bug report written on the system where the test failed. -- System Information: Debian Release: bookworm/sid APT prefers testing-debug APT policy: (500, 'testing-debug'), (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 6.1.0-1-amd64 (SMP w/16 CPU threads; PREEMPT) Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /usr/bin/dash Init: sysvinit (via /sbin/init) LSM: AppArmor: enabled Versions of packages lintian depends on: ii binutils2.40-2 ii bzip2 1.0.8-5+b1 ii clzip [lzip-decompressor] 1.13-5 ii diffstat1.65-1 ii dpkg1.21.19 ii dpkg-dev1.21.19 ii file1:5.44-3 ii gettext 0.21-10 ii gpg 2.2.40-1 ii intltool-debian 0.35.0+20060710.6 ii iso-codes 4.12.0-1 ii libapt-pkg-perl 0.1.40+b2 ii libarchive-zip-perl 1.68-1 ii libberkeleydb-perl 0.64-2+b1 ii libcapture-tiny-perl0.48-2 ii libclass-xsaccessor-perl1.19-4+b1 ii libclone-perl 0.46-1 ii libconfig-tiny-perl 2.28-2 ii libconst-fast-perl 0.014-2 ii
Re: New release for lintian?
Hi, I'm step by step trying to get back into working on Debian again. And besides RC bugs, Lintian is a focus, too. Nilesh Patra wrote on 13th of October 2023: > > > Over the past few days I've tried to merge some of the pending MRs and > > > also push minor changes on the lintian repository. Thanks again for that. I merged a few more today and fixed the test suite issues caused by dh_movetousr. The test suite passes again. > > > Would you consider to do a review and upload a new release to > > > unstable, please? I'll try to get one done soonish. Got another bunch of MRs rebased and waiting for the test results now that the test suite passes again. Also got some more commits waiting to be pushed locally to not cancel those two MR pipelines currently running. (They all seem to run on the same runner, which explains why autopkgtest already runs longer than in previous runs.) > Can I ask you to review/merge these, please? (Some have been > taken from pollo's mail) > > https://salsa.debian.org/lintian/lintian/-/merge_requests/482 Already merged. Thanks! > https://salsa.debian.org/lintian/lintian/-/merge_requests/458 > https://salsa.debian.org/lintian/lintian/-/merge_requests/462 > https://salsa.debian.org/lintian/lintian/-/merge_requests/471 > https://salsa.debian.org/lintian/lintian/-/merge_requests/472 These all either add new tests, require additional run-time dependencies or are generally rather invasive. For getting out a release soonish, I'd rather avoid them and merge them at in a later release. Regards, Axel -- ,''`. | Axel Beckert , https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE signature.asc Description: PGP signature
Re: Bug#1012289: RFH: lintian -- Debian package checker
Hi Bill, Bill Allombert wrote: > By the way, what happened to lintian.debian.org ? Seems as if someone (not me, just noticed it today when "private/refresh-data" failed…) pulled the plug on at least the DNS name. Probably because it hasn't been updated since Felix' try to rewrite it, which AFAIK was never finished, but the old thing also no more worked. (There's probably a lot of legacy code in "lib/Lintian/Output" related to one of these two website generations, maybe even both.) IMHO it's generally a good thing, except that it would have been better to redirect it to the according UDD pages instead. Regards, Axel -- ,''`. | Axel Beckert , https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
Lintian 2.117.0 imminent (was: Re: New release for lintian?)
Hi, Nilesh Patra wrote: > Would you consider to do a review and upload a new release to > unstable, please? Working on it now. Please do no more merges or pushes for the next few hours. Everything else needs to go into a 2.117.1 or 2.118.0. Regards, Axel -- ,''`. | Axel Beckert , https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE signature.asc Description: PGP signature
Re: Bug#1033894: lintian: bad-distribution-in-changes-file bookworm
Version: 2.117.0 Hi, Arnaud Rebillout wrote: > On Tue, 28 Nov 2023 13:00:00 -0700 =?UTF-8?B?T3R0byBLZWvDpGzDpGluZW4=?= > wrote: > > The fix for this issue is still only in git at > > https://salsa.debian.org/lintian/lintian/-/commit/ebb739d102d55797516c0f10452e4e4c2502644d […] > The fix was released in lintian 2.117.0. Thanks for mentioning this. Seems to have slipped through our fingers and indeed was fixed by this commit, but it doesn't close this bug report. (Maybe the committer missed that there is a bug report for that.) I've just retroactively added the "Closes" to Lintian's debian/changelog as there weren't any other changes yet, so "gbp dch" will still work fine. *phew* I've just also added trixie and forky so this is already fixed for the next stable release, too. :-) > But unless it's backported to bookworm, the problem you highlighted > remains. Needs to migrate to testing first. And I'd be glad if someone else could take care of the backport. *hinthinthint* :-) Note: Running the testsuite this time requires a debhelper version newer than in stable (but satisfiable) in stable-backports due to the testsuite expecting dh_movetousr being active. Sorry 'bout that. Feel free to suggest (or even implement) a better solution to that. > > and there has not been any new Lintian uploads since Lintian > > 2.116.3 in February 2023. Please note that February 2023 was during the freeze and Bookworm was released in June. And I indeed remember that we didn't managed to get out a 2.116.4 with some more last-minute fixes. Sorry for that. And yes, there was exactly one year without a Lintian releasae. :-/ While there were a ton of new and old contributors in this release, it seems that nobody else than me dared to actually do a Lintian release. But I was waylaid for months for multiple reasons. (But I think, Bastièn probably would have done one if I wouldn't have become active again recently. :-) Regards, Axel -- ,''`. | Axel Beckert , https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE signature.asc Description: PGP signature
Re: Current state of lintian?
Hi,
Nilesh Patra wrote:
> I wanted to know what the current situation of lintian maintenance
> is.
Now that policy 4.7.0 is out we (really) should get a release done
soon.
The other reason is as you already mentioned …
> Currently there's an RC bug #1066261 against it
… this (and #1065431). Thanks for merging that one!
> and I am unsure as to what should be done (release now, later,
> what?).
"Soon". I plan to do a release within the next 10 days. Probably won't
have time before Saturday, though.
> I've been reviewing and merging some MRs on the repo for a few
> months, but other than that I have not witnessed much activity.
Done that, too, for a few MRs, but probably for fewer than you did.
> So here's the question: How is the maintenance status?
A bit better than last year from my point of view, but it obviously
could be better. I still only find time for Lintian every other month
or so — nevertheless I seem the only one who dares to do a release.
(Which makes me kinda feel honored, but it actually is a really bad
bus-factor. )
Regards, Axel
--
,''`. | Axel Beckert , https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
Re: Current state of lintian?
Hi Nilesh, Nilesh Patra wrote: > On Mon, May 06, 2024 at 03:58:54AM +0200, Axel Beckert wrote: > > The release won't happen tonight anymore, though. Need to go to bed > > now. Also Salsa consistently spews "Something went wrong. Please try > > again." when trying to rebase some more merge requests. Pipelines for > > 6 more now rebased merge requests are currently running (or pending) > > on Salsa. Will check the results tomorrow—eh—later today. > > There were 3 merge request which you marked as "Approve" but not merge > possibly > due to salsa pitfalls? Mostly, yes. > I took the liberty to merge the three (!471, !472 and !499). Please revert > (and > comment) if you think it was a mistake. Well, !499 has a (actually still pending) open question for review: https://salsa.debian.org/lintian/lintian/-/merge_requests/499#note_483348 Didn't expect a merge before that question is solved. Would be happy if you could still have a look at my questions and if necessary push according changes (maybe with "Git-Dch: Ignore"). But we also haven't really rules what approval, thumbs up, etc. exactly mean. So maybe that was the problem. :-) For me approval is a general ok for the concept and an intend to merge, but not necessarily in the current state. But maybe thumbs up is better for that purpose? Regards, Axel -- ,''`. | Axel Beckert , https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE signature.asc Description: PGP signature
Re: Current state of lintian?
Hi, Nilesh Patra wrote: > I wanted to know what the current situation of lintian maintenance > is. Worked on merging or at least reviewing merge requests this night. We're down to a single page of unmerged merge requests. Yay! :-) Two autopkgtest runs from yesterday seem to have failed early on Salsa, but a all pipelines from today passed again. So it seems to have been a temporary problem on Salsa. *phew* I also now have a local box which runs the lintian testsuite in 10 minutes instead of the 40 minutes my old workstation needed. Makes things easier. :-) I'm mostly using it to test merge requests much quicker than Salsa can do (often close to 2h). So if you see me rebasing or merging without CI, I usually ran the test suite locally in a much faster way. The release won't happen tonight anymore, though. Need to go to bed now. Also Salsa consistently spews "Something went wrong. Please try again." when trying to rebase some more merge requests. Pipelines for 6 more now rebased merge requests are currently running (or pending) on Salsa. Will check the results tomorrow—eh—later today. Hope to get the release done within the next few days, though. Regards, Axel -- ,''`. | Axel Beckert , https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE signature.asc Description: PGP signature
Re: adequate maintenance
Hi Serafeim, Serafeim Zanikolas wrote: > I'm considering to ITA the adequate package, Cool! > on the condition that (i) the folks taking care of it to date, and > (ii) the lintian team Can speak for both, more or less. :-) > would be okay for me to rewrite it Neither an objection from myself as former adequate QA uploader nor from the Lintian team. > in go. > > I understand that go is not the most popular of languages in Debian Static linking is bad for security updates. I think that's the main if not the only reason which speaks against Go. But it wouldn't be the first Go package in Debian and the Debian Security Team seems to be able to live with it. And having a useful adequate would be nice. > and that lintian tools are mostly perl and python. Lintian is 95% Perl. It has about 300 lines of Python (in the test suite in dummy python packages) and about 83'000 lines of Perl. Lintian-Brush is written in Python, but a separate project independently developed by Jelmer. Regards, Axel -- ,''`. | Axel Beckert , https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE signature.asc Description: PGP signature
Re: Bug#1071007: sherlock has an undeclared file conflict on /usr/lib/python3/dist-packages/__init__.py
Control: affects -1 - pycrc Control: clone -1 -2 -3 Control: reassign -2 pycrc 0.10.0-2 Control: retitle -1 sherlock: Must not ship /usr/lib/python3/dist-packages/__init__.py Control: retitle -2 pycrc: Must not ship /usr/lib/python3/dist-packages/__init__.py Control: reassign -3 lintian 2.117.0 Control: severity -3 wishlist Control: retitle -3 lintian: Should warn if a package ships /usr/lib/python*/dist-packages/__init__.py Hi Helmut, Helmut Grohne wrote: > This bug report has been automatically filed with no human intervention. > The source code is available at https://salsa.debian.org/helmutg/dumat. Ok, this explains why you didn't notice that this is actually a separate bug in each of these packages. :-) > sherlock has an undeclared file conflict. This may result in an unpack > error from dpkg. > > The file /usr/lib/python3/dist-packages/__init__.py is contained in the > packages > * pycrc/0.10.0-2 as present in trixie|unstable > * sherlock/0.14.3+git20240511.b83f5be-1 as present in unstable My Python foo isn't that well versed, but as far as I understand actually no package must ship an __init__.py file at (more or less) root level (i.e. directly in /usr/lib/python*/dist-packages/ or — since usrmerge also — /lib/python*/dist-packages/). Accordingly cloning the bug report for pycrc as it must not ship that file either. And cloning it a second time as wishlist bug report against Lintian so that these cases get caught much earlier. Might be implemented as extension of python-module-has-overly-generic-name (as the module name seems the empty string in that case ;-) which so far already catches cases like e.g. /usr/lib/python3/dist-packages/doc/__init__.py. Regards, Axel -- ,''`. | Axel Beckert , https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE signature.asc Description: PGP signature
Re: Current state of lintian?
Hi Nilesh, Nilesh Patra wrote: > >Would be happy if you could still have a look at my questions and if > >necessary push according changes (maybe with "Git-Dch: Ignore"). > > I don't see your questions anywhere on the MR. Am I missing > something? Did you by any chance forget to post? Could you let me > know? Oopsi, indeed. There is a "pending" and I thought this means that the review is pending. But if I hover above it, it says "Pending comments are hidden until you submit your review." Then again, the comment is not in an textarea to edit. It just an "edit" icon as if when I can edit an already posted comment. Very weird. (Can send you some screenshots if wanted. But I don't want to send nearly 200kB of PNGs to the list.) Even weirder, if I click the edit button and press "save comment", it doesn't change in any way. It's still pending. ARGH, on the very bottom of the screen, far away from that comment, I now see a very decent footer line with a pull down menu saying "Pending comments (1)" and a button say "Finish review". And if I click that a new comment field shows up. What kind of UI fuckup is this?!? Sorry for the confusion, but this is a horrible new UI from Gitlab. > >For me approval is a general ok for the concept and an intend to > >merge, but not necessarily in the current state. But maybe thumbs up > >is better for that purpose? > > Yep. For me approval from a maintainer would mean ready/approved for a merge. Ok, next time then. But the main issue seems that the comment wasn't sent at all so far. Regards, Axel -- ,''`. | Axel Beckert , https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE signature.asc Description: PGP signature
[Git][lintian/lintian][master] arch-regex: add loong64 support
Axel Beckert pushed to branch master at lintian / lintian Commits: 32710afb by Jiajie Chen at 2023-10-25T23:55:22+08:00 arch-regex: add loong64 support - - - - - 1 changed file: - data/binaries/arch-regex Changes: = data/binaries/arch-regex = @@ -35,6 +35,7 @@ i386 ~~^ELF 32-bit LSB .* 80386, .* (?:GNU/Linux|(?!GNU)).*$ ia64 ~~^ELF 64-bit LSB .* IA-64 kfreebsd-amd64~~^ELF 64-bit LSB .* x86-64, .* (?:GNU/kFreeBSD|(?!GNU)).*$ kfreebsd-i386 ~~^ELF 32-bit LSB .* 80386, .* (?:GNU/kFreeBSD|(?!GNU)).*$ +loong64 ~~^ELF 64-bit LSB .* LoongArch lpia ~~^ELF 32-bit LSB .* 80386, .* (?:GNU/Linux|(?!GNU)).*$ m32r ~~^ELF 32-bit MSB .* M32R m68k ~~^ELF 32-bit MSB .* 680[02]0 View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/32710afb323d923fe3d188c765d75ce1f395e448 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/32710afb323d923fe3d188c765d75ce1f395e448 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Add "noble" as a known Ubuntu distribution.
Axel Beckert pushed to branch master at lintian / lintian Commits: e48c525b by Simon Quigley at 2023-10-20T08:53:59-05:00 Add noble as a known Ubuntu distribution. - - - - - 1 changed file: - vendors/ubuntu/main/data/changes-file/known-dists Changes: = vendors/ubuntu/main/data/changes-file/known-dists = @@ -34,3 +34,4 @@ jammy kinetic lunar mantic +noble View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/e48c525bacef15a9a22d4ccba88084fcfe531109 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/e48c525bacef15a9a22d4ccba88084fcfe531109 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new tag 2.115.1
Axel Beckert pushed new tag 2.115.1 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/2.115.1 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] perltidy lib/Lintian/Check/Documentation.pm
Axel Beckert pushed to branch master at lintian / lintian
Commits:
133b4c74 by Axel Beckert at 2022-06-22T09:19:23+02:00
perltidy lib/Lintian/Check/Documentation.pm
Gbp-Dch: Ignore
- - - - -
1 changed file:
- lib/Lintian/Check/Documentation.pm
Changes:
=
lib/Lintian/Check/Documentation.pm
=
@@ -132,7 +132,7 @@ sub visit_installed_files {
|| ( $item->basename =~ m{^README}xi
&& $item->bytes =~ m{this directory}xi)
# see Bug#1009679
- || $item->name =~ m{^var/lib/ocaml/lintian/.+[.]info$};
+ || $item->name =~ m{^var/lib/ocaml/lintian/.+[.]info$};
}
if ($item->name =~ m{^usr/share/doc/\S}) {
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/133b4c74f10db401c1650a52ee184a86e2feb376
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/133b4c74f10db401c1650a52ee184a86e2feb376
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 3 commits: Add extensions of colour profiles: icc, icm
Axel Beckert pushed to branch master at lintian / lintian Commits: 39452842 by Pino Toscano at 2022-07-06T21:18:19+02:00 Add extensions of colour profiles: icc, icm - - - - - a1addb26 by Pino Toscano at 2022-07-06T21:50:34+02:00 Add more extensions of document files - various OpenDocument formats - EPUB - Comic Book archives - CHM - some Microsoft Office formats Gbp-Dch: Short - - - - - 21b3c002 by Pino Toscano at 2022-07-06T21:51:10+02:00 Add extensions of image files: emf Gbp-Dch: Short - - - - - 1 changed file: - data/files/binary-file-extensions Changes: = data/files/binary-file-extensions = @@ -9,15 +9,25 @@ avi avif avifs bmp +cb7 +cbr +cbt +cbz +chm der djvu dll dmg +doc +emf +epub exe flac gif gmo gpg +icc +icm icns ico jar @@ -34,16 +44,21 @@ mov mp3 mp4 mpg +odg +odp ods +odt oga ogg ogv opus otf +otp p12 pdf pfx png +ppt psd spx sqlite View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/ecc04980869462c5c71f4f71e9b8a71bd5b944b5...21b3c0022c2d82146bbae437d5d8b7ab9cce64cc -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/ecc04980869462c5c71f4f71e9b8a71bd5b944b5...21b3c0022c2d82146bbae437d5d8b7ab9cce64cc You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new tag 2.115.2
Axel Beckert pushed new tag 2.115.2 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/2.115.2 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new branch migrate-overrides
Axel Beckert pushed new branch migrate-overrides at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/migrate-overrides You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new branch salsa-debug
Axel Beckert pushed new branch salsa-debug at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/salsa-debug You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 2 commits: Move libio-prompt-tiny-perl dependency to debian/tests/control
Axel Beckert pushed to branch master at lintian / lintian Commits: 9593ee76 by Axel Beckert at 2022-06-22T23:57:05+02:00 Move libio-prompt-tiny-perl dependency to debian/tests/control Cherry-picked from Ubuntus patches. LP: #1959004 Gbp-Dch: Full - - - - - 47239102 by Axel Beckert at 2022-06-22T23:57:12+02:00 Recognise Mac OS X icons (.icns) as binary files - - - - - 3 changed files: - data/files/binary-file-extensions - debian/control - debian/tests/control Changes: = data/files/binary-file-extensions = @@ -11,3 +11,4 @@ tif tiff wav xcf +icns = debian/control = @@ -56,7 +56,6 @@ Depends: libhtml-html5-entities-perl, libhtml-tokeparser-simple-perl, libio-interactive-perl, - libio-prompt-tiny-perl, libipc-run3-perl, libjson-maybexs-perl, liblist-compare-perl, = debian/tests/control = @@ -18,6 +18,7 @@ Depends: gcc-mingw-w64-x86-64, gpg-agent, javahelper, + libio-prompt-tiny-perl, libmce-perl, libperl-critic-freenode-perl, libperl-critic-pulp-perl, View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/133b4c74f10db401c1650a52ee184a86e2feb376...472391022600f4421ba140d6c6c8f87be5f2a2c7 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/133b4c74f10db401c1650a52ee184a86e2feb376...472391022600f4421ba140d6c6c8f87be5f2a2c7 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 2 commits: Update data for Debian policy releases (4.6.1 added)
Axel Beckert pushed to branch master at lintian / lintian
Commits:
f274aa0e by Damyan Ivanov at 2022-06-13T22:17:00+00:00
Update data for Debian policy releases (4.6.1 added)
- - - - -
3ad582e2 by Damyan Ivanov at 2022-06-13T22:17:00+00:00
update releases.json via lintian itself
magic incantation:
perl -Ilib -wEuse Lintian::Deb822; use Lintian::Data::Policy::Releases;
my $r = Lintian::Data::Policy::Releases-new; $r-refresh(0,
data);
Downloads the debian-policy changelog from salsa
- - - - -
1 changed file:
- data/debian-policy/releases.json
Changes:
=
data/debian-policy/releases.json
=
@@ -8,18 +8,42 @@
"author" : "Sean Whitton ",
"changes" : [
"",
-"debian-policy (4.6.0.2) UNRELEASED; urgency=medium",
+"debian-policy (4.6.1.0) unstable; urgency=medium",
+"",
+" * Policy: Allow non-64-bit packages to install to /usr/lib64",
+"Wording: Sean Whitton ",
+"Seconded: Simon McVittie ",
+"Seconded: Russ Allbery ",
+"Closes: #992601",
+" * Policy: Define 'upstream' & document several version
conventions",
+"Wording: Russ Allbery ",
+"Seconded: Sam Hartman ",
+"Seconded: Sean Whitton ",
+"Closes: #542288, #850729",
+" * virtual-package-names-list: Add {default,}dbus-system-bus
(Closes: #998063).",
+"Thanks to Simon McVittie for the patch.",
+" * Update 9.7.2 and 9.7.3 for package split of bin:mime-support
into",
+"bin:media-types and bin:mailcap (Closes: #1008480).",
+"Thanks to Charles Plessy for the patch.",
"",
" * Fix several problems with footnote regarding the autobuilders
and",
"build dependency alternatives (Closes: #999826).",
-"Thanks to Johannes Schauer Marin Rodrigues for the report and
patch."
+"Thanks to Johannes Schauer Marin Rodrigues for the report and
patch.",
+" * Use syntax highlighting for some source code blocks (Closes:
#999566).",
+"Thanks to Stéphane Blondon for the patch."
],
"closes" : [
-999826.0
- ],
- "epoch" : 1640320759,
- "timestamp" : "2021-12-24T04:39:19Z",
- "version" : "4.6.0.2"
+542288,
+850729,
+992601,
+998063,
+999566,
+999826,
+1008480
+ ],
+ "epoch" : 1652292179,
+ "timestamp" : "2022-05-11T18:02:59Z",
+ "version" : "4.6.1.0"
},
{
"author" : "Sean Whitton ",
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/ccd30b72f3ad9b9d7621a0058f07aee52ae49a73...3ad582e27b1fc690dbbc81623173c7513a9124bc
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/ccd30b72f3ad9b9d7621a0058f07aee52ae49a73...3ad582e27b1fc690dbbc81623173c7513a9124bc
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 9 commits: Update copyright years in debian/copyright
Axel Beckert pushed to branch master at lintian / lintian
Commits:
1b26acec by Axel Beckert at 2022-06-11T17:00:27+02:00
Update copyright years in debian/copyright
… before lintian starts complaining about it. ;-)
- - - - -
648144e9 by Axel Beckert at 2022-06-11T18:59:43+02:00
Run perltidy over bin/lintian and private/{runtests,refresh-perl-provides}
Lintians own tests t/scripts/01-critic/{bin,private}.t fail otherwise.
- - - - -
625526b0 by Axel Beckert at 2022-06-11T18:59:48+02:00
Remove unnecessary usage of UTF-8 from bin/lintian until
https://github.com/Perl-Critic/Perl-Critic/issues/925 is fixed
- - - - -
a60e8001 by Axel Beckert at 2022-06-11T18:59:48+02:00
Run perltidy over t/scripts/{spellintian,…/hintextract,…/tag-coverage}.t
Lintians own test t/scripts/01-critic/scripts.t fails otherwise.
- - - - -
5651c63f by Axel Beckert at 2022-06-11T19:24:51+02:00
Run perltidy over lib
Lintians own test t/scripts/01-critic/libs.t fails otherwise.
It still fails, but no more for 167 files, now only for 64 files.
- - - - -
615d6623 by Axel Beckert at 2022-06-11T22:03:40+02:00
Replace UTF-8 characters in mostly Copyright comments until
https://github.com/Perl-Critic/Perl-Critic/issues/925 is fixed
Actually all of them are copyright comment except for a single Unicode
SECTION SIGN character somewhere else.
- - - - -
1c04b37c by Axel Beckert at 2022-06-11T22:03:40+02:00
Replace UTF-8 characters in code with \N{…} until
https://github.com/Perl-Critic/Perl-Critic/issues/925 is fixed
Lintians own test t/scripts/01-critic/libs.t fails otherwise.
- - - - -
fe229196 by Axel Beckert at 2022-06-11T22:07:49+02:00
Remove literal unicode character U+0334 COMBINING TILDE OVERLAY which likely
had been added accidentally
… slightly over 10 years ago and nobody noticed so far.
For more details see
https://lists.debian.org/msgid-search/20220611194509.ykyasxuwnss6m...@sym.noone.org
- - - - -
34198690 by Axel Beckert at 2022-06-11T22:13:50+02:00
data/…/perl-provides updated by running d…/rules
refresh-perl-provides
- - - - -
30 changed files:
- bin/lintian
- data/fields/perl-provides
- debian/copyright
- lib/Lintian/Archive.pm
- lib/Lintian/Changelog.pm
- lib/Lintian/Check/Apache2.pm
- lib/Lintian/Check/ApplicationNotLibrary.pm
- lib/Lintian/Check/AppstreamMetadata.pm
- lib/Lintian/Check/Binaries/Architecture/Other.pm
- lib/Lintian/Check/Binaries/Hardening.pm
- lib/Lintian/Check/Binaries/LargeFileSupport.pm
- lib/Lintian/Check/Binaries/Location.pm
- lib/Lintian/Check/Binaries/Obsolete/Crypt.pm
- lib/Lintian/Check/Binaries/Prerequisites.pm
- lib/Lintian/Check/Binaries/Prerequisites/Numpy.pm
- lib/Lintian/Check/Binaries/Rpath.pm
- lib/Lintian/Check/Binaries/Spelling.pm
- lib/Lintian/Check/Binaries/Static.pm
- lib/Lintian/Check/BuildSystems/Autotools.pm
- lib/Lintian/Check/BuildSystems/Autotools/Libtool.pm
- lib/Lintian/Check/BuildSystems/Cmake.pm
- lib/Lintian/Check/BuildSystems/Waf.pm
- lib/Lintian/Check/Cruft.pm
- lib/Lintian/Check/DebFormat.pm
- lib/Lintian/Check/Debhelper.pm
- lib/Lintian/Check/Debian/Changelog.pm
- lib/Lintian/Check/Debian/Control/Field/BuiltUsing.pm
- lib/Lintian/Check/Debian/Control/Field/Relation.pm
- lib/Lintian/Check/Debian/Copyright.pm
- lib/Lintian/Check/Debian/Copyright/ApacheNotice.pm
The diff was not included because it is too large.
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/d53aff545cd8e66e5137e6f24a031cb8d1adad07...3419869095c6d8d05e7e770c0281af51855db3ef
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/d53aff545cd8e66e5137e6f24a031cb8d1adad07...3419869095c6d8d05e7e770c0281af51855db3ef
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] README.developers.pod: Explain the difference between a check and a test
Axel Beckert pushed to branch master at lintian / lintian Commits: f28bde63 by Axel Beckert at 2022-06-20T01:32:51+02:00 README.developers.pod: Explain the difference between a check and a test - - - - - 1 changed file: - doc/README.developers.pod Changes: = doc/README.developers.pod = @@ -100,6 +100,11 @@ most important ones: =over 4 +=item Check + +A library checking specific aspects of a package, changes file, +etc. which usually can emit multiple tags. + =item Emit (Tag) Tag that was not suppressed and was triggered. @@ -133,6 +138,10 @@ counted in statistics. Not to be confused with "Overridden". Issue reported by Lintian. +=item Test + +An internal test of Lintian. + =back =head2 Useful tricks View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f28bde63f1c4c00ddaf65b80ba4aee10186d205b -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f28bde63f1c4c00ddaf65b80ba4aee10186d205b You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new branch brackets-in-overrides-rc-bug-1003353
Axel Beckert pushed new branch brackets-in-overrides-rc-bug-1003353 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/brackets-in-overrides-rc-bug-1003353 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new tag 2.115.0
Axel Beckert pushed new tag 2.115.0 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/2.115.0 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 4 commits: Write a test which catches run-time errors of lightweight private scripts
Axel Beckert pushed to branch master at lintian / lintian Commits: 8ec7fc75 by Axel Beckert at 2022-06-21T12:43:39+02:00 Write a test which catches run-time errors of lightweight private scripts Triggered by autopkgtest failure of libconfig-model-dpkg-perl which runs private/latest-policy-version and failed. Gbp-Dch: Full - - - - - 74e9fe65 by Axel Beckert at 2022-06-21T12:45:13+02:00 Fix private/latest-policy-version: $p…-policy_releases → $p…-data-policy_releases Seems to have been forgotten when policy_releases() moved from Lintian::Profile to Lintian::Data. Should fix libconfig-model-dpkg-perl autopkgtest. Gbp-Dch: Full - - - - - 65a0c7db by Axel Beckert at 2022-06-21T12:45:13+02:00 Fix documentation of Lintian::Data-new() - - - - - 6dd3c1b1 by Axel Beckert at 2022-06-21T12:45:13+02:00 Switch all GPL URLs in boilerplates to HTTPS - - - - - 30 changed files: - bin/lintian - bin/lintian-annotate-hints - bin/lintian-explain-tags - commands/reporting-harness.pm - commands/reporting-html-reports.pm - commands/reporting-lintian-harness.pm - commands/reporting-sync-state.pm - lib/Lintian/Archive.pm - lib/Lintian/Changelog.pm - lib/Lintian/Changelog/Version.pm - lib/Lintian/Check.pm - lib/Lintian/Check/Apache2.pm - lib/Lintian/Check/ApplicationNotLibrary.pm - lib/Lintian/Check/AppstreamMetadata.pm - lib/Lintian/Check/Apt.pm - lib/Lintian/Check/Archive/File/Name/Length.pm - lib/Lintian/Check/Archive/Liberty/Mismatch.pm - lib/Lintian/Check/Archive/NonFree/Autobuild.pm - lib/Lintian/Check/Binaries.pm - lib/Lintian/Check/Binaries/Architecture.pm - lib/Lintian/Check/Binaries/Architecture/Other.pm - lib/Lintian/Check/Binaries/Corrupted.pm - lib/Lintian/Check/Binaries/DebugSymbols.pm - lib/Lintian/Check/Binaries/DebugSymbols/Detached.pm - lib/Lintian/Check/Binaries/Hardening.pm - lib/Lintian/Check/Binaries/LargeFileSupport.pm - lib/Lintian/Check/Binaries/Location.pm - lib/Lintian/Check/Binaries/Obsolete/Crypt.pm - lib/Lintian/Check/Binaries/Prerequisites.pm - lib/Lintian/Check/Binaries/Prerequisites/Numpy.pm The diff was not included because it is too large. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/9891622bd15d0a72c0ff1802706be863b2811fbe...6dd3c1b15e2e58fb2dfd0d5507850e115e798251 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/9891622bd15d0a72c0ff1802706be863b2811fbe...6dd3c1b15e2e58fb2dfd0d5507850e115e798251 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Replace all occurrences of "Copyright ©" with "Copyright (C)" again until...
Axel Beckert pushed to branch master at lintian / lintian Commits: d53aff54 by Axel Beckert at 2022-06-11T16:49:27+02:00 Replace all occurrences of Copyright © with Copyright (C) again until https://github.com/Perl-Critic/Perl-Critic/issues/925 is fixed This more or less reverts 1a3f6eeeaef3f31aa28e699a82f509b7a7d50fc3 (Replace Copyright (C) with the Unicode copyright symbol in our own code for consistency.) for now. - - - - - 30 changed files: - bin/lintian - bin/lintian-annotate-hints - bin/lintian-explain-tags - bin/spellintian - commands/reporting-harness.pm - commands/reporting-html-reports.pm - commands/reporting-lintian-harness.pm - commands/reporting-sync-state.pm - lib/Lintian/Archive.pm - lib/Lintian/Changelog.pm - lib/Lintian/Changelog/Entry.pm - lib/Lintian/Changelog/Version.pm - lib/Lintian/Check.pm - lib/Lintian/Check/Apache2.pm - lib/Lintian/Check/ApplicationNotLibrary.pm - lib/Lintian/Check/AppstreamMetadata.pm - lib/Lintian/Check/Apt.pm - lib/Lintian/Check/Archive/File/Name/Length.pm - lib/Lintian/Check/Archive/Liberty/Mismatch.pm - lib/Lintian/Check/Archive/NonFree/Autobuild.pm - lib/Lintian/Check/Binaries.pm - lib/Lintian/Check/Binaries/Architecture.pm - lib/Lintian/Check/Binaries/Architecture/Other.pm - lib/Lintian/Check/Binaries/Corrupted.pm - lib/Lintian/Check/Binaries/DebugSymbols.pm - lib/Lintian/Check/Binaries/DebugSymbols/Detached.pm - lib/Lintian/Check/Binaries/Hardening.pm - lib/Lintian/Check/Binaries/LargeFileSupport.pm - lib/Lintian/Check/Binaries/Location.pm - lib/Lintian/Check/Binaries/Obsolete/Crypt.pm The diff was not included because it is too large. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/d53aff545cd8e66e5137e6f24a031cb8d1adad07 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/d53aff545cd8e66e5137e6f24a031cb8d1adad07 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new branch dpatch-removal
Axel Beckert pushed new branch dpatch-removal at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/dpatch-removal You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new branch fix-cruft-perlcritic
Axel Beckert pushed new branch fix-cruft-perlcritic at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/fix-cruft-perlcritic You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Add "lunar" as a known Ubuntu distribution.
Axel Beckert pushed to branch master at lintian / lintian Commits: f52fe078 by Simon Quigley at 2022-10-28T13:32:42-05:00 Add lunar as a known Ubuntu distribution. - - - - - 1 changed file: - vendors/ubuntu/main/data/changes-file/known-dists Changes: = vendors/ubuntu/main/data/changes-file/known-dists = @@ -32,3 +32,4 @@ hirsute impish jammy kinetic +lunar View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f52fe078adaf55310b49cd2d21d55669f67a34bc -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f52fe078adaf55310b49cd2d21d55669f67a34bc You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] .gitignore: Also ignore debian/*.debhelper files and drop wrong trailing slash for doc/lintian.html
Axel Beckert pushed to branch master at lintian / lintian Commits: e048f0e7 by Axel Beckert at 2022-09-10T17:52:51+02:00 .gitignore: Also ignore debian/*.debhelper files and drop wrong trailing slash for doc/lintian.html Merge potentially three very similar ignore rules into a single one. - - - - - 1 changed file: - .gitignore Changes: = .gitignore = @@ -1,6 +1,5 @@ /*-stamp -/debian/.debhelper/ -/debian/*.debhelper.* +/debian/*.debhelper* /debian/debhelper-build-stamp /debian/files /debian/lintian.substvars @@ -10,7 +9,7 @@ /doc/api.html/ /doc/README /doc/help.tmp -/doc/lintian.html/ +/doc/lintian.html /doc/lintian.txt /l10n/ /man/man*/ View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/e048f0e74ff77cd4853e1f35620b04f8ca48405b -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/e048f0e74ff77cd4853e1f35620b04f8ca48405b You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 4 commits: Replace egrep and fgrep in all test suite dummy packages with grep -E/-F
Axel Beckert pushed to branch master at lintian / lintian Commits: 99fb9320 by Axel Beckert at 2022-09-11T01:08:19+02:00 Replace egrep and fgrep in all test suite dummy packages with grep -E/-F - - - - - 96735a72 by Axel Beckert at 2022-09-11T01:08:19+02:00 Add build-dependencies of the test suite They have been forgotten in commit 258fb7fb. Taken from debian/tests/control and added !notest to each. - - - - - 29cb2a01 by Axel Beckert at 2022-09-11T01:13:05+02:00 Fix test broken by dpatch removal - - - - - c4998558 by Axel Beckert at 2022-09-11T01:13:29+02:00 Fix test broken by updating the list of virtual packages - - - - - 30 changed files: - debian/control - t/recipes/checks/build-systems/debhelper/maintainer-script/token/scripts-maintainer-general/build-spec/debian/postinst - t/recipes/checks/debhelper/debhelper-no-depends/eval/hints - t/recipes/checks/debhelper/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/debian/changelog/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/debian/copyright/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/debian/watch/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/documentation/files-uses-dpkg-database-directly/build-spec/orig/test-1 - t/recipes/checks/fields/dm-upload-allowed/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/fields/mail-address/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/fields/package-relations/fields-depends-general/eval/hints - t/recipes/checks/fields/standards-version/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/files/contents/files-uses-dpkg-database-directly/build-spec/orig/test-1 - t/recipes/checks/files/contents/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/files/contents/scripts-maintainer-general/build-spec/debian/postinst - t/recipes/checks/init-d/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/init-d/maintainer-script/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/maintainer-scripts/empty/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/maintainer-scripts/generated/scripts-maintainer-general/build-spec/debian/postinst - t/recipes/checks/maintainer-scripts/helper/dpkg/scripts-maintainer-general/build-spec/debian/postinst - t/recipes/checks/maintainer-scripts/ldconfig/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/maintainer-scripts/mknod/scripts-maintainer-general/build-spec/debian/postinst - t/recipes/checks/maintainer-scripts/temporary-files/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/maintainer-scripts/temporary-files/scripts-maintainer-general/build-spec/debian/postinst - t/recipes/checks/md5sums/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/nmu/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/script/syntax/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/script/syntax/scripts-maintainer-general/build-spec/debian/postinst - t/recipes/checks/scripts/legacy-maintainer-scripts/build-spec/debian/preinst - t/recipes/checks/scripts/legacy-maintainer-scripts/eval/hints The diff was not included because it is too large. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/be8c92f08d16a4a151e8f81d1c1d5922ab5b7ec8...c49985584b737628c6dde27b6d71e84dfa715ae9 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/be8c92f08d16a4a151e8f81d1c1d5922ab5b7ec8...c49985584b737628c6dde27b6d71e84dfa715ae9 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 2 commits: Make "lintian --version" emit versions unique per commit
Axel Beckert pushed to branch master at lintian / lintian
Commits:
9b6ce500 by Axel Beckert at 2023-01-02T21:15:13+01:00
Make lintian --version emit versions unique per commit
It previously only added the amount of commits since last release to
the patch version if it was at zero. Which is anything but the claimed
Semantic Versioning.
- - - - -
e45c1668 by Axel Beckert at 2023-01-02T21:15:13+01:00
Make lib/Lintian/Version.pm perltidy again
Gbp-Dch: Ignore
- - - - -
1 changed file:
- lib/Lintian/Version.pm
Changes:
=
lib/Lintian/Version.pm
=
@@ -83,15 +83,20 @@ sub version_from_git {
return $EMPTY
unless -d $git_path;
-my $describe
- = decode_utf8(safe_qx('git', "--git-dir=$git_path", 'describe'));
+# Example outputs:
+# 2.115.3-49-g086a9a113
+# 2.115.3-49-g086a9a113-dirty
+my $describe = decode_utf8(
+safe_qx('git', "--git-dir=$git_path", 'describe', '--dirty'));
chomp $describe;
-my ($guess, $step, $commit) = split(/-/, $describe);
-return $EMPTY
- unless defined $step;
-
-$guess =~ s/ [.] 0 $/.$step/sx;
+# Modify it to make it a valid native version number and make it
+# look more debianish like these:
+# 2.115.3+49commits+git086a9a113
+# 2.115.3+49commits+git086a9a113+dirty
+my $guess = $describe;
+$guess =~ s/ - ( \d+ ) -g /+${1}commits+git/sx;
+$guess =~ s/ - /+/sxg;
return ($guess // $EMPTY);
}
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/37770b159e9cb222c8357fcb645456507445f3ca...e45c166839b78dbbe8f1b30d3c64d1fe7f504ce0
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/37770b159e9cb222c8357fcb645456507445f3ca...e45c166839b78dbbe8f1b30d3c64d1fe7f504ce0
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Salsa CI: Override the lintian version being used to the just built version
Axel Beckert pushed to branch master at lintian / lintian
Commits:
f0f98771 by Axel Beckert at 2023-01-02T06:42:02+01:00
Salsa CI: Override the lintian version being used to the just built version
Should fix Salsa CI autopokgtest failures due to e.g.
newer-standards-version if lintian in unstable doesnt know about the
new debian-policy release yet.
- - - - -
1 changed file:
- debian/salsa-ci.yml
Changes:
=
debian/salsa-ci.yml
=
@@ -26,3 +26,10 @@ build-buster-backports:
variables:
SALSA_CI_LINTIAN_FAIL_WARNING: 1
DEB_BUILD_OPTIONS: 'nocheck'
+
+# Try to override the lintian version being used to the just built
+# version.
+.test-lintian:
+ before_script:
+ - apt-get update
+ - apt-get install -y ${WORKING_DIR}/lintian_*.deb
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/f0f98771e8ebab8bc86c959c023a65339532e167
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/f0f98771e8ebab8bc86c959c023a65339532e167
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 2 commits: dh-sequence-vim-addon pulls in dh-vim-addon
Axel Beckert pushed to branch master at lintian / lintian
Commits:
4cc5a245 by Edward Betts at 2023-01-02T14:39:38+01:00
dh-sequence-vim-addon pulls in dh-vim-addon
Fix false positive for missing-build-dependency-for-dh-addon when
a package Build-Depends on dh-sequence-vim-addon.
- - - - -
089a22f4 by Russ Allbery at 2023-01-02T14:48:45+01:00
Fix typo in dh-sequence-vim-addon pulls in dh-vim-addon
Gbp-Dch: Ignore
- - - - -
1 changed file:
- lib/Lintian/Check/Debhelper.pm
Changes:
=
lib/Lintian/Check/Debhelper.pm
=
@@ -125,6 +125,7 @@ my %DH_ADDON_MANUAL_PREREQUISITES = (
'sphinx:any | python-sphinx:any | python3-sphinx:any |
dh-sequence-sphinxdoc:any',
systemd =>
'debhelper:any (>= 9.20160709~) | debhelper-compat:any |
dh-sequence-systemd:any | dh-systemd:any',
+vim_addon => 'dh-vim-addon:any | dh-sequence-vim-addon:any',
);
sub visit_patched_files {
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/f0f98771e8ebab8bc86c959c023a65339532e167...089a22f48baa8cb8aca42cb8a4b53471a94e3fcf
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/f0f98771e8ebab8bc86c959c023a65339532e167...089a22f48baa8cb8aca42cb8a4b53471a94e3fcf
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] missing-systemd-service-for-init.d-script: Mention future deprecation of generator
Axel Beckert pushed to branch master at lintian / lintian Commits: 4ce38e3c by Luca Boccassi at 2023-01-02T17:02:59+01:00 missing-systemd-service-for-init.d-script: Mention future deprecation of generator The generator will be deprecated in the future, so packages without a unit file will stop working. [Committers note: This is half of MR !407 which was authored by Luca as a single commit. Hence Ive changed to first line of the commit message accordingly.] - - - - - 1 changed file: - tags/m/missing-systemd-service-for-init.d-script.tag Changes: = tags/m/missing-systemd-service-for-init.d-script.tag = @@ -5,6 +5,7 @@ Explanation: The specified init.d script has no equivalent systemd service. . Whilst systemd has a SysV init.d script compatibility mode, providing native systemd support has many advantages such as being able to specify - security hardening features. + security hardening features. Moreover, the systemd SysV generator will be + deprecated in the future. . Please provide a suitable .service file for this script. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/4ce38e3ccb9c5fee9e4f99d55b3bc93b7f3d7c61 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/4ce38e3ccb9c5fee9e4f99d55b3bc93b7f3d7c61 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new branch dh-vim-addon
Axel Beckert pushed new branch dh-vim-addon at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/dh-vim-addon You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][salsa-debug] Make "lintian --version" emit versions unique per commit
Axel Beckert pushed to branch salsa-debug at lintian / lintian
Commits:
287d4230 by Axel Beckert at 2023-01-02T14:23:18+01:00
Make lintian --version emit versions unique per commit
It previously only added the amount of commits since last release to
the patch version if it was at zero. Which is anything but the claimed
Semantic Versioning.
- - - - -
1 changed file:
- lib/Lintian/Version.pm
Changes:
=
lib/Lintian/Version.pm
=
@@ -83,15 +83,20 @@ sub version_from_git {
return $EMPTY
unless -d $git_path;
+# Example outputs:
+# 2.115.3-49-g086a9a113
+# 2.115.3-49-g086a9a113-dirty
my $describe
- = decode_utf8(safe_qx('git', "--git-dir=$git_path", 'describe'));
+ = decode_utf8(safe_qx('git', "--git-dir=$git_path", 'describe',
'--dirty'));
chomp $describe;
-my ($guess, $step, $commit) = split(/-/, $describe);
-return $EMPTY
- unless defined $step;
-
-$guess =~ s/ [.] 0 $/.$step/sx;
+# Modify it to make it a valid native version number and make it
+# look more debianish like these:
+# 2.115.3+49commits+git086a9a113
+# 2.115.3+49commits+git086a9a113+dirty
+my $guess = $describe;
+$guess =~ s/ - ( \d+ ) -g /+${1}commits+git/sx;
+$guess =~ s/ - /+/sxg;
return ($guess // $EMPTY);
}
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/287d4230e7f234afcb2a814efbf0cff01f58f61a
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/287d4230e7f234afcb2a814efbf0cff01f58f61a
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Declare compliance with Debian Policy 4.6.2
Axel Beckert pushed to branch master at lintian / lintian Commits: 36a9bf61 by Axel Beckert at 2022-12-18T12:00:54+01:00 Declare compliance with Debian Policy 4.6.2 No other seem necessary for that. - - - - - 1 changed file: - debian/control Changes: = debian/control = @@ -59,7 +59,7 @@ Build-Depends: wamerican , wbritish , zip -Standards-Version: 4.6.1 +Standards-Version: 4.6.2 Rules-Requires-Root: no Vcs-Git: https://salsa.debian.org/lintian/lintian.git Vcs-Browser: https://salsa.debian.org/lintian/lintian View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/36a9bf61b8b05a1cea92fd1ed118ef063e8e8149 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/36a9bf61b8b05a1cea92fd1ed118ef063e8e8149 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Make test for generate-tag-summary more precise and properly cover all cases
Axel Beckert pushed to branch master at lintian / lintian
Commits:
2dab187d by Axel Beckert at 2022-12-22T01:56:58+01:00
Make test for generate-tag-summary more precise and properly cover all cases
See also MR !435. Thanks @pollo!
- - - - -
1 changed file:
- t/scripts/run-private-scripts.t
Changes:
=
t/scripts/run-private-scripts.t
=
@@ -60,7 +60,11 @@ sub t {
}
t('auto-reject-diff', qr/Found \d+ certain/);
-t('generate-tag-summary', qr/Assuming commit range to be/, qr/tags/);
+t(
+'generate-tag-summary',
+qr/Assuming commit range to be/,
+qr/^No tags were added or removed$|\A\Z/
+);
t('latest-policy-version', qr/^(\d+\.){3}/);
done_testing();
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/2dab187df35671f7ce867871fa4ee0753912
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/2dab187df35671f7ce867871fa4ee0753912
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Fix false positive for license-problem-php-license for pear.php.net source code
Axel Beckert pushed to branch master at lintian / lintian
Commits:
53f5b4d2 by William Desportes at 2023-01-16T02:54:14+00:00
Fix false positive for license-problem-php-license for pear.php.net source code
- - - - -
2 changed files:
- lib/Lintian/Check/Cruft.pm
- tags/l/license-problem-php-license.tag
Changes:
=
lib/Lintian/Check/Cruft.pm
=
@@ -657,7 +657,7 @@ sub php_source_whitelist {
return 0
if defined $copyright_path
&& $copyright_path->bytes
- =~ m{^Source: https?://pecl.php.net/package/.*$}m;
+ =~ m{^Source: https?://(pecl|pear).php.net/package/.*$}m;
return 0
if $self->processable->source_name =~ /^php\d*(?:\.\d+)?$/xms;
=
tags/l/license-problem-php-license.tag
=
@@ -5,6 +5,6 @@ Explanation: This package appears to be covered by version 3.0
(exactly) of the
PHP license. This license is not applicable to anything that is not PHP
and has no contributions from the PHP Group.
.
- This tag is not emitted for packages from pecl.php.net as determined by
+ This tag is not emitted for packages from pecl.php.net or pear.php.net as
determined by
the Source: field in debian/copyright.
See-Also: https://ftp-master.debian.org/REJECT-FAQ.html
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/53f5b4d23ae17d7468efe92b999cfb38d8b6c799
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/53f5b4d23ae17d7468efe92b999cfb38d8b6c799
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 3 commits: debian/control: Bump Standards-Version in Description to 4.6.2
Axel Beckert pushed to branch master at lintian / lintian
Commits:
861bcc1e by Axel Beckert at 2023-01-17T01:53:09+01:00
debian/control: Bump Standards-Version in Description to 4.6.2
Gbp-Dch: Ignore
- - - - -
abf85a66 by Axel Beckert at 2023-01-17T02:15:44+01:00
run-private-scripts.t: Do not run auto-reject-diff as it requires network
access.
- - - - -
08d50d35 by Axel Beckert at 2023-01-17T02:42:56+01:00
run-private-scripts.t: Skip generate-tag-summary without git
- - - - -
2 changed files:
- debian/control
- t/scripts/run-private-scripts.t
Changes:
=
debian/control
=
@@ -168,4 +168,4 @@ Description: Debian package checker
compliance with Debian policy. Every Debian maintainer should check packages
with this tool before uploading them to the archive.
.
- This version of Lintian is calibrated for Debian Policy version 4.6.1.
+ This version of Lintian is calibrated for Debian Policy version 4.6.2.
=
t/scripts/run-private-scripts.t
=
@@ -24,7 +24,7 @@ use warnings;
use Const::Fast;
use IPC::Run3;
-use Test::More tests => 3;
+use Test::More tests => 2;
const my $DOT => q{.};
const my $WAIT_STATUS_SHIFT => 8;
@@ -59,12 +59,15 @@ sub t {
return;
}
-t('auto-reject-diff', qr/Found \d+ certain/);
-t(
-'generate-tag-summary',
-qr/Assuming commit range to be/,
-qr/^No tags were added or removed$|\A\Z/
-);
+SKIP: {
+skip('Only works with git', 1) unless -x '/usr/bin/git' && -d '.git';
+
+t(
+'generate-tag-summary',
+qr/Assuming commit range to be/,
+qr/^No tags were added or removed$|\A\Z/
+);
+}
t('latest-policy-version', qr/^(\d+\.){3}/);
done_testing();
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/a3c688e61d78413f3c631a6db720c14f4e6e46b2...08d50d35e7a6481808e9b54f3f3d77d09309a445
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/a3c688e61d78413f3c631a6db720c14f4e6e46b2...08d50d35e7a6481808e9b54f3f3d77d09309a445
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new tag 2.116.0
Axel Beckert pushed new tag 2.116.0 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/2.116.0 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] bitbucket.org no more supports Mercurial
Axel Beckert pushed to branch master at lintian / lintian Commits: 78d9ec4f by Axel Beckert at 2023-01-17T08:06:55+01:00 bitbucket.org no more supports Mercurial https://bitbucket.org/blog/sunsetting-mercurial-support-in-bitbucket - - - - - 1 changed file: - data/fields/vcs-hosters Changes: = data/fields/vcs-hosters = @@ -28,4 +28,4 @@ git://gitorious\.org/ ~~ Git git://[a-zA-Z0-9]+\.branchable\.com/ ~~ Git git://repo\.or\.cz/~~ Git https?://repo\.or\.cz/ ~~ Git -https?://bitbucket\.org/ ~~ Git,Hg +https?://bitbucket\.org/ ~~ Git View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/78d9ec4f37cc61125c9ad2b694b04512010700e2 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/78d9ec4f37cc61125c9ad2b694b04512010700e2 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Fix a boolean precedence issue in the additional condition of MR !442
Axel Beckert pushed to branch master at lintian / lintian
Commits:
438a8252 by Axel Beckert at 2023-01-18T12:18:48+01:00
Fix a boolean precedence issue in the additional condition of MR !442
Gbp-Dch: Ignore
- - - - -
1 changed file:
- lib/Lintian/Check/Documentation.pm
Changes:
=
lib/Lintian/Check/Documentation.pm
=
@@ -124,8 +124,8 @@ sub visit_installed_files {
=~ m{^ usr/share/doc/ (?:.+/)? (?:doxygen|html) / .* [.]map [.] $regex
}sx;
if ($item->is_file
-&& any { $item->basename =~ m{$_}xi } @DOCUMENTATION_FILE_REGEXES
-&& any { $item->basename !~ m{$_}xi } @NOT_DOCUMENTATION_FILE_REGEXES)
{
+and any { $item->basename =~ m{$_}xi } @DOCUMENTATION_FILE_REGEXES
+and any { $item->basename !~ m{$_}xi }
@NOT_DOCUMENTATION_FILE_REGEXES) {
$self->pointed_hint(
'package-contains-documentation-outside-usr-share-doc',
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/438a82523dc66c765d356df4205dff90647d63ea
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/438a82523dc66c765d356df4205dff90647d63ea
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Release and upload as 2.116.1 to unstable
Axel Beckert pushed to branch master at lintian / lintian Commits: 0a783122 by Axel Beckert at 2023-01-23T03:37:24+01:00 Release and upload as 2.116.1 to unstable - - - - - 1 changed file: - debian/changelog Changes: = debian/changelog = @@ -1,8 +1,34 @@ -lintian (2.116.1~git) UNRELEASED; urgency=medium +lintian (2.116.1) unstable; urgency=medium - * WIP (generated at release time: please do not add entries below). + The "No More Neglected Autopkgtest Architectures" Release. - -- Axel Beckert Tue, 17 Jan 2023 08:03:32 +0100 + [ Axel Beckert ] + * bitbucket.org no more supports Mercurial. + * [Testsuite] Fix armhf+i386-only test binaries-missing-lfs. Should fix +autopkgtest on these architectures. + * unknown-section description: Factorize explanations to avoid repitions +as suggested by Cyril Brulebois. (See also below.) + * Fix remaining i386 testsuite issues due to missing brackets. + * Don't emit inconsistent-appstream-metadata-license with "MIT != +Expat". (Closes: #1029055) + * Update Lintian User's Manual for pointed hints in tags and overrides. +Thanks to Soren Stoutner. (Closes: #1029177) + * Whitelist Autobuild, Go-Import-Path, and Ruby-Versions from +unknown-field. (Closes: #1014885) + * Don't emit spare-manual-page for binaries in /usr/libexec/. +(Closes: #1027744) + * Refresh static data. + * data/java/constants: Default is now Java17, versions available up to Java21. + + [ Cyril Brulebois ] + * Add non-free-firmware to known archive areas. + + [ William Desportes ] + * Fix lintian package-contains-documentation-outside-usr-share-doc +matches python files and robots.txt. (Closes: #997987, #976636) + * Add more typo fixes. + + -- Axel Beckert Mon, 23 Jan 2023 03:32:04 +0100 lintian (2.116.0) unstable; urgency=medium View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/0a783122b55c331290d8d4956447d6b8ce02 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/0a783122b55c331290d8d4956447d6b8ce02 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new tag 2.116.1
Axel Beckert pushed new tag 2.116.1 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/2.116.1 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Post-release version bump
Axel Beckert pushed to branch master at lintian / lintian Commits: d59fdac4 by Axel Beckert at 2023-01-29T16:34:44+01:00 Post-release version bump Gbp-Dch: Ignore - - - - - 1 changed file: - debian/changelog Changes: = debian/changelog = @@ -1,3 +1,9 @@ +lintian (2.116.3~git) UNRELEASED; urgency=medium + + * WIP (generated at release time: please do not add entries below.) + + -- Axel Beckert Sun, 29 Jan 2023 16:34:44 +0100 + lintian (2.116.2) unstable; urgency=medium The "FFP2 (Fixing False Positives, too)" Release. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/d59fdac4686191ad9605fa8a51c9348017b840ab -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/d59fdac4686191ad9605fa8a51c9348017b840ab You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Lintian::Check::Files::SourceMissing: Ignore files in debian/missing-sources/
Axel Beckert pushed to branch master at lintian / lintian
Commits:
81c4d841 by William Desportes at 2023-01-29T00:22:23+01:00
Lintian::Check::Files::SourceMissing: Ignore files in debian/missing-sources/
Fixes false positives in tags source-is-missing,
source-contains-prebuilt-javascript-object and friends.
Gbp-Dch: Full
- - - - -
1 changed file:
- lib/Lintian/Check/Files/SourceMissing.pm
Changes:
=
lib/Lintian/Check/Files/SourceMissing.pm
=
@@ -55,6 +55,9 @@ sub visit_patched_files {
return
unless $item->is_file;
+return
+ if $item->dirname =~ m{^debian/missing-sources/};
+
# prebuilt-file or forbidden file type
$self->pointed_hint('source-contains-prebuilt-wasm-binary', $item->pointer)
if $item->file_type =~ m{^WebAssembly \s \(wasm\) \s binary \s module}x;
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/81c4d8416161a5e69004d22e8760b2f5d0e0e1e5
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/81c4d8416161a5e69004d22e8760b2f5d0e0e1e5
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 2 commits: Add testsuite check for missing-pkg-php-tools-addon false positive with...
Axel Beckert pushed to branch master at lintian / lintian
Commits:
1a794ba7 by Axel Beckert at 2023-01-28T23:18:17+01:00
Add testsuite check for missing-pkg-php-tools-addon false positive with
dh-sequence-phpcomposer (see MR !438)
- - - - -
472de40c by William Desportes at 2023-01-28T23:23:58+01:00
missing-pkg-php-tools-addon: Allow dh-sequence-phpcomposer as alternative to
pkg-php-tools-addon
(perltidy variant of MR !438)
- - - - -
7 changed files:
- lib/Lintian/Check/Languages/Php/Pear.pm
- +
t/recipes/checks/languages/php/pear/phppear-composerok/build-spec/debian/control.in
- +
t/recipes/checks/languages/php/pear/phppear-composerok/build-spec/fill-values
- +
t/recipes/checks/languages/php/pear/phppear-composerok/build-spec/orig/composer.json
- +
t/recipes/checks/languages/php/pear/phppear-composerok/build-spec/orig/foo.php
- + t/recipes/checks/languages/php/pear/phppear-composerok/eval/desc
- + t/recipes/checks/languages/php/pear/phppear-composerok/eval/hints
Changes:
=
lib/Lintian/Check/Languages/Php/Pear.pm
=
@@ -149,7 +149,8 @@ sub source {
$self->pointed_hint('composer-package-without-pkg-php-tools-builddep',
$composer_json->pointer)
if defined $composer_json
- && !$build_depends->satisfies('pkg-php-tools')
+ && !($build_depends->satisfies('pkg-php-tools')
+|| $build_depends->satisfies('dh-sequence-phpcomposer'))
&& !defined $package_xml
&& !defined $package2_xml;
=
t/recipes/checks/languages/php/pear/phppear-composerok/build-spec/debian/control.in
=
@@ -0,0 +1,20 @@
+Source: [% $source %]
+Priority: optional
+Section: [% $section %]
+Maintainer: [% $author %]
+Standards-Version: [% $standards_version %]
+Build-Depends: [% $build_depends %], dh-sequence-phpcomposer, php-dev, dh-php
+Rules-Requires-Root: no
+
+Package: [% $source %]
+Architecture: [% $package_architecture %]
+Depends: ${misc:Depends}, ${phppear:Debian-Depends}
+Recommends: ${phppear:Debian-Recommends}
+Breaks: ${phppear:Debian-Breaks}
+Description: ${phppear:summary}
+ This is a test package designed to exercise some feature or tag of
+ Lintian. It is part of the Lintian test suite and may do very odd
+ things. It should not be installed like a regular package. It may
+ be an empty package.
+ .
+ ${phppear:description}
=
t/recipes/checks/languages/php/pear/phppear-composerok/build-spec/fill-values
=
@@ -0,0 +1,3 @@
+Testname: phppear-composerok
+Description: Composer phppear tests with dh-sequence-phpcomposer
+Skeleton: upload-non-native
=
t/recipes/checks/languages/php/pear/phppear-composerok/build-spec/orig/composer.json
=
@@ -0,0 +1 @@
+{}
=
t/recipes/checks/languages/php/pear/phppear-composerok/build-spec/orig/foo.php
=
=
t/recipes/checks/languages/php/pear/phppear-composerok/eval/desc
=
@@ -0,0 +1,4 @@
+Testname: phppear-composerok
+Test-Against:
+ missing-pkg-php-tools-addon
+Check: languages/php/pear
=
t/recipes/checks/languages/php/pear/phppear-composerok/eval/hints
=
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/5400667211bf4af86265d579cfe743c7a43cc992...472de40cabc960117f18ca0cb7562840ed36fe18
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/5400667211bf4af86265d579cfe743c7a43cc992...472de40cabc960117f18ca0cb7562840ed36fe18
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new tag 2.116.2
Axel Beckert pushed new tag 2.116.2 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/2.116.2 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Release as 2.116.2 and upload to unstable
Axel Beckert pushed to branch master at lintian / lintian Commits: a89ceb5f by Axel Beckert at 2023-01-29T09:54:24+01:00 Release as 2.116.2 and upload to unstable - - - - - 1 changed file: - debian/changelog Changes: = debian/changelog = @@ -1,11 +1,61 @@ -lintian (2.116.2~git) UNRELEASED; urgency=medium +lintian (2.116.2) unstable; urgency=medium + The "FFP2 (Fixing False Positives, too)" Release. + + [ Axel Beckert ] * Add private script to automate post release version bump. * Fix typo in previous debian/changelog entry. Thanks Lintian! ;-) - --- - * WIP (generated at release time: please do not add entries below.) + * Mention that #1024039 got closed by 2.116.1 in its changelog entry. + * [Testsuite] Check tag files and docs with spellintian. Thanks to +Sylvestre Ledru for noticing the typos this check now finds. + * Fix duplicate words and one more typo found by +spellintian-textual-content.t. + * "currectly" can be a misspelling of "correctly" or "currently" + * Fix spellintian false positives found by spellintian-textual-content.t: ++ "these package" followed by a plural, e.g. "these package sections", ++ Double word with closing parenthesis inbetween. (So far only opening + parentheses were whitelisted.) + * Add testsuite check for missing-pkg-php-tools-addon false positive +with dh-sequence-phpcomposer. (See MR !438.) + * Add testsuite check for a vcs-field-has-unexpected-spaces false +positive. (See #1023155 and MR !422.) + * debian-rules-uses-unnecessary-dh-argument: Also report found and +minimum dh compat level. Additionally also rephrase tag description to +no more say "this debhelper compatibility level". Thanks to Anthony +Fok for making us aware of the issue in MR !451. + + [ Cyril Brulebois ] + * Teach the is_non_free attribute about the non-free-firmware section. + * Stop checking for Standards-Version for installer-only (i.e. udeb) +packages. (Closes: #991533) + + [ Andreas Beckmann ] + * backports-upload-has-incorrect-version-number: Fix salsaci version +regexp again. (Closes: #1024361) + + [ Sylvestre Ledru ] + * Fix some typos in the doc. + + [ William Desportes ] + * missing-pkg-php-tools-addon: Allow dh-sequence-phpcomposer as +alternative to pkg-php-tools-addon. + * Lintian::Check::Files::SourceMissing: Ignore files in +debian/missing-sources/. Fixes false positives in source-is-missing, +source-contains-prebuilt-javascript-object and friends. + + [ Tino Didriksen ] + * vcs-field-has-unexpected-spaces: Allow any order of git branch and +path. (Closes: #1023155) Thanks to Bradford D. Boyle for the bug +report. + + [ Johannes Schauer Marin Rodrigues ] + * Multiarch terminology: Use "qualifier" instead of "acceptor": Update +tag descriptions of rules-require-build-prerequisite and +missing-build-depends-for-clean-target-in-debian-rules. Also rename +method multiarch_acceptor() to multiarch_qualifier() in + Lintian::Relation::Predicate. - -- Axel Beckert Mon, 23 Jan 2023 12:46:07 +0100 + -- Axel Beckert Sun, 29 Jan 2023 09:32:16 +0100 lintian (2.116.1) unstable; urgency=medium @@ -27,7 +77,8 @@ lintian (2.116.1) unstable; urgency=medium * Don't emit spare-manual-page for binaries in /usr/libexec/. (Closes: #1027744) * Refresh static data. - * data/java/constants: Default is now Java17, versions available up to Java21. + * data/java/constants: Default is now Java17, versions available up to +Java21. (Closes: #1024039) [ Cyril Brulebois ] * Add non-free-firmware to known archive areas. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/a89ceb5f25e5e45d97a7f26c7dd9971a7a1de51d -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/a89ceb5f25e5e45d97a7f26c7dd9971a7a1de51d You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 4 commits: inconsistent-appstream-metadata-license: Versions with trailing ".0" are...
Axel Beckert pushed to branch master at lintian / lintian
Commits:
2348bca3 by Axel Beckert at 2023-01-16T01:10:28+01:00
inconsistent-appstream-metadata-license: Versions with trailing .0
are equivalent to versions without
Fixes false positives as the Debian Copyright Format 1.0 explicitly
states that versions with trailing dot-zeroes are considered to be
equivalent to versions without.
Closes: #1002053
Relevant documentation:
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-short-name
- - - - -
3721f292 by Axel Beckert at 2023-01-16T01:10:39+01:00
inconsistent-appstream-metadata-license: Normalize comparison (-or-later/+,
-only suffix)
Further normalize comparison of Debian style and SPDX style license
identifiers to -or-later suffix vs + suffix, -only suffix vs no
suffix.
Still display the original variant in the tag.
Relevant documentation/policy:
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-short-name
(Also make new code perltidy.)
- - - - -
e48f1d48 by Axel Beckert at 2023-01-16T01:27:45+01:00
inconsistent-appstream-metadata-license description: Text improvements; direct
ref to tag specification
Closes: #1014956
- - - - -
bf82908d by Christoph Biedl at 2023-01-16T01:40:03+01:00
Lintian::Index::FileTypes: Call file with --raw to
unbreak test suite with file/libmagic ≥ 5.42
Closes: #1026920
- - - - -
3 changed files:
- lib/Lintian/Check/Debian/Copyright/Dep5.pm
- lib/Lintian/Index/FileTypes.pm
- tags/i/inconsistent-appstream-metadata-license.tag
Changes:
=
lib/Lintian/Check/Debian/Copyright/Dep5.pm
=
@@ -852,8 +852,30 @@ sub check_dep5_copyright {
next
unless $seen;
+# Compare and also normalize the seen and wanted license
+# identifier wrt. to redundant trailing dot-zeros,
+# -or-later suffix vs + suffix, -only suffix vs no
+# suffix. Still display the original variant in the tag.
+my $seen_normalized = $seen;
+$seen_normalized =~ s/-or-later$/+/i;
+$seen_normalized =~ s/-only$//i;
+my $seen_nozero = $seen_normalized;
+$seen_nozero =~ s/\.0//g;
+
my @wanted = @{$license_identifiers_by_file{$name}};
-my @mismatched = grep { $_ ne $seen } @wanted;
+my @mismatched = grep {
+my $want = $_;
+my $want_normalized = $want;
+$want_normalized =~ s/-or-later$/+/i;
+$want_normalized =~ s/-only$//i;
+my $want_nozero = $want_normalized;
+$want_nozero =~ s/\.0//g;
+
+$want_normalized ne $seen_normalized
+ and $want_nozero ne $seen_normalized
+ and $want_normalized ne $seen_nozero
+ and $want_nozero ne $seen_nozero;
+} @wanted;
$self->pointed_hint('inconsistent-appstream-metadata-license',
$copyright_file->pointer, $name, "($seen != $_)")
=
lib/Lintian/Index/FileTypes.pm
=
@@ -72,7 +72,7 @@ sub add_file_types {
my @files = grep { $_->is_file } @{$self->sorted_list};
my @names = map { $_->name } @files;
-my @command = qw(file --no-pad --print0 --print0 --);
+my @command = qw(file --raw --no-pad --print0 --print0 --);
my %file_types;
=
tags/i/inconsistent-appstream-metadata-license.tag
=
@@ -2,7 +2,9 @@ Tag: inconsistent-appstream-metadata-license
Severity: warning
Check: debian/copyright/dep5
Explanation: The specified AppStream metadata file specifies a
- metadatalicense field but this does not match the files
in
+ metadatalicense field but this does not match
+ its entry (possibly via the Files: * stanza) in
debian/copyright.
See-Also: https://wiki.debian.org/AppStream/Guidelines,
- https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+ https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/,
+
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-metadata_license
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/6bf8452625fb7ebbbad0af23a225557ac146dd99...bf82908d338b9125ed5ba737d50bdfd85f829bee
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/6bf8452625fb7ebbbad0af23a225557ac146dd99...bf82908d338b9125ed5ba737d50bdfd85f829bee
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Fix "Use of uninitialized value $LINTIAN_CFG" in debug output
Axel Beckert pushed to branch master at lintian / lintian
Commits:
f03fc15a by Axel Beckert at 2023-03-05T16:26:04+01:00
Fix Use of uninitialized value $LINTIAN_CFG in debug output
- - - - -
1 changed file:
- bin/lintian
Changes:
=
bin/lintian
=
@@ -614,7 +614,7 @@ unless (@ARGV || $selected{'packages-from-file'}) {
if ($selected{debug}) {
say {*STDERR} encode_utf8("Lintian v$ENV{LINTIAN_VERSION}");
say {*STDERR} encode_utf8("Lintian root directory: $ENV{LINTIAN_BASE}");
-say {*STDERR} encode_utf8("Configuration file: $LINTIAN_CFG");
+say {*STDERR} encode_utf8('Configuration file: '.($LINTIAN_CFG//'(none)'));
}
if (defined $selected{LINTIAN_PROFILE}) {
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/f03fc15a45df4965e374b1e3a40c51cf6fe545ed
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/f03fc15a45df4965e374b1e3a40c51cf6fe545ed
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Release and upload as 2.116.3 to unstable
Axel Beckert pushed to branch master at lintian / lintian Commits: cac78dd8 by Axel Beckert at 2023-02-05T10:29:00+01:00 Release and upload as 2.116.3 to unstable - - - - - 1 changed file: - debian/changelog Changes: = debian/changelog = @@ -1,8 +1,19 @@ -lintian (2.116.3~git) UNRELEASED; urgency=medium +lintian (2.116.3) unstable; urgency=medium - * WIP (generated at release time: please do not add entries below.) + The "FFP3 (Fixing False Positives, Three Small Changes)" Release. - -- Axel Beckert Sun, 29 Jan 2023 16:34:44 +0100 + [ Axel Beckert ] + * Refresh data. (Loong64 removed from two lists, some fonts and dh_cruft +added.) + + [ Simon McVittie ] + * obsolete-packages: libegl1-mesa-dev is not obsolete. + + [ Andreas Beckmann ] + * archive-liberty-mismatch: Add exception for 'non-free-firmware binary +package build from non-free source package'. (Closes: #1030325) + + -- Axel Beckert Sun, 05 Feb 2023 09:10:20 +0100 lintian (2.116.2) unstable; urgency=medium View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/cac78dd88e1171e88ee8c3d6f5b1155b8081863d -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/cac78dd88e1171e88ee8c3d6f5b1155b8081863d You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new tag 2.116.3
Axel Beckert pushed new tag 2.116.3 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/2.116.3 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 2 commits: Post-release version bump
Axel Beckert pushed to branch master at lintian / lintian Commits: 1e177f85 by Axel Beckert at 2023-02-05T11:30:30+01:00 Post-release version bump Gbp-Dch: Ignore - - - - - d50a732a by Andreas Beckmann at 2023-02-05T11:37:36+01:00 dh_dkms is now provided by dh-dkms instead of dkms (See #1013417) Gbp-Dch: Full - - - - - 2 changed files: - debian/changelog - lib/Lintian/Check/Debhelper.pm Changes: = debian/changelog = @@ -1,3 +1,9 @@ +lintian (2.116.4~git) UNRELEASED; urgency=medium + + * WIP (generated at release time: please do not add entries below.) + + -- Axel Beckert Sun, 05 Feb 2023 11:30:30 +0100 + lintian (2.116.3) unstable; urgency=medium The "FFP3 (Fixing False Positives, Three Small Changes)" Release. = lib/Lintian/Check/Debhelper.pm = @@ -81,7 +81,7 @@ my %DH_COMMAND_MANUAL_PREREQUISITES = ( 'dh-autoreconf:any | debhelper:any (>= 9.20160403~) | debhelper-compat:any', dh_autoreconf => 'dh-autoreconf:any | debhelper:any (>= 9.20160403~) | debhelper-compat:any', -dh_dkms => 'dkms:any | dh-sequence-dkms:any', +dh_dkms => 'dh-dkms:any | dh-sequence-dkms:any', dh_girepository => 'gobject-introspection:any | dh-sequence-gir:any', dh_gnome => 'gnome-pkg-tools:any | dh-sequence-gnome:any', dh_gnome_clean => 'gnome-pkg-tools:any | dh-sequence-gnome:any', View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/cac78dd88e1171e88ee8c3d6f5b1155b8081863d...d50a732a00a7596d078a9e8f6919cb6362ca0067 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/cac78dd88e1171e88ee8c3d6f5b1155b8081863d...d50a732a00a7596d078a9e8f6919cb6362ca0067 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Run perltidy on lib/Lintian/Check/AppstreamMetadata.pm
Axel Beckert pushed to branch master at lintian / lintian
Commits:
f1c99de5 by Axel Beckert at 2024-02-04T21:13:09+01:00
Run perltidy on lib/Lintian/Check/AppstreamMetadata.pm
Gbp-Dch: Ignore
- - - - -
1 changed file:
- lib/Lintian/Check/AppstreamMetadata.pm
Changes:
=
lib/Lintian/Check/AppstreamMetadata.pm
=
@@ -97,8 +97,8 @@ sub installable {
foreach my $lib_dir (qw(usr/lib lib)) {
if (
defined(
-my $dir =
-$processable->installed->resolve_path("$lib_dir/udev/rules.d/")
+my $dir = $processable->installed->resolve_path(
+"$lib_dir/udev/rules.d/")
)
) {
for my $item ($dir->descendants) {
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/f1c99de500180c2b67ed3f383401f36a20ab1d32
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/f1c99de500180c2b67ed3f383401f36a20ab1d32
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 3 commits: Add *~ to .gitignore
Axel Beckert pushed to branch master at lintian / lintian
Commits:
5bffcd9a by Richard Lewis at 2024-02-05T00:50:58+00:00
Add *~ to .gitignore
- - - - -
40f26ce4 by Richard Lewis at 2024-02-05T00:50:58+00:00
Add test that demonstrates bug #1019690
lintian exits with code 2 when --show-overrides is given and an error is fixed.
The test added will fail: the next commit will fix lintian so it passes.
- - - - -
372ac9c8 by Richard Lewis at 2024-02-05T00:50:58+00:00
Fix exit code when --show-overrides is given and an error tag is
overridden
Previously, if an error tag was overridden but --show-overrides was given,
lintian would correctly override the tag, but incorrectly give an exit
code of 2.
The reason is a logic error in lib/Lintian/Pool.pm in the code from lines
173-212
The whole block seems to be attempting to:
- skip hints (tags) that should not be displayed (experimental, or at a too-low
display-level)
- count number of errors/warnings that remain (used in line 217 to set exit
code)
- keep hints that should be displayed (line 211)
Because on line 194, if an error tag is overridden and
--show-overrides is given the block
decided not to call next (because keeping the hint doesnt happen until line
211).
But then line 197 is executed which means that the hint is counted as a
warning/error/etc whenever
show-overrides was present: effectively show-overrides makes it look like no
override was present.
(And then on line 217 the exit_code will be set to 2).
This patch therefore changes 197 to only run the sub-block if an override was
not defined.
- - - - -
8 changed files:
- .gitignore
- lib/Lintian/Pool.pm
- +
t/recipes/lintian-features/exit-status/show-overrides-exit-status/build-spec/debian/install
- +
t/recipes/lintian-features/exit-status/show-overrides-exit-status/build-spec/debian/lintian-overrides
- +
t/recipes/lintian-features/exit-status/show-overrides-exit-status/build-spec/fill-values
- +
t/recipes/lintian-features/exit-status/show-overrides-exit-status/build-spec/orig/file
- + t/recipes/lintian-features/exit-status/show-overrides-exit-status/eval/desc
- +
t/recipes/lintian-features/exit-status/show-overrides-exit-status/eval/literal
Changes:
=
.gitignore
=
@@ -17,6 +17,7 @@
/.idea/
/.nobackup
*.bak
+*~
*.rej
cover_db*
/coverage-report
=
lib/Lintian/Pool.pm
=
@@ -191,8 +191,7 @@ sub process{
next
unless $PROFILE->display_level_for_tag($hint->tag_name);
-if (!defined $hint->override
-|| $option->{'show-overrides'}) {
+if (!defined $hint->override) {
++$reported_count{$tag->visibility}
if !$tag->experimental;
=
t/recipes/lintian-features/exit-status/show-overrides-exit-status/build-spec/debian/install
=
@@ -0,0 +1 @@
+file /usr/share/file
=
t/recipes/lintian-features/exit-status/show-overrides-exit-status/build-spec/debian/lintian-overrides
=
@@ -0,0 +1,2 @@
+# package installs a d/rules template not a script
+missing-dep-for-interpreter /usr/bin/make *
=
t/recipes/lintian-features/exit-status/show-overrides-exit-status/build-spec/fill-values
=
@@ -0,0 +1,3 @@
+Skeleton: upload-native
+Testname: show-overrides-exit-status
+Description: Bug #1019690 correct exit status when show-overrides
=
t/recipes/lintian-features/exit-status/show-overrides-exit-status/build-spec/orig/file
=
@@ -0,0 +1,4 @@
+#!/usr/bin/make -f
+
+%:
+ dh $@ --with elpa
=
t/recipes/lintian-features/exit-status/show-overrides-exit-status/eval/desc
=
@@ -0,0 +1,6 @@
+Testname: show-overrides-exit-status
+Check: scripts
+Exit-Status: 0
+Match-Strategy: literal
+Output-Format: EWI
+Default-Lintian-Options: --show-overrides --fail-on error
=
t/recipes/lintian-features/exit-status/show-overrides-exit-status/eval/literal
=
@@ -0,0 +1,2 @@
+N: package installs a d/rules template not a script
+O: show-overrides-exit-status: missing-dep-for-interpreter /usr/bin/make (does
not satisfy make:any | build-essential:any | dpkg-dev:any) [usr/share/file/file]
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/151989ab43db9082c02a75e5d3683fe0bbd6c4cc...372ac9c821c29df356378c9ec3f66dd7cefb94ce
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/151989ab43db9082c02a75e5d3683fe0bbd6c4cc...372ac9c821c29df356378c9ec3f66dd7cefb
[Git][lintian/lintian][master] 2 commits: Add build-depedency on debhleper ≥ 13.11.8~ if the test suite is run at build-time
Axel Beckert pushed to branch master at lintian / lintian
Commits:
6940c6a8 by Axel Beckert at 2024-02-05T01:28:37+01:00
Add build-depedency on debhleper ≥ 13.11.8~ if the test suite is run at
build-time
- - - - -
c9b6c94c by Axel Beckert at 2024-02-05T01:28:52+01:00
L::C::B::Corrupted::check_elf_issues(): Return immediately if file is no ELF
file
Thanks: Corvin Köhne via MR !486
I implemented it differently than Corvin to avoid code duplication and
to be more future proof in case non-ELF issues will be checked in the
future with visit_*_files().
- - - - -
2 changed files:
- debian/control
- lib/Lintian/Check/Binaries/Corrupted.pm
Changes:
=
debian/control
=
@@ -9,6 +9,7 @@ Build-Depends:
aspell ,
aspell-en ,
cdbs ,
+ debhelper (>= 13.11.8~) ,
debhelper-compat (= 13),
default-jdk-headless | default-jdk ,
dh-elpa | bash (<< 4.4) ,
=
lib/Lintian/Check/Binaries/Corrupted.pm
=
@@ -53,6 +53,8 @@ sub visit_installed_files {
sub check_elf_issues {
my ($self, $item) = @_;
+return unless $item->is_elf;
+
for (uniq @{$item->elf->{ERRORS} // []}) {
$self->pointed_hint('elf-error',$item->pointer, $_)
unless (
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/b69e774798c3c63992b869739421ac3bb2c2948f...c9b6c94c91e3c142c172dce9d51f82b08dfad69d
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/b69e774798c3c63992b869739421ac3bb2c2948f...c9b6c94c91e3c142c172dce9d51f82b08dfad69d
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] obsolete-packages: another common old Builld-Dep
Axel Beckert pushed to branch master at lintian / lintian Commits: 151989ab by Alexandre Detiste at 2024-02-05T00:42:44+00:00 obsolete-packages: another common old Builld-Dep - - - - - 1 changed file: - data/fields/obsolete-packages Changes: = data/fields/obsolete-packages = @@ -151,6 +151,7 @@ libgsasl7-dev => libgsasl-dev libidn11-dev => libidn-dev policykit-1 => polkitd and optionally pkexec lsb-base +pkg-config => pkgconf # Deprecated in trixie gnome-common => https://wiki.gnome.org/Projects/GnomeCommon/Migration View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/151989ab43db9082c02a75e5d3683fe0bbd6c4cc -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/151989ab43db9082c02a75e5d3683fe0bbd6c4cc You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Allow @recommends@ as autopkgtest dependency
Axel Beckert pushed to branch master at lintian / lintian
Commits:
c738fa47 by Valentin Vidic at 2024-02-05T02:30:13+00:00
Allow @recommends@ as autopkgtest dependency
Replaces deprecated needs-recommends.
- - - - -
1 changed file:
- lib/Lintian/Check/Testsuite.pm
Changes:
=
lib/Lintian/Check/Testsuite.pm
=
@@ -62,6 +62,7 @@ our $PYTHON3_ALL_DEPEND
my %KNOWN_SPECIAL_DEPENDS = map { $_ => 1 } qw(
@
@builddeps@
+ @recommends@
);
sub source {
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/c738fa474b4b0e737edece78c8553a6fc76442d7
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/c738fa474b4b0e737edece78c8553a6fc76442d7
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Some more usrmerge-related test suite fine-tuning
Axel Beckert pushed to branch master at lintian / lintian Commits: b69e7747 by Axel Beckert at 2024-02-05T00:10:20+01:00 Some more usrmerge-related test suite fine-tuning Git-Dch: Ignore - - - - - 2 changed files: - t/recipes/checks/systemd/kill-mode-none/eval/hints - t/recipes/checks/systemd/service-file-no-install-key/build-spec/debian/install Changes: = t/recipes/checks/systemd/kill-mode-none/eval/hints = @@ -1,2 +1,2 @@ kill-mode-none (binary): systemd-service-file-missing-hardening-features [usr/lib/systemd/system/kill-mode-none.service] -kill-mode-none (binary): kill-mode-none lib/systemd/system/kill-mode-none.service [usr/lib/systemd/system/kill-mode-none.service] +kill-mode-none (binary): kill-mode-none usr/lib/systemd/system/kill-mode-none.service [usr/lib/systemd/system/kill-mode-none.service] = t/recipes/checks/systemd/service-file-no-install-key/build-spec/debian/install = @@ -1 +1 @@ -debian/no-install.service lib/systemd/system/ +debian/no-install.service usr/lib/systemd/system/ View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/b69e774798c3c63992b869739421ac3bb2c2948f -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/b69e774798c3c63992b869739421ac3bb2c2948f You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Don't emit source-nmu-has-incorrect-version-number for stable updates
Axel Beckert pushed to branch master at lintian / lintian
Commits:
79d146ac by Emilio Pozuelo Monfort at 2024-02-05T00:56:05+00:00
Dont emit source-nmu-has-incorrect-version-number for stable updates
Closes: #1022759
- - - - -
1 changed file:
- lib/Lintian/Check/Nmu.pm
Changes:
=
lib/Lintian/Check/Nmu.pm
=
@@ -102,6 +102,7 @@ sub source {
my $version_nmuness = 0;
my $version_local = 0;
my $upload_is_backport = $version =~ m/~bpo(\d+)\+(\d+)$/;
+my $upload_is_stable_update = $version =~ m/~deb(\d+)u(\d+)$/;
if ($version =~ /-[^.-]+(\.[^.-]+)?(\.[^.-]+)?$/) {
$version_nmuness = 1 if defined $1;
@@ -158,6 +159,7 @@ sub source {
$pointer, $version)
if $upload_is_nmu
&& $version_nmuness != 1
+ && !$upload_is_stable_update
&& !$upload_is_backport;
}
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/79d146acb7b4784cea4e7cd705de9f9854e98bd6
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/79d146acb7b4784cea4e7cd705de9f9854e98bd6
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Salsa CI: Drop backports to bullseye (oldstable): We expect a newer debhelper
Axel Beckert pushed to branch master at lintian / lintian Commits: cd755962 by Axel Beckert at 2024-02-05T03:55:52+01:00 Salsa CI: Drop backports to bullseye (oldstable): We expect a newer debhelper ... for the test suite to pass as it now uses path as present after dh_movetousr has been run. And despite the build profile nocheck is passed, apt build-dep in bullseye tries to satisfy !nocheck build-dependencies nevertheless and hence fails to install an older version of debhelper, despite it would have been fine. - - - - - 1 changed file: - debian/salsa-ci.yml Changes: = debian/salsa-ci.yml = @@ -16,13 +16,6 @@ build-bookworm-backports: extends: .build-package allow_failure: true -build-bullseye-backports: - variables: -RELEASE: 'bullseye-backports' -DEB_BUILD_OPTIONS: 'nocheck' - extends: .build-package - allow_failure: true - variables: SALSA_CI_DISABLE_BLHC: 1 SALSA_CI_DISABLE_BUILD_PACKAGE_ANY: 1 View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/cd7559626912ade82df64ea4474008fb56ec3970 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/cd7559626912ade82df64ea4474008fb56ec3970 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] private/generate-tag-summary --in-place: Avoid mojibake by not double-encoding UTF-8
Axel Beckert pushed to branch master at lintian / lintian
Commits:
4fd76dc5 by Axel Beckert at 2024-02-05T21:34:04+01:00
private/generate-tag-summary --in-place: Avoid mojibake by not double-encoding
UTF-8
- - - - -
1 changed file:
- private/generate-tag-summary
Changes:
=
private/generate-tag-summary
=
@@ -95,7 +95,7 @@ if ($opt{'in-place'}) {
or die encode_utf8("Cannot open $infile");
my $outfile = 'debian/changelog.tmp';
-open(my $out_fd, '>:encoding(UTF-8)', $outfile)
+open(my $out_fd, '>', $outfile)
or die encode_utf8("Cannot open $outfile");
while (my $line = <$in_fd>) {
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/4fd76dc585013a0a5ff646797385514721f1ad3b
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/4fd76dc585013a0a5ff646797385514721f1ad3b
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian] Pushed new tag 2.117.0
Axel Beckert pushed new tag 2.117.0 at lintian / lintian -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/tree/2.117.0 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Post-release version bump
Axel Beckert pushed to branch master at lintian / lintian Commits: f2746dd7 by Axel Beckert at 2024-02-05T23:25:47+01:00 Post-release version bump Gbp-Dch: Ignore - - - - - 1 changed file: - debian/changelog Changes: = debian/changelog = @@ -1,3 +1,9 @@ +lintian (2.117.1~git) UNRELEASED; urgency=medium + + * WIP (generated at release time: please do not add entries below.) + + -- Axel Beckert Mon, 05 Feb 2024 23:25:47 +0100 + lintian (2.117.0) unstable; urgency=low The "One Year Later" Release. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f2746dd7c37314e836f6d4f9fac0bcad84d53f5a -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/f2746dd7c37314e836f6d4f9fac0bcad84d53f5a You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 2 commits: Retroactively mention #1033894 in previous changelog entry
Axel Beckert pushed to branch master at lintian / lintian Commits: 66e9477a by Axel Beckert at 2024-02-06T08:16:00+01:00 Retroactively mention #1033894 in previous changelog entry We normaly should never do that as it breaks gbp dch. Unless nothing else than the debian/changelog has been changed since a release. As in this case. :-) - - - - - 27896ef1 by Axel Beckert at 2024-02-06T08:24:22+01:00 data/changes-file/known-dists: Add trixie and forky - - - - - 2 changed files: - data/changes-file/known-dists - debian/changelog Changes: = data/changes-file/known-dists = @@ -11,6 +11,8 @@ stretch buster bullseye bookworm +trixie +forky sid # Aliases @@ -19,4 +21,3 @@ stable testing unstable experimental - = debian/changelog = @@ -1,5 +1,8 @@ lintian (2.117.1~git) UNRELEASED; urgency=medium + [ Axel Beckert ] + * Retroactively mention #1033894 in previous changelog entry. + * WIP (generated at release time: please do not add entries below.) -- Axel Beckert Mon, 05 Feb 2024 23:25:47 +0100 @@ -55,7 +58,7 @@ lintian (2.117.0) unstable; urgency=low [ Nilesh Patra ] * Make lintian recognize fasttrack as a dist. - * Update known dists and oldstable epoch. + * Update known dists and oldstable epoch. (Closes: #1033894) * autopkgtest fix: Update badnocredit.raw for updated Adobe license tag check. * Fix rootless-builds.txt location in lintian tags. (Closes: #1051538) View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/f2746dd7c37314e836f6d4f9fac0bcad84d53f5a...27896ef12c526253ca5f9d49967d1670550f6597 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/f2746dd7c37314e836f6d4f9fac0bcad84d53f5a...27896ef12c526253ca5f9d49967d1670550f6597 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Fix inconsistencies in documentation of lintian-explain-tags
Axel Beckert pushed to branch master at lintian / lintian Commits: b5146d82 by Edu Gómez Escandell at 2024-05-06T01:20:20+00:00 Fix inconsistencies in documentation of lintian-explain-tags - - - - - 2 changed files: - bin/lintian-explain-tags - man/lintian-explain-tags.pod Changes: = bin/lintian-explain-tags = @@ -151,7 +151,7 @@ Usage: $NEW_PROGRAM_NAME [log-file...] ... Options: -l, --list-tagslist all tags Lintian knows about --t, --tag, --tags display tag descriptions +-t, --tag, --tags this option has no effect. --include-dir DIR check for Lintian data in DIR --profile Xuse vendor profile X to determine severities --output-width NUM set output width instead of probing terminal = man/lintian-explain-tags.pod = @@ -26,7 +26,7 @@ lintian-explain-tags - offer more information about Lintian's tags =head1 SYNOPSIS -B B<--tags> I ... +B I ... =head1 DESCRIPTION View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/b5146d82b452c0503f98a836e40409fb20cd09d7 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/b5146d82b452c0503f98a836e40409fb20cd09d7 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] wrong-path-for-interpreter: allow aliased locations
Axel Beckert pushed to branch master at lintian / lintian
Commits:
9266486e by Luca Boccassi at 2024-05-06T01:57:46+01:00
wrong-path-for-interpreter: allow aliased locations
merged-usr is mandatory in Debian since Bookworm (and much longer ago
in Ubuntu), so /usr/bin/bash is a valid path, as is /bin/python3.
Detect and ignore these instances.
Closes: #1051338
- - - - -
2 changed files:
- lib/Lintian/Check/Scripts.pm
- t/recipes/checks/scripts/scripts-control-interpreters/eval/hints
Changes:
=
lib/Lintian/Check/Scripts.pm
=
@@ -47,6 +47,7 @@ const my $NOT_EQUAL => q{!=};
const my $BAD_MAINTAINER_COMMAND_FIELDS => 5;
const my $UNVERSIONED_INTERPRETER_FIELDS => 2;
const my $VERSIONED_INTERPRETER_FIELDS => 5;
+const my $USR_PREFIX_LENGTH => 4;
use Moo;
use namespace::clean;
@@ -692,10 +693,17 @@ sub visit_control_files {
'incorrect-path-for-interpreter'
: 'wrong-path-for-interpreter';
+# Debian is now mandatory usr-merged, so /bin/sh and /usr/bin/sh are both
acceptable
+if ($expected =~ '^(/bin/|/sbin/)') {
+$expected = '(?:/usr)?' . $expected;
+} elsif ($expected =~ '^/usr(/bin/|/sbin/)') {
+$expected = '(?:/usr)?' . substr($expected, $USR_PREFIX_LENGTH);
+}
+
$self->pointed_hint(
$tag_name, $item->pointer, $interpreter,
$NOT_EQUAL, $expected
-)unless $interpreter eq $expected;
+)unless $interpreter =~ $expected;
} elsif ($item->name eq 'config') {
$self->pointed_hint('forbidden-config-interpreter',
@@ -716,10 +724,17 @@ sub visit_control_files {
'incorrect-path-for-interpreter'
: 'wrong-path-for-interpreter';
+# Debian is now mandatory usr-merged, so /bin/sh and /usr/bin/sh are both
acceptable
+if ($expected =~ '^(/bin/|/sbin/)') {
+$expected = '(?:/usr)?' . $expected;
+} elsif ($expected =~ '^/usr(/bin/|/sbin/)') {
+$expected = '(?:/usr)?' . substr($expected, $USR_PREFIX_LENGTH);
+}
+
$self->pointed_hint(
$tag_name, $item->pointer, $interpreter,
$NOT_EQUAL, $expected
-)unless $interpreter eq $expected;
+)unless $interpreter =~ $expected;
$self->pointed_hint('unusual-control-interpreter', $item->pointer,
$interpreter);
=
t/recipes/checks/scripts/scripts-control-interpreters/eval/hints
=
@@ -9,8 +9,6 @@ scripts-control-interpreters-prepython (binary):
unusual-control-interpreter /us
scripts-control-interpreters-prepython (binary): unusual-control-interpreter
/usr/bin/python3 [postinst]
scripts-control-interpreters-prepython (binary): maintainer-script-interpreter
/usr/bin/python3 [preinst]
scripts-control-interpreters-prepython (binary): maintainer-script-interpreter
/usr/bin/python3 [postinst]
-scripts-control-interpreters-paths (binary): wrong-path-for-interpreter
/usr/bin/bash != /bin/bash [postinst]
-scripts-control-interpreters-paths (binary): wrong-path-for-interpreter
/bin/python3 != /usr/bin/python3 [prerm]
scripts-control-interpreters-paths (binary): unusual-control-interpreter
/bin/python3 [prerm]
scripts-control-interpreters-paths (binary): maintainer-script-interpreter
/usr/local/bin/bash [preinst]
scripts-control-interpreters-paths (binary): maintainer-script-interpreter
/usr/bin/bash [postinst]
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/9266486e228fa9dcc20e6500f909c7b3c07b93b0
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/9266486e228fa9dcc20e6500f909c7b3c07b93b0
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Upgrade the severity of missing-systemd-service-for-init.d-script from warning to error
Axel Beckert pushed to branch master at lintian / lintian Commits: 5faaefd9 by Luca Boccassi at 2024-05-05T21:17:29+00:00 Upgrade the severity of missing-systemd-service-for-init.d-script from warning to error The generator will be deprecated during the Trixie dev cycle, so packages without a unit file will stop working. Policy has been updated accordingly: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1039102 - - - - - 1 changed file: - tags/m/missing-systemd-service-for-init.d-script.tag Changes: = tags/m/missing-systemd-service-for-init.d-script.tag = @@ -1,5 +1,5 @@ Tag: missing-systemd-service-for-init.d-script -Severity: warning +Severity: error Check: systemd Explanation: The specified init.d script has no equivalent systemd service. . View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/5faaefd9f0c11c4bc5ab12b0bc713459e041de93 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/5faaefd9f0c11c4bc5ab12b0bc713459e041de93 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] 3 commits: Fix regex replacement for transition suffix g
Axel Beckert pushed to branch master at lintian / lintian
Commits:
b2561ac7 by Mattias Ellert at 2024-05-06T00:04:04+00:00
Fix regex replacement for transition suffix g
The replacement should remove a final g after a digit, but leave the
digit in place, e.g. libpam0g → libpam0 and libgjs0g → libgjs0.
- - - - -
a4c658ff by Mattias Ellert at 2024-05-06T00:04:04+00:00
Only remove transition suffices when preceded by a digit
- - - - -
07167eeb by Mattias Ellert at 2024-05-06T00:04:04+00:00
Add transition suffix t64 for 64 bit time_t transition
- - - - -
1 changed file:
- lib/Lintian/Check/Libraries/Shared/Soname.pm
Changes:
=
lib/Lintian/Check/Libraries/Shared/Soname.pm
=
@@ -83,11 +83,12 @@ sub installable {
# try to strip transition strings
my $shortened_name = $self->processable->name;
-$shortened_name =~ s/c102\b//;
-$shortened_name =~ s/c2a?\b//;
-$shortened_name =~ s/\dg$//;
-$shortened_name =~ s/gf$//;
-$shortened_name =~ s/v[5-6]$//; # GCC-5 / libstdc++6 C11 ABI breakage
+$shortened_name =~ s/(\d)c102$/$1/;
+$shortened_name =~ s/(\d)c2a?$/$1/;
+$shortened_name =~ s/(\d)g$/$1/;
+$shortened_name =~ s/(\d)gf$/$1/;
+$shortened_name =~ s/(\d)v[56]$/$1/; # GCC-5 / libstdc++6 C11 ABI breakage
+$shortened_name =~ s/(\d)t64$/$1/; # 64 bit time_t
$shortened_name =~ s/-udeb$//;
$shortened_name =~ s/^lib64/lib/;
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/dfc03ef87409473bc76e287fa2fd25b388f2e214...07167eebb697d74d84627b275d8aeff4ebf32f7e
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/dfc03ef87409473bc76e287fa2fd25b388f2e214...07167eebb697d74d84627b275d8aeff4ebf32f7e
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Improve CONTRIBUTING.md
Axel Beckert pushed to branch master at lintian / lintian Commits: 1df38cf7 by William Desportes at 2024-05-06T00:25:44+00:00 Improve CONTRIBUTING.md - - - - - 1 changed file: - CONTRIBUTING.md Changes: = CONTRIBUTING.md = @@ -152,7 +152,7 @@ will show you further options. ### Calibrating tests to fix test failures -If tests fail, the teststuite will use an interactive 'calibration' +If tests fail, the testsuite will use an interactive 'calibration' process to help you write or amend a 'hints' file. Simply follow the instructions on the screen. In many cases, it is best to "accept all" and examine the changes in git. In complex cases, you can use @@ -173,6 +173,25 @@ configure perltidy in a special way. Please run it from the repository's base directory. Otherwise it will not find the custom configuration, and the test suite will not pass. +### Run perltidy + +The program perltidy is provided by the package [perltidy](https://packages.debian.org/perltidy). +The program prove is provided by the package [perl](https://packages.debian.org/perl). + + On all files + +```sh +prove -l t/scripts/01-critic/ +``` + +### On recently changed files + +On the 10 last commits + +```sh +git diff --name-only HEAD~10 HEAD | grep -F ".pm" | xargs perltidy -b +``` + ### Submit a merge request Once all the above is done, please push your changes to your Lintian View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/1df38cf7438ff9fd8b389f61be715ec85e4d3e98 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/1df38cf7438ff9fd8b389f61be715ec85e4d3e98 You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] ci: check longer timeout for autopkgtest
Axel Beckert pushed to branch master at lintian / lintian
Commits:
3678cc5a by Kentaro Hayashi at 2024-05-06T00:08:56+09:00
ci: check longer timeout for autopkgtest
The default value of CI_JOB_TIMEOUT is 1h (3600), but autopkgtest will
not finish in 1 hour generally.
lintian/lintian CI/CD setting of timeout is extended to 3h, but
not true for forked/contributors lintian CI/CD settings - so it always
fail.
This MR aimed to fix warn such a situation in advance.
Signed-off-by: Kentaro Hayashi ken...@gmail.com
- - - - -
1 changed file:
- debian/salsa-ci.yml
Changes:
=
debian/salsa-ci.yml
=
@@ -28,3 +28,13 @@ variables:
before_script:
- apt-get update
- apt-get install -y ${WORKING_DIR}/lintian_*.deb
+
+# Try to check whether the maximum job timeout is extended to longer one.
+.test-autopkgtest:
+ before_script:
+- 'echo "CI/CD Settings / General pipelines / Timeout: $CI_JOB_TIMEOUT
seconds"'
+- |
+ if [[ $CI_JOB_TIMEOUT -le 3600 ]]; then
+echo -e "\e[31;1mERROR: CI/CD Settings / General pipelines / Timeout
is too short ($CI_JOB_TIMEOUT). Use longer timeout - e.g. 7200 (2h) is
enough.\e[0m"
+exit 1
+ fi
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/3678cc5ac32075ce91496168b692aa7c2fbd7d85
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/3678cc5ac32075ce91496168b692aa7c2fbd7d85
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Rewrite files/contents/line-length in a more effective manner.
Axel Beckert pushed to branch master at lintian / lintian
Commits:
71198035 by Andrius Merkys at 2024-06-10T00:52:06+00:00
Rewrite files/contents/line-length in a more effective manner.
- - - - -
1 changed file:
- lib/Lintian/Check/Files/Contents/LineLength.pm
Changes:
=
lib/Lintian/Check/Files/Contents/LineLength.pm
=
@@ -31,13 +31,13 @@ use warnings;
use utf8;
use Const::Fast;
-use List::UtilsBy qw(max_by);
use Unicode::UTF8 qw(encode_utf8 decode_utf8 valid_utf8);
const my $GREATER_THAN => q{>};
const my $VERTICAL_BAR => q{|};
const my $VERY_LONG => 512;
+const my $ITEM_NOT_FOUND => -1;
use Moo;
use namespace::clean;
@@ -97,10 +97,12 @@ sub visit_patched_files {
open(my $fd, '<', $item->unpacked_path)
or die encode_utf8('Cannot open ' . $item->unpacked_path);
-my %line_lengths;
-
-my $position = 1;
+my $longest;
+my $length = $ITEM_NOT_FOUND;
+my $position = 0;
while (my $line = <$fd>) {
+$position++;
+
# Skip SQL insert and select statements
next if ($line =~ /^(INSERT|SELECT)\s/i
and $item->basename =~ /sql/i);
@@ -109,24 +111,22 @@ sub visit_patched_files {
$line = decode_utf8($line)
if valid_utf8($line);
-$line_lengths{$position} = length $line;
-
-} continue {
-++$position;
+if( length $line > $length ) {
+$longest = $position;
+$length = length $line;
+}
}
close $fd;
-my $longest = max_by { $line_lengths{$_} } keys %line_lengths;
-
return
unless defined $longest;
my $pointer = $item->pointer($longest);
$self->pointed_hint('very-long-line-length-in-source-file',
-$pointer, $line_lengths{$longest}, $GREATER_THAN, $VERY_LONG)
- if $line_lengths{$longest} > $VERY_LONG;
+$pointer, $length, $GREATER_THAN, $VERY_LONG)
+ if $length > $VERY_LONG;
return;
}
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/7119803571b9abb8cea3a4834e0c2e6b183fffba
--
This project does not include diff previews in email notifications.
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/7119803571b9abb8cea3a4834e0c2e6b183fffba
You're receiving this email because of your account on salsa.debian.org.
[Git][lintian/lintian][master] Salsa-CI: Extend autopkgtest job timeout to 3h by default
Axel Beckert pushed to branch master at lintian / lintian
Commits:
2b05a303 by Otto Kekäläinen at 2024-05-22T20:25:13-07:00
Salsa-CI: Extend autopkgtest job timeout to 3h by default
Looking at current open MRs for Lintian, nearly all of them fail on
autopkgtest timing out. Seems contributors are not looking at the
CI output and reading the error. Fix this by forcing the timeout to 3h
directly from within the GitLab CI definition.
This renders the existing `before_script` section obsolete, but keep it
still around as fall-back to satisfy those who have concerns that the
`timeout` might not always work.
- - - - -
1 changed file:
- debian/salsa-ci.yml
Changes:
=
debian/salsa-ci.yml
=
@@ -29,8 +29,11 @@ variables:
- apt-get update
- apt-get install -y ${WORKING_DIR}/lintian_*.deb
-# Try to check whether the maximum job timeout is extended to longer one.
.test-autopkgtest:
+ # Extend Salsa-CI build jobs to have longer timeout as the default GitLab
+ # timeout (1h) is often not enough.
+ timeout: 3h
+ # Try to check whether the maximum job timeout is extended to longer one.
before_script:
- 'echo "CI/CD Settings / General pipelines / Timeout: $CI_JOB_TIMEOUT
seconds"'
- |
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/2b05a303b2ebe4afa92b4b79e61f31c8bee0ae47
--
This project does not include diff previews in email notifications.
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/commit/2b05a303b2ebe4afa92b4b79e61f31c8bee0ae47
You're receiving this email because of your account on salsa.debian.org.
