Re: A common group on salsa.debian.org for R packages ?

[Andreas Tille]

Hi Frederic,

On Thu, Jan 11, 2018 at 10:45:30AM +, PICCA Frederic-Emmanuel wrote:
> >  The people who
> >  contributed to the decision (including me) consider the advantage
> >  to maintain R packages in a technical team higher than to keep
> >  everything in Debian Science.
> 
> I am just wondering if it is not always better to put packages in under the 
> language team umbrella.
> For exemple to put all the python modules from Debian-science into the Debian 
> Python Team.

You have a point definitely but the according language team needs to
agree to take over those packages.  For instance I'm currently working
on pandas (#884294) and I clearly agree that somebody with more Python
competence should work on this.  But there is no volunteer obviously
(not even a response to the bug report so far).  There are just cases
where a language team explicitly refused to take a package.  Well, I
admit the people who care in Debian Science / Debian Med could join the
language team and use the repository there.  But in some cases it is not
really clear who cares - not always those who are listed as Uploader
care in practice and I'm personally reading lists with different
priorities.  So if I as a team member notice some problem in a package
which obviously needs help (for instance pandas repeatedly) I will
notice way earlier if it is in a list I'm reading with higher priority.
 
> It is not clear to me how to draw a line between Debian Science vs Language 
> Team, when it comes to choose the team for a new package.

In short: There is no such rule to draw a line.

Kind regards

  Andreas.

-- 
http://fam-tille.de

RE:A common group on salsa.debian.org for R packages ?

[PICCA Frederic-Emmanuel]

Hello,

>  The people who
>  contributed to the decision (including me) consider the advantage
>  to maintain R packages in a technical team higher than to keep
>  everything in Debian Science.

I am just wondering if it is not always better to put packages in under the 
language team umbrella.
For exemple to put all the python modules from Debian-science into the Debian 
Python Team.

It is not clear to me how to draw a line between Debian Science vs Language 
Team, when it comes to choose the team for a new package.

Cheers

Frederic

Re: A common group on salsa.debian.org for R packages ?

[Boris Pek]

>>  Sorry for a late reply to this thread. But I am wondering: why have you
>>  decided to make a separate Salsa group instead of making of special
>>  subgroup in Debian Science Team group?
>
> Some additional arguments in addition to what Charles said:
>
>   * There were R packages from different teams (Debian Science and
> Debian Med currently, DebiChem also has R packages which are
> not yet merged). We want to have a common R team.
>
>   * In Debian there are somehow topic based teams (some are organised
> as Blends like Debian Science and Debian Med) and technique (mostly
> programming language) based teams (Python, Perl, etc.) In many
> cases you can argue whether a package belongs to a certain topic
> (or in which of the several potential topics) or the technical team.
> While R is clearly science oriented Debian Science might be the
> natural place but R is also a programming language. The people who
> contributed to the decision (including me) consider the advantage
> to maintain R packages in a technical team higher than to keep
> everything in Debian Science.

I see. Thanks for an explanation.

Best regards,
Boris

Re: A common group on salsa.debian.org for R packages ?

[Andreas Tille]

Hi Boris,

On Thu, Jan 11, 2018 at 12:34:05PM +0300, Boris Pek wrote:
> 
> Sorry for a late reply to this thread. But I am wondering: why have you
> decided to make a separate Salsa group instead of making of special
> subgroup in Debian Science Team group?

Some additional arguments in addition to what Charles said:

  * There were R packages from different teams (Debian Science and
Debian Med currently, DebiChem also has R packages which are
not yet merged).  We want to have a common R team.

  * In Debian there are somehow topic based teams (some are organised
as Blends like Debian Science and Debian Med) and technique (mostly
programming language) based teams (Python, Perl, etc.)  In many
cases you can argue whether a package belongs to a certain topic
(or in which of the several potential topics) or the technical team.
While R is clearly science oriented Debian Science might be the
natural place but R is also a programming language.  The people who
contributed to the decision (including me) consider the advantage
to maintain R packages in a technical team higher than to keep
everything in Debian Science. 

Kind regards

   Andreas.

-- 
http://fam-tille.de

Re: A common group on salsa.debian.org for R packages ?

[Charles Plessy]

Le Thu, Jan 11, 2018 at 12:34:05PM +0300, Boris Pek a écrit :
> >
> > Thus, people would only need to ask for membership if they want to
> > create a new project (needs Master level), or if they have a guest
> > account and are not member of the Science or Med team (that would be
> > Developer level).
> 
> Sorry for a late reply to this thread. But I am wondering: why have you
> decided to make a separate Salsa group instead of making of special
> subgroup in Debian Science Team group?

Hi Boris,

at that time I did not know about subgroups.

In any case, I think that it should not make a big differnece: since we
want to not only share the repositories with the whole science-team
group, but also with the Debian and the future Debian Med groups, we
need anyway to manage the group sharing of the repositories.

(In the long term we need to write a command that spots which
repositories are not appropriately shared, and corrects that).

Following the discussions on flat structures and stable URLs, I also
started to wonder about just putting the repositories in the Debian
group directly.  This would not make a big difference, except that the
risk of accident of a) our API calls to touch the wrong repository, and
b) other DD's API calls to mess accidently with our repositories would
be slightly higher.

Have a nice day,

Charles

-- 
Charles Plessy
Debian Med packaging team,
http://www.debian.org/devel/debian-med
Tsurumi, Kanagawa, Japan

Re: A common group on salsa.debian.org for R packages ?

[Boris Pek]

Hi,

>>> I will create a team on GitLab. How about "r-packages-team" ?
>> I consider r-pkg-team a more typical name.
>
> Thanks for the suggestion. I have just created the `r-pkg-team` group
> ("Debian R Packages Maintainers") on Salsa.
>
> https://salsa.debian.org/groups/r-pkg-team/
>
> For each package in the `r-pkg-team`, I propose to give Developer access
> to all the members of the groups Debian, science-team and the future
> Debian med team (no name chosen yet).
>
> It can be done programatically as follows.
>
> curl -X POST --header "Private-Token: $(cat gitlabtoken.txt)" 
> 'https://salsa.debian.org/api/v4/projects/$project_ID/share?group_id=$group_id_access=$access_level'
>
> (See https://docs.gitlab.com/ce/api/projects.html#share-project-with-group
>  and https://salsa.debian.org/help/user/permissions )
>
> It is not possible to make a group member of a group.
>
> Thus, people would only need to ask for membership if they want to
> create a new project (needs Master level), or if they have a guest
> account and are not member of the Science or Med team (that would be
> Developer level).

Sorry for a late reply to this thread. But I am wondering: why have you
decided to make a separate Salsa group instead of making of special
subgroup in Debian Science Team group?

Best regards,
Boris

Re: A common group on salsa.debian.org for R packages ?

[Charles Plessy]

Le Tue, Jan 09, 2018 at 06:31:45AM +0900, Charles Plessy a écrit :
> Le Mon, Jan 08, 2018 at 03:19:27PM +0100, Andreas Tille a écrit :
> > 
> > Sleep well.  Would you consider moving also the R packages of Debian Med
> > project (remaining on Alioth currently) as well in the next couple of
> > days?
> 
> Just started !

Should be done soon (the group sharing is still running - slowly).

Here is what I have done.

# Block update of the old repositories (on Alioth in /git/debian-med)
for pack in $(ls -d r-*)
do
cat << __HOOK__ > $pack/hooks/pre-receive
#!/bin/sh

cat > r-pkg-team.conf ; done
# See https://salsa.debian.org/salsa/AliothRewriter/merge_requests/43

Have a nice day,

Charles

-- 
Charles Plessy
Debian Med packaging team,
http://www.debian.org/devel/debian-med
Tsurumi, Kanagawa, Japan

Re: A common group on salsa.debian.org for R packages ?

[Dylan Aïssi]

Hi,
I just transferred the dh-r package from debian-science to r-pkg-team [1-2].
But I don't have right to remove the repository at debian-science. Can
someone do it for me?


Best,
Dylan

[1] https://salsa.debian.org/r-pkg-team/dh-r
[2] https://salsa.debian.org/salsa/AliothRewriter/merge_requests/41



2018-01-08 22:31 GMT+01:00 Charles Plessy :
> Le Mon, Jan 08, 2018 at 03:19:27PM +0100, Andreas Tille a écrit :
>>
>> Sleep well.  Would you consider moving also the R packages of Debian Med
>> project (remaining on Alioth currently) as well in the next couple of
>> days?
>
> Just started !
>
> Charles
>
> --
> Charles Plessy
> Debian Med packaging team,
> http://www.debian.org/devel/debian-med
> Tsurumi, Kanagawa, Japan
>

Re: A common group on salsa.debian.org for R packages ?

[Charles Plessy]

Le Mon, Jan 08, 2018 at 03:19:27PM +0100, Andreas Tille a écrit :
> 
> Sleep well.  Would you consider moving also the R packages of Debian Med
> project (remaining on Alioth currently) as well in the next couple of
> days?

Just started !

Charles

-- 
Charles Plessy
Debian Med packaging team,
http://www.debian.org/devel/debian-med
Tsurumi, Kanagawa, Japan

Re: A common group on salsa.debian.org for R packages ?

[Andreas Tille]

On Mon, Jan 08, 2018 at 10:42:39PM +0900, Charles Plessy wrote:
> > 
> >  
> > https://salsa.debian.org/salsa/AliothRewriter/blob/master/definitions/debian-science.conf
> 
> Thanks, I think that I am done now.  After deriving a list of packages
> from the current ones listed in the Alioth redirector, I have:
> 
>  - Imported the projects from the science-team group, using Mehdi's
>helper scripts.
> 
> for pack in $(cat /home/charles/rpacks) ; do ./import.sh 
> https://salsa.debian.org/science-team/$pack r-pkg-team ;done
> 
>  - Deleted the originals.
> 
> for pack in $(cat /home/charles/rpacks) ; do curl -X DELETE --header 
> "Private-Token: $(cat ~/gitlabtoken.txt)" 
> https://salsa.debian.org/api/v4/projects/science-team%2F$pack ;done
> 
>   - Notified the redirector admins, who merged the pull request within 2
> minutes
> 
> https://salsa.debian.org/salsa/AliothRewriter/merge_requests/36
> 
>  - Set commit emails
> 
> for pack in $(cat /home/charles/rpacks) ; do ./emails_on_push.sh $pack ;done
> 
>  - Given Developer access to all members of the Debian and science-team groups
>(technically, this is still running).
> 
> for gid in 2 2136 ; do for pack in $(cat /home/charles/rpacks) ; do curl -X 
> POST --header "Private-Token: $(cat ~/gitlabtoken.txt)" 
> "https://salsa.debian.org/api/v4/projects/r-pkg-team%2F$pack/share?group_id=$gid_access=30;
>  ; done ; done

Sounds good.
 
 
> And now, I am going to bed :)

Sleep well.  Would you consider moving also the R packages of Debian Med
project (remaining on Alioth currently) as well in the next couple of
days?

Thanks for your work

 Andreas.

-- 
http://fam-tille.de

Re: A common group on salsa.debian.org for R packages ?

[Charles Plessy]

> On Sun, Jan 07, 2018 at 09:50:23PM +0900, Charles Plessy wrote:
> 
> > Next, I would like to transfer the R packages that are in the
> > `science-team`.  But at the moment I do not have enough privileges.
> > Can someboody boost my status ?  It can be just temporary of course.

Le Sun, Jan 07, 2018 at 02:35:37PM +0100, Anton Gladky a écrit :
> 
> I think you have now enough rights to move the projects.

Le Sun, Jan 07, 2018 at 05:26:34PM +0100, Sébastien Villemot a écrit :
> 
> Once you have done that, please do not forget to update the alioth rewrite map
> with the new location for R packages:
> 
>  
> https://salsa.debian.org/salsa/AliothRewriter/blob/master/definitions/debian-science.conf

Thanks, I think that I am done now.  After deriving a list of packages
from the current ones listed in the Alioth redirector, I have:

 - Imported the projects from the science-team group, using Mehdi's
   helper scripts.

for pack in $(cat /home/charles/rpacks) ; do ./import.sh 
https://salsa.debian.org/science-team/$pack r-pkg-team ;done

 - Deleted the originals.

for pack in $(cat /home/charles/rpacks) ; do curl -X DELETE --header 
"Private-Token: $(cat ~/gitlabtoken.txt)" 
https://salsa.debian.org/api/v4/projects/science-team%2F$pack ;done

  - Notified the redirector admins, who merged the pull request within 2
minutes

https://salsa.debian.org/salsa/AliothRewriter/merge_requests/36

 - Set commit emails

for pack in $(cat /home/charles/rpacks) ; do ./emails_on_push.sh $pack ;done

 - Given Developer access to all members of the Debian and science-team groups
   (technically, this is still running).

for gid in 2 2136 ; do for pack in $(cat /home/charles/rpacks) ; do curl -X 
POST --header "Private-Token: $(cat ~/gitlabtoken.txt)" 
"https://salsa.debian.org/api/v4/projects/r-pkg-team%2F$pack/share?group_id=$gid_access=30;
 ; done ; done

I have also renamed the r-base project "r-base-backports" and set its
default branch to debian/jessie-backports, and deleted the
r-base.deletemeIn2017 repository.

And now, I am going to bed :)

Have a nice day,

Charles

-- 
Charles Plessy
Debian Med packaging team,
http://www.debian.org/devel/debian-med
Tsurumi, Kanagawa, Japan

Re: A common group on salsa.debian.org for R packages ?

[Sébastien Villemot]

On Sun, Jan 07, 2018 at 09:50:23PM +0900, Charles Plessy wrote:

> Next, I would like to transfer the R packages that are in the
> `science-team`.  But at the moment I do not have enough privileges.
> Can someboody boost my status ?  It can be just temporary of course.

Once you have done that, please do not forget to update the alioth rewrite map
with the new location for R packages:

 
https://salsa.debian.org/salsa/AliothRewriter/blob/master/definitions/debian-science.conf

Thanks,

-- 
⢀⣴⠾⠻⢶⣦⠀  Sébastien Villemot
⣾⠁⢠⠒⠀⣿⡁  Debian Developer
⢿⡄⠘⠷⠚⠋⠀  http://sebastien.villemot.name
⠈⠳⣄  http://www.debian.org


signature.asc
Description: PGP signature

Re: A common group on salsa.debian.org for R packages ?

[Anton Gladky]

Hi Charles,

I think you have now enough rights to move the projects.

Best regards

Anton


2018-01-07 13:50 GMT+01:00 Charles Plessy :
> Next, I would like to transfer the R packages that are in the
> `science-team`.  But at the moment I do not have enough privileges.
> Can someboody boost my status ?  It can be just temporary of course.

Re: A common group on salsa.debian.org for R packages ?

[Charles Plessy]

> On Sun, Jan 07, 2018 at 09:04:06AM +0900, Charles Plessy wrote:
> > 
> > I will create a team on GitLab.  How about "r-packages-team" ?

Le Sun, Jan 07, 2018 at 07:52:14AM +0100, Andreas Tille a écrit :
> 
> I consider r-pkg-team a more typical name.

Thanks for the suggestion.  I have just created the `r-pkg-team` group
("Debian R Packages Maintainers") on Salsa.

https://salsa.debian.org/groups/r-pkg-team/

For each package in the `r-pkg-team`, I propose to give Developer access
to all the members of the groups Debian, science-team and the future
Debian med team (no name chosen yet).

It can be done programatically as follows.

curl -X POST --header "Private-Token: $(cat gitlabtoken.txt)" 
'https://salsa.debian.org/api/v4/projects/$project_ID/share?group_id=$group_id_access=$access_level'

(See https://docs.gitlab.com/ce/api/projects.html#share-project-with-group
 and https://salsa.debian.org/help/user/permissions )

It is not possible to make a group member of a group.

Thus, people would only need to ask for membership if they want to
create a new project (needs Master level), or if they have a guest
account and are not member of the Science or Med team (that would be
Developer level).

Next, I would like to transfer the R packages that are in the
`science-team`.  But at the moment I do not have enough privileges.
Can someboody boost my status ?  It can be just temporary of course.

Cheers,

Charles

-- 
Charles Plessy
Debian Med packaging team,
http://www.debian.org/devel/debian-med
Tsurumi, Kanagawa, Japan

Re: A common group on salsa.debian.org for R packages ?

[Andreas Tille]

On Sun, Jan 07, 2018 at 09:04:06AM +0900, Charles Plessy wrote:
> > > repository.  In GitLab, it is possible to give access to a repository to
> > > all the members of a group, therefore a "r-pkg-team" group could host
> > > the repositories, which would be shared with the "Debian",
> > > "science-team" and "med-team" groups.
> 
> > 
> > Very sensible and the idea was previously discussed in IRC.
> 
> I will create a team on GitLab.  How about "r-packages-team" ?

I consider r-pkg-team a more typical name.

> Hopefully, the use of plural clarifies that the team is not about
> the r-base package.  Also, each team has a description and I will
> mention there that r-base is out of scope.  (Although there may
> eventually be a r-base-backports repository there).

I see no reason to express in the name that r-base is not (yet)
maintained by this team.  This can be expressed by the description. 
A name is just a name and the description can be expressed what
is currently done by the team.

Kind regards

Andreas.

-- 
http://fam-tille.de

Re: A common group on salsa.debian.org for R packages ?

[Charles Plessy]

> On Thu, Jan 04, 2018 at 11:14:14PM +0900, Charles Plessy wrote:
> > with the mass migration to GitLab on salsa.debian.org, I wonder if it
> > would be a good opportunity to host under the same umbrella all the
> > r-cran/bioc/other source packages that are maintained in a Git
> > repository.  In GitLab, it is possible to give access to a repository to
> > all the members of a group, therefore a "r-pkg-team" group could host
> > the repositories, which would be shared with the "Debian",
> > "science-team" and "med-team" groups.
> > 
> > Hopefully it would make them more visible and might help to attract
> > contributions for package updates.  What do you think about this ?

Le Thu, Jan 04, 2018 at 03:20:32PM +0100, Andreas Tille a écrit :
> 
> Very sensible and the idea was previously discussed in IRC.

Le Thu, Jan 04, 2018 at 04:48:04PM +0100, Sébastien Villemot a écrit :
> 
> I fully support the idea (but I don't expect to have time to work on it before
> alioth is shutdown).

Thanks for your support !

I will create a team on GitLab.  How about "r-packages-team" ?
Hopefully, the use of plural clarifies that the team is not about
the r-base package.  Also, each team has a description and I will
mention there that r-base is out of scope.  (Although there may
eventually be a r-base-backports repository there).

Have a nice Sunday,

-- 
Charles

Re: A common group on salsa.debian.org for R packages ?

[Sébastien Villemot]

On Thu, Jan 04, 2018 at 11:14:14PM +0900, Charles Plessy wrote:

> with the mass migration to GitLab on salsa.debian.org, I wonder if it
> would be a good opportunity to host under the same umbrella all the
> r-cran/bioc/other source packages that are maintained in a Git
> repository.  In GitLab, it is possible to give access to a repository to
> all the members of a group, therefore a "r-pkg-team" group could host
> the repositories, which would be shared with the "Debian",
> "science-team" and "med-team" groups.
> 
> Hopefully it would make them more visible and might help to attract
> contributions for package updates.  What do you think about this ?

I fully support the idea (but I don't expect to have time to work on it before
alioth is shutdown).

Best,

-- 
⢀⣴⠾⠻⢶⣦⠀  Sébastien Villemot
⣾⠁⢠⠒⠀⣿⡁  Debian Developer
⢿⡄⠘⠷⠚⠋⠀  http://sebastien.villemot.name
⠈⠳⣄  http://www.debian.org


signature.asc
Description: PGP signature

Re: A common group on salsa.debian.org for R packages ?

[Andreas Tille]

Hi Charles,

On Thu, Jan 04, 2018 at 11:14:14PM +0900, Charles Plessy wrote:
> with the mass migration to GitLab on salsa.debian.org, I wonder if it
> would be a good opportunity to host under the same umbrella all the
> r-cran/bioc/other source packages that are maintained in a Git
> repository.  In GitLab, it is possible to give access to a repository to
> all the members of a group, therefore a "r-pkg-team" group could host
> the repositories, which would be shared with the "Debian",
> "science-team" and "med-team" groups.
> 
> Hopefully it would make them more visible and might help to attract
> contributions for package updates.  What do you think about this ?

Very sensible and the idea was previously discussed in IRC.

If we agree upon this we should move those R packages before some
automatic migration step.  Anybody who wants to do the work has my full
support. 

Kind regards

   Andreas.

-- 
http://fam-tille.de

A common group on salsa.debian.org for R packages ?

[Charles Plessy]

Hello everybody,

with the mass migration to GitLab on salsa.debian.org, I wonder if it
would be a good opportunity to host under the same umbrella all the
r-cran/bioc/other source packages that are maintained in a Git
repository.  In GitLab, it is possible to give access to a repository to
all the members of a group, therefore a "r-pkg-team" group could host
the repositories, which would be shared with the "Debian",
"science-team" and "med-team" groups.

Hopefully it would make them more visible and might help to attract
contributions for package updates.  What do you think about this ?

Charles

-- 
Charles Plessy
Debian Med packaging team,
http://www.debian.org/devel/debian-med
Tsurumi, Kanagawa, Japan