Re: BART 0.8.0

2022-10-07 Thread Andreas Tille
Hi Martin,

Am Sat, Oct 01, 2022 at 02:45:21PM +0200 schrieb Martin Uecker:
> I updated the Debian packages for BART (bart and bart-cuda) 
> to our new upstream version. 

Thanks a lot for preparing these packages which I just uploaded.
 
> This time I also managed to run the CI on salsa for bart-cuda
> There are still some failures, but it seems ok to me.

I admit in my local pbuilder I also observed issues but it seems
to be OK in Salsa CI.

> Please upload if it looks ok to you.

Is there any reason to stick to gcc-10.  I'm not sure when this
GCC version will be removed - but sooner or later this will be
the case. 

Kind regards and thanks again for your contribution

Andreas.

-- 
http://fam-tille.de



Re: BART 0.8.0

2022-10-07 Thread Nilesh Patra
On Fri, Oct 07, 2022 at 03:18:36PM +0200, Andreas Tille wrote:
> > Please upload if it looks ok to you.
> 
> Is there any reason to stick to gcc-10.  I'm not sure when this
> GCC version will be removed - but sooner or later this will be
> the case. 

Becasue nvcc (This is a non-free compiler by nvidia) which bart-cuda
uses does not support gcc-12 yet, as Andreas Beckmann pointed out here[1]

But according to him, B-D on g++-11 could also work.

[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1016625#65

Cheers,

-- 
Best,
Nilesh


signature.asc
Description: PGP signature


Re: BART 0.8.0

2022-10-08 Thread Martin Uecker


Hi Andreas,

Am Freitag, den 07.10.2022, 15:18 +0200 schrieb Andreas Tille:
> Hi Martin,
> 
> Am Sat, Oct 01, 2022 at 02:45:21PM +0200 schrieb Martin Uecker:
> > I updated the Debian packages for BART (bart and bart-cuda) 
> > to our new upstream version. 
> 
> Thanks a lot for preparing these packages which I just uploaded.

Thank you! I assume the bart package is still being processed?

> > This time I also managed to run the CI on salsa for bart-cuda
> > There are still some failures, but it seems ok to me.
> 
> I admit in my local pbuilder I also observed issues but it seems
> to be OK in Salsa CI.
> 
> > Please upload if it looks ok to you.
> 
> Is there any reason to stick to gcc-10.  I'm not sure when this
> GCC version will be removed - but sooner or later this will be
> the case. 

This was caused by nvcc not being compatible with newer
version of GCC, but it seems a new version of
nvidia-cuda-toolkit is now in sid, so we could try
updating the build dependencies:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1016625#65

I will do this soon, but probably wait in case other issues
emerge with the new packages.

Martin


> Kind regards and thanks again for your contribution
> 
> Andreas.
> 



Re: BART 0.8.0

2022-10-08 Thread Andreas Tille
Am Sat, Oct 08, 2022 at 03:41:49PM +0200 schrieb Martin Uecker:
> > Thanks a lot for preparing these packages which I just uploaded.
> 
> Thank you! I assume the bart package is still being processed?

H, I need to check my upload - thanks for mentioning it.
Bart-cuda arrived in unstable but bart is pending.  I'll check later.
 
> I will do this soon, but probably wait in case other issues
> emerge with the new packages.

Sounds reasonable. 

Kind regards

 Andreas.

-- 
http://fam-tille.de



Re: BART 0.8.0

2022-10-08 Thread Andreas Tille
Hi Martin,

Am Sat, Oct 08, 2022 at 05:45:43PM +0200 schrieb Andreas Tille:
> 
> H, I need to check my upload - thanks for mentioning it.
> Bart-cuda arrived in unstable but bart is pending.  I'll check later.

I've done so yesterday.
  
> > I will do this soon, but probably wait in case other issues
> > emerge with the new packages.
 
Seems there are build issues on some architectures:

   https://buildd.debian.org/status/package.php?p=bart

Could you have a look?

Kind regards

 Andreas. 

-- 
http://fam-tille.de



Re: BART 0.8.0

2022-10-09 Thread Martin Uecker


Hi Andreas,

Am Sonntag, den 09.10.2022, 06:39 +0200 schrieb Andreas Tille:
> Hi Martin,
> 
> Am Sat, Oct 08, 2022 at 05:45:43PM +0200 schrieb Andreas Tille:
> > H, I need to check my upload - thanks for mentioning it.
> > Bart-cuda arrived in unstable but bart is pending.  I'll check later.
> 
> I've done so yesterday.

Thanks!

> > > I will do this soon, but probably wait in case other issues
> > > emerge with the new packages.
>  
> Seems there are build issues on some architectures:
> 
>https://buildd.debian.org/status/package.php?p=bart
> 
> Could you have a look?

Yes, the issue is numerical unit tests failing on
some archs. This not entirely surprising as we had this
before, and we added *many* new tests in this version. 

I will see that it get it running on some ARM64 myself
and then push some fixes.

Martin





Re: BART 0.8.0

2022-10-13 Thread Martin Uecker


Hi Andreas,

Am Sonntag, den 09.10.2022, 09:39 +0200 schrieb Martin Uecker:
> Hi Andreas,
> 
> Am Sonntag, den 09.10.2022, 06:39 +0200 schrieb Andreas Tille:
> 


> > > > I will do this soon, but probably wait in case other issues
> > > > emerge with the new packages.
> >  
> > Seems there are build issues on some architectures:
> > 
> >https://buildd.debian.org/status/package.php?p=bart
> > 
> > Could you have a look?
> 
> Yes, the issue is numerical unit tests failing on
> some archs. This not entirely surprising as we had this
> before, and we added *many* new tests in this version. 
> 
> I will see that it get it running on some ARM64 myself
> and then push some fixes.

Ok, I pushed some changes which should address this.
There was some issue affecting 32bit archs
and also some other issue we could reproduce
on ARM64. This is still under investigation but
turning off some optimizations seems to fix it
for now.

There also is the issue that some autopkgtests
were sometimes failing. I tried to address this
too.

For bart-cuda I also changed the build dependency
to g++-11 and maybe this works now with the new
nvidia-toolkit 

So please upload bart and bart-cuda. Thank you!

Martin








Re: BART 0.8.0

2022-10-14 Thread Andreas Tille
Hi Martin,

Am Thu, Oct 13, 2022 at 09:41:19PM +0200 schrieb Martin Uecker:
> > Yes, the issue is numerical unit tests failing on
> > some archs. This not entirely surprising as we had this
> > before, and we added *many* new tests in this version. 
> > 
> > I will see that it get it running on some ARM64 myself
> > and then push some fixes.
> 
> Ok, I pushed some changes which should address this.
> There was some issue affecting 32bit archs
> and also some other issue we could reproduce
> on ARM64. This is still under investigation but
> turning off some optimizations seems to fix it
> for now.
> 
> There also is the issue that some autopkgtests
> were sometimes failing. I tried to address this
> too.

I've uploaded bart.  Thanks a lot for working on this.
 
> For bart-cuda I also changed the build dependency
> to g++-11 and maybe this works now with the new
> nvidia-toolkit 
> 
> So please upload bart and bart-cuda. Thank you!

I've not yet uploaded bart-cuda.  I think it makes sense to wait until
all autobuilders have passed bart.  Please ping me in case I might
forget. 

Kind regards

 Andreas.

-- 
http://fam-tille.de



Re: BART 0.8.0

2022-10-14 Thread Andreas Tille
Hi again,

the build fails on i386[1].  Any idea what might went wrong?

Please note: I'm not able to sponsor bart in the next week
but I guess someone else will step in.

Kind regards

  Andreas.


[1] 
https://buildd.debian.org/status/fetch.php?pkg=bart&arch=i386&ver=0.8.00-2&stamp=1665741010&raw=0

Am Fri, Oct 14, 2022 at 08:53:00AM +0200 schrieb Andreas Tille:
> Hi Martin,
> 
> Am Thu, Oct 13, 2022 at 09:41:19PM +0200 schrieb Martin Uecker:
> > > Yes, the issue is numerical unit tests failing on
> > > some archs. This not entirely surprising as we had this
> > > before, and we added *many* new tests in this version. 
> > > 
> > > I will see that it get it running on some ARM64 myself
> > > and then push some fixes.
> > 
> > Ok, I pushed some changes which should address this.
> > There was some issue affecting 32bit archs
> > and also some other issue we could reproduce
> > on ARM64. This is still under investigation but
> > turning off some optimizations seems to fix it
> > for now.
> > 
> > There also is the issue that some autopkgtests
> > were sometimes failing. I tried to address this
> > too.
> 
> I've uploaded bart.  Thanks a lot for working on this.
>  
> > For bart-cuda I also changed the build dependency
> > to g++-11 and maybe this works now with the new
> > nvidia-toolkit 
> > 
> > So please upload bart and bart-cuda. Thank you!
> 
> I've not yet uploaded bart-cuda.  I think it makes sense to wait until
> all autobuilders have passed bart.  Please ping me in case I might
> forget. 
> 
> Kind regards
> 
>  Andreas.
> 
> -- 
> http://fam-tille.de
> 
> 

-- 
http://fam-tille.de



Re: BART 0.8.0

2022-10-14 Thread Martin Uecker
Am Freitag, den 14.10.2022, 17:39 +0200 schrieb Andreas Tille:
> Hi again,
> 
> the build fails on i386[1].  Any idea what might went wrong?

One test goes into an infinite loop, but only on i386...
Everything else seems fine now (except an old alpha issue).

I will look into this.

Martin

> Please note: I'm not able to sponsor bart in the next week
> but I guess someone else will step in.
> 
> Kind regards
> 
>   Andreas.
> 
> 
> [1] 
> https://buildd.debian.org/status/fetch.php?pkg=bart&arch=i386&ver=0.8.00-2&stamp=1665741010&raw=0
> 
> Am Fri, Oct 14, 2022 at 08:53:00AM +0200 schrieb Andreas Tille:
> > Hi Martin,
> > 
> > Am Thu, Oct 13, 2022 at 09:41:19PM +0200 schrieb Martin Uecker:
> > > > Yes, the issue is numerical unit tests failing on
> > > > some archs. This not entirely surprising as we had this
> > > > before, and we added *many* new tests in this version. 
> > > > 
> > > > I will see that it get it running on some ARM64 myself
> > > > and then push some fixes.
> > > 
> > > Ok, I pushed some changes which should address this.
> > > There was some issue affecting 32bit archs
> > > and also some other issue we could reproduce
> > > on ARM64. This is still under investigation but
> > > turning off some optimizations seems to fix it
> > > for now.
> > > 
> > > There also is the issue that some autopkgtests
> > > were sometimes failing. I tried to address this
> > > too.
> > 
> > I've uploaded bart.  Thanks a lot for working on this.
> >  
> > > For bart-cuda I also changed the build dependency
> > > to g++-11 and maybe this works now with the new
> > > nvidia-toolkit 
> > > 
> > > So please upload bart and bart-cuda. Thank you!
> > 
> > I've not yet uploaded bart-cuda.  I think it makes sense to wait until
> > all autobuilders have passed bart.  Please ping me in case I might
> > forget. 
> > 
> > Kind regards
> > 
> >  Andreas.
> > 
> > -- 
> > http://fam-tille.de
> > 
> > 



Re: BART 0.8.0

2022-10-24 Thread Martin Uecker


Hi Andreas and all,

I updated the package and turned off some unit tests on
i386 for now (and turned on other tests and made some
other changes).

If you or somebody else could sponser an upload, this
would be great!

Then I also need to update bart-view...

Martin



Am Freitag, den 14.10.2022, 17:39 +0200 schrieb Andreas Tille:
> Hi again,
> 
> the build fails on i386[1].  Any idea what might went wrong?
> 
> Please note: I'm not able to sponsor bart in the next week
> but I guess someone else will step in.
> 
> Kind regards
> 
>   Andreas.
> 
> 
> [1] 
> https://buildd.debian.org/status/fetch.php?pkg=bart&arch=i386&ver=0.8.00-2&stamp=1665741010&raw=0
> 
> Am Fri, Oct 14, 2022 at 08:53:00AM +0200 schrieb Andreas Tille:
> > Hi Martin,
> > 
> > Am Thu, Oct 13, 2022 at 09:41:19PM +0200 schrieb Martin Uecker:
> > > > Yes, the issue is numerical unit tests failing on
> > > > some archs. This not entirely surprising as we had this
> > > > before, and we added *many* new tests in this version. 
> > > > 
> > > > I will see that it get it running on some ARM64 myself
> > > > and then push some fixes.
> > > 
> > > Ok, I pushed some changes which should address this.
> > > There was some issue affecting 32bit archs
> > > and also some other issue we could reproduce
> > > on ARM64. This is still under investigation but
> > > turning off some optimizations seems to fix it
> > > for now.
> > > 
> > > There also is the issue that some autopkgtests
> > > were sometimes failing. I tried to address this
> > > too.
> > 
> > I've uploaded bart.  Thanks a lot for working on this.
> >  
> > > For bart-cuda I also changed the build dependency
> > > to g++-11 and maybe this works now with the new
> > > nvidia-toolkit 
> > > 
> > > So please upload bart and bart-cuda. Thank you!
> > 
> > I've not yet uploaded bart-cuda.  I think it makes sense to wait until
> > all autobuilders have passed bart.  Please ping me in case I might
> > forget. 
> > 
> > Kind regards
> > 
> >  Andreas.
> > 
> > -- 
> > http://fam-tille.de
> > 
> > 



Re: BART 0.8.0

2022-10-24 Thread Nilesh Patra
Hello,

On Mon, Oct 24, 2022 at 08:39:33PM +0200, Martin Uecker wrote:
> 
> Hi Andreas and all,
> 
> I updated the package and turned off some unit tests on
> i386 for now (and turned on other tests and made some
> other changes).
> 
> If you or somebody else could sponser an upload, this
> would be great!

Sorry for being lazy and not checking this for myself here, but does your
update also fix the recent release-critical bug against bart-view?

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1022324

If so, please close this in changelog.

Also, salsa CI is failing the build pipeline,

https://salsa.debian.org/med-team/bart-view/-/jobs/3422195

this is not expected right?

Lastly, please consider to add in your new commit e-mail to your salsa profile 
so it
is easy to associate your account w/ your commits.

Thank you,

-- 
Best,
Nilesh


signature.asc
Description: PGP signature


Re: BART 0.8.0

2022-10-24 Thread Martin Uecker
Am Dienstag, den 25.10.2022, 00:41 +0530 schrieb Nilesh Patra:
> Hello,
> 
> On Mon, Oct 24, 2022 at 08:39:33PM +0200, Martin Uecker wrote:
> > Hi Andreas and all,
> > 
> > I updated the package and turned off some unit tests on
> > i386 for now (and turned on other tests and made some
> > other changes).
> > 
> > If you or somebody else could sponser an upload, this
> > would be great!
> 
> Sorry for being lazy and not checking this for myself here, but does your
> update also fix the recent release-critical bug against bart-view?
> 
>   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1022324
> 
> If so, please close this in changelog.

No, this will additionally also require also 
an update of bart-view.

> Also, salsa CI is failing the build pipeline,
> 
>   https://salsa.debian.org/med-team/bart-view/-/jobs/3422195
> 
> this is not expected right?

I am still working on the update of bart-view.
But bart has to be updated first anyway.

> Lastly, please consider to add in your new commit e-mail to your salsa 
> profile so it
> is easy to associate your account w/ your commits.

I will update it.

Best,
Martin






Re: BART 0.8.0

2022-10-24 Thread Nilesh Patra
On Mon, Oct 24, 2022 at 09:20:21PM +0200, Martin Uecker wrote:
> Am Dienstag, den 25.10.2022, 00:41 +0530 schrieb Nilesh Patra:
> > Hello,
> > 
> > On Mon, Oct 24, 2022 at 08:39:33PM +0200, Martin Uecker wrote:
> > > Hi Andreas and all,
> > > 
> > > I updated the package and turned off some unit tests on
> > > i386 for now (and turned on other tests and made some
> > > other changes).
> > > 
> > > If you or somebody else could sponser an upload, this
> > > would be great!
> > 
> > Sorry for being lazy and not checking this for myself here, but does your
> > update also fix the recent release-critical bug against bart-view?
> > 
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1022324
> > 
> > If so, please close this in changelog.
> 
> No, this will additionally also require also 
> an update of bart-view.

By "update" I meant bart-view update there.

> > Also, salsa CI is failing the build pipeline,
> > 
> > https://salsa.debian.org/med-team/bart-view/-/jobs/3422195
> > 
> > this is not expected right?
> 
> I am still working on the update of bart-view.
> But bart has to be updated first anyway.

I saw your commits and was somehow under the impression that you updated 
bart-view, -cuda and bart
since you usually do this at once :)

I have uploaded bart with your changes.

Thanks!

-- 
Best,
Nilesh


signature.asc
Description: PGP signature


Re: BART 0.8.0

2022-10-26 Thread Martin Uecker
Am Dienstag, den 25.10.2022, 01:12 +0530 schrieb Nilesh Patra:
> On Mon, Oct 24, 2022 at 09:20:21PM +0200, Martin Uecker wrote:
> > Am Dienstag, den 25.10.2022, 00:41 +0530 schrieb Nilesh Patra:


Hi Nilesh,

> > > Also, salsa CI is failing the build pipeline,
> > > 
> > >   https://salsa.debian.org/med-team/bart-view/-/jobs/3422195
> > > 
> > > this is not expected right?
> > 
> > I am still working on the update of bart-view.
> > But bart has to be updated first anyway.
> 
> I saw your commits and was somehow under the impression that you updated 
> bart-view, -cuda and bart
> since you usually do this at once :)
> 
> I have uploaded bart with your changes.

Thank you! It seems this is working correctly
on all archs.

I also finalized the bart-view update. Can
you upload it as well?

Martin



Re: BART 0.8.0

2022-10-26 Thread Nilesh Patra
On Wed, Oct 26, 2022 at 11:56:28AM +0200, Martin Uecker wrote:
> Thank you! It seems this is working correctly
> on all archs.
> 
> I also finalized the bart-view update. Can
> you upload it as well?

I had done so, thanks!

-- 
Best,
Nilesh


signature.asc
Description: PGP signature


Re: BART 0.8.0

2022-11-01 Thread Martin Uecker
Am Donnerstag, den 27.10.2022, 07:26 +0530 schrieb Nilesh Patra:
> On Wed, Oct 26, 2022 at 11:56:28AM +0200, Martin Uecker wrote:
> > Thank you! It seems this is working correctly
> > on all archs.
> > 
> > I also finalized the bart-view update. Can
> > you upload it as well?
> 
> I had done so, thanks!

Thank you Nilesh and Andreas! 

bart, bart-cuda, and bart-view all entered testing.


Martin