Re: Packaging InVesalius
Hi Thiago, On Thu, Feb 14, 2013 at 04:27:26PM -0200, Thiago Franco Moraes wrote: > I understand. Maybe it's better to wait to the next version. I think > the next is close to be released. Sounds reasonable specifically because it seems that ftpnew is currently not processed - so waiting on our side a bit is finally no harm at all. > Thanks for the bug report. The -Q is a great idea, I like a lot > when I can use C-q to close an application. :-) Kind regards Andreas. -- http://fam-tille.de -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130214201134.gc23...@an3as.eu
Re: Packaging InVesalius
Hi Andreas, On Fri, Feb 8, 2013 at 5:35 AM, Andreas Tille wrote: > Hi Thiago, > > On Thu, Feb 07, 2013 at 01:25:01PM -0200, Thiago Franco Moraes wrote: >> I created a branch (beta3) where I'm committing and cherry-picking >> some fixes to beta3. After these commits I update the the tag v3.0-b3. >> I don't know if its the better thing to do. To get the last version >> you need to re-download the tarball. > > Hmmm, while this actually helped to solve the issues I reported in my > previous mail we should find some way to make sure that the content of a > file with the same name will not change over time. This would > specifically very important if we decide to upload the package to > Debian. It would be really bad if we ship some orig.tar.gz in Debian > that might be different from the downloadable file. > > I'd suggest to either increase the beta version number on new tarballs > or you either add a date string like mmdd or alternatively some > revision number from VCS to the version string. I understand. Maybe it's better to wait to the next version. I think the next is close to be released. >> It was fixed. You need to re-download to get the fixed one. > > Done and confirm that this is fixed. I also added a slight change to > the packaging to prevent that .inv3 files will be compressed (to enable > simply loading the examples. > > I found some further runtime problem: I tried File -> Exit but > invesalius remained (this happens with or without the inv3 example > opened, if the example was opened only the images are vanishing.) I > needed to press ^C in the xterm from were I started invesalius to stop > the program. As a cosmetic suggestion: I really like some -Q > keybinding to exit a program - it is boring to be forced to use the > mouse to quit a program. Thanks for the bug report. The -Q is a great idea, I like a lot when I can use C-q to close an application. > Kind regards > > Andreas. > > -- > http://fam-tille.de > Thanks! -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAMmoLX_gQP=p9YutxiO_SWAgnzwRG=Q6PnR3F3+bK7N0d==t...@mail.gmail.com
Re: Packaging InVesalius
Hi Thiago, On Thu, Feb 07, 2013 at 01:25:01PM -0200, Thiago Franco Moraes wrote: > I created a branch (beta3) where I'm committing and cherry-picking > some fixes to beta3. After these commits I update the the tag v3.0-b3. > I don't know if its the better thing to do. To get the last version > you need to re-download the tarball. Hmmm, while this actually helped to solve the issues I reported in my previous mail we should find some way to make sure that the content of a file with the same name will not change over time. This would specifically very important if we decide to upload the package to Debian. It would be really bad if we ship some orig.tar.gz in Debian that might be different from the downloadable file. I'd suggest to either increase the beta version number on new tarballs or you either add a date string like mmdd or alternatively some revision number from VCS to the version string. > It was fixed. You need to re-download to get the fixed one. Done and confirm that this is fixed. I also added a slight change to the packaging to prevent that .inv3 files will be compressed (to enable simply loading the examples. I found some further runtime problem: I tried File -> Exit but invesalius remained (this happens with or without the inv3 example opened, if the example was opened only the images are vanishing.) I needed to press ^C in the xterm from were I started invesalius to stop the program. As a cosmetic suggestion: I really like some -Q keybinding to exit a program - it is boring to be forced to use the mouse to quit a program. Kind regards Andreas. -- http://fam-tille.de -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130208073545.ga31...@an3as.eu
Re: Packaging InVesalius
On Thu, Feb 7, 2013 at 11:08 AM, Andreas Tille wrote:
> On Thu, Feb 07, 2013 at 10:48:05AM -0200, Thiago Franco Moraes wrote:
>> sample/sample2.inv3 was created using an old InVesalius version. The
>> new InVesalius is not able to open, so this file is useless. It just
>> happened that nobody removed that file (I removed it these days).
>
> Debian is good in QA also for upstream. ;-)
Very true. :-)
> I guess it might be reasonable to wait for a new upstream tarball before
> uploading to the Debian mirror to avoid distributing ftpmirrors with
> unneeded bytes of some noticeable amount. What do you think?
I created a branch (beta3) where I'm committing and cherry-picking
some fixes to beta3. After these commits I update the the tag v3.0-b3.
I don't know if its the better thing to do. To get the last version
you need to re-download the tarball.
>> > How did you realise this?
>>
>> Ah, sorry. It was my mistake. I was using "fakeroot debian/rules
>> binary" to create the package, this command doesn't apply the patch.
>> If I use debuild it applies the patch.
>
> I always use debuild (or rather pdebuild.)
Good to know about pdebuild. Thanks!
>> > but this is definitely cosmetics and does not have a real influenze.
>> > Apropos cosmetics on patches: It would be nice if you could add some
>> > Description fields as described in DEP3[1] to let others understand
>> > the rationale of the patch (and who wrote it when).
>>
>> Done! I have not filled all fields.
>
> Fine!
>
>> > File "/usr/share/invesalius-3.0/invesalius/session.py", line 269, in run
>> > debug("Session: trying to write into inexistent file")
>> > File "/usr/share/invesalius-3.0/invesalius/utils.py", line 74, in debug
>> > if session.debug:
>> > AttributeError: 'Session' object has no attribute 'debug'
>>
>> Fixed. It was missing python-gdcm and python-vtkgdcm as invesalius
>> dependency.
>
> Probably. Unfortunately I found another issue (wonder why this did not
> happened yesterday, hmmm):
>
> $ LC_ALL=C sudo dpkg -i invesalius_3.0~b3-1_all.deb
> (Reading database ... 313204 files and directories currently installed.)
> Preparing to replace invesalius 3.0~b3-1 (using invesalius_3.0~b3-1_all.deb)
> ...
> Unpacking replacement invesalius ...
> Setting up invesalius (3.0~b3-1) ...
> Sorry: IndentationError: ('expected an indented block',
> ('/usr/share/invesalius/invesalius/data/styles.py', 128, 7, 'def
> OnLeftButtonDown(self, evt, str_evt):\n'))
> dpkg: error processing invesalius (--install):
> subprocess installed post-installation script returned error exit status 101
> Processing triggers for gnome-menus ...
> Processing triggers for desktop-file-utils ...
> Processing triggers for man-db ...
> Processing triggers for menu ...
> Errors were encountered while processing:
> invesalius
It was fixed. You need to re-download to get the fixed one.
> Kind regards
>
> Andreas.
>
> --
> http://fam-tille.de
There one more problem. The files in the presets/raycasting I'm using
from OsiriX. I'm almost forgot about the presets files. I contacted
them to get informations about copyright and license to put these
informations in debian/copyright. As far as I know the license is
LGPL3 and the copyright is from Antoine Rosset. But contacted them to
get the right information.
Thanks!
--
To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/CAMmoLX-CVfbFdp5ik7=yrqwe_wksfnws8pgzq11+0l954hu...@mail.gmail.com
Re: Packaging InVesalius
On Thu, Feb 07, 2013 at 10:48:05AM -0200, Thiago Franco Moraes wrote:
> sample/sample2.inv3 was created using an old InVesalius version. The
> new InVesalius is not able to open, so this file is useless. It just
> happened that nobody removed that file (I removed it these days).
Debian is good in QA also for upstream. ;-)
I guess it might be reasonable to wait for a new upstream tarball before
uploading to the Debian mirror to avoid distributing ftpmirrors with
unneeded bytes of some noticeable amount. What do you think?
> > How did you realise this?
>
> Ah, sorry. It was my mistake. I was using "fakeroot debian/rules
> binary" to create the package, this command doesn't apply the patch.
> If I use debuild it applies the patch.
I always use debuild (or rather pdebuild.)
> > but this is definitely cosmetics and does not have a real influenze.
> > Apropos cosmetics on patches: It would be nice if you could add some
> > Description fields as described in DEP3[1] to let others understand
> > the rationale of the patch (and who wrote it when).
>
> Done! I have not filled all fields.
Fine!
> > File "/usr/share/invesalius-3.0/invesalius/session.py", line 269, in run
> > debug("Session: trying to write into inexistent file")
> > File "/usr/share/invesalius-3.0/invesalius/utils.py", line 74, in debug
> > if session.debug:
> > AttributeError: 'Session' object has no attribute 'debug'
>
> Fixed. It was missing python-gdcm and python-vtkgdcm as invesalius dependency.
Probably. Unfortunately I found another issue (wonder why this did not
happened yesterday, hmmm):
$ LC_ALL=C sudo dpkg -i invesalius_3.0~b3-1_all.deb
(Reading database ... 313204 files and directories currently installed.)
Preparing to replace invesalius 3.0~b3-1 (using invesalius_3.0~b3-1_all.deb) ...
Unpacking replacement invesalius ...
Setting up invesalius (3.0~b3-1) ...
Sorry: IndentationError: ('expected an indented block',
('/usr/share/invesalius/invesalius/data/styles.py', 128, 7, 'def
OnLeftButtonDown(self, evt, str_evt):\n'))
dpkg: error processing invesalius (--install):
subprocess installed post-installation script returned error exit status 101
Processing triggers for gnome-menus ...
Processing triggers for desktop-file-utils ...
Processing triggers for man-db ...
Processing triggers for menu ...
Errors were encountered while processing:
invesalius
Kind regards
Andreas.
--
http://fam-tille.de
--
To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130207130854.ga9...@an3as.eu
Re: Packaging InVesalius
Hi Andreas,
On Wed, Feb 6, 2013 at 8:12 AM, Andreas Tille wrote:
> Hi Thiago,
>
> On Tue, Feb 05, 2013 at 06:29:53PM -0200, Thiago Franco de Moraes wrote:
>> I managed to create the package. I created a new package in debian/control
>> and a new file called debian/invesalius-examples.examples. I think I did
>> correctly.
>
> The binary is created correctly. I did enhanced the description a bit
> and also made sure that the example does not end up in *both* packages.
> BTW, you did only moved one of two samples - what about
> sample/sample2.inv3 ?
sample/sample2.inv3 was created using an old InVesalius version. The
new InVesalius is not able to open, so this file is useless. It just
happened that nobody removed that file (I removed it these days).
>> I realized that the patches are not being applied anymore. I wasn't able to
>> fix this. Could you, please, take a look at this?
>
> How did you realise this?
Ah, sorry. It was my mistake. I was using "fakeroot debian/rules
binary" to create the package, this command doesn't apply the patch.
If I use debuild it applies the patch.
> I commited the result of
>
>quilt push
>quilt refresh
thanks!
> but this is definitely cosmetics and does not have a real influenze.
> Apropos cosmetics on patches: It would be nice if you could add some
> Description fields as described in DEP3[1] to let others understand
> the rationale of the patch (and who wrote it when).
Done! I have not filled all fields.
> However, I found another problem which is probably connected to a
> missing dependency:
>
> $ invesalius-3.0
> Traceback (most recent call last):
> File "invesalius.py", line 303, in
> main()
> File "invesalius.py", line 261, in main
> application = InVesalius(0)
> File "/usr/lib/python2.7/dist-packages/wx-2.8-gtk2-unicode/wx/_core.py",
> line 7981, in __init__
> self._BootstrapApp()
> File "/usr/lib/python2.7/dist-packages/wx-2.8-gtk2-unicode/wx/_core.py",
> line 7555, in _BootstrapApp
> return _core_.PyApp__BootstrapApp(*args, **kwargs)
> File "invesalius.py", line 67, in OnInit
> self.splash = SplashScreen()
> File "invesalius.py", line 138, in __init__
> session.CreateItens()
> File "/usr/share/invesalius-3.0/invesalius/session.py", line 45, in
> CreateItens
> import constants as const
> File "/usr/share/invesalius-3.0/invesalius/constants.py", line 25, in
>
> from project import Project
> File "/usr/share/invesalius-3.0/invesalius/project.py", line 34, in
> import data.mask as msk
> File "/usr/share/invesalius-3.0/invesalius/data/mask.py", line 30, in
>
> import imagedata_utils as iu
> File "/usr/share/invesalius-3.0/invesalius/data/imagedata_utils.py", line
> 24, in
> import gdcm
> ImportError: No module named gdcm
> Exception in thread Thread-1:
> Traceback (most recent call last):
> File "/usr/lib/python2.7/threading.py", line 552, in __bootstrap_inner
> self.run()
> File "/usr/share/invesalius-3.0/invesalius/session.py", line 269, in run
> debug("Session: trying to write into inexistent file")
> File "/usr/share/invesalius-3.0/invesalius/utils.py", line 74, in debug
> if session.debug:
> AttributeError: 'Session' object has no attribute 'debug'
Fixed. It was missing python-gdcm and python-vtkgdcm as invesalius dependency.
> Kind regards
>
> Andreas.
>
> [1] http://dep.debian.net/deps/dep3/
>
> --
> http://fam-tille.de
Thank you!
--
To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/CAMmoLX8DQPhL=gCWkJR9aw74ZUKus6MJEK6qWqKC=vmmf-q...@mail.gmail.com
Re: Packaging InVesalius
Hi Thiago,
On Tue, Feb 05, 2013 at 06:29:53PM -0200, Thiago Franco de Moraes wrote:
> I managed to create the package. I created a new package in debian/control
> and a new file called debian/invesalius-examples.examples. I think I did
> correctly.
The binary is created correctly. I did enhanced the description a bit
and also made sure that the example does not end up in *both* packages.
BTW, you did only moved one of two samples - what about
sample/sample2.inv3 ?
> I realized that the patches are not being applied anymore. I wasn't able to
> fix this. Could you, please, take a look at this?
How did you realise this? I commited the result of
quilt push
quilt refresh
but this is definitely cosmetics and does not have a real influenze.
Apropos cosmetics on patches: It would be nice if you could add some
Description fields as described in DEP3[1] to let others understand
the rationale of the patch (and who wrote it when).
However, I found another problem which is probably connected to a
missing dependency:
$ invesalius-3.0
Traceback (most recent call last):
File "invesalius.py", line 303, in
main()
File "invesalius.py", line 261, in main
application = InVesalius(0)
File "/usr/lib/python2.7/dist-packages/wx-2.8-gtk2-unicode/wx/_core.py", line
7981, in __init__
self._BootstrapApp()
File "/usr/lib/python2.7/dist-packages/wx-2.8-gtk2-unicode/wx/_core.py", line
7555, in _BootstrapApp
return _core_.PyApp__BootstrapApp(*args, **kwargs)
File "invesalius.py", line 67, in OnInit
self.splash = SplashScreen()
File "invesalius.py", line 138, in __init__
session.CreateItens()
File "/usr/share/invesalius-3.0/invesalius/session.py", line 45, in
CreateItens
import constants as const
File "/usr/share/invesalius-3.0/invesalius/constants.py", line 25, in
from project import Project
File "/usr/share/invesalius-3.0/invesalius/project.py", line 34, in
import data.mask as msk
File "/usr/share/invesalius-3.0/invesalius/data/mask.py", line 30, in
import imagedata_utils as iu
File "/usr/share/invesalius-3.0/invesalius/data/imagedata_utils.py", line 24,
in
import gdcm
ImportError: No module named gdcm
Exception in thread Thread-1:
Traceback (most recent call last):
File "/usr/lib/python2.7/threading.py", line 552, in __bootstrap_inner
self.run()
File "/usr/share/invesalius-3.0/invesalius/session.py", line 269, in run
debug("Session: trying to write into inexistent file")
File "/usr/share/invesalius-3.0/invesalius/utils.py", line 74, in debug
if session.debug:
AttributeError: 'Session' object has no attribute 'debug'
Kind regards
Andreas.
[1] http://dep.debian.net/deps/dep3/
--
http://fam-tille.de
--
To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130206101227.gb6...@an3as.eu
Re: Packaging InVesalius
Hi Andreas, On Tue, Feb 5, 2013 at 6:28 AM, Andreas Tille wrote: > On Mon, Feb 04, 2013 at 09:23:37PM -0200, Thiago Franco de Moraes wrote: >> > I just commited some minor and not so minor fixes to InVesalius >> > packaging. Please have a close look into the svn commit logs to learn a >> > bit more about packaging. >> >> Thanks. I took a look at the commits you did, some of them I need yet >> to have a look in debian docs to understand. > > Feel free to ask what part you might not understand ... OK! >> > There is one remaining issue: >> > >> > W: invesalius source: missing-field-in-dep5-copyright license (paragraph >> > at line 23) >> > W: invesalius source: missing-field-in-dep5-copyright copyright (paragraph >> > at line 23) >> > W: invesalius source: missing-field-in-dep5-copyright license (paragraph >> > at line 26) >> > W: invesalius source: missing-field-in-dep5-copyright copyright (paragraph >> > at line 26) >> >> Ok. Since the doc files and the sample file have the same license and >> copyright from the source code (GPL-2), I removed the parts specific >> to them in debian/copyright. And I updated some informations too, like >> the source and the upstream contacts. have I performed correctly in >> this case? > > OK, I noticed that there is > > .../invesalius3-3.0-b3 $ find . -name "*user_guide*" > ./docs/user_guide_pt_BR.pdf > ./docs/user_guide_pt_BR_source > > (= source and PDF which is fine.) The copyright was mentioning an > (assumably English) documentation which is not there any more. The copyright was mentioning an old documentation which is not included in the InVesalius3 tarball anymore. That documentation was included only in the beta1 and beta2. In the beta3 the only documentation included is the user_guide_pt_BR. > The other exception from "Files: *" copyright was a samples/*.inv3 file. > I have no idea in how far these examples are needed, but from a first > look these files are looking like "binary without source" and ftpmaster > might ask, how these files were created and how to edit them. I guess > they were created invesalius3 and thus can be edited with the program > itself. I removed this part about samples from the copyright. The files in that folder have the same copyright and license from the InVesalius source code. And, yes, the file in samples was created using InVesalius and can be edited by InVesalius. > BTW, are these files needed for normal operation of invesalius3? No, it's only an example. > Usually we do ship example files in a separate binary package (created > from the same source package) named -examples and > dh_installexamples is your friend to move files around. If you would > confirm that these files are not needed for normal invesalius3 operation > I'd recommend doing this (feel free to ask in case you have no idea how > to do this - I could do this in a couple of minutes.) I managed to create the package. I created a new package in debian/control and a new file called debian/invesalius-examples.examples. I think I did correctly. I realized that the patches are not being applied anymore. I wasn't able to fix this. Could you, please, take a look at this? >> > Kind regards and thanks for your work on this >> >> I must also thank you for the great help. Thanks! > > Finally this is one of the main purposes of Debian Med project. > > Kind regards > > Andreas. > > -- > http://fam-tille.de Thanks! -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/8ef9e810-3041-4988-977c-0e80946c8...@mocajuba.cti.gov.br
Re: Packaging InVesalius
On Mon, Feb 04, 2013 at 09:23:37PM -0200, Thiago Franco de Moraes wrote: > > I just commited some minor and not so minor fixes to InVesalius > > packaging. Please have a close look into the svn commit logs to learn a > > bit more about packaging. > > Thanks. I took a look at the commits you did, some of them I need yet > to have a look in debian docs to understand. Feel free to ask what part you might not understand ... > > There is one remaining issue: > > > > W: invesalius source: missing-field-in-dep5-copyright license (paragraph at > > line 23) > > W: invesalius source: missing-field-in-dep5-copyright copyright (paragraph > > at line 23) > > W: invesalius source: missing-field-in-dep5-copyright license (paragraph at > > line 26) > > W: invesalius source: missing-field-in-dep5-copyright copyright (paragraph > > at line 26) > > Ok. Since the doc files and the sample file have the same license and > copyright from the source code (GPL-2), I removed the parts specific > to them in debian/copyright. And I updated some informations too, like > the source and the upstream contacts. have I performed correctly in > this case? OK, I noticed that there is .../invesalius3-3.0-b3 $ find . -name "*user_guide*" ./docs/user_guide_pt_BR.pdf ./docs/user_guide_pt_BR_source (= source and PDF which is fine.) The copyright was mentioning an (assumably English) documentation which is not there any more. The other exception from "Files: *" copyright was a samples/*.inv3 file. I have no idea in how far these examples are needed, but from a first look these files are looking like "binary without source" and ftpmaster might ask, how these files were created and how to edit them. I guess they were created invesalius3 and thus can be edited with the program itself. BTW, are these files needed for normal operation of invesalius3? Usually we do ship example files in a separate binary package (created from the same source package) named -examples and dh_installexamples is your friend to move files around. If you would confirm that these files are not needed for normal invesalius3 operation I'd recommend doing this (feel free to ask in case you have no idea how to do this - I could do this in a couple of minutes.) > > Kind regards and thanks for your work on this > > I must also thank you for the great help. Thanks! Finally this is one of the main purposes of Debian Med project. Kind regards Andreas. -- http://fam-tille.de -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130205082836.ga10...@an3as.eu
Re: Packaging InVesalius
Hi Andreas, On Sun, Feb 3, 2013 at 1:11 PM, Andreas Tille wrote: > Hi Thiago, > > On Thu, Jan 31, 2013 at 11:45:10PM -0200, Thiago Franco de Moraes wrote: >> > This would be great. >> >> Done. I created a simple manpage. > > Cool, thanks. > >> I must say that troff syntax is very ugly :) > > Yep. There are people who are using xml2man or similar tools to avoid > dealing with nroff format ... Thanks for tip. > I just commited some minor and not so minor fixes to InVesalius > packaging. Please have a close look into the svn commit logs to learn a > bit more about packaging. Thanks. I took a look at the commits you did, some of them I need yet to have a look in debian docs to understand. > There is one remaining issue: > > W: invesalius source: missing-field-in-dep5-copyright license (paragraph at > line 23) > W: invesalius source: missing-field-in-dep5-copyright copyright (paragraph at > line 23) > W: invesalius source: missing-field-in-dep5-copyright license (paragraph at > line 26) > W: invesalius source: missing-field-in-dep5-copyright copyright (paragraph at > line 26) Ok. Since the doc files and the sample file have the same license and copyright from the source code (GPL-2), I removed the parts specific to them in debian/copyright. And I updated some informations too, like the source and the upstream contacts. have I performed correctly in this case? > You are mentioning the sources to some documentation files but I know > for sure that ftpmaster wants to see these sources included into the > downloadable source tarball. So please do include these in your next > source release and in case they have different copyright / license > please do mention these as well in the debian/copyright file. The source from docs/user_guide_pt_BR.pdf are in the tarball, they are in the folder docs/user_guide_pt_BR_source. This file was written in latex. > Otherwise I'd regard the packaging as read and if the issue of the > documentation > source is solved we could upload to unstable. Cool! > Kind regards and thanks for your work on this I must also thank you for the great help. Thanks! > Andreas. -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/0b2c683f-1ffa-4764-ac38-213350822...@mocajuba.cti.gov.br
Re: Packaging InVesalius
Hi Thiago, On Thu, Jan 31, 2013 at 11:45:10PM -0200, Thiago Franco de Moraes wrote: > > This would be great. > > Done. I created a simple manpage. Cool, thanks. > I must say that troff syntax is very ugly :) Yep. There are people who are using xml2man or similar tools to avoid dealing with nroff format ... I just commited some minor and not so minor fixes to InVesalius packaging. Please have a close look into the svn commit logs to learn a bit more about packaging. There is one remaining issue: W: invesalius source: missing-field-in-dep5-copyright license (paragraph at line 23) W: invesalius source: missing-field-in-dep5-copyright copyright (paragraph at line 23) W: invesalius source: missing-field-in-dep5-copyright license (paragraph at line 26) W: invesalius source: missing-field-in-dep5-copyright copyright (paragraph at line 26) You are mentioning the sources to some documentation files but I know for sure that ftpmaster wants to see these sources included into the downloadable source tarball. So please do include these in your next source release and in case they have different copyright / license please do mention these as well in the debian/copyright file. Otherwise I'd regard the packaging as read and if the issue of the documentation source is solved we could upload to unstable. Kind regards and thanks for your work on this Andreas. -- http://fam-tille.de -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130203151106.gh20...@an3as.eu
Re: Packaging InVesalius
Hi Andreas, On Mon, Jan 28, 2013 at 6:17 AM, Andreas Tille wrote: > Hi Thiago, > > On Sun, Jan 27, 2013 at 05:59:45PM -0200, Thiago Franco de Moraes wrote: >> >> Now the rename is working. He is renaming the tarball to >> invesalius_3.0~b3.orig.tar.gz. To make it work I used uversionmangle instead >> of dversionmangle. The folder inside this tarball has the name >> "invesalius3-3.0-b3" instead of "invesalius_3.0~b3", is this a problem? > > The folder name inside the tarball is no problem. If we do not repack > the tarball we just take what is inside (sometimes there are quite > strange choices of names - we simply leave this as is.) > >> The Lintian returns two warnings: >> >> W: invesalius: extra-license-file usr/share/doc/invesalius/LICENSE.txt.gz > >> It's because the package has two license files, one in English and other in >> Portuguese. The Portuguese version is because a license must be in >> Portuguese to be recognized by the Brazilian government. > > That's a fair reason. I would suggest to rename it LICENSE.pt.txt (or > LICENSE.pt.BR.txt at your preference) and to not compress this file > (which can be done by override_dh_compress (you will find examples when > greping for this string in SVN.) The debian/copyright file must not be > compressed and I would consider the same reason for any translated > license statement. Done. I renamed to LICENSE.pt.txt > You can create a lintian-overrides file to suppress the warning and > also add a comment for the reason you have given above. Done. >> W: invesalius: binary-without-manpage usr/bin/invesalius-3.0 > If you think >> it's necessary, I can create a manpage to InVesalius. > > This would be great. Done. I created a simple manpage. I must say that troff syntax is very ugly :) > Kind regards and thanks for your work on this > >Andreas. > > -- > http://fam-tille.de Thanks! -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/0e11ea51-b304-43f9-840e-92fce6113...@mocajuba.cti.gov.br
Re: Packaging InVesalius
Hi Thiago, On Sun, Jan 27, 2013 at 05:59:45PM -0200, Thiago Franco de Moraes wrote: > > Now the rename is working. He is renaming the tarball to > invesalius_3.0~b3.orig.tar.gz. To make it work I used uversionmangle instead > of dversionmangle. The folder inside this tarball has the name > "invesalius3-3.0-b3" instead of "invesalius_3.0~b3", is this a problem? The folder name inside the tarball is no problem. If we do not repack the tarball we just take what is inside (sometimes there are quite strange choices of names - we simply leave this as is.) > The Lintian returns two warnings: > > W: invesalius: extra-license-file usr/share/doc/invesalius/LICENSE.txt.gz > > It's because the package has two license files, one in English and other in > Portuguese. The Portuguese version is because a license must be in Portuguese > to be recognized by the Brazilian government. That's a fair reason. I would suggest to rename it LICENSE.pt.txt (or LICENSE.pt.BR.txt at your preference) and to not compress this file (which can be done by override_dh_compress (you will find examples when greping for this string in SVN.) The debian/copyright file must not be compressed and I would consider the same reason for any translated license statement. You can create a lintian-overrides file to suppress the warning and also add a comment for the reason you have given above. > W: invesalius: binary-without-manpage usr/bin/invesalius-3.0 > If you think > it's necessary, I can create a manpage to InVesalius. This would be great. Kind regards and thanks for your work on this Andreas. -- http://fam-tille.de -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130128081722.ga9...@an3as.eu
Re: Packaging InVesalius
Hi Andreas, Now the rename is working. He is renaming the tarball to invesalius_3.0~b3.orig.tar.gz. To make it work I used uversionmangle instead of dversionmangle. The folder inside this tarball has the name "invesalius3-3.0-b3" instead of "invesalius_3.0~b3", is this a problem? The Lintian returns two warnings: W: invesalius: extra-license-file usr/share/doc/invesalius/LICENSE.txt.gz > It's because the package has two license files, one in English and other in Portuguese. The Portuguese version is because a license must be in Portuguese to be recognized by the Brazilian government. W: invesalius: binary-without-manpage usr/bin/invesalius-3.0 > If you think it's necessary, I can create a manpage to InVesalius. Best regards. - Mensagem original - De: "Thiago Franco Moraes" Para: debian-med@lists.debian.org Enviadas: Domingo, 20 de Janeiro de 2013 22:48:02 Assunto: Re: Packaging InVesalius Hi Andreas, On Mon, Jan 14, 2013 at 11:59 AM, Andreas Tille wrote: > Hi Thiago, > > On Sun, Jan 13, 2013 at 05:39:11PM -0200, Thiago Franco Moraes wrote: >> I updated the debian/watch to match the last invesalius release. I >> have to use "opts=dversionmangle" to match the package version to git >> tag. I wrote a get-orig-source too (well, actually, I copied the one >> Andreas Tille wrote python-casmoothing :) ). > > Could you imagine how frequently I copy myself from other packages? :-) :) > I checked the build and it creates a package. Please note that the watch > file does not work 100% - I needed to manually > >ln -s invesalius_3.0.0b3.orig.tar.gz invesalius_3.0~b3.orig.tar.gz > > Without testing I think an additional "filenamemangle" is your friend - > please check the `man uscan?. I got today (sunday) to try to resolve this, but I was not able to get filenamemangle work. Maybe I need to try more. >> Ah, I have to wrote a >> patch to change the shebang from "#!/usr/local/bin/python" to >> "#!/usr/bin/python". > > Yep - and there are some other lintian warnings - perhaps you simply use > your upstream hat to fix some permissions. I'd also think that you > could do the patch above upstream - I can not really imagine that there > are production boxes where you find the Python interpreter in > /usr/local these days (or use env). Using the git tag invesalius-3.0.0b3 as base, I created a new branch (beta3) and I resolved these problems with permissions and the shebangs. Ah, I took the opportunity to backport some commits from trunk into this branch (Thanks git for makes it easier :) ), some of these commits fix bugs in InVesalius 3 beta 3. After the backport, I created a new tag v3.0-b3. > Kind regards > >Andreas. > > -- > http://fam-tille.de Thanks again! -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cammolx9rj+u1gpr8ke4pt-goqrpow26ggtasrn2nr00bkir...@mail.gmail.com -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cc44f842-224e-4b23-bb8c-cfb1eb116...@mocajuba.cti.gov.br
Re: Packaging InVesalius
Hi Andreas, On Mon, Jan 14, 2013 at 11:59 AM, Andreas Tille wrote: > Hi Thiago, > > On Sun, Jan 13, 2013 at 05:39:11PM -0200, Thiago Franco Moraes wrote: >> I updated the debian/watch to match the last invesalius release. I >> have to use "opts=dversionmangle" to match the package version to git >> tag. I wrote a get-orig-source too (well, actually, I copied the one >> Andreas Tille wrote python-casmoothing :) ). > > Could you imagine how frequently I copy myself from other packages? :-) :) > I checked the build and it creates a package. Please note that the watch > file does not work 100% - I needed to manually > >ln -s invesalius_3.0.0b3.orig.tar.gz invesalius_3.0~b3.orig.tar.gz > > Without testing I think an additional "filenamemangle" is your friend - > please check the `man uscan?. I got today (sunday) to try to resolve this, but I was not able to get filenamemangle work. Maybe I need to try more. >> Ah, I have to wrote a >> patch to change the shebang from "#!/usr/local/bin/python" to >> "#!/usr/bin/python". > > Yep - and there are some other lintian warnings - perhaps you simply use > your upstream hat to fix some permissions. I'd also think that you > could do the patch above upstream - I can not really imagine that there > are production boxes where you find the Python interpreter in > /usr/local these days (or use env). Using the git tag invesalius-3.0.0b3 as base, I created a new branch (beta3) and I resolved these problems with permissions and the shebangs. Ah, I took the opportunity to backport some commits from trunk into this branch (Thanks git for makes it easier :) ), some of these commits fix bugs in InVesalius 3 beta 3. After the backport, I created a new tag v3.0-b3. > Kind regards > >Andreas. > > -- > http://fam-tille.de Thanks again! -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cammolx9rj+u1gpr8ke4pt-goqrpow26ggtasrn2nr00bkir...@mail.gmail.com
Re: Packaging InVesalius
Hi Thiago, On Sun, Jan 13, 2013 at 05:39:11PM -0200, Thiago Franco Moraes wrote: > I updated the debian/watch to match the last invesalius release. I > have to use "opts=dversionmangle" to match the package version to git > tag. I wrote a get-orig-source too (well, actually, I copied the one > Andreas Tille wrote python-casmoothing :) ). Could you imagine how frequently I copy myself from other packages? :-) I checked the build and it creates a package. Please note that the watch file does not work 100% - I needed to manually ln -s invesalius_3.0.0b3.orig.tar.gz invesalius_3.0~b3.orig.tar.gz Without testing I think an additional "filenamemangle" is your friend - please check the `man uscan?. > Ah, I have to wrote a > patch to change the shebang from "#!/usr/local/bin/python" to > "#!/usr/bin/python". Yep - and there are some other lintian warnings - perhaps you simply use your upstream hat to fix some permissions. I'd also think that you could do the patch above upstream - I can not really imagine that there are production boxes where you find the Python interpreter in /usr/local these days (or use env). Kind regards Andreas. -- http://fam-tille.de -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130114135913.gg24...@an3as.eu
Re: Packaging InVesalius
I updated the debian/watch to match the last invesalius release. I have to use "opts=dversionmangle" to match the package version to git tag. I wrote a get-orig-source too (well, actually, I copied the one Andreas Tille wrote python-casmoothing :) ). Ah, I have to wrote a patch to change the shebang from "#!/usr/local/bin/python" to "#!/usr/bin/python". Best regards. On Wed, Jan 9, 2013 at 8:15 PM, Andreas Tille wrote: > On Wed, Jan 09, 2013 at 04:25:08PM -0200, Thiago Franco Moraes wrote: >> I was very busy working in InVesalius source code and solving other >> problems, so I wasn't working in packaging InVesalius. Now I'm on >> vacation and I think I can take some time to work in packaging :) > > :-) > >> On Mon, Dec 17, 2012 at 2:13 PM, Andreas Tille wrote: >> >> > Please also note that `dpkg --compare-versions` does consider 3.0.0.b3-1 >> >> > larger than 3.0.0-1 - so uscan might fail identifying your real release >> >> > as a higher version than your beta release. >> >> >> >> I was reading [1] about this issue with version. So I'll need to use >> >> something like this as version to InVesalius: 2.99+3.0b3-0tfmoraes1? >> >> And I'll need to create a git tag with that version? >> > >> > Yes, this would be a possible solution. You could also simplify it by >> > using >> > >> > 3.0~b3-1 >> >> As the name of invesalius repository is invesalius3, when I tag a >> version as "3.0~b3-1", the tarball created will be named >> invesalius3-3.0~b3-1. So I think I'll need to create manually a >> tarball named invesalius-3.0~b3-1, isn't it? Or there is a way to >> workaround it in github or in the watch file? > > Well, you download the upstream tarball invesalius-.tgz. > You rename it > >mv invesalius-.tgz invesalius3-3.0~b3-1 > > and you be done. Usually uscan even does the renaming (or symlinking) > for you. > >> > which is also considered smaller than 3.0-1. This is a bit more >> > handsome for reading but finally it does not matter much as long as the >> > relation of the version numbers is correct. Whatever you decide you >> > need to use versionmangling in debian/watch file. Just tell me what >> > kind of version numbering you prefer and whether you need help in >> > adapting debian/watch (which is sometimes a bit tricky and some >> > experience is helpful in the beginning). >> >> I'll try by myself. Any help I need I write here. > > Good luck > >Andreas. > > -- > http://fam-tille.de > > > -- > To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org > with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org > Archive: http://lists.debian.org/20130109221503.gt27...@an3as.eu > -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAMmoLX9k5qYjkQrN_rHjU-hadg3=wktpgnxx3hw74bvdgsf...@mail.gmail.com
Re: Packaging InVesalius
On Wed, Jan 09, 2013 at 04:25:08PM -0200, Thiago Franco Moraes wrote: > I was very busy working in InVesalius source code and solving other > problems, so I wasn't working in packaging InVesalius. Now I'm on > vacation and I think I can take some time to work in packaging :) :-) > On Mon, Dec 17, 2012 at 2:13 PM, Andreas Tille wrote: > >> > Please also note that `dpkg --compare-versions` does consider 3.0.0.b3-1 > >> > larger than 3.0.0-1 - so uscan might fail identifying your real release > >> > as a higher version than your beta release. > >> > >> I was reading [1] about this issue with version. So I'll need to use > >> something like this as version to InVesalius: 2.99+3.0b3-0tfmoraes1? > >> And I'll need to create a git tag with that version? > > > > Yes, this would be a possible solution. You could also simplify it by > > using > > > > 3.0~b3-1 > > As the name of invesalius repository is invesalius3, when I tag a > version as "3.0~b3-1", the tarball created will be named > invesalius3-3.0~b3-1. So I think I'll need to create manually a > tarball named invesalius-3.0~b3-1, isn't it? Or there is a way to > workaround it in github or in the watch file? Well, you download the upstream tarball invesalius-.tgz. You rename it mv invesalius-.tgz invesalius3-3.0~b3-1 and you be done. Usually uscan even does the renaming (or symlinking) for you. > > which is also considered smaller than 3.0-1. This is a bit more > > handsome for reading but finally it does not matter much as long as the > > relation of the version numbers is correct. Whatever you decide you > > need to use versionmangling in debian/watch file. Just tell me what > > kind of version numbering you prefer and whether you need help in > > adapting debian/watch (which is sometimes a bit tricky and some > > experience is helpful in the beginning). > > I'll try by myself. Any help I need I write here. Good luck Andreas. -- http://fam-tille.de -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130109221503.gt27...@an3as.eu
Re: Packaging InVesalius
Hi Andreas, I was very busy working in InVesalius source code and solving other problems, so I wasn't working in packaging InVesalius. Now I'm on vacation and I think I can take some time to work in packaging :) On Mon, Dec 17, 2012 at 2:13 PM, Andreas Tille wrote: > Hi Tiago > > On Mon, Dec 17, 2012 at 01:43:34PM -0200, Thiago Franco Moraes wrote: >> Hi Andreas, >> >> > Please also note that `dpkg --compare-versions` does consider 3.0.0.b3-1 >> > larger than 3.0.0-1 - so uscan might fail identifying your real release >> > as a higher version than your beta release. >> >> I was reading [1] about this issue with version. So I'll need to use >> something like this as version to InVesalius: 2.99+3.0b3-0tfmoraes1? >> And I'll need to create a git tag with that version? > > Yes, this would be a possible solution. You could also simplify it by > using > > 3.0~b3-1 As the name of invesalius repository is invesalius3, when I tag a version as "3.0~b3-1", the tarball created will be named invesalius3-3.0~b3-1. So I think I'll need to create manually a tarball named invesalius-3.0~b3-1, isn't it? Or there is a way to workaround it in github or in the watch file? > which is also considered smaller than 3.0-1. This is a bit more > handsome for reading but finally it does not matter much as long as the > relation of the version numbers is correct. Whatever you decide you > need to use versionmangling in debian/watch file. Just tell me what > kind of version numbering you prefer and whether you need help in > adapting debian/watch (which is sometimes a bit tricky and some > experience is helpful in the beginning). I'll try by myself. Any help I need I write here. > Kind regards > > Andreas. Best regards. >> [1] - http://people.debian.org/~calvin/unofficial/ > > -- > http://fam-tille.de > > > -- > To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org > with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org > Archive: http://lists.debian.org/20121217161313.ge3...@an3as.eu > -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAMmoLX8UD8EUkrGHs06h7_kZe+r=rgvj+khvuccf2nnhuv4...@mail.gmail.com
Re: Packaging InVesalius
Hi Tiago On Mon, Dec 17, 2012 at 01:43:34PM -0200, Thiago Franco Moraes wrote: > Hi Andreas, > > > Please also note that `dpkg --compare-versions` does consider 3.0.0.b3-1 > > larger than 3.0.0-1 - so uscan might fail identifying your real release > > as a higher version than your beta release. > > I was reading [1] about this issue with version. So I'll need to use > something like this as version to InVesalius: 2.99+3.0b3-0tfmoraes1? > And I'll need to create a git tag with that version? Yes, this would be a possible solution. You could also simplify it by using 3.0~b3-1 which is also considered smaller than 3.0-1. This is a bit more handsome for reading but finally it does not matter much as long as the relation of the version numbers is correct. Whatever you decide you need to use versionmangling in debian/watch file. Just tell me what kind of version numbering you prefer and whether you need help in adapting debian/watch (which is sometimes a bit tricky and some experience is helpful in the beginning). Kind regards Andreas. > [1] - http://people.debian.org/~calvin/unofficial/ -- http://fam-tille.de -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121217161313.ge3...@an3as.eu
Re: Packaging InVesalius
Hi Andreas, > Please also note that `dpkg --compare-versions` does consider 3.0.0.b3-1 > larger than 3.0.0-1 - so uscan might fail identifying your real release > as a higher version than your beta release. I was reading [1] about this issue with version. So I'll need to use something like this as version to InVesalius: 2.99+3.0b3-0tfmoraes1? And I'll need to create a git tag with that version? > Kind regards > > Andreas. > > -- > http://fam-tille.de > > > -- > To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org > with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org > Archive: http://lists.debian.org/20121212191509.gm30...@an3as.eu Cheers. [1] - http://people.debian.org/~calvin/unofficial/ -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAMmoLX_eEqfQBdG+HuQDtACN14oTXN7Hg==wauynqraywaa...@mail.gmail.com
Re: Packaging InVesalius
Hi Thiago, On Fri, Dec 14, 2012 at 03:37:05PM -0200, Thiago Franco Moraes wrote: > > I haven't worked at debian/watch yet. I didn't event know about the > source tarball being inside the ubuntu32 folder. Now we are using > Github, when I create a new tag it creates automatically an tarball > following this filename pattern : > > https://github.com/invesalius/invesalius3/archive/invesalius-3.0.0b3.tar.gz Sounds good. Just read http://wiki.debian.org/debian/watch/ how to write the watch file which should be quite simple. Kind regards Andreas. -- http://fam-tille.de -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121214175604.ga7...@an3as.eu
Re: Packaging InVesalius
Hi Andreas, On Wed, Dec 12, 2012 at 5:15 PM, Andreas Tille wrote: > On Wed, Dec 12, 2012 at 03:40:33PM -0200, Thiago Franco Moraes wrote: >> I've done and committed that trick with debian/links. I saw I'll need >> create a man to InVesalius because the package adds a script file in >> /usr/bin/. I think I'll work on it after the next invesalius release. > > Seems it is time to have a sponsor-centric view onto invesalius now. > So I tried :) > $ uscan --verbose --force-download > -- Scanning for watchfiles in . > -- Found watchfile in ./debian > -- In debian/watch, processing watchfile line: > > http://svn.softwarepublico.gov.br/trac/invesalius/browser/releases/invesalius3/ubuntu32/ > > http://svn.softwarepublico.gov.br/trac/invesalius/browser/releases/invesalius3/ubuntu32/invesalius_(.+)\.orig.tar.gz > uscan warning: In debian/watch, > no matching hrefs for watch line > > http://svn.softwarepublico.gov.br/trac/invesalius/browser/releases/invesalius3/ubuntu32/ > > http://svn.softwarepublico.gov.br/trac/invesalius/browser/releases/invesalius3/ubuntu32/invesalius_(.+)\.orig.tar.gz > -- Scan finished > > > Seems your debian/watch file is not fit to download the latest > invesalius source tarball. Considering you are upstream and have some > influence how to structure your download area I'd recommend making > things a bit simpler for uscan. I admit the "ubuntu32" location looks a > bit suspicious. We are seeking for plain souce tarballs - and probably > other distributors are trying the same (or just people who want to > install from source). Putting this into a > named directory just sounds wrong. Also the naming with 'orig' inside > the names makes things quite distribution specific - usually the orig > is added by uscan later on. > > I'd recommend to have a website which contains links to files named > >invesalius-.tar.[gx]z I haven't worked at debian/watch yet. I didn't event know about the source tarball being inside the ubuntu32 folder. Now we are using Github, when I create a new tag it creates automatically an tarball following this filename pattern : https://github.com/invesalius/invesalius3/archive/invesalius-3.0.0b3.tar.gz > Please also note that `dpkg --compare-versions` does consider 3.0.0.b3-1 > larger than 3.0.0-1 - so uscan might fail identifying your real release > as a higher version than your beta release. Ok. I'll take a look at this. Thank you! > Kind regards > > Andreas. > > -- > http://fam-tille.de > > > -- > To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org > with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org > Archive: http://lists.debian.org/20121212191509.gm30...@an3as.eu > -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cammolx-_bgq9gzsk4q3gkkgb29bagx4hyuqv1_xpzzt+whz...@mail.gmail.com
Re: Packaging InVesalius
On Wed, Dec 12, 2012 at 03:40:33PM -0200, Thiago Franco Moraes wrote: > I've done and committed that trick with debian/links. I saw I'll need > create a man to InVesalius because the package adds a script file in > /usr/bin/. I think I'll work on it after the next invesalius release. Seems it is time to have a sponsor-centric view onto invesalius now. So I tried $ uscan --verbose --force-download -- Scanning for watchfiles in . -- Found watchfile in ./debian -- In debian/watch, processing watchfile line: http://svn.softwarepublico.gov.br/trac/invesalius/browser/releases/invesalius3/ubuntu32/ http://svn.softwarepublico.gov.br/trac/invesalius/browser/releases/invesalius3/ubuntu32/invesalius_(.+)\.orig.tar.gz uscan warning: In debian/watch, no matching hrefs for watch line http://svn.softwarepublico.gov.br/trac/invesalius/browser/releases/invesalius3/ubuntu32/ http://svn.softwarepublico.gov.br/trac/invesalius/browser/releases/invesalius3/ubuntu32/invesalius_(.+)\.orig.tar.gz -- Scan finished Seems your debian/watch file is not fit to download the latest invesalius source tarball. Considering you are upstream and have some influence how to structure your download area I'd recommend making things a bit simpler for uscan. I admit the "ubuntu32" location looks a bit suspicious. We are seeking for plain souce tarballs - and probably other distributors are trying the same (or just people who want to install from source). Putting this into a named directory just sounds wrong. Also the naming with 'orig' inside the names makes things quite distribution specific - usually the orig is added by uscan later on. I'd recommend to have a website which contains links to files named invesalius-.tar.[gx]z Please also note that `dpkg --compare-versions` does consider 3.0.0.b3-1 larger than 3.0.0-1 - so uscan might fail identifying your real release as a higher version than your beta release. Kind regards Andreas. -- http://fam-tille.de -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121212191509.gm30...@an3as.eu
Re: Packaging InVesalius
Andreas, On Wed, Dec 12, 2012 at 8:46 AM, Andreas Tille wrote: > On Tue, Dec 11, 2012 at 10:47:23AM -0200, Thiago Franco Moraes wrote: >> > Please make very sure that the source also contains the *source* of this >> > PDF file (whatever it might be). >> >> Yes. It contains the latex files used to build the pdf file. > > That's good to know. > >> > On the other hand: You also could put a symlink using a file >> > >> >debian/links >> > >> > and just symlink to the original location which might save you the patch. >> >> I chose this one. It's simpler :) > > Yes. That's why I was mentioning it. > >> > BTW, if the documentation is only in pt_BR I'd advise upstream to try to >> > give at least an English translation. >> >> This is complicated. We are eager to release a new version very soon. >> I don't know if we'll have time to translate to English before the >> release. > > No problem with this. I just wanted to say that while documentation in > /usr/share/doc/ is a very important thing to have but from a > general point of view if the documentation is not in English I would > reduce the effort I'm investing into it (like patches etc.) Keeping > things simple is in this case quite reasonable and once there might be a > translation we might consider rethinking what should be done to serve > our users best. I've done and committed that trick with debian/links. I saw I'll need create a man to InVesalius because the package adds a script file in /usr/bin/. I think I'll work on it after the next invesalius release. > Kind regards > > Andreas. > > -- > http://fam-tille.de > > > -- > To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org > with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org > Archive: http://lists.debian.org/20121212104655.gc30...@an3as.eu > Thanks! -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cammolx90xcejed3yr5c1yqn+_tmg-sf8dphhvnf+vvozpoq...@mail.gmail.com
Re: Packaging InVesalius
On Tue, Dec 11, 2012 at 10:47:23AM -0200, Thiago Franco Moraes wrote: > > Please make very sure that the source also contains the *source* of this > > PDF file (whatever it might be). > > Yes. It contains the latex files used to build the pdf file. That's good to know. > > On the other hand: You also could put a symlink using a file > > > >debian/links > > > > and just symlink to the original location which might save you the patch. > > I chose this one. It's simpler :) Yes. That's why I was mentioning it. > > BTW, if the documentation is only in pt_BR I'd advise upstream to try to > > give at least an English translation. > > This is complicated. We are eager to release a new version very soon. > I don't know if we'll have time to translate to English before the > release. No problem with this. I just wanted to say that while documentation in /usr/share/doc/ is a very important thing to have but from a general point of view if the documentation is not in English I would reduce the effort I'm investing into it (like patches etc.) Keeping things simple is in this case quite reasonable and once there might be a translation we might consider rethinking what should be done to serve our users best. Kind regards Andreas. -- http://fam-tille.de -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121212104655.gc30...@an3as.eu
Re: Packaging InVesalius
Hi Andreas On Mon, Dec 10, 2012 at 5:29 PM, Andreas Tille wrote: > Hi Thiago, > > On Mon, Dec 10, 2012 at 04:14:11PM -0200, Thiago Franco Moraes wrote: >> InVesalius has a docs and its only file is a pdf file. > > Please make very sure that the source also contains the *source* of this > PDF file (whatever it might be). Yes. It contains the latex files used to build the pdf file. >> It seems me >> that it is more correct put this file at the folder >> /usr/share/doc/invesalius/. OK. So I overrode dh_installdocs at >> debian/rules; >> >> >> override_dh_installdocs: >> dh_installdocs >> dh_installdocs docs/user_guide_pt_BR.pdf >> > > Same as for dh_install you can also use the file > >debian/docs > > containing just > >docs/user_guide_pt_BR.pdf > >> And I created a patch to InVesalius to change where InVesalius will >> find this pdf file. The problem is the process of package creation is >> compressing this files using gzip. I'm not sure if all pdf viewer can >> open gzip pdf files. Is it possible to dh_installdocs without it >> compressing my pdf file? > > override_dh_compress: > dh_compress --exclude=.pdf > > > On the other hand: You also could put a symlink using a file > >debian/links > > and just symlink to the original location which might save you the patch. I chose this one. It's simpler :) > BTW, if the documentation is only in pt_BR I'd advise upstream to try to > give at least an English translation. This is complicated. We are eager to release a new version very soon. I don't know if we'll have time to translate to English before the release. Thanks again Andreas. > Kind regards > > Andreas. > > -- > http://fam-tille.de > > > -- > To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org > with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org > Archive: http://lists.debian.org/20121210192942.ga21...@an3as.eu > -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cammolx_ygisaua8dd1nic0c6bxxsbcaoeczt+y3vtejfy0e...@mail.gmail.com
Re: Packaging InVesalius
Hi Thiago, On Mon, Dec 10, 2012 at 04:14:11PM -0200, Thiago Franco Moraes wrote: > InVesalius has a docs and its only file is a pdf file. Please make very sure that the source also contains the *source* of this PDF file (whatever it might be). > It seems me > that it is more correct put this file at the folder > /usr/share/doc/invesalius/. OK. So I overrode dh_installdocs at > debian/rules; > > > override_dh_installdocs: > dh_installdocs > dh_installdocs docs/user_guide_pt_BR.pdf > Same as for dh_install you can also use the file debian/docs containing just docs/user_guide_pt_BR.pdf > And I created a patch to InVesalius to change where InVesalius will > find this pdf file. The problem is the process of package creation is > compressing this files using gzip. I'm not sure if all pdf viewer can > open gzip pdf files. Is it possible to dh_installdocs without it > compressing my pdf file? override_dh_compress: dh_compress --exclude=.pdf On the other hand: You also could put a symlink using a file debian/links and just symlink to the original location which might save you the patch. BTW, if the documentation is only in pt_BR I'd advise upstream to try to give at least an English translation. Kind regards Andreas. -- http://fam-tille.de -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121210192942.ga21...@an3as.eu
Re: Packaging InVesalius
Hi Andreas, On Fri, Dec 7, 2012 at 1:42 PM, Andreas Tille wrote: > Hi Thiago, > > On Fri, Dec 07, 2012 at 01:20:44PM -0200, Thiago Franco Moraes wrote: >> > You may even make use of `dh_install` syntax instead of the lower >> > level `install` command. >> >> It's a great idea. I'll take a look at 'dh_install' syntax. > > Additional hint which has proven to be given to newcomers: Please use > dh_install via debian/*install files where you just name the files and > the places where these should be moved to. That's the most simple and > straightforward way to move files around - there are lots of examples > using this (and BTW also python-casmoothing is using it ;-)). Thanks! I'm working now at packaging InVesalius and I'm using yours and Mathieu's tips. They have been very helpful. InVesalius has a docs and its only file is a pdf file. It seems me that it is more correct put this file at the folder /usr/share/doc/invesalius/. OK. So I overrode dh_installdocs at debian/rules; override_dh_installdocs: dh_installdocs dh_installdocs docs/user_guide_pt_BR.pdf And I created a patch to InVesalius to change where InVesalius will find this pdf file. The problem is the process of package creation is compressing this files using gzip. I'm not sure if all pdf viewer can open gzip pdf files. Is it possible to dh_installdocs without it compressing my pdf file? Thanks in advance. > Kind regards > > Andreas. > > -- > http://fam-tille.de > > > -- > To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org > with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org > Archive: http://lists.debian.org/20121207154255.ga29...@an3as.eu > -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAMmoLX_OvbahYfowaGehjum6=8zs+qpte3jo9zusjx9yjb0...@mail.gmail.com
Re: Packaging InVesalius
Hi Thiago, On Fri, Dec 07, 2012 at 01:20:44PM -0200, Thiago Franco Moraes wrote: > > You may even make use of `dh_install` syntax instead of the lower > > level `install` command. > > It's a great idea. I'll take a look at 'dh_install' syntax. Additional hint which has proven to be given to newcomers: Please use dh_install via debian/*install files where you just name the files and the places where these should be moved to. That's the most simple and straightforward way to move files around - there are lots of examples using this (and BTW also python-casmoothing is using it ;-)). Kind regards Andreas. -- http://fam-tille.de -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121207154255.ga29...@an3as.eu
Re: Packaging InVesalius
On Fri, Dec 7, 2012 at 12:01 PM, Mathieu Malaterre wrote: > Hi, > > On Fri, Dec 7, 2012 at 2:52 PM, Thiago Franco Moraes > wrote: >> I have the following question: How can I add a file (Makefile in my >> case) when doing the package? I was thinking in add the Makefile in >> the debian folder and put in debian/rules file a command to move the >> Makefile to the source code. Is this a good idea. > > d/rules is already a Makefile... why not copy/paste your existing > Makefile into d/rules ? > > You may even make use of `dh_install` syntax instead of the lower > level `install` command. > > 2cts > -M Hi Mathieu, It's a great idea. I'll take a look at 'dh_install' syntax. Thanks!. -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cammolx8gpxz-vcu4-wm3qx1e95hkgel4zfewcm5cwglg9rj...@mail.gmail.com
Re: Packaging InVesalius
Hi, On Fri, Dec 7, 2012 at 2:52 PM, Thiago Franco Moraes wrote: > I have the following question: How can I add a file (Makefile in my > case) when doing the package? I was thinking in add the Makefile in > the debian folder and put in debian/rules file a command to move the > Makefile to the source code. Is this a good idea. d/rules is already a Makefile... why not copy/paste your existing Makefile into d/rules ? You may even make use of `dh_install` syntax instead of the lower level `install` command. 2cts -M -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CA+7wUsyE57NAVMEvaPe_m=2tf7pftha6gt5sw5uvtnpszsj...@mail.gmail.com
