Re: shell kung-fu with set -e, return codes and i/o redirection in while read ... loop
Jonas Meurer writes:
> On 20/07/2009 Boyd Stephen Smith Jr. wrote:
>> In <20090719235708.gb22...@resivo.wgnet.de>, Jonas Meurer wrote:
>> >- in cryptdisks_{start|stop} only one device is setup anyway. here I
>> > simply don't use set -e and check for the error code instead.
>>
>> While I understand your goal here, I think you should try and accomplish it
>> while leaving the entire script "set -e". It helps prevent errors from
>> cascading. Even if you are checking return values for everything now, you
>> might not be so disciplined with changes in the future.
>
> i see your point and indeed i already reverted the change to not set -e
> the scripts. instead I now use a if statement for the invokation of
> handle_crypttab_line_{start,stop}, do post-cryptsetup stuff (umount)
> directly in the while loop, and exit with log_action_end_msg $ret at the
> end of the while loop. that way the script always stops inside the while
> loop, with or without error.
>
> greetings,
> jonas
Beware that if you call a function from a complex expression (if,
while, ||, &&, |) then that function will not use "set -e". Inside the
function you then need to check every return code again or errors will
cascade.
MfG
Goswin
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Re: shell kung-fu with set -e, return codes and i/o redirection in while read ... loop
On 20/07/2009 Boyd Stephen Smith Jr. wrote:
> In <20090719235708.gb22...@resivo.wgnet.de>, Jonas Meurer wrote:
> >- in cryptdisks_{start|stop} only one device is setup anyway. here I
> > simply don't use set -e and check for the error code instead.
>
> While I understand your goal here, I think you should try and accomplish it
> while leaving the entire script "set -e". It helps prevent errors from
> cascading. Even if you are checking return values for everything now, you
> might not be so disciplined with changes in the future.
i see your point and indeed i already reverted the change to not set -e
the scripts. instead I now use a if statement for the invokation of
handle_crypttab_line_{start,stop}, do post-cryptsetup stuff (umount)
directly in the while loop, and exit with log_action_end_msg $ret at the
end of the while loop. that way the script always stops inside the while
loop, with or without error.
greetings,
jonas
signature.asc
Description: Digital signature
RFS: python-akismet
Dear mentors, I am looking for a sponsor for my package "python-akismet". * Package name: python-akismet Version : 0.2.0-1 Upstream Author : Michael Foord * URL : http://www.voidspace.org.uk/python/modules.shtml#akismet * License : BSD Section : python It builds these binary packages: python-akismet - interface to the Akismet anti comment-spam API The upload would fix these bugs: 537796 The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/p/python-akismet - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/p/python-akismet/python-akismet_0.2.0-1.dsc I would be glad if someone uploaded this package for me. Kind regards Ali MEZGANI
Re: RFS: iulib (5th attempt)
Hi Charles,
2009/7/19 Charles Plessy :
> our tools do not invoke the build target twice in a row, but real people
> sometimes have a good reason to do. For instance, I tried to build iulib it
> did
> not work because I was missing dependancies, and when I installed them and
> called the build target again, it triggered the bug discussed above. A good
> makefile should be resilient to this.
How did you do this? Simply running
$ ./debian/rules build
a second time, produces:
dh --with quilt build
and dh knows it isn't necessary and doesn't build.
> Talking about dependancies, since there are only three versions of the libtool
> package in circulation, you can probably depend on versions higher than Lenny.
> Alternatively, you can support both: it looks easy. It would be especially
> useful if you think that there are chances your package would be backported.
> If the scons migration for the 0.4 version implies to drop libtool, you do not
> need to put too much energy into this…
The latter. I want to get a clean package into the NEW queue, and
while it sits there, I'll work on v0.4.
> A much more problematic issue is the binary dependancies of libiulib0. You
> have
> devised a long list by hand, but it is not accurate for Sid, which is the
> target of your package. There is at least one error: libavcodec51 does not
> exist there. Do you have evidence that ${shlibs:Depends} is not enough?
No. I've removed everything but ${shlibs:Depends}, ${misc:Depends}
> Probably. Maybe you can submit a whishlist bug, or if you have time, try to
> write such a check.
Done[1,2].
> PS: do you know how to write a symbols control file? (me not).
dpkg-gensymbols -O -plibiulib0
gives me output... But how to know I am using it correctly...
I've uploaded the updated package to mentors.
Regards
Jeff
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=537768
[2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=537769
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Re: shell kung-fu with set -e, return codes and i/o redirection in while read ... loop
In <20090719235708.gb22...@resivo.wgnet.de>, Jonas Meurer wrote:
>- in cryptdisks_{start|stop} only one device is setup anyway. here I
> simply don't use set -e and check for the error code instead.
While I understand your goal here, I think you should try and accomplish it
while leaving the entire script "set -e". It helps prevent errors from
cascading. Even if you are checking return values for everything now, you
might not be so disciplined with changes in the future.
--
Boyd Stephen Smith Jr. ,= ,-_-. =.
b...@iguanasuicide.net ((_/)o o(\_))
ICQ: 514984 YM/AIM: DaTwinkDaddy `-'(. .)`-'
http://iguanasuicide.net/\_/
signature.asc
Description: This is a digitally signed message part.
RFS: dtrx (updated package)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dear mentors, I am looking for a sponsor for the new version 6.5-1 of my package "dtrx". It builds these binary packages: dtrx - intelligently extract multiple archive types The package appears to be lintian clean. The upload would fix these bugs: 526996 The package can be found on mentors.debian.net: - - URL: http://mentors.debian.net/debian/pool/main/d/dtrx - - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - - dget http://mentors.debian.net/debian/pool/main/d/dtrx/dtrx_6.5-1.dsc I would be glad if someone uploaded this package for me. Kind regards Miguelangel Jose Freitas Loreto -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkpkge0ACgkQEj/fBl4PScRrugCdF2ZKVEO7Pb++DbvKMiSxE/u3 /4sAn1/mtPJutV/JotUTBqlm2EXp920K =Qr8K -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
