Bug#683184: RFS: suckless-tools/39-1 [ITA]
This is only a very rudimentary review. I don't have time to review this
properly for the time being. Anybody else is welcome to do it for me. :)
* Vasudev Kamath kamathvasu...@gmail.com, 2012-07-29, 22:27:
dget -x
http://mentors.debian.net/debian/pool/main/s/suckless-tools/suckless-tools_39-1.dsc
More information about hello can be obtained from http://www.example.com.
Changes since the last upload:
suckless-tools (39-1) unstable; urgency=low
It doesn't look like it's suitable for wheezy, so please make it
s/unstable/experimental/.
[ Michael Stummvoll ]
* New Maintainer (Closes: #647090)
[0]
[ Vasudev Kamath ]
* Imported new version of slock (Closes: #667796)
This fixes a security issue, so please mention CVE number in the
changelog.
+ Added myself as maintainer and Michael Stummvoll as Uploader
I'd merge this item with [0].
+ Added dependency on dpkg-dev = 1.16.1.1
It'd nice to mention why it's needed.
+This package contains a set of tools from suckless community as
+single package. To build the package you need to create source
+tarballs of individual tool component involved. This can be done
+by running following command from suckless-tools folder
+
+ fakeroot debian/rules get-orig-source
Why fakeroot?
+Forwarded: no|not-needed|url proving that it has been forwarded
Please choose one. :)
+-$ $(tabbed -d /tmp/tabbed.xid); urxvt -embed $(/tmp/tabbed.xid);
++$ $(tabbed \-d /tmp/tabbed.xid); urxvt \-embed $(/tmp/tabbed.xid);
If you're fixing this, please also fix the security hole (insecure use
of temporary files).
+override_dh_installdocs:
+ dh_installdocs
+ for TOOL in $(TOOLS); \
+ do \
+ cp $${TOOL}/README
$(D)/usr/share/doc/suckless-tools/README.$${TOOL}; \
+ done
This for loop needs a set -e; see Policy §4.6. I see other parts of
debian/rules has the same problem.
+ @cd /tmp
+ @tar -cvf - suckless-tools_$(CURRENT_VERSION) 2 /dev/null | gzip -9
../suckless-tools_$(CURRENT_VERSION).orig.tar.gz
+ @rm -rf /tmp/suckless-tools_$(CURRENT_VERSION)
This creates temporary files insecurely.
--
Jakub Wilk
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120730084811.ga6...@jwilk.net
Bug#677379: New upstream version.
Changes since the last upload: * Imported Upstream version 0.1.2 * Cleaned file licenses -- Grzegorz Kolorz 'kAjKo' -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120730105217.GA9111@titan
Bug#677379: New upstream version.
Grzegorz Kolorz gkol...@gmail.com writes: * Imported Upstream version 0.1.2 * Cleaned file licenses Just curious: 1) What software uses this library? I don't see any reverse dependencies. 2) Is the upstream planning to have a public version control system? -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/84vch5qzfm@sauna.l.org
Re: Make CDBS and debhelper not build one binary package
On 2012-07-29 10:16, P. J. McDermott wrote: Is there a way to make CDBS and its debhelper class not build a particular binary package? With debhelper alone, I'd just use the -N/--no-package option. I've tried adding that option to DH_OPTIONS, I've realized that I had forgotten to export DH_OPTIONS... I've got this working now; sorry for the noise. :) and I've tried overriding DEB_ALL_PACKAGES after the CDBS class include lines as follows (where binary-package is the package I don't want to build): DEB_ALL_PACKAGES := $(subst binary-package,,$(strip $(shell \ dh_listpackages 2/dev/null || dh_listpackages))) Though I'm still not sure why that didn't work. Oh well. -- P. J. McDermott(_/@\_),--. http://www.pehjota.net/ o o o/ oo \ http://www.pehjota.net/contact.html o \ `-/| |. o o o~v/_\--/_/ -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/50167b4d.3020...@nac.net
Processed: retitle to RFS: x52pro/0.1.2-1
Processing commands for cont...@bugs.debian.org: retitle 677379 RFS: x52pro/0.1.2-1 Bug #677379 [sponsorship-requests] RFS: x52pro/0.1.1-3 Changed Bug title to 'RFS: x52pro/0.1.2-1' from 'RFS: x52pro/0.1.1-3' stop Stopping processing here. Please contact me if you need assistance. -- 677379: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=677379 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.134366460128327.transcr...@bugs.debian.org
Bug#683184: RFS: suckless-tools/39-1 [ITA]
On 10:48 Mon 30 Jul , Jakub Wilk wrote:
This is only a very rudimentary review. I don't have time to review
this properly for the time being. Anybody else is welcome to do it
for me. :)
Thanks.. Wonder how many more silly stuffs show up on actual review
;-)
* Vasudev Kamath kamathvasu...@gmail.com, 2012-07-29, 22:27:
dget -x
http://mentors.debian.net/debian/pool/main/s/suckless-tools/suckless-tools_39-1.dsc
More information about hello can be obtained from http://www.example.com.
Changes since the last upload:
suckless-tools (39-1) unstable; urgency=low
It doesn't look like it's suitable for wheezy, so please make it
s/unstable/experimental/.
Done! When it should be moved to unstable? After wheezy release? It
does contains some new version of tools so asking.
[ Michael Stummvoll ]
* New Maintainer (Closes: #647090)
[0]
[ Vasudev Kamath ]
* Imported new version of slock (Closes: #667796)
This fixes a security issue, so please mention CVE number in the
changelog.
Done
+ Added myself as maintainer and Michael Stummvoll as Uploader
I'd merge this item with [0].
Done
+ Added dependency on dpkg-dev = 1.16.1.1
It'd nice to mention why it's needed.
Did it :-)
+This package contains a set of tools from suckless community as
+single package. To build the package you need to create source
+tarballs of individual tool component involved. This can be done
+by running following command from suckless-tools folder
+
+ fakeroot debian/rules get-orig-source
Why fakeroot?
Well by habit wrote it :-).. Now fixed
+Forwarded: no|not-needed|url proving that it has been forwarded
Please choose one. :)
Ouch.. I will end up doing one or other copy paste error. Fixed
+-$ $(tabbed -d /tmp/tabbed.xid); urxvt -embed $(/tmp/tabbed.xid);
++$ $(tabbed \-d /tmp/tabbed.xid); urxvt \-embed $(/tmp/tabbed.xid);
If you're fixing this, please also fix the security hole (insecure
use of temporary files).
Done too
+override_dh_installdocs:
+dh_installdocs
+for TOOL in $(TOOLS); \
+do \
+cp $${TOOL}/README
$(D)/usr/share/doc/suckless-tools/README.$${TOOL}; \
+done
This for loop needs a set -e; see Policy §4.6. I see other parts
of debian/rules has the same problem.
As discussed in IRC the SHELL := sh -e on top of rule file should
handle this.
+@cd /tmp
+@tar -cvf - suckless-tools_$(CURRENT_VERSION) 2 /dev/null | gzip -9
../suckless-tools_$(CURRENT_VERSION).orig.tar.gz
+@rm -rf /tmp/suckless-tools_$(CURRENT_VERSION)
This creates temporary files insecurely.
Fixed.
Instead of pushing new package to mentors I've pushed my changes to
collab-maint repository [1] Hope that is fine with you if not let me know
[1] git.debian.org:/git/collab-maint/suckless-tools.git
Thanks for the review.
--
Vasudev Kamath
http://copyninja.info
Connect on ~friendica: copyninja@{frndk.de | vasudev.homelinux.net}
IRC nick: copyninja | vasudev {irc.oftc.net | irc.freenode.net}
GPG Key: C517 C25D E408 759D 98A4 C96B 6C8F 74AE 8770 0B7E
signature.asc
Description: Digital signature
Processed: Close sponsorship requests
Processing commands for cont...@bugs.debian.org: close 672981 Bug #672981 [sponsorship-requests] RFS: eiskaltdcpp/2.2.7-1 (updated) -- Direct Connect and Advanced Direct Connect client Marked Bug as done close 672290 Bug #672290 [sponsorship-requests] RFS: uhub/0.4.0-1 (updated) -- High performance Advanced Direct Connect p2p hub Marked Bug as done close 673457 Bug #673457 [sponsorship-requests] RFS: psi-plus-i18n/0.15.5338.6-1 [ITP] -- translation files for Psi+ Marked Bug as done thanks Stopping processing here. Please contact me if you need assistance. -- 672290: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=672290 672981: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=672981 673457: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=673457 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.134368190626037.transcr...@bugs.debian.org
Bug#683336: RFS: ninja-build/120508+git638b033
Package: sponsorship-requests Severity: normal [important for RC bugs, wishlist for new packages] Dear mentors, I am looking for a sponsor for my package ninja-build * Package name: ninja-build Version : 120508+git638b033 Upstream Author : Google * URL : http://martine.github.com/ninja/ * License : Apache v2 Section : devel It builds those binary packages: ninja-build - small build system closest in spirit to Make To access further information about this package, please visit the following URL: http://mentors.debian.net/package/ninja-build Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/n/ninja-build/ninja-build_120508+git638b033.dsc More information about hello can be obtained from http://www.example.com. Changes since the last upload: ninja-build (120508+git638b033) unstable; urgency=low * Initial release. (Closes: #68) Regards, Gary Kramlich
Processed: retitle to RFS: m2m-aligner/1.1-1 [ITP] -- many-to-many alignments for string transduction
Processing commands for cont...@bugs.debian.org: retitle 663455 RFS: m2m-aligner/1.1-1 [ITP] -- many-to-many alignments for string transduction Bug #663455 [sponsorship-requests] RFS: m2m-aligner/1.0-1 [ITP] -- many-to-many alignments for string transduction Changed Bug title to 'RFS: m2m-aligner/1.1-1 [ITP] -- many-to-many alignments for string transduction' from 'RFS: m2m-aligner/1.0-1 [ITP] -- many-to-many alignments for string transduction' stop Stopping processing here. Please contact me if you need assistance. -- 663455: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=663455 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.134370840016645.transcr...@bugs.debian.org
Processed: ninja-build: block ITP 683332 by RFS 683336
Processing commands for cont...@bugs.debian.org: block 683332 by 683336 Bug #683332 [wnpp] ITP: ninja-build -- small build system closest in spirit to Make Bug #68 [wnpp] ITP: ninja-build -- small build system closest in spirit to Make 683332 was not blocked by any bugs. 683332 was not blocking any bugs. Added blocking bug(s) of 683332: 683336 68 was not blocked by any bugs. 68 was not blocking any bugs. Added blocking bug(s) of 68: 683336 stop Stopping processing here. Please contact me if you need assistance. -- 683332: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=683332 68: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=68 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.13437138577956.transcr...@bugs.debian.org
