Re: Bug#731466: RFS - policyd-weight/0.1.15.2-6
On Tue, 10 Dec 2013 07:14:02 +0100, Werner Detter wrote: -. /lib/init/vars.sh . /lib/lsb/init-functions You'll have to explain to me why this is right? /lib/init/vars.sh still exists and appears to contain default values. Although it does seem the the policyd-weight init script doesn't use of them - maybe that's the point? Right, but I had the lintian warning: init.d-script-call-internal-API before with . /lib/init/vars.sh in the init-script. I've googled around and found this bugreport: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=710559 So, I took it out. ... where Niels says that the lintian tag was premature and he deactivated it in lintian git for the time being. Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of the Free Software Foundation Europe `- NP: Rigmor Gustafsson: Empty Hearts signature.asc Description: Digital signature
Re: Bug#731466: RFS - policyd-weight/0.1.15.2-6
Am 10.12.13 09:04, schrieb gregor herrmann: On Tue, 10 Dec 2013 07:14:02 +0100, Werner Detter wrote: -. /lib/init/vars.sh . /lib/lsb/init-functions You'll have to explain to me why this is right? /lib/init/vars.sh still exists and appears to contain default values. Although it does seem the the policyd-weight init script doesn't use of them - maybe that's the point? Right, but I had the lintian warning: init.d-script-call-internal-API before with . /lib/init/vars.sh in the init-script. I've googled around and found this bugreport: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=710559 So, I took it out. ... where Niels says that the lintian tag was premature and he deactivated it in lintian git for the time being. Yes .. but .. Josh states: /etc/init.d/skeleton is wrong; only sysvinit's own internal scripts should use vars.sh directly. Other scripts should source /lib/lsb/init-functions and use the log_* functions. Yes tag was premature and deactivated BUT will it be reenabled if /etc/init.d/skeleton is fixed? I can take it back in - no problem - but then i get the mentioned lintian-warning init.d-script-call-internal-API so what to do here now? Cheers, Werner -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/52a6e584.5010...@aloah-from-hell.de
Re: Bug#731466: RFS - policyd-weight/0.1.15.2-6
On Tue, 10 Dec 2013 10:57:24 +0100, Werner Detter wrote: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=710559 So, I took it out. deactivated it in lintian git for the time being. Yes .. but .. Josh states: /etc/init.d/skeleton is wrong; only sysvinit's own internal scripts should use vars.sh directly. Other scripts should source /lib/lsb/init-functions and use the log_* functions. Right, there is a problem somewhere but this needs to be fixed before, in my understanding. Yes tag was premature and deactivated BUT will it be reenabled if /etc/init.d/skeleton is fixed? Probably, as soon as there is a solution for the actual issue. I can take it back in - no problem - but then i get the mentioned lintian-warning init.d-script-call-internal-API so what to do here now? I left it in in a script of mine and just ignored the lintian warning, knowing that it will go away as soon as someone finds the time to upload lintian. Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of the Free Software Foundation Europe `- BOFH excuse #34: (l)user error -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20131210102937.ga5...@colleen.colgarra.priv.at
Re: Bug#731466: RFS - policyd-weight/0.1.15.2-6
+++ Werner Detter [2013-12-10 10:57 +0100]: Am 10.12.13 09:04, schrieb gregor herrmann: On Tue, 10 Dec 2013 07:14:02 +0100, Werner Detter wrote: -. /lib/init/vars.sh . /lib/lsb/init-functions You'll have to explain to me why this is right? /lib/init/vars.sh still exists and appears to contain default values. Although it does seem the the policyd-weight init script doesn't use of them - maybe that's the point? Right, but I had the lintian warning: init.d-script-call-internal-API before with . /lib/init/vars.sh in the init-script. I've googled around and found this bugreport: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=710559 So, I took it out. ... where Niels says that the lintian tag was premature and he deactivated it in lintian git for the time being. Yes .. but .. Josh states: /etc/init.d/skeleton is wrong; only sysvinit's own internal scripts should use vars.sh directly. Other scripts should source /lib/lsb/init-functions and use the log_* functions. Yes tag was premature and deactivated BUT will it be reenabled if /etc/init.d/skeleton is fixed? I can take it back in - no problem - but then i get the mentioned lintian-warning init.d-script-call-internal-API so what to do here now? Given that the init script doesn't use any of the variables from vars.sh there is no reason to use an interface that is now deprecated to do nothing, so I agree that taking this line out is the right thing to do. The 'waiting for a fix' part is only relvaant if your script actually _is_ using those vars, IMHO. So I'll upload as-is. Wookey -- Principal hats: Linaro, Emdebian, Wookware, Balloonboard, ARM http://wookware.org/ -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20131210143301.gj1...@stoneboat.aleph1.co.uk
Re: Bug#731466: RFS - policyd-weight/0.1.15.2-6
Hi Wookey, So I'll upload as-is. Thank you. Cheers, Werner -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/52a727f4.2090...@aloah-from-hell.de
Correcting a version number
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dear mentors, I have realised that in an earlier package upload, I made a blunder with regards the version of the package. The package was versioned as 0.5b0-1, though I somehow missed, despite testing the watch file that this should have been 0.5~b0-1. I have seen some discussion on correcting the version number, either by using an epoch or by adding an additional part to the version number. - From what I can see, the only way to fix the version number here is to use an epoch, but from what I've this should be avoided if possible, so does anyone have any other suggestion on how to correct this version number? Regards Daniel Lintott -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBAgAGBQJSp1S6AAoJEMw/9yOWzAkJ5T0H/jq9Hnma75BsYIEPX+8AvuPa 0BA+pVS2rjeaE8xticH2HROAMSUNUPgf9rVELeIvZ8Kh1ZUMtmtrXhYq0wurUSMX SasPhsNcb0tDu3oLBescufStkcInK732WXpGiIc6t0P3T+G77k5FEvQnrOqq6EX2 jafRnnm7SeZCmlIhzasyyBTRV+y0AhoJiBcG3w2znQF3npHtNmZSkqZ9Svfuq/RV m5ttiXxwokR6DbcWdIhMzQSMQ+5KyrjXLdyXPW238tbITT3Up34iq5HOYgyKL5rr xxa1suI9ebaxad79i3cUIEwNhlyZPxJHJ8Qyxgw3Uehg/8WQgJXIc2SGuu0SqEY= =DzI8 -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/52a754bb.8090...@serverb.co.uk
Re: Correcting a version number
Daniel Lintott dan...@serverb.co.uk wrote: [..] I have realised that in an earlier package upload, I made a blunder with regards the version of the package. The package was versioned as 0.5b0-1, though I somehow missed, despite testing the watch file that this should have been 0.5~b0-1. I have seen some discussion on correcting the version number, either by using an epoch or by adding an additional part to the version number. - From what I can see, the only way to fix the version number here is to use an epoch, but from what I've this should be avoided if possible, so does anyone have any other suggestion on how to correct this version number? [...] Hello, I do not think there are any other reasonable[1] possibilities available. You can either use an epoch (forever) or live with a ugly version number for some time. Personally I would use an ugly version number for the 0.5 release: Upstream Debian 0.5b0 0.5b0-1 0.5b1 0.5b1-1 ... 0.5rc1 0.5rc1-1 ... 0.50.5+rel-1 0.6b0 0.6~b1 (Please doublcheck the sorting with dpkg --compare-versions, I might have made an error, too. ;-) hth, cu Andreas [1] renaming the package does not count. -- `What a good friend you are to him, Dr. Maturin. His other friends are so grateful to you.' `I sew his ears on from time to time, sure' -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/rt3kna-hp4@argenau.downhill.at.eu.org
Re: Correcting a version number
Hi, I have realised that in an earlier package upload, I made a blunder with regards the version of the package. Where is that package now? On mentors, or in Debian? -nik -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/5b5cf785-3895-4d4b-9ed2-66f07fe50...@email.android.com
Re: Correcting a version number
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/12/13 18:59, Dominik George wrote: Hi, I have realised that in an earlier package upload, I made a blunder with regards the version of the package. Where is that package now? On mentors, or in Debian? -nik The package is in Debian [1] and the watch file status [2] [1] http://packages.debian.org/sid/vpcs [2] http://qa.debian.org/cgi-bin/watch?pkg=vpcs_0.5b0-1 Regards Daniel Lintott -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBAgAGBQJSp2i1AAoJEMw/9yOWzAkJIywH/jRYWhUHJ2/CkUiGOCZT+4HI xI333jvqMHDYQUHEaic+Odhvt0MUmyZZ3xr1bUfIRlVTZuSsDCXqwwoDosxrWNDF slyOAEWpVW3bhzmsZiq2EwvEtKFRpv12i1wgRTcmEp4TnETTkehnwP4OnE3T8Anm gqLlsU/6xXnvyuL2yiuL/6HV+ZyBcKGPsgMgqtgTl1mGJ5Re1VIZdUl9g1WnbpIR R7XXF7U1o3C+eaBGJOaM8fbnNcLtxU6fanTZJ0DX+z0suP8XhZi595Lno6st99im UXnrO3fHxH0ncODFPJJ7KQl2sHxzaXHmvlpTwbcN8pt8LGmyE7NdUQR3YhQhkA4= =JPFw -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/52a768b5.9070...@serverb.co.uk
Re: Correcting a version number
[2] http://qa.debian.org/cgi-bin/watch?pkg=vpcs_0.5b0-1 In that special case, I'd even say your versioning mistake is good because upstream's ~ notation is a mess. That char is reserved for Debian ;) (yes, that's false and not so humble ;))! Why not keep your version numbering as it is and use version mangling in the watch file instead to match.upstream? -nik -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/f297d82e-184e-4ea3-83ef-d39ddd599...@email.android.com
Re: Correcting a version number
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/12/13 19:21, Dominik George wrote: [2] http://qa.debian.org/cgi-bin/watch?pkg=vpcs_0.5b0-1 In that special case, I'd even say your versioning mistake is good because upstream's ~ notation is a mess. That char is reserved for Debian ;) (yes, that's false and not so humble ;))! Why not keep your version numbering as it is and use version mangling in the watch file instead to match.upstream? -nik The output from the above seems a little confusing (to me) as upstream don't use ~ which can be seen in the upstream-url, as well as on the upstream sf page [1] It's entirely possible that there is also a mistake in the watch file... which wouldn't help matters. Regards Daniel [1] http://sourceforge.net/projects/vpcs/files/0.5/beta/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBAgAGBQJSp2sUAAoJEMw/9yOWzAkJxoEH/3PoECk57dURUGsFKj0wyWP9 ee4vhNqruYY+qWYYFssBBxM1khx0JyRb/m8L8qIBYKjSbuE8ycnCE6xDpseX7ZC/ kvDESKkjQC3qz9AVd+/FgKIScMMIlGI+31DRS/r2EsBhyIEQMywmooOMG0Cwt6So wh85z6n8ySWZ/pUJAv0mOkzhi+avvX2gaiV55cLiV8HiDdpldQ1oXPpPtt+KmQ8v Jg3TeLVKkHH9ZdbVXPqkozi7pql14C18judWEfO16hNWLMKFvi3Ge3IvdGxXWOyG 37gfSVD8PujpnQfMHE8KikKl3q7hXdqQsz6CQbmH5h6uValYMKfEgrePdXFdS/I= =op0c -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/52a76b14.5090...@serverb.co.uk
