Bug#863309: curvedns RFS

[Stéphane Neveu]

Gianfranco, Philippe,

I've just pushed my updated package on mentors again, because my ssh
key isn't working on alioth yet...

>> lets review:
>>
>>
>> debian/copyright has some GPL-2 packaging, why not just take the same
>> upstream license
>>
>> for the packaging?
>>

license-reconcile told me to do so but following your advice I've
changed everything to BSD-2-clause.


>>
>> lots of useless files?
>>
>> debian/README.source
>>
>> debian/README.Debian
>>
>> debian/service
>> debian/env
>>
>> (and so on)
>>

yes, all those files are deleted now sorry.

>>
>> and lots of debian files, e.g. is debian/dirs needed?
>>
>> (usually it is a task for the upstream build system to install
>> directories)
>>

Yes no automated install.

>> override_dh_installinit:
>> dh_installinit
>>

Sorry deleted.

>>
>>
>> I will continue the review after the above is fixed
>>
>>
>> some CPPFLAGS seems missing?
>>
>> http://debomatic-amd64.debian.net/distribution#unstable/curvedns/0.87-1/blhc
>>

Yes I still have this issue, I made a patch but it doesn't seem to fix blhc.

>> and some stuff is uselessly installed in the end user system (e.g. README
>> files)
>>
>>
>> (the packaging looks good, but I prefer less files to review, if
>> something can be just
>> deleted)
>>
>> G.
>

Thank you Gianfranco !

>
> Little review:
>
>
> $ splint -I . +posixlib -preproc -standard *.c
> ... And one memory leak :-/
>

Philippe, like we said no need to patch it since it only affect init cache.

> $ env PERL5OPT=-m-lib=. license-reconcile
> Copyright mismatch: File
> nacl/crypto_scalarmult/curve25519/donna_c64/smult.c: Trying to match 'Google
> Inc.' against 'Lieuwe Jan Koning' but it does not look like a good match. at
> /usr/share/perl5/Debian/LicenseReconcile/App.pm line 222,  line 3.
>

Google Inc. is added but license-reconcile isn't happy now for
debian/* with my BSD-2-clause license.

>
> $ find . -type d \( -iname .bzr -o -iname .git -o -iname .hg -o -iname .svn
> -o -iname CVS -o -iname RCS -o -iname SCCS -o -iname _MTN -o -iname _darcs
> -o -iname .pc -o -iname .cabal-sandbox -o -iname .cdv -o -iname .metadata -o
> -iname CMakeFiles -o -iname _build -o -iname  _sgbak -o -iname
> autom4te.cache -o -iname blib -o -iname cover_db -o -iname node_modules -o
> -iname '~.dep' -o -iname '~.dot' -o -iname '~.nib' -o -iname '~.plst' \)
> -prune -o -type f ! \( -iname '*.bak' -o  -iname '*.swp' -o -iname '#.*' -o
> -iname '#*#' -o -iname 'core.*' -o -iname '*~' -o -iname '*.gif' -o -iname
> '*.jpg' -o -iname '*.jpeg' -o  -iname '*.png' -o -iname '*.min.js' -o -iname
> '*.js.map' -o -iname '*.js.min' -o -iname '*.min.css' -o -iname '*.css.map'
> -o -iname  '*.css.min' -o -iname '*.wav' \) -exec env PERL5OPT=-m-lib=.
> spellintian --picky {}
> 
>
> (thanks to Paul Wise for this last line :) )
>
> Didn't try lintian/piuparts/blhc...
>

No more errors except in spelling.patch :)

> Cheers,
> --
> Philippe.


I also need to work a bit on curvedns.service to add some security features !


Stephane

Bug#864626: RFS: visual-fill-column/1.11-1 [ITP]

[Sean Whitton]

Hello Nicholas,

On Tue, Jun 13, 2017 at 09:49:33PM -0400, Nicholas D Steeves wrote:
> Brilliant, in that case no one would have been bothered by this
> redundant RFS! ;-) Would you please grant DM permissions for
> visual-fill-column?

It would be best to ask the person who uploaded the package.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#864622: RFS: rich-minority/1.0.1-1 [ITP]

[Sean Whitton]

Hello Nicholas,

On Tue, Jun 13, 2017 at 09:39:43PM -0400, Nicholas D Steeves wrote:
> Phase four: Do you think that it would be useful to have
> d/package.convert-to-info, d/package.convert-to-text, etc?  This would
> allow a plain d/rules.

This probably wouldn't work because each conversion will probably need
particular options and fixups.  I also doubt the debhelper maintainers
would want to add those files.

> Alternatively, it might be a better use of time to just write a
> Makefile to generate the docs for each package, and then submit those
> to upstreams.  What do you think?
> [...]
> What do you think?  Does this sound like a good proposal?  When should
> I email pkg-emacsen?  After Stretch is released?

As a rule of thumb it's better to have things merged upstream.

I don't think we need any kind of team policy on this.  It's not an
Emacs-specific issue.  Packagers can handle the documentation as they
would for any other package.  And for elpa-* packages, it's almost
always just a README, which can remain in Org/Markdown/plain text.

> Hmm, so the question comes down to how committed and able I am to get
> rich-minority (and smart-mode-line for that matter) to work with a
> potential default of emacs26 for Buster?

Chances are it will Just Work.  New releases of Emacs do not break very
many things.  So I would upload it to unstable once you've run it
locally for a week or so.

> Most packages have a fairly short "long description" so I've been
> operating under the assumption that it is supposed to be less than 25
> lines long, with 24 lines preferred.

You wouldn't want it to be pages and pages.  But feel free to go over 25
lines.

> > diminish.el works like this:
> > 
> > (diminish 'auto-fill-function)
> > 
> > That's it.  Clearly simpler.
> 
> Does this hide "Fill" from the modeline?  Does a subsequent
> 
> (diminish 'flyspell-mode)
> 
> concatenate Fly|Flyspell to the list of minor modes that will be
> hidden?

Yes.

> For now, do you think I should create a README.Debian with these
> examples or wait for upstream to merge them?

I don't think you need to do either.  Just mention that it's meant to be
a more flexible/improved version of diminish.el.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#863309: curvedns RFS

[phil]

On 2017-06-14 11:50, Gianfranco Costamagna wrote:



lets review:


debian/copyright has some GPL-2 packaging, why not just take the same
upstream license

for the packaging?


lots of useless files?

debian/README.source

debian/README.Debian

debian/service
debian/env

(and so on)


and lots of debian files, e.g. is debian/dirs needed?

(usually it is a task for the upstream build system to install 
directories)


override_dh_installinit:
dh_installinit


this seems useless? :)

I will continue the review after the above is fixed


some CPPFLAGS seems missing?
http://debomatic-amd64.debian.net/distribution#unstable/curvedns/0.87-1/blhc

and some stuff is uselessly installed in the end user system (e.g. 
README files)



(the packaging looks good, but I prefer less files to review, if
something can be just
deleted)

G.


Little review:


$ splint -I . +posixlib -preproc -standard *.c
... And one memory leak :-/

$ env PERL5OPT=-m-lib=. license-reconcile
Copyright mismatch: File 
nacl/crypto_scalarmult/curve25519/donna_c64/smult.c: Trying to match 
'Google Inc.' against 'Lieuwe Jan Koning' but it does not look like a 
good match. at /usr/share/perl5/Debian/LicenseReconcile/App.pm line 222, 
 line 3.



$ find . -type d \( -iname .bzr -o -iname .git -o -iname .hg -o -iname 
.svn -o -iname CVS -o -iname RCS -o -iname SCCS -o -iname _MTN -o -iname 
_darcs -o -iname .pc -o -iname .cabal-sandbox -o -iname .cdv -o -iname 
.metadata -o -iname CMakeFiles -o -iname _build -o -iname  _sgbak -o 
-iname autom4te.cache -o -iname blib -o -iname cover_db -o -iname 
node_modules -o -iname '~.dep' -o -iname '~.dot' -o -iname '~.nib' -o 
-iname '~.plst' \) -prune -o -type f ! \( -iname '*.bak' -o  -iname 
'*.swp' -o -iname '#.*' -o -iname '#*#' -o -iname 'core.*' -o -iname 
'*~' -o -iname '*.gif' -o -iname '*.jpg' -o -iname '*.jpeg' -o  -iname 
'*.png' -o -iname '*.min.js' -o -iname '*.js.map' -o -iname '*.js.min' 
-o -iname '*.min.css' -o -iname '*.css.map' -o -iname  '*.css.min' -o 
-iname '*.wav' \) -exec env PERL5OPT=-m-lib=.  spellintian --picky {}



(thanks to Paul Wise for this last line :) )

Didn't try lintian/piuparts/blhc...

Cheers,
--
Philippe.

Bug#863278: RFS: usbguard/0.7.0-1

[gustavo panizzo]

Hi

I'll review the package this weekend

On June 14, 2017 6:51:06 PM GMT+08:00, Muri Nicanor  wrote:
>control: tags -1 - moreinfo
>
>hi,
>
>On 06/01/2017 12:07 PM, gustavo panizzo wrote:
>> the package builds fine with pbuilder but tests fails when i try to
>> build using sbuild.
>> 
>> FAIL UseCase/001_cli_policy.sh (exit status: 1)
>this fails if there is already a running usbguard instance- when i
>stopped mine the test ran fine
>
>
>> perhaps usbguard should build-depend on sudo?
>> 
>> UseCase/002_cli_devices.sh.log:  + sudo -n dd bs=4096 count=1
>> if=/dev/zero of=/tmp/usbguard_disk
>> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line
>81:
>> sudo: command not found
>> UseCase/002_cli_devices.sh.log:  + sudo -n modprobe dummy_hcd
>> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line
>82:
>> sudo: command not found
>> UseCase/002_cli_devices.sh.log:  + sudo -n rmmod g_mass_storage
>> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line
>83:
>> sudo: command not found
>> UseCase/002_cli_devices.sh.log:  + sudo -n modprobe g_mass_storage
>> file=/tmp/usbguard_disk iSerialNumber=555666111
>> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line
>84:
>> sudo: command not found
>> UseCase/002_cli_devices.sh.log:  + '[' 127 -ne 0 ']'
>> UseCase/002_cli_devices.sh.log:  + exit 77
>> UseCase/002_cli_devices.sh.log:  SKIP UseCase/002_cli_devices.sh
>(exit
>> status: 77)
>
>this test is now disabled (skipped), as the neede kernel modules needed
>are not part of debian default kernel
>
>> this should be easy to fix
>> 
>> Packaging/spell-check.sh.log:  Skipping test because some dependecies
>> are missing
>> Packaging/spell-check.sh.log:  ASPELL: Packaging/spell-check.sh.log: 
>> PANDOC: /usr/bin/pandoc
>> Packaging/spell-check.sh.log:  SKIP Packaging/spell-check.sh (exit
>> status: 77)
>fixed.
>
>i've uploaded a new version to mentors,
>
>cheers,
>muri

-- 
IRC: gfa
GPG: 0x44BB1BA79F6C6333

Sent from my mobile. Please excuse my brevity and typos.

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

control: tags -1 - moreinfo

hi,

On 06/01/2017 12:07 PM, gustavo panizzo wrote:
> the package builds fine with pbuilder but tests fails when i try to
> build using sbuild.
> 
> FAIL UseCase/001_cli_policy.sh (exit status: 1)
this fails if there is already a running usbguard instance- when i
stopped mine the test ran fine


> perhaps usbguard should build-depend on sudo?
> 
> UseCase/002_cli_devices.sh.log:  + sudo -n dd bs=4096 count=1
> if=/dev/zero of=/tmp/usbguard_disk
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 81:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + sudo -n modprobe dummy_hcd
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 82:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + sudo -n rmmod g_mass_storage
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 83:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + sudo -n modprobe g_mass_storage
> file=/tmp/usbguard_disk iSerialNumber=555666111
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 84:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + '[' 127 -ne 0 ']'
> UseCase/002_cli_devices.sh.log:  + exit 77
> UseCase/002_cli_devices.sh.log:  SKIP UseCase/002_cli_devices.sh (exit
> status: 77)

this test is now disabled (skipped), as the neede kernel modules needed
are not part of debian default kernel

> this should be easy to fix
> 
> Packaging/spell-check.sh.log:  Skipping test because some dependecies
> are missing
> Packaging/spell-check.sh.log:  ASPELL: Packaging/spell-check.sh.log: 
> PANDOC: /usr/bin/pandoc
> Packaging/spell-check.sh.log:  SKIP Packaging/spell-check.sh (exit
> status: 77)
fixed.

i've uploaded a new version to mentors,

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#863309: curvedns RFS

[Gianfranco Costamagna]

control: owner -1 !

control: tags -1 moreinfo



>I'm looking for a sponsor for my curvedns package here :

>CurveDNS is an alternative for DNSSEC based on ECC curves.


nice

>be possible to become a member of pkg-security team ?


yes, please join the team


lets review:


debian/copyright has some GPL-2 packaging, why not just take the same upstream 
license

for the packaging?


lots of useless files?

debian/README.source

debian/README.Debian

debian/service
debian/env

(and so on)


and lots of debian files, e.g. is debian/dirs needed?

(usually it is a task for the upstream build system to install directories)

override_dh_installinit:
dh_installinit


this seems useless? :)

I will continue the review after the above is fixed


some CPPFLAGS seems missing?
http://debomatic-amd64.debian.net/distribution#unstable/curvedns/0.87-1/blhc

and some stuff is uselessly installed in the end user system (e.g. README files)


(the packaging looks good, but I prefer less files to review, if something can 
be just
deleted)

G.