Bug#864428: RFS: bitfield/1.0.0-2 [ITP #864358]

2017-07-27 Thread Thomas Goirand
On 07/25/2017 04:05 PM, Roland Fehrenbacher wrote:
> Hi Vitalie,
> 
> I pick up the sponsoring process.
> 
>   V> Thank you very much for your help and comments.
> 
>> libbitfield$SOVERSION (shared library)
>> libbitfield-dev (development files)
> 
>   V> Done. Package name changed from 'bitfield' to 'libbitfield' and 
> SOVERSION is set
>   V> to 1, so we get:
>   V>   libbitfield1
>   V>   libbitfield-dev
> 
> This looks good now.
> 
>> If you don't have soversioning in place, then it probably means that your
>> software is still too volatile for you to think about a stable ABI / 
> API. If
>> that's the case, then it is not a good candidate for packaging in Debian 
> just yet.
> 
>   V> Done. SO-versioning (and versioning policy in general) has been set. ABI 
> /API
>   V> has been stabilized. Version (1.0.0) has been released.
> 
> That's also OK now.
> 
> Some further problems with the packaging:
> 
> - The link /usr/lib/x86_64-linux-gnu/libbitfield.so should go to
>   the libbitfield-dev package.
> - A shared library should have a debian/.symbols file
>   (see man dpkg-gensymbols).
> - The standards version should be updated to 4.0.0
> - The files README.{Debian,source} do not provide any real info. They should
>   be dropped until they contain something useful.
> - Please also remove the unrelated comments at the end of debian/rules
>   and the comments after the DH_VERBOSE line at the beginning.
> - The files debian/*.dirs are unnecessary . Please remove.
> 
> Please fix your package and ping me when done, so I can recheck.
> 
> Cheers,
> 
> Roland

Some other comments.

* The debian/changelog should:
- Contain only the first line.
- Have 1.0.0-1 (and not -3) as Debian release, as no previous version
were uploaded to Debian.

* Is there a reason why you're using debhelper 9 and not 10?

* I would recommend the use of "wrap-and-sort -t -a" (from devscripts)
to make debian/control cleaner.

* Your long description is a bit too short. When searching on a search
engine, I can see there's lots of this type of library. Your long
description doesn't tell where your library differentiate. Also, your
long description for the -dev package is only 2 lines long, which even
triggers a lintian warning that you should have seen. I would recommend
copying the long desc of libbitfield1 on top of the 2 lines of
libbitfield-dev as well.

* There's some lintian errors about spelling in man pages. Please fix them.

* Have you considered using DEB_BUILD_MAINT_OPTIONS=hardening=+all in
your debian/rules ? That's usually a good idea, and lintian also
complains about this.

* The .symbols file contains the debian revision. Typically, this
shouldn't be in, as the symbols are exported from the upstream version,
and wont change on debian revisions.

One last thing: what is your intention about packaging this library? Are
you going to upload a program that will actually use that lib? What is
the point in having it in Debian, and how will it be useful for our users?

I hope this helps.

Cheers,

Thomas Goirand (zigo)



Bug#859778: [supp...@mentors.debian.net: xtrs uploaded to mentors.debian.net]

2017-07-27 Thread Sean Whitton
Hello Branden,

On Thu, Jun 15, 2017 at 04:35:23PM +0100, Sean Whitton wrote:
> Please accept my apologies for letting this RFS sit for so long.  Thank
> you for all your work.  Looking forward to uploading it soon.
> 
> Here's a full review of dc84e1861798b3aba0969e2fe81a2431f2ee17de:

Any progress on this?

-- 
Sean Whitton


signature.asc
Description: PGP signature


Bug#869201: RFS: etcd/3.1.8+dfsg-2+nmu1 [NMU]

2017-07-27 Thread Andrey Rahmatullin
Control: tags -1 + moreinfo

On Wed, Jul 26, 2017 at 07:42:02PM +0530, Harish Sriram wrote:
> Here is the link to the uploaded package.
> 
> https://mentors.debian.net/debian/pool/main/e/etcd/etcd_3.1.8+dfsg-2
> +nmu1.dsc
No, the correct suffix for non-native package NMUs is .1, not +nmu1.
Please use dch --nmu and read
https://www.debian.org/doc/manuals/developers-reference/ch05.en.html#nmu
Besides, there are three RC bugs in the package while this NMU solves only
one. And you've even posted a patch to other one. While are you not
including it here?

-- 
WBR, wRAR


signature.asc
Description: PGP signature


Bug#869692: RFS: cyclograph/1.9.0-1

2017-07-27 Thread Andrey Rahmatullin
On Tue, Jul 25, 2017 at 07:41:12PM +0200, Federico Brega wrote:
> cyclograph (1.9.0-1) UNRELEASED; urgency=medium
> 
>   [ Federico Brega ]
You don't need to add your name in brackets if there are no other names.

>   * Debhelper compat version updated to 9
The current recommended level is 10.

And there are other changes (about python for example) that are not listed
in the changelog.

-- 
WBR, wRAR


signature.asc
Description: PGP signature


Bug#869926: RFS: oprofile/1.2.0-1 [ITP]

2017-07-27 Thread Andrey Rahmatullin
Why is this not using dh(1)?
It's also hardcoding /usr/lib and not the multiarch path in d/rules.
Why is changelog-move-to-git-log.patch needed?

There are a lot of strange and ancient things kept from the previous
Debian package, yet d/changelog doesn't have the old entries. OTOH
d/copyright doesn't list even the current maintainer or the current year.


-- 
WBR, wRAR


signature.asc
Description: PGP signature


Bug#869926: RFS: oprofile/1.2.0-1 [ITP]

2017-07-27 Thread Roberto Oliveira
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "oprofile"

Package name: oprofile
Version : 1.2.0-1
URL : http://oprofile.sourceforge.net/
License : GPL2
Section : devel

It builds those binary packages:
libjvmti-oprofile0 - system-wide profiler for Linux systems (Java
runtime library)
libopagent1 - system-wide profiler for Linux systems (opagent runtime library)
oprofile   - system-wide profiler for Linux systems

To access further information about this package, please visit the
following URL:
https://mentors.debian.net/package/oprofile


Alternatively, one can download the package with dget using this command:

dget -x 
https://mentors.debian.net/debian/pool/main/o/oprofile/oprofile_1.2.0-1.dsc


Regards,
Roberto Oliveira


Re: Bug#864428: RFS: bitfield/1.0.0-3 [ITP #864358]

2017-07-27 Thread Vitalie Ciubotaru
On 07/25/2017 11:05 PM, Roland Fehrenbacher wrote:
Hi Roland,

Thank you very much for your reply.

> Some further problems with the packaging:
> 
> - The link /usr/lib/x86_64-linux-gnu/libbitfield.so should go to the
>   libbitfield-dev package.
> - A shared library should have a debian/.symbols file
>   (see man dpkg-gensymbols).
> - The standards version should be updated to 4.0.0
> - The files README.{Debian,source} do not provide any real info. They should 
>   be dropped until they contain something useful.
> - Please also remove the unrelated comments at the end of debian/rules and
>   the comments after the DH_VERBOSE line at the beginning.
> - The files debian/*.dirs are unnecessary . Please remove.
> 
> Please fix your package and ping me when done, so I can recheck.

Fixed. Please, recheck.

  dget -x
https://mentors.debian.net/debian/pool/main/b/bitfield/bitfield_1.0.0-3.dsc

Best regards,

Vitalie Ciubotaru



Bug#864532: marked as done (RFS: tss2/1045-1 [ITP] -- IBM's TCG Software Stack (TSS))

2017-07-27 Thread Debian Bug Tracking System
Your message dated Thu, 27 Jul 2017 16:20:36 +
with message-id 
and subject line closing RFS: tss2/1045-1 [ITP] -- IBM's TCG Software Stack 
(TSS)
has caused the Debian Bug report #864532,
regarding RFS: tss2/1045-1 [ITP] -- IBM's TCG Software Stack (TSS)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
864532: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=864532
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---

Package: sponsorship-requests
Severity: wishlist




  Dear mentors,

  I am looking for a sponsor for my package "tss2"

 * Package name: tss2
   Version : 851-2
   Upstream Author : Ken Goldman 
 * URL :
http://sourceforge.net/projects/ibmtpm20tss/files/NotForUsers_DebianSource/
 * License : BSD
   Section : admin

 It builds those binary packages:

 libtss-dev - Development headers for IBM's TSS 2.0
 libtss0- Development library for IBM's TSS 2.0
 tss2  - IBM's TCG Software Stack (TSS) for TPM 2.0 and related utilities



  To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/tss2


  Alternatively, one can download the package with dget using this command:

  dget -x https://mentors.debian.net/debian/pool/main/t/tss2/tss2_851-2.dsc


  More information about tss2 can be obtained from

  https://sourceforge.net/projects/ibmtpm20tss.



  Changes since the last upload:


  * debian/rules:
- modified to use automatic debugging symbol packages.

  * debian/control:
- renamed the library package name and the development header package
name.
- removed the 'Priority: important' from the library package.
- added the 'Section: libdevel' to the development header package.
- removed the manual library dependencies.

 -- Hon Ching (Vicky) Lo   Fri, 09 Jun 2017
19:42:00 +




  Regards,
   Hon Ching (Vicky) Lo


--- End Message ---
--- Begin Message ---
Package tss2 version 1045-1 is in NEW now,
and the package at mentors is not newer (2017-07-26) than the package in NEW 
(2017-07-26),
so there is currently no package to sponsor.

https://ftp-master.debian.org/new/tss2_1045-1.html
https://mentors.debian.net/package/tss2

Please remove the package from mentors or mark it "needs sponsor = no".
If for some reason you need to replace the package in NEW,
then you can upload an updated package to mentors
and feel free to reopen this RFS 864532 or open a new RFS.--- End Message ---


Bug#869898: RFS: dtkcore/0.3.3-1 [ITP]

2017-07-27 Thread Boyuan Yang
2017-07-27 22:47 GMT+08:00 Liang Guo :
> On Thu, Jul 27, 2017 at 10:25 PM, ChangZhuo Chen  wrote:
>> On Thu, Jul 27, 2017 at 09:30:52PM +0800, Boyuan Yang wrote:
>>>   Alioth packaging repository:
>>>
>>> https://anonscm.debian.org/git/collab-maint/dtkcore.git
>>
>> * The copyrights in src/log/* are different from other files, please
>>   check copyright header of every file and list them in
>>   debian/copyright.
>>
>> * This symbol control file for libdtkcore.so is missing. Please help to
>>   add it.
>
> Agree, beside these problem, please notice:
>
> * debian/docs is empty please remove
>
> * Their should be an short license declaration in each *.{c,h,cpp}
> file.  For GPL3 license files, the short license should like this:
> 
> Copyright (C)   
>
> This program is free software: you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
> the Free Software Foundation, either version 3 of the License, or
> (at your option) any later version.
>
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
>
> You should have received a copy of the GNU General Public License
> along with this program.  If not, see .
>
> Please ask the original author to complete the license declaration.
>
> * debian/copyright file should obey DEP-5 proposal[1]
>
>
> [1] https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
>
>
> --
> Liang Guo
> http://guoliang.me/

Thank you all for detailed review with this package.

I have checked the packaging src again with check-all-the-things and
fixed all problems that can be fixed in debian/ directory. d/copyright
information has been updated after manual check with the source code.

Detailed changes can be found on
anonscm.debian.org/git/collab-maint/dtkcore.git git repository. Source
packages on mentors.d.o and debomatic-amd64.d.o are also updated
accordingly.

Thanks,
Boyuan Yang



Bug#869898: RFS: dtkcore/0.3.3-1 [ITP]

2017-07-27 Thread Liang Guo
On Thu, Jul 27, 2017 at 10:25 PM, ChangZhuo Chen  wrote:
> On Thu, Jul 27, 2017 at 09:30:52PM +0800, Boyuan Yang wrote:
>>   Alioth packaging repository:
>>
>> https://anonscm.debian.org/git/collab-maint/dtkcore.git
>
> * The copyrights in src/log/* are different from other files, please
>   check copyright header of every file and list them in
>   debian/copyright.
>
> * This symbol control file for libdtkcore.so is missing. Please help to
>   add it.

Agree, beside these problem, please notice:

* debian/docs is empty please remove

* Their should be an short license declaration in each *.{c,h,cpp}
file.  For GPL3 license files, the short license should like this:

Copyright (C)   

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program.  If not, see .

Please ask the original author to complete the license declaration.

* debian/copyright file should obey DEP-5 proposal[1]


[1] https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/


-- 
Liang Guo
http://guoliang.me/



Bug#869898: RFS: dtkcore/0.3.3-1 [ITP]

2017-07-27 Thread 陳昌倬
On Thu, Jul 27, 2017 at 09:30:52PM +0800, Boyuan Yang wrote:
>   Alioth packaging repository:
> 
> https://anonscm.debian.org/git/collab-maint/dtkcore.git

* The copyrights in src/log/* are different from other files, please
  check copyright header of every file and list them in
  debian/copyright.

* This symbol control file for libdtkcore.so is missing. Please help to
  add it.


-- 
ChangZhuo Chen (陳昌倬) czchen@{czchen,debian}.org
http://czchen.info/
Key fingerprint = BA04 346D C2E1 FE63 C790  8793 CC65 B0CD EC27 5D5B


signature.asc
Description: PGP signature


Bug#869898: RFS: dtkcore/0.3.3-1 [ITP]

2017-07-27 Thread Liang Guo
Interesting, I'll have a look

On Thu, Jul 27, 2017 at 9:30 PM, Boyuan Yang <073p...@gmail.com> wrote:
> Package: sponsorship-requests
> Severity: wishlist
> X-Debbugs-CC: czc...@debian.org
>
> Dear mentors,
>
> I am looking for a sponsor for my package "dtkcore".
>
> This source package provides a library used by various software from Deepin
> Linux. This is the dependency of many Deepin software and DDE (Deepin Desktop
> Environment).
>
> This package is parallel with previous "dtksettings" thus can be uploaded at
> the same time without conflicts/dependency problems.
>
> * Package name: dtkcore
>   Version : 0.3.3-1
>   Upstream Author : Deepin Technology Co., Ltd.
> * URL : https://www.deepin.org/
>Section : devel
>
>   It builds those binary packages:
>
>  libdtkcore-dev - Deepin Tool Kit Core Devel library
>  libdtkcore1 - Deepin Tool Kit Core library
>
>   To access further information about this package, please visit the following
> URL:
>
>   https://mentors.debian.net/package/dtkcore
>
>   Alternatively, one can download the package with dget using this command:
>
> dget -x https://mentors.debian.net/debian/pool/main/d/dtkcore/
> dtkcore_0.3.3-1.dsc
>
>   Alternatively, one can retrieve more information from debomatic-amd64:
>
> http://debomatic-amd64.debian.net/distribution#unstable/dtkcore/0.3.3-1/
>
>   Alioth packaging repository:
>
> https://anonscm.debian.org/git/collab-maint/dtkcore.git
>
>More information about hello can be obtained from https://github.com/
> linuxdeepin/dtkcore .
>
>   Changes since the last upload:
>
>  dtkcore (0.3.3-1) unstable; urgency=medium
>  .
>* Initial release (Closes: #869894)
>
> Regards,
> Boyuan Yang



-- 
Liang Guo
http://guoliang.me/



Bug#869898: RFS: dtkcore/0.3.3-1 [ITP]

2017-07-27 Thread Boyuan Yang
Package: sponsorship-requests
Severity: wishlist
X-Debbugs-CC: czc...@debian.org

Dear mentors,

I am looking for a sponsor for my package "dtkcore".

This source package provides a library used by various software from Deepin 
Linux. This is the dependency of many Deepin software and DDE (Deepin Desktop 
Environment).

This package is parallel with previous "dtksettings" thus can be uploaded at 
the same time without conflicts/dependency problems.

* Package name: dtkcore
  Version : 0.3.3-1
  Upstream Author : Deepin Technology Co., Ltd.
* URL : https://www.deepin.org/
   Section : devel

  It builds those binary packages:

 libdtkcore-dev - Deepin Tool Kit Core Devel library
 libdtkcore1 - Deepin Tool Kit Core library

  To access further information about this package, please visit the following 
URL:

  https://mentors.debian.net/package/dtkcore

  Alternatively, one can download the package with dget using this command:

dget -x https://mentors.debian.net/debian/pool/main/d/dtkcore/
dtkcore_0.3.3-1.dsc

  Alternatively, one can retrieve more information from debomatic-amd64:

http://debomatic-amd64.debian.net/distribution#unstable/dtkcore/0.3.3-1/

  Alioth packaging repository:

https://anonscm.debian.org/git/collab-maint/dtkcore.git

   More information about hello can be obtained from https://github.com/
linuxdeepin/dtkcore .

  Changes since the last upload:

 dtkcore (0.3.3-1) unstable; urgency=medium
 .
   * Initial release (Closes: #869894)

Regards,
Boyuan Yang

signature.asc
Description: This is a digitally signed message part.