Bug#862875: RFS: libzc/0.3.1-1 [ITP] -- fast zip cracking library
On Mon, Jul 24, 2017 at 3:24 PM, Andrey Rahmatullin wrote: > > Control: tags -1 + moreinfo > > Please either add check to B-D to enable tests or explicitly disable them > in debian/rules. > I don't think yazc should be in the libs section. > Explicit Depends: libzc3 in yazc is not needed. > Please switch to the debhelper compat level 10. > Please update Standards-Version to the current version. > lib/qsort.h is not described in debian/copyright as having a different > license. > All done. Thanks for the review. Please use: dget -x https://mentors.debian.net/debian/pool/main/libz/libzc/libzc_0.3.3-1.dsc to get the new version. Marc
Bug#873822: RFS: achilles/2-9 [QA]
It was with compat level 10.
On 01/09/17 23:28, Tobias Frost wrote:
> Am Freitag, den 01.09.2017, 23:01 +0100 schrieb David William Richmond
> Davies-Jones:
>> I did do an upload here I dropped the build-dep, but it threw up a
>> warning about outdated config.{sub|guess}. Should I ignore this?
>
> This was probably before setting compat level 10?
> (As said, d/compat == 10 does the magic, see https://lists.debian.org/d
> ebian-devel/2016/04/msg00018.html)
>
>
>
>> On 01/09/17 22:59, Tobias Frost wrote:
>>> Am Freitag, den 01.09.2017, 21:14 +0100 schrieb David William
>>> Richmond
>>> Davies-Jones:
Hello
I have fixed the problems with the copyright file, deleted the
stray
file, and fixed the lintian warnings about encoding in desktop
file
and
description started with synopsis.
>>>
>>> OK
>>>
I also *think* that I've got everything sorted with autoreconf
etc,
but
to be honest I always seem to have trouble and get confused with
them.
>>>
>>> With compat level 10 dh-autoreconf is default -> you do not need B-
>>> D on
>>> it or autotools-dev anymore. That should fix the warning :)
>>>
>>> Fix this and reupload... Then we're ready, I guess!
>>>
>>> Thanks for the package!
>>>
>>> --
>>> tobi
>>>
>>>
David
On 31/08/17 22:17, Tobias Frost wrote:
> Control: owner -1 !
> Control: tags -1 moreinfo
>
> Hallo David,
>
> The package is already in a nice state; many thanks for
> updating
> it!
>
> However some fixes are required:
>
> - d/copyright needs fixing:
> - as it says "Copyright: ?"... I think it must be
> Copyright: 2000 Matthew Danish
> - Also the License is GPL-2+
> - The license grant is not copied verbatimly
>
> - d/manpage is a stray file.
>
> - Please (try to) fix those linitan warnings or evaluate if
> they
> are
> valid:
>
> W: achilles source: useless-autoreconf-build-depends autotools-
> dev
> I: achilles source: debian-watch-file-is-missing
> I: achilles: hardening-no-bindnow usr/bin/achilles
> W: achilles: description-synopsis-starts-with-article
> I: achilles: desktop-entry-contains-encoding-key
> usr/share/applications/achilles.desktop:3 Encoding
> I: achilles: desktop-entry-lacks-keywords-entry
> usr/share/applications/achilles.desktop
>
>
> --
> tobi
>
>>
>>
Bug#873822: RFS: achilles/2-9 [QA]
Am Freitag, den 01.09.2017, 23:01 +0100 schrieb David William Richmond
Davies-Jones:
> I did do an upload here I dropped the build-dep, but it threw up a
> warning about outdated config.{sub|guess}. Should I ignore this?
This was probably before setting compat level 10?
(As said, d/compat == 10 does the magic, see https://lists.debian.org/d
ebian-devel/2016/04/msg00018.html)
> On 01/09/17 22:59, Tobias Frost wrote:
> > Am Freitag, den 01.09.2017, 21:14 +0100 schrieb David William
> > Richmond
> > Davies-Jones:
> > > Hello
> > >
> > > I have fixed the problems with the copyright file, deleted the
> > > stray
> > > file, and fixed the lintian warnings about encoding in desktop
> > > file
> > > and
> > > description started with synopsis.
> >
> > OK
> >
> > > I also *think* that I've got everything sorted with autoreconf
> > > etc,
> > > but
> > > to be honest I always seem to have trouble and get confused with
> > > them.
> >
> > With compat level 10 dh-autoreconf is default -> you do not need B-
> > D on
> > it or autotools-dev anymore. That should fix the warning :)
> >
> > Fix this and reupload... Then we're ready, I guess!
> >
> > Thanks for the package!
> >
> > --
> > tobi
> >
> >
> > > David
> > >
> > > On 31/08/17 22:17, Tobias Frost wrote:
> > > > Control: owner -1 !
> > > > Control: tags -1 moreinfo
> > > >
> > > > Hallo David,
> > > >
> > > > The package is already in a nice state; many thanks for
> > > > updating
> > > > it!
> > > >
> > > > However some fixes are required:
> > > >
> > > > - d/copyright needs fixing:
> > > > - as it says "Copyright: ?"... I think it must be
> > > > Copyright: 2000 Matthew Danish
> > > > - Also the License is GPL-2+
> > > > - The license grant is not copied verbatimly
> > > >
> > > > - d/manpage is a stray file.
> > > >
> > > > - Please (try to) fix those linitan warnings or evaluate if
> > > > they
> > > > are
> > > > valid:
> > > >
> > > > W: achilles source: useless-autoreconf-build-depends autotools-
> > > > dev
> > > > I: achilles source: debian-watch-file-is-missing
> > > > I: achilles: hardening-no-bindnow usr/bin/achilles
> > > > W: achilles: description-synopsis-starts-with-article
> > > > I: achilles: desktop-entry-contains-encoding-key
> > > > usr/share/applications/achilles.desktop:3 Encoding
> > > > I: achilles: desktop-entry-lacks-keywords-entry
> > > > usr/share/applications/achilles.desktop
> > > >
> > > >
> > > > --
> > > > tobi
> > > >
>
>
Bug#873822: RFS: achilles/2-9 [QA]
I did do an upload where I dropped the build-dep, but it threw up a
warning about outdated config.{sub|guess}. Should I ignore this?
On 01/09/17 22:59, Tobias Frost wrote:
> Am Freitag, den 01.09.2017, 21:14 +0100 schrieb David William Richmond
> Davies-Jones:
>> Hello
>>
>> I have fixed the problems with the copyright file, deleted the stray
>> file, and fixed the lintian warnings about encoding in desktop file
>> and
>> description started with synopsis.
>
> OK
>
>> I also *think* that I've got everything sorted with autoreconf etc,
>> but
>> to be honest I always seem to have trouble and get confused with
>> them.
>
> With compat level 10 dh-autoreconf is default -> you do not need B-D on
> it or autotools-dev anymore. That should fix the warning :)
>
> Fix this and reupload... Then we're ready, I guess!
>
> Thanks for the package!
>
> --
> tobi
>
>
>> David
>>
>> On 31/08/17 22:17, Tobias Frost wrote:
>>> Control: owner -1 !
>>> Control: tags -1 moreinfo
>>>
>>> Hallo David,
>>>
>>> The package is already in a nice state; many thanks for updating
>>> it!
>>>
>>> However some fixes are required:
>>>
>>> - d/copyright needs fixing:
>>> - as it says "Copyright: ?"... I think it must be
>>> Copyright: 2000 Matthew Danish
>>> - Also the License is GPL-2+
>>> - The license grant is not copied verbatimly
>>>
>>> - d/manpage is a stray file.
>>>
>>> - Please (try to) fix those linitan warnings or evaluate if they
>>> are
>>> valid:
>>>
>>> W: achilles source: useless-autoreconf-build-depends autotools-dev
>>> I: achilles source: debian-watch-file-is-missing
>>> I: achilles: hardening-no-bindnow usr/bin/achilles
>>> W: achilles: description-synopsis-starts-with-article
>>> I: achilles: desktop-entry-contains-encoding-key
>>> usr/share/applications/achilles.desktop:3 Encoding
>>> I: achilles: desktop-entry-lacks-keywords-entry
>>> usr/share/applications/achilles.desktop
>>>
>>>
>>> --
>>> tobi
>>>
Bug#873822: RFS: achilles/2-9 [QA]
Am Freitag, den 01.09.2017, 21:14 +0100 schrieb David William Richmond Davies-Jones: > Hello > > I have fixed the problems with the copyright file, deleted the stray > file, and fixed the lintian warnings about encoding in desktop file > and > description started with synopsis. OK > I also *think* that I've got everything sorted with autoreconf etc, > but > to be honest I always seem to have trouble and get confused with > them. With compat level 10 dh-autoreconf is default -> you do not need B-D on it or autotools-dev anymore. That should fix the warning :) Fix this and reupload... Then we're ready, I guess! Thanks for the package! -- tobi > David > > On 31/08/17 22:17, Tobias Frost wrote: > > Control: owner -1 ! > > Control: tags -1 moreinfo > > > > Hallo David, > > > > The package is already in a nice state; many thanks for updating > > it! > > > > However some fixes are required: > > > > - d/copyright needs fixing: > > - as it says "Copyright: ?"... I think it must be > > Copyright: 2000 Matthew Danish > > - Also the License is GPL-2+ > > - The license grant is not copied verbatimly > > > > - d/manpage is a stray file. > > > > - Please (try to) fix those linitan warnings or evaluate if they > > are > > valid: > > > > W: achilles source: useless-autoreconf-build-depends autotools-dev > > I: achilles source: debian-watch-file-is-missing > > I: achilles: hardening-no-bindnow usr/bin/achilles > > W: achilles: description-synopsis-starts-with-article > > I: achilles: desktop-entry-contains-encoding-key > > usr/share/applications/achilles.desktop:3 Encoding > > I: achilles: desktop-entry-lacks-keywords-entry > > usr/share/applications/achilles.desktop > > > > > > -- > > tobi > >
Bug#869926: RFS: oprofile/1.2.0-1 [ITP]
Hi Andrey, On Thu, 31 Aug 2017 22:52:12 +0500 Andrey Rahmatullin wrote: > Please upgrade to the current Standards-Version. Fixed. > Why do you use "rm `find . -name "*.la"`" instead of "find . -name "*.la" > -delete"? Fixed > Why do you ship static versions of the plugins? Fixed. Don't need them, just need the .so files > README_PACKAGERS says "It is recommended to run ldconfig in %post and > %postun to add/remove the /oprofile path from the standard library > search paths.", have you checked the plugins work without adding that to > the search paths? Fixed. I created a file in /etc/ld.so.conf.d/ so operf with JITed code works doing something like: $ operf java -Xcomp -agentlib:jvmti_oprofile Hello I also did the changes in packages, as we talked in IRC, providing 4 packages: oprofile, oprofile-jit, libopagent1 and libopagent-dev > include/sstream should be documented in debian/copyright. Fixed > doc/*.html should ideally be rebuilt during the build process, you can > probably achieve that by adding them to debian/clean and checking that > they are built properly. Fixed. I added debian/clean file > > -- > WBR, wRAR
Bug#873822: RFS: achilles/2-9 [QA]
Hello I have fixed the problems with the copyright file, deleted the stray file, and fixed the lintian warnings about encoding in desktop file and description started with synopsis. I also *think* that I've got everything sorted with autoreconf etc, but to be honest I always seem to have trouble and get confused with them. David On 31/08/17 22:17, Tobias Frost wrote: > Control: owner -1 ! > Control: tags -1 moreinfo > > Hallo David, > > The package is already in a nice state; many thanks for updating it! > > However some fixes are required: > > - d/copyright needs fixing: > - as it says "Copyright: ?"... I think it must be > Copyright: 2000 Matthew Danish > - Also the License is GPL-2+ > - The license grant is not copied verbatimly > > - d/manpage is a stray file. > > - Please (try to) fix those linitan warnings or evaluate if they are > valid: > > W: achilles source: useless-autoreconf-build-depends autotools-dev > I: achilles source: debian-watch-file-is-missing > I: achilles: hardening-no-bindnow usr/bin/achilles > W: achilles: description-synopsis-starts-with-article > I: achilles: desktop-entry-contains-encoding-key > usr/share/applications/achilles.desktop:3 Encoding > I: achilles: desktop-entry-lacks-keywords-entry > usr/share/applications/achilles.desktop > > > -- > tobi >
Bug#864241: marked as done (RFS: pnmixer/0.7.2-2 -- Simple mixer application for system tray)
Your message dated Fri, 1 Sep 2017 20:56:12 +0200 with message-id <20170901185612.wbzoe5w7jbwhl...@angband.pl> and subject line Re: Bug#864241: RFS: pnmixer/0.7.2-1 -- Simple mixer application for system tray has caused the Debian Bug report #864241, regarding RFS: pnmixer/0.7.2-2 -- Simple mixer application for system tray to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 864241: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=864241 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems --- Begin Message --- Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "pnmixer" * Package name: pnmixer Version : 0.7.2-1 Upstream Author : Nick Lanham, Julian Ospald, Arnaud Rebillout * URL : https://github.com/nicklan/pnmixer * License : GPLv3 Section : sound It builds those binary packages: pnmixer- Simple mixer application for system tray To access further information about this package, please visit the following URL: https://mentors.debian.net/package/pnmixer Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/p/pnmixer/pnmixer_0.7.2-1.dsc More information about pnmixer can be obtained from https://github.com/nicklan/pnmixer. Changes since the last upload: * New upstream release. - Switch to cmake buildsystem. - Use gettext instead of intltool for translation. - Build is now reproducible. Closes: #854112. * Update watchfile to version 4. * Package is now versioned with git and build with gbp. See the control file for the url. Additional notes For the last release, Paul Wise made a thorough review, and I failed to reply in time (see #839289). So I will reply now. > The file downloaded by uscan is different to the one you have included in > your Debian source package. Please adjust your debian/watch file to use the > correct one. Done, the watch file seem to work according to `uscan`, but mentors.debian.net says there's a problem. I'm not sure what's wrong. > I suggest that you try and make the github generated tarball as similar as > possible to the `make dist` generated tarball. The package is now built with `gbp` from a git tag. I guess it fixes the problem. > The debian/watch tells uscan that v0.7-rc1 is newer than v0.7. I think you > want uversionmangle=s/-rc/~rc/. Yes indeed, fixed, thanks. > The images say they were produced in GIMP and look like multi-layer images > that have been rendered to flat bitmaps, did you discard the XCF images or > are they hidden away somewhere? How were these images produced? In general it > is best to render final images from the source material at build time, using > xcf2png or similar. I have no idea where are the source images, when I jumped in PNMixer development there was only the PNG files, and I don't think the XCF files will ever be found. > Generated and stamp files should be removed from the upstream git repo and > added to .gitignore: Done. > I expect most of autogen.sh can be replaced with a call to autoreconf: We switched to CMake in the end, no more autotools. > Running wrap-and-sort would make diffs of the Debian packaging easier to read Done, thx for the command. > The system() and g_spawn_command_line_async() functions should not be used > and I don't think `which` is very portable. Instead of system()+`which` you > should use g_find_program_in_path(). Done, thx, I didn't know about this function. > Instead of g_spawn_command_line_async() you should use g_spawn_async(). Sorry, disagreeing on this one, g_spawn_command_line_async() is definitely what I want to use, it's the right tool for the job. And if the implementation is bad and uses too many pid, no worries. In PNMixer, this function is rarely called, probably never called. But in other situations, if ever we made an extensive use of this function, then I would probably agree with you and use g_spawn_async(). > Please add some upstream metadata Done. > Since you are upstream, please read our guide for upstreams Oups, reading now :) > Automatic checks Fixed a few things, but there's way too much stuff there, I didn't take time to look through everything. For the next release :) Best regards, Arnaud Rebillout --- End Message --- --- Begin Message --- On Thu, Aug 31, 2017 at 07:15:21AM +0700, Arnaud wrote: > > what is the status of this RFS? > > > > Hi Gianfranco, > > this RFS is still waiting. As Gianfranco is currently busy, I'm poaching this
Bug#873938: marked as done (RFS: engauge-digitizer/10.3+ds.1-1)
Your message dated Fri, 1 Sep 2017 17:35:31 +0200 with message-id <20170901153531.ekl6mvvosilzj...@angband.pl> and subject line Re: Bug#873938: RFS: engauge-digitizer/10.3+ds.1-1 has caused the Debian Bug report #873938, regarding RFS: engauge-digitizer/10.3+ds.1-1 to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 873938: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=873938 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems --- Begin Message --- Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "engauge-digitizer" * Package name: engauge-digitizer Version : 10.3+ds.1-1 Upstream Author : Mark Mitchell * URL : https://github.com/markummitchell/engauge6 * License : GPL-2+ Section : science It builds those binary packages: engauge-digitizer - interactively extracts numbers from bitmap graphs or maps engauge-digitizer-doc - engauge-digitizer user manual and tutorial To access further information about this package, please visit the following URL: https://mentors.debian.net/package/engauge-digitizer Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/e/engauge-digitizer/ engauge-digitizer_10.3+ds.1-1.dsc More information about hello can be obtained from https://www.example.com. Changes since the last upload: * New upstream release * Updated to standards version 4.0.0 * engauge-digitizer-doc as Multi-Arch: foreign Regards, Tobias Winchen signature.asc Description: This is a digitally signed message part. --- End Message --- --- Begin Message --- On Fri, Sep 01, 2017 at 01:37:59PM +0200, Tobias Winchen wrote: > * Package name: engauge-digitizer >Version : 10.3+ds.1-1 > Changes since the last upload: > > * New upstream release > * Updated to standards version 4.0.0 > * engauge-digitizer-doc as Multi-Arch: foreign ✓ -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢰⠒⠀⣿⡁ Vat kind uf sufficiently advanced technology iz dis!? ⢿⡄⠘⠷⠚⠋⠀ -- Genghis Ht'rok'din ⠈⠳⣄ --- End Message ---
Bug#873938: RFS: engauge-digitizer/10.3+ds.1-1
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "engauge-digitizer" * Package name: engauge-digitizer Version : 10.3+ds.1-1 Upstream Author : Mark Mitchell * URL : https://github.com/markummitchell/engauge6 * License : GPL-2+ Section : science It builds those binary packages: engauge-digitizer - interactively extracts numbers from bitmap graphs or maps engauge-digitizer-doc - engauge-digitizer user manual and tutorial To access further information about this package, please visit the following URL: https://mentors.debian.net/package/engauge-digitizer Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/e/engauge-digitizer/ engauge-digitizer_10.3+ds.1-1.dsc More information about hello can be obtained from https://www.example.com. Changes since the last upload: * New upstream release * Updated to standards version 4.0.0 * engauge-digitizer-doc as Multi-Arch: foreign Regards, Tobias Winchen signature.asc Description: This is a digitally signed message part.
Re: [Debian-med-packaging] Bug#853568: No idea how to fix abs arguments in nanopolish
Am Donnerstag, den 31.08.2017, 21:00 -0700 schrieb Walter Landry: > Andreas Tille wrote: > > Hi, > > > > to fix bug #853568 I tried a patch (gcc-7.patch) to fix abs() > > arguments > > in nanopolish[1] but I have no idea how to deal with this: > > > > ... > > g++ -o src/hmm/nanopolish_pore_model_set.o -c -g -O2 -fdebug- > > prefix-map=/build/nanopolish-0.5.0=. -fstack-protector-strong > > -Wformat -Werror=format-security -g -O3 -std=c++11 -fopenmp -Wdate- > > t > > src/common/nanopolish_variant.cpp: In function > > 'std::vector extract_variants(const string&, const > > string&)': > > src/common/nanopolish_variant.cpp:32:69: error: call of overloaded > > 'abs(std::__cxx11::basic_string::size_type)' is ambiguous > > size_t difference = std::abs(reference.size() - > > haplotype.size()); > > The result of subtracting two size_t's is still a size_t, which is > unsigned. So you need to cast it to a signed type. The correct type > is ptrdiff_t. > > http://en.cppreference.com/w/cpp/types/ptrdiff_t > > The line then becomes > > size_t difference = > std::abs(static_cast(reference.size() - > haplotype.size())); Casting the difference may result in undefined behavior. Consider the case reference.size() == 1 haplotype.size() == 2 then reference.size() - haplotype.size() will be 0x (on 32 bit), and how this is casted to a signed type is implementation dependent (i.e. it is not guaranteed that this simply wraps to -1, it may also raise a trap because of integer overflow). It would be better to avoid the cast altogether by doing something like size_t difference = reference.size() > haplotype.size() ? reference.size() - haplotype.size() : haplotype.size() - reference.size(); or cast both values before doing the subtraction. Best, Gert
