Re: Request for peer review of clamav-unofficial-sigs
On Thu, Nov 22, 2018 at 2:34 PM Brent Clark wrote: > I am new to packaging and I would like to ask if someone could please > peer review my work. Some comments: I'm not sure how you want to use git for packaging. I used gbp and pristine-tar. These days I would personally remove all upstream code from git and store only the debian/ directory. A more popular option is to use the DEP14 standard for this. I'm not sure how the clamav team do things these days. https://dep-team.pages.debian.net/deps/dep14/ I think you will want to use the releases page in the debian/watch: https://github.com/extremeshok/clamav-unofficial-sigs/releases The eXtremeSHOK version doesn't have a CHANGELOG file like the original version did, they instead store their NEWS equivalent file in the README.md, which would already be installed by dh_installdocs. So I think you can drop the dh_installchangelogs override from debian/rules and just not have a separate changelog. If you want to separate them and upstream refuse to do that, you could split the README.md at build time and clamav-unofficial-sigs.conf doesn't exist in the eXtremeSHOK version so the install phase of package building will fail when it tries to copy that. I guess you will need to do something with the upstream config directory instead. I wonder if debian/publickey.gpg is still needed. The eXtremeSHOK version doesn't have a clamav-unofficial-sigs.8 so debian/manpages will cause dh_installman to fail. The eXtremeSHOK version has a README.md file instead of a README file so debian/docs will cause dh_installdocs to fail. If you ever decide to get this into Debian, debian/copyright needs to be updated for the new copyrights of eXtremeSHOK. You might want to add yourself to Uploaders in debian/control. I'd put a space before the bracket in debian/changelog. Please run lintian on the .changes file. -- bye, pabs https://wiki.debian.org/PaulWise
Request for peer review of clamav-unofficial-sigs
Good day Guys I am new to packaging and I would like to ask if someone could please peer review my work. https://salsa.debian.org/brentclark-guest/clamav-unofficial-sigs my work is in the branch bc_packaging_extremeshoks_clamav_unofficial_sigs Basically whats happened is the shipped version of clamav-unofficial-sigs forked or taken over by another project (i.e. https://github.com/extremeshok/clamav-unofficial-sigs ) I have been in contact with the package maintainer (i.e. Paul Wise), who was kind enough to point me in the right direction, but also indicated that he would like some else to take over it. Im not looking to take over the package and be its maintainer, but I am looking to package it and use it on my systems (I will make the deb package available to all), but I just to make sure I am doing it all correctly. Regards Brent Clark
Re: Bug#913261: RFS: chkboot/1.2-1 [ITP]
Control: owner -1 p...@debian.org Le mercredi 21 novembre 2018 à 16:37:53-0200, Herbert Fortes a écrit : > On 21/11/2018 13:31, Baptiste BEAUPLAT wrote: > > Hello Herbert, > > > > I hope you are well. > > > > I was wondering if you had time to take a second look at this package? > > > > No. > > I had to improve the Debian CI tests for some > of the packages I take care. > > Anyone can take of that package if necessary. > I can not do it right now. I'll take it from here. -- Pierre-Elliott Bécue GPG: 9AE0 4D98 6400 E3B6 7528 F493 0D44 2664 1949 74E2 It's far easier to fight for one's principles than to live up to them. signature.asc Description: PGP signature
Bug#913261: RFS: chkboot/1.2-1 [ITP]
On 21/11/2018 13:31, Baptiste BEAUPLAT wrote: Hello Herbert, I hope you are well. I was wondering if you had time to take a second look at this package? No. I had to improve the Debian CI tests for some of the packages I take care. Anyone can take of that package if necessary. I can not do it right now. Regards, Herbert
Bug#913261: RFS: chkboot/1.2-1 [ITP]
Hello Herbert, I hope you are well. I was wondering if you had time to take a second look at this package? Best regards, On 11/10/18 2:14 PM, Baptiste BEAUPLAT wrote: >> The package does not build twice in a row: > This is fixed now. -- Baptiste BEAUPLAT - lyknode signature.asc Description: OpenPGP digital signature
Bug#914174: RFS: easy-rsa [ITA]
On 11/21/18 3:14 PM, Adam Borowski wrote:
> On Wed, Nov 21, 2018 at 02:27:17PM +0100, Michele Orru wrote:
>> On 11/21/18 6:45 AM, Adam Borowski wrote:
>>> On Tue, Nov 20, 2018 at 08:45:09AM +0100, Michele Orrù wrote:
* Package name: easy-rsa
Version : 3.0.5-1
>>>
https://salsa.debian.org/maker-guest/easy-rsa/
>>
>> thanks a lot for your prompt response!
>>
>> I really apologise for the silly mistake on dh_installdocs: it should be
>> fixed now, together with the other issues you reported.
>>
>> I pushed the modifications on salsa, and uploaded the package on
>> mentors.debian.net
>
> Awesome.
>
> There's one more issue that's better to fix before uploading:
> Maintainer: Debian QA Group
> -- you'd want to update this.
>
… right, thanks again. It should be fixed now (both on mentors and on
salsa).
>> I also took the liberty of removing: ${shlibs:Depends} from the list of
>> dependencies. They were empty, plus easy-rsa is just a shell script that
>> relies solely on openssl, which is explicit in the package. Hope that's
>> fine.
>
> It's generally better to keep this even if unused as an empty var that's
> referenced is ok but a non-empty var that's missing would cause problems.
> This might happen if you one day need to include a bit of compiled code
> in the package. But then, for now there's no difference either way.
I see your point, I'll keep that in mind. However, unless you really
think it would be best to keep it, I'd leave as it is to get rid of that
lintian warning.
I also went through:
https://www.debian.org/doc/packaging-manuals/upgrading-checklist.txt
to update the Standards version, which apparently required no additional
changes to the package, or the metadata. Hope that's fine.
--
μ.
Bug#914174: RFS: easy-rsa [ITA]
On Wed, Nov 21, 2018 at 02:27:17PM +0100, Michele Orru wrote:
> On 11/21/18 6:45 AM, Adam Borowski wrote:
> > On Tue, Nov 20, 2018 at 08:45:09AM +0100, Michele Orrù wrote:
> > > * Package name: easy-rsa
> > >Version : 3.0.5-1
> >
> > > https://salsa.debian.org/maker-guest/easy-rsa/
>
> thanks a lot for your prompt response!
>
> I really apologise for the silly mistake on dh_installdocs: it should be
> fixed now, together with the other issues you reported.
>
> I pushed the modifications on salsa, and uploaded the package on
> mentors.debian.net
Awesome.
There's one more issue that's better to fix before uploading:
Maintainer: Debian QA Group
-- you'd want to update this.
> I also took the liberty of removing: ${shlibs:Depends} from the list of
> dependencies. They were empty, plus easy-rsa is just a shell script that
> relies solely on openssl, which is explicit in the package. Hope that's
> fine.
It's generally better to keep this even if unused as an empty var that's
referenced is ok but a non-empty var that's missing would cause problems.
This might happen if you one day need to include a bit of compiled code
in the package. But then, for now there's no difference either way.
Meow!
--
⢀⣴⠾⠻⢶⣦⠀ We domesticated dogs 36000 years ago; together we chased
⣾⠁⢰⠒⠀⣿⡁ animals, hung out and licked or scratched our private parts.
⢿⡄⠘⠷⠚⠋⠀ Cats domesticated us 9500 years ago, and immediately we got
⠈⠳⣄ agriculture, towns then cities. -- whitroth on /.
Bug#914174: RFS: easy-rsa [ITA]
[2018-11-20 08:45] Michele Orrù > > * Package name: easy-rsa > Version : 3.0.5-1 > Upstream Author : the Open-Source OpenVPN development community > * URL : https://github.com/OpenVPN/easy-rsa/ > * License : GPLv2 > > It builds those binary packages: > > easy-rsa - Simple shell based CA utility For commit 7a17: * typo in `debian/control': correct is `Rules-Requires-Root' ^ * FTBFS: dh_installdocs: Cannot find (any matches for) "debian/README-Debian-much-features-such-wow" (tried in ., debian/tmp)
Bug#914132: RFS: cwm/6.3-1 -- lightweight and efficient window manager for X11
[2018-11-19 18:44] James McDonald > It builds those binary packages: > > cwm -- lightweight and efficient window manager for X11 > [...] > > dget -x https://mentors.debian.net/debian/pool/main/c/cwm/cwm_6.3-1.dsc 404.
Bug#914174: RFS: easy-rsa [ITA]
On 11/21/18 6:45 AM, Adam Borowski wrote:
On Tue, Nov 20, 2018 at 08:45:09AM +0100, Michele Orrù wrote:
* Package name: easy-rsa
Version : 3.0.5-1
https://salsa.debian.org/maker-guest/easy-rsa/
Changes since the last upload:
* New upstream version 3.0.5
* Updated d/README.Debian
Hi!
The package's changelog is set as UNRELEASED, which marks the current state
as not meant for upload.
The changelog doesn't also list your takeover.
The package fails to build:
dh_installdocs: Cannot find (any matches for)
"debian/README-Debian-much-features-such-wow" (tried in ., debian/tmp)
(the file is deleted in the packaging now)
Rules-Require-Root should be "Requires".
Hi,
thanks a lot for your prompt response!
I really apologise for the silly mistake on dh_installdocs: it should be
fixed now, together with the other issues you reported.
I pushed the modifications on salsa, and uploaded the package on
mentors.debian.net
I also took the liberty of removing: ${shlibs:Depends} from the list of
dependencies. They were empty, plus easy-rsa is just a shell script that
relies solely on openssl, which is explicit in the package. Hope that's
fine.
Cheers,
--
μ.
Bug#914261: RFS: libt3window/0.3.1-1
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "libt3window" * Package name: libt3window Version : 0.3.1-1 Upstream Author : Gertjan Halkes * URL : https://os.ghalkes.nl/t3/libt3window.html * License : GPLv3 Section : libs It builds those binary packages: libt3window-dev - Development files for libt3window libt3window0 - Library for creating window-based terminal programs To access further information about this package, please visit the following URL: https://mentors.debian.net/package/libt3window Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/libt/libt3window/libt3window_0.3.1-1.dsc Changes since the last upload: * New upstream release. Regards, Gertjan Halkes
