Re: Automake issues on pngnq

2022-03-07 Thread Andreas Tille
Am Mon, Mar 07, 2022 at 11:08:11PM +0100 schrieb Filip Hroch:
> 
> PKG_CHECK_MODULES macro defines set of [lib]png_* variables,
> specially [lib]png_CFLAGS and [lib]png_LIBS, which can be used
> in Makefile[.am] by this way:
> 
> pngnq_CFLAGS = ... $(png_CFLAGS) ..
> pngnq_LDADD = ... $(png_LIBS) ..
> 
> (I'm unsure if ones are png_* or libpng_*, please
> consult `config.log').

Its $(PNG_LIBS) and the build works that way.
 
Thanks for your helpful hint

  Andreas. 

-- 
http://fam-tille.de



Re: Automake issues on pngnq

2022-03-07 Thread Filip Hroch

Dear Andreas,

Andreas Tille  writes:

...


I was checking this as well - seems here is something broken:


# checks for libraries
AC_SEARCH_LIBS([zlibVersion],[z])
AC_SEARCH_LIBS([sqrt],[m])
PKG_CHECK_MODULES([PNG], [libpng >= 1.2.0])



PKG_CHECK_MODULES macro defines set of [lib]png_* variables,
specially [lib]png_CFLAGS and [lib]png_LIBS, which can be used
in Makefile[.am] by this way:

pngnq_CFLAGS = ... $(png_CFLAGS) ..
pngnq_LDADD = ... $(png_LIBS) ..

(I'm unsure if ones are png_* or libpng_*, please
consult `config.log').

As an alternative, the command:

 $ libpng-config --libs
   -lpng16

can be added to the command line; linked libraries should
be the last argument.

I believe it makes a sense,
FH
--
F. Hroch , Masaryk University,
Dept. of theor. physics and astrophysics, Brno, Moravia, CZ



Re: Automake issues on pngnq

2022-03-07 Thread Andreas Tille
Am Tue, Mar 08, 2022 at 01:07:05AM +0500 schrieb Andrey Rahmatullin:
> On Mon, Mar 07, 2022 at 08:59:38PM +0100, Andreas Tille wrote:
> > For whatever reason automake puts LDFLAGS before "-o pngcomp"
> This is correct.
> 
> > instead of after and the last options are obtained from the LIBS variable. 
> This is correct.
> 
> > I have no idea how to tweak this sequence.
> You don't need to tweak the sequence. You need to put libs into LIBS.

I was checking this as well - seems here is something broken:


# checks for libraries
AC_SEARCH_LIBS([zlibVersion],[z])
AC_SEARCH_LIBS([sqrt],[m])
PKG_CHECK_MODULES([PNG], [libpng >= 1.2.0])


Any idea how to make sure the correct -lpng expression is added here?


Kind regards

  Andreas.


-- 
http://fam-tille.de



Re: Automake issues on pngnq

2022-03-07 Thread Andrey Rahmatullin
On Mon, Mar 07, 2022 at 08:59:38PM +0100, Andreas Tille wrote:
> For whatever reason automake puts LDFLAGS before "-o pngcomp"
This is correct.

> instead of after and the last options are obtained from the LIBS variable. 
This is correct.

> I have no idea how to tweak this sequence.
You don't need to tweak the sequence. You need to put libs into LIBS.

-- 
WBR, wRAR


signature.asc
Description: PGP signature


Automake issues on pngnq

2022-03-07 Thread Andreas Tille
Hi,

I tried to adopt pngnq from QA and pushed it to Salsa[1].
Unfortunately the new upstream version has some automake issues.

Strangely enough one issue in configure script occures only in
salsa-ci[2] but not in my local pbuilder.  There I get another
issue in a later stage of the build process:

gcc `libpng-config --I_opts` -Wall --pedantic -std=gnu99 -g -O2 
-ffile-prefix-map=/build/pngnq-1.1=. -fstack-protector-strong -Wformat 
-Werror=format-security `libpng-config --ldflags` -lz -lm -Wl,-z,relro 
-Wl,-z,now  -o pngcomp pngcomp.o rwpng.o colorspace.o  -lm -lz 
/usr/bin/ld: rwpng.o: in function `rwpng_error_handler':
./src/rwpng.c:563: undefined reference to `png_get_error_ptr'
/usr/bin/ld: rwpng.o: in function `rwpng_version_info':
./src/rwpng.c:48: undefined reference to `png_get_header_ver'
/usr/bin/ld: rwpng.o: in function `rwpng_read_image':
./src/rwpng.c:82: undefined reference to `png_sig_cmp'
/usr/bin/ld: ./src/rwpng.c:88: undefined reference to `png_create_read_struct'
...


The latter can be fixed by appending `libpng-config --ldflags` in the
end of the command line.  For whatever reason automake puts LDFLAGS
before "-o pngcomp" instead of after and the last options are obtained
from the LIBS variable.  I have no idea how to tweak this sequence.

Kind regards

 Andreas.


[1] https://salsa.debian.org/debian-phototools-team/pngnq/
[2] https://salsa.debian.org/debian-phototools-team/pngnq/-/jobs/2538883

-- 
http://fam-tille.de



Bug#1006832: RFS: minetest/5.5.0+dfsg+~1.9.0mt4+dfsg-1 -- Multiplayer infinite-world block sandbox

2022-03-07 Thread Bastian Germann

On Sat, 5 Mar 2022 21:59:31 -0500 Travis Wrightsman wrote:

Changes since the last upload:

 minetest (5.5.0+dfsg+~1.9.0mt4+dfsg-1) unstable; urgency=medium
 .
   * New upstream release.
   * Add git-buildpackage config file.
   * Migrate from repack.sh to Files-Excluded.
   * Refresh patches.
   * Add NEWS describing breaking/significant changes.
   * Add README.source for maintainer notes.



If this is a team upload, please say so in the changelog.



Bug#1006808: RFS: jimtcl/0.79+dfsg0-4 [ITA] -- small-footprint implementation of Tcl - shared library

2022-03-07 Thread Bastian Germann

Am 07.03.22 um 13:17 schrieb vimer:

Hi,
On Mon, Mar 07, 2022 at 12:59:45PM +0100, Bastian Germann wrote:

On Sat, 5 Mar 2022 23:16:45 +0800 vimer wrote:

Changes since the last upload:

  jimtcl (0.79+dfsg0-4) unstable; urgency=medium
  .
 * Add myself as maintainer (Closes: #993599).


You should really accomplish something else on the package on adopting it.
I am closing this request.

Ok. But could you please tell me the "something else" on the package is
what really.
The lintian warnings? https://tracker.debian.org/pkg/jimtcl.
Thank you!


I do not know the package, so I do not know that. When you want to be the 
maintainer, please find that out yourself.
Just setting yourself as a maintainer without actually doing any work is just 
not feasible for a sponsorship request.
People want to sponsor package revisions that have an effect additionally to 
handing over maintainership.



Bug#1006808: marked as done (RFS: jimtcl/0.79+dfsg0-4 [ITA] -- small-footprint implementation of Tcl - shared library)

2022-03-07 Thread Debian Bug Tracking System
Your message dated Mon, 7 Mar 2022 12:59:45 +0100
with message-id <0a300a68-953a-2f74-62ce-c2c33cdee...@debian.org>
and subject line Re: RFS: jimtcl/0.79+dfsg0-4 [ITA] -- small-footprint 
implementation of Tcl - shared library
has caused the Debian Bug report #1006808,
regarding RFS: jimtcl/0.79+dfsg0-4 [ITA] -- small-footprint implementation of 
Tcl - shared library
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1006808: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1006808
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: sponsorship-requests
Severity: normal


Dear mentors,

I am looking for a sponsor for my package "jimtcl":

 * Package name: jimtcl
   Version : 0.79+dfsg0-4
   Upstream Author : Salvatore Sanfilippo 
 * URL : http://jim.tcl.tk/
 * License : BSD-2-clause, TCL
 * Vcs : https://salsa.debian.org/debian/jimtcl
   Section : devel

 It builds those binary packages:

   jimsh - small-footprint implementation of Tcl named Jim
   libjim-dev - small-footprint implementation of Tcl - development files
   libjim0.79 - small-footprint implementation of Tcl - shared library

 To access further information about this package, please visit the following 
URL:

   https://mentors.debian.net/package/jimtcl/

 Alternatively, one can download the package with dget using this command:

   dget -x 
https://mentors.debian.net/debian/pool/main/j/jimtcl/jimtcl_0.79+dfsg0-4.dsc

 Changes since the last upload:

   jimtcl (0.79+dfsg0-4) unstable; urgency=medium
   .
  * Add myself as maintainer (Closes: #993599).

 Regards,
 --
   vimer
--- End Message ---
--- Begin Message ---

On Sat, 5 Mar 2022 23:16:45 +0800 vimer wrote:

 Changes since the last upload:

   jimtcl (0.79+dfsg0-4) unstable; urgency=medium
   .
  * Add myself as maintainer (Closes: #993599).


You should really accomplish something else on the package on adopting it.
I am closing this request.--- End Message ---