Bug#1010242: RFS: opengnb/1.2.8.7-1 [ITP] -- via P2P to setup de-centralized layer3 network VPN
Am 26.05.22 um 06:05 schrieb xiao sheng wen(肖盛文): Files: libs/protocol/network_protocol.h Copyright:1995, 1996, 1997, and 1998 WIDE Project. 1982, 1986, 1993 The Regents of the University of California. License: BSD-3-clause Comment: The upstream distribution does not contain an explicit statement of copyright ownership. . struct ip6_hdr come from FreeBSD: src/sys/netinet/ip6.h /* $FreeBSD: src/sys/netinet/ip6.h,v 1.5 2001/06/11 12:39:00 ume Exp $ */ /* $KAME: ip6.h,v 1.18 2001/03/29 05:34:30 itojun Exp $ */ . struct iphdr come from BSD, modified by upstream author. The other parts of this file is write by upstream author. Is this acceptable? Please change the last comment to say: struct iphdr comes from FreeBSD and is modified by the upstream author. The other parts of this file is written by the upstream author. Otherwise this looks good. ed25519's license name "Expat" is misleading. Please rename it to "zlib". For murmurhash, you would have to find the original version to really know that it is public-domain. The nginx version has a copyright statement but I could find murmurhash v2 implementations that are public domain. However, I did not find the nginx version elsewhere quickly. Your comment "It is assumed that all content is copyright by its respective authors unless otherwise stated" actually contradicts the idea of public domain, which to get rid of copyright explicitly for some copyrightable work. If you do not find the original, please consider replacing this file. There is at least the package libmurmurhash available (but I do not know if it is an equivalent version). I also minor update the d/control file for the package description's grammar. Here is my suggestion: Description: P2P de-centralized layer 3 VPN OpenGNB is a de-centralized virtual private network (VPN) to set-up a layer 3 network via P2P with the capability of NAT traversal. . OpenGNB can add many nodes and LANs together into one big VPN. OpenGNB supports public index nodes to forward net packages. . opengnb support the following platforms: Linux, FreeBSD, OpenBSD, and macOS. . OpenGNB uses UDP by default. With the software gnb_udp_over_tcp installed it can also use TCP.
Bug#1011313: marked as done (RFS: python-decouple/3.6-1 [ITA] -- Helps you to organize your Django/Flask settings)
Your message dated Thu, 26 May 2022 12:35:32 +0200 with message-id and subject line Re: RFS: python-decouple/3.6-3 -- Helps you to organize your Django/Flask settings has caused the Debian Bug report #1011313, regarding RFS: python-decouple/3.6-1 [ITA] -- Helps you to organize your Django/Flask settings to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 1011313: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1011313 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems --- Begin Message --- Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "python-decouple": * Package name: python-decouple Version : 3.6-3 Upstream Author : Henrique Bastos * URL : https://github.com/henriquebastos/python-decouple * License : MIT * Vcs : https://salsa.debian.org/debian/python-decouple Section : python The source builds the following binary packages: python3-decouple - Helps you to organize your Django/Flask settings To access further information about this package, please visit the following URL: https://mentors.debian.net/package/python-decouple/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/p/python-decouple/python-decouple_3.6-3.dsc Or, the git repository (forked from the main branch): https://salsa.debian.org/zaharazod/python-decouple.git Changes since the last upload: python-decouple (3.6-3) unstable; urgency=medium . * copyright fixes * lintian fixes * new upstream version (3.6) Regards, -- Matt Barry --- End Message --- --- Begin Message --- Please do not mix upstream with debian/ changes. I have reorganized (force-pushed) your changes in git. Please make yourself familiar with git-buildpackage if you want to keep maintaining this pkg in git. Your version was just uploaded.--- End Message ---
Bug#1011670: RFS: open-ath9k-htc-firmware/1.4.0-108-gd856466+dfsg1 -- firmware for AR7010 and AR9271 USB wireless adapters
On Thu, 26 May 2022 06:26:29 + John Scott wrote: This package was previously uploaded, but failed to clear NEW because my introduction of a udeb wasn't fully vetted. This upload drops the udeb so we can fix the FTBFS; perhaps it can be reintroduced later. I think Bastian Germann has been watching this package closely, so allow a little time for him to review this RFS. Please add a -1 Debian revision. I would like to move the Salsa repo into the Debian namespace as he suggested; could somebody create this for me? My Salsa username is 'jscott' I have granted you access to the new repo. Please change the Vcs-* fields with the next upload. You should keep the BSD-4-clause license name because the 4th clause is not renumbered. Please remove the 3rd clause in the license. asf_queue.h also has that modified license. As no other file references BSD-3-Clause anymore, please remove it. This also has the problem that it contains an alternative GPL-2 option which is not reflected in its name.
Bug#1010242: RFS: opengnb/1.2.8.7-1 [ITP] -- via P2P to setup de-centralized layer3 network VPN
Hi Bastian, Thanks for your quick reply. 在 2022/5/26 17:26, Bastian Germann 写道: > > Please change the last comment to say: > struct iphdr comes from FreeBSD and is modified by the upstream author. > The other parts of this file is written by the upstream author. > > Otherwise this looks good. Updated. > > ed25519's license name "Expat" is misleading. Please rename it to "zlib". Renamed. > > For murmurhash, you would have to find the original version to really > know > that it is public-domain. The nginx version has a copyright statement > but I > could find murmurhash v2 implementations that are public domain. > However, I > did not find the nginx version elsewhere quickly. I use apt source nginx to get the source code in sid, I find the original version. I compared the libs/hash/murmurhash.c and nginx-1.20.2/src/core/ngx_murmurhash.c, only the function name is different. This file use BSD-2-clause, it said by nginx d/copyright. I update the infos for this file: Files: libs/hash/murmurhash.c Copyright: Copyright (C) Austin Appleby License: BSD-2-clause Comment: original comes from nginx-1.20.2/src/core/ngx_murmurhash.c only rename the function name by the upstream author. > > Here is my suggestion: > > Description: P2P de-centralized layer 3 VPN > OpenGNB is a de-centralized virtual private network (VPN) to set-up a > layer 3 network via P2P with the capability of NAT traversal. > . > OpenGNB can add many nodes and LANs together into one big VPN. > OpenGNB supports public index nodes to forward net packages. > . > opengnb support the following platforms: > Linux, FreeBSD, OpenBSD, and macOS. > . > OpenGNB uses UDP by default. With the software gnb_udp_over_tcp > installed it can also use TCP. > Updated. Uploaded to: https://mentors.debian.net/package/opengnb/ Thanks! -- 肖盛文 xiao sheng wen Faris Xiao 微信(wechat)：atzlinux 《铜豌豆 Linux》https://www.atzlinux.com 基于 Debian 的 Linux 中文 桌面 操作系统 Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com GnuPG Public Key: 0x00186602339240CB OpenPGP_signature Description: OpenPGP digital signature
Bug#1010242: RFS: opengnb/1.2.8.7-1 [ITP] -- via P2P to setup de-centralized layer3 network VPN
Am 26.05.22 um 13:28 schrieb xiao sheng wen(肖盛文): For murmurhash, you would have to find the original version to really know that it is public-domain. The nginx version has a copyright statement but I could find murmurhash v2 implementations that are public domain. However, I did not find the nginx version elsewhere quickly. I use apt source nginx to get the source code in sid, I find the original version. I compared the libs/hash/murmurhash.c and nginx-1.20.2/src/core/ngx_murmurhash.c, only the function name is different. This file use BSD-2-clause, it said by nginx d/copyright. I update the infos for this file: Files: libs/hash/murmurhash.c Copyright: Copyright (C) Austin Appleby License: BSD-2-clause Comment: original comes from nginx-1.20.2/src/core/ngx_murmurhash.c only rename the function name by the upstream author. https://github.com/nginx/nginx/commit/42f1e1cb96b510d1fa1abad99a5294a37b750d99 introduced this. There is no license info attached to it. The Debian package most probably just thought it inherits nginx's license. That might be wrong. Therefore, I suggested to find the original, which should be some other place than nginx. https://github.com/aappleby/smhasher/blob/master/src/MurmurHash2.cpp has some versions of this hash, and https://github.com/aappleby/smhasher/blob/master/README.md says "All MurmurHash versions are public domain software, and the author disclaims all copyright to their code." You can cite that in the comment and mark it public-domain again. Plus points: File a bug on Debian's nginx pkg which notifies them that src/core/ngx_murmurhash.c and debian/modules/http-ndk/src/hash/murmurhash2.c are actually public domain and misrepresented in their d/copyright.
Bug#1010663: RFS: strawberry/1.0.4-1 [ITP] -- Audio player and music collection organizer
Control: tags 1010663 - moreinfo
On 18/05/2022 11:03, Jeroen Ploemen wrote:
Control: tags -1 moreinfo
On Fri, 6 May 2022 13:11:37 +0100
Peter wrote:
I am looking for a sponsor for my package "strawberry":
hi Peter,
like pollo, I'm puzzled by the mention on the ITP bug of the package
being in NEW at some point, only to vanish into thin air? Would be
nice to know what happened to it, if only to avoid running into the
same problems. Maybe Thomas would like to chime in on this?
That said, I took a look anyway. Some comments and observations:
- There's an unused manpage in the debian dir, an apparent leftover
from the earlier packaging effort
- Copyright:
* missing copyright holder "Pascal Below" (for various
scrobbler-related files)
* missing info for 3rdparty/macdeployqt
* wrong license for 3rdparty/SPMediaKeyTap
* is upstream the sole contributor to the debian packaging?
* MIT and Expat license definitions appear identical, please use
Expat as the license name throughout and remove the duplicate
* the content of the license paragraphs for GPL-3 and GPL-3+ is
identical (but obviously shouldn't be)
* be careful to exclude copyright claims, comments, etc. from the
license paragraphs; i.e. make the definitions for the BSD-style
licenses start at "Redistribution and use..." so they're generic
and re-usable; everything else belongs in the Files paragraphs
- Control:
* short description shouldn't start with caps
* hardcoded libsqlite3-0 library dependency should be handled by
${shlibs:Depends} (libqt5sql5-sqlite is only recommended by the
qt sql lib so that one might actually be justified)
* a slightly newer standards-version out has come out recently
* VCS: consider setting up a git repo on salsa.debian.org for your
packaging work and enabling the CI there: it's a great quality
control and collaboration tool, and a real timesaver for reviewers
too
- Docs: upstream changelog installed as doc rather than as changelog
(via dh_installchangelogs)
- Rules: better list those files in d/clean instead of using an
override
- Upstream/metadata: is a github user page -even that of the lead
developer- really the best place to contact the upstream project?
- Watch: unused dversionmangling
- Build: why -fpermissive?
- FHS: according to its manpage, the tagreader binary "is not meant to
be run on its own"; is /usr/bin really where it should be installed?
See https://www.debian.org/doc/packaging-manuals/fhs/ (libexec?)
- Lintian:
* I: strawberry: desktop-entry-lacks-keywords-entry
usr/share/applications/org.strawberrymusicplayer.strawberry.desktop
- Tests: upstream ships a testsuite; if possible, please run it on
build and/or deploy it as an autopkgtest
Please remove the moreinfo tag (and CC me directly) once you have an
updated package ready.
Hi Jeroen,
Thanks for your review.
I have implemented your suggestions (except testsuite & VCS) and uploaded to
Mentors.
I cannot get the test suite to build. Also, as strawberry is an interactive GUI,
the scope for autopkgtest style tests seems restricted.
However, it would be helpful for me to be able to run formal tests locally,
so I intend to raise the issue upstream.
I don't have privilege to set up repositories on Salsa, but would like to have
one to run CI.
Could someone create an empty repository for strawberry under debian group?
Cheers,
Peter B
Bug#1010663: RFS: strawberry/1.0.4-1 [ITP] -- Audio player and music collection organizer
On Thu, 26 May 2022 15:22:09 +0100 Peter wrote: > >> I am looking for a sponsor for my package "strawberry": > I don't have privilege to set up repositories on Salsa, but would > like to have one to run CI. Could someone create an empty > repository for strawberry under debian group? I've just created https://salsa.debian.org/debian/strawberry and granted your account maintainer level access. Once you got that up and running with the CI I'll take another look at the package. pgpcsc9O7VNc8.pgp Description: OpenPGP digital signature
Bug#1010242: RFS: opengnb/1.2.8.7-1 [ITP] -- via P2P to setup de-centralized layer3 network VPN
Hi Bastian, Thanks for your investigate for murmurhash license. 在 2022/5/26 22:23, Bastian Germann 写道: > > https://github.com/nginx/nginx/commit/42f1e1cb96b510d1fa1abad99a5294a37b750d99 > > introduced this. There is no license info attached to it. > > The Debian package most probably just thought it inherits nginx's > license. > That might be wrong. Therefore, I suggested to find the original, > which should be some other place than nginx. > > https://github.com/aappleby/smhasher/blob/master/src/MurmurHash2.cpp > has some versions of this hash, and > https://github.com/aappleby/smhasher/blob/master/README.md > says "All MurmurHash versions are public domain software, and the > author disclaims all copyright to their code." > > You can cite that in the comment and mark it public-domain again. Yes, updated. Files: libs/hash/murmurhash.c Copyright: Austin Appleby License: Public-Domain Comment: https://github.com/aappleby/smhasher/blob/master/README.md says "All MurmurHash versions are public domain software, and the author disclaims all copyright to their code." Uploaded to: https://mentors.debian.net/package/opengnb/ > > Plus points: File a bug on Debian's nginx pkg which notifies them that > src/core/ngx_murmurhash.c and > debian/modules/http-ndk/src/hash/murmurhash2.c > are actually public domain and misrepresented in their d/copyright. I'll bugreport in tomorrow. Thanks! -- 肖盛文 xiao sheng wen Faris Xiao 微信(wechat)：atzlinux 《铜豌豆 Linux》https://www.atzlinux.com 基于 Debian 的 Linux 中文 桌面 操作系统 Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com GnuPG Public Key: 0x00186602339240CB OpenPGP_signature Description: OpenPGP digital signature
Few questions about updating the dia package
Hello, I'm trying to adopt and update the dia package, as my first contribution to Debian packaging. I managed to update the package to the current upstream version (not the easiest thing: the project moved from autotools to meson since the last package update) and fix some lintian issues. I think the package is almost ready for upload, but I have the following warnings when I build the package, and I don't know how to fix them: - dpkg-shlibdeps: warning: can't extract name and version from library name 'libdia.so' dia builds a shared library libdia.so, to be used only by the dia binary. By default meson installs it in /usr/lib/x86_64-linux-gnu/, but lintian isn't happy about it (wrong library name, ldconfig isn't called, etc). If I understand correctly, since libdia.so is not meant to be used by other software, it has to go /usr/lib/x86_64-linux-gnu/dia/, and that's how it's done with the dia package currently in Debian repositories. I had to patch the meson scripts and adjust some rpath settings to make it work, but now I have this warning... - W: dia source: debian-rules-sets-DEB_BUILD_OPTIONS (line 10) Parallel builds may cause a build error with dia (a header file isn't found). To disable parallel builds, I added in d/rules: export DEB_BUILD_OPTIONS = parallel=1 lintian says I should rename DEB_BUILD_OPTIONS to DEB_BUILD_MAINT_OPTIONS, but when I add parallel=1 to DEB_BUILD_MAINT_OPTIONS, the parallel=1 instruction is ignored... - W: dia-dbgsym: elf-error In program headers: Unable to find program interpreter name [usr/lib/debug/.build-id/82/7909d9da4f9c6253d5235a76b6fe4513c8ebf7.debug] I don't even know how to start investigating on this warning since the mentioned file doesn't exist once the package is built... Can you give me some hints? I use the following Git repository for the package: https://salsa.debian.org/phsw/dia (btw shouldn't it go under the debian namespace instead of mine?). Any review of the package is welcome! :) Philippe.
Bug#1010242: RFS: opengnb/1.2.8.7-1 [ITP] -- via P2P to setup de-centralized layer3 network VPN
在 2022/5/27 01:03, xiao sheng wen(肖盛文) 写道: > Hi Bastian, > > Thanks for your investigate for murmurhash license. > > 在 2022/5/26 22:23, Bastian Germann 写道: >> Plus points: File a bug on Debian's nginx pkg which notifies them that >> src/core/ngx_murmurhash.c and >> debian/modules/http-ndk/src/hash/murmurhash2.c >> are actually public domain and misrepresented in their d/copyright. > I'll bugreport in tomorrow. reported. please see: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1011936 > > > Thanks! > -- 肖盛文 xiao sheng wen Faris Xiao 微信(wechat)：atzlinux 《铜豌豆 Linux》https://www.atzlinux.com 基于 Debian 的 Linux 中文 桌面 操作系统 Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com GnuPG Public Key: 0x00186602339240CB OpenPGP_signature Description: OpenPGP digital signature
Re: Few questions about updating the dia package
On Thu, May 26, 2022 at 11:31:22PM +0200, Philippe SWARTVAGHER wrote: > - dpkg-shlibdeps: warning: can't extract name and version from library > name 'libdia.so' I think you can ignore these. > - W: dia source: debian-rules-sets-DEB_BUILD_OPTIONS (line 10) > > Parallel builds may cause a build error with dia (a header file isn't > found). To disable parallel builds, I added in d/rules: > > export DEB_BUILD_OPTIONS = parallel=1 > > lintian says I should rename DEB_BUILD_OPTIONS to > DEB_BUILD_MAINT_OPTIONS, but when I add parallel=1 to > DEB_BUILD_MAINT_OPTIONS, the parallel=1 instruction is ignored... You should pass --no-parallel to dh(1) instead. > - W: dia-dbgsym: elf-error In program headers: Unable to find program > interpreter name > [usr/lib/debug/.build-id/82/7909d9da4f9c6253d5235a76b6fe4513c8ebf7.debug] > > I don't even know how to start investigating on this warning since the > mentioned file doesn't exist once the package is built... This is a lintian false positive. -- WBR, wRAR signature.asc Description: PGP signature
