Re: RFS: self-serve photo booth software
On Sun, May 24, 2015 at 04:24:19AM +, Adam Roses Wight wrote: * Not sure why the copyright file is not linting. In the documentation, I see that repeated licenses only need to be specified once. [2] There are three files with the same license, and I only give the standalone paragraph for the third. The second file causes a lint warning! Possibly a bug in the lintian job? [2] https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#stand-alone-license-paragraph Solved by reading the lintian source. To reuse a license, it must be declared as a License: short-name and full text, but with no Files. I think the docs at [2] should be updated to mention this fact. -a -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20150524045515.gb14...@ludd.net
Re: RFS: self-serve photo booth software
A few more small questions, otherwise the photo-booth package is ready for another review. [1] Thanks for all the help so far! * The package name has changed since I filed the ITP bug. How can I update the bug with a new package name, should I just reply with a human-readable note to that effect? * I accidentally ran dput without a host argument, which pushed my package files to the production upload box. I've sent some commands to dcut rm, hopefully that works correctly. It looks like the commands were consumed with no effect on the photo-booth* files. * Not sure why the copyright file is not linting. In the documentation, I see that repeated licenses only need to be specified once. [2] There are three files with the same license, and I only give the standalone paragraph for the third. The second file causes a lint warning! Possibly a bug in the lintian job? -Adam [1] http://mentors.debian.net/package/photo-booth [2] https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#stand-alone-license-paragraph On Tue, May 19, 2015 at 10:07:00AM +0800, Paul Wise wrote: Also, is it standard procedure to upload locally built packages to mentors.d.n, or is that not necessary if I already have hosting for the files? [4] mentors does not distribute binary packages, which is what you have uploaded to github. Some sponsors are fine interacting with random git trees but others like to use the Debian source package (.dsc), which you haven't uploaded anywhere. Personally I'd suggest uploading the source package to mentors. -- bye, pabs https://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/CAKTje6Gua8ao9B+XcF8Af1PfzCCNF+gvmHk8Q1e7snmFtu=f...@mail.gmail.com -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20150524042419.ga14...@ludd.net
Re: RFS: self-serve photo booth software
I see it's not recommended to include a debian/ directory in my upstream source control [1]. What's the best practice for hosting Debian packaging files? Should I request a new repo on Alioth, fork my upstream, and add the debian dir on a branch? [2, 3] Also, is it standard procedure to upload locally built packages to mentors.d.n, or is that not necessary if I already have hosting for the files? [4] Thanks, Adam [1] https://wiki.debian.org/DebianMentorsFaq#What.27s_wrong_with_upstream_shipping_a_debian.2F_directory.3F [2] http://anonscm.debian.org/cgit/debian-science/packages/opencv.git/tree/ [3] https://alioth.debian.org/register/ [4] https://github.com/adamwight/photo-booth/releases On Tue, May 12, 2015 at 09:06:22AM +, Adam Roses Wight wrote: On Sun, Apr 19, 2015 at 05:20:43PM +0800, Paul Wise wrote: i18n would definitely be a good idea, I'd suggest using gettext. I slogged through the gettext support, noticing too late that QT comes with its own i18n library. If my ad-hoc gettext integration eventually rabbitholes, I might try that instead: http://www.cmake.org/Wiki/CMake:How_To_Build_Qt4_Software#Translations None of the files appear to have copyright/license information: http://lu.is/blog/2012/03/17/on-the-importance-of-per-file-license-information/ I think it's unlikely that any file would be taken out of this project in isolation, so I'll assume the top-level LICENSE is obvious enough for now. $ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open any of the paths given.' [sound.hpp:40]: (error) Mismatching allocation and deallocation: buf That was a real memory leak, fantastic! I think I worked through all your other points, looking forward to the next iteration. Thanks, Adam -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20150512090622.ga31...@ludd.net -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20150519010023.ga28...@ludd.net
Re: RFS: self-serve photo booth software
On Sun, Apr 19, 2015 at 05:20:43PM +0800, Paul Wise wrote: i18n would definitely be a good idea, I'd suggest using gettext. I slogged through the gettext support, noticing too late that QT comes with its own i18n library. If my ad-hoc gettext integration eventually rabbitholes, I might try that instead: http://www.cmake.org/Wiki/CMake:How_To_Build_Qt4_Software#Translations None of the files appear to have copyright/license information: http://lu.is/blog/2012/03/17/on-the-importance-of-per-file-license-information/ I think it's unlikely that any file would be taken out of this project in isolation, so I'll assume the top-level LICENSE is obvious enough for now. $ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open any of the paths given.' [sound.hpp:40]: (error) Mismatching allocation and deallocation: buf That was a real memory leak, fantastic! I think I worked through all your other points, looking forward to the next iteration. Thanks, Adam -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20150512090622.ga31...@ludd.net
RFS: self-serve photo booth software
Dear comrades, https://github.com/adamwight/booths I've written a photo booth application based on OpenCV, which uses motion detection to trigger a 4-up sequence of snapshots. The UI is pretty nice, and doesn't require any input devices aside from the camera. The code and configuration are robust, and simple to extend if desired. A couple people have contacted me about running the software, but compiling an OpenCV app is not for the faint of heart, so I recently produced a few .deb packages for various platforms: https://github.com/adamwight/booths/releases I'd like help refining this package, to reach a wider audience. It seems to be the simplest entry in this niche. Open issues: * I'm leaning towards GPL-v3.0, any reason to reconsider this? * Need to finish i18n of the interface text. * Sound effects are pulled in by the makefile, and belong to http://www.trekcore.com/audio/ -- I don't know if this is fair use or not. * Debian metadata and documentation are crude, please suggest improvements. Thank you in advance! Adam -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20150419080346.gd27...@ludd.net
Re: RFS: self-serve photo booth software
Hi pabs, Thanks for the thorough first review! I'll work on these suggestions and respond here with the next release candidate. -Adam -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20150419162452.ga9...@ludd.net
