Re: Request for voluntary package reviews
On Sun, Nov 07, 2010 at 09:23:53PM +0100, Michael Tautschnig wrote: Hi Alexandre, [...] (review by chrysn and comments) i couldn't test the functionality itself for lack of midi hardware, but at least that's reflected by appropriate warnings by midish. I was mostly concerned by any packaging mistakes, but testing the code itself never hurts :-) The package includes regression tests - would it make sense to run these at build time, or would that only make sense if a MIDI device was present? I tried to run them and all of them passed, but I don't really know if this is just trivially true as I don't have MIDI hardware. If it makes sense to run them even without MIDI hardware, please include a make check run in future releases of your package. Indeed these tests require no midi hardware. They are mostly useful to developpers but running them can't hurt ;) I'll include them in the next version of the package. Thanks for your comments, the new package is on the usual place: http://mentors.debian.net/debian/pool/main/m/midish Thanks to the review by chrysn it was pretty easy to do another final review; I have now built and uploaded your package. For future versions, please take the following into consideration: - As said above, a regression test would of course be nice to have. - In line with [1] you might consider acknowleding reviews such as chrysn's as those help in speeding up the sponsoring process. - You require a compat level of 7, so you could also make use of the much simplified rules file made possible by debhelper 7. See [2] for further information. Thanks for the review and for uploading the package. I just got a notification that the package fails to build on kfreebsd, I guess the kfreebsd has clock_gettime() in librt. Fixing these issues... -- Alexandre -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101108174518.gx5...@moule.localdomain
Re: Request for voluntary package reviews
On Sun, Oct 31, 2010 at 12:03:27AM +0200, chrysn wrote: concerning the midish package: i've had a look at the midish package mentioned in [1]. it seems to be packaged in a reasonable way. the only potential issue i've spottet is that Willem van Engen, co-author of mdep_alsa.c, is mentioned in the file's copyright section, but not in debian/copyright; Oops. Now Willem in the debian/copyright file also, Samuel Mimram did the earlier packaging, he might deserve being mentioned in debian/copyright as well, unless 0.3.0-1 was a complete re-packaging, in which case that should be stated in the changelog. Yes, 1.0.4-1 is a complete repackaging because many things changed (the upstream build process, standards, alsa support, ...). I added the corresponding line in the changelog (on the minor end of the severity scale, one might suggest to upstream to keep source code, man pages and examples in appropriate sub-directories, but that's probably just a matter of style.) i couldn't test the functionality itself for lack of midi hardware, but at least that's reflected by appropriate warnings by midish. I was mostly concerned by any packaging mistakes, but testing the code itself never hurts :-) Thanks for your comments, the new package is on the usual place: http://mentors.debian.net/debian/pool/main/m/midish cheers, -- Alexandre -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101031120631.gc15...@moule.localdomain
Re: RFS: midish update
On Thu, Aug 19, 2010 at 08:53:14PM +0200, Alexandre Ratchov wrote: Hi all, I'm looking for a sponsor to verify and upload the new 1.0.3-1 version of midish. It builds a single package: midish - shell-like MIDI sequencer/filter The package is lintian clean, and available here: - http://mentors.debian.net/debian/pool/main/m/midish - deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/m/midish/midish_1.0.3-1.dsc I got no comments on this package so far. The current package is more than 3 years old and a lot of bugs and usability issues were fixed since then. And as we're at it I've just updated the package to the new 1.0.4 release. cheers, -- Alexandre -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101030121441.ga15...@moule.localdomain
RFS: midish update
Hi all, I'm looking for a sponsor to verify and upload the new 1.0.3-1 version of midish. It builds a single package: midish - shell-like MIDI sequencer/filter The package is lintian clean, and available here: - http://mentors.debian.net/debian/pool/main/m/midish - deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/m/midish/midish_1.0.3-1.dsc cheers, -- Alexandre -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100819185314.ge21...@moule.localdomain
