Bug#799498: RFS: neko/2.0.0-4
-I/usr/include/apr-1.0 cgi.c > > > ui.c: In function 'ui_main': > ui.c:151:2: warning: 'g_thread_init' is deprecated > [-Wdeprecated-declarations] > g_thread_init(NULL); > > > the last one can be fixed with a > // g_thread_init has been deprecated since version 2.32 and should not be > used in newly-written code. This function is no longer necessary. The GLib > threading system is automatically initialized at the start of your program. > #if !(GLIB_CHECK_VERSION(2,32,0)) > g_thread_init(NULL); > #endif > > > block I guess > > (I'm not asking you to fix the above, but I would appreciate if you can > forward them upstream :) > > cheers, > > G. > > Il Giovedì 24 Settembre 2015 12:51, Andy Li <a...@onthewings.net> ha > scritto: > > > > Hi Gianfranco, > > > Thanks for the review! > Good idea about using the *FLAGS env vars. I've updated the patch to use > those and will also propose the change to upstream. > I've also added back -Wall as suggested. > The package has just been reuploaded to mentors. > > Best regards, > Andy > > > > > On Thu, Sep 24, 2015 at 5:54 PM, Gianfranco Costamagna < > costamagnagianfra...@yahoo.it> wrote: > > Hi Andy, > > > > > > > >the packaging looks good. > > > >I did two builds with DH_VERBOSE=1 in a sid chroot > >(the unstable and mentors versions) > > > >I did a meld between them, and I see some "issues" > > > >-"Wall" flag has disappeared > > > >(I guess not a real problem here :) ) > > > > > >- many lines are like this one > >gcc -O3 -DEAPI -fPIC -pthread $(pkg-config --cflags apr-1) -pthread > $(dpkg-buildflags --get CFLAGS) -c -I../../vm -I/usr/include/mysql mysql.c > > > >evaluating $(dpkg-buildflags --get CFLAGS) at each file build (and link, > the same is for LDFLAGS) is somewhat an overkill. > > > >I see they come from debian/patches/harden.patch, > >just as TODO you might ask upstream to use *FLAGS from the environment, > and drop that patch. > > > > > >but we are nitpicking here :) > > > >So if you can readd the -Wall flag I guess we are fine there :) > > > >cheers, > > > >G. > > >
Bug#799498: RFS: neko/2.0.0-4
Hi Gianfranco, Thanks for the review! Good idea about using the *FLAGS env vars. I've updated the patch to use those and will also propose the change to upstream. I've also added back -Wall as suggested. The package has just been reuploaded to mentors. Best regards, Andy On Thu, Sep 24, 2015 at 5:54 PM, Gianfranco Costamagna < costamagnagianfra...@yahoo.it> wrote: > Hi Andy, > > > > the packaging looks good. > > I did two builds with DH_VERBOSE=1 in a sid chroot > (the unstable and mentors versions) > > I did a meld between them, and I see some "issues" > > -"Wall" flag has disappeared > > (I guess not a real problem here :) ) > > > - many lines are like this one > gcc -O3 -DEAPI -fPIC -pthread $(pkg-config --cflags apr-1) -pthread > $(dpkg-buildflags --get CFLAGS) -c -I../../vm -I/usr/include/mysql mysql.c > > evaluating $(dpkg-buildflags --get CFLAGS) at each file build (and link, > the same is for LDFLAGS) is somewhat an overkill. > > I see they come from debian/patches/harden.patch, > just as TODO you might ask upstream to use *FLAGS from the environment, > and drop that patch. > > > but we are nitpicking here :) > > So if you can readd the -Wall flag I guess we are fine there :) > > cheers, > > G. >
Bug#799498: RFS: neko/2.0.0-4
Hi Gianfranco, Thanks for the review! > 1) please bump debhelper and compat level to 9 > (bonus points for converting the package to multiarch) > I've bumped those to 9. For multiarch, I will address that in the next upstream version since there are quite some changes needed. > 2) please drop useless build-dependencies (such as quilt and maybe some > others, e.g. pkg-config?) > I dropped quilt. The others including pkg-config are actually used during the build. > 3) rules file, can you please convert in plain dh_ calls? > Done. I've reuploaded the package to mentors. Please let me know if there is any other problem. Best regards, Andy
Bug#799498: RFS: neko/2.0.0-4
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "neko". I'm a member of the Haxe Foundation. I would like to maintain the package in the long term to improve haxe's debian support. * Package name: neko Version : 2.0.0-4 Upstream Author : Haxe Foundation * URL : http://nekovm.org/ * License : MIT Section : interpreters It builds those binary packages: libapache2-mod-neko - Apache module for running server-side Neko programs libneko0 - Lightweight virtual machine - shared library neko - Lightweight virtual machine - compiler and tools neko-dev - Lightweight virtual machine - headers To access further information about this package, please visit the following URL: http://mentors.debian.net/package/neko Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/n/neko/neko_2.0.0-4.dsc Changes since the last upload: * Adopt package (Closes: #628939). + Set maintainer to myself. * Set Vcs-* fields to Haxe Foundation neko-debian git repo. * Bump Standards-Version to 3.9.6 (no changes). Regards, Andy Li
Bug#799092: RFS: haxe/1:3.2.0+dfsg-1
Hi Vincent,
I've saved a copy of git-archive-all in debian directory and updated
copyright accordingly.
The package has been reuploaded to mentors.
Thank you!
Best regards,
Andy
On Fri, Sep 18, 2015 at 3:57 PM, Vincent Bernat <ber...@debian.org> wrote:
> ❦ 17 septembre 2015 19:17 +0800, Andy Li <a...@onthewings.net> :
>
> > I've revised the package and reuploaded.
>
> In d/rules, get-orig-source is using "curl | python". I am a bit
> uncomfortable with that. I had a quick look at this Python script and it
> should be replacable by something like that:
>
> #+BEGIN_SRC sh
> (
> git ls-files
> git submodule --quiet foreach \
>--recursive 'git ls-files --with-tree=${sha1} | sed
> s+^+${path}/+'
> ) | while read f; do
> [[ -d $f ]] || echo $f
> done | tar -zcf orig.tar.gz -T -
> #+END_SRC
>
> If not, it would be better to retrieve the script and place it in the
> debian/ directory (and update d/copyright).
>
> > I'm not very sure about the lintian hardening warnings. Lintian didn't
> > report those to me when I build the package, maybe because I have a
> > different environment than yours? I've added a lintian-override file
> > anyway.
>
> I am using "lintian -viI". Not everything needs an override (notably
> stuff with "I"). Your override worked fine.
>
> I don't see any additional problem with your packaging.
> --
> Debian package sponsoring guidelines:
> http://vincent.bernat.im/en/debian-package-sponsoring.html
>
Bug#799092: RFS: haxe/1:3.2.0+dfsg-1
Hi Gabriele, thanks for accepting my adoption! Hi Vincent, thanks for the review! I've revised the package and reuploaded. I'm not very sure about the lintian hardening warnings. Lintian didn't report those to me when I build the package, maybe because I have a different environment than yours? I've added a lintian-override file anyway. Please let me know if there is any other problem. Best regards, Andy On Wed, Sep 16, 2015 at 7:32 PM, Vincent Bernat <ber...@debian.org> wrote: > ❦ 16 septembre 2015 03:46 +0800, Andy Li <a...@onthewings.net> : > > > * Package name : haxe > > Version : 1:3.2.0+dfsg-1 > > Upstream Author : Haxe Foundation<cont...@haxe.org> > > * URL : http://haxe.org/ > > * License : GPLv2+, MIT, LGPLv2+ > > Section : devel > > [...] > > - d/control: in the short description, drop the "A" article. > > - d/watch: please, keep it, just to check if the package is up-to-date > > - d/rules: get-orig-source can do anything needed to retrieve the > appropriate source tarball, including not using uscan; see: > https://wiki.debian.org/onlyjob/get-orig-source > > - d/rules: bash-completions should be installed to > /usr/share/bash-completion/completions; there is an helper > for that (dh_bash-completion), see its manual page > > - d/changelog: please, add the bug number for the adoption request > > - d/changelog: ensure you wrap the lines to 80 characters > > - d/copyright: LGPL is Lesser General Public License (not Lesser Public > License); GPL-3+ paragraph is also unused > > I am not familiar with OCaml stuff. Lintian complains about hardening, > but I suppose this makes little sense with OCaml. In this case, please, > use a lintian override. > > I: haxe: hardening-no-fortify-functions usr/bin/haxelib > W: haxe: hardening-no-relro usr/bin/haxe > -- > Debian package sponsoring guidelines: > http://vincent.bernat.im/en/debian-package-sponsoring.html >
Bug#799092: RFS: haxe/1:3.2.0+dfsg-1
Package: sponsorship-requests Severity: normal [important for RC bugs, wishlist for new packages] Dear mentors, I am looking for a sponsor for my package "haxe". I'm a member of the Haxe Foundation. I would like to maintain the package in the long term to improve haxe's debian support. * Package name: haxe Version : 1:3.2.0+dfsg-1 Upstream Author : Haxe Foundation<cont...@haxe.org> * URL : http://haxe.org/ * License : GPLv2+, MIT, LGPLv2+ Section : devel It builds those binary packages: haxe - A multi-target universal programming language To access further information about this package, please visit the following URL: http://mentors.debian.net/package/haxe Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/h/haxe/haxe_3.2.0+dfsg-1.dsc Changes since the last upload: haxe (1:3.2.0+dfsg-1) unstable; urgency=low * Adopt package. + Set maintainer to myself. * New upstream version. + Update neko version dependency. * Remove outdated and discontinued emacs haxe mode. * Clean up copyright. + Remove entries of removed files. * Remove d/watch and get-orig-source target because the archive at Github is missing submodules. -- Andy Li <a...@onthewings.net> Wed, 26 Aug 2015 15:01:06 +0800 Regards, Andy Li
