Bug#859778: [supp...@mentors.debian.net: xtrs uploaded to mentors.debian.net]

[G. Branden Robinson]

At 2017-07-27T13:50:53-0700, Sean Whitton wrote:
> Hello Branden,
> 
> On Thu, Jun 15, 2017 at 04:35:23PM +0100, Sean Whitton wrote:
> > Please accept my apologies for letting this RFS sit for so long.  Thank
> > you for all your work.  Looking forward to uploading it soon.
> > 
> > Here's a full review of dc84e1861798b3aba0969e2fe81a2431f2ee17de:
> 
> Any progress on this?

Hi Sean,

Not much, as I've had a few distractions lately.  However, I do hope to
be able to make some progress on these items this coming week at
DebConf.  Not sure if you were aware, but I'll be there.  Since I see
your name in the keysigning-party keyring, I hope to meet you in person.

Looking forward to it!

Regards,
Branden


signature.asc
Description: PGP signature

Bug#859778: [supp...@mentors.debian.net: xtrs uploaded to mentors.debian.net]

[G. Branden Robinson]

package sponsorship-requests
tag 859778 - moreinfo
thanks

$ dput mentors xtrs_4.9d-1_amd64.changes 
Checking signature on .changes
gpg: /home/branden/src/GIT/debian/xtrs_4.9d-1_amd64.changes: Valid signature 
from D19E9C7D71266DCE
Checking signature on .dsc
gpg: /home/branden/src/GIT/debian/xtrs_4.9d-1.dsc: Valid signature from 
D19E9C7D71266DCE
Uploading to mentors (via http to mentors.debian.net):
  Uploading xtrs_4.9d-1.dsc: done.
  Uploading xtrs_4.9d.orig.tar.gz: done.
  Uploading xtrs_4.9d-1.debian.tar.xz: done.  
  Uploading xtrs-dbgsym_4.9d-1_amd64.deb: done.
  Uploading xtrs_4.9d-1_amd64.buildinfo: done.
  Uploading xtrs_4.9d-1_amd64.deb: done.
  Uploading xtrs_4.9d-1_amd64.changes: done.
Successfully uploaded packages.

- Forwarded message from "mentors.debian.net"  
-

Date: Thu,  1 Jun 2017 21:11:41 + (UTC)
From: "mentors.debian.net" 
To: g.branden.robin...@gmail.com
Subject: xtrs uploaded to mentors.debian.net

Hi.

Your upload of the package 'xtrs' to mentors.debian.net was
successful. Others can now see it. The URL of your package is:
https://mentors.debian.net/package/xtrs

The respective dsc file can be found at:
https://mentors.debian.net/debian/pool/contrib/x/xtrs/xtrs_4.9d-1.dsc

If you do not yet have a sponsor for your package you may want to go to
https://mentors.debian.net/sponsors/rfs-howto/xtrs
and set the "Seeking a sponsor" option to highlight your package on the
welcome page.

You can also send an RFS (request for sponsorship) to the debian-mentors
mailing list. Your package page will give your suggestions on how to
send that mail.

Good luck in finding a sponsor!

Thanks,

-- 
mentors.debian.net

- End forwarded message -

Regards,
Branden


signature.asc
Description: PGP signature

Bug#859778: RFS: xtrs/4.9d-3

[G. Branden Robinson]

At 2017-04-22T16:04:25-0700, Sean Whitton wrote:
> > Can you explain your reasoning here?
> 
> Currently, almost all Debian packagers/maintainers use one changelog
> entry and version number per upload.  So if there are rounds of review
> in an RFS, new changes are folded into the previous changelog entry.
> 
> My concern is simply that it could be misleading to break this
> convention.  Someone might think that there were -1, -2 and -3 uploads
> to the archive.
> 
> Jumping straight to -3 could also be confusing, so it would probably be
> best to merge the changes in -3 and -2 into -1.
> 
> The actual history of development is available from the git history,
> which I will push to https://browse.dgit.debian.org/ as part of the
> upload.  So we're not throwing away any information.
> 
> I guess that the older practice of using a new version number for each
> round of review is due to the difficulties created by exchanging raw
> source packages.  But we are using git.
> 

Okay.  This makes sense.  I'll coalesce the changelog and release
history.

Regards,
Branden


signature.asc
Description: PGP signature

Bug#859778: RFS: xtrs/4.9d-3

[G. Branden Robinson]

At 2017-04-22T15:41:48-0400, G. Branden Robinson wrote:
> > Given this problem I haven't done a full review, but I'd like to make
> > two preliminary suggestions:
> > 
> > 1) How about merging the -1, -2 and -3~~unreleased changelog entries
> > into a single entry, since we're doing a single upload?
> 
> Won't that prompt the question of what happened to -1 and -2?
> 
> Or do you mean renumber -3 as -1?  And move the git tags?
> 
> > 2) You have made a very large number of changes to the upstream source
> > by means of debian/patches.  How about separating the changelog into two
> > sections, something like this:
> > 
> > Debian packaging changes:
> > * Migrate to new (to me) quilt-based Debian source format 3.0.
> >   + Migrate former contents of debian/patches to debian/patch/*; 
> > dropping
> > patches now merged upstream.
> > [...]
> > 
> > Debian patches to upstream source:
> > * Makefile: Observe LDFLAGS when building internal "compile_rom" tool.
> >   Thanks to Graham Inggs for the discussion!  (Closes: #859751)
> > [...]

Hmm, did you notice that:

1) Almost all the changes to upstream code are in release -3?
and
2) Almost all the changes to packaging are in releases -1 and -2?

So, to be clear, you're asking me to coalesce all the changelog entries
since 4.9c together and then split them up in a different way, which
less accurately reflects the actual history of recent development?

Can you explain your reasoning here?

Regards,
Branden

Bug#859778: RFS: xtrs/4.9d-3

[G. Branden Robinson]

At 2017-04-22T07:13:38-0700, Sean Whitton wrote:
> control: tag -1 +moreinfo
> 
> Hello Branden,
> 
> I can't get 79e8ccf40499ace8cf36210a7ad9fb157209bbe4 to build.  Log
> attached.

Urp.  This is due to the unavailabilty of gropdf on the build host, it
looks like.  I'll investigate.

> Given this problem I haven't done a full review, but I'd like to make
> two preliminary suggestions:
> 
> 1) How about merging the -1, -2 and -3~~unreleased changelog entries
> into a single entry, since we're doing a single upload?

Won't that prompt the question of what happened to -1 and -2?

Or do you mean renumber -3 as -1?  And move the git tags?

> 2) You have made a very large number of changes to the upstream source
> by means of debian/patches.  How about separating the changelog into two
> sections, something like this:
> 
> Debian packaging changes:
> * Migrate to new (to me) quilt-based Debian source format 3.0.
>   + Migrate former contents of debian/patches to debian/patch/*; dropping
> patches now merged upstream.
> [...]
> 
> Debian patches to upstream source:
> * Makefile: Observe LDFLAGS when building internal "compile_rom" tool.
>   Thanks to Graham Inggs for the discussion!  (Closes: #859751)
> [...]
> 
> Also, could you confirm that your changes have been forwarded upstream?

Yes, I emailed some of them to Tim Mann on 3 April, and the rest on 17
April.  I think there were some cosmetic changes to the man pages after
that.

> If you're able to address the issues I've raised in this message, please
> remove the moreinfo tag in this bug, and don't forget to re-run `dch -r`
> to refresh the changelog timestamp.

Will do.

Regards,
Branden


signature.asc
Description: PGP signature

Bug#859778: RFS: xtrs/4.9d-2

[G. Branden Robinson]

At 2017-04-20T15:58:04-0700, Sean Whitton wrote:
> Please remove the moreinfo tag from the bug when it's ready to be
> uploaded.

Will do!

Regards,
Branden


signature.asc
Description: PGP signature

Bug#859778: RFS: xtrs/4.9d-2

[G. Branden Robinson]

At 2017-04-20T09:45:13-0700, Sean Whitton wrote:
> Hello Branden,

Hi Sean!

> On Wed, Apr 12, 2017 at 11:09:45PM -0400, G. Branden Robinson wrote:
> > Yeah, I didn't understand that at the time.  Subsequently I changed all
> > the 4.9d changelog entries to target experimental.
> > 
> > > Thus, it'd be better to target the new version at experimental instead
> > > (or refrain from updates for now -- but that goes against "release
> > > early, release often" and makes debdiffs far harder to read).
> > 
> > It sounds like I should maybe just forget about -2 and upload -3.  I had
> > one more thing I wanted to do for it but it's a big task, rather
> > involved, and not required.
> 
> What is the status of this RFS?  Are you still working on the upload to
> experimental?

Sure am.  In fact I have xtrs 4.9d-3 pretty much ready to go except for
the official versioning and tagging.  I've also been in touch with
upstream; he's been working on an xtrs 5.0 for quite some time.  :)

See attachments.  I've also pushed my work to alioth.

-- 
Regards,
Branden
Format: 3.0 (quilt)
Source: xtrs
Binary: xtrs
Architecture: any
Version: 4.9d-3~~unreleased
Maintainer: G. Branden Robinson <g.branden.robin...@gmail.com>
Homepage: http://www.tim-mann.org/xtrs.html
Standards-Version: 3.9.8
Build-Depends: bsdmainutils, debhelper (>= 9), groff-base, html2text, 
libreadline-dev, libx11-dev, po-debconf
Package-List:
 xtrs deb contrib/otherosfs extra arch=any
Checksums-Sha1:
 42b1fc90246901456d29071421e838b545f39f0f 99 xtrs_4.9d.orig.tar.gz
 a346107dc33d28e66e440590edeb63c1e35fe679 100156 
xtrs_4.9d-3~~unreleased.debian.tar.xz
Checksums-Sha256:
 3985f2331e76198dfc027bc2afcd09a158d2bcad0348aeb4a4958a8fb99cf5c4 99 
xtrs_4.9d.orig.tar.gz
 702129c437c486a6b98d75b54ff1561aff16b1e59b96189e44c6c9a31a873163 100156 
xtrs_4.9d-3~~unreleased.debian.tar.xz
Files:
 93868bed769c038bfae907375316bb2d 99 xtrs_4.9d.orig.tar.gz
 f89963f7dc0155dd23eeb65f9d4d3f23 100156 xtrs_4.9d-3~~unreleased.debian.tar.xz
 dpkg-buildpackage -rfakeroot -us -uc
dpkg-buildpackage: info: source package xtrs
dpkg-buildpackage: info: source version 4.9d-3~~unreleased
dpkg-buildpackage: info: source distribution experimental
dpkg-buildpackage: info: source changed by G. Branden Robinson 
<g.branden.robin...@gmail.com>
 dpkg-source --before-build xtrs
dpkg-buildpackage: info: host architecture amd64
dpkg-source: info: applying prep-makefiles-for-debian.patch
dpkg-source: info: applying fix-compiler-warnings.patch
dpkg-source: info: applying ignore-alt-key-events.patch
dpkg-source: info: applying add-ifdef-guards-around-setuid.patch
dpkg-source: info: applying stop-ignoring-result-from-fread.patch
dpkg-source: info: applying make-plain-text-docs-from-html.patch
dpkg-source: info: applying debian-stop-clobbering-cflags-and-ldflags.patch
dpkg-source: info: applying mkdisk-document-d-option-in-usage-message.patch
dpkg-source: info: applying stop-mkdisk-from-overflowing-buffers.patch
dpkg-source: info: applying mkdisk-check-fopen-return-with-dmk-images.patch
dpkg-source: info: applying mkdisk-protect-against-overwrites.patch
dpkg-source: info: applying this-one-goes-to-c11.patch
dpkg-source: info: applying hex2cmd-idiomatize-manpage.patch
dpkg-source: info: applying cmddump-idiomatize-manpage.patch
dpkg-source: info: applying cassette-idiomatize-manpage.patch
dpkg-source: info: applying debian-cassette-manpage-del-paragraph.patch
dpkg-source: info: applying mkdisk-idiomatize-manpage.patch
dpkg-source: info: applying xtrs-idiomatize-manpage.patch
dpkg-source: info: applying makefile-generate-pdf-manpages.patch
dpkg-source: info: applying emtsafe-flag-on-by-default.patch
dpkg-source: info: applying write-online-help-to-stderr-if-small-window.patch
dpkg-source: info: applying kill-last-fprintf-stderr-stragglers.patch
 fakeroot debian/rules clean
dh clean
   dh_testdir
   dh_auto_clean
make -j1 clean
make[1]: Entering directory '/home/branden/git/debian/xtrs'
rm -f z80.o main.o load_cmd.o load_hex.o trs_memory.o trs_keyboard.o error.o 
debug.o dis.o trs_io.o trs_cassette.o trs_xinterface.o trs_chars.o 
trs_printer.o trs_rom1.o trs_rom3.o trs_rom4p.o trs_disk.o trs_interrupt.o 
trs_imp_exp.o trs_hard.o trs_uart.o mkdisk.o compile_rom.o error.o load_cmd.o 
load_hex.o cmd.o error.o load_hex.o hex2cmd.o \
cmddump.o load_cmd.o trs_rom*.c *~ \
xtrs mkdisk hex2cmd cmddump compile_rom \
cpmutil.txt dskspec.txt
make[1]: Leaving directory '/home/branden/git/debian/xtrs'
   dh_clean
rm -f debian/debhelper-build-stamp
rm -f debian/xtrs.substvars
rm -f debian/xtrs.*.debhelper
rm -rf debian/xtrs/
rm -rf debian/.debhelper/
rm -f debian/*.debhelper.log
rm -f debian/files
rm -f -- debian/copyright-info.actual debian/no-copyright-info.actual
find .  \( 

Bug#859778: RFS: xtrs/4.9d-2

[G. Branden Robinson]

At 2017-04-12T22:49:51+0200, Adam Borowski wrote:
> On Wed, Apr 12, 2017 at 12:28:11PM -0400, G. Branden Robinson wrote:
> > I think I got it fixed.
> > 
> > The URL of my package is:
> > https://mentors.debian.net/package/xtrs
> > 
> > The respective dsc file can be found at:
> > https://mentors.debian.net/debian/pool/contrib/x/xtrs/xtrs_4.9d-2.dsc
> 
> Cool, got it.
> 
> The package looks good to me, albeit I did only a quite cursory
> review.
> 
> From the technical point of view, I've so far noticed only one issue:
> the changelog lost the entry for 4.9c-4; even though changes done
> there have been reimplemented, it would confuse BTS version tracking
> somewhat.  Could you please insert that entry back?

It's already merged in in what will become 4.9d-3.  See attached
changelog.

> However, you try to put into unstable a lot of changes not targetted at
> Stretch.  That's a pretty bad idea even for a leaf package -- in case
> there's a need for an update (not unlikely after an upload a mere week ago),
> using testing-proposed-updates is burdensome and doesn't work well.

Yeah, I didn't understand that at the time.  Subsequently I changed all
the 4.9d changelog entries to target experimental.

> Thus, it'd be better to target the new version at experimental instead
> (or refrain from updates for now -- but that goes against "release
> early, release often" and makes debdiffs far harder to read).

It sounds like I should maybe just forget about -2 and upload -3.  I had
one more thing I wanted to do for it but it's a big task, rather
involved, and not required.

-- 
Regards,
Branden
xtrs (4.9d-3~~unreleased) experimental; urgency=medium

  * mkdisk.c: Fix buffer overflow when given filename >8 characters.  Truncate
filename by default when copying to hard disk image.  Add -S ("spill")
flag to partially simulate old behavior.  Exit with error if filename
argument would overflow even the subsequent structure member historically
used by xtrs to store extra filename characters.
+ mkdisk.man: Document -S flag and related issues.
+ test-mkdisk.sh: Add tests for overflow and new filename truncation and
  spillage logic.
+ Makefile: Add "check" target to run the foregoing test.  Nothing
  upstream calls this target automatically.
  * mkdisk.c: Check return value of fopen() when creating DMK disk image file.
  * mkdisk.c: Refuse to clobber files by default.  Add -f ("force") flag to
override this behavior.
+ mkdisk.man: Document new behavior and -f flag.
+ test-mkdisk.sh: Test default no-clobber and -f flag behavior.
  * mkdisk.c: Document the -d option for hard disk images in usage message.
  * Makefile: Observe LDFLAGS when building internal "compile_rom" tool.
Thanks to Graham Inggs for the discussion!  (Closes: #859751)
  * Port to C11 and build with -std=c11.

 -- G. Branden Robinson <g.branden.robin...@gmail.com>  Sun, 09 Apr 2017 
15:34:01 -0400

xtrs (4.9d-2) experimental; urgency=medium

  * Export Debian build flags to environment.  Executables are now hardened
per < https://wiki.debian.org/Hardening >.
  * Add Turkish debconf template translations; thanks, Mert Dirik!
(Closes: #757864)
  * Add Dutch debconf template translations; thanks, Frans Spiesschaert!
(Closes: #767488)
  * Add Indonesian debconf template translations; thanks, Izharul Haq!
(Closes: #835622)

 -- G. Branden Robinson <g.branden.robin...@gmail.com>  Sun, 26 Mar 2017 
22:17:39 -0400

xtrs (4.9d-1) experimental; urgency=medium

  * Merge new upstream release.
+ "Deleted all SIGIO code.  The code was a kludge to begin with and it no
  longer worked with current X libraries and Linux kernels, causing xtrs
  to hang.  It was also reported to cause hangs when xtrs was compiled for
  Windows using Cygwin.  Thanks to Howard Pepper, Dennis Lovelady, Arumin
  Nueckel, Christopher Currie, and Joe Peterson for bug reports."
  (Closes: #511645)
  * Update README.Debian to refresh URLs and reflect developments in the
TRS-80 retrocomputing enthusiast community over the past several years.
  * Implement debian/compare-copyright script.
+ Add "check-source" target to debian/rules to call the script.
+ Add debian/{no-,}copyright-info.expected files.
  * Migrate former contents of debian/checklist to debian/README.source.
  * Rewrite debian/copyright using machine-readable copyright info.
  * Migrate to new (to me) quilt-based Debian source format 3.0.
+ Migrate former contents of debian/patches to debian/patch/*; dropping
  patches now merged upstream.
  * Migrate former contents of debian/README.contrib-only to Disclaimer field
of debian/copyright, and update discussion.
  * Stop shipping Tim Mann's TRS-80 FAQ document.  It's great, but strictly
s

Bug#859778: RFS: xtrs/4.9d-2

[G. Branden Robinson]

I think I got it fixed.

The URL of my package is:
https://mentors.debian.net/package/xtrs

The respective dsc file can be found at:
https://mentors.debian.net/debian/pool/contrib/x/xtrs/xtrs_4.9d-2.dsc

##lftp mentors.debian.net:/debian/pool/contrib/x/xtrs> ls
drwxr-xr-x  --  ..
-rw-r--r-- 433K  2017-04-01 02:48  xtrs_4.9c.orig.tar.gz
-rw-r--r--  30K  2017-04-12 16:19  xtrs_4.9d-2.debian.tar.xz
-rw-r--r-- 1.8K  2017-04-12 16:19  xtrs_4.9d-2.dsc
-rw-r--r-- 434K  2017-04-12 16:19  xtrs_4.9d.orig.tar.gz

At 2017-04-12T17:39:54+0200, Adam Borowski wrote:
> On Wed, Apr 12, 2017 at 10:20:55AM -0400, G. Branden Robinson wrote:
> > Hrm #1: GMail helpfully categorized your mail as spam.
> 
> Not nice, let's try again; if you don't respond in a day I'll send
> from some other place.

It's fixed.  I told GMail you're not a spammer.  :)

-- 
Regards,
Branden


signature.asc
Description: PGP signature

Bug#859778: RFS: xtrs/4.9d-2

[G. Branden Robinson]

At 2017-04-07T15:23:19+0200, Adam Borowski wrote:
> On Fri, Apr 07, 2017 at 07:41:51AM -0400, G. Branden Robinson wrote:
> > * Package name: xtrs
> >   Version : 4.9d-2
> 
> > https://mentors.debian.net/package/xtrs
> > dget -x 
> > https://mentors.debian.net/debian/pool/contrib/x/xtrs/xtrs_4.9d-2.dsc
> 
> I'm afraid these URLs are 404-compliant.  Am I missing something?

Hrm #1: GMail helpfully categorized your mail as spam.

Hrm #2: Apparently I forgot the correct sponsorship-request procedure.

$ dput mentors xtrs_4.9d-2_amd64.changes
Package has already been uploaded to mentors on mentors.debian.net
Nothing more to do for xtrs_4.9d-2_amd64.changes

lftp mentors.debian.net and then "ls" returns no results.

How do I find my upload after I've uploaded it?

Regards,
Branden


signature.asc
Description: PGP signature

Bug#859778: RFS: xtrs/4.9d-2

[G. Branden Robinson]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I seek a sponsor for my package "xtrs".

* Package name: xtrs
  Version : 4.9d-2
  Upstream Author : Tim Mann
* URL : http://www.tim-mann.org/xtrs.html
* License : 2 different custom permissive licenses
  Section : otherosfs

It builds these binary packages:

xtrs  - emulator for TRS-80 Model I/III/4/4P computers

To access further information about this package, please visit the
following URL:

https://mentors.debian.net/package/xtrs

Alternatively, one can download the package with dget using this
command:

dget -x 
https://mentors.debian.net/debian/pool/contrib/x/xtrs/xtrs_4.9d-2.dsc

Changes since the last upload:

  * Export Debian build flags to environment.  Executables are now hardened
per < https://wiki.debian.org/Hardening >.
  * Add Turkish debconf template translations; thanks, Mert Dirik!
(Closes: #757864)
  * Add Dutch debconf template translations; thanks, Frans Spiesschaert!
(Closes: #767488)
  * Add Indonesian debconf template translations; thanks, Izharul Haq!
(Closes: #835622)

Regards,
Branden

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Bug#858800: RFS: xtrs/4.9d-1 [ITA]

[G. Branden Robinson]

At 2017-03-31T18:39:23-0700, Sean Whitton wrote:
> control: owner -1 !
> 
> Hello Branden,
> 
> On Fri, Mar 31, 2017 at 07:40:51PM -0400, G. Branden Robinson wrote:
> > I've reuploaded 4.9c-4.
> 
> I can't find this on mentors...  As I said, an e-mailed debdiff would
> be fine at this point.

I accidentally uploaded to ftp-master instead, by not giving dput a
hostname argument.  I tried again; see attachment.

A debdiff *.dsc of the last NMU and this version is also attached.

> > Please find attached two files which were not dput, which you may wish
> > to peruse for QA purposes:
> 
> Thank you for these!

My pleasure!

Regards,
Branden
Successfully uploaded xtrs_4.9c-4.dsc to mentors.debian.net for mentors.
Successfully uploaded xtrs_4.9c-4.diff.gz to mentors.debian.net for mentors.
Successfully uploaded xtrs-dbgsym_4.9c-4_amd64.deb to mentors.debian.net for 
mentors.
Successfully uploaded xtrs_4.9c-4_amd64.buildinfo to mentors.debian.net for 
mentors.
Successfully uploaded xtrs_4.9c-4_amd64.deb to mentors.debian.net for mentors.
Successfully uploaded xtrs_4.9c-4_amd64.changes to mentors.debian.net for 
mentors.
diff -u xtrs-4.9c/debian/changelog xtrs-4.9c/debian/changelog
--- xtrs-4.9c/debian/changelog
+++ xtrs-4.9c/debian/changelog
@@ -1,3 +1,11 @@
+xtrs (4.9c-4) unstable; urgency=medium
+
+  * Makefile: Undefine HAVE_SIGIO.  (Closes: #511645)
+  * Update Maintainer full name and email address from the "old me" to the
+"new me".
+
+ -- G. Branden Robinson <g.branden.robin...@gmail.com>  Thu, 30 Mar 2017 09:20:32 -0400
+
 xtrs (4.9c-3.5) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -u xtrs-4.9c/debian/control xtrs-4.9c/debian/control
--- xtrs-4.9c/debian/control
+++ xtrs-4.9c/debian/control
@@ -1,7 +1,7 @@
 Source: xtrs
 Section: contrib/otherosfs
 Priority: extra
-Maintainer: Branden Robinson <bran...@debian.org>
+Maintainer: G. Branden Robinson <g.branden.robin...@gmail.com>
 Build-Depends: libncurses5-dev, libreadline-dev, libx11-dev, groff, debhelper (>= 5), po-debconf, html2text
 Standards-Version: 3.7.3
 
diff -u xtrs-4.9c/debian/patches xtrs-4.9c/debian/patches
--- xtrs-4.9c/debian/patches
+++ xtrs-4.9c/debian/patches
@@ -236,0 +237,11 @@
+--- Makefile.orig	2017-03-30 09:17:41.055300129 -0400
 Makefile	2017-03-30 09:17:48.455224512 -0400
+@@ -143,7 +143,7 @@
+ include Makefile.local
+ 
+ CFLAGS = $(DEBUG) $(ENDIAN) $(DEFAULT_ROM) $(READLINE) $(DISKDIR) $(IFLAGS) \
+-   $(APPDEFAULTS) -DKBWAIT -DHAVE_SIGIO
++   $(APPDEFAULTS) -DKBWAIT
+ LIBS = $(XLIB) $(READLINELIBS) $(EXTRALIBS)
+ 
+ ZMACFLAGS = -h
only in patch2:
unchanged:
--- xtrs-4.9c.orig/Makefile
+++ xtrs-4.9c/Makefile
@@ -143,7 +143,7 @@
 include Makefile.local
 
 CFLAGS = $(DEBUG) $(ENDIAN) $(DEFAULT_ROM) $(READLINE) $(DISKDIR) $(IFLAGS) \
-   $(APPDEFAULTS) -DKBWAIT -DHAVE_SIGIO
+   $(APPDEFAULTS) -DKBWAIT
 LIBS = $(XLIB) $(READLINELIBS) $(EXTRALIBS)
 
 ZMACFLAGS = -h


signature.asc
Description: PGP signature

Bug#858800: RFS: xtrs/4.9d-1 [ITA]

[G. Branden Robinson]

At 2017-03-29T12:59:12-0700, Sean Whitton wrote:
> Hello Branden,
> 
> On Tue, Mar 28, 2017 at 08:29:38PM -0400, G. Branden Robinson wrote:
> > > On Tue, Mar 28, 2017 at 05:28:25PM -0400, G. Branden Robinson wrote:
> > > > So my goals were, in this order:
> > > > 1) Get the package suitable for unstable (which it wasn't); then
> > > > 2) Get the package suitable for testing.
> >
> > It'll be suitable for testing for Buster, that's for sure.  My bad luck
> > to return during a release freeze.
> 
> Right.  But your wording ("then") suggested that (2) could be done
> exclusively of (1).

It can.  I've uploaded xtrs 4.9c-4 with a far leaner set of changes, and
am attaching a diff of the diff to this message.  As you can see, it's
far leaner.

Thoughts?

> > I'm interested in the least-effort solution (for other people) that
> > doesn't involve shipping a badly broken package in Stretch.
> 
> Well, letting it drop out of testing is technically the least-effort
> solution.

Right.  What's the next-least-effort solution?  :)

Regards,
Branden
--- xtrs_4.9c-3.5.diff	2017-03-30 09:25:15.053347227 -0400
+++ xtrs_4.9c-4.diff	2017-03-30 09:25:15.053347227 -0400
@@ -1,3 +1,14 @@
+--- xtrs-4.9c.orig/Makefile
 xtrs-4.9c/Makefile
+@@ -143,7 +143,7 @@
+ include Makefile.local
+ 
+ CFLAGS = $(DEBUG) $(ENDIAN) $(DEFAULT_ROM) $(READLINE) $(DISKDIR) $(IFLAGS) \
+-   $(APPDEFAULTS) -DKBWAIT -DHAVE_SIGIO
++   $(APPDEFAULTS) -DKBWAIT
+ LIBS = $(XLIB) $(READLINELIBS) $(EXTRALIBS)
+ 
+ ZMACFLAGS = -h
 --- xtrs-4.9c.orig/Makefile.local
 +++ xtrs-4.9c/Makefile.local
 @@ -50,7 +50,7 @@
@@ -363,7 +374,15 @@
 +vim:set ai et ts=4 sw=4 tw=80:
 --- xtrs-4.9c.orig/debian/changelog
 +++ xtrs-4.9c/debian/changelog
-@@ -0,0 +1,627 @@
+@@ -0,0 +1,635 @@
++xtrs (4.9c-4) unstable; urgency=medium
++
++  * Makefile: Undefine HAVE_SIGIO.  (Closes: #511645)
++  * Update Maintainer full name and email address from the "old me" to the
++"new me".
++
++ -- G. Branden Robinson <g.branden.robin...@gmail.com>  Thu, 30 Mar 2017 09:20:32 -0400
++
 +xtrs (4.9c-3.5) unstable; urgency=medium
 +
 +  * Non-maintainer upload.
@@ -1036,8 +1055,8 @@
 +Source: xtrs
 +Section: contrib/otherosfs
 +Priority: extra
-+Maintainer: Branden Robinson <bran...@debian.org>
-+Build-Depends: libncurses5-dev, libreadline-dev, libx11-dev, groff, debhelper (>= 5), po-debconf, html2text
++Maintainer: G. Branden Robinson <g.branden.robin...@gmail.com>
++Build-Depends: libncurses5-dev, libreadline-dev, libx11-dev, groff-base, debhelper (>= 5), po-debconf, html2text
 +Standards-Version: 3.7.3
 +
 +Package: xtrs
@@ -1132,7 +1151,7 @@
 +  command="/usr/bin/xtrs"
 --- xtrs-4.9c.orig/debian/patches
 +++ xtrs-4.9c/debian/patches
-@@ -0,0 +1,236 @@
+@@ -0,0 +1,247 @@
 +--- cassette.man~
  cassette.man
 +@@ -15,13 +15,6 @@
@@ -1369,6 +1388,17 @@
 + 
 + # If you want to debug the emulator, use the -g flag instead:
 + 
++--- Makefile.orig	2017-03-30 09:17:41.055300129 -0400
+ Makefile	2017-03-30 09:17:48.455224512 -0400
++@@ -143,7 +143,7 @@
++ include Makefile.local
++ 
++ CFLAGS = $(DEBUG) $(ENDIAN) $(DEFAULT_ROM) $(READLINE) $(DISKDIR) $(IFLAGS) \
++-   $(APPDEFAULTS) -DKBWAIT -DHAVE_SIGIO
+++   $(APPDEFAULTS) -DKBWAIT
++ LIBS = $(XLIB) $(READLINELIBS) $(EXTRALIBS)
++ 
++ ZMACFLAGS = -h
 --- xtrs-4.9c.orig/debian/po/POTFILES.in
 +++ xtrs-4.9c/debian/po/POTFILES.in
 @@ -0,0 +1 @@


signature.asc
Description: PGP signature

Bug#858800: RFS: xtrs/4.9d-1 [ITA]

[G. Branden Robinson]

On Tue, Mar 28, 2017 at 05:16:21PM -0700, Sean Whitton wrote:
> Hello Branden,
> 
> On Tue, Mar 28, 2017 at 05:28:25PM -0400, G. Branden Robinson wrote:
> > > You are very unlikely to get release team approval for this upload as it
> > > stands.  Given what you wrote in #511645, is your intention for xtrs to
> > > drop out of stretch, to be reintroduced in buster?
> > 
> > I've been making conservative (pessimistic) estimates about how fast I'd
> > be getting things done since I'm freshly back to the project after a
> > long absence.  There were and are best practices I need(ed) to get
> > caught up on.  I also couldn't be absolutely sure I'd get a sponsor
> > before the removal-from-testing date (scheduled for 11 April); I don't
> > know when I'll be able to get my new GPG key into the Debian keyring so
> > that I can upload under my own power[1], and so forth.  Finally, I don't
> > want to cause the release team any trouble.
> > 
> > So my goals were, in this order:
> > 1) Get the package suitable for unstable (which it wasn't); then
> > 2) Get the package suitable for testing.
> 
> Generally speaking, something shouldn't go into unstable unless it would
> also be suitable for testing (once deps and r-deps are also ready to
> migrate).

It'll be suitable for testing for Buster, that's for sure.  My bad luck
to return during a release freeze.

I'm interested in the least-effort solution (for other people) that
doesn't involve shipping a badly broken package in Stretch.

-- 
Regards,
Branden


signature.asc
Description: PGP signature

Bug#858800: RFS: xtrs/4.9d-1 [ITA]

[G. Branden Robinson]

On Mon, Mar 27, 2017 at 07:11:10PM -0700, Sean Whitton wrote:
> control: tag -1 +moreinfo

Dummy response to -quiet to test Mutt/GPG configuration.

-- 
Regards,
Branden


signature.asc
Description: PGP signature

Bug#858800: RFS: xtrs/4.9d-1 [ITA]

[G. Branden Robinson]

On Mon, Mar 27, 2017 at 07:11:10PM -0700, Sean Whitton wrote:
> control: tag -1 +moreinfo
> 
> Dear Branden,
> 
> On Sun, Mar 26, 2017 at 06:45:34PM -0400, Branden Robinson wrote:
> > Changes since the last upload:
> > 
> >   * Merge new upstream release.
> > + "Deleted all SIGIO code.  The code was a kludge to begin with and it 
> > no
> >   longer worked with current X libraries and Linux kernels, causing xtrs
> >   to hang.  It was also reported to cause hangs when xtrs was compiled 
> > for
> >   Windows using Cygwin.  Thanks to Howard Pepper, Dennis Lovelady, 
> > Arumin
> >   Nueckel, Christopher Currie, and Joe Peterson for bug reports."
> >   (Closes: #511645)
> 
> Is it impossible to backport this fix to the version currently in
> stretch?

No, likely not impossible.  The crudest fix might be simply to just
#undef SIGIO in Makefile.local.

I will explore this.

> You are very unlikely to get release team approval for this upload as it
> stands.  Given what you wrote in #511645, is your intention for xtrs to
> drop out of stretch, to be reintroduced in buster?

I've been making conservative (pessimistic) estimates about how fast I'd
be getting things done since I'm freshly back to the project after a
long absence.  There were and are best practices I need(ed) to get
caught up on.  I also couldn't be absolutely sure I'd get a sponsor
before the removal-from-testing date (scheduled for 11 April); I don't
know when I'll be able to get my new GPG key into the Debian keyring so
that I can upload under my own power[1], and so forth.  Finally, I don't
want to cause the release team any trouble.

So my goals were, in this order:
1) Get the package suitable for unstable (which it wasn't); then
2) Get the package suitable for testing.

Thanks for following up!

Regards,
Branden

[1] That might take a while; my new key is not in the web of trust.